[jewel][CWM Advanced Edition] PhilZ Touch

[Captain_Throwback]

Any link to that gerrit please
also a twrp fixed recovery

I guess you used all the binaries from stock, which I was trying to avoid to simplify maintenance...

I built it from source with Omni. The TWRP is in my Sense 5 thread. Omni gerrit is at gerrit.omnirom.org I believe.

 

[Phil3759]

I built it from source with Omni. The TWRP is in my Sense 5 thread. Omni gerrit is at gerrit.omnirom.org I believe.

I see thank you

 

[Phil3759]

I built it from source with Omni. The TWRP is in my Sense 5 thread. Omni gerrit is at gerrit.omnirom.org I believe.

Looking at your latest TWRP, you used cm kernel which supports lpm mode
I was trying to use the new stock prebuilt kernel though, which lacks the lpm support and uses, like all HTC kernels, some hacks with custom bins and the init.rc

Anyway, I think it is not worth the effort. Since it works with old 3.x cm kernel, let's keep it
Will update soon

 

[Captain_Throwback]

Looking at your latest TWRP, you used cm kernel which supports lpm mode
I was trying to use the new stock prebuilt kernel though, which lacks the lpm support and uses, like all HTC kernels, some hacks with custom bins and the init.rc

Anyway, I think it is not worth the effort. Since it works with old 3.x cm kernel, let's keep it
Will update soon

I used CM kernel? You sure? I was using the prebuilt kernel from the stock 4.3 update, last time I checked.
How can you tell the difference?

 

[Phil3759]

I used CM kernel? You sure? I was using the prebuilt kernel from the stock 4.3 update, last time I checked.
How can you tell the difference?

Because you said you compiled from sources:
https://github.com/omnirom/android_device_htc_jewel/blob/android-4.4/BoardConfig.mk#L34

Maybe you omitted to say you manually repack on post compile
Now, that you say you are using a prebuilt kernel from 4.3, and I see your init.rc changes I get it better

My missing part is here:

service recovery /sbin/recovery
disabled

Did you try to repack your TWRP with new stock 4.1.xx kernel without modifying anything else? Does it break charger

 

[Captain_Throwback]

Because you said you compiled from sources:
https://github.com/omnirom/android_device_htc_jewel/blob/android-4.4/BoardConfig.mk#L34

Maybe you omitted to say you manually repack on post compile
Now, that you say you are using a prebuilt kernel from 4.3, and I see your init.rc changes I get it better

My missing part is here:


Did you try to repack your TWRP with new stock 4.1.xx kernel without modifying anything else? Does it break charger

I don't manually repack. I just use the prebuilt recovery kernel from the stock 4.3 recovery from HTC. I had no reason to try the 4.1.2 kernel so I didn't. The 4.3 kernel fully supports SELinux so it's preferable.

 

[Phil3759]

I don't manually repack. I just use the prebuilt recovery kernel from the stock 4.3 recovery from HTC. I had no reason to try the 4.1.2 kernel so I didn't. The 4.3 kernel fully supports SELinux so it's preferable.

I think I was not clear enough:
By 4.1 I meant from stock FW-4.13.651.1 firmware, not old 4.1.2 kernel

Anyway, I binary compared your TWRP zImage and I now understand that you used the one from the latest stock FW-4.13.651.1
Thank you for your help
I will merge the needed changes from ramdisk

 

[Phil3759]

Update 6.14.0

This fixes a few bugs but also tries to properly implement the charger animation
It now works properly on HTC One, so hope the same for you

This is not same implementation by @Captain_Throwback because I try to limit the ramdisk changes. Understand that I support above 120 devices now and I must keep maintenance the easiest, if you want to see devices updated in the future. I also must keep track with CyanogenMod upstreams

If it still fails, do not waste your time and mine posting some bull**** like "it doesn't work", "fails"...
Take time to provide details:

1. what happens when phone is turned off and you plug charger (screen flicker, recovery starts, proper charger anim shows...) ?
2. are the animation and charge leds working ?
3. if it charges correctly while it is turned off, what happens if you quickly press power button while off and charging: device reboots, recovery starts or the charge anim is shown?
4. another bug? detail it

Else, do not ever dream for any support as I do not own, never owned and do not plan to buy any HTC device

 

[Magnum_Enforcer]

Update 6.14.0

This fixes a few bugs but also tries to properly implement the charger animation
It now works properly on HTC One, so hope the same for you

This is not same implementation by @Captain_Throwback because I try to limit the ramdisk changes. Understand that I support above 120 devices now and I must keep maintenance the easiest, if you want to see devices updated in the future. I also must keep track with CyanogenMod upstreams

If it still fails, do not waste your time and mine posting some bull**** like "it doesn't work", "fails"...
Take time to provide details:

1. what happens when phone is turned off and you plug charger (screen flicker, recovery starts, proper charger anim shows...) ?
2. are the animation and charge leds working ?
3. if it charges correctly while it is turned off, what happens if you quickly press power button while off and charging: device reboots, recovery starts or the charge anim is shown?
4. another bug? detail it

Else, do not ever dream for any support as I do not own, never owned and do not plan to buy any HTC device

Just installed 6.14.0. Here are my findings:

When the phone is turned off and the phone is plugged up to charge, the phone does charge as it's supposed to. However, the charging animation does not appear. The phone doesn't boot into recovery in this state. The charge LED is working correctly. Quickly pressing the power button while off does nothing-you have to hold the button down for several seconds to power up the phone, at which time the phone boots up the way it should.

 

[Phil3759]

Just installed 6.14.0. Here are my findings:

When the phone is turned off and the phone is plugged up to charge, the phone does charge as it's supposed to. However, the charging animation does not appear. The phone doesn't boot into recovery in this state. The charge LED is working correctly. Quickly pressing the power button while off does nothing-you have to hold the button down for several seconds to power up the phone, at which time the phone boots up the way it should.

Great
The most important is fixed
Will look at charge animation when i have time

 

[Phil3759]

6.15.3 (13.02.2014)

- update superSU to 1.93
- sync sources
- fix recovery reboot command (adb and shell) by adding the init sys.powerctl property control
- merge "Fix mkfs.f2fs calling in roots"
- fix display current path when navigating backward in folders
- Nandroid Simple Logging: toggle logging of file names during nandroid to keep screen progress while speed up nandroid operations for some devices
- increase NICE_INTERVAL to 300 msec (faster backup/restore on some devices)
- hide unused settings in Nandroid Settings menu (if we disable all progress on screen, hide non valid options)
- re-order nandroid settings menu
- add a toggle for fall back to pre-built update-binary to permit use of older update-binary in zip packages (doesn't persist on reboot).
this will fix the assert errors due to outdate update-binary. It could still be affected by assert error on device name getprop. However, that one is easier to fix by end users by editing updater-script. This is a workaround. The best is to hammer your ROM cooker to update his scripts and binaries
- setting for signature check toggle on zip updates will be now saved on reboot
- Aroma File Manager: mount vold managed volumes on launch from recovery
- Free Browse Mode: make it possible to install from any custom path even ramdisk
- Free browse mode: fix exceptions when setting up custom path
- Free browse mode: mount known volumes during setup
- Free browse mode: better handling of /data/media devices
- Free Browse Mode: mount vold managed volumes when navigating in
- HTC One variants (m7): fix charger
- HTC Evo 4G LTE (jewel): fix charger
- HTC Evo 4G LTE (jewel): update to new Sense 5 partition layout (/data/media)
- HTC Evo 4G LTE (jewel): use exfat modules for much faster backup speed to exfat cards
- New: Moto G variants (falcon): xt1028 xt1031 xt1032 xt1033 xt1034
- New: Moto G Google Play Edition (falcon_gpe)
- New: Galaxy Note 8.0 LTE (n5120) support
- New: HP Touch (tenderloin), no touch
- fix potential logging issues
- fix compiler warnings
- clean up code and misc fixes

I added the offline charge images to ramdisk. Seems they are missing even in stock CWM new s4-common device tree
If still fails, I will update the prebuilt binaries included, but hopefully it should be fine

Please let me know when ever you test
This also includes a lot of updates / fixes as in change log

 

[phillymade]

6.15.3 (13.02.2014)



I added the offline charge images to ramdisk. Seems they are missing even in stock CWM new s4-common device tree
If still fails, I will update the prebuilt binaries included, but hopefully it should be fine

Please let me know when ever you test
This also includes a lot of updates / fixes as in change log

I have this installed, will test it out tonight when I get home. I will post my findings for you. Thank you for your attention to this.

 

[Magnum_Enforcer]

Installed the latest version a few minutes ago. Power-off charging animation works, but no percentage is shown. Also appears that the charging animation stays on all the time, instead of the screen going to "sleep" after being plugged in for a couple of minutes. The charging animation "shifts" to different places on the screen after the phone is on the charger for roughly five minutes. Haven't tried making or restoring a backup since my battery is low at the moment. Everything seems okay, otherwise.

 

[Phil3759]

Installed the latest version a few minutes ago. Power-off charging animation works, but no percentage is shown. Also appears that the charging animation stays on all the time, instead of the screen going to "sleep" after being plugged in for a couple of minutes. The charging animation "shifts" to different places on the screen after the phone is on the charger for roughly five minutes. Haven't tried making or restoring or making a backup since my battery is low at the moment. Everything seems okay, otherwise.

Thank you
Seems no way unless cm updates the s4-common tree or i hack it hard during post compile repack
Will look at it later

 

[Magnum_Enforcer]

Ran into another issue this morning when trying to make a backup. When trying to make a backup to either sdcard0 or sdcard1, the recovery can't mount /system. I was trying to backup /boot, /data & /system at the time.

Sent from my EVO LTE

 

[Phil3759]

Ran into another issue this morning when trying to make a backup. When trying to make a backup to either sdcard0 or sdcard1, the recovery can't mount /system. I was trying to backup /boot, /data & /system at the time.

Sent from my EVO LTE

the new version is only for new sense 5 partition layout

 

[Magnum_Enforcer]

the new version is only for new sense 5 partition layout

That's what I'm using it on.

Sent from my EVO LTE

 

[Phil3759]

That's what I'm using it on.

Sent from my EVO LTE

My bad, really sorry
Seems I missed the correct settings in /etc/recovery.fstab

Please, stop using it to avoid any issues

 

[Phil3759]

Ok
I found the issue. I correctly set the fstab, however, the device tree maintainer is using deprecated recovery.fstab file that I did not add a flag to override. Normally it is not needed as it is "always" done on new vold common fstab

Will update you soon with again a few changes to charger

 

[Phil3759]

Update 6.15.6

- fixed fstab for new Sense 5
- small charger changes

I verified the fstab manually to be sure, this version is now safe for Sense 5
If the charger anim issue still persists, I will try the hard way

Just let me know