[KERNEL] CleanSlate v1.7.13 | LED|SqueezeCntrl|Flashlight|AdBlock|WireGuard [25 Sept]

[tbalden]

Really loving your kernel. Has been my daily driver for the entire year 2018.
A few small things, that I noticed on the U11+.
The notification LED blinking while charging only works sometimes, most of the time it just stays on. The great new feature "call off hook vibration" didn't work for me on the U11+, but I am using HTCs ROM feature, that answers a phone call, once you bring up the phone to the ear.
Third thing the USB port fast charging is working, but keeps asking me if I want to use the phone for file transfer after using it for a minute after unlock. It also switches back to regular USB port charging, when I enable USB fast charge, lock the screen and leave the phone alone for a few minutes.
Using Manjaro Linux, just wanted to mention this to give a complete picture, but I suspect this to be a ROM side issue, but maybe you can influence it with the kernel to allow the supply power option to stick?

And one last thing after a clean installation it doesn't seem to recognize the Wi-Fi ap, so the dynamic profile switching based on which network I am using doesn't work. Latest releases of your apps and kernel.

Thanks again for your fantastic work, the issues I mentioned are pretty nitpicky, but I thought to mention them. I know my little text is nothing but words without a log, if you need one let me know. I would attach a last kmsg, but I am currently not rooted and probably using the wrong terminal command. Wish you a nice evening.

Could you please try the vibration with silenced phone?
Wi-Fi is strange. So reconnection to Wi-Fi solves it I guess but when installing fresh on Wi-Fi it's like this, right?

 

[Cryptycat7]

Could you please try the vibration with silenced phone?
Wi-Fi is strange. So reconnection to Wi-Fi solves it I guess but when installing fresh on Wi-Fi it's like this, right?

Turned off my land-line a few weeks ago, so will have to ask a friend to call me, will report back, when I have a result. Not receiving many phone calls at the moment.
Currently I am struggling to get the profile switching to work on my home network, will try from a different Wi-Fi.

 

[tbalden]

Turned off my land-line a few weeks ago, so will have to ask a friend to call me, will report back, when I have a result. Not receiving many phone calls at the moment.
Currently I am struggling to get the profile switching to work on my home network, will try from a different Wi-Fi.

strange about the second one. Thought it's just a temporary issue that is worked around by switching on/off wifi so that the app detects it correctly. So it always displays NULL as the name of the current wifi AP?

 

[Cryptycat7]

strange about the second one. Thought it's just a temporary issue that is worked around by switching on/off wifi so that the app detects it correctly. So it always displays NULL as the name of the current wifi AP?

Yes, but had it working on the exact same network on a previous clean installation.

 

[tbalden]

Yes, but had it working on the exact same network on a previous clean installation.

try this:
Go into the settings page. Connect wifi, then in drawer tap Profile activation page again. Does it refresh to the good AP name?
I have this null there too as long as I don't retap the menu.

 

[Cryptycat7]

try this:
Go into the settings page. Connect wifi, then in drawer tap Profile activation page again. Does it refresh to the good AP name?
I have this null there too as long as I don't retap the menu.

That did the trick, thank you very much. Regarding the quick charging I think Android is the culprit here. It probably just doesn't fully that the kernel supports USB fast charging, just a guess.

 

[tbalden]

That did the trick, thank you very much. Regarding the quick charging I think Android is the culprit here. It probably just doesn't fully that the kernel supports USB fast charging, just a guess.

I see, yeah, easily possible
I'll check the Wi-Fi bug then, should be easy to fix

 

[Cryptycat7]

I see, yeah, easily possible
I'll check the Wi-Fi bug then, should be easy to fix

Thanks again for your help and your continuous work on the kernel. Really makes the difference between a good and an excellent phone. Will tinker around a bit with the USB fast charge, to bad, that google is building more and more barriers into custom development. The USB fast charge would have most likely worked out of the box on lollipop.

 

[tbalden]

I see, yeah, easily possible
I'll check the Wi-Fi bug then, should be easy to fix

Fixed, rolling out on PlayStore. Thanks @Cryptycat7 for reporting :good:

 

[Cryptycat7]

Fixed, rolling out on PlayStore. Thanks @Cryptycat7 for reporting :good:

Thank you very much for the lightning fast fix.
Edit: Tapping the profile activation tab results in a force close of the app. I created a log with the options from the developer options. Uploaded it to Gdrive, hope it has useful information in it. https://drive.google.com/file/d/1IU8caQySx0OZC5q9a7dECkaGgKrnY8UE/view?usp=drivesdk

 

[tbalden]

Thank you very much for the lightning fast fix.
Edit: Tapping the profile activation tab results in a force close of the app. I created a log with the options from the developer options. Uploaded it to Gdrive, hope it has useful information in it. https://drive.google.com/file/d/1IU8caQySx0OZC5q9a7dECkaGgKrnY8UE/view?usp=drivesdk

just noticed your edit, found the exception tracelog, thanks for the bugreport.
Going to check it soon.

org.cleanslate.csconfig, PID: 1522
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.startsWith(java.lang.String)' on a null object reference
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: 	at org.cleanslate.csconfig.MainActivity.pageToProfileActivationSetup(MainActivity.java:343)
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: 	at org.cleanslate.csconfig.MainActivity.access$100(MainActivity.java:69)
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: 	at org.cleanslate.csconfig.MainActivity$19.onMenuItemClick(MainActivity.java:1267)
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: 	at android.support.v7.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:167)
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: 	at android.support.v7.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:973)
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: 	at android.support.design.internal.NavigationMenuPresenter$1.onClick(NavigationMenuPresenter.java:342)
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: 	at android.view.View.performClick(View.java:6256)
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: 	at android.view.View$PerformClick.run(View.java:24779)
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:789)
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:98)
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:180)
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:6950)
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: 	at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
02-14 23:00:16.145 10185  1522  1522 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:835)

 

[tbalden]

Rolling out fix for Profile Activation crash

 

[vegetaleb]

Hello @tbalden, do you know if leedroid is finalising his rom for u11+? You are the only one here to work for this phone

 

[Cryptycat7]

Rolling out fix for Profile Activation crash

I know this would be normally a simple ROM side change, but since I am not sure if this device is going to see any ROMs, I was wondering if this could be done on kernel level.
The 1.24 build changed the color of the status bar from a sleek black with white font to a white tone with grey font, that jumps right into the eye. This change doesn't seem to receive any positive feedback from the community, at least not from what I read.
Would it be possible to invert the color of the navigation bar to black on kernel level? Attached a screenshot really looks weird, especially with a dark keyboard theme applied.

 

[Siminica]

how is the flash blinking on notification supposed to react when a notification is dismissed without unlocking the screen?

I will explain the context (sorry if this behavior is already known): I run whatsapp on my mobile and also on my laptop, when a new message comes if the laptop whatsapp window is not active and I don't see/react to message on laptop in a given amount of time, a phone notification is created so the flashlight starts blinking; I see the blinking and switch to the laptop whatsapp window, read/respond to message and the phone notification is dismissed. In this context the blinking should stop by itself?

same scenario could apply to emails - when I delete them on laptop the corresponding notifications are dismissed

thank you

 

[tbalden]

how is the flash blinking on notification supposed to react when a notification is dismissed without unlocking the screen?

I will explain the context (sorry if this behavior is already known): I run whatsapp on my mobile and also on my laptop, when a new message comes if the laptop whatsapp window is not active and I don't see/react to message on laptop in a given amount of time, a phone notification is created so the flashlight starts blinking; I see the blinking and switch to the laptop whatsapp window, read/respond to message and the phone notification is dismissed. In this context the blinking should stop by itself?

same scenario could apply to emails - when I delete them on laptop the corresponding notifications are dismissed

thank you

Hi,
Answer is two fold:
if the blinking is started by the Notification LED, and that stops blinking then it will stop the flashlight too.
If the notification is gathered from Vibration pattern or by Companion app channeling it, it won't stop until you turn screen on.

 

[Siminica]

Hi,
Answer is two fold:
if the blinking is started by the Notification LED, and that stops blinking then it will stop the flashlight too.
If the notification is gathered from Vibration pattern or by Companion app channeling it, it won't stop until you turn screen on.

uh oh - what will the settings be in your app settings or companion in order to achieve first behavior where flashlight is connected to notification led? (I have the companion app installed)
thank you

 

[tbalden]

I know this would be normally a simple ROM side change, but since I am not sure if this device is going to see any ROMs, I was wondering if this could be done on kernel level.
The 1.24 build changed the color of the status bar from a sleek black with white font to a white tone with grey font, that jumps right into the eye. This change doesn't seem to receive any positive feedback from the community, at least not from what I read.
Would it be possible to invert the color of the navigation bar to black on kernel level? Attached a screenshot really looks weird, especially with a dark keyboard theme applied.

This is typically a ROM thing, not in the kernel domain. Let's hope there'll be some customization for that for u11plus too.

 

[Cryptycat7]

This is typically a ROM thing, not in the kernel domain. Let's hope there'll be some customization for that for u11plus too.

That's what I thought, thanks for clarifying.

 

[tbalden]

uh oh - what will the settings be in your app settings or companion in order to achieve first behavior where flashlight is connected to notification led? (I have the companion app installed)
thank you

If you switch off in companion app the extra notifications, and have no vibration for notifications then it will behave like that.
For now the vibration pattern detection is not optional.
I'll think about making it optional.