[KERNEL][OREO] [SM-T830/T835] [2019-11-21] Modesty 1.0.0 [Linux 4.4.202] [ARK4]

N1NJATH3ORY

Senior Member
Aug 16, 2010
1,046
181
63
Installed...but this kernel kills my bluetooth-connected wireless keyboard (FINTIE)...The keyboard connects but the keys don't work...I thought it was the custom ROMs before but now I think I have isolated the issue to the kernel...

UPDATE: I have restored my TWRP-backed up boot image and voila, my bluetooth keyboard connects and works just fine...
Did you flash libsecure_storage.so ? As you need to flash that otherwise you will have bluetooth issue as you know!
 

BlindDroid

Senior Member
Oct 28, 2013
58
7
0
Love to see some development for SM-T830. Does this kernel support DriveDroid by chance? Apparently it needs "UMS" enabled in the kernel and does not work with the stock Tab S4 kernel.

Thanks!
 

ianmacd

Senior Member
Jan 5, 2016
2,278
3,583
183
Amsterdam
EDIT: Nah, still didn't work...back on Stock kernel and everything works just fine again.
Sorry to hear that. Thanks for the report.

This is a tricky one to debug, since I don't have any problem myself and so it's not a trivial matter to determine when the issue was introduced.

Have you tried any older versions of this kernel? If you have time, it would be useful to try to figure out whether the issue has been present since the beginning. The trouble is, older kernels weren't built for current firmware, so may malfunction just due to the firmware mismatch and not because of a bug as such.

I'll trace through the source control history and see if anything leaps out at me, but it's a bit like looking for a needle in a haystack.

Is anything logged, either when the device is initialised or when it fails to produce input? Please check the dmesg, kmsg and logcat logs for clues. Send them to me, too, alone with a note of the times at which you enabled BlueTooth, tried to use the keyboard, etc.
 
  • Like
Reactions: ALLDAT

ianmacd

Senior Member
Jan 5, 2016
2,278
3,583
183
Amsterdam
Love to see some development for SM-T830. Does this kernel support DriveDroid by chance? Apparently it needs "UMS" enabled in the kernel and does not work with the stock Tab S4 kernel.
Do you just need CONFIG_USB_MASS_STORAGE enabled or anything else? The makers are less than clear about precisely which parts of USB mass storage are required.

I looked at the DriveDroid site and the patches on the XDA thread, but they are ancient. The files they modify don't even exist on modern kernels. Possibly the patches aren't needed nowadays.

If it's just a question of enabling mass storage gadget support, that's trivial and something I can release in the next version.
 

dr460nf1r3

Senior Member
Dec 6, 2013
477
195
73
garudalinux.org
Do you just need CONFIG_USB_MASS_STORAGE enabled or anything else? The makers are less than clear about precisely which parts of USB mass storage are required.

I looked at the DriveDroid site and the patches on the XDA thread, but they are ancient. The files they modify don't even exist on modern kernels. Possibly the patches aren't needed nowadays.

If it's just a question of enabling mass storage gadget support, that's trivial and something I can release in the next version.
I Had drivedroid working Out of The Box using this Kernel.

Sent from my dreamlte using XDA Labs
 

ianmacd

Senior Member
Jan 5, 2016
2,278
3,583
183
Amsterdam
AppLock for the Tab S4.

I don't think this warrants its own thread, so in the absence of a more obvious place, I'm posting it here.

I was missing having a good built-in AppLock for my Tab S4, and the various alternatives available on the Play Store all had at least one major shortcoming or another, so I grabbed the AppLock.apk present in the Chinese firmware — Don't ask me why Samsung thinks only the Chinese need this — wrote an installer for it and packaged it as the ZIP file attached to this posting.

I would have preferred to make this a Magisk module, but I'm afraid there's more to this than simply mounting the package on /system. The configuration file that defines the features available to the currently active CSC needs to be modified.

So, be aware that the attached file will modify your device's file-system, adding one file and replacing another, making a back-up in the process. The installer is also idempotent, which means that repeatedly flashing it will not have unintended consequences.

The installer currently supports the following CSCs: ATO, AUT, BGL, BTU, CAU, DBT, EUR, ITV, LUX, NEE, PHE, PHN, ROM, SEB, SEE, SEK, TPH, XAC, XAR, XEF, XEH, XEO, XEU, XEZ and XSK. Those are the CSCs for which I was able to extract the necessary data from my own native PHN device.

Anyway, if you need a good AppLock, this is for you. It supports PIN- and iris-based unlocking. You can activate it after flashing by going to System → Advanced settings.

Note that the excellent [url="https://play.google.com/store/apps/details?id=com.brit.swiftinstaller]Swift Installer[/url] supports theming of this AppLock and will turn the retina-burning default white into a pleasing AMOLED black. Even if you don't need this AppLock, I heartily recommend Swift Installer to all users of this tablet for darkening its UI.
 

Attachments

BlindDroid

Senior Member
Oct 28, 2013
58
7
0
Do you just need CONFIG_USB_MASS_STORAGE enabled or anything else? The makers are less than clear about precisely which parts of USB mass storage are required.

I looked at the DriveDroid site and the patches on the XDA thread, but they are ancient. The files they modify don't even exist on modern kernels. Possibly the patches aren't needed nowadays.

If it's just a question of enabling mass storage gadget support, that's trivial and something I can release in the next version.
Thanks for replying. I'll try flashing this kernel first as someone reported DriveDroid working out-of-the-box with this kernel. If it doesn't work, maybe you could try enabling UMS in the next update.

Thanks so much.
 

philow

Senior Member
Aug 30, 2007
268
106
0
I don't think this warrants its own thread, so in the absence of a more obvious place, I'm posting it here.

I was missing having a good built-in AppLock for my Tab S4, and the various alternatives available on the Play Store all had at least one major shortcoming or another, so I grabbed the AppLock.apk present in the Chinese firmware — Don't ask me why Samsung thinks only the Chinese need this — wrote an installer for it and packaged it as the ZIP file attached to this posting.

@ianmacd I have the Chinese SM-T835C Hong Kong (TGY). I do not see AppLock on my device. Did you get this from the CHC version of the Chinese model?
 

philow

Senior Member
Aug 30, 2007
268
106
0
Yes, I downloaded the CHC firmware and extracted it from that.

If you have it on TGY, you will find it under /system/app/AppLock.

@ianmacd

I have been holding back on rooting and following all the forums. I have not made up my mind if I will use this tablet for work which will require VMware AirWatch to be installed and it requires Knox. Until I make up my mind I keep looking around ;)

It does not look like TGY has the app. I do not need you to make it for me. But I am wondering if I can flash any other 835 or 835C (CHC) on it without breaking Knox?

Thanks!
 

airmaxx23

Senior Member
Jun 25, 2010
4,673
1,381
243
Colton, NY
I don't think this warrants its own thread, so in the absence of a more obvious place, I'm posting it here.

I was missing having a good built-in AppLock for my Tab S4, and the various alternatives available on the Play Store all had at least one major shortcoming or another, so I grabbed the AppLock.apk present in the Chinese firmware — Don't ask me why Samsung thinks only the Chinese need this — wrote an installer for it and packaged it as the ZIP file attached to this posting.

I would have preferred to make this a Magisk module, but I'm afraid there's more to this than simply mounting the package on /system. The configuration file that defines the features available to the currently active CSC needs to be modified.

So, be aware that the attached file will modify your device's file-system, adding one file and replacing another, making a back-up in the process. The installer is also idempotent, which means that repeatedly flashing it will not have unintended consequences.

The installer currently supports the following CSCs: ATO, AUT, BGL, BTU, CAU, DBT, EUR, ITV, LUX, NEE, PHE, PHN, ROM, SEB, SEE, SEK, TPH, XAC, XAR, XEF, XEH, XEO, XEU, XEZ and XSK. Those are the CSCs for which I was able to extract the necessary data from my own native PHN device.

Anyway, if you need a good AppLock, this is for you. It supports PIN- and iris-based unlocking. You can activate it after flashing by going to System → Advanced settings.

Note that the excellent [url="https://play.google.com/store/apps/details?id=com.brit.swiftinstaller]Swift Installer[/url] supports theming of this AppLock and will turn the retina-burning default white into a pleasing AMOLED black. Even if you don't need this AppLock, I heartily recommend Swift Installer to all users of this tablet for darkening its UI.
I deleted a lot of system apps, do you know which ones are required for this to work?
 

ianmacd

Senior Member
Jan 5, 2016
2,278
3,583
183
Amsterdam
It does not look like TGY has the app. I do not need you to make it for me. But I am wondering if I can flash any other 835 or 835C (CHC) on it without breaking Knox?
No official, unmodified firmware will ever trip Knox.

The only thing you need to take care with is whether the firmware you flash is compatible with your C model, but that should be no problem in the case of CHN.

The AppLock ZIP file I uploaded contains a script called mkzip. That script connects to a Tab S4, pulls the relevant XML feature files for all CSCs supported by the firmware on the device, decodes them, edits them, reencodes them, and finally creates a flashable ZIP for use on any device with one of the supported CSCs.

You could run that script on your own computer and create a flashable ZIP for your own tablet. That would save you from having to install CHC firmware just to obtain AppLock.
 
Last edited:
  • Like
Reactions: ALLDAT and philow

konchog uma

Senior Member
Oct 29, 2013
90
24
0
Running well on my T830 I'm happy to report

Thank you Ian for your work and for how you relate to users here on xda

You're a breath of fresh air... I'd love to send something to support your work but didnt notice any donate button
 
  • Like
Reactions: ianmacd

ianmacd

Senior Member
Jan 5, 2016
2,278
3,583
183
Amsterdam
The gamepad connected via bluetooth was not detected in this core. everything is ok on stock
This is a known problem, I'm afraid. Input data from Bluetooth input devices is not recognised.

The problem requires someone with a Bluetooth input device to check device logs for signs of the issue and, failing that, to try earlier releases of Modesty to determine when the bug was introduced. It may well have been present since the very beginning.
 
  • Like
Reactions: ALLDAT