Actually, it is at a state where it should work, but I will always sync them, there's much work to do and to commit since we are now selinux enforcing.
From 9149b52b2b29fa32274fec7f60c8d0c78c38e3db Mon Sep 17 00:00:00 2001
From: html6405 <[email protected]>
Date: Mon, 9 Nov 2020 16:30:10 +0100
Subject: [PATCH] Fixed libMali ColorFade crash when turning screen off to work
it without low_ram set.
Change-Id: I7e5a6fe89311571c7d98bd27f63977fe00b9cdff
---
.../java/com/android/server/display/ColorFade.java | 12 +++++++++++-
.../android/server/power/PowerManagerService.java | 2 +-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/services/core/java/com/android/server/display/ColorFade.java b/services/core/java/com/android/server/display/ColorFade.java
index 33525fdc52d..e0dc4aa0530 100644
--- a/services/core/java/com/android/server/display/ColorFade.java
+++ b/services/core/java/com/android/server/display/ColorFade.java
@@ -36,6 +36,7 @@ import android.opengl.EGLDisplay;
import android.opengl.EGLSurface;
import android.opengl.GLES20;
import android.opengl.GLES11Ext;
+import android.os.SystemProperties;
import android.util.Slog;
import android.view.DisplayInfo;
import android.view.Surface.OutOfResourcesException;
@@ -71,6 +72,10 @@ final class ColorFade {
// See code for details.
private static final int DEJANK_FRAMES = 3;
+ private static final boolean DESTROY_SURFACE_AFTER_DETACH =
+ SystemProperties.getBoolean("ro.egl.destroy_after_detach", false);
+
+
private final int mDisplayId;
// Set to true when the animation context has been fully prepared.
@@ -330,10 +335,15 @@ final class ColorFade {
destroyScreenshotTexture();
destroyGLShaders();
destroyGLBuffers();
- destroyEglSurface();
+ if (!DESTROY_SURFACE_AFTER_DETACH) {
+ destroyEglSurface();
+ }
} finally {
detachEglContext();
}
+ if (DESTROY_SURFACE_AFTER_DETACH) {
+ destroyEglSurface();
+ }
// This is being called with no active context so shouldn't be
// needed but is safer to not change for now.
GLES20.glFlush();
diff --git a/services/core/java/com/android/server/power/PowerManagerService.java b/services/core/java/com/android/server/power/PowerManagerService.java
index e5458292c0f..bdf3f6e81dc 100644
--- a/services/core/java/com/android/server/power/PowerManagerService.java
+++ b/services/core/java/com/android/server/power/PowerManagerService.java
@@ -123,7 +123,7 @@ public final class PowerManagerService extends SystemService
implements Watchdog.Monitor {
private static final String TAG = "PowerManagerService";
- private static final boolean DEBUG = false;
+ private static final boolean DEBUG = true;
private static final boolean DEBUG_SPEW = DEBUG && true;
// Message: Sent when a user activity timeout occurs to update the power state.
--
2.25.1From 6880875711d850eced8f2911f9ad4d210a9a4337 Mon Sep 17 00:00:00 2001
From: html6405 <[email protected]>
Date: Fri, 20 Nov 2020 17:28:29 +0100
Subject: [PATCH] Included build variable for BOARD_EGL_NEEDS_HANDLE_VALUE.
Change-Id: Ic60409eb8e676a6f05ee67d587acf1bd0476abbc
---
build/soong/android/variable.go | 6 +++++-
build/soong/soong_config.mk | 1 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/build/soong/android/variable.go b/build/soong/android/variable.go
index 41619b82..b2ac836c 100644
--- a/build/soong/android/variable.go
+++ b/build/soong/android/variable.go
@@ -7,8 +7,11 @@ type Product_variables struct {
Cflags []string
}
Egl_workaround_bug_10194508 struct {
- Cppflags []string
+ Cppflags []string
}
+ Egl_needs_handle struct {
+ Cppflags []string
+ }
Bootloader_message_offset struct {
Cflags []string
}
@@ -77,6 +80,7 @@ type ProductVariables struct {
Additional_gralloc_10_usage_bits *string `json:",omitempty"`
Apply_msm8974_1440p_egl_workaround *bool `json:",omitempty"`
Egl_workaround_bug_10194508 *bool `json:",omitempty"`
+ Egl_needs_handle *bool `json:",omitempty"`
Bootloader_message_offset *int `json:",omitempty"`
Has_legacy_camera_hal1 *bool `json:",omitempty"`
Java_Source_Overlays *string `json:",omitempty"`
diff --git a/build/soong/soong_config.mk b/build/soong/soong_config.mk
index 6f18848d..b02f5f4e 100644
--- a/build/soong/soong_config.mk
+++ b/build/soong/soong_config.mk
@@ -5,6 +5,7 @@ _contents := $(_contents) "Lineage":{$(newline)
# See build/core/soong_config.mk for the add_json_* functions you can use here.
$(call add_json_str_omitempty, Additional_gralloc_10_usage_bits, $(TARGET_ADDITIONAL_GRALLOC_10_USAGE_BITS))
+$(call add_json_bool, Egl_needs_handle, $(filter true,$(BOARD_EGL_NEEDS_HANDLE_VALUE)))
$(call add_json_bool, Apply_msm8974_1440p_egl_workaround, $(filter true,$(TARGET_MSM8974_1440P_EGL_WORKAROUND)))
$(call add_json_bool, Egl_workaround_bug_10194508, $(filter true,$(BOARD_EGL_WORKAROUND_BUG_10194508)))
$(call add_json_val_default, Bootloader_message_offset, $(BOOTLOADER_MESSAGE_OFFSET), 0)
--
2.25.1From 5751efcf297385f017737a6fa0dc96151e061ac7 Mon Sep 17 00:00:00 2001
From: html6405 <[email protected]>
Date: Fri, 20 Nov 2020 10:31:40 +0100
Subject: [PATCH] libgui: Don't assign handle to NULL after free is common
Reportedly Mali and PowerVR GPUs are crashing when setting handle to NULL
So we will set a flag for the devices that might need this aswell
Set BOARD_EGL_NEEDS_HANDLE_VALUE=true in BoardConfig.mk to use
Change-Id: I4babdbf051b5e7f59bbf5f5dbe9cb80541355764
---
libs/ui/Android.bp | 3 +++
libs/ui/GraphicBuffer.cpp | 2 ++
2 files changed, 5 insertions(+)
diff --git a/libs/ui/Android.bp b/libs/ui/Android.bp
index 25c353a51..7187adc36 100644
--- a/libs/ui/Android.bp
+++ b/libs/ui/Android.bp
@@ -48,6 +48,9 @@ cc_library_shared {
product_variables: {
lineage: {
+ egl_needs_handle: {
+ cppflags: ["-DEGL_NEEDS_HANDLE"],
+ },
additional_gralloc_10_usage_bits: {
cppflags: ["-DADDNL_GRALLOC_10_USAGE_BITS=%s"],
},
diff --git a/libs/ui/GraphicBuffer.cpp b/libs/ui/GraphicBuffer.cpp
index 7670ac6fb..f10106257 100644
--- a/libs/ui/GraphicBuffer.cpp
+++ b/libs/ui/GraphicBuffer.cpp
@@ -109,7 +109,9 @@ void GraphicBuffer::free_handle()
GraphicBufferAllocator& allocator(GraphicBufferAllocator::get());
allocator.free(handle);
}
+#ifndef EGL_NEEDS_HANDLE
handle = NULL;
+#endif
}
status_t GraphicBuffer::initCheck() const {
--
2.25.1From 80a442dc5493628147d55ded7ae5ed0cf655000b Mon Sep 17 00:00:00 2001
From: html6405 <[email protected]>
Date: Tue, 24 Nov 2020 18:00:49 +0100
Subject: [PATCH] Disable ColorFade in general becaus our LibMali is buggy.
Change-Id: I61f75e28c8db7bdc2718ab497632402797e5e297
---
.../java/com/android/server/display/DisplayPowerController.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/services/core/java/com/android/server/display/DisplayPowerController.java b/services/core/java/com/android/server/display/DisplayPowerController.java
index af4257082de..4d1edef4a65 100644
--- a/services/core/java/com/android/server/display/DisplayPowerController.java
+++ b/services/core/java/com/android/server/display/DisplayPowerController.java
@@ -482,7 +482,7 @@ final class DisplayPowerController implements AutomaticBrightnessController.Call
}
}
- mColorFadeEnabled = !ActivityManager.isLowRamDeviceStatic();
+ mColorFadeEnabled = false;
mColorFadeFadesConfig = resources.getBoolean(
com.android.internal.R.bool.config_animateScreenLights);
--
2.25.1Installed TWRP 3.5.0 and cleared internal storage again. Rebooted the system. No change. Access denied.
Ok, than this could be selinux related, if you could create a complete logging file with syslos app, I will be able to find out which rules are missing.
this problem should exist since the version version.
Ok, this could be selinux related, could you do a logcat when this happens?
Thank you for posting so many updates to my tablet. You have released about 25 updates so far. I am grateful to [email protected]My OTG USB and stuck on boot problems are gone. Thank you!
Hi. I have the same problems as you.
And I have a question from html6405; what's this file: "e-0.15-p-20210329-HTML6405-n8000.zip"?
Have you tested to disable 5GHz, PMF or did a complety fresh installation?
forum.xda-developers.com
Please do a logcat while you are trying this, maybe a sleinux rule is missing.
As already answered in our conversation via PM:
forum.xda-developers.com
Have you tested to disable 5GHz, PMF or did a complety fresh installation?
It also could be a problem if 2,4GHz and 5GHz are sharing the same SSID.
LineageOS 16.0 Android 9 for GT-N8000 GT-N8010 GT-N8013 GT-N8020 FINAL VERSION EOL
/* * Your warranty is now void. * * I am not responsible for bricked devices, dead SD cards, * thermonuclear war, or you getting fired because the alarm app failed. Please * do some research if you have any concerns about features included in...
Please do a logcat while you are trying this, maybe a sleinux rule is missing.
As already answered in our conversation via PM:
Just read the initial post[ROM][9.0][N8000/N801x/N8020][OFFICIAL] /e/
/* * Your warranty is now void. * * I am not responsible for bricked devices, dead SD cards, * thermonuclear war, or you getting fired because the alarm app failed. Please * do some research if you have any concerns about features included in...
Many thanks for response.Have you tested to disable 5GHz, PMF or did a complety fresh installation?
It also could be a problem if 2,4GHz and 5GHz are sharing the same SSID.
LineageOS 16.0 Android 9 for GT-N8000 GT-N8010 GT-N8013 GT-N8020 FINAL VERSION EOL
/* * Your warranty is now void. * * I am not responsible for bricked devices, dead SD cards, * thermonuclear war, or you getting fired because the alarm app failed. Please * do some research if you have any concerns about features included in...
Please do a logcat while you are trying this, maybe a sleinux rule is missing.
As already answered in our conversation via PM:
Just read the initial post.[ROM][9.0][N8000/N801x/N8020][OFFICIAL] /e/
/* * Your warranty is now void. * * I am not responsible for bricked devices, dead SD cards, * thermonuclear war, or you getting fired because the alarm app failed. Please * do some research if you have any concerns about features included in...
.
yeah u gotta install this kernel that @html6405 made
forum.xda-developers.com
oh, i think there was an older version in the thread for gt-n8020 but the headphone jack wasnt working
/*
* Your warranty is now void.
*
* I am not responsible for bricked devices, dead SD cards,
* thermonuclear war, or you getting fired because the alarm app failed. Please
* do some research if you have any concerns about features included in this ROM
* before flashing it! YOU are choosing to make these modifications, and if
* you point the finger at me for messing up your device, I will laugh at you.
*
*/
