[Magisk] [Exynos] Samsung 4k60 Camera Mod | UHD @ 60 FPS | HEVC | 6400 ISO | More

[pipoi9505]

Thx and good job.
Finaly now the module works on Hades rom 5.0 Pie without any problems, the app is always telling me Camera update v9.0.1.0 where i find this update....

 

[little-endian]

That should be coming in a future update

@CvoltonCan you please implent JPG compression options?

At least the settings for edge enhancement and noise reduction apparently can be independently applied with ZeroProbe's mod for now as his mod seems to be effectively patching the file "libexynoscamera.so" only in order to cover these two settings. Due to the lack of any setting in Cvolton's mod here, I guess altering this file is not in scope here. The JPEG data reduction ratio thing probably is trickier because part of the classes.dex within SamsungCamera7.apk, at least this is what is different after using Zeroprobe's mod here and comparing original and patch.
@Cvolton:

First, thanks for providing a very promising alternative to ZeroProbe's mod, however, at least in conjunction with the Note 8 (N950FD), neither yours is flawless:

- [email protected] has more or less stutter (more when using H264, less when using "MPEG-4 Visual")
- whenever attempting to use [email protected], the phone crashes and restarts
- lack of the edge enhancement and noise reduction setting
- lack of JPEG data reduction setting
- limited recording time/size

It would be fantastic if you could address these drawbacks your mod has over Zeroprobe's or - like I already wrote, team up with him and make one great mod altogether.

 

[Cvolton]

At least the settings for edge enhancement and noise reduction apparently can be independently applied with ZeroProbe's mod for now as his mod seems to be effectively patching the file "libexynoscamera.so" only in order to cover these two settings. Due to the lack of any setting in Cvolton's mod here, I guess altering this file is not in scope here. The JPEG data reduction ratio thing probably is trickier because part of the classes.dex within SamsungCamera7.apk, at least this is what is different after using Zeroprobe's mod here and comparing original and patch.

JPEG quality settings have been already added in an update I released a few days ago.

(btw modifying dex is way easier than modifying libexynoscamera)

First, thanks for providing a very promising alternative to ZeroProbe's mod, however, at least in conjunction with the Note 8 (N950FD), neither yours is flawless:

- [email protected] has more or less stutter (more when using H264, less when using "MPEG-4 Visual")

This issue may be caused by your Note 8 underperforming, I've seen a case where the 4k60 mode was only recording 45 FPS because the phone had a hardware issue that caused the CPU to only perform at ~60% speed. I'd suggest you try Antutu or any other benchmark to see if you're getting scores that you should have (circa 210k in Antutu, that person had only 160k).

- whenever attempting to use [email protected], the phone crashes and restarts

This is an odd issue I can't recreate, this may be caused by your ROM + kernel combination.

- lack of the edge enhancement and noise reduction setting

Already addressed, will probably come in a future update. I'll have to introduce a supplemental app for library patching for this probably, as this isn't possible to change just by setting camera parameters.

- lack of JPEG data reduction setting

Already addressed, is present in 3.0.2

- limited recording time/size

Will keep this in mind for future updates, although the FHD 60 and UHD 30 limits have been lifted already and I don't find lifting the 4 GB limit as important, since the recording restarts immediately. This doesn't mean that I'm not going to look into it though.

It would be fantastic if you could address these drawbacks your mod has over Zeroprobe's or - like I already wrote, team up with him and make one great mod altogether.

Sadly, I don't see teaming up with him as a very realistic option, as we have very different approaches for our mods. My mod is more feature focused, while his mod focuses on being very easy to update and so on. He has basically stated in his Telegram group, that he's mostly doing it for profit lately, while my mod exists just because I want to see these features myself.

Overall I'd like to say that I appreciate the feedback and I'll be looking for ways to implement the requested features in future updates.

 

[little-endian]

Many thanks for your elaborate reply, Cvolton.

I indeed had missed the recent, very fortunate update with the JPEG quality setting. Exactly what was essentially missing, great! Luckily, the edge enhancement and noise reduction settings can still be applied afterwards with Zeroprobe's mod so one has the best of two worlds for now at least as a purist who rather has it noisy than smeared.

If I'm not overlooking something here, it's in fact just a few bytes changed in libexynoscamera.so for those two settings, however I don't know how Zeroprobe's app is effectively able to write the file (ES File Explorer returns the message that the file would be in use despite root access and R/W mount).

As for the reproducable reboot, it happens whenever I use the combination of UHD resolution, 48 fps and the MPEG-4 Visual codec. Other frame rates or codecs seem to be fine (except for the dropped frames of course).

In terms of potential performance issues with my phone, I ran Antutu and the result while not being terrible (feel free to disagree), is rather average at 182731 points, with Geekbench while the single core result is allegedly above average at 2015, it is suspiciously low at 5640. I guess I'll reflash Pie and run it again under a "fresh" system and check it further. Have you been able to figure out the hardware issue you were referring to in detail? Since I can hardly imagine a significant performance spread calculation speed wise of CPUs and graphic processors, I can only assume a problem with the heat distribution causing lower clock speeds. Not that this would be frustrating any less but the current Note 8 I have at least doesn't have the severe black crush at low brightness due to a weird gamma setting one can't easily change of course. Samsung's quality control, if at all existing, is simply a nightmare.

 

[Cvolton]

Many thanks for your elaborate reply, Cvolton.

I indeed had missed the recent, very fortunate update with the JPEG quality setting. Exactly what was essentially missing, great! Luckily, the edge enhancement and noise reduction settings can still be applied afterwards with Zeroprobe's mod so one has the best of two worlds for now at least as a purist who rather has it noisy than smeared..

If I'm not overlooking something here, it's in fact just a few bytes changed in libexynoscamera.so for those two settings, however I don't know how Zeroprobe's app is effectively able to write the file (ES File Explorer returns the message that the file would be in use despite root access and R/W mount).

When a file is mounted by Magisk, it can be modified but not deleted. This is probably what ES is complaining about. I am aware it is a few bytes patch, but I don't want to look at what exactly Zero Camera Mod does (mostly in order to maintain dev integrity, I don't want to just rip off someone else's mod). My current issue isn't even about figuring out a way to patch it but to come up with something convenient for the end user, as library patching wouldn't be exactly easy to integrate into Samsung Camera. (BTW when you patch sharpness and denoise with ZCM, it removes the 4 GB limit too)

As for the reproducable reboot, it happens whenever I use the combination of UHD resolution, 48 fps and the MPEG-4 Visual codec. Other frame rates or codecs seem to be fine (except for the dropped frames of course).

The MPEG-4 Visual codec was probably never really tested for resolutions above 1920x1080, I just left it there as an option, as I didn't want to put any restrictions in the mod. If you want to maintain proper framerates, use either H264 or H265, these 2 have been verified to work properly. I wasn't able to reproduce this issue on my S7 though, even with the codec set to MPEG-4 Visual.

In terms of potential performance issues with my phone, I ran Antutu and the result while not being terrible (feel free to disagree), is rather average at 182731 points, with Geekbench while the single core result is allegedly above average at 2015, it is suspiciously low at 5640. I guess I'll reflash Pie and run it again under a "fresh" system and check it further. Have you been able to figure out the hardware issue you were referring to in detail? Since I can hardly imagine a significant performance spread calculation speed wise of CPUs and graphic processors, I can only assume a problem with the heat distribution causing lower clock speeds. Not that this would be frustrating any less but the current Note 8 I have at least doesn't have the severe black crush at low brightness due to a weird gamma setting one can't easily change of course. Samsung's quality control, if at all existing, is simply a nightmare.

That phone's issue was most likely related to thermals, however we didn't do any further testing confirming this yet. According to that person, the phone was performing like this since day one.

Regarding dropped frames, try using H264 or H265, these have been confirmed to make use of proper hardware acceleration and are both more efficient than MPEG-4 Visual anyways. (with H264 being the most compatible with social media platforms and various media players, and H265 being the most efficient)

 

[mlekopan16]

Is panorama mode working with pie rom? I cleared cache for shoting apk and still when I press the camera button, it doesn't make a panorama picture at all. Does anyone else have this?

 

[Cvolton]

Is panorama mode working with pie rom? I cleared cache for shoting apk and still when I press the camera button, it doesn't make a panorama picture at all. Does anyone else have this?

there are 2 panorama modes, the first one doesn't work, the second one does

 

[xex360]

First of thanks for this mod it makes the phone alive again, the quality of the videos is just fantastic.
I have one question or rather an observation, so I left my phone recording 4K60 and forgot about it, after I checked it recorded a few videos but all were limited to 4gb/6min, is it a normal limitation? I left the bitrate on auto.

 

[Cvolton]

First of thanks for this mod it makes the phone alive again, the quality of the videos is just fantastic.
I have one question or rather an observation, so I left my phone recording 4K60 and forgot about it, after I checked it recorded a few videos but all were limited to 4gb/6min, is it a normal limitation? I left the bitrate on auto.

the recordings get split every 4 GB, this is a limitation of the stock cam I haven't removed (yet)

 

[xex360]

the recordings get split every 4 GB, this is a limitation of the stock cam I haven't removed (yet)

Thank you for the reply, I thought it was a storage limitation like we had back in the day with fat32.

 

[Crazzy.Wave]

Hello Users. I did flash this camera mod on Note 8 Oreo, it worked well. But i couldn't make the video college, it was in frozen state. And then i installed Pie rom, and flashed again, through Magisk. After rebooting there is no more Pie Camera. The camera is from Oreo. Is it normal, or i am doing something wrong ?

 

[Cvolton]

Thank you for the reply, I thought it was a storage limitation like we had back in the day with fat32.

It is implemented for that reason, the devices still support FAT32 SD cards. If you try to record a video that's over 4 GB with the limit removed, it corrupts the video

 

[xex360]

the recordings get split every 4 GB, this is a limitation of the stock cam I haven't removed (yet)

It is implemented for that reason, the devices still support FAT32 SD cards. If you try to record a video that's over 4 GB with the limit removed, it corrupts the video

It makes total sense, I totally forgot about the SD cards, to be brutally honest I never even checked how the SD card was formatted.

Hello Users. I did flash this camera mod on Note 8 Oreo, it worked well. But i couldn't make the video college, it was in frozen state. And then i installed Pie rom, and flashed again, through Magisk. After rebooting there is no more Pie Camera. The camera is from Oreo. Is it normal, or i am doing something wrong ?

If momety serves Cvolton said that both cameras were similar but the pie one doesn't have pro mode in video.

 

[little-endian]

Thanks again for the valuable information, Cvolton.

Since my Note 8 unfortunately seems to have another hardware issue (with charging sometimes not working properly and dropouts when using a USB-C to HDMI adapter), I am considering getting another one or a Note 9. The latter one raises the question if you intend to support the Note 9 anytime soon, though.

Would be great if you could reply to that shortly as I have to decide what to order.

---------- Post added at 10:16 PM ---------- Previous post was at 09:45 PM ----------

And then i installed Pie rom, and flashed again, through Magisk. After rebooting there is no more Pie Camera. The camera is from Oreo. Is it normal, or i am doing something wrong ?

Perfectly normal as per Cvolton's "design decision" since the camera software from Pie is ironically worse than the one from Oreo (except for officially supporting H.265 now) due to the lack of the pro settings for video recording.

 

[Cvolton]

Thanks again for the valuable information, Cvolton.

Since my Note 8 unfortunately seems to have another hardware issue (with charging sometimes not working properly and dropouts when using a USB-C to HDMI adapter), I am considering getting another one or a Note 9. The latter one raises the question if you intend to support the Note 9 anytime soon, though.

Would be great if you could reply to that shortly as I have to decide what to order.

Note 9 support still remains a question. I have made some attempts to port the version of Samsung Camera used in Note 9 Oreo to Pie, and while there has been some progress, it doesn't even fully load yet.

 

[markobabic]

Mod for S9?

Hi Cvolton, this is such a great mod! Any chance of this happening for S9? Best regards.

 

[ricci206]

double camera

Good morning,

the double camera mod not working in this version


Thank you

 

[Cvolton]

Good morning,

the double camera mod not working in this version


Thank you

The virtual camera device used in this mode doesn't exist anymore on Pie, so this mode only works on Oreo and older.

 

[ricci206]

The virtual camera device used in this mode doesn't exist anymore on Pie, so this mode only works on Oreo and older.

OK,

but the option is present.

any way to delete it?

Thank you

 

[t3chg33k]

Any possibility of getting this to work with Exynos 9610 that comes with the Galaxy A50? The chip has good imaging capabilities going up to 4k120 but is limited to 1080p30 in the default app and 4k30 in other apps.