• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

m0han

Senior Member
Apr 30, 2012
4,416
1,587
....Magisk Is A Magic Mask to Alter System Systemless-ly.
  • If you are running custom roms, dirty flash the rom again to remove all possible issues. If the rom includes SuperSU, unzip the boot image from the rom zip, and flash it through TWRP, flashify, fastboot etc. to restore to stock ramdisk......
  • ....... you can now download Magisk and flash to your device.
  • To remove Magisk, restore your boot image back (Magisk will backup your boot image automatically in /data/stock_boot(md5).img.gz), then delete /data/magisk.img.
is the following still applicable in the case of custom roms?
1. Boot in to TWRP
2. go to Advanced / File Manager and delete folder named supersu
3. go to Advanced / Terminal and enter these two commands
echo SYSTEMLESS=true>>/data/.supersu
echo BINDSYSTEMXBIN=false>>/data/.supersu​
The first one forces systemless, the second prevents /su/xbin_bind from existing.
4. Flashed Beta SuperSu 2.74-2 (we can notice while flashing this zip after the above script, we will not see the line saying "Disabling OTA". Also, end of flashing it warns that it takes longer time to boot.
5. Reboot device and enjoy systemless
6. To check if we have achieved systemless root, go to system/xbin folder and we should not see the file named "su".
7. I rebooted in to TWRP and flashed xposed 85.1 (also updated with 85.2 later) and installed the apk (Material design apk from this thread)
8. All done and my xposed works.....
 
Last edited:

swipp3r

Member
Sep 22, 2014
10
2
Stuck at boot screen on the S7 Exynos variant, is this just for stock Android or did i do something wrong? I flashed the Magisk v1 then the phh root zip now im stuck at the boot screen ?
 
  • Like
Reactions: driftr31

grep_i

Senior Member
Sep 19, 2015
1,551
621
Stuck at boot screen on the S7 Exynos variant, is this just for stock Android or did i do something wrong? I flashed the Magisk v1 then the phh root zip now im stuck at the boot screen ?
Sure you probably did something wrong.
For starters you gave way to little information.
Did you follow the procedure from the OP exactly ?
What rom do you have, custom recovery if any, custom kernel if any ?
How did you flash ?
Come on people give this information by yourself please, don't let us pull it out of you everytime.
You know you are the one needing help than please try to give detailed information about your problem.

Sent from my Nexus 5 using XDA-Developers mobile app
 

swipp3r

Member
Sep 22, 2014
10
2
Sure you probably did something wrong.
For starters you gave way to little information.
Did you follow the procedure from the OP exactly ?
What rom do you have, custom recovery if any, custom kernel if any ?
How did you flash ?
Come on people give this information by yourself please, don't let us pull it out of you everytime.
You know you are the one needing help than please try to give detailed information about your problem.

Sent from my Nexus 5 using XDA-Developers mobile app
Stock marshmallow, flashed via twrp, and yes i followed the op correctly. No custom kernel.
 
  • Like
Reactions: it0rrent

Nezorflame

Senior Member
Sep 7, 2009
931
2,630
Moscow
nezorfla.me
Google Nexus 5
OnePlus 3
Stuck at boot screen on the S7 Exynos variant, is this just for stock Android or did i do something wrong? I flashed the Magisk v1 then the phh root zip now im stuck at the boot screen ��

Did you flash phh's root zip from this thread's Downloads section or from original phh's thread? If the latter, then that's probably the culprit.
 
  • Like
Reactions: Scandiz

m0han

Senior Member
Apr 30, 2012
4,416
1,587
Magisk on (Yu Yureka) ARM64 device

i did a full clean wipe and then flashed rom, magisk and 'Magisk Compatible phh's SuperUser' - in that order. magisk manager app does not open.
 

Attachments

  • beanmagisklog.zip
    81.4 KB · Views: 1,970
  • Like
Reactions: cleberkorg

Top Liked Posts

  • 6
    Completely factual post, must be impersonal machine, just facts. Must not smile, must not
    emote.
    Come on mate... That's not what it's about. It's the page after page of off-topic social media/Telegram style posting, that clutters the thread so much that discussions about actual Magisk stuff gets even harder to find (in this impossible to search mammoth of a thread), that is the problem.

    I'll keep an eye on things (since I pretty much live in the Magisk forum anyway) and let you guys know if it starts getting out of hand.

    Nice try at satire though... It baited me hook line and sinker. :ROFLMAO:
    5
    Alpha Magisk update (61783ffc-alpha)

    [General] Based on 61783ffc, the content that has been merged into the upstream is no longer listed

    [App] Correctly process any data from magiskd

    [App] Support SharedUserld

    [App] Delete the backup file after restoring the boot mirror image

    [App] Built-in current version update log

    [App] Use the local version when you cannot download the stub, now it can be used completely offline

    [Busybox] Fix the default shell path

    [App] Switch to Java 8 modern time API

    [DenyList] Deal with suspicious props

    [App] Expand and update SafetyNet, update the version of snet.jar to 18

    [Sepolicy] Sepolicy with built-in LSPosed

    [General] Add an obsolete cgroup v2 path

    [Zygisk] Fix app_zygote and webview_zygote binary


    - You update the journal From 23.0 to 61783ffc

    [General] Supports pure 64-bit devices

    [General] Support Android 12 emulator

    [Zygisk] Code injection framework

    [General] Remove MagiskHide

    [General] Support Simulator to add modules

    [MagiskBoot] Support zimage format

    [MagiskBoot] Add zopfi encoder

    [Magisklnit] Support bootconfig

    [App] The repair installation function will now check if the script under /data/adb/magisk/ has not been updated

    [Magisklnit] Support some Meizu devices

    [MagiskSU] If the kernel supports it, use isolated devpts

    [MagiskSU] Fix the pts configuration code, now no additional sepolicy rules are needed

    [MagiskBoot] Support v4 boot image header format

    [Magisklnit] Support oplus.fstab for some OnePlus and Opal devices

    [App] Restart and update modules, not allowed to be marked as pending deletion

    [App] Delete online warehouses

    [App] Add mounting information to the saved log file

    [App] Suitable for Android 12 API level

    [App] Display the waiting pop-up window that is running when hide/restore the original app

    [Stub] Open source obfuscation function

    [Script] Check and display the sepolicy rule folder of the module.

    [App] When the window pops up, hide the screen and add layers. Android 12+ is required

    [App] Delete the floating bottom bar and change it to the general bottom operation bar

    [General] Support compilation and cache

    [General] Add rejection list function

    [App] Delete DoH

    [App] Delete SafetyNet

    [App] Allow the log page to be opened when Magisk is not installed

    [App] Display Zygisk status, add restart to take effect to remind Zygisk to Fix the problem

    PW
    3
    new alpha is out and working fine
    photo_2021-09-23_12-06-06.jpg
    2
    As mentioned by @J.Michael, I think you have likely already succeeded in flashing root w/ Magisk in recovery ramdisk since it flashed without errors, and you don't get bootloop.

    Your difficulty appears to be booting to recovery mode system-with-Magisk on type III device using key combo.

    https://topjohnwu.github.io/Magisk/boot.html#piecing-things-together

    Nb. 'booting into recovery mode' is not referring booting into recovery, but system-with-Magisk mode achieved using recovery ramdisk, ie. booting into system via 'hijacked' recovery ramdisk since boot.img lacks ramdisk. This involves Magisk independently detecting recovery mode key combo + release of buttons within a specific time window in order to execute magiskinit. (A ramdisk is always required for systemless Magisk.)
    https://github.com/topjohnwu/Magisk/blob/master/docs/details.md#magisk-booting-process

    If the key combo only is detected ramdisk will boot to recovery.

    Instructions:
    https://topjohnwu.github.io/Magisk/install.html#magisk-in-recovery

    As mentioned, key release timing is critical, and varies per device.

    Compounding the issue is the fact that John's hybrid Magisk key combo detection does not operate as expected / designed on many devices, and users may need to experiment to establish a working method that is sometimes at odds with John's instructions.

    As an example, safe mode is not always detected by Magisk resulting in modules remaining active even after safe-mode has been activated w/ Magisk installed on (some) Xiaomi devices. This can be very misleading to users. However, an altered key combo does work to both trigger safe mode and allow Magisk to detect Safe mode trigger.

    I opened an issue here Regarding this failure to detect key combo and critical timing 'sweet spot'.
    https://github.com/topjohnwu/Magisk/issues/4624

    So I recommend you keep trying to boot system w/ Magisk in recovery as you already seem to have (had) this installed correctly.

    🤠 PW
    Yes I can go to recovery
    Guy
    No, its FASTBOOT not RECOVERY that I use.

    But it be irrelevant for YOUR device, as covered in the post https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85674179
    im sorry ,yes i can go into fastboot,i will read everything you said and i will start from scratch!
    2
    so after hours nothing, i am sure something else is missing for this device, also while searching I found for the same allwinner brand a custom twrp for a TV box and it pass the signature verification, it does not work cause diffrence device, but when I try to load with the same method magisk zip it failed cause verification error, can we fix somehow the verification on magisk, searching for ways...
    You cannot install the magisk.zip from the stock Android recovery, you need a custom recovery like TWRP. But if your device need to use the recovery image to install Magisk (due to no ramdisk in boot) you cannot install Magisk through recovery...

    So far it sounds to me like you've managed to get a recovery image patched, but you have not yet managed to boot to a rooted system. I'm assuming you've read this:
    https://topjohnwu.github.io/Magisk/install.html#magisk-in-recovery

    When you do the recovery key combo to boot to a rooted system, does it boot up straight away or do you end up in recovery first? If everything is installed correctly it might just be down to a timing thing (as mentioned earlier) and you need to try different timings of releasing the buttons when the device vibrates with splash screen.

    It could also be that the device simply is incompatible too, but let's hope it's a timing thing.
  • 44
    OK. AIO solution. Modded "Universal SafetyNet Fix" module. Just added "model" props.
    17
    So, new layer of HARDWARE detection is here.
    SafetyNet failed on devices, where must bee HARDWARE detection. GMS no longer check system response of evaluation type, and force check HW. USNF doesn't work in this cause.
    Hm, funny things happening. I was thinking this is upgrade of HW attestation, but it is DOWNGRADE actually. 😄

    Remember my old first simple digging into HW?
    It`s..... working again.

    Looks like a temporary solution or just "combo" of old and new methods from Google.
    This explains the fact that dirty hack with Xposed-s working now.

    So, this current environment may be temporary or preparation for something BIGGER.

    In conclusion: in this time to passing SafetyNet you need just my old "hardware_off" module from link above or "MagiskHidePropsConf" with any "BASIC" print with model simulation and kdrag0n-s "Universal SafetyNet Fix".

    No ***-posed-s need!
    16
    Few Headsups:

    1) There are reports that Danny's (@kdrag0n) new early release Universal SafetyNet Fix 2.0.0 (combines AOSP Keystore and shim Keystore solutions) is restoring ctsProfile for some. It just may work for all, but not enough reports as yet. Also, it requires a payment at this stage:
    https://forum.xda-developers.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/post-85581909

    https://github.com/kdrag0n/safetynet-fix/pull/13#issuecomment-904209677

    2) There are reports that simply using MagiskHide Props Config module to 'delete' ro.product.model prop fixes ctsProfile on custom ROMs where other methods have failed. Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912885628

    3) New MagiskHide Props Config module 6.0.0 just released with all the sensitive prop values that MagiskHide changed up to and including Magisk v23 set by default, "Force BASIC key attestation" re-enabled (for Googles latest changes), and various other fixes.
    https://forum.xda-developers.com/t/...p-edits-and-more-v6-0-0.3789228/post-85581939

    I have to agree that this module's name does suddenly seem very apt, and as always, it proves elegant in its versatility. 😛👍

    4) Another elegant solution that some may have relegated to a bygone era seems to be coming back in fashion to!

    Those with Google Pay problems persisting after fixing ctsProfile are reporting in GPay threads, here and elsewhere, that GPay-SQLite-Fix + SQLite binary modules from stylemessiah (a connoisseur at least in digital fashion ... or perhaps just lucky, our @73sydney, - original solution from @BostonDan ) is fixing these for them once again. 😜 Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912798412

    WOT 😉 to read if interested:
    https://forum.xda-developers.com/t/...s-of-gms-17-1-22-on-pie.3929950/post-79643248

    🤠 PW
    15
    ro.product.model was enough for my OP8T, but I didn't like how Google Play Services started referring to my device as "OnePlus BASIC" with the "hardware off" module, so I knocked together this module really quickly to just append _SN to the real model name. WFM. 🤘
    14
    Removed the @Displax safety net mod fix and applied the latest USNF 2.1.0 from @kdrag0n.

    Attestation is passed and device is compliant in company portal too with my original device name 1+8 Pro and not Pixel.

    This is done over the latest Alpha Magisk.

    Update: My In-display fingerprint hardware is not working anymore, I think the fix is already committed. Hopefully it will be resolved in the next version.
    Yep, I have sent a Pull Request with the fix like an hour after v2.1.0 was released. 🤠

    See my post here in the official USNF thread for getting it working in the meantime until it's merged and a new release is made: https://forum.xda-developers.com/t/...tynet-fix-1-1-0.4217823/page-59#post-85631613

    Also may be worth everyone reading my comments at the end of that post about people doubting the sponsored testing closed-then-open development.

    And then here on this GitHub issue about how it's not meant to replace MagiskHide so you can't just turn Hide off: https://github.com/kdrag0n/safetynet-fix/issues/91#issuecomment-919264624
  • 1062
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p