Magisk General Support / Discussion

Search This thread
By:
Advanced…
miguelr4720

miguelr4720

Senior Member
May 24, 2015
111
35
27
New York
Cant Someone Please Help Me With This Problem Safety Net Wont Pass On My Galaxy Note EDGE N915T T-Mobile Running LineAge Rom Cant Someone Provide me a fix for this Problem i Try Universal Safety Net Fix Try Different Kernels Still The Problem How Do I Fix This Issue Please Help Me ASAP PLEASE PLEASE
 
A

admiralspeedy

Senior Member
Dec 22, 2011
308
132
Didgeridoohan said:
https://github.com/topjohnwu/Magisk/blob/master/docs/details.md#simple-mount-details



:eek: No, don't bother... That's just me being incredibly confused and lacking quite a few hours of sleep. :laugh:

Logs will still be nice though. :D
Click to expand...

Ok, here are the logs I could pull. I installed the njh47f stock image to my Pixel XL, booted, went through the initial setup and everything, then turned it off, went into the the bootloader and fastboot booted TWRP (3.2.1.0) and installed Magisk 15.3 (1531) (although this happens 14.6, 15.0, 15.1, 15.2, and every other build of 15.3) and it installed totally fine.

I rebooted the phone and started logcat so it would log right from boot, and that log is attached in the zip as "startup.log". I took a look in it and it does appear as though Magisk starts to some degree, but as I stated in other posts, once the phone boots, Magisk Manager is not installed. I installed Magisk Manager 5.5.5 myself, and then started logcat again, launched Magisk Manager and let it log (attached in the zip as "magiskmanager.log") for about a minute while Magisk Manager just hung doing nothing.

As for the actual Magisk log that is supposed to be located in /data/adb/magisk, well it never gets created for me. I checked through the TWRP file manager and while the /data/adb/magisk folder does exist, there is no log file in it.
 

Attachments

  • logs.zip
    235.5 KB · Views: 8
Last edited:
G

gothicVI

Senior Member
Jun 7, 2014
1,326
620
Munich
miguelr4720 said:
Cant Someone Please Help Me With This Problem Safety Net Wont Pass On My Galaxy Note EDGE N915T T-Mobile Running LineAge Rom Cant Someone Provide me a fix for this Problem i Try Universal Safety Net Fix Try Different Kernels Still The Problem How Do I Fix This Issue Please Help Me ASAP PLEASE PLEASE
Click to expand...
1. Don't cross post, you violate forum rules!
2. Read op about safetynet!
3. Don't be demanding, you violate forum rules!
4. Mind your punctuation. Your text is unreadable...

Gesendet von meinem Moto G 2014 LTE mit Tapatalk
 
  • Like
Reactions: steppie, *.jpg and Pkt_Lnt
Didgeridoohan

Didgeridoohan

Forum Moderator / Developer Relations
Staff member
May 31, 2012
11,420
11,623
Gothenburg
Google Nexus 4
Nexus 6
miguelr4720 said:
Cant Someone Please Help Me With This Problem Safety Net Wont Pass On My Galaxy Note EDGE N915T T-Mobile Running LineAge Rom Cant Someone Provide me a fix for this Problem i Try Universal Safety Net Fix Try Different Kernels Still The Problem How Do I Fix This Issue Please Help Me ASAP PLEASE PLEASE
Click to expand...

Most of the info you'll need can be found here:
https://forum.xda-developers.com/apps/magisk/guide-magisk-troubleshooting-t3641417

Pay close attention to the part titled "Asking for help".

admiralspeedy said:
Ok, here are the logs I could pull. I installed the njh47f stock image to my Pixel XL, booted, went through the initial setup and everything, then turned it off, went into the the bootloader and fastboot booted TWRP (3.2.1.0) and installed Magisk 15.3 (1531) (although this happens 14.6, 15.0, 15.1, 15.2, and every other build of 15.3) and it installed totally fine.

I rebooted the phone and started logcat so it would log right from boot, and that log is attached in the zip as "startup.log". I took a look in it and it does appear as though Magisk starts to some degree, but as I stated in other posts, once the phone boots, Magisk Manager is not installed. I installed Magisk Manager 5.5.5 myself, and then started logcat again, launched Magisk Manager and let it log (attached in the zip as "magiskmanager.log") for about a minute while Magisk Manager just hung doing nothing.

As for the actual Magisk log that is supposed to be located in /data/adb/magisk, well it never gets created for me. I checked through the TWRP file manager and while the /data/adb/magisk folder does exist, there is no log file in it.
Click to expand...

Quick look at the log shows a broken Magisk installation (can't access and create the necessary folders, or something like that) and a few segfaults. That's all I saw at the moment...

You'll only find the debug log if you have the beta version of Magisk installed (only difference is more verbose logging), and the location is /data/adb.
 
  • Like
Reactions: Pkt_Lnt
A

admiralspeedy

Senior Member
Dec 22, 2011
308
132
Didgeridoohan said:
Most of the info you'll need can be found here:
https://forum.xda-developers.com/apps/magisk/guide-magisk-troubleshooting-t3641417

Pay close attention to the part titled "Asking for help".



Quick look at the log shows a broken Magisk installation (can't access and create the necessary folders, or something like that) and a few segfaults. That's all I saw at the moment...

You'll only find the debug log if you have the beta version of Magisk installed (only difference is more verbose logging), and the location is /data/adb.
Click to expand...

I did install a beta version (1531) and there was no log in /data/adb either (I checked there before I checked /data/adb/magisk). If the installation is failing, then that's a problem with the Magisk installer because the TWRP log shows that it installed completely fine, and I can post it if you want proof of that. I'm pretty sure this is an issue with Nougat that was introduced when support for Oreo was added.

EDIT: To further confirm that this issue exists, I flashed my old Nexus 6 with its last stock factory image, which is 7.1.1 and installed Magisk 15.3, beta 1531 and it produces the exact same result as on my Pixel XL. No Magisk Manager installed, and when I install it, it just hangs when I open it. This confirms that it is not a Pixel (or A/B slot device) specific issue.
 
Last edited:
  • Like
Reactions: Didgeridoohan and galaxys
botteur

botteur

Member
Jan 3, 2011
11
1
Namur
Hi !

I have an LG G6 with the latest build of LineageOS & Magisk and I have problems with Magisk Hide.

When I apply Hide to my banking application, it works for a day or two and then it detects the root and doesn't work anymore. Even I uninstall the application and reinstall it after, always the same problem... How to do this?

Thanks !
 
J

johnyg07

Member
Aug 5, 2013
40
22
random reboot once a day

Hi,
I am using magisk on my nexus 6, with Nitrogen OS OREO 8.1 ROM. I have this problem of my phone crashing once a day.
When I initially clean flashed the ROM at 6 PM local time, finished setup by 6:30. My phone would crash around 6:30 pm every day.
Then I flashed the rom again at 11:30 pm without restoring apps from titanium backup, did a clean setup and apps restore from google, my phone then would crash and reboot around 11:45 pm.
Then I tried messing up the phone time to simulate the crash but it did not happen. after this my phone start crashing in the afternoon.
I checked the logs with logcat and saw the logs from magisk.

Could someone please take a look at the attached logs and see if magisk is causing the system crash or or there is something else causing the crash.
 

Attachments

  • Log_2018-02-02_12-53-30-copy.zip
    55.2 KB · Views: 6
S

spiritflare01

Senior Member
Sep 19, 2015
117
13
Toronto
Magisk and Android Pay

Running Lineage 14.1. Android Pay doesn't work due to failing Safety Net.

"Android pay cannot be used on this device"

Is it possible to hiding root with say, Magisk ? Or relocking bootloader.

Anyone had any success with either method ? Don't feel to go back to stock..
 
Didgeridoohan

Didgeridoohan

Forum Moderator / Developer Relations
Staff member
May 31, 2012
11,420
11,623
Gothenburg
Google Nexus 4
Nexus 6
admiralspeedy said:
EDIT: To further confirm that this issue exists, I flashed my old Nexus 6 with its last stock factory image, which is 7.1.1 and installed Magisk 15.3, beta 1531 and it produces the exact same result as on my Pixel XL. No Magisk Manager installed, and when I install it, it just hangs when I open it. This confirms that it is not a Pixel (or A/B slot device) specific issue.
Click to expand...

That's good... :p

Means I can throw that factory image on my old N6 and do some testing myself.

botteur said:
Hi !

I have an LG G6 with the latest build of LineageOS & Magisk and I have problems with Magisk Hide.

When I apply Hide to my banking application, it works for a day or two and then it detects the root and doesn't work anymore. Even I uninstall the application and reinstall it after, always the same problem... How to do this?

Thanks !
Click to expand...

You can also try hiding the Manager (it's in the Manager settings). Since it seems to work for a while, it could be that your Hide randomly stops working on your device... Some more testing and, if possible, logs would be nice. Install the beta version of Magisk v15.3 and save the magisk_debug.log (/data/adb) after the app starts complaining about root. If we're lucky it'll show something...

johnyg07 said:
Hi,
I am using magisk on my nexus 6, with Nitrogen OS OREO 8.1 ROM. I have this problem of my phone crashing once a day.
When I initially clean flashed the ROM at 6 PM local time, finished setup by 6:30. My phone would crash around 6:30 pm every day.
Then I flashed the rom again at 11:30 pm without restoring apps from titanium backup, did a clean setup and apps restore from google, my phone then would crash and reboot around 11:45 pm.
Then I tried messing up the phone time to simulate the crash but it did not happen. after this my phone start crashing in the afternoon.
I checked the logs with logcat and saw the logs from magisk.

Could someone please take a look at the attached logs and see if magisk is causing the system crash or or there is something else causing the crash.
Click to expand...

There's a fatal error 6 in there, for the Manager. Hm... I'm running the same setup on my N6, but haven't seen this. It's not my daily driver though... More details about your device and setup, please.

Could you also install the beta version of Magisk v15.3 and save the magisk_debug.log (/data/adb) after the crash. You'll have to save it before the phone boots again, from recovery.

spiritflare01 said:
Running Lineage 14.1. Android Pay doesn't work due to failing Safety Net.

"Android pay cannot be used on this device"

Is it possible to hiding root with say, Magisk ? Or relocking bootloader.

Anyone had any success with either method ? Don't feel to go back to stock..
Click to expand...

It's often possible to hide root and an unlocked bootloader with Magisk. It depends a bit on your device and setup though.

Take a look in the installation and troubleshooting guide for some tips.

siealex said:
Nexus 5x, stock Oreo 8.1. Magisk causes the phone to crash randomly at the Google logo. WTF?
Click to expand...
EmiRus said:
Same here, u mean iif reboot Stuck at google Logo right?

Sent from my Nexus 5X using XDA Labs
Click to expand...

Logs, please...
 
A

admiralspeedy

Senior Member
Dec 22, 2011
308
132
Didgeridoohan said:
That's good... :p

Means I can throw that factory image on my old N6 and do some testing myself.
Click to expand...

That'd be awesome, because I actually noticed that every version from 14.5 to 14.6 (including betas) randomly loses root all the time on me or doesn't work at all, so I'm kinda just stuck at 14.3 for now. If you need me to test anything else, let me know!
 
Last edited:
elandroido

elandroido

Senior Member
Aug 13, 2014
1,022
598
Munich
Dr. Hurt said:
Xiaomi Redmi Note 4 Qualcomm SD625 Oreo ROM

Formatted data to F2FS and now magisk su requests work but are not remembered. I have to grant permission every single time the su command is issued by the requesting app.

Log shows errors related to magisk su database
Click to expand...

Hey,

I have exactly the same problem (even the same device).
Magisk worked perfectly until I switched to f2fs. Now it cannot remember granted permissions.
I have attached log screenshots.

The loopback module would not work for me because I have data and cache f2fs formatted.

Have you (or anyone else) found a solution?

I really want to stay with f2fs, because it improved performance for my usecase quite a bit.

(I probably have to try other kernels).

Gr33z
 
Last edited:
E

etmatrix

Member
Jan 6, 2015
27
6
I have updated Magisk to lastest stable version 15.3 my previous version was 14. I see strange char appears in file /init.rc after last line

Code: 
00006950: 2020 2067 726f 7570 2072 6f6f 740a 05c3     group root...
00006960: 043a 03f2 037a 0420 04ff 03ff 0320 040a  .:...z. ..... ..
I tried to dump boot.img and unpack it but these chars there are not in file /init.rc
Why? Someone has some suggestions?
 
siealex

siealex

Senior Member
Jul 22, 2008
2,535
497
Kharkov
Quote:
Originally Posted by siealex
Nexus 5x, stock Oreo 8.1. Magisk causes the phone to crash randomly at the Google logo. WTF?

Quote:
Originally Posted by EmiRus
Same here, u mean iif reboot Stuck at google Logo right?

Sent from my Nexus 5X using XDA Labs

Logs, please...
Click to expand...

Where can I get them if it even does not boot up to the boot animation???
 
Didgeridoohan

Didgeridoohan

Forum Moderator / Developer Relations
Staff member
May 31, 2012
11,420
11,623
Gothenburg
Google Nexus 4
Nexus 6
elandroido said:
Hey,

I have exactly the same problem (even the same device).
Magisk worked perfectly until I switched to f2fs. Now it cannot remember granted permissions.
I have attached log screenshots.

The loopback module would not work for me because I have data and cache f2fs formatted.

Have you (or anyone else) found a solution?

I really want to stay with f2fs, because it improved performance for my usecase quite a bit.

(I probably have to try other kernels).

Gr33z
Click to expand...

There was a commit made recently for the Manager that might fix this issue. You could build it yourself or test one of the unofficial snapshots provided by @kantjer.

siealex said:
Where can I get them if it even does not boot up to the boot animation???
Click to expand...

You mention that Magisk causes your phone to crash. Try to grab a logcat of the crash.

And if it's not too early in the boot process a logcat when it's looping might show something. Sounds like it's a bit too early though, but worth a shot...

If nothing else works, a recovery/installation log for Magisk and a copy of the boot image might be useful.
 
  • Like
Reactions: kantjer and elandroido
You must log in or register to reply here.

Similar threads

noidodroid
Magisk MultiROM Support
Replies
3
Views
367
MoistPicklez
MoistPicklez
D
Magisk supported devices
Replies
2
Views
13K
D
DerEngel
Killua96
[Discussion] Fate Go Magisk Discussion Thread
Replies
50
Views
15K
Me_Ashish_
Me_Ashish_
Heisenberg
[Discussion] PokeMon Go Magisk Discussion Thread
Replies
5K
Views
604K
Z
Zelda mjau
D
Sony Support for Magisk
Replies
0
Views
2K
D
Devo7v

Top Liked Posts

24 Hours 30 Days All time
  • 1
    I
    ineedroot69
    Lamantin001 said:
    Hi developers!
    Today I wanted to update my magisk from the app from 22.0 to 22.1, but upon updating using direct install, my phone got into bootloop. After (or during) installing it just rebooted, but it always reboots into fastboot. It's a xiaomi pocophone f1 with latest stable miui global stock rom (12.0.3), unlocked bootloader, twrp recovery, with root of course by previous magisk install. I didn't have any modules installed from the app, so that couldn't make the problem, it was during updating the app. I can still access twrp. There, when I first wanted to reboot to system, before trying anything, it said "No os installed". Then I started googling, I tried uninstalling magisk, by downloading first v22.0 apk, renaming it to uninstall.zip, flashing, rebooting, same thing. Then tried again, and tried installing it back again, rebooting, same thing. Then tried uninstalling, flashing clean boot.img, rebooting, same thing. Then tried the same with 22.1 apk uninstaller. I tried all combinations of these solutions, none of them seemed to work. :/ Currently I still have the bootloop to fastboot.
    Can you suggest any other solutions without losing all the data?
    Click to expand...
    flash system.img you got same issue with this guy https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/page-2261#post-84814787

    or this https://www.didgeridoohan.com/magisk/MagiskUninstall
    View
  • 12
    P
    pndwal

    Latest Public (Stable / Beta)​

    Release Notes and Changelog:​


    2021.4.9 Magisk v22.1​

    This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.

    Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.

    Bug Fixes​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    🎉 👍 PW
    View
    8
    osm0sis
    osm0sis
    io2345 said:
    @osm0sis
    Thank you for having an eye on that.
    Did the "ls" twice, first from a TWRP-terminal in recovery, second from a terminal while phone is "up and running".
    Click to expand...
    Looks like you have /dev/bootimg as your real partition location and it is still higher in the list in util_functions.sh like how I fixed it in the linked commit, so this is definitely a regression from some other recent change to Magisk.. sigh, I'll look into it. 🤔😕
    View
    6
    osm0sis
    osm0sis
    io2345 said:
    No, the phone is an Estar Takee1.
    ROM is from here: Mikel Android 7 for Takee1
    and is itself a port from this ROM: RidonOS for Micromaxx A311
    Click to expand...

    io2345 said:
    You're right, sorry for that. Now here the installation log for canary-version:

    - Target image: /dev/BOOT
    - Device platform: armeabi-v7a
    - Installing: f152b4c2 (22005)
    nanddump: MEMGETINFO: Not a typewriter
    Parsing boot image: [boot.img]
    - Unpacking boot image
    ! Unsupported/Unknown image format
    ! Installation failed
    Click to expand...

    Didgeridoohan said:
    That was quick... Didn't even have to whisper your name three times in the mirror.

    Boot image is here:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84688655

    And this is supposedly the install log:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84686805

    And for good measure there's a Magisk log as well:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84695083

    And some device info:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84689305
    Click to expand...
    😛

    /dev/BOOT is known (usually) not an actual boot partition, hence nanddump failing.

    I had originally fixed this back here: https://github.com/topjohnwu/Magisk/commit/2aede97754fec67d393bde0c7725ed84d8c3c112

    So not sure if we're looking at some kind of a regression, or just a further edge case.

    @io2345 what's the actual, correct location of your boot partition? Please give me the output of `ls -alR /dev`
    View
    6
    zgfg
    zgfg
    #Xiaomi.eu, #OTA, #Magisk 22006, #Viper4Android, #sepolicy.rule

    This week, Xiaomi.eu weekly update 21.3.24 (MIUI 12.5, A11) was late a day and a half, hence I upgraded yesterday night

    As usual:
    - I downloaded the zip, extracted boot.img and patched (already from my previous Xiaomi.eu 21.3.18, rooted by Magisk 22006)
    - Flashed the Xiaomi.eu zip from TWRP, wiped Dalwik and Cache and rebooted
    - Then rebooted once again to TWRP and flashed the boot.img that was patched in advance

    I could probably flash its patched boot img right after flashing the 'OTA' zip (saving one time booting to the not-rooted system and rebooting to TWRP), but I rather play the safe and many times proven game

    Upon rebooting with the patched boot img, I have Magisk 22006 root again, with all modules (except V4A), root granted apps snd apps enabled for Magisk hide

    This time the old trick to make V4A did not work. Maybe because of the known sepolicy.rule bug in Magisk 22006, or maybe I was not 'patient' enough and made a mistake in steps

    Anyway, I also wanted to test, hence I modified V4A's post-fs-data.sh in accordance to:
    https://forum.xda-developers.com/t/...-0-viper4android-fx-2-7.3774651/post-84121895
    rebooted, and it did the trick 👍

    The modified post-fs-data.sh for:
    /data/adb/modules/ViPER4AndroidFX
    is zipped and attached

    The zip also contains DDC and Kernel folders to be copied ton Internalmemory: /Android/data/com.pittvandewitt.viperfx/files
    for V4A Convolvers and headphone profiles

    Hence now I have again AML, V4A plus another audio mode (320 kbps bitrate for my phone) and V4A is happilly again Supported and Proccessing (still in the Legacy mode)
    View
    6
    P
    pndwal

    Latest Canary Changelog, including Release Notes:​


    Magisk (9c0e1897) (22007)​

    • [General] Fix logic to copy sepolicy.rule during module installation
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.

    Diffs to v22.0​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlock
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    👍 PW
    View
  • 1045
    T
    topjohnwu
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    View
    155
    T
    topjohnwu
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    View
    119
    Chainfire
    Chainfire
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    View
    76
    nathanchance
    nathanchance
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    View
    74
    T
    topjohnwu
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
    View

New posts

Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone