Magisk General Support / Discussion

Search This thread

EViollet

Senior Member
Aug 9, 2010
1,833
708
Hi

Is there a tasker interface for magisk, so I can root / unroot on tasker events ?
Send the following command to unroot :
$(getprop magisk.supath)/su -c "setprop magisk.root 0"

And to root again :
$(getprop magisk.supath)/su -c "setprop magisk.root 1"

Envoyé de mon ONEPLUS A3003 en utilisant Tapatalk
 
  • Like
Reactions: gazzacbr

grep_i

Senior Member
Sep 19, 2015
1,551
621
anyone know how to install magisk on zenfone 6? i flashed it via twrp but the twrp restarted: when i sliced a button to flash, the screen turned black and then it go to twrp main menu, nothing add on the log, seem like a crash. there's over 350 pages here and i cant find comments. if u know anything plz tell me or ask @topjohnwu to add it on the instruction.thx
It's an Asus device isn't it ?
In OP he states that Asus devices need some work on the boot image and you need to contact @topjohnwu to give him details so he can fix that issue.

Sent from my Nexus 5 using XDA-Developers mobile app
 
Last edited:
  • Like
Reactions: duy0699cat

Captain_Throwback

Recognized Developer
It's an Asus device isn't it ?
In OP he states that Asus devices need some work on the boot image and probably it will be working in next version V7

Sent from my Nexus 5 using XDA-Developers mobile app
Where does it say it will probably be working in v7? It says a developer needs to provide the necessary information for him to start looking at it. I doubt there will be support in v7.
 

Rayman96

Senior Member
Jun 3, 2009
1,190
325
Warszawa, Poland
Why is it that everyone is turning a blind eye on this post,i have posted here several times and nobody seems to notice it or reply it's really sad to see?

Look at my post in this thread regarding Lenovo A7-30. If you can do the same, then somebody can help. You are just moaning for nothing.

---------- Post added at 15:56 ---------- Previous post was at 15:55 ----------

I get also the message "Unable to detect boot image" when I run magisk 6 into recoverry.

The script fail because he cannot find boot partition; BOOTIMAGE leave at null


no "by-name" folder exist in my system that's why I get the message. and propably other people get this message.
And I cannot find manualy the boot partition into recovery. part5 is system, 6 is cache, 7 data. I mount part1 and part2 to see them and there are empty !

sorry for my bad english

What is your device? Can you run same commands as I did in my post about lenovo A7-30 in this thread?
 

Secundus

Member
Jan 20, 2011
25
0
Ludwigshafen
can not uninstall magisk

i have flashed all files. Magisk does not work on my Samsung Galaxy S4 I9506 . if i turn Root toggle off it goes on one second later. And Hide selinunx is grayed.
Now i want to boot in to Recovery to flash the uninstall but it does not work. no recovery on my Samsung!!
I have read i must flash the boot.img to remove magisk. i have a backup in twrp. i have tried twrp manager but it needs root. i don't have root. reflash of twrp does not help.

please can anyone tell me how do i remove magisk completely?
 

Omel

Senior Member
Sep 13, 2008
250
33
Sorry for my noob question have anyone any luck install. Viper4android on a note 4 or note edge and have it working
I could sure use some guidelines
 

boilavera1980

Senior Member
Feb 19, 2015
429
70
Are you on CM? Then you need to unroot first.

i have flashed all files. Magisk does not work on my Samsung Galaxy S4 I9506 . if i turn Root toggle off it goes on one second later. And Hide selinunx is grayed.
Now i want to boot in to Recovery to flash the uninstall but it does not work. no recovery on my Samsung!!
I have read i must flash the boot.img to remove magisk. i have a backup in twrp. i have tried twrp manager but it needs root. i don't have root. reflash of twrp does not help.

please can anyone tell me how do i remove magisk completely?
 

ibrokemypie

Senior Member
Jul 20, 2016
435
211
is magisk still working to get around safety net? flashed rom update which wipes /system before installing,. then installed magisk and phh root, only other things i have flashed have been magisk modules, but even afterunmounting safetynet is tripped.
is there any way to check what tripped it? the rom dev spent a few days getting magisk working so i dont believe the rom is the problem...
 

Captain_Throwback

Recognized Developer
is magisk still working to get around safety net? flashed rom update which wipes /system before installing,. then installed magisk and phh root, only other things i have flashed have been magisk modules, but even afterunmounting safetynet is tripped.
is there any way to check what tripped it? the rom dev spent a few days getting magisk working so i dont believe the rom is the problem...
Yes, it's working fine, as long as you don't have Xposed installed or enabled.
 
  • Like
Reactions: LeeDroid

lebeneur

Member
Sep 23, 2016
15
1
Originally Posted by JuergenZ66
You need to bump your boot partition.
Just use cbump directly after flashing magisk and phh in recovery before you reboot.
You can find cbump here http://forum.xda-developers.com/lg-g...image-t3325186
follow the link, download is under Miscellaneous.

Thanks for replying ! Is this tools works as well with G3 ?

I booted on my stock rom, with stock 6.0 boot img.
I go in TWRP
I Flashed magisk6.0 (no error)
I flashed supersu 2.46magisk (no error)
I flashed aligator cbump (supposed fixing and signing boot).
Reboot...

boot stuck with this message ...fastboot mode enable

Does ianyone succeded in installing magisk on a LGG3 ?
 

GXGOW

Senior Member
Apr 4, 2012
1,120
489
East Flanders Best Flanders
is magisk still working to get around safety net? flashed rom update which wipes /system before installing,. then installed magisk and phh root, only other things i have flashed have been magisk modules, but even afterunmounting safetynet is tripped.
is there any way to check what tripped it? the rom dev spent a few days getting magisk working so i dont believe the rom is the problem...

If you don't use Xposed, it's working flawlessly. Otherwise, you'll have to disable Xposed, reboot and re-enable it once you're done using the application which uses SafetyNet. That's what I'm doing and yes, it sounds like a band-aid kind of solution, but hey, it's working for now.
 

ibrokemypie

Senior Member
Jul 20, 2016
435
211
If you don't use Xposed, it's working flawlessly. Otherwise, you'll have to disable Xposed, reboot and re-enable it once you're done using the application which uses SafetyNet. That's what I'm doing and yes, it sounds like a band-aid kind of solution, but hey, it's working for now.
systemless xposed doesnt work?
 

toshi127k

Member
May 16, 2011
6
7
Yokohama
toshi127k, could you pls make a step-by-step manual/howto to make it possible to install magisk V6 on Sony Z1 compact with 14.6.A.1.236 using either TWRP or Flashtool as many other users including me are not as familiar in linux as you. As far as I understood it's not only needed to flash your modified magisk-v6k.zip but also make some changes in kernel/boot. Please attach to your post all the needed modified files as well. Thank you in advance.

The way to the destination has been shown #3302
I can not show procedure that all users can understand,sorry

**********************************************
this is for
Xperia Z1compact(D5503)
Stock ROM 14.6.A.1.236
only

download boot.img on your PC
download Magisk-v6k.zip on your device
Please perform the following steps in place flash Magisk-V6.zip
  1. reboot device into bootloader & flash boot.img
    PHP:
    fastboot flash boot boot.img
  2. reboot device into TWRP & install Magisk-V6k.zip
All please go at your own risk
**********************************************
please do not ask me any more
 
Last edited:

Top Liked Posts

  • 3
    "dual Magisk": Did you try to put Magisk in *both* boot and recovery?
    Yes 😛
    I do not understand "ANY attempt to flash Magisk to recovery finds recovery's 'stock boot image' and patching succeeds": What is "find", and what is "succeeds"?
    See this log for patching recovery image (Recovery mode checked):
    Code:
    - Device platform: arm64-v8a
    - Installing: e136fb3a (22102)
    - Copying image to cache
    - Unpacking boot image
    - Checking ramdisk status
    - Stock boot image detected
    - Patching ramdisk
    - Repacking boot image
    
    ****************************
    Output file is written to
    /storage/emulated/0/Download/magisk_patched-22102_xumwp.img
    ****************************
    - All done!
    Direct Installation log is similar.

    You said Xiaomi. I have a Samsung.
    😆
    I agree the bootloader supports ramdisk. As I quibbled with you earlier, I believe that it is the kernel that may or may not look for / use a ramdisk: it's the same bootloader, whether you boot boot or boot recovery, so if recovery always has a ramdisk, the bootloader always supports ramdisk.
    But recovery ramdisk and boot ramdisk are implemented differently.

    As John took pains to point out, type III (Ramdisk= no) devices (generally speaking) DON'T support boot-ramdisk (even if added manually when missing, as Magisk does) due to lack of bootloader support. However, since bootloader (generally speaking) supports recovery-ramdisk, Magisk in recovery is an option.

    Or the bootloader doesn't even know about ramdisk, and the kernel finds the ramdisk at the end of what the bootloader thought was kernel. Of course, there could be a flag in the kernel's meta-data that tells the bootloader not to bother doing ramdisk stuff, but that would still be a matter of the *kernel* choosing to not allow ramdisk.
    As I understand it, to use any ramdisk type requires ramdisk specific bootloader support. Kernel and ramdisk can be patched, but bootloader (again, generally) cannot be, due to proprietary nature.

    Bootloader support (or lack of it) presents the real challenge.
    I agree that it seems to be possible to install Magisk in boot on my device.

    I do not believe that I have Magisk in boot -- I told you I had to boot repeatedly before hitting the sweet spot that caused Magisk to activate.
    Yep, understand that. 🙂 But I don't understand fully what's going on yet.

    Since trying with stock, I tried patching and flashing TWRP image (w/ fastboot) both w/ stock boot, and Magisk patched boot image with similar results; patching succeeds (completes w/ no errors), but get 'system has been destroyed' on booting.

    Then, with Magisk in boot, I've checked Recovery mode and tried Direct Install. Surprisingly, this succeeds, and reboot (from Magisk App) lands me in recovery.

    It appeared I now had Magisk in Recovery as all settings were for this, but on powering off and trying to boot with recovery key combo / releasing keys at splash screen (for system with Magisk in recovery), like you, I have great difficulty getting to system. I get recovery unless I release keys on vibration, and almost BEFORE splash screen appears! I get System with root this way, but I'm not sure I'm not simply releasing keys too early to boot using recovery at all (ie. that this isn't actually Magisk in boot.)!

    To test this, I've variously to flash stock boot.img (to see if I can boot with and without root as instructions say I should have ability), and with boot.img patched with a slightly different version of Magisk (for bootup comparison), but ANY such changes in combination with patched working recovery image result in 'System Has Been Destroyed', Fastboot mode only available, and this is fixed only by flashing unpatched recovery image.

    Seems the symptoms I have may be similar to yours (difficulty booting to system from recovery key combo, etc). At the very least, I'm not convinced I actually have Magisk in recovery, although it has clearly been Patched / altered.

    At this stage, I suspect that Xiaomi devices that appear as type III (and possibly other devices) may not be properly accounted for in John's Booting Shenanigans summary. I'm thinking the unexplained bootloader compatibility with ramdisk in boot may somehow be there to boot recovery, although not needed for system.... or other perhaps something else is going on.... So we may in fact have more than IV basic boot-types of Android device... There seem to be more discrepancy with John's Type III model that just having Magisk in Boot ability.

    I'd love to get my head around this!
    I do not know if my version of Magisk Manager has a reboot option, but I would be afraid to try to use it to get back to Magisk active from Magisk inactive. I would expect the Manager to need root privilege to trigger a reboot, let alone to trigger a reboot to recovery. Are those really things that Android will allow an unprivileged app to do?
    Covered by @zgfg. 👍 PW
    2
    Does anyone know which version of Magisk still has the "Install in to inactive Slot (AfterOTA)? I know it was removed temporarily, having a difficult time finding the version before it it was removed.
    I'm using 22.1, and I still have that "Install in to inactive Slot (AfterOTA)" functionality. However, I haven't tried it on Android 11. It has worked for me on Android 10 with 22.1: OnePlus 7Pro (GM-1917) running OOS 10.3.8.
    2
    Well, tried to test dual Magisk on my RN8T (Ramdisk = no), but more surprises: ANY attempt to flash Magisk to recovery finds recovery's 'stock boot image' and patching succeeds, but booting fails with 'System Has Been Destroyed'; Fastboot only available.(flash stock recovery fixes). Not sure what the problem is with recovery-ramdisk, but understand other Xiaomi users have also failed to gain root by official Ramdisk= no method also. Fortunately, it generally works with boot-ramdisk.

    I've tried builds from latest back to 20.3 with same results... Must try patching custom recovery.img soon!

    I'm not sure of anything either (now more so), but still strongly suspect your device has boot-ramdisk bootloader support (despite no factory boot-ramdisk) like mine, and that after Magisk patching adds basic missing boot-ramdisk with Magisk-init (working since this commit: https://github.com/topjohnwu/Magisk/commit/e72c6685edf81706617a3444575c4500b9b8fe6c ), Magisk in boot works. If reports of .zip installer from twrp working are true I think this MUST be the case.

    Not sure if this does account for booting to Magisk without recovery key combo for you, but I think it could.

    I noticed using reboot from Magisk App boots to recovery after checking Recovery mode too. I'm guessing that when system is able to boot from recovery w/ Magisk, this should get one back to back to system with Magisk in recovery.

    I just can't see how this could work after normal power off. From this state, the kernel directly mounts the system partition as rootdir and exec /init to boot (ie. SAR). Kernel doesn’t need initramfs (ie. ramdisk) to boot Android (because rootdir is in system), and there is NO ramdisk in boot partition to access... unless it is added manually...

    But I certainly could be missing something... PW
    2
    Well, tried to test dual Magisk on my RN8T (Ramdisk = no), but more surprises: ANY attempt to flash Magisk to recovery finds recovery's 'stock boot image' and patching succeeds, but booting fails with 'System Has Been Destroyed'; Fastboot only available.(flash stock recovery fixes). Not sure what the problem is with recovery-ramdisk, but understand other Xiaomi users have also failed to gain root by official Ramdisk= no method also. Fortunately, it generally works with boot-ramdisk.

    I've tried builds from latest back to 20.3 with same results... Must try patching custom recovery.img soon!

    I'm not sure of anything either (now more so), but still strongly suspect your device has boot-ramdisk bootloader support (despite no factory boot-ramdisk) like mine, and that after Magisk patching adds basic missing boot-ramdisk with Magisk-init (working since this commit: https://github.com/topjohnwu/Magisk/commit/e72c6685edf81706617a3444575c4500b9b8fe6c ), Magisk in boot works. If reports of .zip installer from twrp working are true I think this MUST be the case.

    Not sure if this does account for booting to Magisk without recovery key combo for you, but I think it could.

    I noticed using reboot from Magisk App boots to recovery after checking Recovery mode too. I'm guessing that when system is able to boot from recovery w/ Magisk, this should get one back to back to system with Magisk in recovery.

    I just can't see how this could work after normal power off. From this state, the kernel directly mounts the system partition as rootdir and exec /init to boot (ie. SAR). Kernel doesn’t need initramfs (ie. ramdisk) to boot Android (because rootdir is in system), and there is NO ramdisk in boot partition to access... unless it is added manually...

    But I certainly could be missing something... PW
    At the end of 2019, when I got my Xiaomi Mi 9T, I think it was MIUI 10/Pie and Magisk v19 or v20, I searched how to root.
    Since it's reporting Ramdisk=No (SAR yes, A/B no - I checked also querying by adb) and by following the Magisk Github documentation it was 'clear' I had to patch recovery, not boot

    Fortunately, I found two independent guides for my Mi 9T claiming that for Magisk one must patch boot.img - hence I happilly did the same, specially because I also use TWRP (in Recovery) in parallel

    Since then, I do it the same way through all MIUI updates (now on MIUI 12.6/A11 Xiaomi.eu) and all Magisk (Canary) updates

    I always wanted to test but never really tried what would happen if I patch Recovery instead (cannot test now since I'm now on weekly Xiaomi.eu beta that distributes without recovery.img in the zip, and their firmwares must be flashed through TWRP)

    I only tested updating Magisk by flashing the zip from TWRP, and it properly found and re-patched the Boot - however I never tried cold installation of Magisk from TWRP, would it properly imstall to Boot (but I think I've seen other users for my Mi 9T confirming it working well)

    Ofc, I don't know does it work the same way or 'all' Xiaomi phones
    2
    Does anyone know which version of Magisk still has the "Install in to inactive Slot (AfterOTA)? I know it was removed temporarily, having a difficult time finding the version before it it was removed.
    I believe it was 20.4
  • 12

    Latest Public (Stable / Beta)

    Release Notes and Changelog:


    2021.4.9 Magisk v22.1​

    This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.

    Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.

    Bug Fixes​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    🎉 👍 PW
    8
    @osm0sis
    Thank you for having an eye on that.
    Did the "ls" twice, first from a TWRP-terminal in recovery, second from a terminal while phone is "up and running".
    Looks like you have /dev/bootimg as your real partition location and it is still higher in the list in util_functions.sh like how I fixed it in the linked commit, so this is definitely a regression from some other recent change to Magisk.. sigh, I'll look into it. 🤔😕
    6
    #Xiaomi.eu, #OTA, #Magisk 22006, #Viper4Android, #sepolicy.rule

    This week, Xiaomi.eu weekly update 21.3.24 (MIUI 12.5, A11) was late a day and a half, hence I upgraded yesterday night

    As usual:
    - I downloaded the zip, extracted boot.img and patched (already from my previous Xiaomi.eu 21.3.18, rooted by Magisk 22006)
    - Flashed the Xiaomi.eu zip from TWRP, wiped Dalwik and Cache and rebooted
    - Then rebooted once again to TWRP and flashed the boot.img that was patched in advance

    I could probably flash its patched boot img right after flashing the 'OTA' zip (saving one time booting to the not-rooted system and rebooting to TWRP), but I rather play the safe and many times proven game

    Upon rebooting with the patched boot img, I have Magisk 22006 root again, with all modules (except V4A), root granted apps snd apps enabled for Magisk hide

    This time the old trick to make V4A did not work. Maybe because of the known sepolicy.rule bug in Magisk 22006, or maybe I was not 'patient' enough and made a mistake in steps

    Anyway, I also wanted to test, hence I modified V4A's post-fs-data.sh in accordance to:
    https://forum.xda-developers.com/t/...-0-viper4android-fx-2-7.3774651/post-84121895
    rebooted, and it did the trick 👍

    The modified post-fs-data.sh for:
    /data/adb/modules/ViPER4AndroidFX
    is zipped and attached

    The zip also contains DDC and Kernel folders to be copied ton Internalmemory: /Android/data/com.pittvandewitt.viperfx/files
    for V4A Convolvers and headphone profiles

    Hence now I have again AML, V4A plus another audio mode (320 kbps bitrate for my phone) and V4A is happilly again Supported and Proccessing (still in the Legacy mode)
    6
    No, the phone is an Estar Takee1.
    ROM is from here: Mikel Android 7 for Takee1
    and is itself a port from this ROM: RidonOS for Micromaxx A311

    You're right, sorry for that. Now here the installation log for canary-version:

    - Target image: /dev/BOOT
    - Device platform: armeabi-v7a
    - Installing: f152b4c2 (22005)
    nanddump: MEMGETINFO: Not a typewriter
    Parsing boot image: [boot.img]
    - Unpacking boot image
    ! Unsupported/Unknown image format
    ! Installation failed

    😛

    /dev/BOOT is known (usually) not an actual boot partition, hence nanddump failing.

    I had originally fixed this back here: https://github.com/topjohnwu/Magisk/commit/2aede97754fec67d393bde0c7725ed84d8c3c112

    So not sure if we're looking at some kind of a regression, or just a further edge case.

    @io2345 what's the actual, correct location of your boot partition? Please give me the output of `ls -alR /dev`
    6

    Latest Canary Changelog, including Release Notes:​


    Magisk (9c0e1897) (22007)​

    • [General] Fix logic to copy sepolicy.rule during module installation
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.

    Diffs to v22.0​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlock
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    👍 PW
  • 1046
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    155
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    119
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    74
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone