• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

zgfg

Senior Member
Oct 10, 2016
5,721
3,174
You can also manually ask the app to create the icon in Magisk Manager settings.
Then please a simple question, how/where to "ask the app to create the icon in Magisk Manager settings"?
Have you tried, where is that setting?

Screenshot from the repackaged Manager attached, there is only a setting to add shortcut but that is not the same as the proper icon for the app:
That shortcut (with standard Magisk icon) cannot substitute the ugly icon

Real (ugly icon for the repackaged Manager) provides long tap functionality: you can directly access (without opening Manager) Modules, Magisk Hide and SuperUser

By long tapping the shortcut, you only get Remove option, nothing else
 

Attachments

  • Screenshot_2020-10-04-08-00-25-077_kiohcaw.fydn.jpg
    Screenshot_2020-10-04-08-00-25-077_kiohcaw.fydn.jpg
    154.1 KB · Views: 372
Last edited:

CatThief

Senior Member
Apr 28, 2012
181
36
I just used the newly-redesigned Magisk Manager 8.0.0 to root my Pixel 4a with Magisk 21.0 and didn't have any trouble at all finding settings, etc, and I actually like the new UI. John did a darn good job, and I sure am happy to have my firewall and AdAway running again. Thank you John!
 

pndwal

Senior Member
Great, cos he beat me to the punch...
Cheers for the clarification

I was half worried people were just doing it because they thought they "had to"
Feature needed as bank etc app Devs don't trust SafetyNet (for obvious reasons) and employ their own means to detect root / modified environment including detection of root apps, TWRP folders etc, etc. Guess they would tell you you're rooted with nothing more than Manager installed unless hidden.
Many of us have been using the newer gui for a while on canary builds

You get used to it pretty quickly
+1. I liked UI for its extra features (device configuration details, etc) after I got used to it some time ago.

Nb. Some features that might seem to be missing are actually now on an as-needed-for-device basis. With better 'smarts' they won't show unless supported / needed.

An observation: I Just moved back to Canary after trying new Stable Manager and Beta MagiskSU. I initially had Manager 8.0.0 (301) Beta, then updated to 8.0.0 (302) Stable. I noticed that while otherwise looking identical w/ same basic version number 8.0.0, the Beta (301) showed 4 update channels, Stable, Beta, Canary and Custom, but after updating to Stable (302), settings only shows 3 channels, Stable, Beta and Custom. Since I'd updated I had to download Canary from GitHub. In Canary, 4 channels show again.

This change necessitating migrating to Canary via GitHub download may be intentional. PW
 
Mar 20, 2017
45
4
Trying to update from Magisk stable 20.3 to Magisk stable 20.4 inside the stable manager 8.0.0 results in an installation failed error. Flashing the 20.4 zip manually from twrp renders my device unusable after 20 or so seconds. (It looks like it's crashing systemui).
Android 5.1.1 TouchWiz, arm7. Do I need to log anything else apart from the install log below ?
View attachment 5109465
 

zgfg

Senior Member
Oct 10, 2016
5,721
3,174
@zgfg That the repackaged Manager uses the default ("ugly") Android icon is by design (but I'm sure you've read the FAQ already.
Of course I have read the FAQ - please did you read my post where I cited the FAQ , posted the screenshot from the Manager settings and simply asked where is that setting mentioned in the FAQ to create the icon (shortcut is not the same)
https://forum.xda-developers.com/showpost.php?p=83635161&postcount=41789

Btw, all who just point to FAQ and ask/comment like, have you read etc, did you try yourself first to be sure about?

Edit: Screenshot from the FAQ attached
 

Attachments

  • IMG_20201004_092431.jpg
    IMG_20201004_092431.jpg
    191.4 KB · Views: 408
Last edited:

Roll3r

Senior Member
Mar 7, 2006
731
260
Oakland, CA
Then please a simple question, how/where to "ask the app to create the icon in Magisk Manager settings"?
Have you tried, where is that setting?

Screenshot from the repackaged Manager attached, there is only a setting to add shortcut but that is not the same as the proper icon for the app:

Man this is from the FAQ. I didn't write the SW (obviously), I'm just pointing out where the, contrary to your opinion, "ugly icon" was in fact intentional

But, I'll hold your hand because I'm super bored because we're all stuck at home on account of forest fires shooting up the AQI and covid and we can only watch CNN to check if the president's dead or not

This is from memory, but it should be close enough
In Magisk, go to "settings". , do you see "hide Magisk Manager" or similar? Tap it
It'll ask you for a name for the hidden app. Enter whatever you want
From the app drawer, click on the "ugly icon" named whatever you chose
It's gonna tell you it needs to "download the full version" or something. Do that
Open the "ugly icon" again
It's going to ask you "Do you want a pretty icon"? Say yes if you want

Is it super straight forward? Nope! But I wouldn't say it's "hard"
 
Last edited:

Philnicolls89

Senior Member
Jun 28, 2019
634
267
32
A.C.T
Man this is from the FAQ. I didn't write the SW (obviously), I'm just pointing out where the, contrary to your opinion, "ugly icon" was in fact intentional

But, I'll hold your hand because I'm super bored because we're all stuck at home on account of forest fires shooting up the AQI and covid and we can only watch CNN to check if the president's dead or not

This is from memory, but it should be close enough
In Magisk, go to "settings". , do you see "hide Magisk Manager" or similar? Tap it
It'll ask you for a name for the hidden app. Enter whatever you want
From the app drawer, click on the "ugly icon" named whatever you chose
It's gonna tell you it needs to "download the full version" or something. Do that
Open the "ugly icon" again
It's going to ask you "Do you want a pretty icon"? Say yes if you want

Is it super straight forward? Nope! But I wouldn't say it's "hard"
The problem for me is that the 'pretty icon' app (that has been repacked and renamed) and the normal app both have the ugly android stub icon.
 

Didgeridoohan

Senior Moderator / Dev Committee / Dev Relations
Staff member
May 31, 2012
11,989
13,550
Gothenburg
Google Nexus 4
Nexus 6
Of course I have read the FAQ - please did you read my post where I cited the FAQ , posted the screenshot from the Manager settings and simply asked where is that setting mentioned in the FAQ to create the icon (shortcut is not the same)
https://forum.xda-developers.com/showpost.php?p=83635161&postcount=41789

Btw, all who just point to FAQ and ask/comment like, have you read etc, did you try yourself first to be sure about?

Edit: Screenshot from the FAQ attached

The setting mentioned is for the shortcut. That's all you get... If you're unhappy with how it's phrased in the FAQ you can submit a PR with suggested changes.

If you want full obfuscation of the Manager you'll have to live with the "ugly" icon. As I've already mentioned it's quite easy to make it pretty again...
 

zgfg

Senior Member
Oct 10, 2016
5,721
3,174
Man this is from the FAQ. I didn't write the SW (obviously), I'm just pointing out where the, contrary to your opinion, "ugly icon" was in fact intentional

But, I'll hold your hand because I'm super bored because we're all stuck at home on account of forest fires shooting up the AQI and covid and we can only watch CNN to check if the president's dead or not

This is from memory, but it should be close enough
In Magisk, go to "settings". , do you see "hide Magisk Manager" or similar? Tap it
It'll ask you for a name for the hidden app. Enter whatever you want
From the app drawer, click on the "ugly icon" named whatever you chose
It's gonna tell you it needs to "download the full version" or something. Do that
Open the "ugly icon" again
It's going to ask you "Do you want a pretty icon"? Say yes if you want

Is it super straight forward? Nope! But I wouldn't say it's "hard"
Man, I have gone through the hiding and unhiding Magisk Manager ten times the last days, I'm not guessing "something" like this or that, etc

And I'm also bored of repeating what is the difference between that "shortcut" and the "icon" in this case (I have them one by another on my Home screen)

Thank you for such help - I also know to read FAQ but before I started to write a word about here I carefully tested mysellf (!) and then just pointed to the observed issue and to the discrepancy between the way how it works compared to how it was described.

In addition to previous screenshots, now also a link to screenrocording, showing the whole process of Hiding Magisk Manager:
https://mega.nz/file/V0sVkCxY#RDOpE0sLAx9Z1zNUjHcFm2wHGOWPOAMBq-4Us9ZSjCM

- Observe that I had Magisk Chanary channel, and already Magisk Manager 303

- Upon hiding the Magisk Manager, it dropped to 302, asking me to update again to 303 (no big deal but strange)

- There is no setting to change the icon but only to install the Shortcut

- Shortcut installed (already while hiding, when it popped-up and asked for), but then observe a difference with the long tap functionality between the icon ('ugly' or maybe very nice to somebody, on the left) and shortcut (standard Magisk icon look, on the right)

Take care and let's consider this 'closed', this discussion made no progress
 
Last edited:

andrea0807

Senior Member
Jul 24, 2014
350
33
38
Perugia
I updated my poco F2 Pro to Android 11 today but magisk canary does not pass safetynet check.
I have the ROM xiaomi.eu weekly
How can I solve?
Screenshot_2020-10-04-14-18-21-207_com.topjohnwu.magisk.jpg

Inviato dal mio Redmi K30 Pro utilizzando Tapatalk
 
Last edited:

pndwal

Senior Member
I just used the newly-redesigned Magisk Manager 8.0.0 to root my Pixel 4a with Magisk 21.0 and didn't have any trouble at all finding settings, etc, and I actually like the new UI. John did a darn good job, and I sure am happy to have my firewall and AdAway running again. Thank you John!
Some context regarding Magisk Manager:

"Diareuse is officially the main maintainer of Magisk Manager"!
https://medium.com/@topjohnwu/state-of-magisk-2020-21de32721d65

This is a great read from a talented, modest developer, and a basic history of MagiskSU evolution from Systemless Xposed AND Magisk SU in 2016, to 2020 Magisk building.

So many thanks to John for arranging all this. :good:

... AND many thanks to Viktor De Pasquale, @diareuse, for his sterling (re)development of Magisk Manager! :good: :good: :good:

Kotlin code, edge2edge display support etc etc may mean more to others, but I'm liking it and appreciate that difficult decisions had to be made to boot!
John Wu
23 Jan

Also for those who ask to keep the old design as an option: no it won't happen. Due to technical reasons we cannot have 2 completely different components in the app (at least without significant effort). Also, we do not have the man power to maintain 2 completely different UIs.

wiki de pasquale, [@]diareuse

You will inevitably get [email protected]# for everything you do. Months of work flushed down the drain in the eyes of many users

John Wu

You just have to get used to it haha, I'm used to getting bashed LOL
So credit where credit is due! (And we shouldn't forget the huge contribution from Jorrit Jongma / @Chainfire, who continues to support John's MagiskSU, as well as those of Devs like @DVDandroid and @digitalhigh, who John also acknowledges here. :good: :good: )

... I'm certainly glad the two of you "continue to enjoy the fun of hacking things around while it lasts"... Cos I do too! PW
 
Last edited:
  • Like
Reactions: duttyend

dcarvil

Senior Member
Apr 20, 2016
467
247
Thank you for your reply, but I'm a bit confused. The OTA is currently residing in the inactive slot, but the procedure you described here will effect the currently active slot will it not?
Maybe it would be easier to rollback my Magisk+Manager to a version that still supported "Install to Inactive Slot" as that seemed to take care of all this automatically.
What would you suggest ?
Jake

I did a reboot after the OTA, which makes the OTA update the current slot. This causes the loss of Magisk, which was not a big deal for me. Then I patched boot.img using Magisk 21, and flashed it to the boot partition. Reboot again, and back in business. There are probably other ways to do it, but this is what worked for me.
 

Spartacus500

Senior Member
Nov 6, 2014
555
101
The new version of magisk manager 8.0.0 is amazing ? beautiful UI appearance, and most importantly, it hides the root beautifully for the app :highfive:
 

Top Liked Posts

  • 10
    MOD ACTION:

    Enough is enough. Despite my deleting some off topic posts yesterday, the spam continues. Thread cleaned. Please check your PM inbox and avoid off topic posts.
    3
    This is based on John's repo.
    I am not sure if vvb2060's alpha build require Zygisk active for enabling DenyList.
    AFAICS it does, at least for now.

    I believe ptrace was used previously for this; new Magisk needs Zygisk; I don't think we'll have an option in future since all ptrace code is gone... unless it comes back. vvb2060 OP note re. this here:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85643797

    ... 'n please don't team up on me; my Android reflexes are abominably slow and I might just go sulk in the carpark... Marvin.
    3
    Need quick help with the installation instructions https://topjohnwu.github.io/Magisk/install.html

    Under "Patching Images" it says I need the boot.img (cause my OP 5T has RAM disk), but where can I download it?

    Thanks in advance

    Edit: I'm running lineage OS with microG
    From the LOS install zip file.
    Unzip that file, you should find a boot.img in there. That's what Magisk needs.
    If you have a boot.img.br file, just uncompress it first with brotli.
    2
    For those running vvb2060's alpha builds.

    You should be able to install any of the alpha builds over each other.
    The versionName is changing GitShortHead-alpha.
    The versionCode is remaining 23001.

    The versionCode is what triggers the upgrade/downgrade install.
    PackageManager only see that you are re-installing version 23001. ;)

    With that being said, you might run into a problem with magisk.db that was generated by an older/newer build.
    There was a very recent commit about this. (Currently the last commit on John's repo.)​
    Magisk - GitHub - commit - f7c0e40
    Also the last commit in vvb2060's repo currently.


    You might have an issues repacking a Magisk boot image.
    For testing purposes you should always use your ROM's stock boot image.
    Yes testing the updating logic is important but, you need a base line to compare.​
    A clean install may fail when an update succeeds and vice versa.

    Cheers all. :cowboy:
    Good to know, thx

    Hopefully, if I make a copy of /data/adb/magisk.db before trying the next Alpha, I will be able to restore the database if I would have to go back to b6298f86-alpha
    1
    Hi,

    Does snapchat work with the Magisk and corresponding modules for hiding? I've been out of rooting scene for long, so I don't know. The last time snapchat was able to detect it.

    Thanks.
  • 44
    OK. AIO solution. Modded "Universal SafetyNet Fix" module. Just added "model" props.
    17
    So, new layer of HARDWARE detection is here.
    SafetyNet failed on devices, where must bee HARDWARE detection. GMS no longer check system response of evaluation type, and force check HW. USNF doesn't work in this cause.
    Hm, funny things happening. I was thinking this is upgrade of HW attestation, but it is DOWNGRADE actually. 😄

    Remember my old first simple digging into HW?
    It`s..... working again.

    Looks like a temporary solution or just "combo" of old and new methods from Google.
    This explains the fact that dirty hack with Xposed-s working now.

    So, this current environment may be temporary or preparation for something BIGGER.

    In conclusion: in this time to passing SafetyNet you need just my old "hardware_off" module from link above or "MagiskHidePropsConf" with any "BASIC" print with model simulation and kdrag0n-s "Universal SafetyNet Fix".

    No ***-posed-s need!
    16
    Few Headsups:

    1) There are reports that Danny's (@kdrag0n) new early release Universal SafetyNet Fix 2.0.0 (combines AOSP Keystore and shim Keystore solutions) is restoring ctsProfile for some. It just may work for all, but not enough reports as yet. Also, it requires a payment at this stage:
    https://forum.xda-developers.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/post-85581909

    https://github.com/kdrag0n/safetynet-fix/pull/13#issuecomment-904209677

    2) There are reports that simply using MagiskHide Props Config module to 'delete' ro.product.model prop fixes ctsProfile on custom ROMs where other methods have failed. Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912885628

    3) New MagiskHide Props Config module 6.0.0 just released with all the sensitive prop values that MagiskHide changed up to and including Magisk v23 set by default, "Force BASIC key attestation" re-enabled (for Googles latest changes), and various other fixes.
    https://forum.xda-developers.com/t/...p-edits-and-more-v6-0-0.3789228/post-85581939

    I have to agree that this module's name does suddenly seem very apt, and as always, it proves elegant in its versatility. 😛👍

    4) Another elegant solution that some may have relegated to a bygone era seems to be coming back in fashion to!

    Those with Google Pay problems persisting after fixing ctsProfile are reporting in GPay threads, here and elsewhere, that GPay-SQLite-Fix + SQLite binary modules from stylemessiah (a connoisseur at least in digital fashion ... or perhaps just lucky, our @73sydney, - original solution from @BostonDan ) is fixing these for them once again. 😜 Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912798412

    WOT 😉 to read if interested:
    https://forum.xda-developers.com/t/...s-of-gms-17-1-22-on-pie.3929950/post-79643248

    🤠 PW
    15
    ro.product.model was enough for my OP8T, but I didn't like how Google Play Services started referring to my device as "OnePlus BASIC" with the "hardware off" module, so I knocked together this module really quickly to just append _SN to the real model name. WFM. 🤘
    14
    Removed the @Displax safety net mod fix and applied the latest USNF 2.1.0 from @kdrag0n.

    Attestation is passed and device is compliant in company portal too with my original device name 1+8 Pro and not Pixel.

    This is done over the latest Alpha Magisk.

    Update: My In-display fingerprint hardware is not working anymore, I think the fix is already committed. Hopefully it will be resolved in the next version.
    Yep, I have sent a Pull Request with the fix like an hour after v2.1.0 was released. 🤠

    See my post here in the official USNF thread for getting it working in the meantime until it's merged and a new release is made: https://forum.xda-developers.com/t/...tynet-fix-1-1-0.4217823/page-59#post-85631613

    Also may be worth everyone reading my comments at the end of that post about people doubting the sponsored testing closed-then-open development.

    And then here on this GitHub issue about how it's not meant to replace MagiskHide so you can't just turn Hide off: https://github.com/kdrag0n/safetynet-fix/issues/91#issuecomment-919264624
  • 1062
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p