Magisk General Support / Discussion

Search This thread

DiamondJohn

Recognized Contributor
Aug 31, 2013
4,956
4,223
243
Sydney
Do you have "auto-update" turned off in Google Play settings?

I don't remember if Play Services shows up in list of apps with updates. If it does, I probably take it because at some point update refuses to work with outdated Services.

In Android Settings -> Apps, Play Services has a button to uninstall updates. Maybe you can use that.
I am going to *GUESS* that the playstore will update regardless of the auto updates setting, its too important/dangerous for google to allow you to not update it. I have never seen the playstore in the list of available updates, I think it updates at the very start of the playstore if there is one available; i.e. no chance to show in a list.

I built a play store detach method, and I have never tested it on the playstore (and actually excluded it in the first release) which has the GMS as an option to be detached. Might be worth a try. ==> TeMeFI
 
  • Like
Reactions: J.Michael

curiousrom

Recognized Contributor
Play Services Auto-Updates

...Is there any way to stop google play services from updating itself ? I want to keep old version of gms.
Do you have "auto-update" turned off in Google Play settings?

I don't remember if Play Services shows up in list of apps with updates...
I am going to *GUESS* that the playstore will update regardless of the auto updates setting, its too important/dangerous for google to allow you to not update it. I have never seen the playstore in the list of available updates, I think it updates at the very start of the playstore if there is one available; i.e. no chance to show in a list...

Google Play & Google Services updates themselves automatically regardless if you chose Don't auto-update apps automatically or not in Google Play Store's settings & regardless if Play Store is at the foreground or not.

I observed the downloading of Play services in the notifications on both Galaxy S5 G900M LineageOS 17.1 klte + Open GApps Pico and on a S5 Mini with stock Samsung 6.0.1 with my Don't auto-update apps automatically setting.

Never saw Play Services in the list of apps with available updates in Play Store.
***
 
Last edited:

johnybravojr

Senior Member
Dec 8, 2009
270
77
48
magisk 21.2
magisk manager 8.0.5(4802)
running
magiskHide props config 5.4.0-v113
universal safetynet fix 1.0.2 by kdragon
hardware off 1.1 by displax

if i am not mistaken iam up to date. this just happened... probably i am the first to report?
I had everything working using the earlier Carary Build. I updated to the latest Canary Build yesterday (direct install), and now many of my apps are force-closing, most banking apps are detecting root, and MagiskHide list is getting automatically unchecked. Everything's messed up now. Looks like this issue is with the Magisk update, and not with the updated banking apps. And lesson learned: don't try to fix what is not broken!
 
  • Like
Reactions: fobtob387

DiamondJohn

Recognized Contributor
Aug 31, 2013
4,956
4,223
243
Sydney
I had everything working using the earlier Carary Build. I updated to the latest Canary Build yesterday (direct install), and now many of my apps are force-closing, most banking apps are detecting root, and MagiskHide list is getting automatically unchecked. Everything's messed up now. Looks like this issue is with the Magisk update, and not with the updated banking apps. And lesson learned: don't try to fix what is not broken!
Its CANARY! by definition its about fixing things so that tfuture functionality can be implemented. Possibly beta or stable would be a better choice. I personally am only on beta as I am on A11, otherwise I'd onl.y install stable.
 

zgfg

Senior Member
Oct 10, 2016
4,970
2,259
233
Its CANARY! by definition its about fixing things so that tfuture functionality can be implemented. Possibly beta or stable would be a better choice. I personally am only on beta as I am on A11, otherwise I'd onl.y install stable.
Stable is now also on 21200 (same as Beta) and therefore as well good for A11
 
Last edited:
  • Like
Reactions: DiamondJohn

johnybravojr

Senior Member
Dec 8, 2009
270
77
48
Its CANARY! by definition its about fixing things so that tfuture functionality can be implemented. Possibly beta or stable would be a better choice. I personally am only on beta as I am on A11, otherwise I'd onl.y install stable.
I'm aware of that, but in the past, I've had apps detecting root on stable versions of Magisk. So I switched to Canary, which solved the problems.
 

pndwal

Senior Member
Jun 23, 2016
2,057
1,218
163
Sydney
Xiaomi Redmi Note 7
Universal SafetyNet Fix update:
Latest release
v1.1.1
@kdrag0n released this 4 hours ago

Changes
- Removed security patch fixup to fix CTS profile mismatches on some devices

Some devices will now need to use MagiskHide Props Config in addition to this module in order to pass CTS profile checks as part of basic attestation. Altering the CTS profile is no longer in scope for this module as it breaks more devices than it fixes
NB. As Danny indicates here, MHPC remains a vital cog in Magisk's MH gearbox. PW
 

potan

Member
Oct 17, 2010
28
3
23
i cannot hide magisk manager in miui 8.1.4.0 android 6.0 marshmallow,
the device Mi5
os miui 8.1.4.0 android 6.0
latest magisk 21.2

what i have try:
-clean install, no internet connnection turn off play protect and setenforce 0
-clean install, turn on internet connection, let gapps update to latest, turn off play protect and setenforce 0
-clean install, turn on internet connection, don't let gapps update to latest, turn off play protect and setenforce 0

can it be fixed? or some workaround?
after searching for a whole day most of i found fixed with setenforce 0 and turn off play protect.
 
i cannot hide magisk manager in miui 8.1.4.0 android 6.0 marshmallow,
the device Mi5
os miui 8.1.4.0 android 6.0
latest magisk 21.2

what i have try:
-clean install, no internet connnection turn off play protect and setenforce 0
-clean install, turn on internet connection, let gapps update to latest, turn off play protect and setenforce 0
-clean install, turn on internet connection, don't let gapps update to latest, turn off play protect and setenforce 0

can it be fixed? or some workaround?
after searching for a whole day most of i found fixed with setenforce 0 and turn off play protect.
You serched for a day and didn't find this thread? https://forum.xda-developers.com/t/...etynet-fix-1-1-0.4217823/page-7#post-84299679
 

pndwal

Senior Member
Jun 23, 2016
2,057
1,218
163
Sydney
Xiaomi Redmi Note 7
Latest Canary:

Jan 15

Magisk (04c53c35) (21203)
- Workaround f2fs bugs in Linux that causes bootloops

Magisk Manager (04c53c35) (4818)
- Update scripts for the said fix mentioned above

Jan 17

Magisk (2f5331ab) (21301)
- Sync with public release

Magisk Manager (2f5331ab) (4828)
- Sync with public release

Latest Beta / Stable:

Release Notes

2021.1.16 Magisk v21.3

Happy 2021! v21.3 adds a workaround for devices with buggy F2FS Linux kernel drivers. This F2FS bug may cause bootloops on many devices. Checkout the full v21.0 release notes if coming from older releases.

Magisk Changelog

v21.3
- [MagiskInit] Avoid mounting f2fs userdata as it may result in kernel crashes. This shall fix a lot of bootloops
- [MagiskBoot] Fix a minor header checksum bug for DHTB header and ASUS blob image formats
- [MagiskHide] Allowing hiding isolated processes if the mount namespace is separated

Magisk Manager Changelog

v8.0.5
- fix sepolicy rule copying

V8.0.6
- Minor UI changes
- Update internal scripts

👍 PW
 
Last edited:

curiousrom

Recognized Contributor
Universal SafetyNet Fix v1.1.1 is now available.

Changes
  • Removed security patch fixup to fix CTS profile mismatches on some devices

Download

Some devices will now need to use MagiskHide Props Config in addition to this module in order to pass CTS profile checks as part of basic attestation. Altering the CTS profile is no longer in scope for this module as it breaks more devices than it fixes.

If this module helped you, please consider a recurring donation for sustainable support, or alternatively buy me a coffee. Everything helps, but a recurring donation is the best way to keep the project alive in the long term.

Issues on heavy OEM skins
This is a reminder that heavy OEM skins are not officially supported. They may happen to work depending on your luck and the particular ROM in question, but nothing is guaranteed. Please do not report problems on such ROMs. It's surprising that it works at all on them; I wouldn't expect everything to be fully working. I will not provide more support for issues related to heavy OEM skins.

The compatibility issue does not lie in the SafetyNet fix itself, but rather how the Magisk module is built. It's possible to make the Magisk module version of the fix slightly more portable, but I have no interest in supporting heavy OEM skins, nor do I have any devices running such ROMs.

You will always have the best luck with a ROM not too far from AOSP, e.g. most custom ROMs and Pixel stock ROMs.
 

Spartacus500

Senior Member
Nov 6, 2014
539
96
58
After updating to the latest version of Magisk 21.3, I have a problem with the selected root stealth applications, they are hidden, but not checked in Magisk hide, and in the log such info:
Screenshot_20210116-165039.jpgScreenshot_20210116-165319.jpg
 
  • Like
Reactions: fobtob387

zgfg

Senior Member
Oct 10, 2016
4,970
2,259
233
Updated from Canary 21202 to 21203, but no good - Viper4Android shows Status Abnormal

That's why I never update directly nor flash through TWRP but patch an image and keep for a while - flashed my yesterday's 21202 patched and Status is back to Normal

Xiaomi.eu A11 beta
With today's 21203 Viper4Android also does not work: Status Abnormal

I can simply reflash between my various saved patched boot images back and forth, last version of Magisk where V4A works is 21202

Anybody else here using V4A, and how is V4A for you?
 

thomas140

Senior Member
Jul 3, 2018
641
139
43
Johor
With today's 21203 Viper4Android also does not work: Status Abnormal

I can simply reflash between my various saved patched boot images back and forth, last version of Magisk where V4A works is 21202

Anybody else here using V4A, and how is V4A for you?
I already faced this issue since 21.2.
Resolved by changing selinux status to permissive.
No issue after 21.3 also
 

Lughnasadh

Senior Member
Mar 23, 2015
1,992
1,286
143
Google Nexus 5
LG Nexus 5X
With today's 21203 Viper4Android also does not work: Status Abnormal

I can simply reflash between my various saved patched boot images back and forth, last version of Magisk where V4A works is 21202

Anybody else here using V4A, and how is V4A for you?
Still working for me on Magisk Beta 21.3. Previously I had installed through the Magisk Repo and when Beta 21.2 came out it broke it. I uninstalled that V4A version and reinstalled by just installing the apk (2.7.2.1) and it worked and is still working with 21.3. I also had JamesDSP, AML, and ACP installed prior to reinstalling the 2.7.2.1 apk.

Using Pixel 4 XL, stock Android 11 (January update).
 
  • Like
Reactions: zgfg

Top Liked Posts

  • 2
    I have upgraded from 22002 to 22100. Everything is fine. But in 22.1 I have no possibility to choice canary version. The user based url https://raw.githubusercontent.com/topjohnwu/magisk_files/canary/debug.json doesn't work. Is there a special mm apk for 22.1?
    All later Magisk builds are a Stand Alone (no need for internet connection / json files to downgrade), single package solution, both debug (Canary) builds (from 22402):
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84354959
    and public (Stable/Beta) from 22.0:
    https://topjohnwu.github.io/Magisk/releases/22000.html

    For older stable builds, unless Installing .zip package from custom recovery you'd need hosted address of corresponding raw json file pasted in 'Custom Channel'. Older Canary Jsons won't work this way without editing and re-hosting as they always point to (common) address for LATEST Canary build rather than unique address.

    But you can forget all that! 😆

    All you need to do is click on Magisk Canary, under Downloads on Magisk main page on GitHub, and .apk will download! Just Install it.

    FYI Canary builds, being 'bleeding edge' builds for debug purposes, are not considered Public builds, so Canary Channel won't appear in Magisk App (Settings) from Beta / Stable Public Releases. Debug builds contain all channels. 🤠 PW
    1
    Yes, I'm aware you have Magisk in boot ramdisk. I think you did from the beginning of this discussion. But since you said you did direct update with Recovery mode checked, I was curious whether that succeeded


    IMO, its just a very obvious and very basic logic:

    1) If you (not yourself) patch boot img, then Recovery mode must not be checked, and resulted magisk_patched.img must be flashed to Boot

    2) If you patch recovery.img, then Recovery mode must be checked in, and resulted magisk_patched.img must be flashed to Recovery

    1a) If you originally installed Magisk by (1) , then always update Magisk again by repeating (1), not (2).
    Or if you opt for Direct update, then Recovery mode must not be checked in - like originally when it wasn't checked for (1)

    2a) If you originally installed Magisk by (2), then always update Magisk again by repeating (2), not (1).
    Or if you opt for Direct update, then Recovery mode must be checked in - like originally when it was checked for (2)

    Sorry but any other combination for me is simply out of mind and asking for troubles, like:
    - patching boot.img but with Recovery mode checked in
    - flashing the patched recovery img but to Boot partition
    - originally patching and flashing boot img but later forcing Recoveey mode while taking Direct update
    - etc

    One can experiment, nice, but please later don't cry why Magisk did not update, why bootloop, how to fix, and so on 🤓
    1
    The latest magisk 21.2 when I install it xposed moudel is not working (activated in edexposed managet ) riru edxposed yahfa 0.4.6.4 4563 instaled . riru 21.3 as riru 23.1 causes that exposed moudel not working… . so I am back to magisk 20.4 working perfect any fix to instal the latest magisk my device redmi k20 pro premium edition miui 12.0.6 eu
    fixed for me on my phone (rig see below) with Magisk v22.1 - thank you @topjohnwu !!!
    1
    1) Obviously.
    2) As specified / already mentioned I would have mentioned it if I had known it before. I thought it was a general problem.
    3) Sure, that would be plan B.
    Good result (so far)!

    Got Regression label, getting attention... 👍

    ... all while John blissfully studies Rust / Kotlin and plays Toki tori with Apple Music drowning out the cries for help with a 'Smart' washing machine refusing to start because it identifies unlocked bootloader as 'Root' on a ThinQ ... 😛

    😆 PW
  • 12

    Latest Public (Stable / Beta)

    Release Notes and Changelog:


    2021.4.9 Magisk v22.1​

    This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.

    Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.

    Bug Fixes​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    🎉 👍 PW
    8
    @osm0sis
    Thank you for having an eye on that.
    Did the "ls" twice, first from a TWRP-terminal in recovery, second from a terminal while phone is "up and running".
    Looks like you have /dev/bootimg as your real partition location and it is still higher in the list in util_functions.sh like how I fixed it in the linked commit, so this is definitely a regression from some other recent change to Magisk.. sigh, I'll look into it. 🤔😕
    6
    #Xiaomi.eu, #OTA, #Magisk 22006, #Viper4Android, #sepolicy.rule

    This week, Xiaomi.eu weekly update 21.3.24 (MIUI 12.5, A11) was late a day and a half, hence I upgraded yesterday night

    As usual:
    - I downloaded the zip, extracted boot.img and patched (already from my previous Xiaomi.eu 21.3.18, rooted by Magisk 22006)
    - Flashed the Xiaomi.eu zip from TWRP, wiped Dalwik and Cache and rebooted
    - Then rebooted once again to TWRP and flashed the boot.img that was patched in advance

    I could probably flash its patched boot img right after flashing the 'OTA' zip (saving one time booting to the not-rooted system and rebooting to TWRP), but I rather play the safe and many times proven game

    Upon rebooting with the patched boot img, I have Magisk 22006 root again, with all modules (except V4A), root granted apps snd apps enabled for Magisk hide

    This time the old trick to make V4A did not work. Maybe because of the known sepolicy.rule bug in Magisk 22006, or maybe I was not 'patient' enough and made a mistake in steps

    Anyway, I also wanted to test, hence I modified V4A's post-fs-data.sh in accordance to:
    https://forum.xda-developers.com/t/...-0-viper4android-fx-2-7.3774651/post-84121895
    rebooted, and it did the trick 👍

    The modified post-fs-data.sh for:
    /data/adb/modules/ViPER4AndroidFX
    is zipped and attached

    The zip also contains DDC and Kernel folders to be copied ton Internalmemory: /Android/data/com.pittvandewitt.viperfx/files
    for V4A Convolvers and headphone profiles

    Hence now I have again AML, V4A plus another audio mode (320 kbps bitrate for my phone) and V4A is happilly again Supported and Proccessing (still in the Legacy mode)
    6
    No, the phone is an Estar Takee1.
    ROM is from here: Mikel Android 7 for Takee1
    and is itself a port from this ROM: RidonOS for Micromaxx A311

    You're right, sorry for that. Now here the installation log for canary-version:

    - Target image: /dev/BOOT
    - Device platform: armeabi-v7a
    - Installing: f152b4c2 (22005)
    nanddump: MEMGETINFO: Not a typewriter
    Parsing boot image: [boot.img]
    - Unpacking boot image
    ! Unsupported/Unknown image format
    ! Installation failed

    😛

    /dev/BOOT is known (usually) not an actual boot partition, hence nanddump failing.

    I had originally fixed this back here: https://github.com/topjohnwu/Magisk/commit/2aede97754fec67d393bde0c7725ed84d8c3c112

    So not sure if we're looking at some kind of a regression, or just a further edge case.

    @io2345 what's the actual, correct location of your boot partition? Please give me the output of `ls -alR /dev`
    6

    Latest Canary Changelog, including Release Notes:​


    Magisk (9c0e1897) (22007)​

    • [General] Fix logic to copy sepolicy.rule during module installation
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.

    Diffs to v22.0​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlock
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    👍 PW
  • 1045
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    155
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    119
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    74
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone