Magisk General Support / Discussion

Search This thread

DiamondJohn

Recognized Contributor
Aug 31, 2013
4,956
4,222
243
Sydney
Alright so huge update; everything now works! How did I do it?

I switched from using Command Prompt to PowerShell. I don't even know what made me figure out to give that a try, but it worked!

Mystery solved for anyone else that ever has this problem!
Im happy to hear it all now works for you, however, thats the opposite of "mystery solved" as to why it wasnt working before. But it certainly is a path for others who end up in the same dead end as you. (y)
 
  • Like
Reactions: daddylonglegs

daddylonglegs

Senior Member
Oct 23, 2009
488
101
63
Vermont
Im happy to hear it all now works for you, however, thats the opposite of "mystery solved" as to why it wasnt working before. But it certainly is a path for others who end up in the same dead end as you. (y)

Yep! Figured I would post the fix for anyone that ever has the problem.

The only issue now is when Magisk is enabled, my entire phone freezes shortly after booting into Android. I only have 3 modules installed. Universal Safetynet Fix module (v 1.1.1), Systemless Hosts and MagiskHide Props Config.

Any clue why this would be locking my phone up?
 

arkadius41

Senior Member
May 19, 2009
252
13
48
Hi there. Could sb help with proper installation on my device Huawei Mediapad M3, LineageOS-17.1 & twrp-3.3.1-3. Just can't go any further and stop on that below
Screenshot_20210119-131626_Magisk_Manager.png
Screenshot_20210119-131616_Magisk_Manager.png
 

DiamondJohn

Recognized Contributor
Aug 31, 2013
4,956
4,222
243
Sydney
Yep! Figured I would post the fix for anyone that ever has the problem.

The only issue now is when Magisk is enabled, my entire phone freezes shortly after booting into Android. I only have 3 modules installed. Universal Safetynet Fix module (v 1.1.1), Systemless Hosts and MagiskHide Props Config.

Any clue why this would be locking my phone up?
First you question, I dont personally have a clue. Have you tried the magisk boot log?

And just to help others who have your problem, did you have to do the "fastboot flash boot boot_image..." or did the "fastboot flash boot_image.img" work (or whatever it was)?
 

daddylonglegs

Senior Member
Oct 23, 2009
488
101
63
Vermont
OK it seems as though my phone is locking up because Magisk somehow changed my active boot slot?

So when I flashed the patched magisk boot file, I used this command:

Code:
fastboot flash boot magisk_patched_qfngE.img --slot all

I did that because someone here recommended I try that.

After doing that, I noticed my phone now tries boot from slot A. It was previously always slot B.

I tried this command:

Code:
fastboot --set-active=b

which seemed to work, but when my phone reboots, it defaults back to slot A, which is where I get the constant hard lockups in Android.

Does anyone know what's up and what I can do to fix this?
 

Yahoo1

Senior Member
Jul 6, 2014
94
89
38
Yep! Figured I would post the fix for anyone that ever has the problem.

The only issue now is when Magisk is enabled, my entire phone freezes shortly after booting into Android. I only have 3 modules installed. Universal Safetynet Fix module (v 1.1.1), Systemless Hosts and MagiskHide Props Config.

Any clue why this would be locking my phone up?
Maybe wipe everything and start installation from scratch after all your mishaps. Btw the PowerShell use is pretty interesting solution of your previous problem. I mean why Command Prompt was not enough...
 
  • Like
Reactions: daddylonglegs

daddylonglegs

Senior Member
Oct 23, 2009
488
101
63
Vermont
Maybe wipe everything and start installation from scratch after all your mishaps. Btw the PowerShell use is pretty interesting solution of your previous problem. I mean why Command Prompt was not enough...

I appreciate it but there's no way I am wiping my data. Too many important things; even just the way I have the phone set up would be a nightmare to re-do.

I think doing the fastboot flash boot magisk_patched_qfngE.img --slot all command is what screwed my phone up. "--slot all" installs Magisk to both slots and it for whatever reason changed my phone to always boot from slot A.

Is there a way to reverse this? Flash the January 2021 firmware to both slots maybe? How do I do that? Do I have to make each slot active and then run flash-all.bat ?
 

AndDiSa

Senior Member
Dec 2, 2009
3,477
4,554
268
Heidelberg
@daddylonglegs as I already tried to explain to you: the Pixel 3a has two boot slots for seamless updates, i.e.
- before the update it starts e.g. from slot A
- after the update slot B is activated and the phone tries to start from slot B
if for whatever reason the phone cannot boot, slot B will be marked as 'bad' and the phone will automatically start from slot A again.

Flashing to both slots in parallel is not needed / recommended as there is also a ramdisk / system / ... connected to slot B and if those are not compatible to the boot image you have just flashed it will mark automatically the slot as 'invalid' and will fall back to the other one ...
 

daddylonglegs

Senior Member
Oct 23, 2009
488
101
63
Vermont
@daddylonglegs as I already tried to explain to you: the Pixel 3a has two boot slots for seamless updates, i.e.
- before the update it starts e.g. from slot A
- after the update slot B is activated and the phone tries to start from slot B
if for whatever reason the phone cannot boot, slot B will be marked as 'bad' and the phone will automatically start from slot A again.

Flashing to both slots in parallel is not needed / recommended as there is also a ramdisk / system / ... connected to slot B and if those are not compatible to the boot image you have just flashed it will mark automatically the slot as 'invalid' and will fall back to the other one ...

OK thank you.

Maybe I should stop trying to install Magisk from ADB. I believe there is a way to boot to the patched image, and then install Magisk in the app? Is that correct? If so is there a link on how to install that way instead of flashing the patched boot?
 

AndDiSa

Senior Member
Dec 2, 2009
3,477
4,554
268
Heidelberg
@daddylonglegs no, you need to upload the original boot.img (which is exactly matching the OS you are running) to a running phone where Magisk-Manager is installed. Then you need to patch that image, get it back to your PC and flash it into the currently active slot (e.g. flashing without any --slot parameter). After that you can boot your phone and it's rooted with Magisk.
 
  • Like
Reactions: daddylonglegs

daddylonglegs

Senior Member
Oct 23, 2009
488
101
63
Vermont
@daddylonglegs no, you need to upload the original boot.img (which is exactly matching the OS you are running) to a running phone where Magisk-Manager is installed. Then you need to patch that image, get it back to your PC and flash it into the currently active slot (e.g. flashing without any --slot parameter). After that you can boot your phone and it's rooted with Magisk.

That's what I am doing. My phone hard locks whenever it boots and Magisk is installed. Flashing the original boot.img file, my phone works fine. Flashing the Magisk one makes my phone freeze up about a minute into being inside Android 11.
 

AndDiSa

Senior Member
Dec 2, 2009
3,477
4,554
268
Heidelberg
Most likely it's related to Systemless hosts. I had this freezing from time to time, too, but since about two weeks it's working fine (even with systemless hosts enabled). Try to run without systemless hosts (at least for some time) and see whether this fixes your issues.
 
  • Like
Reactions: daddylonglegs

Homeboy76

Senior Member
Aug 24, 2012
2,498
1,208
188
OK thank you.

Maybe I should stop trying to install Magisk from ADB. I believe there is a way to boot to the patched image, and then install Magisk in the app? Is that correct? If so is there a link on how to install that way instead of flashing the patched boot?
Using a windows computer, try:
- unhide magisk
- uninstall Magisk --> Restore Images
- opening File Explorer
- click the platform-tools folder
- click the folder (left side of address bar) to highlight the address
- type cmd and press enter.
- at the prompt type:
- fastboot flash boot magisk_patched_xxxx.img
 
Last edited:
  • Like
Reactions: daddylonglegs

zgfg

Senior Member
Oct 10, 2016
4,969
2,259
233
Will my Adblocker still work OK?

Also how do I uninstall the module? The adb wait-for-device shell magisk --remove-modules command does nothing for me in PowerShell. I press enter and nothing happens.
If your system is read-only (e g. A11), AdAway will not work without Systemless hosts

To disable, open Magisk Manager, modules tab, find Systemless hosts, disable its button and reboot

You can also disable by some root explorer like MiXplorer or from TWRP by putting an empty file named disable (exactly as that) to the folder:
/data/adb/modules/hosts
(always reboot)

Disabling through Magisk Manager does the same, putting that disable file.
Enabling just removes the disable file
 
  • Like
Reactions: daddylonglegs

zgfg

Senior Member
Oct 10, 2016
4,969
2,259
233
Update: phone locks up with only Universal Safetynet Fix module (v 1.1.1) installed. FML.
If you have TWRP, you can disable as was described for Systemless hosts.
This time you put disable file to the folder:
/data/adb/modules/safetynet-fix (not sure about the exact folder name but you will see)

Or disable all modules by booting to Safe Android mode, then to normal mode (you will also have to re-enable Magisk hide)

Or remove all modules by adb command - everything is described in Magisk Wiki on Github, pls read and learn 👍
 

daddylonglegs

Senior Member
Oct 23, 2009
488
101
63
Vermont
So try no modules first. And did you make sure to patch boot.img from correct factory zip file? Is it the same version you have on your phone now? I know it probably is, I am just running out of ideas here...

First I want to say thank you so much to you and all the other strangers that have been trying to help me. You have no idea how much I appreciate it. I try to pay it forward in my everyday life. :)

I definitely am using the proper boot file from the latest firmware. I checked and redownloaded a half dozen times just to make sure.

With no modules, my phone works fine. I just installed Systemless Hosts and Riru, and rebooted and no lockups. This says to me the issue is Universal Safetynet Fix module (v 1.1.1) .

This is very unfortunate because passing SafetyNet is really important to me. I can live without it for a bit and maybe the next version of Universal Safetynet Fix will not lock up my phone. But what if it does? Is there any way to just remove a single module instead of removing them all with that ADB command?

If you have TWRP, you can disable as was described Systemless hosts.
This time you put disable file to the folder:
/data/adb/modules/safetynet-fix (not sure about the exact folder name but you will see)

Or disable all modules by booting to Safe mode, then to normal mode (you will also have to re-enable Magisk hide)

Or remove all modules by adb command - everything is described in Magisk Wiki on Github

Unless I am missing something I thought TWRP hasn't worked in forever? Since like, Android 9 or something?
 
  • Like
Reactions: Yahoo1

zgfg

Senior Member
Oct 10, 2016
4,969
2,259
233
Id there any way to just remove a single module instead of removing them all with that ADB command?

Unless I am missing something I thought TWRP hasn't worked in forever? Since like, Android 9 or something?
The adb command:
adb wait-for-device shell magisk --remove-modules

uninstalls all modules - but you can easily reinstall what you need

Or use Android Safe mode, then normal boot, then remove or enable modules from your Magisk Manager (you must also enable Magisk hide)

For TWRP it depends if it was ported to your device

Latest official TWRP 3.5 supports A11 but again, must be ported to your device - check on your device forum and on https://dl.twrp.me

For SafetyNet Fix google, search on XDA or scroll back for few days in this thread to find its XDA thread.
Ask there why your phone bootloops with or if there is some special test version you could try for your phone
 
Last edited:

Top Liked Posts

  • 2
    I have upgraded from 22002 to 22100. Everything is fine. But in 22.1 I have no possibility to choice canary version. The user based url https://raw.githubusercontent.com/topjohnwu/magisk_files/canary/debug.json doesn't work. Is there a special mm apk for 22.1?
    All later Magisk builds are a Stand Alone (no need for internet connection / json files to downgrade), single package solution, both debug (Canary) builds (from 22402):
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84354959
    and public (Stable/Beta) from 22.0:
    https://topjohnwu.github.io/Magisk/releases/22000.html

    For older stable builds, unless Installing .zip package from custom recovery you'd need hosted address of corresponding raw json file pasted in 'Custom Channel'. Older Canary Jsons won't work this way without editing and re-hosting as they always point to (common) address for LATEST Canary build rather than unique address.

    But you can forget all that! 😆

    All you need to do is click on Magisk Canary, under Downloads on Magisk main page on GitHub, and .apk will download! Just Install it.

    FYI Canary builds, being 'bleeding edge' builds for debug purposes, are not considered Public builds, so Canary Channel won't appear in Magisk App (Settings) from Beta / Stable Public Releases. Debug builds contain all channels. 🤠 PW
    1
    ... So, you probably now have Magisk in Recovery ramdisk also (unless Direct Install w/ Recovery mode checked failed to complete). I'm interested if you can boot with root this way:


    Booting any way, can you also Install CPU-Z from PlayStore, check System, Kernel Architecture. Is this 32 or 64 bit? 👍 PW
    I can boot into recovery mode holding power and volume up, no Idea how to boot into Magisk if thats what you mean. My architecture according to cpu-z js armv8l
    1
    I have upgraded from 22002 to 22100. Everything is fine. But in 22.1 I have no possibility to choice canary version. The user based url https://raw.githubusercontent.com/topjohnwu/magisk_files/canary/debug.json doesn't work. Is there a special mm apk for 22.1?
    I'm not sure about .json file since I never switching update from stable to canary or beta, I usually just clean install it if I switch. But if you can't download it from .json file you can grab it directly from github.
    1
    Yes, I'm aware you have Magisk in boot ramdisk. I think you did from the beginning of this discussion. But since you said you did direct update with Recovery mode checked, I was curious whether that succeeded


    IMO, its just a very obvious and very basic logic:

    1) If you (not yourself) patch boot img, then Recovery mode must not be checked, and resulted magisk_patched.img must be flashed to Boot

    2) If you patch recovery.img, then Recovery mode must be checked in, and resulted magisk_patched.img must be flashed to Recovery

    1a) If you originally installed Magisk by (1) , then always update Magisk again by repeating (1), not (2).
    Or if you opt for Direct update, then Recovery mode must not be checked in - like originally when it wasn't checked for (1)

    2a) If you originally installed Magisk by (2), then always update Magisk again by repeating (2), not (1).
    Or if you opt for Direct update, then Recovery mode must be checked in - like originally when it was checked for (2)

    Sorry but any other combination for me is simply out of mind and asking for troubles, like:
    - patching boot.img but with Recovery mode checked in
    - flashing the patched recovery img but to Boot partition
    - originally patching and flashing boot img but later forcing Recoveey mode while taking Direct update
    - etc

    One can experiment, nice, but please later don't cry why Magisk did not update, why bootloop, how to fix, and so on 🤓
    1
    The latest magisk 21.2 when I install it xposed moudel is not working (activated in edexposed managet ) riru edxposed yahfa 0.4.6.4 4563 instaled . riru 21.3 as riru 23.1 causes that exposed moudel not working… . so I am back to magisk 20.4 working perfect any fix to instal the latest magisk my device redmi k20 pro premium edition miui 12.0.6 eu
    fixed for me on my phone (rig see below) with Magisk v22.1 - thank you @topjohnwu !!!
  • 12

    Latest Public (Stable / Beta)

    Release Notes and Changelog:


    2021.4.9 Magisk v22.1​

    This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.

    Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.

    Bug Fixes​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    🎉 👍 PW
    8
    @osm0sis
    Thank you for having an eye on that.
    Did the "ls" twice, first from a TWRP-terminal in recovery, second from a terminal while phone is "up and running".
    Looks like you have /dev/bootimg as your real partition location and it is still higher in the list in util_functions.sh like how I fixed it in the linked commit, so this is definitely a regression from some other recent change to Magisk.. sigh, I'll look into it. 🤔😕
    6
    #Xiaomi.eu, #OTA, #Magisk 22006, #Viper4Android, #sepolicy.rule

    This week, Xiaomi.eu weekly update 21.3.24 (MIUI 12.5, A11) was late a day and a half, hence I upgraded yesterday night

    As usual:
    - I downloaded the zip, extracted boot.img and patched (already from my previous Xiaomi.eu 21.3.18, rooted by Magisk 22006)
    - Flashed the Xiaomi.eu zip from TWRP, wiped Dalwik and Cache and rebooted
    - Then rebooted once again to TWRP and flashed the boot.img that was patched in advance

    I could probably flash its patched boot img right after flashing the 'OTA' zip (saving one time booting to the not-rooted system and rebooting to TWRP), but I rather play the safe and many times proven game

    Upon rebooting with the patched boot img, I have Magisk 22006 root again, with all modules (except V4A), root granted apps snd apps enabled for Magisk hide

    This time the old trick to make V4A did not work. Maybe because of the known sepolicy.rule bug in Magisk 22006, or maybe I was not 'patient' enough and made a mistake in steps

    Anyway, I also wanted to test, hence I modified V4A's post-fs-data.sh in accordance to:
    https://forum.xda-developers.com/t/...-0-viper4android-fx-2-7.3774651/post-84121895
    rebooted, and it did the trick 👍

    The modified post-fs-data.sh for:
    /data/adb/modules/ViPER4AndroidFX
    is zipped and attached

    The zip also contains DDC and Kernel folders to be copied ton Internalmemory: /Android/data/com.pittvandewitt.viperfx/files
    for V4A Convolvers and headphone profiles

    Hence now I have again AML, V4A plus another audio mode (320 kbps bitrate for my phone) and V4A is happilly again Supported and Proccessing (still in the Legacy mode)
    6
    No, the phone is an Estar Takee1.
    ROM is from here: Mikel Android 7 for Takee1
    and is itself a port from this ROM: RidonOS for Micromaxx A311

    You're right, sorry for that. Now here the installation log for canary-version:

    - Target image: /dev/BOOT
    - Device platform: armeabi-v7a
    - Installing: f152b4c2 (22005)
    nanddump: MEMGETINFO: Not a typewriter
    Parsing boot image: [boot.img]
    - Unpacking boot image
    ! Unsupported/Unknown image format
    ! Installation failed

    😛

    /dev/BOOT is known (usually) not an actual boot partition, hence nanddump failing.

    I had originally fixed this back here: https://github.com/topjohnwu/Magisk/commit/2aede97754fec67d393bde0c7725ed84d8c3c112

    So not sure if we're looking at some kind of a regression, or just a further edge case.

    @io2345 what's the actual, correct location of your boot partition? Please give me the output of `ls -alR /dev`
    6

    Latest Canary Changelog, including Release Notes:​


    Magisk (9c0e1897) (22007)​

    • [General] Fix logic to copy sepolicy.rule during module installation
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.

    Diffs to v22.0​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlock
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    👍 PW
  • 1045
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    155
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    119
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    74
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone