Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
Jun 23, 2016
2,044
1,213
163
Sydney
Android 12 Pixel 5 magisk not working. after flash the patched boot.img reboot to bootloader.
Mishaal Rahman reported Magisk works on the Pixel 3 XL running A12 DP1.

I guess there may be issues to iron out with other (later) Pixel models, but your best chance of compatibility will be using latest Canary build (not beta/stable) due to recent fixes included. You haven't indicated what build you tried.

@MishaalRahman, did you use Canary Magisk build? Thanks, PW
 
Last edited:
  • Like
Reactions: J.Michael

pndwal

Senior Member
Jun 23, 2016
2,044
1,213
163
Sydney
Lenovo TB-x606f. I have tried flashing the patched_boot.img from magisk 8.0.7 without luck. It just boot loops. Any suggestions? Other people seem to managed.

Android 10
Assuming you have Magisk 21400 (public stable/beta), and I see yours is a fairly recent device.

What Ramdisk status is displayed in Magisk Homescreen?

Also, how are you flashing patched image exactly?

Nb. also recent fixes in Canary 21410 (not merged to public builds yet):
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84493077 PW
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
Jun 23, 2016
2,044
1,213
163
Sydney
Is it recommended to Magisk Hide Google Play Services? If so, are there only specific components that should be hidden, or should all be hidden? The components I'm seeing are:
com.google.android.gms
com.google.android.gms.feedback
com.google.android.gms.learning
com.google.android.gms.persistent
com.google.android.gms.room
com.google.android.gms.ui
com.google.android.gms.unstable
com.google.android.gms:car
com.google.android.gms:snet


Additionally, for banking, payment and password storage apps, how do we know which components to hide?
Example: Venmo has 3 options:
com.venmo
com.venmo:MiSnap
com.venmo:playcore_missing_splits_activity

Example 2: Microsoft Authenticator has 2 options:
com.azure.authenticator
com.azure.authenticator:auth

Example 3: Chase has 2 options:
com.chase.sig.android
com.chase.sig.android:remote

Example 4: Citimobile has 2:
com.citi.citimobile
com.citi.citimobile:MiSnap

You get the picture. Any guidance on this would be much appreciated!
I've had root hidden from all Google Play Services components in the past, and noticed no I'll effects. However, as this may cause unforseen problems, I'm back using MagiskHide's default setting (which is selected automatically when toggling MagiskHide in settings) of hiding only com.google.android.gms.unstable service. This is also working fine for me, allowing SafetyNet pass and giving Play Protect certification.

For security centric apps (banking etc), I've hidden root from all components and not experienced problems, but I may be lazy; it's likely only one component actually detects root, and you could experiment to find (enable all services, get app working, then disable one at a time to identify) which that is. I also have G Pay working fine with root hidden from its two services fwiw.

See officially endorsed tips on hiding root from apps, including why you shouldn't simply hide everything, here:
Skip down to The Hide list, and see also System Instabilities. PW
 
Last edited:

snickle

Senior Member
Sep 6, 2009
261
37
48

martyfender

Senior Member
Mar 9, 2017
3,146
1,649
223
Indianapolis, IN
Is it recommended to Magisk Hide Google Play Services? If so, are there only specific components that should be hidden, or should all be hidden? The components I'm seeing are:
com.google.android.gms
com.google.android.gms.feedback
com.google.android.gms.learning
com.google.android.gms.persistent
com.google.android.gms.room
com.google.android.gms.ui
com.google.android.gms.unstable
com.google.android.gms:car
com.google.android.gms:snet


Additionally, for banking, payment and password storage apps, how do we know which components to hide?
Example: Venmo has 3 options:
com.venmo
com.venmo:MiSnap
com.venmo:playcore_missing_splits_activity

Example 2: Microsoft Authenticator has 2 options:
com.azure.authenticator
com.azure.authenticator:auth

Example 3: Chase has 2 options:
com.chase.sig.android
com.chase.sig.android:remote

Example 4: Citimobile has 2:
com.citi.citimobile
com.citi.citimobile:MiSnap

You get the picture. Any guidance on this would be much appreciated!


by default Magisk hides: com.google.android.gms.unstable and no other in Google Play Services.
 
  • Like
Reactions: ipdev

pndwal

Senior Member
Jun 23, 2016
2,044
1,213
163
Sydney
Re. Problem mounting System (from Recovery):

Finally a properly reported bug / issue!
with solution included. 👌

I'm sure this issue (since 21407) will get fixed ASAP (or I'll eat my hat). Well done @BillGoss! PW
 
Last edited:
  • Like
Reactions: dr4go and BillGoss

robi54321

Senior Member
Apr 22, 2012
82
13
38
Budapest
Hello all,

I have 21.4 installed, but whenever I try to install any magisk module it fails and tells me to install Magisk X.Y+ where X.Y is an older version than mine. Also where it shows the latest Magisk version I get a forever "Loading..."

Any ideas how to fix this?

Thanks,
robi54321

Device: Exynos S10+ on Android 11
Magisk log:
Code:
02-20 09:45:27.364  5296  5296 I : Magisk 21.4(21400) daemon started
02-20 09:45:27.364  5296  5296 I : * Device API level: 30
02-20 09:45:27.428  5296  5297 I : ** post-fs-data mode running
02-20 09:45:27.436  5296  5297 I : * Mounting mirrors
02-20 09:45:27.436  5296  5297 I : mount: /dev/jaHx/.magisk/mirror/product
02-20 09:45:27.436  5296  5297 I : mount: /dev/jaHx/.magisk/mirror/vendor
02-20 09:45:27.436  5296  5297 I : link: /dev/jaHx/.magisk/mirror/cache
02-20 09:45:27.436  5296  5297 I : mount: /dev/jaHx/.magisk/mirror/data
02-20 09:45:27.436  5296  5297 I : link: /dev/jaHx/.magisk/mirror/system
02-20 09:45:27.437  5296  5297 I : mount: /dev/jaHx/.magisk/mirror/system_root
02-20 09:45:27.437  5296  5297 I : link: /dev/jaHx/.magisk/mirror/system_ext
02-20 09:45:27.438  5296  5297 I : * Initializing Magisk environment
02-20 09:45:27.454  5296  5297 E : * Magisk environment incomplete, abort
02-20 09:45:27.454  5296  5297 I : * Loading modules
02-20 10:45:28.589  5296  5605 I : ** late_start service mode running
02-20 10:45:28.590  5296  5605 I : * Running service.d scripts
02-20 10:45:28.602  5296  5605 I : * Running module service scripts
02-20 10:45:42.679  5296  7143 I : ** boot_complete triggered
 

Attachments

  • Screenshot_20210220-104711.jpg
    Screenshot_20210220-104711.jpg
    336.8 KB · Views: 39

Didgeridoohan

Forum Moderator / Developer Relations
Staff member
May 31, 2012
11,413
11,607
263
Gothenburg
Google Nexus 4
Nexus 6
whenever I try to install any magisk module it fails and tells me to install Magisk X.Y+ where X.Y is an older version than mine.
That simply sounds like the module you're trying to install is using an outdated installer script.
https://www.didgeridoohan.com/magisk/Magisk#hn_Outdated_template
Also where it shows the latest Magisk version I get a forever "Loading..."
That could be caused by something on your device blocking internet access for the app. Firewall, hosts file, etc...
 
  • Like
Reactions: J.Michael

robi54321

Senior Member
Apr 22, 2012
82
13
38
Budapest
That simply sounds like the module you're trying to install is using an outdated installer script.
https://www.didgeridoohan.com/magisk/Magisk#hn_Outdated_template

That could be caused by something on your device blocking internet access for the app. Firewall, hosts file, etc...

Thanks for the quick reply!

It happens with Magiskhide Props Config too, which I assume uses the correct template :/ and literally every module. Also this is a fresh install, there is no firewall or any change to the hosts file.
 
  • Like
Reactions: J.Michael

Didgeridoohan

Forum Moderator / Developer Relations
Staff member
May 31, 2012
11,413
11,607
263
Gothenburg
Google Nexus 4
Nexus 6
Thanks for the quick reply!

It happens with Magiskhide Props Config too, which I assume uses the correct template :/ and literally every module. Also this is a fresh install, there is no firewall or any change to the hosts file.

The only way for the install message to tell you to install an older release of Magisk is if it's using an outdated script. That can happen with MHPC too if you're not downloading it from within the Magisk app...
 

pndwal

Senior Member
Jun 23, 2016
2,044
1,213
163
Sydney
Re. Problem mounting System (from Recovery):

Finally a properly reported bug / issue!
with solution included. 👌

I'm sure this issue (since 21407) will get fixed ASAP (or I'll eat my hat). Well done @BillGoss! PW
... And there you go! First issue fix committed post 21410! (replete w/ your code in green.) ... Guess you'll be able to run your mod in TWRP again when 21411 arrives shortly @BillGoss!
https://github.com/topjohnwu/Magisk/commit/9cc91b30b34729c8fe470a3f3a96c617347f585d

Great contribution (even though John didn't respond after previously fobbing it off: "This is a bug in many custom recoveries, no way around that"... At least he's up closing issues / committing fixes despite a demanding week at Apple, and itching to try A12 on Pixel! ...and I won't need to eat my hat.

See you in the Changelogs! PW
John Wu, 6h

After a hell of a week of work, finally time to pull out my Pixel 4 XL and upgrade to Android 12 😅
 
Last edited:
  • Like
Reactions: BillGoss and dr4go

pndwal

Senior Member
Jun 23, 2016
2,044
1,213
163
Sydney
Hello all,

I have 21.4 installed, but whenever I try to install any magisk module it fails and tells me to install Magisk X.Y+ where X.Y is an older version than mine. Also where it shows the latest Magisk version I get a forever "Loading..."

Any ideas how to fix this?

Thanks,
robi54321

Device: Exynos S10+ on Android 11
Magisk log:
Code:
02-20 09:45:27.364  5296  5296 I : Magisk 21.4(21400) daemon started
02-20 09:45:27.364  5296  5296 I : * Device API level: 30
02-20 09:45:27.428  5296  5297 I : ** post-fs-data mode running
02-20 09:45:27.436  5296  5297 I : * Mounting mirrors
02-20 09:45:27.436  5296  5297 I : mount: /dev/jaHx/.magisk/mirror/product
02-20 09:45:27.436  5296  5297 I : mount: /dev/jaHx/.magisk/mirror/vendor
02-20 09:45:27.436  5296  5297 I : link: /dev/jaHx/.magisk/mirror/cache
02-20 09:45:27.436  5296  5297 I : mount: /dev/jaHx/.magisk/mirror/data
02-20 09:45:27.436  5296  5297 I : link: /dev/jaHx/.magisk/mirror/system
02-20 09:45:27.437  5296  5297 I : mount: /dev/jaHx/.magisk/mirror/system_root
02-20 09:45:27.437  5296  5297 I : link: /dev/jaHx/.magisk/mirror/system_ext
02-20 09:45:27.438  5296  5297 I : * Initializing Magisk environment
02-20 09:45:27.454  5296  5297 E : * Magisk environment incomplete, abort
02-20 09:45:27.454  5296  5297 I : * Loading modules
02-20 10:45:28.589  5296  5605 I : ** late_start service mode running
02-20 10:45:28.590  5296  5605 I : * Running service.d scripts
02-20 10:45:28.602  5296  5605 I : * Running module service scripts
02-20 10:45:42.679  5296  7143 I : ** boot_complete triggered
Not sure why your Manager version shows as 284. I thought it should report v 8.0.7... maybe someone on stable can confirm... I may have forgotten.

Perhaps you could confirm if actual version is 8.0.7, but looks strange to me. PW
 
Last edited:
  • Like
Reactions: J.Michael

Didgeridoohan

Forum Moderator / Developer Relations
Staff member
May 31, 2012
11,413
11,607
263
Gothenburg
Google Nexus 4
Nexus 6

pndwal

Senior Member
Jun 23, 2016
2,044
1,213
163
Sydney
Looks like an old Canary Manager...

Edit - looks like it matches this commit: https://github.com/topjohnwu/Magisk/commit/87de0e7a0e13bcbbc2491b158149c8dea3f77937
So it does, thanks.

... So the v204 Manager he's using is a May 2020 20400 series - compatible Canary Manager (pre canary channel cleanout) w/ latest stable 21.4 (21400 Jan 2021) Magisk? ...Why?...How?

This is surely incompatible! Oldest Canary Manager still archived is v303 for Magisk 21001!

Hello all,

I have 21.4 installed, but whenever I try to install any magisk module it fails and tells me to install Magisk X.Y+ where X.Y is an older version than mine. Also where it shows the latest Magisk version I get a forever "Loading..."

Any ideas how to fix this?

Thanks,
robi54321
Update Manager to 8.0.7 from Magisk main page here for starters:
https://github.com/topjohnwu/Magisk

PW
 
Last edited:

pndwal

Senior Member
Jun 23, 2016
2,044
1,213
163
Sydney
Does hiding an app with Magisk hide use any system resources? If I have 5 hidden apps or 100 is there a difference in battery/cpu usage on my device?
You can likely hide root from only one component of apps that detect root to make them work, and it is recommended that you limit processes hidden for system stability reasons; I'm not sure of impact on system resources (- as a guess, I'd say this would be minimal, and stability is the real concern).

It is recommended NOT to add System apps and processes (especially) to Hide list for the same reasons. This can even prevent a device from booting.

For security centric apps (banking etc), I've hidden root from all components and not experienced problems, but I may be lazy; it's likely only one component actually detects root, and you could experiment to find (enable all services, get app working, then disable one at a time to identify) which that is. I also have G Pay working fine with root hidden from its two services fwiw.

See officially endorsed tips on hiding root from apps, including why you shouldn't simply hide everything, here:
Skip down to The Hide list.

See also System Instabilities here:

PW
 

Top Liked Posts

  • 5
    i previously asked that too "why is magisk called systemless when it's capable corrupting system partition" but nobody answered me i guess it's one of those question like

    Which Came First, the Chicken or the Egg?​

    nobody know thou it's better left unanswered
    Magisk itself is not Systemlesss, in that it modifies the BOOT partition, which some would cal a "system" modification. However, technically NOT touching the SYSTEM partition.

    The "magic" of Magisk is that after that, all modifications that appear to be to the SYSTEM partition are actual achieved by systemless mods; the mods are in the DATA partition.

    Its the differentiation between BOOT and SYSTEM, and that the changes made by Magisk are systemless. Magisk is not ...errr.. "bootlesss";)
    2
    that make sense so if magisk installation got corrupted then system partion would appear to be corrupted to since magisk is symlinking or like emulating system partition
    That could be the case, but if yur boot partition is corrupted (ie not working) then there would be no chance for your phone to work exactly; booot gets loaded before system). But also (as you stated), if the Magisk install starts making "bad" changes to tour system, then the system wont boot / operate correctly. The first step to recover from such a situation is commonly to flash back the original boot image (doing so is built into magisk), and hence remove the system changes and hopefully that will give you a working system. Or remove all your modules (ie systemless changes)

    PS: in case you haven't already, simply report your own double post to get it removed.
    1
    Yh I do. Where can I find magisk backup partition? I used to flash custom roms and kernels back when I had my Nexus 4 but these days it's just stock with magisk so I'm pretty much new to this whole thing.
    Ok I'm getting nowhere. I got the backup boot.img which I extracted from /data/magisk_backup_sha1/boot.img.gz and flashed it using the command fastboot flash boot boot.img and my OP 5T just shows a white led and ends up in some diagnostic mode. I've also tried flashing the stock boot.img then flashing magisk but that didn't work either. Does anyone want to help me with some instructions a 5 year old could follow?
    I have a twrp backup from a while ago which is for the same android version but an older magisk version and I also have one with the broken boot after the failed update from 22.0 and before attempting to flash 22.1 again in twrp.

    Edit: I've gotten back into android by restoring my system backup from late 2019. I then uninstalled the broken magisk app installed 22.1 again and all is working fine. I've tried restoring the broken system image but it bootlooped again. What could be causing this? The only thing I can think of is substratum.
    1
    First time here and I hope I'm asking this question in the right place.
    Oneplus 3T running OOS 9.0.6 since about Jan. 2020 with Magisk installed a long time ago.
    TWRP 3.5.2_9

    This morning there was a download for Magisk which I ignored. (Little download arrow at the top of the screen.)
    I was using the phone fine for a few hours until I got out of the car and put it in my pocket.
    10 minutes later I noticed it was hot, took it out and found it stuck at the prompt for start/recovery/bootloader etc.

    It will not complete its boot.
    I can get to TWRP, I've tried flashing v22.1 but it fails in the same way.

    ! Unsupported/Unknown image format
    - Unmounting partitions
    Updater process ended with ERROR: 1

    I've attached the dmesg.log and recovery.log if that helps.

    I have Nandroid backups from the last time (after) I upgraded to OOS 9.0.6.

    Any help would be appreciated.
    1
    On clean flashed (fully wiped) LineageOS 18.1, Xiaomi Mi A1, v22.1, the app didn't work initially after flashing the apk renamed as .zip (it threw an error message trying to download and install the full app after tapping it in the app drawer). I then manually installed the app by using the normal apk. Everything works fine su wise but attempting to install a module crashes the app, event though notifs say it's downloading (but doesn't install).
    Little confusing what you now have; what does Magisk app report under Magisk, Installed, and under App, Installed respectively?

    App should be at least as late as Magisk version. If not, update App. PW
  • 12

    Latest Public (Stable / Beta)

    Release Notes and Changelog:


    2021.4.9 Magisk v22.1​

    This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.

    Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.

    Bug Fixes​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    🎉 👍 PW
    8
    @osm0sis
    Thank you for having an eye on that.
    Did the "ls" twice, first from a TWRP-terminal in recovery, second from a terminal while phone is "up and running".
    Looks like you have /dev/bootimg as your real partition location and it is still higher in the list in util_functions.sh like how I fixed it in the linked commit, so this is definitely a regression from some other recent change to Magisk.. sigh, I'll look into it. 🤔😕
    6
    No, the phone is an Estar Takee1.
    ROM is from here: Mikel Android 7 for Takee1
    and is itself a port from this ROM: RidonOS for Micromaxx A311

    You're right, sorry for that. Now here the installation log for canary-version:

    - Target image: /dev/BOOT
    - Device platform: armeabi-v7a
    - Installing: f152b4c2 (22005)
    nanddump: MEMGETINFO: Not a typewriter
    Parsing boot image: [boot.img]
    - Unpacking boot image
    ! Unsupported/Unknown image format
    ! Installation failed

    😛

    /dev/BOOT is known (usually) not an actual boot partition, hence nanddump failing.

    I had originally fixed this back here: https://github.com/topjohnwu/Magisk/commit/2aede97754fec67d393bde0c7725ed84d8c3c112

    So not sure if we're looking at some kind of a regression, or just a further edge case.

    @io2345 what's the actual, correct location of your boot partition? Please give me the output of `ls -alR /dev`
    6

    Latest Canary Changelog, including Release Notes:​


    Magisk (9c0e1897) (22007)​

    • [General] Fix logic to copy sepolicy.rule during module installation
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.

    Diffs to v22.0​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlock
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    👍 PW
    6
    #Xiaomi.eu, #OTA, #Magisk 22006, #Viper4Android, #sepolicy.rule

    This week, Xiaomi.eu weekly update 21.3.24 (MIUI 12.5, A11) was late a day and a half, hence I upgraded yesterday night

    As usual:
    - I downloaded the zip, extracted boot.img and patched (already from my previous Xiaomi.eu 21.3.18, rooted by Magisk 22006)
    - Flashed the Xiaomi.eu zip from TWRP, wiped Dalwik and Cache and rebooted
    - Then rebooted once again to TWRP and flashed the boot.img that was patched in advance

    I could probably flash its patched boot img right after flashing the 'OTA' zip (saving one time booting to the not-rooted system and rebooting to TWRP), but I rather play the safe and many times proven game

    Upon rebooting with the patched boot img, I have Magisk 22006 root again, with all modules (except V4A), root granted apps snd apps enabled for Magisk hide

    This time the old trick to make V4A did not work. Maybe because of the known sepolicy.rule bug in Magisk 22006, or maybe I was not 'patient' enough and made a mistake in steps

    Anyway, I also wanted to test, hence I modified V4A's post-fs-data.sh in accordance to:
    https://forum.xda-developers.com/t/...-0-viper4android-fx-2-7.3774651/post-84121895
    rebooted, and it did the trick 👍

    The modified post-fs-data.sh for:
    /data/adb/modules/ViPER4AndroidFX
    is zipped and attached

    The zip also contains DDC and Kernel folders to be copied ton Internalmemory: /Android/data/com.pittvandewitt.viperfx/files
    for V4A Convolvers and headphone profiles

    Hence now I have again AML, V4A plus another audio mode (320 kbps bitrate for my phone) and V4A is happilly again Supported and Proccessing (still in the Legacy mode)
  • 1044
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    155
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    119
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    74
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone