Magisk General Support / Discussion

Search This thread

zgfg

Senior Member
Oct 10, 2016
5,027
2,309
Guys, did you try by first unhiding/restoring Magisk Manager (or Magisk app, if you were already on Canary).
That was the most common case/bug reappearing every so and often with (major) Magisk updates
 

svendsvin

Senior Member
Oct 21, 2013
177
35
Lost in space
Very nice. Smooth update. Miss a colored icon though.
 

Attachments

  • Screenshot_2021-02-23-18-24-44-002_s.tjroqf.jpg
    Screenshot_2021-02-23-18-24-44-002_s.tjroqf.jpg
    292.4 KB · Views: 80
  • IMG_20210223_182646.jpg
    IMG_20210223_182646.jpg
    19.1 KB · Views: 79

Spartacus500

Senior Member
Nov 6, 2014
541
97
Samsung Galaxy S7 Edge Custom Pie 9.0 Rom, upgrade to version 22000 passed without any errors, but am I okay? Now I have no information that the latest version of Magisk is installed, is it correct on the new version?
Screenshot_20210223-182654.jpg

Opening the option what I marked does not work for me on the latest version of Magisk manager, is it supposed to be or is something wrong with me?
Screenshot_20210223-191341.jpg
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
5,027
2,309
Samsung Galaxy S7 Edge Custom Pie 9.0 Rom, upgrade to version 22000 passed without any errors, but am I okay? Now I have no information that the latest version of Magisk is installed, is it correct on the new version?
View attachment 5230523
This is how it looks like once there is no more Magisk Manager but Magisk app (already in previous versions of Canary)

It clearly says what is the latest version of Magisk app (22000), hence that's also the version of latest Magisk
 

zgfg

Senior Member
Oct 10, 2016
5,027
2,309
the last update destroyed my phone REDMIN NOTE 8
The phone exploded?🤓

Flash the original/stock boot img or the one patched by your previous working Magisk

If you are not accustomed to patch&flash images, you might still have TWRP backup of the Boot with the previous Magisk
 

ssamurai

Senior Member
Dec 29, 2012
137
15
The phone exploded?🤓

Flash the original/stock boot img or the one patched by your previous working Magisk

If you are not accustomed to patch&flash images, you might still have TWRP backup of the Boot with the previous Magisk
I fixed it by installing a custom recovery
 

XtraWater

Senior Member
Apr 8, 2018
563
92
I just updated the manager and magisk (stable). As advised I did unhide magisk. The update process was fine and the phone booted normally. Now, in the app drawer I see 3 magisk icon. One looks as the mask icon. The other one has the name I had masgik hidden before. And the 3rd has the name I just gave when I activate hide magisk again.

How to clean up those icons? Just uninstall?

Edit: restated phone again. The original magisk icon is gone. Then I deleted the old hidden app.

It seems everything fine now.
 
  • Like
Reactions: Didgeridoohan

HippoMan

Senior Member
May 5, 2009
1,594
452
Hippoland
I very much appreicate and am sincerely grateful to John Wu for his work on this, which helps so many people.

Sadly, I will not be upgrading to this version, because it no longer supports the A/B OTA Retention Script. That module makes OS upgrades very simple on A/B devices such as mine, and I want to avoid the more complicated and therefore more error-prone method that I would now have to utilize in order to upgrade my OS under this new Magisk version.

Some day I might give in, but for the time being, I'm sticking with 21.4.
I apologize for the above post. It is a false alarm.

I was going by an earlier message which stated that the A/B Retention Script for OTA is not supported under the latest Magisk version. However, some time after that earlier message was posted, it turns out that osm0sis fixed the A/B Retention Script, and it now does indeed work under Magisk 22.0.

He pointed that out to me, and so I tried upgrading to 22.0 (after backing everything up, of course), and his OTA utility is indeed available via that version of Magisk. I reinstalled my current OS via Local upgrade and the standard A/B Retention Script procedure, and everthing worked fine.

So, I am now successfully running Magisk 22.0 on my OnePlus 7Pro (GM-1917) with OOS 10.3.8.
 

pndwal

Senior Member
Jun 23, 2016
2,105
1,292
Sydney
Xiaomi Redmi Note 7
I saw something similar. The "Let's go" button didn't seem to do anything, but while trying to save a log I realised that there were several flashing instances running in the background. Completely destroyed my boot image... Had to restore it and flash in TWRP to get up and running again.

I think I managed to get a log of the issue and have given it to John, but could you grab one as well, just in case?
Yes, intend to do this when I get a little time... precious little ATM! 😐

As it's a long time since I've grabbed logs, please point me to which / how. Also, I didn't see your issue on GitHub to append... Thanks, PW
 

Didgeridoohan

Forum Moderator / Developer Relations
Staff member
May 31, 2012
11,435
11,645
Gothenburg
Google Nexus 4
Nexus 6
Yes, intend to do this when I get a little time... precious little ATM! 😐

As it's a long time since I've grabbed logs, please point me to which / how. Also, I didn't see your issue on GitHub to append... Thanks, PW

A logcat would most likely be the most helpful:
https://www.didgeridoohan.com/magisk/MagiskHelp

And I didn't open a GitHub issue. I sent it to him directly since I'm active in the internal testing group... I would append a link to your post or issue there.
 
  • Like
Reactions: dcarvil and pndwal

Smil3yWulf

Senior Member
Jan 25, 2015
62
1
Im having problem rooting with v22. I was fine rooted with 21.4 but the new update v22 doesnt rooted my tablet Samsung Galaxy a6 (SM-T280)it always says ramdisk yes. Installed no latest 22. Ive tried patching the boot and flash it with odin. Also twrp flash v22 zip and do all the process but i still get installed n/a on magisk app Any help or guide to be rooted with v22 on SM-T280
 

Smil3yWulf

Senior Member
Jan 25, 2015
62
1
Im having problem rooting with v22. I was fine rooted with 21.4 but the new update v22 doesnt rooted my tablet Samsung Galaxy a6 (SM-T280)it always says ramdisk yes. Installed no latest 22. Ive tried patching the boot and flash it with odin. Also twrp flash v22 zip and do all the process but i still get installed n/a on magisk app Any help or guide to be rooted with v22 on SM-T280
 

snickle

Senior Member
Sep 6, 2009
261
37
Upgraded app to new version. Could not do a direct install if 22. Complained of read-only file system when try to write boot img. I used the patch and fastboot the patched boot.img and everything is fine.

Ideas on read-only filesystem?
 

Top Liked Posts

  • 8
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/56d4ca44e12927217ae761df0874e3cd7d05cea4/notes.md :

    Magisk (fb8000b5) (22104)​

    • [App] Hide annoying errors in logs when hidden as stub
    • [App] Update stub implementation
    • [App] Some internal code refactoring
    • [App] Update snet extension implementation

    Diffs to v22.1​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [App] Hide annoying errors in logs when hidden as stub
    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    May fix sundry issues with Magisk App! 👍 PW
    5
    Hey could anyone tell me where i can find a trust file that i can remove Magisk via TWRP? I find some files in internet but not i official site. Could someone can help me?
    Rename the Magisk APK file to uninstall.zip and flash it in TWRP.

    From the official instuctions.
    Magisk Installation - github.io - Uninstallation - Link

    The easiest way to uninstall Magisk is directly through the Magisk app.
    If you insist on using custom recoveries, rename the Magisk APK to uninstall.zip and flash it like any other ordinary flashable zip.

    Personal Note:
    You may also need to manually flash your rom's stock boot image.

    Cheers. :cowboy:
    3
    Hey could anyone tell me where i can find a trust file that i can remove Magisk via TWRP? I find some files in internet but not i official site. Could someone can help me?
    U can remove magisk directly in magisk itself
    First open magisk app
    Than click on uninstall magisk button in magisk app
    Reboot than magisk is successfully uninstalled
    2
    Hi, Thank you very much for the replied. Please refer to the this here for my feedback:

    Do let me know where is more appropriate to post my issue so that I won't be consider spamming the forum...tqvm for the help.
    Hi. It's fine to post here - this is Magisk General Support / Discussion after all! 🙂

    Updates there are clear however.

    Yes, Latest 2 Canary builds have fix for Magisk SafetyNet check error, which is not actually indicating a failed result, only an evaluation failure. SafetyNet is actually still passing if PlayStore Settings shows PlayProtect Device is certified result. (Read recent posts here.)

    Question: When updating to 22.1 App, did you have Manager hidden? Unhiding is critical due to incompatibility between old Manager and new App, as per release notes.

    If you didn't do this, you likely have two conflicting Magisk apps installed. 😬 PW
    1
    Dear all,

    I am new to this magisk thingy and have follow every single step to install it. I am unable to move forward due to it say the Magisk installed status is N/A. I've tried all the method that can find on the internet but still not working.

    May I know how can I solve it and enjoy the Hide feature?

    Btw, I am running android 6.0.1 on Samsung Galaxy Note 4 (SM-N910C).

    View attachment 5284801

    Thank you.
    Jeffrey
    Don't start with other docs, please read official Installation Instruction carefully, then ask here if anything is unclear or doesn't work.

    Official Installation Instruction is accessed from Magisk main page on John Wu's GitHub (under Useful Links), where, I hope, you downloaded Magisk App.

    From Magisk App, just click GitHub OctoPuss (cat) symbol on home screen.

    If you have compatable TWRP (custom Recovery) for your device, you can follow Custom Recovery section (Nb. Magisk in Recovery is something different altogether, and won't apply to your 'legacy' device).

    Otherwise, familiarise yourself with Patching Images section before proceeding. Nb. Depending on how your Sammy ROM package archives boot image, some of the information for newer SAR devices in Samsung section may be useful for you if using Patching method.

    Read, read, read. Then proceed! 👍 PW

    Edit: Seems from this:
    https://forum.xda-developers.com/t/...0f-touchwiz-armeabi-v7a.4253113/post-84870675
    that you may have actually tried flashing 22100 using TWRP... but it's not clear.

    You really need to say what you have tried.

    If you did flash (aside from installing App), did you have a previous version? Direct Update within App?

    Please give us a clue if you are still facing issues. 🙂 PW
  • 12

    Latest Public (Stable / Beta)

    Release Notes and Changelog:


    2021.4.9 Magisk v22.1​

    This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.

    Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.

    Bug Fixes​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    🎉 👍 PW
    10
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/ea57c9b33b3a6ce2e0e65ce4c33dfb1c01552fcb/notes.md :

    Magisk (f49966d8) (22103)​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    Diffs to v22.1​

    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic
    👍 ...And things are all Rosy 'n Safe in the Custom Mod. world once again... but ironically, only on the bleeding edge... (Confirmed on my RN8T. 🙂 )

    News for those not wanting to get cut (Public Stable / Beta users) below. 😜

    Thanks John... And other collaborators for additional fixes! PW
    8
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/56d4ca44e12927217ae761df0874e3cd7d05cea4/notes.md :

    Magisk (fb8000b5) (22104)​

    • [App] Hide annoying errors in logs when hidden as stub
    • [App] Update stub implementation
    • [App] Some internal code refactoring
    • [App] Update snet extension implementation

    Diffs to v22.1​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [App] Hide annoying errors in logs when hidden as stub
    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    May fix sundry issues with Magisk App! 👍 PW
    8
    Update snet.jar extension
    The existing API key was revoked for some reason.
    Release an updated extension jar with a new API key.

    In addition, add some offline signature verification and change how
    results are parsed to workaround some dumbass Xposed module "faking"
    success results, since many users really don't know better.

    @topjohnwu

    topjohnwu committed 19 minutes ago
    6

    Latest Canary Changelog, including Release Notes:​


    Magisk (9c0e1897) (22007)​

    • [General] Fix logic to copy sepolicy.rule during module installation
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.

    Diffs to v22.0​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlock
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    👍 PW
  • 1046
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    155
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    119
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    74
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone