You should report the issue to Github with logs
Btw, you can still try Direct install (to collect logs), even upon you already updated
Magisk General Support / Discussion
- Thread starter topjohnwu
- Start date
Btw, you can still try Direct install (to collect logs), even upon you already updated
How do I collect the needed logs. Have not done it before
When finishing Install (update) you have diskette icon top-right to save the Install log
You have also a tab for logs (between the tabs for Superuser and Modules), wherefrom you can also save the logs
Tiny bit stuck now.
Magisk said "Update available" -> downloaded, tried to install but got the error message "Package didn't parse correctly" (sth. like that). So now when I want to try again and open "Manager" it says "Upgrade to full Magisk Manager to finish the setup. Download and install?" and nothing happens.
Uninstall Manager? Reinstall Manager 8.07 again and then try?
Cheers
Tom
Edit: Nvm, installed 8.0.7 again and then started the update, all fine
Magisk said "Update available" -> downloaded, tried to install but got the error message "Package didn't parse correctly" (sth. like that). So now when I want to try again and open "Manager" it says "Upgrade to full Magisk Manager to finish the setup. Download and install?" and nothing happens.
Uninstall Manager? Reinstall Manager 8.07 again and then try?
Cheers
Tom
Edit: Nvm, installed 8.0.7 again and then started the update, all fine
Last edited:
Same as tom1807 except I didn't install it because instructions indicate you have to unhide magisk first. Plus not sure I want to update anyway. This is on a Pixel 2, stock, rooted. I exited magisk manager but now every time I try to open it, it pops up this message. I never started to install it so not sure why it claims I need to finish the setup. If I select cancel and try to open manager it just pops up again and I can't get into it. Anyone else come across this? Any way around it? Even if I want to update I can't get into it to unhide it.
Last edited:
I solved my problem flashing stock boot.img again
Reboot in TWRP.
Flashed magisk patched boot img again.
Reboot in TWRP.
Flashing Magisk 21.4 again. (Finised OK)
Reboot in TWRP.
Unisntalling Magisk 21.4 (Finised OK)
Reboot in TWRP.
Flashing Magisk 22 (Finished OK)
Fixed
I have an OnePlus 6.
Hope helps.
Reboot in TWRP.
Flashed magisk patched boot img again.
Reboot in TWRP.
Flashing Magisk 21.4 again. (Finised OK)
Reboot in TWRP.
Unisntalling Magisk 21.4 (Finised OK)
Reboot in TWRP.
Flashing Magisk 22 (Finished OK)
Fixed
I have an OnePlus 6.
Hope helps.
My j7 prime root is not working anymore with this new update, i updated it, reinstalled it, and the root is not working anymore on the latest update, only on the old magisk, also, theres no settings to config
I have the issue w/my OnePlus 6T where it keeps booting to TWRP. This is after Magisk said it needed to reboot to make a modification to install.
Is this an issue of a Magisk module incompatibility? Does flashing boot.img erase everything on the phone, apps & data? Is Magisk booting to TWRP because it wants me to install something?
After installing the update, is it normal for the "Install" buttons to still appear?
Same question. I've installed on 3 times and it still says install. Should it?
Edit: never mind. It does the correct version and doesn't say Update like it did before. Don't know why the Install was confusing me.
Last edited:
So I'm seeing that Magisk 22 is not a zip? It's an apk only? Why is this different now?
You can rename it from apk to zip and flash from recovery. It's in the new installation guide.
Oh thanks! Okay that solves any other questions I was gonna ask
Thank you!
im also looking for twrp install .zip of v22 magisk...it has been a few years since i read the installations guide
Please read the installation guide: https://topjohnwu.github.io/Magisk/install.html#custom-recovery
"
- Rename the .apk file extension to .zip, for example: Magisk-v22.0.apk → Magisk-v22.0.zip. If you have trouble renaming the file extension (like on Windows), use a file manager on Android or the one included in TWRP to rename the file.
- Flash the zip just like any other ordinary flashable zip.
Ah yes, sorry for being vague.
I did not intend to imply that the method generally does not work.
This is actually the first time that I tried that method, since there's a new installation guide and only now that I know it is the recommended one. I have always been flashing the zip in TWRP.
Anyway, I read the wiki carefully and tried not to make a mistake, but to no avail.
Looks like there might be some issue with OnePlust 6t and 22 version. It hard bricked my phone. I did unhide manager first and then tried to flash magisk (direct) and got unsupported image error. After reboot it went straight to fastboot mode and I had to flash whole rom from there. I'm not the only one, I saw someone in 6t forum reported the same. So just a warning
Top Liked Posts
-
4
There's no need to unhide the app if you're already on v22+. That's only necessary when updating from older releases.2
what are you doing? why you manually changing them?
anyway here's what they does from the god himself John Wu
preserve avb 2.0/dm-verity
Preserve force encryption
11
Why not use v22.1 directly? Or is there some known incompatibility with the S7 Edge?
And also, why not link directly to the files on John's Github? Always the safest way...1 -
12
Latest Public (Stable / Beta)
Release Notes and Changelog:
2021.4.9 Magisk v22.1
This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.
Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.
Bug Fixes
- [App] Prevent multiple installation sessions running in parallel
- [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
- [General] Proper cgroup migration implementation
- [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
- [General] Many scripts updates fixing regressions
- [MagiskHide] Prevent possible deadlock when signal arrives
- [MagiskHide] Partial match process names if necessary
- [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
- [MagiskBoot] Properly strip out data encryption flags
- [MagiskBoot] Prevent possible integer overflow
- [MagiskInit] Fix sepolicy.rule mounting strategy
- [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
PW8
Looks like you have /dev/bootimg as your real partition location and it is still higher in the list in util_functions.sh like how I fixed it in the linked commit, so this is definitely a regression from some other recent change to Magisk.. sigh, I'll look into it.
6Latest Canary Changelog, including Release Notes:
Magisk (9c0e1897) (22007)
- [General] Fix logic to copy sepolicy.rule during module installation
- [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
Diffs to v22.0
- [App] Prevent multiple installation sessions running in parallel
- [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
- [General] Proper cgroup migration implementation
- [General] Rewrite log writer from scratch, should resolve any crashes and deadlock
- [General] Many scripts updates fixing regressions
- [MagiskHide] Prevent possible deadlock when signal arrives
- [MagiskHide] Partial match process names if necessary
- [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
- [MagiskBoot] Properly strip out data encryption flags
- [MagiskBoot] Prevent possible integer overflow
- [MagiskInit] Fix sepolicy.rule mounting strategy
- [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
PW6
/dev/BOOT is known (usually) not an actual boot partition, hence nanddump failing.
I had originally fixed this back here: https://github.com/topjohnwu/Magisk/commit/2aede97754fec67d393bde0c7725ed84d8c3c112
So not sure if we're looking at some kind of a regression, or just a further edge case.
@io2345 what's the actual, correct location of your boot partition? Please give me the output of `ls -alR /dev`6#Xiaomi.eu, #OTA, #Magisk 22006, #Viper4Android, #sepolicy.rule
This week, Xiaomi.eu weekly update 21.3.24 (MIUI 12.5, A11) was late a day and a half, hence I upgraded yesterday night
As usual:
- I downloaded the zip, extracted boot.img and patched (already from my previous Xiaomi.eu 21.3.18, rooted by Magisk 22006)
- Flashed the Xiaomi.eu zip from TWRP, wiped Dalwik and Cache and rebooted
- Then rebooted once again to TWRP and flashed the boot.img that was patched in advance
I could probably flash its patched boot img right after flashing the 'OTA' zip (saving one time booting to the not-rooted system and rebooting to TWRP), but I rather play the safe and many times proven game
Upon rebooting with the patched boot img, I have Magisk 22006 root again, with all modules (except V4A), root granted apps snd apps enabled for Magisk hide
This time the old trick to make V4A did not work. Maybe because of the known sepolicy.rule bug in Magisk 22006, or maybe I was not 'patient' enough and made a mistake in steps
Anyway, I also wanted to test, hence I modified V4A's post-fs-data.sh in accordance to:
https://forum.xda-developers.com/t/...-0-viper4android-fx-2-7.3774651/post-84121895
rebooted, and it did the trick
The modified post-fs-data.sh for:
/data/adb/modules/ViPER4AndroidFX
is zipped and attached
The zip also contains DDC and Kernel folders to be copied ton Internalmemory: /Android/data/com.pittvandewitt.viperfx/files
for V4A Convolvers and headphone profiles
Hence now I have again AML, V4A plus another audio mode (320 kbps bitrate for my phone) and V4A is happilly again Supported and Proccessing (still in the Legacy mode) -
1044This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
All information, including troubleshoot guides and notes, are in the Announcement Thread155Hello, I haven't given much support on XDA lately. It can be resulted from
- University started and I have limited free time. In fact, I mostly develop during midnight
- I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
- The new version is about to come, I don't want to spend effort on supporting old releases
New Forum!
As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
**For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about
The Pixel Phone
Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things
Current Progress
In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)
Safety Net Disaster
Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.
Conclusion
Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.
Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!119Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.
First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.
-------------------------
What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!
Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).
He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.
It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
@topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.
tl;dr Towards @topjohnwu, I have:
- expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
- expressed surprise he is using SuperSU binaries in a competing superuser without permission
- expressed surprise he is posting a modified LiveBoot without permission
- informed him of issues with the modified SuperSU he has posted
- let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser
To be crystal clear:
- I have not asked for an apology
- I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
- I have not made an issue of any of this anywhere, until this post
- I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
- I have not reported this thread to XDA moderators for copyright violations or otherwise
While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.
To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.
I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake
Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.76Thread temporarily closed so everyone sees this.
The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.
The Flash
Forum Moderator
EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.74Hello everyone!
I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.
Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.
So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.
Google, how will a few systemless mods do any harm
New posts
-
-
MIUI 12 Ultra Lite ROM [64bit]- Latest: happybird337
-
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone