Magisk General Support / Discussion

Search This thread

BrikHaus

Senior Member
Jun 24, 2012
134
37
Actually I couldn't boot into recovery. Only fastboot was working so I flashed all partitions using fastboot zip stock rom but I do not recommend that as you will get everything wiped. Now I would try flashing just stock boot.img in fastboot and then boot into recovery to flash rom. This way I wouldn't wipe everything...

FYI
If you extract your update, remove the -w from the end of the flash-all.bat, it won't wipe your phone.
Then just run flash-all.bat with phone in fastboot.
 

kiwigi

Senior Member
Oct 4, 2012
163
20
Hoping someone can help me, my phone is stuck at the Samsung boot logo after updating Magisk.

At that point, I realized something had gone wrong, and since I didn't care about losing all my data, I did a force reboot into TWRP and did the following:

Formatted Data.
Wiped Dalvik, System, Data and Cache.
Restored a Nandroid backup that I had made before rooting my phone.

Once I did all that, I rebooted and the phone is still stuck at the boot logo. How is that possible?
@Newtype14
Would you mind telling me a couple of things:
have you flashed TWRP after complete magisk set-up ?
how did you do the Nandroid backup before rooting? have you used an app?
Thanks
 

Newtype14

Member
Feb 24, 2021
9
4
@Newtype14
Would you mind telling me a couple of things:
have you flashed TWRP after complete magisk set-up ?
how did you do the Nandroid backup before rooting? have you used an app?
Thanks

I flashed TWRP before doing anything with Magisk, then booted into Recovery mode and in TWRP, I created a backup by selecting: "Boot", "System", "Cache", "Baseband" and "EFS".

For additional information: I did wipe my phone three weeks ago and used that backup to restore and it worked fine.
 

daniel_loft

Senior Member
Jan 22, 2011
542
96
Stuttgart
Because every now and then another app needs Magisk hide (latest I noticed was Revolut) I was thinking about this little suggestion:
- When activating Magisk hide, why not set it to hidden to all apps? Or, if possible hidden to all exempt those that were specifically given root access.
or, if the above is not implementable...
- Could it be possible to have a way to export the list of selected apps from MagiskHide?
I happen to have installed Magisk relatively often lately and it's always annoying to repopulate the list in MagiskHide.
Thanks!
 
Galaxy S7 TWRP Backup Restore Fail

...I did a force reboot into TWRP and did the following:

Formatted Data.
Wiped Dalvik, System, Data and Cache.
Restored a Nandroid backup that I had made before rooting my phone.

Once I did all that, I rebooted and the phone is still stuck at the boot logo. How is that possible?

Many users including me reported fail to boot if you select install the TWRP app when asked in TWRP. That app is fluff, wants to start at boot, run in the background, collect data & is not necessary anyway because the TWRP updates are not frequent & it's easy enough to update manually.

If you did that, go to TWRP > Settings > and disable: Prompt to install TWRP app if not installed.

Samsung Galaxy S7 (SM-G930W8)
Android 8.0 Oreo

Is that stock Samsung OS? TWRP version?

I flashed TWRP before doing anything with Magisk, then booted into Recovery mode and in TWRP, I created a backup by selecting: "Boot", "System", "Cache", "Baseband" and "EFS".

For additional information: I did wipe my phone three weeks ago and used that backup to restore and it worked fine.

You only need to restore System, Boot (which is the kernel in fact & this gets modified by Magisk on your device) & Data. You did not backup the Data partition?

There is no need to backup or restore Cache as it is recreated by the system if needed.

The EFS partition can be restored if you have problems with unknown IMEI or no access to the network after checking the APN settings. No need to fix what is not broken. Don't restore Baseband. Are you sure that it's not labeled Modem?
***
 
Last edited:
  • Like
Reactions: ipdev

pndwal

Senior Member
Jun 23, 2016
2,116
1,305
Sydney
Xiaomi Redmi Note 7
All I see is boot.emmc. This backup was done before rooting with Magisk.
View attachment 5231743

Not sure I understand what I should try doing. I don't have much experience since I just recently learned how to root.
Well, you just need to understand that being systemless, actual Magisk is flashed to boot image (assuming ramdisk [in boot image] = yes), so this is what got corrupted by bad flash.

Flashing patched boot image thru fastboot from PC is now the preferred method to flash Magisk, but, if you have TWRP you can generally flash boot partition from this (without PC) also.

The reverse is also true: to remove Magisk root (or corrupted Installation), simply flash back UNPATCHED boot image (download and extract from your current ROM package).

The details are all laid out for you in John's official Installation Instruction on the Magisk main page. Just click the GitHub (cat) symbol on Magisk app main page (or click here: https://github.com/topjohnwu/Magisk ), then Installation Instruction. Please read everything (especially Patching Images). Nb. some of the special instructions for Samsung may be relevant, but largely won't apply as your device did no launch w/ Android 9 or later (ie not SAR device).

Hope this helps. PW
 
Last edited:

DrPhant0m

Senior Member
Oct 21, 2010
931
273
NOW I'M STUCK IN DOWNLOAD MODE!!!

UPDATE: Being on DrKetan ROM, I flashed the BL + CP package in Odin, which allowed me to reboot into TWRP. I still couldn't reboot the system, so I dirty-flashed my current ROM, and it allowed me to start my phone without losing anything. I still want to know what the "like magic" part is about flashing the apk in TRWP, though. /UPDATE

So... the changelog for Magisk v22 said that you can flash the apk as a zip "like magic" so I changed the .apk to .zip and tried to flash it on my Note 9 (Exynos). The process failed in TWRP with ERROR 1 (IIRC), so I tapped Reboot System. The phone rebooted to download mode, and seems to be STUCK THERE. If I hold vol down + power the screen turns off for a second, and goes back to download mode.

I tried flashing my version of TWRP back in Odin with auto reboot turned on, and it succeeds, but still goes back to download mode. Do I really have to flash the stock ROM back to my phone because of this? :(

Someone please help. I have a business trip tomorrow and need my phone... I guess I shouldn't have tried this. Thanks in advance!
 
Last edited:

golden7

Senior Member
Apr 30, 2016
98
30
Serious issues with v22 update - MagiskManager shows the new Manager ver as being v. 22 I didn't see any changelogs, so I selected Updatefor Manager app (not Magisk) from MagiskManager - so v22 became the Manager version and Manager showed no Magisk or root, and all crapped out. Using old Xperia Z3 but running Android 10 - CarbonRom (Lineage variant, very nice btw)

Solution: First I downloaded older version of Magisk 21.4, latest Magisk uninstaller, and Manager 8.0.7 Second, unininstalled MagiskManager v22 app. Third reboot to TWRP and uninstalled Magisk with latest Magisk uninstaller. No reboot, directly installed Magisk v 21.4 from TWRP, booted to system, and installed apk for Manager v 8.0.7 and all runs fine - have root.

New development - Manager keeps "Checking for updates . . ." and not showing version installed or available. Guess the Magisk Team is on it. Now shows Manager is up to date.

Galaxy s9 is confused. Screenshot_20210224-223420.jpg
 
Last edited:

Pandemic

Senior Member
Aug 30, 2010
23,973
23,165
Meppel
talk.sonymobile.com
Updated from 21.4 to 22.0 and no issues at all on my Xperia 1 with Android 11, updated the magisk manager 1st then updated to magisk 22.0 with the manager with direct install.. So dunno what is wrong with the other people that have issues.
 

Newtype14

Member
Feb 24, 2021
9
4
The reverse is also true: to remove Magisk root (or corrupted Installation), simply flash back UNPATCHED boot image (download and extract from your current ROM package).

I thought that when I was restoring with my backup, it was also restoring the boot to its pre-Magisk state, since I selected "boot" in TWRP when I created my backup. Am I wrong?

What's the proper way of getting this boot.img? I did some research and everywhere it says that to get the boot.img, you have to download the latest firmware for your phone model/carrier and extract it from those files.
 

Lim_Dul

Member
Oct 20, 2014
26
10
Serious issues with v22 update - MagiskManager shows the new Manager ver as being v. 22 I didn't see any changelogs, so I selected Updatefor Manager app (not Magisk) from MagiskManager - so v22 became the Manager version and Manager showed no Magisk or root, and all crapped out. Using old Xperia Z3 but running Android 10 - CarbonRom (Lineage variant, very nice btw)

Solution: First I downloaded older version of Magisk 21.4, latest Magisk uninstaller, and Manager 8.0.7 Second, unininstalled MagiskManager v22 app. Third reboot to TWRP and uninstalled Magisk with latest Magisk uninstaller. No reboot, directly installed Magisk v 21.4 from TWRP, booted to system, and installed apk for Manager v 8.0.7 and all runs fine - have root.

New development - Manager keeps "Checking for updates . . ." and not showing version installed or available. Guess the Magisk Team is on it. Now shows Manager is up to date.

Thanks for sharing your fix / workaround. I'm on an old Xiaomi Mi Mix, Android 9.
Had the same symptoms when I updated to the newest Manager. Also, Magisk / Magisk Manager started crashing. Downgraded to 21.4 and 8.0.7 and everything is fine again. The update to 22.0 is now greyed out in the manager, so I guess I'll wait till a more stable version comes out before trying this one. The Manager is still showing an update for itself (22.0) but that can't be right. I think the repo URLs might have gotten mixed up or something.
 

cyril'u

New member
Jun 21, 2008
3
1
It is known issue that Magisk Manager (now Magisk app) must not be installed as a system app (also not on external SD).
AFAIK, documented somewhere in Magisk docs or Wiki, it was also discussed here and under Github issues
You 're right . But Magisk was included in my Custom Pie ROM I've used for 2 years. Until r22 I didn't know that a file magisk.apk was into my system/app folder. Until r21.4 , all the updates didn't detect it. Now everything is back to the normal and it is running fine. Finally not a big issue. Thanks for your help.
 

mrror

Member
Aug 1, 2011
22
2
Napoli
Issues on MIUI Global 12.0.3.0(QFGEUXM) (Redmi Note 7 - Lavender), Android 10 QKQ1.190910.002
Magisk v22.0 doesn't work at all, seems to patch fine in TWRP, but boot stucks at MIUI logo, hangs there for a while, then reboots to recovery (TWRP 3.5.0_9.0-lavender).
Tried installing through patching and flashing stock boot image and recovery (one at a time), but none of these have worked.
I was able to install Magisk v19.0 (TWRP zip flash) and boot, but Magisk Manager nor Magisk app won't detect it (if I try to flash zip again it says "Detected magisk patched boot image" (or sth like that) and patches fine).
Any solutions?

Same exact problem on my Redmi Note 8T/willow (MIUI 12.0.2 QCXEUXM, Android 10) with Orangefox 11.0_1. I have to reflash the rom to boot to system again.
 
  • Like
Reactions: Bielecki

Didgeridoohan

Forum Moderator / Developer Relations
Staff member
May 31, 2012
11,445
11,661
Gothenburg
Google Nexus 4
Nexus 6

okchinmaya

Senior Member
Nov 25, 2018
63
10
Dehradun
May I ask what those devices are exactly & the method you used?
***
You are The Messiah good sir! Thank you, thank you so much. For almost everyone stuck with acquiring the boot.img file, if you are using any custom ROM, check its ZIP, it will have a boot.img file within it without fail. Simply flash it using fastboot flash boot boot.img and you're good to go.
 

Nivan0611

Member
Mar 5, 2014
16
0
Hi All . . . I posted this in another thread, but it seems that it should have been posted here

If any can please Help . . .
"Quote"
Hi All . . .
I am running a Amlogic X96Air Box with Slimrom-Android 9

Can someone plz guide me on installing Magisk for Safety Net Pass on Uncertified Google Play Store "Uncertified Device"

Firstly i installed the App Manager to access if "ramdisk" is available . . it says "No"
I then uninstalled it . . then tried to go the route to flash the zip (v22) thru TWRP . . after reboot nothing showed up in all apps (no Magisk) . . not sure if I'm doing it correctly !!! . . . However, I then reset the box and also reinstalled the rom to have a clean installation.

Any guidance on installing Magisk for Safety Net Pass on Play Store to have a certified device would be greatly appreciated, if this is at all possible
Thanks :)
 

Top Liked Posts

  • 2
    Went to Canary to solve the API issue.
    App shows I'm running 22104 and that I'm on the Stable update channel.
    Will Magisk just install the stable when the next stable update is released?
    Supposidely, next Stable will be 22200, hence higher than Canary 2210x

    In that case, Magisk will first ask you to update (Install) Magisk app to that new Stable 22200, and afterwards you will update the Magisk itself
    1
    hi all!

    Do you know if it is possible to configure something to make the Samsung Note 10 boot straight into magisk mode? (N970F variant)

    The new UI3 makes it a pain in the a** to boot into magisk because you have to plug the phone into the usb.
    Am I right to assume this is a Ramdisk = no device, and you have Magisk in Recovery (Magisk patched Recovery image)?

    I understand you may be able to RE-BOOT to system with root in recovery partition from Magisk App Reboot menu, but I'm fairly sure you'll always need Recovery key combo after complete shutdown. Some have reported otherwise, but John Wu said:
    For these devices, you will have to reboot to recovery every time you want Magisk...
    As soon as you press the combo and the device vibrates with a splash screen, release all buttons to boot into Magisk.
    https://topjohnwu.github.io/Magisk/install.html#magisk-in-recovery

    It's not clear why you need to plug in USB. Are you saying key combo changed (or became unavailable) with OS update?

    Have you tried reported key combos like:
    - Press and hold the Volume Up and Power buttons together to boot your Galaxy Note 10/Note 10+ into Recovery Mode.
    - The phone will vibrate and enter the stock recovery mode. You can release the buttons now.
    https://www.thecustomdroid.com/boot-samsung-galaxy-note-10-plus-recovery-download-mode-guide/
    but IMMEDIATELY releasing both buttons at vibration / splash screen to bypass Recovery mode and boot to System with Magisk root? PW
    1
    Please help. My phone is bootloop, when I flash it with Odin it fails and it says sw rev check fail bootloader device -1. Please help which firmware should I use? Does firmware -1 exist?
    I have no experience with rooted Samsung, but if you have SAR = Yes device, John's Installation Instruction, Samsung (SAR), Additional Notes will apply:
    - Never, ever try to restore either boot or recovery partitions back to stock! You can easily brick your device by doing so, and the only way out is to do a full Odin restore with data wipe.
    - To upgrade your device with a new firmware, NEVER directly use the stock AP tar file with reasons mentioned above. Always pre-patch AP in the Magisk app before flashing in Odin.
    - Use HOME_CSC to preserve your data when doing a firmware upgrade in the future. Using CSC is only necessary for the initial Magisk installation.
    - Never just flash only AP, or else Odin can shrink your /data filesystem. Flash full AP + BL + CP + HOME_CSC when upgrading.
    https://topjohnwu.github.io/Magisk/install.html#additional-notes

    So seems you may need full Odin restore with data wipe (ie. Factory Reset), and (I'm guessing), this may include relocking, to restore. ☹️

    Regarding which ROM package to use, this really isn't the best forum for that, but likely others in XDA forums for your device will know. 🤠 PW
    1
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/ea57c9b33b3a6ce2e0e65ce4c33dfb1c01552fcb/notes.md :

    Magisk (f49966d8) (22103)​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    Diffs to v22.1​

    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic
    👍 ...And things are all Rosy 'n Safe in the Custom Mod. world once again... but ironically, only on the bleeding edge... (Confirmed on my RN8T. 🙂 )

    News for those not wanting to get cut (Public Stable / Beta users) below. 😜

    Thanks John... And other collaborators for additional fixes! PW
    Thanks, this solved my problem yesterday 👏
    1
    I'm on oos11 and today I got an API error in the magisk. Any ideas ?
    Unhide Magisk -> install Magisk Canary from GitHub -> rehide Magisk -> restart

    Or wait a little while for a new stable release.
    There's no real urgency. Phone still passes gpay, credit cards, banks, etc. The Check fails, not the hide.
  • 12

    Latest Public (Stable / Beta)

    Release Notes and Changelog:


    2021.4.9 Magisk v22.1​

    This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.

    Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.

    Bug Fixes​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    🎉 👍 PW
    11
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/ea57c9b33b3a6ce2e0e65ce4c33dfb1c01552fcb/notes.md :

    Magisk (f49966d8) (22103)​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    Diffs to v22.1​

    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic
    👍 ...And things are all Rosy 'n Safe in the Custom Mod. world once again... but ironically, only on the bleeding edge... (Confirmed on my RN8T. 🙂 )

    News for those not wanting to get cut (Public Stable / Beta users) below. 😜

    Thanks John... And other collaborators for additional fixes! PW
    9
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/56d4ca44e12927217ae761df0874e3cd7d05cea4/notes.md :

    Magisk (fb8000b5) (22104)​

    • [App] Hide annoying errors in logs when hidden as stub
    • [App] Update stub implementation
    • [App] Some internal code refactoring
    • [App] Update snet extension implementation

    Diffs to v22.1​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [App] Hide annoying errors in logs when hidden as stub
    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    May fix sundry issues with Magisk App! 👍 PW
    8
    Update snet.jar extension
    The existing API key was revoked for some reason.
    Release an updated extension jar with a new API key.

    In addition, add some offline signature verification and change how
    results are parsed to workaround some dumbass Xposed module "faking"
    success results, since many users really don't know better.

    @topjohnwu

    topjohnwu committed 19 minutes ago
    7
    Strange how people think they don't need to read the other posts but expect that their questions should be addressed and answered😌
  • 1046
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    155
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    119
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    74
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone