Magisk General Support / Discussion

Search This thread

zgfg

Senior Member
Oct 10, 2016
5,040
2,339
I've thought about a similar way to get ramdisk= yes on such devices too, but it would be a little messy, and can't be the way you described, simply 'recognizing the existence of ramdisk when patching and remembering', because existence of ramdisk is not the problem (and nothing is 'remembered').

The problem is that such devices did NOT use ramdisk in boot image, so generally they use a bootloader that is no longer compatible w/ ramdisk, so even if ramdisk is ADDED SUCCESSFULLY to boot image, (and I believe this is always done if ramdisk is not present), and Magisk is successfully added to boot image also (ie patching is wholly successful), the Magisk Installation will STILL fail due to bootloader, and, as John says, Magisk has no way to see bootloader compatibility.

Xiaomi devices just happen to use ramdisk compatible bootloaders, probably because they never rewrote the code fully, which is to our advantage because John has done us (Xiaomi etc users) a favour by adding a 'manually add initramfs if not present' feature to Magisk.

So Ramdisk= no correctly means no FACTORY ramdisk in boot image. To make it mean no ramdisk without qualification WOULD involve adding a memory feature to remember a successful boot with root before changing this flag... as I said, could get a bit messy (otherwise I might have suggested this as a feature also). PW
Flashing DOES NOT fail, we patch and flash the patched boot img and have the Magisk up and running

About 'remembering', finding and declaring that there is no Ramdisk, look at my previous post and the log attached there
 

zgfg

Senior Member
Oct 10, 2016
5,040
2,339
Is this a fair intepretation of the point you are making?

* Before flashing a patched img: Magisk's Ramdisk detection method used at that time (call it "detection method 1") shows that there is no Ramdisk on the given device.

* After flashing a patched img: Magisk's same detection method 1 shows that there is still no Ramdisk of the type that it is looking for, but there is now another version of a Ramdisk which is present on the device which shows up as a result of a different mechanism for detecting a Ramdisk (call this "detection method 2").

* After patching, the results of detection method 2 should be presented to the user, because there now is at least some form of Ramdisk that is being used, even though it isn't detectable by detection method 1.

Did I understand your point correctly?
And what is unfair when I said earlier - not consistensy, using one method here, the other method there...
 

HippoMan

Senior Member
May 5, 2009
1,597
459
Hippoland
I see it as the same as what you said earlier. I'm just saying it in a different way to perhaps make it more understandable to those who seem to be missing your point.
... and to be clear, I agree with the point you are making, and this is just an attempt to support it.
And I used the word "fair" to mean "accurate" (i.e., fair to you by my attempt to accurately represent your point).
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
Jun 23, 2016
2,116
1,305
Sydney
Xiaomi Redmi Note 7
Screenshot: patching the stock boot.img, it says PATCHING RAMDISK

Upon flashing that patched img it still displays: Ramdisk No

But the attached log from repatching parses that the same patched img and finds the (not existing?!) ramdisk:
Parsing boot image:
...
RAMDISK_SZ [713664]
...
RAMDISK_FMT [raw]
As mentioned, making it say ramdisk = yes for manually added ramdisk would be misleading as Magisk will now always add ramdisk support to a boot image lacking it, but this will usually not help anyway.

A bootloader compatibility flag, if only it were possible, would be the true indicator of success BOOTING a boot image with Magisk and ramdisk. Successful patching of Magisk to boot image is simply not enough. (Users of type III devices without compatible bootloaders will see ramdisk exists in logs after Magisk adds initramfs too, but it won't be usable. Ours is, but there is apparently no way to tell other than to try...) PW
 
Last edited:
  • Like
Reactions: J.Michael

zgfg

Senior Member
Oct 10, 2016
5,040
2,339
A bootloader compatibility flag, if only it were possible, would be the true indicator of success BOOTING a boot image with Magisk and ramdisk.
even if ramdisk is ADDED SUCCESSFULLY to boot image, (and I believe this is always done if ramdisk is not present), and Magisk is successfully added to boot image also (ie patching is wholly successful), the Magisk Installation will STILL fail due to bootloader, as John says...
Ok so maybe there is another bug then - Magisk app just incorrectly declares that Magisk is installed 🤓

And maybe I was wrong all the time thinking that I'm using Magisk, while I could not be, because the way it was installed must fail

Then sorry for spamming in this thread, if not running Magisk my opinions are not relevant😷
 
Last edited:

Zoki88

Senior Member
Feb 26, 2017
56
8
Did you read the Magisk Wiki (find it from Magisk Github, link to Github is right on the Magisk app main window), and did you try the suggestions there

If you don't pass SafetyNet you maybe need to install SafetyNet fix.
Apps you want to hide from must be enabled for under the the Magisk Hide

But some apps could look for something benign, like TWRP folder and just because of that they declare that the phone is rooted

Etc
i didn't read it, i'll head now there and take a look, but yes, i pass safetynet every time, have those apps under magisk hide, and also magisk manager itself hiden with random named data folder, and still didn't help. Thx for magisk github, hope there will find solution
 

pndwal

Senior Member
Jun 23, 2016
2,116
1,305
Sydney
Xiaomi Redmi Note 7
Flashing DOES NOT fail, we patch and flash the patched boot img and have the Magisk up and running

About 'remembering', finding and declaring that there is no Ramdisk, look at my previous post and the log attached there
Please read carefully what I said. It WILL fail for these devices (w/ non ramdisk compatible bootloaders)! This is the whole reason John added Magisk in Recovery option.

And of course there is now ramdisk; Magisk adds it! ... But this DOES NOT mean it's usable (unless OEM happens to leave legacy support in bootloader, as does Xiaomi)... It's simply reporting no FACTORY ramdisk as this is the only one sure to work. (Factory ramdisk present indicates compatible bootloader. Manually added ramdisk indicates nothing!) PW
 
Last edited:
  • Like
Reactions: J.Michael

nowster

Senior Member
Dec 30, 2012
374
123
Does anyone have same issues with hiding magisk actually not working after update from few days ago? Apps actually recognize root, even if all things are enabled magiskhide and hide the magisk app. I'm on LG H930DS Oreo Europe software
Reboot. You'll probably find MagiskHide has turned itself off. Turn it back on.

It sometimes happens with the recent update.
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
Jun 23, 2016
2,116
1,305
Sydney
Xiaomi Redmi Note 7
Ok so maybe there is another bug then - Magisk app just incorrectly declares that Magisk is installed 🤓

And maybe I was wrong all the time thinking that I'm using Magisk, while I could not be, because the way it was installed must fail

Then sorry for spamming in this thread, if not running Magisk my opinions are not relevant😷
Of course it's not incorrect, you have Magisk, and no-one said it must fail w/ this Installation method, and please don't make out I did! ☹

It's just as John said:
Some Type III devices’ bootloader will still accept and provide initramfs that was manually added to the boot image to the kernel (e.g. some Xiaomi phones), but many device don’t (e.g. Samsung S10, Note 10). It solely depends on how the OEM implements its bootloader.

And no need to apologize for all that spam! 😉 FWIW I quite enjoy your opinions. Seriously; all learn from each other here!

PW
 
Last edited:
  • Like
Reactions: J.Michael

Newtype14

Member
Feb 24, 2021
9
4
Writing this to avoid any confusion:

Device: Samsung Galaxy S7, Stock Android 8.0.
Context: Updated to latest version of Magisk, then phone wouldn't boot past the Samsung logo.

So I found what the issue is. It seems that on my device, if I install TWRP without Magisk, my phone will bootloop.
Installing Magisk through TWRP fixed the issue. (I tried installing it with ADB/Fastboot like the instructions say, but Fastboot couldn't detect my device; I don't even think the S7 has a Fastboot mode, or if it has one it's different.)

What I think happened is that when I updated Magisk, the phone then rebooted, but Magisk stopped preventing my phone from bootlooping. I'm not knowledgeable enough about this to know why.

So now everything works fine. Phone is restored with my old Backup too, but I'm worried if the same thing will happen again every time there's a new Magisk update.

Thanks to everyone who tried to help.
 

pndwal

Senior Member
Jun 23, 2016
2,116
1,305
Sydney
Xiaomi Redmi Note 7
FWIW, John gave some clarification on why Magisk "Says Ramdisk No, but still works, annoyingly" last October:

topjohnwu commented on 5 Oct 2020
In the last section in Android Booting Shenanigans is your answer. And I quote:
Some Type III devices’ bootloader will still accept and provide initramfs that was manually added to the boot image to the kernel (e.g. some Xiaomi phones), but many device don’t (e.g. Samsung S10, Note 10). It solely depends on how the OEM implements its bootloader.
It is literally impossible for Magisk to know whether a device bootloader accepts ramdisk, so the assumption is to always inform the user to use recovery mode

This and other details:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-83987947 PW
 
Last edited:
  • Like
Reactions: J.Michael

ineedroot69

Senior Member
Nov 13, 2019
747
1
145
So anybody experience this after a failed Magisk v22.0 installation attempt ??
my phone is 100% fully operational but everytime i boot up my device or access recovery mode (I can access recovery mode ) this thing always shows up but my device is 100% fully operational IDK should i try to fix it or just leave it there?? :unsure: :unsure: :unsure:

thread-55167417-5963559593997696019.jpg
 
  • Like
Reactions: J.Michael

ineedroot69

Senior Member
Nov 13, 2019
747
1
145
update::
So i did some searching and apparently dm-verity is a feature that verify Android partition( system, vendor, and optionally oem partitions ) with SHA256 checksum hash. and due to the fact that i tried fixing Magisk 22.0 installation issue by flashing my "dumped" stock "system.img" (i'm the one who dumped it i'm pretty sure its stock version) . I guess you could say my device is Stock ROM but since SHA256 checksum didn't match dm-verity is triggered .. well fuk me then
 
  • Like
Reactions: J.Michael

pixbuf

Senior Member
Oct 29, 2010
250
44
Saitama
My device is a Sony Z2 tablet running AICP, android version 10. For years up to now I have had no trouble with Magisk. But when I updated to v22 the Magisk app says Magisk is not installed. I followed the "100% guaranteed to work method":
  1. extracted boot.img from ROM
  2. patched boot.img with Magisk
  3. copied magisk_patched_*.img to PC
  4. fastboot flash boot magisk_patched_*.img
Magisk still says it's not installed. I tried changing .apk to .zip and flashing it in TWRP. Nope. I tried uninstalling and reinstalling magisk_v22.0.apk. Nope.
Any ideas?
TIA
 

pndwal

Senior Member
Jun 23, 2016
2,116
1,305
Sydney
Xiaomi Redmi Note 7
My device is a Sony Z2 tablet running AICP, android version 10. For years up to now I have had no trouble with Magisk. But when I updated to v22 the Magisk app says Magisk is not installed. I followed the "100% guaranteed to work method":
  1. extracted boot.img from ROM
  2. patched boot.img with Magisk
  3. copied magisk_patched_*.img to PC
  4. fastboot flash boot magisk_patched_*.img
Magisk still says it's not installed. I tried changing .apk to .zip and flashing it in TWRP. Nope. I tried uninstalling and reinstalling magisk_v22.0.apk. Nope.
Any ideas?
TIA
Did you previously have a hidden Manager? Did you restore it first? PW
 
  • Like
Reactions: J.Michael

jelly_jeremy

Member
Sep 28, 2017
10
3
If only people could read requirements and that highlighted sentences when prompted to update. Everything is written in that update notes, called changelog...
The problem is, we tap the update notification pushed out by the old magisk app without reading the changelog because there isn't one in the notification. Not everyone is free to look at the changelog on GitHub or here before installing every version. We only found out that we have to unhide magisk manager before installing the new app, after installing the new app.

So maybe it's a new circumstances where no one is at fault here? Maybe the users will have to adopt the new habit of reading changelog before installing EVERY VERSION. Or maybe the developers can learn to not push out notifications to ask users to update directly without warning when there is some big change like this in the future? No?
 

DiamondJohn

Recognized Contributor
Aug 31, 2013
4,984
4,280
Sydney
I have a Pixel 4a running A11. From what I have found, there is no TWRP for this device on this firware. So, if a Magisc module creates a bootloop, I do not know how to resolve it. by deleting or disabling the speific module

If I flash the stock boot image, Magisk is gone and so the bootloop stops, HOWEVER, I also loose root, and so I cant manually disable the offending module manually.

How do I disable a module triggering a bootloop, without TWRP?
 

kiwigi

Senior Member
Oct 4, 2012
163
20
Writing this to avoid any confusion:

Device: Samsung Galaxy S7, Stock Android 8.0.
Context: Updated to latest version of Magisk, then phone wouldn't boot past the Samsung logo.

So I found what the issue is. It seems that on my device, if I install TWRP without Magisk, my phone will bootloop.
Installing Magisk through TWRP fixed the issue. (I tried installing it with ADB/Fastboot like the instructions say, but Fastboot couldn't detect my device; I don't even think the S7 has a Fastboot mode, or if it has one it's different.) ........

I've got the same phone and the same stock version.
To be able to use ADB you need to have the drivers installed on the PC( and I'm sure you have done that) . Then connect via usb from the motherboard port( better).
In Android make sure it is connected for charging, not for file transfer.
Use command prompt on the PC and use the ADB commands.
It took me ages to find this out.
I've got a file somewhere with a few command samples if you need.
Does the above make sense?
Good luck.
 
Last edited by a moderator:

Top Liked Posts

  • 2
    Went to Canary to solve the API issue.
    App shows I'm running 22104 and that I'm on the Stable update channel.
    Will Magisk just install the stable when the next stable update is released?
    Supposidely, next Stable will be 22200, hence higher than Canary 2210x

    In that case, Magisk will first ask you to update (Install) Magisk app to that new Stable 22200, and afterwards you will update the Magisk itself
    1
    hi all!

    Do you know if it is possible to configure something to make the Samsung Note 10 boot straight into magisk mode? (N970F variant)

    The new UI3 makes it a pain in the a** to boot into magisk because you have to plug the phone into the usb.
    Am I right to assume this is a Ramdisk = no device, and you have Magisk in Recovery (Magisk patched Recovery image)?

    I understand you may be able to RE-BOOT to system with root in recovery partition from Magisk App Reboot menu, but I'm fairly sure you'll always need Recovery key combo after complete shutdown. Some have reported otherwise, but John Wu said:
    For these devices, you will have to reboot to recovery every time you want Magisk...
    As soon as you press the combo and the device vibrates with a splash screen, release all buttons to boot into Magisk.
    https://topjohnwu.github.io/Magisk/install.html#magisk-in-recovery

    It's not clear why you need to plug in USB. Are you saying key combo changed (or became unavailable) with OS update?

    Have you tried reported key combos like:
    - Press and hold the Volume Up and Power buttons together to boot your Galaxy Note 10/Note 10+ into Recovery Mode.
    - The phone will vibrate and enter the stock recovery mode. You can release the buttons now.
    https://www.thecustomdroid.com/boot-samsung-galaxy-note-10-plus-recovery-download-mode-guide/
    but IMMEDIATELY releasing both buttons at vibration / splash screen to bypass Recovery mode and boot to System with Magisk root? PW
    1
    Please help. My phone is bootloop, when I flash it with Odin it fails and it says sw rev check fail bootloader device -1. Please help which firmware should I use? Does firmware -1 exist?
    I have no experience with rooted Samsung, but if you have SAR = Yes device, John's Installation Instruction, Samsung (SAR), Additional Notes will apply:
    - Never, ever try to restore either boot or recovery partitions back to stock! You can easily brick your device by doing so, and the only way out is to do a full Odin restore with data wipe.
    - To upgrade your device with a new firmware, NEVER directly use the stock AP tar file with reasons mentioned above. Always pre-patch AP in the Magisk app before flashing in Odin.
    - Use HOME_CSC to preserve your data when doing a firmware upgrade in the future. Using CSC is only necessary for the initial Magisk installation.
    - Never just flash only AP, or else Odin can shrink your /data filesystem. Flash full AP + BL + CP + HOME_CSC when upgrading.
    https://topjohnwu.github.io/Magisk/install.html#additional-notes

    So seems you may need full Odin restore with data wipe (ie. Factory Reset), and (I'm guessing), this may include relocking, to restore. ☹️

    Regarding which ROM package to use, this really isn't the best forum for that, but likely others in XDA forums for your device will know. 🤠 PW
    1
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/ea57c9b33b3a6ce2e0e65ce4c33dfb1c01552fcb/notes.md :

    Magisk (f49966d8) (22103)​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    Diffs to v22.1​

    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic
    👍 ...And things are all Rosy 'n Safe in the Custom Mod. world once again... but ironically, only on the bleeding edge... (Confirmed on my RN8T. 🙂 )

    News for those not wanting to get cut (Public Stable / Beta users) below. 😜

    Thanks John... And other collaborators for additional fixes! PW
    Thanks, this solved my problem yesterday 👏
    1
    I'm on oos11 and today I got an API error in the magisk. Any ideas ?
    Unhide Magisk -> install Magisk Canary from GitHub -> rehide Magisk -> restart

    Or wait a little while for a new stable release.
    There's no real urgency. Phone still passes gpay, credit cards, banks, etc. The Check fails, not the hide.
  • 12

    Latest Public (Stable / Beta)

    Release Notes and Changelog:


    2021.4.9 Magisk v22.1​

    This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.

    Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.

    Bug Fixes​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    🎉 👍 PW
    11
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/ea57c9b33b3a6ce2e0e65ce4c33dfb1c01552fcb/notes.md :

    Magisk (f49966d8) (22103)​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    Diffs to v22.1​

    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic
    👍 ...And things are all Rosy 'n Safe in the Custom Mod. world once again... but ironically, only on the bleeding edge... (Confirmed on my RN8T. 🙂 )

    News for those not wanting to get cut (Public Stable / Beta users) below. 😜

    Thanks John... And other collaborators for additional fixes! PW
    9
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/56d4ca44e12927217ae761df0874e3cd7d05cea4/notes.md :

    Magisk (fb8000b5) (22104)​

    • [App] Hide annoying errors in logs when hidden as stub
    • [App] Update stub implementation
    • [App] Some internal code refactoring
    • [App] Update snet extension implementation

    Diffs to v22.1​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [App] Hide annoying errors in logs when hidden as stub
    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    May fix sundry issues with Magisk App! 👍 PW
    8
    Update snet.jar extension
    The existing API key was revoked for some reason.
    Release an updated extension jar with a new API key.

    In addition, add some offline signature verification and change how
    results are parsed to workaround some dumbass Xposed module "faking"
    success results, since many users really don't know better.

    @topjohnwu

    topjohnwu committed 19 minutes ago
    7
    Strange how people think they don't need to read the other posts but expect that their questions should be addressed and answered😌
  • 1046
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    155
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    119
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    74
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone