Magisk General Support / Discussion

Search This thread

Zincoshine

Senior Member
Dec 22, 2012
98
26
38
My phone prompted me to update the manager to v22.0. now the manager crashes every time I try to open it. I still have root access apparently. I'm not sure what to do here. I haven't had a problem with magisk in years, the last time I had a problem was when magisk 17.0 bricked my phone. My phone is a oneplus 5t with Android 8.1.0 and oxygen OS 5.1.7.

Edit: is there any way to downgrade the manager to 21.4 without touching magisk itself?
 

CSX321

Senior Member
Aug 21, 2009
604
274
93
Southern IL USA
Ah, I hoped I wouldn't need the app.
Edit...still froze...see later post below

FWIW, the new kernel in the Pixel 3 March update hasn't frozen on me yet. I've tried to look up in which kernel version the f2fs deadlock bug was patched (if it has been), but I haven't had any luck finding the info yet. I'm currently using Magisk 21.4 with systemless hosts and the USF module, and everything is perfect.
 
Last edited:

nowster

Senior Member
Dec 30, 2012
373
123
63
FWIW, the new kernel in the Pixel 3 March update hasn't frozen on me yet. I've tried to look up in which kernel version the f2fs deadlock bug was patched (if it has been), but I haven't had any luck finding the info yet. I'm currently using Magisk 21.4 with systemless hosts and the USF module, and everything is perfect.
I had a freeze two minutes after booting March 2021 update with Magisk patch. :(
 

CSX321

Senior Member
Aug 21, 2009
604
274
93
Southern IL USA
I had a freeze two minutes after booting March 2021 update with Magisk patch. :(
Yeah, I guess I cursed myself with that post. Mine just froze. Back to ElementalX, I guess!

Edit...Man, it's weird how it worked fine for more than 24 hours, and now it freezes almost immediately when I reboot! What a pain that was to fix. Safety mode didn't seem to disable the Magisk modules; it still would freeze. I had to remove all modules with the adb command, then set everything back up.
 
Last edited:

Sizzlechest

Senior Member
Dec 18, 2010
1,111
191
83
My phone prompted me to update the manager to v22.0. now the manager crashes every time I try to open it. I still have root access apparently. I'm not sure what to do here. I haven't had a problem with magisk in years, the last time I had a problem was when magisk 17.0 bricked my phone. My phone is a oneplus 5t with Android 8.1.0 and oxygen OS 5.1.7.

Edit: is there any way to downgrade the manager to 21.4 without touching magisk itself?

If you updated Manager App to v22 and it now crashes, just uninstall the app and reinstall it. It should work even if you didn't update (or remove) Magisk.
 

Fil76

Senior Member
Dec 30, 2014
261
48
48
Torino
Last time i try to update 21.4 to 22 i bricked my op6t (direct install error)

Lost boot IMG and also twrp so only hard reset was in my skill with Mauronofrio tool

I'dont speak english well could someone check if this procedure Is correct


Update magisk manager (app to 22)

Unhide magisk and restore magisk original name

Click update and do direct install ?

Is correct ? What about if i Lost again boot.img ? Push original boot.img via fastboot ?
 

dynamo1950

Senior Member
Jan 8, 2010
55
15
38
Las Vegas, NV
Going to go out on a limb and post this before calling it a night.

Am having similar issues - not a stranger to magisk/roms/etc... - did spend the evening reading & trying various things.
Hoping it's something simple I am missing - but I am seeing others with my device/update having the same problem too. May just be too tired - but was unable to get any safe-mode to work.

Device - Google Pixel 4a 5G
OS - Stock Rom, running the March 1 2021 update (Android 11 - RQ2A.210305.006)
Prior OS - Stock Rom, running the Feb 1st Update

Had been on Magisk 21.4 without issues - and had been updated to/running v22 without issues as well since release

Since applying the March update, any version of Magisk I try (21.4, 22, 22 Canary) cause bootloops and require the stock boot.img to be reflashed.

Magisk App / Manager have been completely uninstalled and were also removed prior to flashing the patched boot.img - just in case anything was lingering in the background.
--------------------------------------------------------------------------------------------------------------------------------------------------------

Experienced a similar issue with my Moto G Power XT2041-4 (sofia) after flashing the January update (QPMS30.80-63-6-8-5) a few days ago. Flashing the the Magisk v22.0 patched boot.img causes bootloop. Then flashed Magisk v21.4 patched boot.img results in bootloop as well. Flashing the stock boot.img from this update allows phone to boot normally but, of course, without root.

The phone worked fine with the November update (QPMS30.80-63-6-8-3) running Magisk v22.0. I updated from v21.4 to v22.0 using the Magisk app direct install while on this update.

I suspect there may be some changes in the new boot.img that conflict with the changes Magisk makes when patching it.

Any thoughts???
 
Last edited:
  • Like
Reactions: dan60

artlan

Senior Member
Aug 7, 2007
226
95
58
--------------------------------------------------------------------------------------------------------------------------------------------------------

Experienced the same with my Moto G Power XT2041-4 (sofia) after flashing the January update (QPMS30.80-63-6-8-5) a few days ago. Flashing the the Magisk v22.0 patched boot.img from this update causes bootloop showing the blue Android logo indefinitely. Then flashed Magisk v21.4 patched boot.img results in bootloop as well. Flashing the stock boot.img from this update allow phone to boot successfully.

The phone worked fine with the November update (QPMS30.80-63-6-8-3) running Magisk v22.0. I updated from Magisk v21.4 to v22.0 using direct install in the Magisk app successfully last month.

I suspect there may be some changes in the updated boot.img that conflict with the changes Magisk makes when patching the boot.img.

Any thoughts???

So, and I knew this would happen if I posted, I got mine working and it was of course my own fault.
I swore I had disabled all mods prior, but I must have double tapped one (a clock/navbar mod) and it was the culprit.
I was shown an alternate way to get into safe mode, which finally worked (pressing the power button before the reboot screen once the os tries to load, getting the reboot menu, long press restart option), and that let me start up just fine.
I'm now running v22 on the march update with safetynet/magisk hide/systemless hosts just fine again.
 
  • Like
Reactions: J.Michael

Fil76

Senior Member
Dec 30, 2014
261
48
48
Torino
Last time i try to update 21.4 to 22 i bricked my op6t (direct install error)

Lost boot IMG and also twrp so only hard reset was in my skill with Mauronofrio tool

I'dont speak english well could someone check if this procedure Is correct


Update magisk manager (app to 22)

Unhide magisk and restore magisk original name

Click update and do direct install ?

Is correct ? What about if i Lost again boot.img ? Push original boot.img via fastboot ?

I take a Xanax ;) and tried again

But this time i simple renamed apk to zip and installed via twrp

Really sad that Lost some photo in last brick

Next time i Will do a backup
 

Smil3yWulf

Senior Member
Jan 25, 2015
62
1
28
I patched my AP firmware file with magisk. As instructed to use Bl, CSC, And Patched AP on Odin. But I get unassigned file error in odin when doing the process.. when I look at my phone J7 2018 <J737T1> it's says secure check failed (Boot) .. Can someone Helped me out to Flash It. So I can have Magisk SU. I just wanna install Viper4Android, and Dolby Ultra Headphones x for my music listening and watching TV on spectrum TV app with magisk module's
 

Smil3yWulf

Senior Member
Jan 25, 2015
62
1
28
This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
All information, including troubleshoot guides and notes, are in the Announcement Thread
I have a great issue problem, I cant flash Magisk patched file with Odin.. I get unassigned file error in odin .. I check on my phone and its says secure check failed (boot). How can I fixed the problem so I can flash it in and start using magisk .. my device is J7 Star 2018 (J737T1)
 

mistermojorizin

Senior Member
Dec 21, 2011
814
174
63
Hi i want to ask, i just installed magisk v22.0 on Xiaomi MI A1 on Wave Os ROM, and i check the safetynet and its failed, how to passed the safety net test? pls help thanks
 
  • Like
Reactions: pignose28

mistermojorizin

Senior Member
Dec 21, 2011
814
174
63
Sorry if this is the wrong place to ask, I'm trying to find a module.

It was a module that let you disable/manage magisk modules from ADB. It was separate from the one that lets you manage modules from TWRP.

I used to have it a few years ago and now I can't find it for the life of me. Any help would be appreciated.
 
Last edited:

dynamo1950

Senior Member
Jan 8, 2010
55
15
38
Las Vegas, NV
--------------------------------------------------------------------------------------------------------------------------------------------------------

Experienced a similar issue with my Moto G Power XT2041-4 (sofia) after flashing the January update (QPMS30.80-63-6-8-5) a few days ago. Flashing the the Magisk v22.0 patched boot.img causes bootloop. Then flashed Magisk v21.4 patched boot.img results in bootloop as well. Flashing the stock boot.img from this update allows phone to boot normally but, of course, without root.

The phone worked fine with the November update (QPMS30.80-63-6-8-3) running Magisk v22.0. I updated from v21.4 to v22.0 using the Magisk app direct install while on this update.

I suspect there may be some changes in the new boot.img that conflict with the changes Magisk makes when patching it.

Any thoughts???
------------------------------------------------------------------------
Anyway, I discovered the solution to my dilemma mentioned above by searching thru forums and Youtube. This may be helpful to those who have flashed the latest ROM update for their phone, then flashed the Magisk patched boot.img and now the phone is unable to boot to the OS.

It appears that the bootloop caused by flashing the 'Magisk_v22.0_Patched_boot.img' was due to installed Magisk modules. This is what worked for me:

1. Boot into TWRP from fastboot.
2. Using the File Manager in TWRP navigate to the '/data/adb/modules/' folder where the Magisk modules reside as folders. Delete all of them.
3. If Magisk is NOT installed then flash 'Magisk_v22.0_Patched_boot.img' as Boot or 'Magisk_v22.0.zip' in TWRP and boot phone to the OS.
4. Open the Magisk app to configure Magisk and install the Magisk modules.
5. Reboot.

The phone is now running the latest ROM, rooted with Magisk v22.0, passes safety net all without erasing user data...
 
Last edited:
  • Like
Reactions: Uluru25

pndwal

Senior Member
Jun 23, 2016
2,050
1,215
163
Sydney
Xiaomi Redmi Note 7
Need some help installing Magisk on an ancient Rockchip tablet. It's the Medion Lifetab E7312, based on Rockchip RK3066 SoC, running Cyanogenmod 12.1 (Android 5.1). This device got its own seperate kernel.img, instead of the kernel being part of boot.img. I tried to patch the kernel.img (and also boot.img and recovery.img, just to be sure) in Magisk 22, but always get the "Unsupported/Unknown image format" error message.

Any idea how I can get it to work? Maybe manually patch the image?
Here are the images:
Do you have a custom recovery for that?... And does Magisk app say ramdisk = yes? PW
 

justjeepin

Member
Mar 15, 2019
11
1
3
I have a Samsung Tab S2 that I previously had Lineage OS 16 and recently installed an unofficial Lineage OS 17.1 rom. I got everything working but Netflix and Disney Plus are not showing up in the Google Play Store. So I installed Magisk and MagiskHide Props Config. After a reboot I now pass a Safety Net check.

Two questions:

1. The previously mentioned apps still don't show in the Google Play Store.

2. I read something about keeping your device certified by installing a configuration file. It says to do it before setting up your device but I already have everything setup. Can I still do it or will I have to clean install and start over?

With stock LOS I didn't have this issue but with this custom rom I am.
 

Top Liked Posts

  • 2
    It's systemless because it doesn't modify the system partition by default.
    Yes, of course!
    Android checks the partition integrity at boot on most new devices.
    Not sure this matters much once AVB is defeated by unlocking bootloader, but since most newer stock ROMs are locked to read-only due to 'Shared Blocks' implementation, a systemless solution may be the only practical option.
    It didn't in the earlier versions of Android. You could literally just add root permissions right to the system and have no problems. Since that is no longer the case, it now resides in the boot image, not system image and never the recovery image.
    Well, it exists always in a boot image certainly, as it's always in ramdisk. But recovery image is also a boot image with ramdisk!

    Actually, boot partition doesn't always contain ramdisk, and boot type ramdisk added manually by Magisk will also fail when bootloader support is missing, as is the case with the type III devices discussed here:
    https://topjohnwu.github.io/Magisk/boot.html

    Fortunately, there is a second Android boot image that can be used as an alternative; Recovery.img. As John Wu states:
    recovery and boot partition:
    these 2 are actually very similar: both are Android boot images containing ramdisk and Linux kernel (plus some other stuff).
    In the case of type III devices, Magisk in Recovery is the only option for Magisk root. Please see Magisk in Recovery section in Installation Instructions:
    https://topjohnwu.github.io/Magisk/install.html#magisk-in-recovery

    Magisk 'Recovery mode' patching option exists specifically for the purpose of patching recovery.img with Magisk properly, as boot partition ramdisk and recovery partition ramdisk configurations differ significantly.

    Wiith 'Magisk in Recovery', boot.img can be left stock & unaltered. Generally however, 'Magisk in Boot' is the preferred option, especially as no special key combinations are needed to boot with Magisk root.

    ... As has been observed however, both of these 'Systemless' root options have advantages over solutions that alter system. Eg:

    1) Ease of recovering from systemless mod failure causing boot issues. There are several methods to prevent these 'system overlays' from being applied, hence allowing system to boot normally.

    2) Only Boot and/or Recovery partitions need restoring to take OTA updates (because actual system partition is unaltered). Also, as modules / Magisk settings are stored in /data partition, after flashing Magisk patched images again the mods / settings are restored. PW
    2
    Under Magisk it's "Installed 22.1 (22100) | Ramdisk Yes | A/B Yes | SAR YES"
    Under App it's "Latest 22.1 (22100) (20) | Installed 22.1 (22100) | Package com.topjohnwu.magisk"
    It seems to be the same version except the App's Latest has an additional "(20)" over the Installed part.
    You could have attached the screenshot but per description, it looks ok.
    E.g., I have Canary 22002 (not Stable 22000 like you), Magisk properly imstalled and all ok - compare to my screenshot

    If I understand correctly, you reported a crash while installing a Magisk module

    If installing from Repo, take Download (instead of Install), it will download to your Download folder.
    Then, take from Magisk app (again Modules tab, at the top), Install from storage and navigate to the Download folder and the downloaded module zip file

    I.e., there was recently a bug that Magisk app was crashing when installing a module but by e.g. installing an already downloaded module zip file it worked fine (since I'm on Canary 22002, I don't know how is the case with your Stable 22000)

    There was also another workaround. When taking Install, once Magisk app crashed, it was just enough to tap to the notification that module was downloaded - Magisk app would continue installinf the module

    If still failing/crashing, try with another Magisk module (from Repo!) to make sure it wasn't an errant module
    1
    I assume you were patching recovery.img w/ Recovery mode check toggled on!

    Perhaps John couldn't reproduce issue since you didn't specify 0 byte result only occurs if Magisk App is not unhidden / restored, and issue title was simply "Magisk v22+ produces a boot.img of zero size".

    Why not create a new issue with clear title: "Magisk v22xxx produces a Recovery image of zero size on Galaxy S10 if App remains hidden" etc, as long as issue still exists using latest 22102. 👍 PW
    1) Obviously.
    2) As specified / already mentioned I would have mentioned it if I had known it before. I thought it was a general problem.
    3) Sure, that would be plan B.
    1
    1) Obviously.
    2) As specified / already mentioned I would have mentioned it if I had known it before. I thought it was a general problem.
    3) Sure, that would be plan B.
    But you said you feel John will likely overlook your comments.

    My feeling is that he won't if a new issue that states the configuration that results in the bug/issue clearly is opened. 🙂

    I've seen other users reopen the same issue multiple times, but get taken seriously in the end... And yours does seem serious, especially as it may well affect other devices.

    Didge. may well help however! 😉 PW
    1
    @dr4go I don't understand why you talk of whether the Recovery box is checked. I thought you had a Samsung device, and I thought the firmware came packaged as tar files, so I thought you would be telling Magisk to patch AP.tar. Magisk will modify boot, recovery, and vbmeta, and will produce magisk-patched-AP.tar -- you feed that to Odin, and all three get "flashed" (along with everything else in the tar, and everything in the other three tars you pass to Odin).

    Are you seeing this zero-length boot.img in the magisk-patched-AP.tar?
    Why I talk about the recovery box being checked? No offense, but please reread the posts. I found it pointless to talk about that, because I can't change the way of how Samsung's bootloader work.
    I assume you know how it works, if not please inform yourself. Explanation: Magisk usually resides in the boot.img. But because those semi-modern devices (s10 series and some others) come with no initramfs, you need to patch the recovery (that is Magisk gets installed there). So you need to press a key combo to boot rooted (you often see people complain about that, because they don't know their devices and should not root at all: "help, I lost root!", etc.).

    Yes.

    This will he my last post about that, because I find it rather pointless to spam this huge thread even more with no added information. And obviously this talking won't anything help to fix this issue. I prefer to be quiet if I have nothing useful to say.
  • 12

    Latest Public (Stable / Beta)

    Release Notes and Changelog:


    2021.4.9 Magisk v22.1​

    This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.

    Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.

    Bug Fixes​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    🎉 👍 PW
    8
    @osm0sis
    Thank you for having an eye on that.
    Did the "ls" twice, first from a TWRP-terminal in recovery, second from a terminal while phone is "up and running".
    Looks like you have /dev/bootimg as your real partition location and it is still higher in the list in util_functions.sh like how I fixed it in the linked commit, so this is definitely a regression from some other recent change to Magisk.. sigh, I'll look into it. 🤔😕
    6

    Latest Canary Changelog, including Release Notes:​


    Magisk (9c0e1897) (22007)​

    • [General] Fix logic to copy sepolicy.rule during module installation
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.

    Diffs to v22.0​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlock
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    👍 PW
    6
    #Xiaomi.eu, #OTA, #Magisk 22006, #Viper4Android, #sepolicy.rule

    This week, Xiaomi.eu weekly update 21.3.24 (MIUI 12.5, A11) was late a day and a half, hence I upgraded yesterday night

    As usual:
    - I downloaded the zip, extracted boot.img and patched (already from my previous Xiaomi.eu 21.3.18, rooted by Magisk 22006)
    - Flashed the Xiaomi.eu zip from TWRP, wiped Dalwik and Cache and rebooted
    - Then rebooted once again to TWRP and flashed the boot.img that was patched in advance

    I could probably flash its patched boot img right after flashing the 'OTA' zip (saving one time booting to the not-rooted system and rebooting to TWRP), but I rather play the safe and many times proven game

    Upon rebooting with the patched boot img, I have Magisk 22006 root again, with all modules (except V4A), root granted apps snd apps enabled for Magisk hide

    This time the old trick to make V4A did not work. Maybe because of the known sepolicy.rule bug in Magisk 22006, or maybe I was not 'patient' enough and made a mistake in steps

    Anyway, I also wanted to test, hence I modified V4A's post-fs-data.sh in accordance to:
    https://forum.xda-developers.com/t/...-0-viper4android-fx-2-7.3774651/post-84121895
    rebooted, and it did the trick 👍

    The modified post-fs-data.sh for:
    /data/adb/modules/ViPER4AndroidFX
    is zipped and attached

    The zip also contains DDC and Kernel folders to be copied ton Internalmemory: /Android/data/com.pittvandewitt.viperfx/files
    for V4A Convolvers and headphone profiles

    Hence now I have again AML, V4A plus another audio mode (320 kbps bitrate for my phone) and V4A is happilly again Supported and Proccessing (still in the Legacy mode)
    6
    No, the phone is an Estar Takee1.
    ROM is from here: Mikel Android 7 for Takee1
    and is itself a port from this ROM: RidonOS for Micromaxx A311

    You're right, sorry for that. Now here the installation log for canary-version:

    - Target image: /dev/BOOT
    - Device platform: armeabi-v7a
    - Installing: f152b4c2 (22005)
    nanddump: MEMGETINFO: Not a typewriter
    Parsing boot image: [boot.img]
    - Unpacking boot image
    ! Unsupported/Unknown image format
    ! Installation failed

    😛

    /dev/BOOT is known (usually) not an actual boot partition, hence nanddump failing.

    I had originally fixed this back here: https://github.com/topjohnwu/Magisk/commit/2aede97754fec67d393bde0c7725ed84d8c3c112

    So not sure if we're looking at some kind of a regression, or just a further edge case.

    @io2345 what's the actual, correct location of your boot partition? Please give me the output of `ls -alR /dev`
  • 1045
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    155
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    119
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    74
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone