Magisk General Support / Discussion

Search This thread

ineedroot69

Senior Member
Nov 13, 2019
746
1
144
I'm using lineagOS 17.1 on the xperia xz2 compact

Is it necessary to re-flash the patched boot.img everytime lineage releases an update? Can i use to the same patched boot.img or do i need to extract boot.img from the new release, patch it, and then flash it?
they might do some changes on boot partition so if that happen and you used patched boot.img from previous OS version it might trigger bootloop so its better to extract and re-flash patched boot.img everytime lineage releases an update its not that time consuming anyway ...
 

pndwal

Senior Member
Jun 23, 2016
2,082
1,258
Sydney
Xiaomi Redmi Note 7
Hi everyone
After a lot of researches I'm closed to giving up installing Magisk. But before that, I'm here to see if someone can take some time to help me get what I'm missing.
So here is my situation and my understanding. Any help would be appreciated.

I bought a K20 pro (MI9T Pro) with unlocked bootloader (global ROM installed in place of the original chinese one) unrooted. So I can't pay with Gpay.
I found a way to make if work from :
https://xiaomi.eu/community/threads/tutorial-working-fix-for-safetynet-cts-profile-failed.59384/

From there I realised I need to install Magisk.
I then installed magisk.app but my Ramdisk is at NO

So plz tell me if all that's bellow, if no plz correct it :
  • I need to install twrp
  • I must find the recovery.img (I downloaded my official rom.zip but couldn't find the recovery.img, only the boot.img) ==> where can if find this recovery.img ? Plus, is that necessary ? I read on this thread that Magisk can work with the boot.img for Xiaomi phone
  • I proceed like discribed on https://topjohnwu.github.io/Magisk/install.html
  • I dl the module on xiaomi.eu's link above
I'm good.
My two problems are :
Do I need to install twrp and where to find this recovery.img (and any other mistakes that would have been pointed out^^)

Thx for you help
NEVER give up!

Can you confirm its actually Chinese variant (eg box info, not phone settings)... Appears some Indian K20 Pro variants physically lack NFC hardware, and have been sold unlocked w/ global ROMs etc.

NFC cannot apparently be made to work on these Indian models, but Chinese variant has NFC and reportedly also works with later (10.3.12.0 MIUI onward) global or custom XiaomiEU ROMs.
https://forum.xda-developers.com/t/solved-no-nfc-on-redmi-k20-pro.3945229/

You should NOT need the mods you found on XiaomiEU site.

You DON'T need TWRP.

You likely DON'T need recovery.img DESPITE (factory) ramdisk (in boot) = no (because it's Xiaomi):
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84603817

Once you have 10.3.12.0 MIUI global or later installed, and ADB Fastboot PC drivers working, also extract boot.img from ROM package, then simply install Magisk APK, open app, click install Magisk, then NEXT (in Options with Recovery Mode UNCHECKED), click Select and Patch a File, select your boot.img, click Let's Go, wait for All Done!, boot to fastboot and flash patchedboot.img (as for ramdisk= yes). Boot to system. If it bootloops (system is corrupted message), simply flash UNPATCHED boot.img. You will likely need Magisk in recovery in this case.

If system boots, check you have root in Magisk app. If not, you will also likely need to flash UNPATCHED boot.img and Install Magisk in recovery.

If you have root (most likely), turn on Magisk hide in settings, reboot and run Check SafetyNet in Magisk app. If you get basicIntegrity pass but ctsProfile fail, install Universal SafetyNet Fix (and Busybox for Android NDK) Magisk module, reboot and check SafetyNet again. If you have pass, open PlayStore settings and check PlayProtect says Device is Certified. If not, clear Google PlayStore data and Google Play Services cache, reboot and check again.

If you have PlayProtect certified device, Install Gpay (if necessary), open Magisk app and toggle on Google Pay in MagiskHide list, then reboot. Next, clear Data for Google Pay, then open it and try setting up card(s) / NFC payment.

Nb. It seems that there is no longer a need to install SQLite fix for Gpay.

All best! PW
 
Last edited:

toot-217

Member
Nov 3, 2012
20
3
When I open Magisk on my LG G5 h850 (running Lineage 10) I get the prompt to "upgrade to the complete Magisk manager to complete the setup."

And when I choose to "download and install" and hit Ok I receive the toast message "please manually re-launch the app".

I wanted to open Magisk to update to v.22, what have i to do now?
 

Philnicolls89

Senior Member
Jun 28, 2019
591
241
32
A.C.T
Hi all, sorry for the OT question but I haven't been able to find the answer elsewhere. I am curious to know how i can find out if a phone has its /system as RW or RO? my current S10+ is RW and I like being able to just delete or edit things using mixplorer, especially when it comes to debloating system apps.
If I have access to the device in question (fully stock unrooted) is there a way to find out this information?
 

Homeboy76

Senior Member
Aug 24, 2012
2,514
1,213
But, you're installing the recovery to the boot partition.

Does it just work out because you install something else to the boot partition later?
:oops: Opps, I left out the word temporarily.
This is why I said temporarily install lineage 17.1...recovery...img to the boot partition on my Pixel XL (marlin): Install LineageOS on marlin
I do understand your point, because it makes sense to temporarily boot the recovery using fastboot boot lineage17.1...recovery...img.
 
Last edited:
  • Like
Reactions: J.Michael

pndwal

Senior Member
Jun 23, 2016
2,082
1,258
Sydney
Xiaomi Redmi Note 7
I'm using lineagOS 17.1 on the xperia xz2 compact

Is it necessary to re-flash the patched boot.img everytime lineage releases an update? Can i use to the same patched boot.img or do i need to extract boot.img from the new release, patch it, and then flash it?
Aside from above advice:

FWIW, if you simply want to avoid large download each time, this should work (if you have TWRP):

Unroot, flash OTA update, do TWRP backup of boot image, rename resulting boot.emmc.win file to boot.img and patch that. Flash to re-root.

Have a properly extracted boot.img on hand the first time you try this to recover device in case it doesn't work for you. PW
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
Jun 23, 2016
2,082
1,258
Sydney
Xiaomi Redmi Note 7
:oops: Opps, I left out the word temporarily.
This is why I temporarily install lineage 17.1...img to the boot partition on my Pixel XL (marlin): Install LineageOS on marlin - Temporarily booting a custom recovery using fastboot
Mmm. And more seriously "fastboot flash boot lineage-17.1-20210303-recovery-marlin.img will install (flash) the recovery image to the boot partition on the device" (causing boot failure) as pointed out!
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84612929

😬 😉 PW
 

Homeboy76

Senior Member
Aug 24, 2012
2,514
1,213
Last edited:
  • Like
Reactions: pndwal

ineedroot69

Senior Member
Nov 13, 2019
746
1
144
unless if you got fetish having bootloop then go on 😉
Hi all, sorry for the OT question but I haven't been able to find the answer elsewhere. I am curious to know how i can find out if a phone has its /system as RW or RO? my current S10+ is RW and I like being able to just delete or edit things using mixplorer, especially when it comes to debloating system apps.
If I have access to the device in question (fully stock unrooted) is there a way to find out this information?
adb shell > cat /proc/mounts

or this android app https://play.google.com/store/apps/details?id=me.kuder.diskinfo
 

pndwal

Senior Member
Jun 23, 2016
2,082
1,258
Sydney
Xiaomi Redmi Note 7

pndwal

Senior Member
Jun 23, 2016
2,082
1,258
Sydney
Xiaomi Redmi Note 7
Latest Canary Magisk Changelog:

Magisk (45e0df9c) (22002)
  • [App] Prevent multiple installation sessions running in parallel
  • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
  • [General] Proper cgroup migration implementation
  • [General] Prevent possible deadlock in logging code
  • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
👍 PW
 

pndwal

Senior Member
Jun 23, 2016
2,082
1,258
Sydney
Xiaomi Redmi Note 7
Just had an 'Oh No' moment after flashing this!

Re-booted fine, but not fully; clock widget wouldn't appear, apps wouldn't open, or open and hang... Thought I'd be reflashing last patched boot.img...

Decided to try second reboot:

Fully booted this time, and all seems fine now...

Root is intact, settings preserved, SafetyNet passing fully. 👍

So be aware, you may have issues till second reboot. (Some are also getting 'unable to repack boot Image!' error.)

- Redmi Note 8T, Magisk in boot.img (despite ramdisk = no). PW
 
Last edited:
  • Like
Reactions: J.Michael

pndwal

Senior Member
Jun 23, 2016
2,082
1,258
Sydney
Xiaomi Redmi Note 7
Latest Canary Magisk Changelog and Release Notes:

Magisk (bf80b08b) (22003)
  • Rebuild executables (fix boot image repacking issues)
Diffs to v22.0
  • [App] Prevent multiple installation sessions running in parallel
  • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
  • [General] Proper cgroup migration implementation
  • [General] Prevent possible deadlock in logging code
  • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
👍 PW
 

Homeboy76

Senior Member
Aug 24, 2012
2,514
1,213
Well, you're right... That guide prescribes 'fastboot flash boot <recovery_filename>. img' for temporary boot to recovery!

This makes no sense to me... are you sure you used that?

Official instructions properly prescribe 'fastboot boot path/to/twrp.img'
https://twrp.me/google/googlepixelxl.html

PW
Yes, decided to give fastboot boot ... a try the next time I update. Also posted a question to Dev about it.
 
  • Like
Reactions: pndwal

capitarider

Member
Jun 8, 2015
28
3
Hey there,

I am currently struggeling with my Samsung Galaxy S7 (Exynos) device, running on superman rom (Android 8).

What happened?
For root I´m using Magisk Manager and for banking apps I have Magisk hide running. Then the program told me that there is an update (Magisk App) available. So, as always and recommended, I choosed "Direct Install" but that failed for some reason. OK I thought´, no problem. Later I wanted to reboot my phone but it didn´t. The screen says "Downloading.... Do not turn off device!". I only can enter "Download Mode" and "Recovery Mode via TWRP".

What I tried so far:
1) Wipe cache/dalvik --> not successful
2) Tried to do a factory reset via twrp --> not successful

At this time I realised that the same problem occured to my Galaxy Tablet SM-T580. So I came to the point that I did something wrong with updating magisk on both devides.

What I also tried next:
3) Tried to delete magisk modules via twrp --> not successful
4) Tried to uninstall magisk through twrp by downloading the latest Magisk app and rename it to "uninstall.zip" as recommended in installation guide --> Not successful because of Error installing zip file: Unsupported /Unknown image format

What can I do next?
Please help me
 

boxemall

Member
Feb 2, 2012
24
4
Device: Xiaomi Mi9t /Redmi K20

Updated to "https://xiaomifirmwareupdater.com/firmware/davinci/weekly/21.1.28/"
&
Flashed "https://build.aospa.co/prerelease/davinci/pa-ruby-beta-1-davinci-20210202.zip"

After reboot all worked fine without any errors. I then went on and rebooted into TWRP (twrp-3.5.0_9-0-davinci.img)

I followed instructions and patched the above twrp-3.5.0_9-0-davinci.img which got successfully patched & renamed into the process.

following that, i flashed the patched recovery. system rebooted fine but without root, which was expected due to not pressing any key combos during boot.

also worth mentioning: once rebooted after flashing the patched recovery magisk app won't show magisk as installed. is that due to the "normal" boot? it will probably only show in the app when the key combo is executed properly during boot, right?

the issue here is that no matter what key combo is pressed the device ends up in fastboot mode. using fastboot commands, it won't reboot normally (fastboot reboot) and neither into recovery (fastboot reboot recovery).
reoobting without key combos won't reboot into system either.

the only thing that helps is re-flashing the unpatched twrp image over fastboot.

if there is anything i can help with, plz do tell and i'll do anything possible to me!

regards
 

zelitrex36

Member
Feb 29, 2012
17
6
NEVER give up!

Can you confirm its actually Chinese variant (eg box info, not phone settings)... Appears some Indian K20 Pro variants physically lack NFC hardware, and have been sold unlocked w/ global ROMs etc.

NFC cannot apparently be made to work on these Indian models, but Chinese variant has NFC and reportedly also works with later (10.3.12.0 MIUI onward) global or custom XiaomiEU ROMs.
https://forum.xda-developers.com/t/solved-no-nfc-on-redmi-k20-pro.3945229/

You should NOT need the mods you found on XiaomiEU site.

You DON'T need TWRP.

You likely DON'T need recovery.img DESPITE (factory) ramdisk (in boot) = no (because it's Xiaomi):
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84603817

Once you have 10.3.12.0 MIUI global or later installed, and ADB Fastboot PC drivers working, also extract boot.img from ROM package, then simply install Magisk APK, open app, click install Magisk, then NEXT (in Options with Recovery Mode UNCHECKED), click Select and Patch a File, select your boot.img, click Let's Go, wait for All Done!, boot to fastboot and flash patchedboot.img (as for ramdisk= yes). Boot to system. If it bootloops (system is corrupted message), simply flash UNPATCHED boot.img. You will likely need Magisk in recovery in this case.

If system boots, check you have root in Magisk app. If not, you will also likely need to flash UNPATCHED boot.img and Install Magisk in recovery.

If you have root (most likely), turn on Magisk hide in settings, reboot and run Check SafetyNet in Magisk app. If you get basicIntegrity pass but ctsProfile fail, install Universal SafetyNet Fix (and Busybox for Android NDK) Magisk module, reboot and check SafetyNet again. If you have pass, open PlayStore settings and check PlayProtect says Device is Certified. If not, clear Google PlayStore data and Google Play Services cache, reboot and check again.

If you have PlayProtect certified device, Install Gpay (if necessary), open Magisk app and toggle on Google Pay in MagiskHide list, then reboot. Next, clear Data for Google Pay, then open it and try setting up card(s) / NFC payment.

Nb. It seems that there is no longer a need to install SQLite fix for Gpay.

All best! PW

just waw
Thank you so much for the spent to help me. It worked like a charm.
I had a hard time finding if my NFC was working but a phone tester app made its tests with a credit card to test the NFC. From there I could run everything you said.
Unfortunately, I have one last problem and I found it as already been described here :

The OP could solve it by wiping datas... That doesn't work for me. Any idea of what I could do ?
Anyway thanks again that was veeeeeery kind to help me like that and taking the time to describe step by step what to do :)

Edit : I realized that I did that not correctly :
If you have PlayProtect certified device, Install Gpay (if necessary), open Magisk app and toggle on Google Pay in MagiskHide list, then reboot. Next, clear Data for Google Pay, then open it and try setting up card(s) / NFC payment.
I did :
Got PlayProtect certified device, opened Gpay, clear Data for Google Pay (and play service and Playstore again). Only then I got what "open Magisk app and toggle on Google Pay in MagiskHide list, then reboot" means and actually did it.
 
Last edited:

Top Liked Posts

  • 4
    Thanks pndwal I got my safety net up and going!
    Actually SafteyNet was passing all the time... It's just Magisk-side issue
    3
    Alright Im new to XDA but not new to rooting. I'm hoping to get some answers with a glitch I have found. I have passed safety net no problems (I am rocking a oneplus 8 pro and its been rooted since I got it!) Until now! Magisk say api error , and other safety-net apps fail too! The weird thing is Netflix and my baking apps work no problems so I'm not to worried but it bugs the crap out of me! The troubleshooting steps I took was, I factory reset and rerooted (after hours of trying to find out what change) I went back to stock ROM and rerooted the phone and still cannot figure it out! I went ahead and put lineage 18.1 back on and hope I can find some answers later. Maybe I can get someone to check there safety net through magisk and see if its a me problem or a magisk problem. Thanks guys!
    Just read the previous page or two. Everything has been explained.
    2
    Thank you

    Thank you
    But in first when i started using magisk myb v22, in option there was canary beta stable.
    But now only have beta
    Is there any link to download canary apk in my sony xz premium?
    In the Stable and Beta builds there is no option for Canary

    To have Stable, Beta and Canary Update channel options, stay in Canary app
    2
    Using magisk 22.1 (22100) in
    Sony xz premium g8142.
    everything was ok but suddnly
    riru lasposed got error *Sepolicy not loaded properly
    This fix may help with your issue, and is already merged in Canary release:
    - [MagiskPolicy] Remove unnecessary sepolicy rules
    Also *safety net check got error
    Riru v25.4.2
    Lsposed v1. 3.5
    Fix for this is merged too:
    - [App] Update snet extension. This fixes SafetyNet API errors.
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84846949

    If you don't wish to switch to debug (Canary) release, next public (Stable / Beta) release will include fixes, and may be imminent.
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84847033 PW
    2
    Thanks but you forgot to include a link to where that changelog comes from. ¯\_(ツ)_/¯

    ***
    Thanks but that won't fix @pndwal's bad habit of not including a link to the source when quoting changelogs. ;)
    Of course but if one goes to a page to copy a changelog then how difficult is it to also copy the URL?

    Sorry but lack of attribution and/or link to source is a pet peeve of mine.
    ***
    I have taken time to respond to your opinion at least twice now, CLEARLY EXPLAINING my reasoning / method, INCLUDING source for John's current material / releases / notes.
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84312597

    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84817221

    You have not once done me same courtesy, or even acknowledged responses... You just keep repeating 'You forgot..." ☹️

    Should I keep saying "No I didn't"? ... or keep responding when you don't? 🙄

    ... I've told you I didn't forget... Whether or not it's a 'bad habit' is purely subjective, especially if the reasons are not considered.

    To be clear, when I've quoted from other sources, or old postings from John's Twitter and GitHub pages, I HAVE been at pains to cite source pages.

    I have also explained that the generic link to canary/notes.md is not static (it won't show notes for build referenced if link is used after a later Canary release). This is another reason not to include it.

    Of course, I could go to the trouble of locating the static link to a particular Canary build file, but why, when it will seldom be needed (and anyone needing it retrospectively will also likely need to understand how to locate all the files for that build). See below for repository for Canary builds.

    For those here who are unfamiliar with John Wu's channels for CURRENT documentation / files / comments, I have happily supplied this generic information when asked, and noted changes when these occur.

    For instance, I included this in my reply to you (link above):
    FYI, debug (Canary) repository has recently changed from https://github.com/topjohnwu/magisk_files/tree/canary to https://github.com/topjohnwu/magisk-files/tree/canary

    Release notes are therefore now found at https://github.com/topjohnwu/magisk-files/blob/canary/notes.md

    Nb. This link will not remain correct for cited Release Notes since it will always show the latest. Searches by commit / date give static address for specific builds.

    FOR CANARY USERS WANTING TO ACCESS BUILD FILES:

    I hope repeating this particular information regarding repository for debug Canary build files will help other debug (Canary) build users locate both current and old debug build files and information.

    Nb. User must select Canary branch in John Wu's /magisk-files repository, then (for older builds at least) the commit history (clock) button, then a commit selected by date, then Browse files, then either View code or Go to file (from menu), then select a file to view or download. PW
  • 12

    Latest Public (Stable / Beta)

    Release Notes and Changelog:


    2021.4.9 Magisk v22.1​

    This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.

    Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.

    Bug Fixes​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    🎉 👍 PW
    10
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/ea57c9b33b3a6ce2e0e65ce4c33dfb1c01552fcb/notes.md :

    Magisk (f49966d8) (22103)​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    Diffs to v22.1​

    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic
    👍 ...And things are all Rosy 'n Safe in the Custom Mod. world once again... but ironically, only on the bleeding edge... (Confirmed on my RN8T. 🙂 )

    News for those not wanting to get cut (Public Stable / Beta users) below. 😜

    Thanks John... And other collaborators for additional fixes! PW
    8
    Update snet.jar extension
    The existing API key was revoked for some reason.
    Release an updated extension jar with a new API key.

    In addition, add some offline signature verification and change how
    results are parsed to workaround some dumbass Xposed module "faking"
    success results, since many users really don't know better.

    @topjohnwu

    topjohnwu committed 19 minutes ago
    8
    @osm0sis
    Thank you for having an eye on that.
    Did the "ls" twice, first from a TWRP-terminal in recovery, second from a terminal while phone is "up and running".
    Looks like you have /dev/bootimg as your real partition location and it is still higher in the list in util_functions.sh like how I fixed it in the linked commit, so this is definitely a regression from some other recent change to Magisk.. sigh, I'll look into it. 🤔😕
    6

    Latest Canary Changelog, including Release Notes:​


    Magisk (9c0e1897) (22007)​

    • [General] Fix logic to copy sepolicy.rule during module installation
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.

    Diffs to v22.0​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlock
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    👍 PW
  • 1046
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    155
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    119
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    74
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone