Magisk General Support / Discussion

Search This thread

CapnShitzhu

Member
Feb 6, 2018
38
5
So through the process of hiding magisk through inapp settings, magisk crashed. And now I only see the Home screen of magisk app only. All the other tabs are gone. So I boot to recovery and reflash the magisk zip but still its the same. So I tried the Uninstaller and it fails too. I think the hiding process crashed before finishing so some stuff are messed and could not be Uninstaller. Anyway to fix this

Magisk. 21.4, Twrp 3.4.0, oneplus 5.
 

pndwal

Senior Member
Jun 23, 2016
2,116
1,308
Sydney
Xiaomi Redmi Note 7
Device: Xiaomi Mi9t /Redmi K20

Updated to "https://xiaomifirmwareupdater.com/firmware/davinci/weekly/21.1.28/"
&
Flashed "https://build.aospa.co/prerelease/davinci/pa-ruby-beta-1-davinci-20210202.zip"

After reboot all worked fine without any errors. I then went on and rebooted into TWRP (twrp-3.5.0_9-0-davinci.img)

I followed instructions and patched the above twrp-3.5.0_9-0-davinci.img which got successfully patched & renamed into the process.

following that, i flashed the patched recovery. system rebooted fine but without root, which was expected due to not pressing any key combos during boot.

also worth mentioning: once rebooted after flashing the patched recovery magisk app won't show magisk as installed. is that due to the "normal" boot? it will probably only show in the app when the key combo is executed properly during boot, right?

the issue here is that no matter what key combo is pressed the device ends up in fastboot mode. using fastboot commands, it won't reboot normally (fastboot reboot) and neither into recovery (fastboot reboot recovery).
reoobting without key combos won't reboot into system either.

the only thing that helps is re-flashing the unpatched twrp image over fastboot.

if there is anything i can help with, plz do tell and i'll do anything possible to me!

regards
I'd forget using Magisk in recovery, at least till you've tried patching boot.img.

Try method I gave @zelitrex36 (after restoring unpatched recovery):
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84614357

It worked for him; see post after yours. PW
 
Last edited:

pndwal

Senior Member
Jun 23, 2016
2,116
1,308
Sydney
Xiaomi Redmi Note 7
So through the process of hiding magisk through inapp settings, magisk crashed. And now I only see the Home screen of magisk app only. All the other tabs are gone. So I boot to recovery and reflash the magisk zip but still its the same. So I tried the Uninstaller and it fails too. I think the hiding process crashed before finishing so some stuff are messed and could not be Uninstaller. Anyway to fix this

Magisk. 21.4, Twrp 3.4.0, oneplus 5.
Yes, uninstalling Magisk won't fix this as uninstall can't see hidden app.

Just locate and uninstall BOTH hidden manager/app(s), and current manager/app (which are conflicting), then reinstall app for current Magisk root Installation. PW
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
Jun 23, 2016
2,116
1,308
Sydney
Xiaomi Redmi Note 7
Hey there,

I am currently struggeling with my Samsung Galaxy S7 (Exynos) device, running on superman rom (Android 8).

What happened?
For root I´m using Magisk Manager and for banking apps I have Magisk hide running. Then the program told me that there is an update (Magisk App) available. So, as always and recommended, I choosed "Direct Install" but that failed for some reason. OK I thought´, no problem. Later I wanted to reboot my phone but it didn´t. The screen says "Downloading.... Do not turn off device!". I only can enter "Download Mode" and "Recovery Mode via TWRP".

What I tried so far:
1) Wipe cache/dalvik --> not successful
2) Tried to do a factory reset via twrp --> not successful

At this time I realised that the same problem occured to my Galaxy Tablet SM-T580. So I came to the point that I did something wrong with updating magisk on both devides.

What I also tried next:
3) Tried to delete magisk modules via twrp --> not successful
4) Tried to uninstall magisk through twrp by downloading the latest Magisk app and rename it to "uninstall.zip" as recommended in installation guide --> Not successful because of Error installing zip file: Unsupported /Unknown image format

What can I do next?
Please help me
Restore a previously patched, or unpatched boot image for your ROM. PW
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
Jun 23, 2016
2,116
1,308
Sydney
Xiaomi Redmi Note 7
just waw
Thank you so much for the spent to help me. It worked like a charm.
...
Edit : I realized that I did that not correctly :
If you have PlayProtect certified device, Install Gpay (if necessary), open Magisk app and toggle on Google Pay in MagiskHide list, then reboot. Next, clear Data for Google Pay, then open it and try setting up card(s) / NFC payment.
I did :
Got PlayProtect certified device, opened Gpay, clear Data for Google Pay (and play service and Playstore again). Only then I got what "open Magisk app and toggle on Google Pay in MagiskHide list, then reboot" means and actually did it.
Yeah; If you have any further problems, ensure you toggled on Google Pay in MagiskHide list and rebooted BEFORE clearing GPay's data. PW
 
Last edited:
  • Like
Reactions: J.Michael

J.Michael

Senior Member
Jan 20, 2018
572
325
Hi all, sorry for the OT question but I haven't been able to find the answer elsewhere. I am curious to know how i can find out if a phone has its /system as RW or RO? my current S10+ is RW and I like being able to just delete or edit things using mixplorer, especially when it comes to debloating system apps.
If I have access to the device in question (fully stock unrooted) is there a way to find out this information?
I think even if unrooted, you can install a terminal emulator and run "mount" from the command prompt. The line for "/system" will tell how it is mounted ("ro" vs. "rw").
 
  • Like
Reactions: pndwal

J.Michael

Senior Member
Jan 20, 2018
572
325
Mmm. And more seriously "fastboot flash boot lineage-17.1-20210303-recovery-marlin.img will install (flash) the recovery image to the boot partition on the device" (causing boot failure) as pointed out!
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84612929

😬 😉 PW
I haven't tried it, but I would have thought flashing recovery.img to the boot partition would just give you two recoveries installed. Not a great way to have the device, but I wouldn't expect boot failure.
 
  • Like
Reactions: pndwal

pndwal

Senior Member
Jun 23, 2016
2,116
1,308
Sydney
Xiaomi Redmi Note 7
I haven't tried it, but I would have thought flashing recovery.img to the boot partition would just give you two recoveries installed. Not a great way to have the device, but I wouldn't expect boot failure.
Yeah, that crossed my mind too...but I don't know, and have never heard of this done in practice.

It could actually be useful, but I don't have an A/B device... PW
 

zelitrex36

Member
Feb 29, 2012
17
6
Yeah; If you have any further problems, ensure you toggled on Google Pay in MagiskHide list and rebooted BEFORE clearing GPay's data. PW


Hi there, I still have some issues :rolleyes:
But someone told me to never give up so I won't^^

My Gpay problem is still not resolved but I'll post that specific subject in the proper thread to avoid confusion and stick to magisk here.

I have one question and one issue :
Question : when I read "hide magisk" does that refer to :
1)
img1.jpg


OR

2)
img2.jpg


My issue is : My phone is now rooted and and can't connect to Teams anymore because it detects my phone as rooted. I don't know if it's Teams apk or "portail d'entreprise" which I also tried to hide as you can see on picture one.

Am I missing a module or did I make a mistake ?
Thx for you help. This is actually a bigger problem than my previous one lol (Gpay)
 
  • Like
Reactions: J.Michael

ineedroot69

Senior Member
Nov 13, 2019
747
1
145
Hi there, I still have some issues :rolleyes:
But someone told me to never give up so I won't^^

My Gpay problem is still not resolved but I'll post that specific subject in the proper thread to avoid confusion and stick to magisk here.

I have one question and one issue :
Question : when I read "hide magisk" does that refer to :
1)
View attachment 5243611

OR

2)
View attachment 5243615

My issue is : My phone is now rooted and and can't connect to Teams anymore because it detects my phone as rooted. I don't know if it's Teams apk or "portail d'entreprise" which I also tried to hide as you can see on picture one.

Am I missing a module or did I make a mistake ?
Thx for you help. This is actually a bigger problem than my previous one lol (Gpay)
you can try using xprivacy lua
 

pndwal

Senior Member
Jun 23, 2016
2,116
1,308
Sydney
Xiaomi Redmi Note 7
Hi there, I still have some issues :rolleyes:
But someone told me to never give up so I won't^^

My Gpay problem is still not resolved but I'll post that specific subject in the proper thread to avoid confusion and stick to magisk here.

I have one question and one issue :
Question : when I read "hide magisk" does that refer to :
1)
View attachment 5243611

OR

2)
View attachment 5243615

My issue is : My phone is now rooted and and can't connect to Teams anymore because it detects my phone as rooted. I don't know if it's Teams apk or "portail d'entreprise" which I also tried to hide as you can see on picture one.

Am I missing a module or did I make a mistake ?
Thx for you help. This is actually a bigger problem than my previous one lol (Gpay)
Good you don't have TWRP then!

Answer to 1st question: Without knowing where you were reading, I'm guessing neither. It's probably option Hide the Magisk app, --> Settings / App, last option.

Best tips on apps detecting root / custom mods:
https://www.didgeridoohan.com/magisk/MagiskHide#
-scroll down to Hiding Root from Apps. PW
 

pndwal

Senior Member
Jun 23, 2016
2,116
1,308
Sydney
Xiaomi Redmi Note 7
Never had a boot failure following the instructions: Install LineageOS on marlin . I do understand your point and I <edited> my post. 🙏
I haven't tried it, but I would have thought flashing recovery.img to the boot partition would just give you two recoveries installed. Not a great way to have the device, but I wouldn't expect boot failure.
Yeah, that crossed my mind too...but I don't know, and have never heard of this done in practice.

It could actually be useful, but I don't have an A/B device... PW
Actually, it now seems that this method may be reasonable practice for Legacy A/B devices as 'fastboot flash recovery twrp.img' will fail ('fastboot boot twrp.img' works however) as there is no recovery partition for these (although later A/B devices w/ 2SI & boot type ramdisk may include recovery _a / _b partitions), whereas flashing to boot_a / _b works! (until boot image is reflashed with a new OTA etc it seems).
https://android.stackexchange.com/q...rite-to-recovery-using-fastboot-on-a-b-device

Not sure if flashing this way will replace both ramdisk and kernel (don't know how new TWRP builds implement 'Install Recovery Ramdisk' option (which now utilizes Magiskboot to allow repacking boot images)) or the consequences, but only ramdisk (not kernel) should be replaced on these devices it seems. (Ramdisk in boot image is only used for recovery in these devices anyway; kernel is used for both system and recovery.)
https://topjohnwu.github.io/Magisk/boot.html

PW
 
Last edited:
  • Like
Reactions: Homeboy76

CSX321

Senior Member
Aug 21, 2009
608
277
Southern IL USA
My issue is : My phone is now rooted and and can't connect to Teams anymore because it detects my phone as rooted. I don't know if it's Teams apk or "portail d'entreprise" which I also tried to hide as you can see on picture one.
FWIW, I've never had a problem running Teams on my rooted Pixel 3, even without ticking it in Magisk Hide. It's running right now, and working fine.
 
  • Like
Reactions: J.Michael

Homeboy76

Senior Member
Aug 24, 2012
2,517
1,216
Actually, it now seems that this method may be reasonable practice for Legacy A/B devices as 'fastboot flash recovery twrp.img' will fail ('fastboot boot twrp.img' works however) as there is no recovery partition for these (although later A/B devices w/ 2SI & boot type ramdisk may include recovery _a / _b partitions), whereas flashing to boot_a / _b works! (until boot image is reflashed with a new OTA etc it seems)...
PW
Thanks for the information, I am going to edit my post (fastboot flash boot lineage17.1...) based on this information.
If the dev replies to my post with a change to the instruction I will modify the instructions and post his reply.
 
  • Like
Reactions: pndwal

HippoMan

Senior Member
May 5, 2009
1,597
459
Hippoland
Actually, it now seems that this method may be reasonable practice for Legacy A/B devices as 'fastboot flash recovery twrp.img' will fail ('fastboot boot twrp.img' works however) as there is no recovery partition for these (although later A/B devices w/ 2SI & boot type ramdisk may include recovery _a / _b partitions), whereas flashing to boot_a / _b works! (until boot image is reflashed with a new OTA etc it seems).
https://android.stackexchange.com/q...rite-to-recovery-using-fastboot-on-a-b-device
[ ... etc. ... ]
PW
On my legacy A/B device (OnePlus 7 Pro - GM-1917), I always do this to initially install TWRP:

1. boot phone into bootloader
2. connect phone to desktop via USB
3. (on the desktop machine) fastboot boot twrp-recovery.img
4. (in TWRP) Advanced->ADB Sideload
5. (in TWRP) swipe the "Swipe to Start Sideload" slider to the right
6. (on the desktop machine) adb sideload twrp-installer.zip
7. (in TWRP) reboot to recovery

I never had any problems with this TWRP installation method.
 

djsolidsnake86

Senior Member
Feb 14, 2009
2,285
98
hello, mi 9 lite and latest miui
i installed magisk 22 from zip (by renaming apk) and now my phone boot only in twrp
also installing 21.4 by zip file it boot to recovery
what do now?
also installing the uninstaller it boot to recovery
 
Last edited:

Top Liked Posts

  • 2
    Went to Canary to solve the API issue.
    App shows I'm running 22104 and that I'm on the Stable update channel.
    Will Magisk just install the stable when the next stable update is released?
    Supposidely, next Stable will be 22200, hence higher than Canary 2210x

    In that case, Magisk will first ask you to update (Install) Magisk app to that new Stable 22200, and afterwards you will update the Magisk itself
    2
    Now I'm more confused
    The app is set to the stable update channel. Will I auto update to the next stable or the next canary?
    View attachment 5287523
    I've answered you earlier today what will happen when Stable will be released with the build number 22200, higher than your installed Canary 22104

    Magisk app will offer you to install/update to 22200 and after that you will also smoothly update the Magisk itself to 22200 (Stable)

    Higher number will rule.
    And next Stable will not be 22101 or anything lower than your installed 22104 (Canary)

    And since you already put the Channel to Stable, further Canary updates will not bother you. At the time when TJW relesses his next Stable it will for sure be higher number than all previous Canaries and Betas - this is the procedure going on at least for the last two years
    1
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/ea57c9b33b3a6ce2e0e65ce4c33dfb1c01552fcb/notes.md :

    Magisk (f49966d8) (22103)​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    Diffs to v22.1​

    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic
    👍 ...And things are all Rosy 'n Safe in the Custom Mod. world once again... but ironically, only on the bleeding edge... (Confirmed on my RN8T. 🙂 )

    News for those not wanting to get cut (Public Stable / Beta users) below. 😜

    Thanks John... And other collaborators for additional fixes! PW
    Thanks, this solved my problem yesterday 👏
    1
    I'm on oos11 and today I got an API error in the magisk. Any ideas ?
    Unhide Magisk -> install Magisk Canary from GitHub -> rehide Magisk -> restart

    Or wait a little while for a new stable release.
    There's no real urgency. Phone still passes gpay, credit cards, banks, etc. The Check fails, not the hide.
    2
    I think that is talking about a specific Xposed module doing the faking rather than EdXposed/LSposed themselves... Could be wrong, but at least with EdXposed, you had to exclude certain Google apps to get SafetyNet to pass. So it wasn't like EdXposed is designed to pass SN by default.
    For Now Edxposed can't pass Savetynet by default.. LS give me blink status in SN app.. just Taichi give a stable pass in SN app 🤣
  • 12

    Latest Public (Stable / Beta)

    Release Notes and Changelog:


    2021.4.9 Magisk v22.1​

    This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.

    Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.

    Bug Fixes​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    🎉 👍 PW
    11
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/ea57c9b33b3a6ce2e0e65ce4c33dfb1c01552fcb/notes.md :

    Magisk (f49966d8) (22103)​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    Diffs to v22.1​

    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic
    👍 ...And things are all Rosy 'n Safe in the Custom Mod. world once again... but ironically, only on the bleeding edge... (Confirmed on my RN8T. 🙂 )

    News for those not wanting to get cut (Public Stable / Beta users) below. 😜

    Thanks John... And other collaborators for additional fixes! PW
    9
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/56d4ca44e12927217ae761df0874e3cd7d05cea4/notes.md :

    Magisk (fb8000b5) (22104)​

    • [App] Hide annoying errors in logs when hidden as stub
    • [App] Update stub implementation
    • [App] Some internal code refactoring
    • [App] Update snet extension implementation

    Diffs to v22.1​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [App] Hide annoying errors in logs when hidden as stub
    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    May fix sundry issues with Magisk App! 👍 PW
    8
    Update snet.jar extension
    The existing API key was revoked for some reason.
    Release an updated extension jar with a new API key.

    In addition, add some offline signature verification and change how
    results are parsed to workaround some dumbass Xposed module "faking"
    success results, since many users really don't know better.

    @topjohnwu

    topjohnwu committed 19 minutes ago
    7
    Strange how people think they don't need to read the other posts but expect that their questions should be addressed and answered😌
  • 1046
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    155
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    119
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    74
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone