Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
Jun 23, 2016
2,099
1,282
Sydney
Xiaomi Redmi Note 7
I'm on Android 7.1.2, RR-N 5.8.5 ONYX

Previous versions of magisk gave me the ability to use magisk-hide, even though I had to use "Magiskhide --disable Magiskhide --enable" on every reboot, I really didn't mind. Ive been using this workaround for a LOOOOONG time.
There's a fix for that: create a late_start service boot script. See here:
https://www.didgeridoohan.com/magisk/MagiskHideIssues#
Yesterday I updated to the new version and now everything is broken, I can no longer use my banking app. Magiskhide is no longer working. What is the solution here? I'd LOVE to downgrade but I can't find the means to do so, not even on github. Please help.
New public 22.0?

Sure MagiskHide is toggled on in Settings? Try toggling off, then on again.

Also, if you had Magisk Manager hidden/renamed, did you unhide BEFORE updating app as per instructions/reasons in changelog? If not, you'll have manager/app issues, and need to locate/uninstall BOTH before re-installing Magisk app.

You could try latest debug (Canary) build. It has many fixes. See differences in Release Notes I posted above.

Download apk file from main page Downloads / Magisk Canary link. (Clange extension to.zip to install from Custom Recovery)

Downgrading is easy w/ TWRP / zip package; just download and flash. Restore clean boot.img from ROM package in case of problems.

To download older public builds,, click Releases near end of main Magisk GitHub page, scroll to desired version, click Assets, then (zip) file.

To downgrade to pre public 22.0 releases from Manager/app, you'll need to set hosted address of raw json file for custom channel in app Settings. PW
 
Last edited:

pndwal

Senior Member
Jun 23, 2016
2,099
1,282
Sydney
Xiaomi Redmi Note 7
News:
John Wu, 11h

I have decided that Magisk v22 will be the last major version to support anything lower than Android 5.0. The next major release with the version bump will drop Kitkat and Jellybean support.
Reason: 😉
John Wu, 4h

First video game I played. My 6-year-old dum dum brain cannot solve many of the puzzles LOL

Image
What modesty! Age ÷ 4; We like your Dum Dum efforts John.

Thanks for spilling the J Beans... Have a break! Break a Kit Kat...

No one can handle too much desert, but you GOTTA leave some room for a Snow Cone!👍 PW
 
Last edited:
  • Haha
Reactions: dr4go

pndwal

Senior Member
Jun 23, 2016
2,099
1,282
Sydney
Xiaomi Redmi Note 7
On the Installation page, at the bottom, there is a "Samsung (System-as-root)" section. Does this also applies to the custom ROM?
Oooh YES!

If device launched w/ Android 9 or later.

You'll need to patch / use boot image for CUSTOM ROM, however that is packaged though...

Some info (patching tar files etc) will be useful for legacy Sammy devices also.

PW
 
Last edited:

nowster

Senior Member
Dec 30, 2012
374
123
I installed https://forum.xda-developers.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/ and now CTS is good as well, Safety net is OK, but Google Pay is not working still and now phone is hanging, after OS boot, phone freez.
Help guys..

//edit: phones booted up finally, but Google Pay is still not working, CTS is good.
Any idea?
The freeze is a problem with f2fs filesystem in the kernel.

The fix is to use a different kernel, which for the Pixel 3a and 3aXL MVK is the best maintained.

 
  • Like
Reactions: pndwal

newsera

Senior Member
Mar 24, 2011
129
6
Hi, I got this app called Singpass, its basically a 2FA app by the singapore government. It seems to detect magisk installation, and detects root even after magisk hide had been enabled and the magisk manager itself being reconfigured to a random package name.

At times magisk hide works on the app, but will stop working soon after. clearing the app cache and ticking unticking the app in magisk hide works sometimes.

I'm running lineage 17.1 with magiskhideprops config enabled - my device is sony kirin, and I'm able to pass safetynet check, any idea how I can debug this?
Did you find a workaround for this? I am running Evo X rom on my Poco and have the same issue. I don't even have Magisk installed and I assume by default the rom doesn't provide root privileges.
 

Xanth0k1d

Member
Sep 25, 2019
12
7
Did you find a workaround for this? I am running Evo X rom on my Poco and have the same issue. I don't even have Magisk installed and I assume by default the rom doesn't provide root privileges.
I wrote a post on this, you can find it under posts by me.
The vkey thing detects your devuce fingerprint as well, so if u r running a custom rom, singpass will not work.
 
  • Like
Reactions: pndwal

Mr.Brownstone

New member
Mar 13, 2011
2
0
Hi guys, first thanks for the hard work ! I have an issue that I think comes from Magisk: VoIP calls make my phone crash (Whatsapp, signal, etc). Looking at the log it seems to be audioserver that crashes, is there any fix for that ? Thanks in advance ! (FP3+, /e/ OS with microG, no Magisk modules installed) Log is here, see line 2546
 

zgfg

Senior Member
Oct 10, 2016
5,024
2,307
Hi guys, first thanks for the hard work ! I have an issue that I think comes from Magisk: VoIP calls make my phone crash (Whatsapp, signal, etc). Looking at the log it seems to be audioserver that crashes, is there any fix for that ? Thanks in advance ! (FP3+, /e/ OS with microG, no Magisk modules installed) Log is here, see line 2546
Developers are not really here but on Github - link to Gothub is on the Magisk app.
You will need to report the issue there, following the strict requirements (otherwise, ticket might be closed) about (Magisk) logs, phone, Android, firmware, Magisk version, etc (you will see when you go to open the ticket)

Also, make sure you test without Magisk - if you have no module or root app installed, Magisk, IMO, should not affect the audio driver
 
  • Like
Reactions: J.Michael

DualJoe

Senior Member
Oct 12, 2011
2,089
962
de
How can i edit files in /system? When i do 'sudo vim /system/etc/hosts' it says 'file is read-only'. I also cannot do a 'mount -o remount,rw /system'. It says '/system is not in /proc/mounts'.

LOS18.1
 

pndwal

Senior Member
Jun 23, 2016
2,099
1,282
Sydney
Xiaomi Redmi Note 7
How can i edit files in /system? When i do 'sudo vim /system/etc/hosts' it says 'file is read-only'. I also cannot do a 'mount -o remount,rw /system'. It says '/system is not in /proc/mounts'.

LOS18.1
Post Android 10, probably with some effort!

Here's one way, incl. info on new 'Shared Blocks' filesystem:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84739785

Magic Mount is the way to do it systemlessly using Magisk. It's essentially what Magisk modules do to load:
https://topjohnwu.github.io/Magisk/details.html#magic-mount PW
 
Last edited:

Mr.Brownstone

New member
Mar 13, 2011
2
0
Developers are not really here but on Github - link to Gothub is on the Magisk app.
You will need to report the issue there, following the strict requirements (otherwise, ticket might be closed) about (Magisk) logs, phone, Android, firmware, Magisk version, etc (you will see when you go to open the ticket)

Also, make sure you test without Magisk - if you have no module or root app installed, Magisk, IMO, should not affect the audio driver
OK thanks ! 👍
 

JimSmith94

Senior Member
Jul 21, 2007
2,743
522
Midlothian, TX
I'm not 100% sure what bricked my Pixel 5 but after installing the April Security update and patching boot.img, it was stuck on the fastboot screen with no boot image on slot b. I believe it happened because I patched boot. img without checking and installing the new Magisk Manager first. UbreakIFix was unable to force flash so now I'm waiting for them to get in a new motherboard. As I said, I'm not positive this caused it, but perhaps this warning will keep someone else from doing something stupid like I did.
 

pndwal

Senior Member
Jun 23, 2016
2,099
1,282
Sydney
Xiaomi Redmi Note 7

Latest Public (Stable / Beta)

Release Notes and Changelog:


2021.4.9 Magisk v22.1​

This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.

Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.

Bug Fixes​

  • [App] Prevent multiple installation sessions running in parallel
  • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
  • [General] Proper cgroup migration implementation
  • [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
  • [General] Many scripts updates fixing regressions
  • [MagiskHide] Prevent possible deadlock when signal arrives
  • [MagiskHide] Partial match process names if necessary
  • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
  • [MagiskBoot] Properly strip out data encryption flags
  • [MagiskBoot] Prevent possible integer overflow
  • [MagiskInit] Fix sepolicy.rule mounting strategy
  • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
🎉 👍 PW
 

stormy1777

Senior Member
Feb 12, 2016
153
44
Being Xiaomi, patching boot.img will most likely work despite Ramdisk=no. If your previous successful Installation was installed using zip archive flashed from TWRP, this would confirm Magisk in n boot partition succeeds on your device as zip necessarily installs to boot ramdisk, even if Magisk has to add it. (Works for me -RN8T- and for other models/users also). See below.*

Method:
Select Install Magisk, deselect Recovery mode, Patch boot.img, flash to boot partition using fastboot.

It's not clear what you first did. If you tried direct Install to update, you MUST unhide /restore Magisk Manager/app thru settings menu if hidden/renamed as clearly stated in the changelog (due to new incompatible hiding method) BEFORE updating Manager/app.

If you failed to do so, you likely had working root, but app shows 'n/a' due to the two apps conflicting. You need to uninstall BOTH newly installed app AND renamed (hidden) Manager, before installing app again.

Seems you may have Magisk in recovery partition now also (not sure whether you still have patched boot.img). - To get rooted OS depends on boot method in this case. Did you thereafter (starting from power off):
Use Recovery Key Combo, → (Splash screen) → Release all buttons (to get System with Magisk)?

Nb. Power up normally (= System with NO Magisk),
Recovery Key Combo → (Splash screen) → Keep pressing volume up (= Recovery Mode)

Also, your error message suggests archive download is corrupted, and this may be causing other issues too. Or, if you were still using Magisk patched recovery, this is a likely cause as you CANNOT use zip installer to update Magisk in recovery partition. You may also have TWRP incompatibilities, which is common, and why recovery flashing has been consigned to 'Legacy device support'.

I'd recommend cleaning up conflicting Magisk app/manager(s) as described above, flash clean / unpatched boot and recovery images, check system and recovery now boot normally, Install latest Magisk app, then try recommended patching method I described at the outset, but w/ boot.img, not recovery.img.

*Regarding Ramdisk=no

The current Installation Instructions say:

"if the result is **No** this means your device's boot partition does **NOT** include ramdisk. This means you will have to go through some extra steps to make Magisk work properly."

However, there are exceptions to this where patching and flashing boot image (as if your device's boot partition does include ramdisk) works because the assumption that bootloader is incompatible where OEM doesn't supply ramdisk in boot partition may not be true.

Magisk will add needed ramdisk functionality to boot image where lacking, but Magisk app will continue to indicate factory ramdisk state, ie. 'no', to indicate that bootloader support cannot be relied on. The only way to know for sure whether bootloader does or does not support the Magisk-added ramdisk in boot is to try patching / flashing boot image. Notably, this will work on most recent Xiaomi devices.

While Magisk should install in recovery partition by patching / flashing recovery also in these cases, installing in boot will be a better alternative.

If your bootloader does not support boot ramdisk, Magisk must be installed to recovery. Read the Magisk in Recovery section for VERY important information!

Hope this helps. PW

Thanks for the tips, and time writing.
Being Xiaomi, patching boot.img will most likely work despite Ramdisk=no. If your previous successful Installation was installed using zip archive flashed from TWRP, this would confirm Magisk in n boot partition succeeds on your device as zip necessarily installs to boot ramdisk, even if Magisk has to add it. (Works for me -RN8T- and for other models/users also). See below.*

Method:
Select Install Magisk, deselect Recovery mode, Patch boot.img, flash to boot partition using fastboot.

It's not clear what you first did. If you tried direct Install to update, you MUST unhide /restore Magisk Manager/app thru settings menu if hidden/renamed as clearly stated in the changelog (due to new incompatible hiding method) BEFORE updating Manager/app.

If you failed to do so, you likely had working root, but app shows 'n/a' due to the two apps conflicting. You need to uninstall BOTH newly installed app AND renamed (hidden) Manager, before installing app again.

Seems you may have Magisk in recovery partition now also (not sure whether you still have patched boot.img). - To get rooted OS depends on boot method in this case. Did you thereafter (starting from power off):
Use Recovery Key Combo, → (Splash screen) → Release all buttons (to get System with Magisk)?

Nb. Power up normally (= System with NO Magisk),
Recovery Key Combo → (Splash screen) → Keep pressing volume up (= Recovery Mode)

Also, your error message suggests archive download is corrupted, and this may be causing other issues too. Or, if you were still using Magisk patched recovery, this is a likely cause as you CANNOT use zip installer to update Magisk in recovery partition. You may also have TWRP incompatibilities, which is common, and why recovery flashing has been consigned to 'Legacy device support'.

I'd recommend cleaning up conflicting Magisk app/manager(s) as described above, flash clean / unpatched boot and recovery images, check system and recovery now boot normally, Install latest Magisk app, then try recommended patching method I described at the outset, but w/ boot.img, not recovery.img.

*Regarding Ramdisk=no

The current Installation Instructions say:

"if the result is **No** this means your device's boot partition does **NOT** include ramdisk. This means you will have to go through some extra steps to make Magisk work properly."

However, there are exceptions to this where patching and flashing boot image (as if your device's boot partition does include ramdisk) works because the assumption that bootloader is incompatible where OEM doesn't supply ramdisk in boot partition may not be true.

Magisk will add needed ramdisk functionality to boot image where lacking, but Magisk app will continue to indicate factory ramdisk state, ie. 'no', to indicate that bootloader support cannot be relied on. The only way to know for sure whether bootloader does or does not support the Magisk-added ramdisk in boot is to try patching / flashing boot image. Notably, this will work on most recent Xiaomi devices.

While Magisk should install in recovery partition by patching / flashing recovery also in these cases, installing in boot will be a better alternative.

If your bootloader does not support boot ramdisk, Magisk must be installed to recovery. Read the Magisk in Recovery section for VERY important information!

Hope this helps. PW
@pndwal thanks for the time, tips. helped.
Finally managed to update to magisk v22, with help of an EXTERNAL patcher:


It appears there's something "funky" with Redmi 7A in that ramdisk=no, but if patched outside by such tools, it can be added back, then Magisk's patching works.. original thread above has exact steps I've carried out.
Thanks.
Stormy.
 
  • Like
Reactions: pndwal

Top Liked Posts

  • 4
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/56d4ca44e12927217ae761df0874e3cd7d05cea4/notes.md :

    Magisk (fb8000b5) (22104)​

    • [App] Hide annoying errors in logs when hidden as stub
    • [App] Update stub implementation
    • [App] Some internal code refactoring
    • [App] Update snet extension implementation

    Diffs to v22.1​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [App] Hide annoying errors in logs when hidden as stub
    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    May fix sundry issues with Magisk App! 👍 PW
    2
    Oh!

    User with query in this case was simply trying to downgrade from current Canary to Stable. (User was stuck attempting App 'downgrade' at that point however).
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84859611

    I've done such 'downgrades' several times recently (App, then Magisk Mask) with no issues using phone only (Direct Install method), but only between new single-package builds. Do you recommend avoiding this option?

    Aside from issues resulting from failing to unhide Manager in older builds, what has gone wrong? PW
    Like I said, in most cases there are no issues. And when I say "horribly wrong", I just mean that the downgrade failed and that I needed to restore a stock boot image/uninstall Magisk and start fresh, nothing major. For the inexperienced user it could mean a bit of a panic though and may result in them doing a full reset of the device and losing a bunch of data...

    But, as also noted, it was a while since I've had that happen. I usually do test a lot and that of course raises the risk of things going wrong.

    Generally it's pretty low risk to downgrade, especially if the releases are pretty close version-vise, but things can always go belly up when you least expect it. Backup, backup, backup...
    2
    It's definitely not the apps doing in-depth checks as the same apps (with the same app versions) did work before.

    Anyway, I got some updates: interaction between Magisk and Webview Manager seems to be the problem. I installed the latter lately so this, and not the Magisk update, could be what introduced the change.

    I noticed that both of the apps which are giving me problems produce logs before crashing reporting the lack of the Chromium Webview. In fact, I currently only have the Bromite Webview installed.

    Anyway, I'd definitely not say that Magisk is completely innocent since disabling Magisk Hide make the apps work again, even in lack of the Chromium Webview.

    I'll report on eventual updates for possible readers facing my same problem, in the meantime suggestions are well accepted.
    I can confirm webview manager module as being an issue. In Magisk Canary passing Safetynet but PayPal, Venmo, Chase, Synovus apps not working until I uninstalled the Webview Manager module by Androidacy. Without it all are working fine.
    2
    Since now I have ignored the floating menu because usually it contains that "follow me on Twitter/Facebook/whatever" spam. A mental blind spot so to say. I had expected to see all settings in the settings menu.
    If you mean Support Us menu it's not spam. Since John stopped commenting here, his Twitter is the only real way to keep up with comments on Magisk progress, and official documents / files are all on his GitHub - OctoPuss (cat) icon - ! Other 2 are for contributions if you wish.

    But floating menu is different; Home, Shield (SuperUser / MagiskHide List), Bug (Logs), Puzzle piece (Modules) icons. 😉 PW
    2
    My problem is:
    SafetyNet failure and
    there is no hide menu where I can tell which apps should be prevented to check for rooted devices. There is just one switch to enable/disable the hide function.
    If SafetyNet fails with API error, that has been discussed in many posts the last days here, the cure is simple, install the latest Canary 22103 (or wait until it will be fixed in the upcoming new Stable relesse)

    Magisk Hide can be turned on or off in the Settings, but there is separately a tab where you can select for which package and process it has to be enabled.
    You can also use magiskhide command from terminal apps.
    See the screenshots and read from the Magisk guides available from Github
  • 12

    Latest Public (Stable / Beta)

    Release Notes and Changelog:


    2021.4.9 Magisk v22.1​

    This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.

    Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.

    Bug Fixes​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    🎉 👍 PW
    10
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/ea57c9b33b3a6ce2e0e65ce4c33dfb1c01552fcb/notes.md :

    Magisk (f49966d8) (22103)​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    Diffs to v22.1​

    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic
    👍 ...And things are all Rosy 'n Safe in the Custom Mod. world once again... but ironically, only on the bleeding edge... (Confirmed on my RN8T. 🙂 )

    News for those not wanting to get cut (Public Stable / Beta users) below. 😜

    Thanks John... And other collaborators for additional fixes! PW
    8
    @osm0sis
    Thank you for having an eye on that.
    Did the "ls" twice, first from a TWRP-terminal in recovery, second from a terminal while phone is "up and running".
    Looks like you have /dev/bootimg as your real partition location and it is still higher in the list in util_functions.sh like how I fixed it in the linked commit, so this is definitely a regression from some other recent change to Magisk.. sigh, I'll look into it. 🤔😕
    8
    Update snet.jar extension
    The existing API key was revoked for some reason.
    Release an updated extension jar with a new API key.

    In addition, add some offline signature verification and change how
    results are parsed to workaround some dumbass Xposed module "faking"
    success results, since many users really don't know better.

    @topjohnwu

    topjohnwu committed 19 minutes ago
    6

    Latest Canary Changelog, including Release Notes:​


    Magisk (9c0e1897) (22007)​

    • [General] Fix logic to copy sepolicy.rule during module installation
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.

    Diffs to v22.0​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlock
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    👍 PW
  • 1046
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    155
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    119
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    74
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone