Magisk General Support / Discussion

Search This thread

zgfg

Senior Member
Oct 10, 2016
5,109
2,414
i previously asked that too "why is magisk called systemless when it's capable corrupting system partition" but nobody answered me i guess it's one of those question like

Which Came First, the Chicken or the Egg?​

nobody know thou it's better left unanswered
I don't know what do you mean by 'corrupting' the system, but Magisk does not install (hence it does not affect and neither corrupt) the System, but to Boot partition (or in some cases Recovery or Randisk partitions)

Strictly speaking, those partitions are not System partition - whereas the term Systemless refers strictly to not making changes to the System partition itself

Hence if something goes wrong (bootlop or so), it was not due to Magisk affected or 'corrupted' the System partition - you could e.g. take a TWRP backup of the System (!) partition before and upon installing Magisk, and compare the back-ups
 
Last edited:
  • Like
Reactions: J.Michael

pndwal

Senior Member
Jun 23, 2016
2,199
1,399
Sydney
Xiaomi Redmi Note 7
Hello! New user here. So I've been trying to update to latest Magisk version and it seems like I have an issue updating it through the app. Here's what it looks like as of now.
View attachment 5276525
The app version is the same as latest, yet it gives me an update option. It also doesn't want to update Magisk itself. (log attached)
I use Xiaomi redmi note 7 (codename - lavender) with android 10 qkq.1.190910.002 with miui version 12.0.2.0(qfgruxm)

This is also my first time reporting a bug so if anything more is required please tell me what I need to provide.
As it's Xiaomi, you can most likely use Magisk in Boot despite ramdisk = no, as you likely know.

Can you confirm:

1) You just boot device normally (no special Recovery key combination needed to boot to system with root).

2) You click Update, Clear Recovery mode box (if it's not already), Click Next, select Direct Install, click Let's Go... Reboot.

👍 PW
 

xAutumn

New member
Apr 11, 2021
4
1
As it's Xiaomi, you can most likely use Magisk in Boot despite ramdisk = no, as you likely know.

Can you confirm:

1) You just boot device normally (no special Recovery key combination needed to boot to system with root).

2) You click Update, Clear Recovery mode box (if it's not already), Click Next, select Direct Install, click Let's Go... Reboot.

👍 PW
I can boot into device normally.
Did what you mentioned in 2, it didn't update, previously I've ticked recovery mode box.
 

Iron_Overheat

Senior Member
Apr 13, 2016
104
16
You could have attached the screenshot but per description, it looks ok.
E.g., I have Canary 22002 (not Stable 22000 like you), Magisk properly imstalled and all ok - compare to my screenshot

If I understand correctly, you reported a crash while installing a Magisk module

If installing from Repo, take Download (instead of Install), it will download to your Download folder.
Then, take from Magisk app (again Modules tab, at the top), Install from storage and navigate to the Download folder and the downloaded module zip file

I.e., there was recently a bug that Magisk app was crashing when installing a module but by e.g. installing an already downloaded module zip file it worked fine (since I'm on Canary 22002, I don't know how is the case with your Stable 22000)

There was also another workaround. When taking Install, once Magisk app crashed, it was just enough to tap to the notification that module was downloaded - Magisk app would continue installinf the module

If still failing/crashing, try with another Magisk module (from Repo!) to make sure it wasn't an errant module
Installing the zip from storage was something I already tried but for some reason Internal Storage is showing as empty in my system (can't even access through MTP, only sdcard...). Even accessing thru root file explorer, /storage/emulated/0/ is empty... But on the settings app, under storage, it shows "Internal shared storage 11.02 GB used of 64.00 GB"... I have no idea why, before installing LineageOS 18.1 I could access internal storage... I already asked on my ROM's thread about this issue but nobody answered...
 

zgfg

Senior Member
Oct 10, 2016
5,109
2,414
Installing the zip from storage was something I already tried but for some reason Internal Storage is showing as empty in my system (can't even access through MTP, only sdcard...). Even accessing thru root file explorer, /storage/emulated/0/ is empty... But on the settings app, under storage, it shows "Internal shared storage 11.02 GB used of 64.00 GB"... I have no idea why, before installing LineageOS 18.1 I could access internal storage... I already asked on my ROM's thread about this issue but nobody answered...
Do you properly see Internal storage from TWRP?
What about using a different file explorer, like MiXplorer (use the version for target SDK 29, NOT for target SDK 30)
 

op3tguy

New member
Apr 11, 2021
2
2
No log files attached!

You could try extracting original boot.img from ROM package, then flash this from TWRP or PC w/ fastboot commands. Should boot again.

Then flash new Magisk; If zip (TWRP) install still gives issues, try recommend patch image / fastboot flash method. PW
Okay, I'll try the boot.img first.
I'll try attaching the files again.
Hmmm, I attached and they appeared to upload but perhaps because this is my first post it won't "stick".
 
  • Like
Reactions: pndwal

pndwal

Senior Member
Jun 23, 2016
2,199
1,399
Sydney
Xiaomi Redmi Note 7
I can boot into device normally.
Did what you mentioned in 2, it didn't update, previously I've ticked recovery mode box.
... So, you probably now have Magisk in Recovery ramdisk also (unless Direct Install w/ Recovery mode checked failed to complete). I'm interested if you can boot with root this way:
Each device has its own key combo to boot into recovery... A quick Google search should easily get you this info of your device. As soon as you press the combo and the device vibrates with a splash screen, release all buttons to boot into Magisk. (If you decide to boot into actual recovery mode, continue to press volume up until you see the recovery screen.)

Booting any way, can you also Install CPU-Z from PlayStore, check System, Kernel Architecture. Is this 32 or 64 bit? 👍 PW
 
Last edited:

pndwal

Senior Member
Jun 23, 2016
2,199
1,399
Sydney
Xiaomi Redmi Note 7

J.Michael

Senior Member
Jan 20, 2018
600
367
In addition to special patching requirements etc, some Sammy devices are type III, as are devices from other OEMs, and Magisk cannot be installed in boot partition on many (most?) of these since that cannot host a working ramdisk due to OEM's bootloader implementation.

Magisk must be installed in recovery partition (it has working ramdisk), and Recovery mode is selected to ensure patching recovery.img is done properly (as boot partition ramdisk and recovery partition ramdisk configurations differ significantly).
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84818535

Incidentally, I think many are confusing Magisk Installed thru custom recovery (which ALWAYS results in Magisk in Boot) with Magisk in Recovery (something entirely different)! 😬 PW
What I was trying to say was, if you give Magisk an AP.tar file, Magisk knows it's handling a tar file, Magisk extracts the boot, recovery, and vbmeta images, and Magisk modifies those three. The checkbox "Recovery" on the Magisk screen does not seem to apply, because in that case Magisk will always put Magisk in the recovery.img -- it makes changes to the boot.img and vbmeta.img to deal with signature checks, but the "installation" of Magisk is in the recovery.img.
 

zgfg

Senior Member
Oct 10, 2016
5,109
2,414
@zgfg

Did you ever get any info on that (Russian?) patched Magisk-R for RN7 from here:
https://forum.xda-developers.com/t/install-magisk-on-android-11-r-100-functional.4162761/

It may help user above to know what issue is, but I don't want to recommend it as looks dubious...

I thought it may be related to R7A issues (apparent it's boot.img is 32 bit with a 'fake' 64 bit Ramdisk (placeholder)), but I doubt this after looking at specs... PW
No, but there was a similar (albeit different) Magisk zip fluctuating around for my Mi 9T, that turned out to be Magisk 20004 or something.
It was needed to patch the boot.img first by that (Magisk 20004), and then to re-patch by the latetest Magisk, otherwise it didn't work

However, it became obsolete when Magisk 21xxx was fixed

In the thread you mentioned the latest posts are from Dec 2020, hence I would assume that it similarly became obsolete when Magisk was fixed to properly patch boot images (for various Xiaomi phones)

However I don't know for that particular model and it's special CPU (maybe it's not Qualcomm like in the my Mi 9T but MTK or something - although, AFAIK, Magisk was also fixed for MTK chipsets around the beginning of 2021)

PS: I just checked on GSMArena, R7A has Qualcomm SDM439 Snapdragon 439 (not MTK)
 
Last edited:
  • Like
Reactions: pndwal

pndwal

Senior Member
Jun 23, 2016
2,199
1,399
Sydney
Xiaomi Redmi Note 7
No, but there was a similar (albeit different) Magisk zip fluctuating around for my Mi 9T, that turned out to be Magisk 20004 or something.
It was needed to patch the boot.img first by that (Magisk 20004), and then to re-patch by the latetest Magisk, otherwise it didn't work

However, it became obsolete when Magisk 21xxx was fixed

In the thread you mentioned the latest posts are from Dec 2020, hence I would assume that it similarly became obsolete when Magisk was fixed to properly patch boot images (for various Xiaomi phones)

However I don't know for that particular model and it's special CPU (maybe it's not Qualcomm like in the my Mi 9T but MTK or something - although, AFAIK, Magisk was also fixed for MTK chipsets around the beginning of 2021)

PS: I just checked on GSMArena, R7A has Qualcomm SDM439 Snapdragon 439 (not MTK)
Ta. Asked, since you asked about it in RN7 thread. User has RN7:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84820497
That's QCom 660. (R7A issue now seems unrelated as I said).

May be a new issue anyway, since user can't update from 22.0, but seems there's been something peculiar about that model...

@xAutumn, Suggest you Unroot completely (restore both clean boot / recovery (keep stock) images, uninstall modules and app), then try patching boot.img extracted from ROM using latest Magisk App and flashing this from PC (fastboot mode), and see if this fixes issue. This method is best practice for fresh install. PW
 

pndwal

Senior Member
Jun 23, 2016
2,199
1,399
Sydney
Xiaomi Redmi Note 7
... The checkbox "Recovery" on the Magisk screen does not seem to apply, because in that case Magisk will always put Magisk in the recovery.img -- it makes changes to the boot.img and vbmeta.img to deal with signature checks, but the "installation" of Magisk is in the recovery.img.
Are you sure? Because instructions in Samsung section are almost identical to general Patching Images section:
If your device does NOT have boot ramdisk, make sure “Recovery Mode” is checked in options.
In most cases it should already be automatically checked.
Ie. App will know to use Boot ramdisk protocol if unchecked (whether patching Magisk to discreet boot image (.img) or to boot image integrated in AP (.tar) firmware package), and Recovery ramdisk protocol if checked (whether patching Magisk to discreet recovery image (.img) or to recovery image integrated in AP (.tar) firmware package).

As I've mentioned, the two ramdisk types are different, and implemented differently (or only one type may be implemented) in bootloader. 🤠 PW
 
Last edited:

J.Michael

Senior Member
Jan 20, 2018
600
367
Are you sure? Because instructions in Samsung section are almost identical to general Patching Images section:

Ie. App will know to use Boot ramdisk protocol if unchecked (whether patching Magisk to discreet boot image (.img) or to boot image integrated in AP (.tar) firmware package), and Recovery ramdisk protocol if checked (whether patching Magisk to discreet recovery image (.img) or to recovery image integrated in AP (.tar) firmware package).

As I've mentioned, the two ramdisk types are different, and implemented differently (or only one type may be implemented) in bootloader. 🤠 PW
I can't be sure of anything -- I haven't looked at Magisk's code. I thought I had tried patching a tar file both with and without checking Recovery, and had seen no difference in the three modified images. I might be misremembering.

I thought Samsung was the only case of firmware being packaged as a tar file. I thought all Samsungs had to have Magisk installed in recovery. I think the people who got TWRP working on the SM-T290 and SM-T295 have succeeded by patching the boot image.
 

pndwal

Senior Member
Jun 23, 2016
2,199
1,399
Sydney
Xiaomi Redmi Note 7
I can't be sure of anything -- I haven't looked at Magisk's code. I thought I had tried patching a tar file both with and without checking Recovery, and had seen no difference in the three modified images. I might be misremembering.

I thought Samsung was the only case of firmware being packaged as a tar file. I thought all Samsungs had to have Magisk installed in recovery. I think the people who got TWRP working on the SM-T290 and SM-T295 have succeeded by patching the boot image.
Well, if flash in Custom Recovery is working, this confirms that Magisk in Boot works. It will necessarily work on the same device by patching .tar / flashing with Odin.

Patching Recovery can never be done from Custom Recovery and is only needed, for type III devices... It will usually work on others too...

But why would you?

To boot into System with Magisk root you HAVE to use key combination for Recovery, then, when the device vibrates with a splash screen, release all buttons EVERY TIME you boot device.

Nb. Unless you boot that way, root (if present) was actually installed as Magisk in Boot. 👍 PW
 

xAutumn

New member
Apr 11, 2021
4
1
... So, you probably now have Magisk in Recovery ramdisk also (unless Direct Install w/ Recovery mode checked failed to complete). I'm interested if you can boot with root this way:


Booting any way, can you also Install CPU-Z from PlayStore, check System, Kernel Architecture. Is this 32 or 64 bit? 👍 PW
I can boot into recovery mode holding power and volume up, no Idea how to boot into Magisk if thats what you mean. My architecture according to cpu-z js armv8l
 
  • Like
Reactions: pndwal

xAutumn

New member
Apr 11, 2021
4
1
Well, if flash in Custom Recovery is working, this confirms that Magisk in Boot works. It will necessarily work on the same device by patching .tar / flashing with Odin.

Patching Recovery can never be done from Custom Recovery and is only needed, for type III devices... It will usually work on others too...

But why would you?

To boot into System with Magisk root you HAVE to use key combination for Recovery, then, when the device vibrates with a splash screen, release all buttons EVERY TIME you boot device.

Nb. Unless you boot that way, root (if present) was actually installed as Magisk in Boot. 👍 PW
My phone boots with root every time with no need to use key combination for recovery, just a simple reboot and root is always enabled.
 

zputnyq

Senior Member
Apr 19, 2013
585
259
I have upgraded from 22002 to 22100. Everything is fine. But in 22.1 I have no possibility to choice canary version. The user based url https://raw.githubusercontent.com/topjohnwu/magisk_files/canary/debug.json doesn't work. Is there a special mm apk for 22.1?
I'm not sure about .json file since I never switching update from stable to canary or beta, I usually just clean install it if I switch. But if you can't download it from .json file you can grab it directly from github.
 
  • Like
Reactions: voroxda

pndwal

Senior Member
Jun 23, 2016
2,199
1,399
Sydney
Xiaomi Redmi Note 7
My phone boots with root every time with no need to use key combination for recovery, just a simple reboot and root is always enabled.
Yes, I'm aware you have Magisk in boot ramdisk. I think you did from the beginning of this discussion. But since you said you did direct update with Recovery mode checked, I was curious whether that succeeded.

If it did, you will have a SECOND iteration of Magisk in recovery ramdisk. Booting to system with root using THAT Installation is done via Recovery booting, ie. recovery combination buttons (since Recovery has been 'hijacked' as a means of booting to System w/ root).

Whether you get recovery, or system w/ root, depends on when you RELEASE the recovery combination buttons, as noted above, and in John's official Installation Instruction page. PW
 
Last edited:

pndwal

Senior Member
Jun 23, 2016
2,199
1,399
Sydney
Xiaomi Redmi Note 7
I have upgraded from 22002 to 22100. Everything is fine. But in 22.1 I have no possibility to choice canary version. The user based url https://raw.githubusercontent.com/topjohnwu/magisk_files/canary/debug.json doesn't work. Is there a special mm apk for 22.1?
All later Magisk builds are a Stand Alone (no need for internet connection / json files to downgrade), single package solution, both debug (Canary) builds (from 21402):
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84354959
and public (Stable/Beta) from 22.0:
https://topjohnwu.github.io/Magisk/releases/22000.html

For older stable builds, unless Installing .zip package from custom recovery you'd need hosted address of corresponding raw json file pasted in 'Custom Channel'. Older Canary Jsons won't work this way without editing and re-hosting as they always point to (common) address for LATEST Canary build rather than unique address.

But you can forget all that! 😆

All you need to do is click on Magisk Canary, under Downloads on Magisk main page on GitHub, and .apk will download! Just Install it.

FYI Canary builds, being 'bleeding edge' builds for debug purposes, are not considered Public builds, so Canary Channel won't appear in Magisk App (Settings) from Beta / Stable Public Releases. Debug builds contain all channels. 🤠 PW
 
Last edited:
  • Like
Reactions: dcarvil and zputnyq

Top Liked Posts

  • 1
    Full stock rom of a.61 is not available on the internet rn.
    Also there is no twrp for realme c3 atm iirc. So I can't flash any zips.
    1
    Full stock rom of a.61 is not available on the internet rn.
    Also there is no twrp for realme c3 atm iirc. So I can't flash any zips.
    Hi.
    I am not familiar with Realme.

    I did a quick check and see there is TWRP build over in the Realme C3 forums.
    [RECOVERY][TWRP][RMX2020] TWRP 3.5.2 [UNOFFICIAL] - xdaThread - Link
    Looks like it has only been out for a month and I am the only one who hit the like button so far. ;)

    Quite a few custom rom threads but, I did not see a thread for Stock rom / firmware.
    Realme C3 - xdaForum - Link

    Hope this is the correct TWRP for your device.
    Cheers. :cowboy:

    Edit:
    @SaikiK
    I see, you device might have rollback protection.
    To be safe, you might want to ask in the C3 TWRP thread before you try it.
    1
    I use Termux. Sometimes I need a root shell, so I granted root permanently to Termux, so I can use 'sudo bash' in Termux. But, as there is no password prompt, this is actually a security flaw. So I wanted to revoke root access and grant root access only on demand, when I really need it.

    Revocation succeeded, but I can only grant root access permanently and not temporarily. The latter only happens when I grant root access to an app for the very first time.
    Can't reproduce. If I revoke superuser access for Termux and then run su I can pick "forever", "once" or one of the set time periods.
    1
    Where is the canary build?
    The latest Canary apk is always linked in the main Magisk GitHub repo:
    https://github.com/topjohnwu/Magisk
  • 11
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/ea57c9b33b3a6ce2e0e65ce4c33dfb1c01552fcb/notes.md :

    Magisk (f49966d8) (22103)​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    Diffs to v22.1​

    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic
    👍 ...And things are all Rosy 'n Safe in the Custom Mod. world once again... but ironically, only on the bleeding edge... (Confirmed on my RN8T. 🙂 )

    News for those not wanting to get cut (Public Stable / Beta users) below. 😜

    Thanks John... And other collaborators for additional fixes! PW
    9
    Update snet.jar extension
    The existing API key was revoked for some reason.
    Release an updated extension jar with a new API key.

    In addition, add some offline signature verification and change how
    results are parsed to workaround some dumbass Xposed module "faking"
    success results, since many users really don't know better.

    @topjohnwu

    topjohnwu committed 19 minutes ago
    9
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/56d4ca44e12927217ae761df0874e3cd7d05cea4/notes.md :

    Magisk (fb8000b5) (22104)​

    • [App] Hide annoying errors in logs when hidden as stub
    • [App] Update stub implementation
    • [App] Some internal code refactoring
    • [App] Update snet extension implementation

    Diffs to v22.1​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [App] Hide annoying errors in logs when hidden as stub
    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    May fix sundry issues with Magisk App! 👍 PW
    8
    Which logs are helpful when devices bootloops on splash screen?

    I read https://www.didgeridoohan.com/magisk/MagiskHelp but is last_kmsg need be taken after booting to Android after flashing stock boot.img?

    I have took and posted logs by booting to TWRP. Is that a correct way?


    Thanks
    The kmsg (Kernel Message) file is constantly written to while booted into an Android environment.
    System or Recovery.

    A new kmsg file is created every time you boot the device into an Android environment.
    The previous kmsg file is moved to last_kmsg

    Both files are replaced each time you (re)boot into an Android environment.

    Example.

    You boot into system and get stuck at the splash screen.
    Your device is currently writing to /proc/kmsg

    You force a reboot into recovery.
    The previous /proc/kmsg was moved to /proc/last_kmsg
    Your device is currently writing to /proc/kmsg

    /proc/kmsg is now the current recovery boot
    Your previous boot into system is now /proc/last_kmsg

    If you now reboot from recovery into recovery again.
    The previous /proc/kmsg is moved to /proc/last_kmsg
    Your device is currently writing to /proc/kmsg file.​

    /proc/kmsg is now the current recovery boot
    Your previous boot into recovery is now /proc/last_kmsg


    Note:
    • Newer devices use /sys/fs/pstore instead of /proc/last_kmsg
    • You normally need heightened privileges (root) to grab kmsg or pstore.
      A custom recovery normally allows you root access.

    Hope it helps more than confuse. 🙃

    Cheers. :cowboy:
    8
    Strange how people think they don't need to read the other posts but expect that their questions should be addressed and answered😌
  • 1047
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    Donate Magisk 1N9fG13ccZFpaPqV167f24Fjpp1R588BVR BTC to mantain it alive.
    155
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    119
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    74
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone