Magisk General Support / Discussion

Search This thread

Tanvir Rezwan

Member
Apr 15, 2021
8
4
Thank you
This fix may help with your issue, and is already merged in Canary release:
- [MagiskPolicy] Remove unnecessary sepolicy rules

Fix for this is merged too:
- [App] Update snet extension. This fixes SafetyNet API errors.
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84846949

If you don't wish to switch to debug (Canary) release, next public (Stable / Beta) release will include fixes, and may be imminent.
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84847033 PW
Thank you
But in first when i started using magisk myb v22, in option there was canary beta stable.
But now only have beta
Is there any link to download canary apk in my sony xz premium?
 

pndwal

Senior Member
Jun 23, 2016
2,203
1,412
Sydney
Xiaomi Redmi Note 7
  • Like
Reactions: Homeboy76
Re: Linking to the Source of the Changelogs

I have taken time to respond to your opinion at least twice now, CLEARLY EXPLAINING my reasoning...

Bad reasons.

If one goes to a page to copy a changelog then how difficult is it to also copy the URL?

Sorry but lack of attribution and/or link to source is a pet peeve of mine.
***

BTW are those huge headings really necessary? And they get quoted in the right column in a PC browser if Liked as seen in the attachment.

Maybe just simply bolding them would be enough. For example:

Latest Debug (Canary)​

Changelog and Release Notes:​

Magisk (f49966d8) (22103)​


For example:

FYI from https://github.com/topjohnwu/magisk-files/tree/canary > notes.md @ the present:

Latest Debug (Canary)
Changelog and Release Notes:

Magisk (f49966d8) (22103)


***

This link goes to a page that besides giving the user a chance to explore de source includes a download link.

And if there is a new Canary release, that page is automatically updated.

Win-win-win. ;)
***
 

Attachments

  • pndwal_Top_Liked.jpg
    pndwal_Top_Liked.jpg
    47.7 KB · Views: 40
Last edited:
  • Like
Reactions: DiamondJohn

pndwal

Senior Member
Jun 23, 2016
2,203
1,412
Sydney
Xiaomi Redmi Note 7
  • Like
Reactions: Tanvir Rezwan

midgo12

Senior Member
May 30, 2017
89
12
Flashed this...

Latest De Bug Canary

Changelog and Release Notes:

Magisk (f49966d8) (22103)


Still have the API error,,,
Oneplus 7pro on OOS10.3.8...
 

pndwal

Senior Member
Jun 23, 2016
2,203
1,412
Sydney
Xiaomi Redmi Note 7
Re: Linking to the Source of the Changelogs

Bad reasons.

If one goes to a page to copy a changelog then how difficult is it to also copy the URL?

Sorry but lack of attribution and/or link to source is a pet peeve of mine.
***
At least you acknowledged my response for once... but not sure you understood / read it carefully.

I go to generic Canary notes.md page, with non-static link (read 'if I cite that URL and anyone checks it after future Canary releases, it will NOT show the relevant release notes').

I could go through a few more steps to reach the static (unique) URL each time and get link, but really feel it's more useful for users to appraise themselves of / use the links for John's current files / info.
BTW are those huge headings really necessary?
More pet peeves? I'm trying to help people with Magisk! 😮

I haven't altered the fonts copied from https://github.com/topjohnwu/magisk-files/blob/canary/notes.md at all, and when I type, heading lines at top match pasted text.

Besides, I like John's formatting, otherwise I'd 'paste as plain text'!
And they get quoted in the right column in a PC browser if Liked.
Wouldn't know; I do all this from a mobile, often from a rooftop in the bright Sydney sun... Copy, paste, add a description and boom... It's up, looks good, and party time for Canary users watching!
Maybe just simply bolding them would be enough. For example:

For example:

FYI from https://github.com/topjohnwu/magisk-files/tree/canary > notes.md @ the present:

Latest Debug (Canary)
Changelog and Release Notes:

Magisk (f49966d8) (22103)
Just checked, and can't bold with John's Heading text formatting... Guess I could change text type to normal, then reduce and bold it...

Man you want me to work hard...
That link besides giving the user a chance to explore de source includes a download link in that page.

And if there is a new Canary release, that page is automatically updated.

Win-win-win. ;)
***
Nah, that's just messy... It'll still be confusing when citation links release notes for a completely different build...

Tell you what: I'll meet you half way (since you at least responded / discussed it this time):

I'll keep John's

Attention Grabbing​

headings, but I'll locate unique static URL and cite that for Canary / other GitHub documentation / files etc. in future. (Might have to come down from a roof.) 😛

Win-win? 🥳

Do I have to cite threads for John's current Twitter comments also? PW
 
Last edited:

pndwal

Senior Member
Jun 23, 2016
2,203
1,412
Sydney
Xiaomi Redmi Note 7
Flashed this...

Latest De Bug Canary

Changelog and Release Notes:

Magisk (f49966d8) (22103)


Still have the API error,,,
Oneplus 7pro on OOS10.3.8...
If Magisk App actually shows 'Installed f49966d8 (22103)' under Magisk (not just under App), both basicIntegrity and ctsProfile are failing, and SafetyNet is really NOT working (ie, showing 'FAIL' in external SafetyNet checking apps), you may actually have this known issue:
https://github.com/topjohnwu/Magisk/issues/4231

If otherwise, please give more information. PW

Edit: issue closed minutes ago. May go nowhere now.
 
Last edited:

duvuao

New member
Apr 16, 2021
1
0
Any ideas on why isn't the F-Droid distributed Magisk App 22.1 working?

It fails install with "Unable to extract files".

Environment:
- ASUS ZenFone Max Pro M2
- Android 10 (stock beta)
- Magisk App 22.1 (F-Droid)

Got it to work by downloading from Magisk itself and reinstalling the APK.
 

Attachments

  • magisk_install_log_2021-04-16T21:53:42Z.log
    104 bytes · Views: 8

midgo12

Senior Member
May 30, 2017
89
12
If Magisk App actually shows 'Installed f49966d8 (22103)' under Magisk (not just under App), both basicIntegrity and ctsProfile are failing, and SafetyNet is really NOT working (ie, showing 'FAIL' in external SafetyNet checking apps), you may actually have this known issue:
https://github.com/topjohnwu/Magisk/issues/4231

If otherwise, please give more information. PW

Edit: issue closed minutes ago. May go nowhere now.
Here are screen shots of the app with 22103 installed.

Magisk App.JPG


API Message.JPG


Any ideas...
 

pndwal

Senior Member
Jun 23, 2016
2,203
1,412
Sydney
Xiaomi Redmi Note 7
Here are screen shots of the app with 22103 installed.

View attachment 5281749

View attachment 5281751

Any ideas...
Just to be clear (as mentioned already), seems while you have flashed Magisk 22103, you haven't updated Magisk App.

As per Changelog, snet extension update is an App fix, as opposed to a fix in the Magic Mask itself.
[App] Update snet extension. This fixes SafetyNet API errors.

As a general rule, App should be the same version or newer than Magisk itself to maintain compatibility.

Recommended Patching / Fastboot flashing Image, and Direct Install methods ensure this, but legacy Custom Recovery zip Installation requires attention to this detail.

If a Magisk App is installed before flashing zip, it's probably best to check it is up to date / updated first from .apk package. Otherwise, as official Istallation Instruction page says:
- Flash the zip....
- Check whether the Magisk app is installed. If it isn’t installed automatically, manually install the APK.
👍 PW
 

martyfender

Senior Member
Mar 9, 2017
3,154
1,670
Indianapolis, IN
Any ideas on why isn't the F-Droid distributed Magisk App 22.1 working?

It fails install with "Unable to extract files".

Environment:
- ASUS ZenFone Max Pro M2
- Android 10 (stock beta)
- Magisk App 22.1 (F-Droid)

Got it to work by downloading from Magisk itself and reinstalling the APK.

If i'm not mistaken, F-Droid is not an official source for Magisk.

https://github.com/topjohnwu/Magisk/releases/tag/v22.1

Packages built by F-Droid are signed by F-Droid, so all apps in the official F-Droid repo are signed by F-Droid keys. F-Droid will generate a new key for each app that is included. All of the different APKs built from different versions of an app will be signed by the same app key. But do note: if an app is also distributed in an APK signed by the developer, like in the Google Play Store, then the F-Droid APK will have a different signature.
 
Last edited:

loshabih

Senior Member
Jul 2, 2012
72
9
I've strange thing here with app root detection , below steps i followed :
1- TWRP factory reset
2- wipe data and storage in twrp (where you type yes)
3- install this app https://play.google.com/store/apps/details?id=ae.damanhealth.daman&hl=en&gl=US
4- app works fine
5- install magisk app
6- app detect root despite i didn't flash magisk.zip
7- remove magisk app and the app started to work again.
8- i flashed magisk.zip
9- app didn't work and it detect root
10- I tried to hide it from magisk hide, change magisk app name

still this app detect root, i don't know if the app detect root from boot partition or from where
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
Jun 23, 2016
2,203
1,412
Sydney
Xiaomi Redmi Note 7
I've strange thing here with app root detection , below steps i followed :
1- TWRP factory reset
2- wipe data and storage in twrp (where you type yes)
3- install this app https://play.google.com/store/apps/details?id=ae.damanhealth.daman&hl=en&gl=US
4- app works fine
5- install magisk app
6- app detect root despite i didn't flash magisk.zip
7- remove magisk app and the app started to work again.
8- i flashed magisk.zip
9- app didn't work and it detect root
10- I tried to hide it from magisk hide, change magisk app name

still this app detect root, i don't know if the app detect root from boot partition or from where
Please try this:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84743225

Much more here also:
https://www.didgeridoohan.com/magisk/MagiskHideHidingRoot 🤠 PW
 

midgo12

Senior Member
May 30, 2017
89
12
Just to be clear (as mentioned already), seems while you have flashed Magisk 22103, you haven't updated Magisk App.
Thanks for this info.
I have uninstalled the old app and reflashed Magisk 22103 again and the safety net API has now passed.
Screenshot_20210418-065052.jpg


Screenshot_20210418-065044.jpg

Thanks again for the help given...
 
  • Like
Reactions: pndwal
Sep 1, 2019
8
7
I have a OnePlus 7t pro McLaren (T-Mobile HD1925). I am using newest magisk app 22.1 to patch my boot.img pulled using dd. I am having a hard time finding the usual checkbox for preserve dm-verity. Can someone tell me if this feature has been removed or is for some reason not available on my device. I really want to be able to just modify my device as much as i want without a "soft brick" into fastboot mode. There is no working TWRP for the device. Is it possible to make a magisk module that overlays an entire "systemless" system image that i can run and edit at free will without tripping some sort of verity that causes a Boot loop?


just to clarify... Device is fully rooted with magisk. Issue is.. I cant hardly do anything with root! Everything that i used to do in older versions of Android , if you do those cool types of tricks and mods now you get a bootloop! Everything has to be done as a magisk module. How do i make my device less secure lol.
 
Last edited:

Top Liked Posts

  • 5
    @pndwal

    I haz made my first Magisk related issue, lets see how quickly it gets closed :) :)

    Born out of testing 4 ROMS this week is this "issue" was driving me nuts

    https://github.com/topjohnwu/Magisk/issues/4333

    Its not entirely out of bone idle laziness, but having to switch back after each module install was starting to get on my nerves :)

    I dont hover around github enough to know if its been mentioned before
    Was about to say I think It'll be considered, but see it's more than that already. 👍

    Re. idle laziness, I agree with John that Open Source is great!
    John Wu, ?

    I love the fact that despite being lazy, haven't worked on Magisk for almost a week, quite a few people start creating PRs to fix some regressions, burning down a lot of issues

    Gotta say,
    Open source sure is quite a nice thing! Maybe I should be lazy more often in the future /jk 😛
    Could be no coincidence that Chris is on it though; what's with you compulsive testers / gluttons for punishment? 😜 PW

    https://qablog.practitest.com/should-all-testers-have-ocd/ PW
    3
    <SNIP>
    Could be no coincidence that Chris is on it though; what's with you compulsive testers / gluttons for punishment? 😜 PW

    https://qablog.practitest.com/should-all-testers-have-ocd/ PW
    It is just good testing. ;)
    Does it work.
    • No - Try to fix it.
    • Yes - Find a way to break it.

    The next step is figuring out why it doesn't work on one device when it works on the rest.
    This is the difficult step.

    Cheers. :cowboy:
    3
    Latest Debug (Canary)
    Changelog and Release Notes:

    Magisk (6b34ec3a) (22105)​

    • [MagiskHide] Some changes that prevents zygote deadlock
    • [General] Update BusyBox to use proper libc
    • [App] Fix issues when patching ODIN tar files when the app is hidden

    Diffs to v22.1​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [App] Hide annoying errors in logs when hidden as stub
    • [App] Fix issues when patching ODIN tar files when the app is hidden
    • [General] Remove all pre Android 5.0 support
    • [General] Update BusyBox to use proper libc
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic
    • [MagiskHide] Some changes that prevents zygote deadlock
    https://github.com/topjohnwu/magisk-files/tree/9d8ae9c501f3975a9a548a5d2dff440d9ce9b8a2

    Don't you just love Mondays!

    Flashed fine on RN8T, SafetyNet, modules fine incl. Viper!

    Nb. Fix for image patching on Samsung devices.

    Thanks to John and colaborators! 👍 PW
    2
    It is just good testing. ;)
    Does it work.
    • No - Try to fix it.
    • Yes - Find a way to break it.

    The next step is figuring out why it doesn't work on one device when it works on the rest.
    This is the difficult step.

    Cheers. :cowboy:
    Quite.

    I had my tongue firmly in my cheek when I said that, but fully appreciate testing efforts / methods / benefits to all of us, yours included!

    FWIW, I don't think it's bone idleness or lazy to work for an easier testing setup either. After all, John happily accepted @vvb2060's Auto close issues bot. 😬

    ... But then, he IS lazy... Said so himself! 😜

    Incidentally, I hope I speak for most of us here in saying that we do this largely to entertain ourselves (for fun). Of course, offering help to one another and educating ourselves is the main aim, but I hope we can have a bit of fun in these forums from time to time without being taken too seriously...

    I make this comment after just having had a post w/ link to Monty Python's original 'I don't like Spam' sketch (along with others that inspired Python programming code) removed from 'Spam Users' thread. This, to me, is a real irony. 🙃 PW
    2
    Ignore this post.
  • 11
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/ea57c9b33b3a6ce2e0e65ce4c33dfb1c01552fcb/notes.md :

    Magisk (f49966d8) (22103)​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    Diffs to v22.1​

    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic
    👍 ...And things are all Rosy 'n Safe in the Custom Mod. world once again... but ironically, only on the bleeding edge... (Confirmed on my RN8T. 🙂 )

    News for those not wanting to get cut (Public Stable / Beta users) below. 😜

    Thanks John... And other collaborators for additional fixes! PW
    9
    Update snet.jar extension
    The existing API key was revoked for some reason.
    Release an updated extension jar with a new API key.

    In addition, add some offline signature verification and change how
    results are parsed to workaround some dumbass Xposed module "faking"
    success results, since many users really don't know better.

    @topjohnwu

    topjohnwu committed 19 minutes ago
    9
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/56d4ca44e12927217ae761df0874e3cd7d05cea4/notes.md :

    Magisk (fb8000b5) (22104)​

    • [App] Hide annoying errors in logs when hidden as stub
    • [App] Update stub implementation
    • [App] Some internal code refactoring
    • [App] Update snet extension implementation

    Diffs to v22.1​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [App] Hide annoying errors in logs when hidden as stub
    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    May fix sundry issues with Magisk App! 👍 PW
    8
    Strange how people think they don't need to read the other posts but expect that their questions should be addressed and answered😌
    8
    Which logs are helpful when devices bootloops on splash screen?

    I read https://www.didgeridoohan.com/magisk/MagiskHelp but is last_kmsg need be taken after booting to Android after flashing stock boot.img?

    I have took and posted logs by booting to TWRP. Is that a correct way?


    Thanks
    The kmsg (Kernel Message) file is constantly written to while booted into an Android environment.
    System or Recovery.

    A new kmsg file is created every time you boot the device into an Android environment.
    The previous kmsg file is moved to last_kmsg

    Both files are replaced each time you (re)boot into an Android environment.

    Example.

    You boot into system and get stuck at the splash screen.
    Your device is currently writing to /proc/kmsg

    You force a reboot into recovery.
    The previous /proc/kmsg was moved to /proc/last_kmsg
    Your device is currently writing to /proc/kmsg

    /proc/kmsg is now the current recovery boot
    Your previous boot into system is now /proc/last_kmsg

    If you now reboot from recovery into recovery again.
    The previous /proc/kmsg is moved to /proc/last_kmsg
    Your device is currently writing to /proc/kmsg file.​

    /proc/kmsg is now the current recovery boot
    Your previous boot into recovery is now /proc/last_kmsg


    Note:
    • Newer devices use /sys/fs/pstore instead of /proc/last_kmsg
    • You normally need heightened privileges (root) to grab kmsg or pstore.
      A custom recovery normally allows you root access.

    Hope it helps more than confuse. 🙃

    Cheers. :cowboy:
  • 1047
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    Donate Magisk 1N9fG13ccZFpaPqV167f24Fjpp1R588BVR BTC to mantain it alive.
    155
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    119
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    74
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone