Magisk General Support / Discussion

Search This thread

BillGoss

Senior Member
Sep 2, 2010
4,534
3,926
Sydney
OnePlus 3T
OnePlus 8T
I have a OnePlus 7t pro McLaren (T-Mobile HD1925). I am using newest magisk app 22.1 to patch my boot.img pulled using dd. I am having a hard time finding the usual checkbox for preserve dm-verity. Can someone tell me if this feature has been removed or is for some reason not available on my device. I really want to be able to just modify my device as much as i want without a "soft brick" into fastboot mode. There is no working TWRP for the device. Is it possible to make a magisk module that overlays an entire "systemless" system image that i can run and edit at free will without tripping some sort of verity that causes a Boot loop?


just to clarify... Device is fully rooted with magisk. Issue is.. I cant hardly do anything with root! Everything that i used to do in older versions of Android , if you do those cool types of tricks and mods now you get a bootloop! Everything has to be done as a magisk module. How do i make my device less secure lol.
Maybe it's time to bite the bullet and learn about Magisk modules and make your own - it's not that difficult. See https://topjohnwu.github.io/Magisk/guides.html
 
  • Like
Reactions: pndwal

J.Michael

Senior Member
Jan 20, 2018
597
366
I have a OnePlus 7t pro McLaren (T-Mobile HD1925). I am using newest magisk app 22.1 to patch my boot.img pulled using dd. I am having a hard time finding the usual checkbox for preserve dm-verity. Can someone tell me if this feature has been removed or is for some reason not available on my device. I really want to be able to just modify my device as much as i want without a "soft brick" into fastboot mode. There is no working TWRP for the device. Is it possible to make a magisk module that overlays an entire "systemless" system image that i can run and edit at free will without tripping some sort of verity that causes a Boot loop?


just to clarify... Device is fully rooted with magisk. Issue is.. I cant hardly do anything with root! Everything that i used to do in older versions of Android , if you do those cool types of tricks and mods now you get a bootloop! Everything has to be done as a magisk module. How do i make my device less secure lol.
How are you pulling boot.img using dd? If you are rooted because you have installed Magisk into the boot image, you are pulling a copy of the patched boot image. I've read that it is safe to patch a patched image, but why? Why not use the image you patched when you originally installed Magisk?

If the things you want to do involve fiddling with files in /system, you only need as much module as a tree under /data/adb/modules. If you screw it up, you can boot to Safe Mode (an Android concept), then on the next boot Magisk will come up with all modules disabled, giving you a chance to fix your "module", or disable it more permanently.
 
  • Like
Reactions: pndwal

pndwal

Senior Member
Jun 23, 2016
2,198
1,397
Sydney
Xiaomi Redmi Note 7
I have a OnePlus 7t pro McLaren (T-Mobile HD1925). I am using newest magisk app 22.1 to patch my boot.img pulled using dd. I am having a hard time finding the usual checkbox for preserve dm-verity. Can someone tell me if this feature has been removed or is for some reason not available on my device.
Should still show on supported legacy devices:
John Wu, Aug 24, 2020

Magisk Manager will no longer show confusing/useless installation options to the user in the following cases:

• Keep forceencrypt on FBE: does not work
• Keep verity on SAR: dangerous/does not work
• Recovery mode on devices with ramdisk: not needed

Disabling force encryption and dm-verity is only relevant in the time of past. In the spirit of backwards compatibility, these options are still there on supported legacy devices. Devices with ramdisk installing with recovery mode enabled will simply go straight to bootloops 😂

In case removing the option to disable AVB 2.0 (for direct partition rw) on SAR is controversial: on legacy SAR, system is always rw-able, other partitions require patching DTB that could cause bootloops on some devices; for logical partitions it's ... well, "complicated".

The tools for stripping AVB flags in various places (fstab in ramdisk, DT in boot, DTB/DTBO partitions) are still there in magiskboot, so for advanced users/devs, all power to you! I just no longer want to allow normal root users to break their devices with options in the app.
www.twitter.com/topjohnwu/status/1297833910320021504

Commit: https://github.com/topjohnwu/Magisk/commit/e437ffdbae065b5a08456412a8e036c191a3903e

I really want to be able to just modify my device as much as i want without a "soft brick" into fastboot mode. There is no working TWRP for the device. Is it possible to make a magisk module that overlays an entire "systemless" system image that i can run and edit at free will without tripping some sort of verity that causes a Boot loop?
Interestingly, John HAS overlayed a stock system with an entire custom ROM as Proof of Concept for a projected Universal MultiROM (Magisk powered custom ROM)!

Unfortunately, this ambitious project ground to a halt due to lack of time. 🙁

The details (and potential) are very interesting however:
MultiROM - POC

I spend some time playing with the possibility of Universal MultiROM by only using Magisk.
Surprisingly, it is not that difficult at all! Here is a small POC video demonstrating my HTC 10 dual booting stock rom and CM 13.

No other dependency is required (e.g. modified TWRP recovery, kext kernel patch etc.). You only need Magisk injected into the boot image, and along with proper settings, by swapping out the boot image, you can load any rom systemless-ly.
What this means is that all Magisk supported device can enjoy MultiROM features! What a great news for flashaholics LOL.

NOTE! The process showed in this video in far from what it will be eventually. I will make the process nice and smooth 🙂
https://forum.xda-developers.com/t/magisk-the-magic-mask-for-android.3473445/post-69226527
Multirom? Updates?
I've spend my extremely limited free time to fix current Magisk issues, and so far (the latest commit on Github) it has improved a lot compared with the current v9 release.
I haven't really spend much time in the multirom feature, however I found an interesting open source project: DualBootPatcher.
It exists for quite a while, and it is very impressive just like the Multirom Tasssadar created. I haven't looked into how DualBootPatcher works, so I'm not sure if it is using similar tactics method that I switch between systems in a super simple way through Magisk.
https://forum.xda-developers.com/t/magisk-the-magic-mask-for-android.3473445/post-70155585
Magic Mount With No Limits
I'm glad to announce that starting from this update, Magic Mount can do ANYTHING! Thanks to the new mirror implementation and some workarounds in the algorithm, it can now handle adding files to /system root (and /vendor root if separate partition). Also thanks to the new MagiskHide, all mounting combinations can pass SafetyNet!

Magisk Powered Custom ROM: One Click to Custom ROM, Another Click You're Back to Stock
I am a member of an HTC custom ROM developer team - Team Venom, and without too much effort, The world's first Magisk Powered Custom ROM http://venomroms.com/worlds-first-100-percent-magisk-rom/ was born!
The advantage over traditional full packaged custom rom is that we ROM developers no longer need to port carrier features (Wi-Fi calling, VOLTE etc.) to our ROMs. Users can install Magisk on their stock devices, load the Custom ROM module, reboot and BOOM all done, along with 100% fully working carrier features. Also, it is just cool to load a custom ROM fully systemless, isn't it!
https://forum.xda-developers.com/t/magisk-the-magic-mask-for-android.3473445/post-70363391
And yes, that means I will postpone the long planned but never worked on Multi-ROM feature (I barely spent time on it after the POC video)
https://forum.xda-developers.com/t/magisk-the-magic-mask-for-android.3473445/post-70897029

just to clarify... Device is fully rooted with magisk. Issue is.. I cant hardly do anything with root! Everything that i used to do in older versions of Android , if you do those cool types of tricks and mods now you get a bootloop! Everything has to be done as a magisk module. How do i make my device less secure lol.
Systemless Solutions

Magic Mount is the way to do this systemlessly using Magisk. It's essentially what Magisk modules do to load:
https://topjohnwu.github.io/Magisk/details.html#magic-mount

Root Directory Overlay System:
https://topjohnwu.github.io/Magisk/guides.html#root-directory-overlay-system

Nb. Systemless options have advantages over solutions that alter system. Eg:

1) Ease of recovering from systemless mod failure causing boot issues. There are several methods to prevent these 'system overlays' from being applied, hence allowing system to boot normally.

2) Only Boot and/or Recovery partitions need restoring to take OTA updates (because actual system partition is unaltered). Also, as modules / Magisk settings are stored in /data partition, after flashing Magisk patched images again the mods / settings are restored.

Shared Blocks and other Difficulties with System read write

www.twitter.com/topjohnwu/status/1259039809361739776

Universally Mount System read write

Are you adventurous / maverick / a Power User? - If answer is 'no' to any of the above, I recommend you ignore the following, which may be fraught...

ONLY if 'yes', here you go:

Since most stock ROMs are locked to read only due to new Shared Blocks (incl. Super partition devices) implementation, it may be of interest to many 'Power Users' here that a mod has been developed that can 'Universally Mount System read write for Android 10+ ROM w/ SUPER or NO_SUPER'!

It does this by dumping existing super OR system / product / vendor partitions, extracting embedded read-only partitions, then flashing images back to device as read-write partition(s).

Description:
A script for all Android power users that wish to make their read-only Android 10+ system read-write-able again to remove bloatware and make more thorough customizations to their device.
https://forum.xda-developers.com/t/...unt-system-read-write-super-no_super.4247311/

See also John Wu's initial comments on EXT4_FEATURE_RO_COMPAT_SHARED_BLOCKS, ext4 dedup filesystems:
John Wu, Sep 6, 2019

Just confirmed that the inability to remount system (the directory "/" in system-as-root) to rw is something new in Android Q, NOT an issue with the new system-as-root approach Magisk is using in the canary builds. Will have to investigate further to find out how to deal with it.

John Wu, Sep 8, 2019

I found out that Android 10's system images are formatted with EXT4_FEATURE_RO_COMPAT_SHARED_BLOCKS. It will deduplicate blocks in the filesystem to reduce the image size. On my Pixel XL, the partition is physically not large enough to successfully run 'e2fsck -E unshare_blocks'.

As clearly stated in the name of the feature, that EXT4 shared blocks feature is RO (read-only). The inability to disable this feature due to lack of free space in the partition (at least on my Pixel XL) makes it literally impossible to ever mount the system partition as rw.

I guess Google's justification to format partitions with this feature enabled is the introduction of overlayfs to "simulate" a writable partition

RIP to any mods or root apps that modify system. On Android 10 it seems system is either formatted as RO or using logical partitions
www.twitter.com/topjohnwu/status/1170404631865778177 😏 PW
 
Last edited:

exillity

Member
Mar 27, 2016
40
6
UK
Hello!
How to revert back from canary version to the stable one? I just can't install stable version again: it says "app not installed" after I try to install the release version.
 

pndwal

Senior Member
Jun 23, 2016
2,198
1,397
Sydney
Xiaomi Redmi Note 7
Hello!
How to revert back from canary version to the stable one? I just can't install stable version again: it says "app not installed" after I try to install the release version.
Yup, most systems will refuse to load an app's apk package if a newer one is already installed.

Since latest stable Magisk App is actually a version DOWNGRADE, you'll likely simply need to uninstall newer (Canary) App first.

The Magisk-22.1(22100).apk package will be in your Download path (Magisk Settings), probably [storage]/Download Folder, from your first attempt. Tip: sorting by Modification time will bring it to the top of the list.

Nb. Settings / modules will survive this, as they are stored in /data/adb, but do check MagiskHide remains toggled on in settings before and after doing Direct Install Magisk downgrade.

Nb.2. Update Channel may be set to Beta by default in public release App.

In short, just uninstalling Canary App before installing Stable App should work. 🤠 PW
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
5,108
2,413
Hello!
How to revert back from canary version to the stable one? I just can't install stable version again: it says "app not installed" after I try to install the release version.
Uninstall Canary Magisk app, and install Stable.
Be aware, Safety Net will fail you in Stable with API error

This way you will only downgrade from Canary Magisk app 22103 to Stable 22100.
If you also want to downgrade Magisk, you will need to patch your stock boot/recovery img from the Stable Magisk app once you downgrade the Magisk app
 

lundakj

New member
Apr 18, 2021
1
0
Hi all,
I am little lost, may I please some advice? On my old, but managed Onelus3T magisk stop working. No visible reason. No update, or something. I am abble to run/update manager, but magisk and all childs not.
So I try to boot in recovery, and install/flash app file renamed to zip. (22.1). Install seems ok, but after reboot no change, magisk not working.
I also read new install guide, so I download latest FW for my phone, extract boot.img, and patch it. But flashing this is really mine last resort.
Any other way left to ty? Maybe unistall/install or something?
Someone with simmiliar problem?

Only manage is wornig from this 5 magisk icons:
df460f22-9a36-4e75-bd1f-e252009b260e.jpg


In manager seems magisk as N/A:
b1dbb12a-70be-452a-8168-c449132a7dc9.jpg
 

hackwerk

Senior Member
Jan 7, 2010
423
106
Amsterdam
As I wrote in another thread;
I have an A3 EU with stock unrooted V12.0.5.0.RFQEUXM (security update 5th of march 2021).

Magisk (22.0) patched img is making my phone not bootable.
It gets stuck in Recovery telling me something like "Can't load Andoid system. Your data might be corrupted." and to Retry (not working) or Factory Reset (never!).
Same happens when I myself patch the stock img with Magisk 22.1 and flash that to my phone (boot_a).


What is happening, and how can we fix this and use Magisk (22.1)?!

Any ideas why I cannot use Magisk anymore?! Is it the A/B stuff? I dont get that at all (switch or put it on the active (A) or?).
Used to use Magisk all the time without any problems...
 

zgfg

Senior Member
Oct 10, 2016
5,108
2,413
As I wrote in another thread;
I have an A3 EU with stock unrooted V12.0.5.0.RFQEUXM (security update 5th of march 2021).

Magisk (22.0) patched img is making my phone not bootable.
It gets stuck in Recovery telling me something like "Can't load Andoid system. Your data might be corrupted." and to Retry (not working) or Factory Reset (never!).
Same happens when I myself patch the stock img with Magisk 22.1 and flash that to my phone (boot_a).


What is happening, and how can we fix this and use Magisk (22.1)?!

Any ideas why I cannot use Magisk anymore?! Is it the A/B stuff? I dont get that at all (switch or put it on the active (A) or?).
Used to use Magisk all the time without any problems...
You can simply check is it A/B or not (btw, documented on Magisk Github):
getprop ro.build.ab_update

True means yes, otherwise no

Stock img - what do you mean, (stock) boot.img or recovery.img?
 
  • Like
Reactions: J.Michael

hackwerk

Senior Member
Jan 7, 2010
423
106
Amsterdam
You can simply check is it A/B or not (btw, documented on Magisk Github):
getprop ro.build.ab_update

True means yes, otherwise no

Stock img - what do you mean, (stock) boot.img or recovery.img?

It is A/B (my Mi A3) and I know that. I just dont understand it.
Active was A so I flashed it to A. Or do I have to do switches etc?
Yes boot img. I dont have or saw or used recovery.img for my phone.
 

hypern0va

Senior Member
Sep 18, 2014
358
135
Italy
Hello everyone, I just discovered a second app among those installed on my phone which are crashing if Magisk Hide is on for them, while they work perfectly ok when I turn it off. I don't remember this happening before the last update, is it a known issue?

The just discovered app is my main banking one - which gets mad when it detects root - so it's a pretty big problem for me atm. I'm on LOS 17.1 btw (Android 10).

Also I'm sorry if this has already been discussed, I'm on my phone and gave a quick look at the latest thread pages but found nothing. Thanks.
 

HippoMan

Senior Member
May 5, 2009
1,635
488
Hippoland
Hello everyone, I just discovered a second app among those installed on my phone which are crashing if Magisk Hide is on for them, while they work perfectly ok when I turn it off. I don't remember this happening before the last update, is it a known issue?

The just discovered app is my main banking one - which gets mad when it detects root - so it's a pretty big problem for me atm. I'm on LOS 17.1 btw (Android 10).

Also I'm sorry if this has already been discussed, I'm on my phone and gave a quick look at the latest thread pages but found nothing. Thanks.
What is your banking app? Some banks put extra checks into their apps which go beyond standard SafetyNet checking. If your bank has done that, it might be impossible for Magisk to hide root from the banking app.

The bank that I use, Chase, has this characteristic, and I cannot hide root from the Chase app. Some people have reported this with certain other banking apps, as well.
 
Last edited:

hypern0va

Senior Member
Sep 18, 2014
358
135
Italy
What is your banking app? Some banks put extra checks into their apps which go beyond standard SafetyNet checking. If your bank has done that, it might be impossible for Magisk to hide root from the banking app.

The bank that I use, Chase, has this characteristic, and I cannot hide root from the Chase app. Some people have reported this with certain other banking apps, as well.
It's definitely not the apps doing in-depth checks as the same apps (with the same app versions) did work before.

Anyway, I got some updates: interaction between Magisk and Webview Manager seems to be the problem. I installed the latter lately so this, and not the Magisk update, could be what introduced the change.

I noticed that both of the apps which are giving me problems produce logs before crashing reporting the lack of the Chromium Webview. In fact, I currently only have the Bromite Webview installed.

Anyway, I'd definitely not say that Magisk is completely innocent since disabling Magisk Hide make the apps work again, even in lack of the Chromium Webview.

I'll report on eventual updates for possible readers facing my same problem, in the meantime suggestions are well accepted.
 

CounterC

Senior Member
Oct 26, 2012
2,077
642
I got this error since the last version. Anyone has an idea?
 

Attachments

  • Screenshot_2021-04-19-08-08-44-866_com.topjohnwu.magisk.jpg
    Screenshot_2021-04-19-08-08-44-866_com.topjohnwu.magisk.jpg
    156.7 KB · Views: 26

HippoMan

Senior Member
May 5, 2009
1,635
488
Hippoland
Last edited:

CounterC

Senior Member
Oct 26, 2012
2,077
642
  • Like
Reactions: wfred and TKruzze

pndwal

Senior Member
Jun 23, 2016
2,198
1,397
Sydney
Xiaomi Redmi Note 7
Did you check Magisk target version (you can try also patching)?
Yep.

With 22100 App Installed and 22103 Magisk Installed, Direct Install successfuly flashes / boots to 22100 (downgrades).

Just confirmed same behaviour patching prepatched 22103 w/ 22100.

Log:
Device platform: arm64-v8a
- Installing: 22.1 (22100)
- Copying image to cache
- Unpacking boot image
- Checking ramdisk status
- Magisk patched boot image detected
- Patching ramdisk
- Repacking boot image
****************************
Output file is written to
/storage/emulated/0/Download/magisk_patched-22100_2gXYx.img
****************************
- All done!

While Magisk App downgrade requires un-installation of newer app before installing a previous version on many devices (this may well depend on OS configuration), a Magisk Mask downgrade to a previous version can be done (patched) over an image prepatched with a newer version without issues.

Whatever is shown for App Installed will be flashed as Magisk Mask since first single-package version, 21402.*

Further, it seems the only basic prerequisite for Direct Installation is having root. (Nb. Some have even been able to gain full root privileges with Bootloader locked using Direct Install to update, after first gaining partial / temporary root through an exploit!)

* Nb. Post stand-alone builds (21402+), the update Channel NO LONGER determines Magisk Mask to flash. This is now set by App version installed.

Update Channel now only affects the App version shown as Latest (more specifically, Latest for selected channel), ie. App version to be installed if App Install (or Update) is selected.

Nb. Since Update Channel for public builds is set to Beta by default (only occurs if App is freshly insalled, not updated) users will see Stable build updates (Beta Channel points to Stable builds except where Beta is a later version) AS WELL as Updates to new Beta builds UNLESS channel is changed from default. - I'm guessing that in this event, many public Stable build users WON'T REALISE that they are actually updating to a Beta build.

This may all seem confusing / counterintuitive, especially for long time Magisk users, and there may well be better ways of implementing the new single-package builds. However, it ain't broke, and all works fine as described above.

Understanding the new single-package setup will hopefully allay confusion. 😬 PW
 
  • Like
Reactions: Wolfcity and zgfg

Top Liked Posts

  • 1
    Hi, anyone in italy have problem with Credem home banking app? App found root (and close itself) even if magisk Is hidden root ti app and with anonymous package.

    I have twrp too, on oneplus nord

    Thanks
    Cleared data since?

    This, or something else here may help:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84936057 PW
    1
    Full stock rom of a.61 is not available on the internet rn.
    Also there is no twrp for realme c3 atm iirc. So I can't flash any zips.
    1
    Full stock rom of a.61 is not available on the internet rn.
    Also there is no twrp for realme c3 atm iirc. So I can't flash any zips.
    Hi.
    I am not familiar with Realme.

    I did a quick check and see there is TWRP build over in the Realme C3 forums.
    [RECOVERY][TWRP][RMX2020] TWRP 3.5.2 [UNOFFICIAL] - xdaThread - Link
    Looks like it has only been out for a month and I am the only one who hit the like button so far. ;)

    Quite a few custom rom threads but, I did not see a thread for Stock rom / firmware.
    Realme C3 - xdaForum - Link

    Hope this is the correct TWRP for your device.
    Cheers. :cowboy:

    Edit:
    @SaikiK
    I see, you device might have rollback protection.
    To be safe, you might want to ask in the C3 TWRP thread before you try it.
  • 12

    Latest Public (Stable / Beta)

    Release Notes and Changelog:


    2021.4.9 Magisk v22.1​

    This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.

    Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.

    Bug Fixes​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    🎉 👍 PW
    11
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/ea57c9b33b3a6ce2e0e65ce4c33dfb1c01552fcb/notes.md :

    Magisk (f49966d8) (22103)​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    Diffs to v22.1​

    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic
    👍 ...And things are all Rosy 'n Safe in the Custom Mod. world once again... but ironically, only on the bleeding edge... (Confirmed on my RN8T. 🙂 )

    News for those not wanting to get cut (Public Stable / Beta users) below. 😜

    Thanks John... And other collaborators for additional fixes! PW
    9
    Latest Debug (Canary)
    Changelog and Release Notes
    https://github.com/topjohnwu/magisk-files/blob/56d4ca44e12927217ae761df0874e3cd7d05cea4/notes.md :

    Magisk (fb8000b5) (22104)​

    • [App] Hide annoying errors in logs when hidden as stub
    • [App] Update stub implementation
    • [App] Some internal code refactoring
    • [App] Update snet extension implementation

    Diffs to v22.1​

    • [App] Update snet extension. This fixes SafetyNet API errors.
    • [App] Fix a bug in the stub app that causes APK installation to fail
    • [App] Hide annoying errors in logs when hidden as stub
    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    • [General] Fix a C++ bug that causes undefined behavior
    • [MagiskHide] Update package and process name validation logic

    May fix sundry issues with Magisk App! 👍 PW
    9
    Update snet.jar extension
    The existing API key was revoked for some reason.
    Release an updated extension jar with a new API key.

    In addition, add some offline signature verification and change how
    results are parsed to workaround some dumbass Xposed module "faking"
    success results, since many users really don't know better.

    @topjohnwu

    topjohnwu committed 19 minutes ago
    8
    Strange how people think they don't need to read the other posts but expect that their questions should be addressed and answered😌
  • 1047
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    Donate Magisk 1N9fG13ccZFpaPqV167f24Fjpp1R588BVR BTC to mantain it alive.
    155
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    119
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    74
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone