Magisk General Support / Discussion

Search This thread

wfred

Senior Member
Mar 15, 2014
113
30
Upstate, NY
Hello everyone, I just discovered a second app among those installed on my phone which are crashing if Magisk Hide is on for them, while they work perfectly ok when I turn it off. I don't remember this happening before the last update, is it a known issue?

The just discovered app is my main banking one - which gets mad when it detects root - so it's a pretty big problem for me atm. I'm on LOS 17.1 btw (Android 10).

Also I'm sorry if this has already been discussed, I'm on my phone and gave a quick look at the latest thread pages but found nothing. Thanks.
Just a suggestion.
Check USB & ADB debugging. I have two apps that need Magisk hide, but will still refuse to load of debugging is turned on

Never mind, I see you find the solution
 
Last edited:
  • Like
Reactions: hypern0va

alexandarpb

Member
Mar 8, 2016
43
7
I have a problem here.
Xiaomi Мi А3, still on andorid 10 ( V11.0.10.0.QFQEUXM).
Today I saw that I have an Magisk update. As before, direct installation, but instead of the usual, just black screen was displayed. 10 minutes later I tried to go back in some way, but it was not possible, I decided to clear it from the recent apps, I started again, but only the magisk logo appears and nothing else. I tried to install the recently updated application again, but there was no change. I'm a little scared to restart the phone, because doesn't want it to go into a bootloop or anything like that. I integrated the flash log, but it is literally empty. Should i delete the app data? What should I do? I still have root access.

Screenshot_20210422-142111.pngScreenshot_20210422-143909.png
 
Last edited:

J.Michael

Senior Member
Jan 20, 2018
631
405
I have a problem here.
Xiaomi Мi А3, still on andorid 10 ( V11.0.10.0.QFQEUXM).
Today I saw that I have an Magisk update. As before, direct installation, but instead of the usual, just black screen was displayed. 10 minutes later I tried to go back in some way, but it was not possible, I decided to clear it from the recent apps, I started again, but only the magisk logo appears and nothing else. I tried to install the recently updated application again, but there was no change. I'm a little scared to restart the phone, because doesn't want it to go into a bootloop or anything like that. I integrated the flash log, but it is literally empty. Should i delete the app data? What should I do? I still have root access.

View attachment 5287153View attachment 5287155
Did you have Magisk app hidden / renamed?
You should unhide / unrename.
Check app drawer for multiple copies / versions of Magisk Manager app. Uninstall every copy.
 

lhooipg

Senior Member
Dec 14, 2011
511
61
May I know is anyone able to help me to create a zip file for my patch.boot.img file as my phone does not support adb or fastboot to flash it? I tried TWRP or Flashify app not working.

If yes, please PM me and will send the patch.boot.img file...tqvm in advance.
 

hachamacha

Senior Member
Jun 15, 2010
1,355
746
May I know is anyone able to help me to create a zip file for my patch.boot.img file as my phone does not support adb or fastboot to flash it? I tried TWRP or Flashify app not working.

If yes, please PM me and will send the patch.boot.img file...tqvm in advance.
Not enough info, but I just made one that's working on my global op7t but made it from the international global 11.0.0.2 payload dumper from lastest Magisk. So that's op7t 1903 and was from the complete source for Global International. What's your model and other versions I mentioned?
magisk: v22104
OS: 11.0.0.2
Flavor: HD1903 or 7
 
  • Like
Reactions: J.Michael

zgfg

Senior Member
  • Oct 10, 2016
    5,155
    2,451
    May I know is anyone able to help me to create a zip file for my patch.boot.img file as my phone does not support adb or fastboot to flash it? I tried TWRP or Flashify app not working.

    If yes, please PM me and will send the patch.boot.img file...tqvm in advance.
    There is no magic in the zip file for TWRP. It will contain your patched img and a command for TWRP to flash to the Boot partition. The same you (supposidely) are doing manually.
    If it fails manually, it will also fail from the zip

    What exactly are you trying in TWRP, and what/how it fails?
    Take screenshots in TWRP by simultaneously pressing Vol- and Pow buttons
     
    • Like
    Reactions: J.Michael

    lhooipg

    Senior Member
    Dec 14, 2011
    511
    61
    Not enough info, but I just made one that's working on my global op7t but made it from the international global 11.0.0.2 payload dumper from lastest Magisk. So that's op7t 1903 and was from the complete source for Global International. What's your model and other versions I mentioned?
    magisk: v22104
    OS: 11.0.0.2
    Flavor: HD1903 or 7
    Sorry I am not a tech savvy. May I know model you are referring is handset? If yes I am using SM-N910C (Note 4). Version wise is 6.0.1
    Magisk: fb8000b5(22104)
     

    lhooipg

    Senior Member
    Dec 14, 2011
    511
    61
    There is no magic in the zip file for TWRP. It will contain your patched img and a command for TWRP to flash to the Boot partition. The same you (supposidely) are doing manually.
    If it fails manually, it will also fail from the zip

    What exactly are you trying in TWRP, and what/how it fails?
    Take screenshots in TWRP by simultaneously pressing Vol- and Pow buttons
    I boot into TWRP & select img instead of zip to flash
     

    J.Michael

    Senior Member
    Jan 20, 2018
    631
    405
    Sorry I am not a tech savvy. May I know model you are referring is handset? If yes I am using SM-N910C (Note 4). Version wise is 6.0.1
    Magisk: fb8000b5(22104)
    If your device is a Samsung, you probably need to use Odin. Except you talk like you have TWRP.

    How did you put TWRP on your device?

    You would probably do better in a forum specific to your device.
     
    • Like
    Reactions: pndwal

    zgfg

    Senior Member
  • Oct 10, 2016
    5,155
    2,451
    I boot into TWRP & select img instead of zip to flash
    Ok, does it ask you and do you choose Boot partition for the image to be flashed there?
    And how it fails?
    Again, make screenshots in TWRP and attach here

    EDIT:
    If you are using Samsung, then please carefully read Magisk guide on Github - AFAIK (but I have no Sammy and cannot guide you), you should be using ODIN and the tar img, not the boot.img, not TWRP, etc

    Search also on XDA for your phone model, there should be a section Guides and Q/A and check or ask there how the other users install Magisk to the same phone
     
    Last edited:
    • Like
    Reactions: J.Michael

    pndwal

    Senior Member
    Jun 23, 2016
    2,243
    1,477
    Sydney
    Xiaomi Redmi Note 7
    Went to Canary to solve the API issue.
    App shows I'm running 22104 and that I'm on the Stable update channel.
    Will Magisk just install the stable when the next stable update is released?
    Unless you change channel!

    Update Channel now only affects the App version shown as Latest (more specifically, Latest for selected channel), ie. App version to be installed if App Install (or Update) is selected.

    Whatever is shown for App Installed will be flashed as Magisk Mask since first single-package version, 21402.

    Nb. Post stand-alone builds (21402+), the update Channel NO LONGER determines Magisk Mask to flash. This is now set by App version installed.

    Full explanation:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84863037 🤠 PW
     
    • Like
    Reactions: J.Michael

    wfred

    Senior Member
    Mar 15, 2014
    113
    30
    Upstate, NY
    Unless you change channel!

    Update Channel now only affects the App version shown as Latest (more specifically, Latest for selected channel), ie. App version to be installed if App Install (or Update) is selected.

    Whatever is shown for App Installed will be flashed as Magisk Mask since first single-package version, 21402.

    Nb. Post stand-alone builds (21402+), the update Channel NO LONGER determines Magisk Mask to flash. This is now set by App version installed.

    Full explanation:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84863037 🤠 PW
    Now I'm more confused
    The app is set to the stable update channel. Will I auto update to the next stable or the next canary?
    Screenshot_20210422-170306.jpg
     

    zgfg

    Senior Member
  • Oct 10, 2016
    5,155
    2,451
    Now I'm more confused
    The app is set to the stable update channel. Will I auto update to the next stable or the next canary?
    View attachment 5287523
    I've answered you earlier today what will happen when Stable will be released with the build number 22200, higher than your installed Canary 22104

    Magisk app will offer you to install/update to 22200 and after that you will also smoothly update the Magisk itself to 22200 (Stable)

    Higher number will rule.
    And next Stable will not be 22101 or anything lower than your installed 22104 (Canary)

    And since you already put the Channel to Stable, further Canary updates will not bother you. At the time when TJW relesses his next Stable it will for sure be higher number than all previous Canaries and Betas - this is the procedure going on at least for the last two years
     
    Last edited:
    • Like
    Reactions: J.Michael and wfred

    drewcu

    Senior Member
    Jan 31, 2012
    288
    101
    Have LSposed and upgraded to Magisk Canary 22104 due to the Safetynet API changes, and all of a sudden Safetynet FAILS (have tried multiple times).

    Anyone else in a similar situation?

    Was on Canary 22103 also with LSposed and SN passed just like on 22.1 before the API change.

    Without LSposed enabled, Magisk 22104 passes SN so anything I can do to get LSposed not to be detected by Safetynet?
     

    pndwal

    Senior Member
    Jun 23, 2016
    2,243
    1,477
    Sydney
    Xiaomi Redmi Note 7
    Now I'm more confused
    The app is set to the stable update channel. Will I auto update to the next stable or the next canary?
    Not sure what you mean by auto update... I don't think you can!

    Channel determines only App to be installed and App listed as Latest (ie. Latest for THAT CHANNEL, not necessarily latest Magisk build).

    App Update will only appear when a later build is available for channel set (ie. You WON'T see Canary updates is Stable is set).

    App Installed ALONE determines what will be flashed as Magisk Mask.

    Magisk [the actual 'mask'] Update will only appear when the Installed version is OLDER than the binary contained in the installed APP. (Again, this is NO LONGER affected by the channel set, or by any newer App shown as latest.)

    Things were quite different before first single-package version, 21402.

    Nb. If you click Magisk Install NOW, with things as per screenshot, you will be prompted to re-install current 22104, since that is current app installed, and this now (since 21402) contains the Magisk Mask binary.

    Nb.2. Since single-package builds were introduced, you can upgrade OR downgrade easily by observing these rules.

    To downgrade App however, you will probably need to uninstall the previous app to avoid 'app not installed' error. The app will be found in Download path folder set in Magisk Settings from previous unsuccessful attempt.

    Hope it's clear as mud now! 😛 PW
     
    Last edited:
    • Like
    Reactions: wfred

    pndwal

    Senior Member
    Jun 23, 2016
    2,243
    1,477
    Sydney
    Xiaomi Redmi Note 7
    Have LSposed and upgraded to Magisk Canary 22104 due to the Safetynet API changes, and all of a sudden Safetynet FAILS (have tried multiple times).

    Anyone else in a similar situation?

    Was on Canary 22103 also with LSposed and SN passed just like on 22.1 before the API change.

    Without LSposed enabled, Magisk 22104 passes SN so anything I can do to get LSposed not to be detected by Safetynet?
    This is at least the second report of this issue. (Read back recent posts). It clearly appears to be a regression.

    However, LSposed / riru / EDXposed compatibility was likely the catalyst for the SafetyNet API key change (to the one now causing SafetyNet test errors) in the first place, so it may be a complex fix.

    Perhaps you or another LSposed user will / should open an issue (bug report) regarding this. PW
     
    Last edited:
    • Like
    Reactions: J.Michael

    drewcu

    Senior Member
    Jan 31, 2012
    288
    101
    This is at least the second report of this issue. (Read back recent posts). It clearly appears to be a regression.

    However, LSposed / riru / EDXposed compatibility was likely the catalyst for the SafetyNet API key change (to the one now causing SafetyNet test errors) in the first place, so it may be a complex fix.

    Perhaps you or another LSposed user will / should open an issue (bug report) regarding this. PW

    Thanks; I tried submitting an Issue on LSposed's GitHub and I was told to stop asking about SafetyNet and immediately closed my Issue... Kind of rude. My first time asking and aren't EdXposed / LSposed based on the premise that they circumvent Xposed SafetyNet detection? Oh well... guess I don't really need it to pass for most of the stuff I use my phone for anyway.
     

    ipdev

    Recognized Contributor
  • Feb 14, 2016
    1,332
    1
    1,476
    Google Nexus 10
    Nexus 7 (2013)
    Have LSposed and upgraded to Magisk Canary 22104 due to the Safetynet API changes, and all of a sudden Safetynet FAILS (have tried multiple times).

    Anyone else in a similar situation?

    Was on Canary 22103 also with LSposed and SN passed just like on 22.1 before the API change.

    Without LSposed enabled, Magisk 22104 passes SN so anything I can do to get LSposed not to be detected by Safetynet?

    Thanks; I tried submitting an Issue on LSposed's GitHub and I was told to stop asking about SafetyNet and immediately closed my Issue... Kind of rude. My first time asking and aren't EdXposed / LSposed based on the premise that they circumvent Xposed SafetyNet detection? Oh well... guess I don't really need it to pass for most of the stuff I use my phone for anyway.

    I thought I read something about Xposed recently. ;)

    From the Update snet.jar extension commit message.
    Magisk - GitHub - Commit
    In addition, add some offline signature verification and change how
    results are parsed to workaround some dumbass Xposed module "faking"
    success results, since many users really don't know better.

    Maybe LSposed was not circumventing SafetyNet ?
    ¯\_(ツ)_/¯

    Cheers. :cowboy:
     
    • Like
    Reactions: J.Michael

    Top Liked Posts

    • 3
      yea, 3) is confusing :) i tried both. removing modified magisk .img by installing stock boot.img, which removes root. and also flashing modified magisk boot.img which gives me root back for both apps. also magiskhide is working for two apps (security token generating apps). these were only ideas to get back to a running magisk app.
      after installing magisk app, the flashed magisk .img is not recordnized in magisk app (n/a). also i can not find any magiskhide app in settings/manage_apps (i'm also not remembering the hidden name, but scrolling slowly through all apps, there's no app with random characters). my goal is to get magisk app running that i'm able to use root for more apps.
      thx fo your fast help btw!
      device: google pixel 4a 5g
      On both my Andrioid 6 and 9 devices, the hidden Magisk Manager is named Settings, with the generic Android icon, as I don't change its name when hiding it. In older versions of Magisk it was named Manager when hidden, I believe.
      3
      From what I can see it's detecting the Magisk app, even when repackaged and hidden. Seems to be more and more common... Solution, for now: freeze or uninstall the Magisk app when you need to use Raiffeisen.

      Edit: if freezing uninstalling works you can very likely use an app like Island or Shelter (open source, yay) to put the app in a work profile to prevent it from detecting other apps.

      I am having a similar problem with the Chase banking app. I tried running it in Shelter, but the app still manages to detect root. Even when running inside of Shelter, the app says the following when I try to access a number of features:
      For your security, this feature is unavailable on devices that have been "rooted" or contain malware. Read our Security FAQ to use this feature.

      Magisk is not running in the shelter. And outside of the shelter, the Chase app is hidden in Magisk 23.0

      Chase and some other banks are going beyond SafetyNet and other tests. Luckily, the Chase IT people are not very smart, and all of the features that I cannot access via the Chase Android app are available when I access my account via the Chase web site from my Android device. This renders all of their so-called "security" useless.

      The following is what I did, and it might work for some other banks, as well:
      * Install a browser besides the standard Android browser (I chose Dolphin)
      * Configure it so that its user agent string is the same one as the one that is used by your desktop browser (not all Android browsers allow this)
      * Also configure it so that the start page for that browser is that bank's normal web site

      This allows me to log into my bank's web site without all the Android-root-related restrictions.

      PS: I used my "Home app" (Nova, in my case) to set the icon of this browser app to be the Chase app's icon, and I changed the title of that app on the screen to "Chase Alternate".
      3
      thx 4 the hint. there's a "settings" with generic android-icon. i disabled it, but still root is hidden. maybe on android 11 it's renamed different? i'm thinking about installing lineage over my pixel stock. this should remove all system modifications.
      If you "disabled" it, then it wasn't Magisk: system apps have a "Disable" option, non-system apps have an "Uninstall" option. (I assume you went to "App info" from the app icon in the Apps drawer. Is there an entry in App info for "details"?)
      2
      thx 4 the hint. there's a "settings" with generic android-icon. i disabled it, but still root is hidden. maybe on android 11 it's renamed different? i'm thinking about installing lineage over my pixel stock. this should remove all system modifications.
      Just checked on my Pixel 3aXL (Android 11)
      Default name to Hide the Magisk app is Settings

      Take a look at the app info. (package name)
      com.android.settings is the device settings app.
      In my case, ziqfexf.wfukfetecw is the hidden Magisk app.

      Cheers. :cowboy:
      1
      ... also i can not find any magiskhide app in settings/manage_apps (i'm also not remembering the hidden name, but scrolling slowly through all apps, there's no app with random characters)...
      Just checked on my Pixel 3aXL (Android 11)
      Default name to Hide the Magisk app is Settings

      Take a look at the app info. (package name)
      com.android.settings is the device settings app.
      In my case, ziqfexf.wfukfetecw is the hidden Magisk app.
      Ah yes; nice way to make distinction!

      App names are not random; they're what user sees generally.

      APK names are generally logical names too; android, com.android.xxx, com.miui.xxx, vendor.qti.xxx

      Magisk hidden app APK name IS random however; oor.xuuzw.xfa.j PW
    • 9
      Latest Debug (Canary)
      Changelog and Release Notes
      https://github.com/topjohnwu/magisk-files/blob/56d4ca44e12927217ae761df0874e3cd7d05cea4/notes.md :

      Magisk (fb8000b5) (22104)​

      • [App] Hide annoying errors in logs when hidden as stub
      • [App] Update stub implementation
      • [App] Some internal code refactoring
      • [App] Update snet extension implementation

      Diffs to v22.1​

      • [App] Update snet extension. This fixes SafetyNet API errors.
      • [App] Fix a bug in the stub app that causes APK installation to fail
      • [App] Hide annoying errors in logs when hidden as stub
      • [General] Remove all pre Android 5.0 support
      • [MagiskPolicy] Remove unnecessary sepolicy rules
      • [General] Fix a C++ bug that causes undefined behavior
      • [MagiskHide] Update package and process name validation logic

      May fix sundry issues with Magisk App! 👍 PW
      8
      Magisk v23 Stable released and by Release Notes SafetyNet API error is fixed in (Magisk apk) Stable as well, hence no need anymore to use (Magisk apk) Canary for SN testing

      Be careful, v23 supports only Lollipop and higher
      8
      Which logs are helpful when devices bootloops on splash screen?

      I read https://www.didgeridoohan.com/magisk/MagiskHelp but is last_kmsg need be taken after booting to Android after flashing stock boot.img?

      I have took and posted logs by booting to TWRP. Is that a correct way?


      Thanks
      The kmsg (Kernel Message) file is constantly written to while booted into an Android environment.
      System or Recovery.

      A new kmsg file is created every time you boot the device into an Android environment.
      The previous kmsg file is moved to last_kmsg

      Both files are replaced each time you (re)boot into an Android environment.

      Example.

      You boot into system and get stuck at the splash screen.
      Your device is currently writing to /proc/kmsg

      You force a reboot into recovery.
      The previous /proc/kmsg was moved to /proc/last_kmsg
      Your device is currently writing to /proc/kmsg

      /proc/kmsg is now the current recovery boot
      Your previous boot into system is now /proc/last_kmsg

      If you now reboot from recovery into recovery again.
      The previous /proc/kmsg is moved to /proc/last_kmsg
      Your device is currently writing to /proc/kmsg file.​

      /proc/kmsg is now the current recovery boot
      Your previous boot into recovery is now /proc/last_kmsg


      Note:
      • Newer devices use /sys/fs/pstore instead of /proc/last_kmsg
      • You normally need heightened privileges (root) to grab kmsg or pstore.
        A custom recovery normally allows you root access.

      Hope it helps more than confuse. 🙃

      Cheers. :cowboy:
      8
      Strange how people think they don't need to read the other posts but expect that their questions should be addressed and answered😌
      7
      Thanks for your answer, freezing doesnt seem to work, it does not trigger the same "your device is rooted" problem, but another error afterwards. Probably it still detect su and magisk binary..
      I dont know. I really wont completly unroot my device to use it :(.
      If there is no other option i will change my bank...
      You can use a tool like shelter to create a workprofile and place the app there.
      Make sure Magisk app is not cloned to the workprofile.
      Works for me with DKB Tan2Go and a quick test shows, that it seems to work for the Raiffeisen app also.
    • 1048
      This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
      All information, including troubleshoot guides and notes, are in the Announcement Thread
      156
      Hello, I haven't given much support on XDA lately. It can be resulted from
      • University started and I have limited free time. In fact, I mostly develop during midnight
      • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
      • The new version is about to come, I don't want to spend effort on supporting old releases
      The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

      New Forum!
      As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
      **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
      It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

      The Pixel Phone
      Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

      Current Progress
      In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
      To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
      After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

      Safety Net Disaster
      Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
      However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
      I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

      Conclusion
      Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

      Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
      121
      Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

      First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

      -------------------------

      What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

      Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

      He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

      It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
      @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

      tl;dr Towards @topjohnwu, I have:
      - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
      - expressed surprise he is using SuperSU binaries in a competing superuser without permission
      - expressed surprise he is posting a modified LiveBoot without permission
      - informed him of issues with the modified SuperSU he has posted
      - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

      To be crystal clear:
      - I have not asked for an apology
      - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
      - I have not made an issue of any of this anywhere, until this post
      - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
      - I have not reported this thread to XDA moderators for copyright violations or otherwise

      While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

      To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

      I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

      Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
      76
      Thread temporarily closed so everyone sees this.

      The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

      The Flash
      Forum Moderator

      EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
      75
      Hello everyone!

      I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

      Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

      So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

      Google, how will a few systemless mods do any harm :p:p
    Our Apps
    Get our official app!
    The best way to access XDA on your phone
    Nav Gestures
    Add swipe gestures to any Android
    One Handed Mode
    Eases uses one hand with your phone