Magisk General Support / Discussion

Search This thread

Xellerate

Member
Apr 8, 2020
27
4
After it booted up without touchscreen, have you tried flashing unpatched stock files with Heimdall? Are you then back where you started, no Magisk but touchscreen works?

If so, I would say that shows you are using Heimdall correctly.

If you are using Heimdall, I would assume you are have a Samsung device. Have you read the Imstallation Notes sections about Samsung? I would expect you to have to install Magisk to recovery. There is some disagreement over whether you need to check the Recovery option in Magisk Manager before patching the AP.tar file, or whether Magisk Manager will always install to recovery when presented with an AP.tar file.
Thats what i did last time i flashed it, but the thing with heimdall is that i have to extract the ap then flash the files separately, it doesnt have the option to flash the packaged version of them, im wondering that maybe its because i didnt flash the full ap is why the touchscreen didnt work, by the way do you have to flash the fota.zip
 
  • Like
Reactions: J.Michael

Xellerate

Member
Apr 8, 2020
27
4
After it booted up without touchscreen, have you tried flashing unpatched stock files with Heimdall? Are you then back where you started, no Magisk but touchscreen works?

If so, I would say that shows you are using Heimdall correctly.

If you are using Heimdall, I would assume you are have a Samsung device. Have you read the Imstallation Notes sections about Samsung? I would expect you to have to install Magisk to recovery. There is some disagreement over whether you need to check the Recovery option in Magisk Manager before patching the AP.tar file, or whether Magisk Manager will always install to recovery when presented with an AP.tar file.
After i was faced with the no touchscreen error, i flashed the boot.img like i did before then it worked, when going into recovery mode is it just meant to be a list of all the options
 

zgfg

Senior Member
  • Oct 10, 2016
    5,301
    2,600
    I just got a factory reset oneplus 6T. I heard that the newest version of twrp (3.5+) and magisk (v22+) dont work together and that wifi doesnt work if you use them both. Is this true? What versions of twrp and magisk work well together for OP6T?
    This is really a question to be posted under Q&A at:
    Maybe already covered in your device forum there
     
    • Like
    Reactions: J.Michael

    J.Michael

    Senior Member
    Jan 20, 2018
    700
    488
    Samsung Galaxy Tab A series
    Thats what i did last time i flashed it, but the thing with heimdall is that i have to extract the ap then flash the files separately, it doesnt have the option to flash the packaged version of them, im wondering that maybe its because i didnt flash the full ap is why the touchscreen didnt work, by the way do you have to flash the fota.zip

    After i was faced with the no touchscreen error, i flashed the boot.img like i did before then it worked, when going into recovery mode is it just meant to be a list of all the options
    I don't know your device. I've only used one device (Samsung SM-T290).
    But, yes, I think recovery mode is just a list of options. One option for me says something like "boot to bootloader", and is one of the paths to what's called "download mode". That's where I use Odin. I assume that's where you use Heimdall.

    The little I read about Heimdall made me think it was beastly to use. Can't you hold your nose and use Windows long enough to use Odin?

    Since @topjohnwu warns against just flashing one .tar file, or flashing too little in the AP.tar file, I'd say there's a good chance that your problems come from failing to flash enough. Did you flash boot.img, recovery.img, and vbmeta.img? (The notes say to at least put that much into a tiny AP.tar file. They also say don't leave out the other three .tar files.)
     
    • Like
    Reactions: pndwal

    Zimbushman

    Member
    Apr 21, 2021
    6
    0
    South Africa
    Hi, I have a Samsung A10s, (sm-a107f) with Android 10, Magisk 22.1 installed, no ramdisk, SAR yes, flashed stock kernel with patched AP. Boot into Magisk via recovery, all good , phone rooted, but will no detect sim card, aeroplane mode dimly lit, cannot toggle, if i boot phone normally (no magisk root ) the siim card is detected, making me think that the problem lies with Magisk, could someone kindly advise, Cheers in advance
     

    pndwal

    Senior Member
    Jun 23, 2016
    2,395
    1,681
    Sydney
    Xiaomi Redmi Note 7
    I just got a factory reset oneplus 6T. I heard that the newest version of twrp (3.5+) and magisk (v22+) dont work together and that wifi doesnt work if you use them both. Is this true? What versions of twrp and magisk work well together for OP6T?
    Not sure it your device, but new suffix now = Android version compatable.

    I found latest Official twrp-installer-3.5.2_9-0-fajita.zip - seems to be Android 9.

    TWRP 3.4.0-11 Q Unofficial by mauronofrio may in fact be more improved:
    Prop fix, A11 decryption, (A10 device tree?)
    https://forum.xda-developers.com/t/...y-for-oneplus-6t-stable.3861482/post-84118769

    If you still have compatibility problems, consider Restoring stock Recovery, and Fastboot booting only (not flashing) to TWRP when needed. This overcomes compatibility problems for many. PW
     
    • Like
    Reactions: J.Michael

    pndwal

    Senior Member
    Jun 23, 2016
    2,395
    1,681
    Sydney
    Xiaomi Redmi Note 7
    Hi, I have a Samsung A10s, (sm-a107f) with Android 10, Magisk 22.1 installed, no ramdisk, SAR yes, flashed stock kernel with patched AP. Boot into Magisk via recovery, all good , phone rooted, but will no detect sim card, aeroplane mode dimly lit, cannot toggle, if i boot phone normally (no magisk root ) the siim card is detected, making me think that the problem lies with Magisk, could someone kindly advise, Cheers in advance
    I don't have Sammy 😜

    However, did you do initial Magisk installation this way:
    - Patch AP tar w/ Recovery mode selected.
    - Copy the patched tar file to your PC with ADB (NOT MTP).
    - Using Odin, flash magisk_patched.tar as AP, TOGETHER WITH BL, CP, and CSC (NOT HOME_CSC) to flash w/ data wipe.
    - Allow Additional setup from Internet.

    If updating ROM:
    - pre-patch AP w/ Recovery mode selected.
    - Copy the patched tar file to your PC with ADB (NOT MTP).
    - Using Odin, flash magisk_patched.tar as AP, TOGETHER WITH BL + CP + HOME_CSC to upgrade / keep data.
    - Allow any Additional setup from Internet.

    ... just checking... 😛 PW
     
    Last edited:
    • Like
    Reactions: J.Michael

    J.Michael

    Senior Member
    Jan 20, 2018
    700
    488
    Samsung Galaxy Tab A series
    Hi, I have a Samsung A10s, (sm-a107f) with Android 10, Magisk 22.1 installed, no ramdisk, SAR yes, flashed stock kernel with patched AP. Boot into Magisk via recovery, all good , phone rooted, but will no detect sim card, aeroplane mode dimly lit, cannot toggle, if i boot phone normally (no magisk root ) the siim card is detected, making me think that the problem lies with Magisk, could someone kindly advise, Cheers in advance
    Do you have any modules installed?
    Disable all Magisk modules and reboot.
     
    • Like
    Reactions: pndwal

    ipdev

    Recognized Contributor
  • Feb 14, 2016
    1,362
    1
    1,532
    Google Nexus 10
    Nexus 7 (2013)
    Sorry for a bit of OT. ;)

    Note about TWRP.
    TeamWinRecoveryProject

    Starting with 3.5.x, TWRP is built on Android 9 or Android 10 depending on the device.

    TWRP 3.5.0 is out now for most currently supported devices.

    For this release we are breaking down new support for devices based on android trees and device compatibility. For Pie and earlier devices, they will be built out of the android-9.0 branch. For devices that are released with Android Version 10, they will be supported under the android-10 branch.

    The separation became apparent when a lot of functionality was dropped in the android-10 release last year. The devices that are supported in Android 10 are from the tireless support of the following individuals over this period: - CaptainThrowback - Mauronofrio - AndroiableDroid - Noah Jacobson

    TWRP 3.5.0 Release Notes.
    TeamWin - WebSite - Link

    Cheers. :cowboy:
     
    • Like
    Reactions: pndwal

    pndwal

    Senior Member
    Jun 23, 2016
    2,395
    1,681
    Sydney
    Xiaomi Redmi Note 7
    I would expect you to have to install Magisk to recovery. There is some disagreement over whether you need to check the Recovery option in Magisk Manager before patching the AP.tar file, or whether Magisk Manager will always install to recovery when presented with an AP.tar file.
    Isn't it a question of whether ramdisk is supported in boot? Pretty sure patching AP.tar still patches boot image on Ramdisk=yes devices.

    On Sammy with Ramdisk=no, is Magisk Installed properly to recovery without Recovery mode selected? (I don't think Magisk in boot works for Sammy as it does generally for Type III Xiaomi, and John says "If your device does NOT have boot ramdisk, make sure “Recovery Mode” is checked in options" in Sammy section.) PW
     
    Last edited:

    pndwal

    Senior Member
    Jun 23, 2016
    2,395
    1,681
    Sydney
    Xiaomi Redmi Note 7
    Restore Images doesn't work for me. I get a message that says:

    stock backup does not exist!
    You may be able to check this.

    Using a root explorer, so you have any magisk_backup_xxx folder(s) in /data?

    Or in /data/adb/magisk, any stock_boot.img?
    I have the stock boot.img from April - where do I need to place the file so Magisk will find it?
    Just flash it to restore! Fastboot, or TWRP. 👍 PW
     
    • Like
    Reactions: J.Michael

    pndwal

    Senior Member
    Jun 23, 2016
    2,395
    1,681
    Sydney
    Xiaomi Redmi Note 7
    I checked Settings option on TWRP, but haven't seen the about device option sadly (using TWRP 3.0.2-0-decker-2, if that helps). Right now I'm only able to access recovery on the phone.
    Meant device Settings, About device! 😛
    Yeah, they are small .zip files which were bundled on the S60 Rooting topic package, so I guess they are binary-patches. I guess I could try to make a NANDroid boot's backup and then try the uninstall.zip method with the magisk version I used, and if that fails try to use 31.02 boot.img and try to be lucky and in case something goes bad, I could restore the NANDroid bootlooping backup.
    Meant unroot, take OTA, make TWRP backup to obtain boot.img update (if you can't extract, or its only a binary incremental OTA patch), patch and flash that to re-root. (Simply renaming boot.emmc.win to .img file seems to work fine, although renaming other .win files apparently doesn't always.) 🤠 PW
     
    • Love
    Reactions: XenonF-Dev

    sereksim

    Member
    Dec 11, 2020
    8
    1
    It says 0 KB, but then the file too big - how big is really your original boot.img and the patched one (mine is cca 21 KB)?

    When calling fastboot without the path for the file, file must be in the ADB directory, is it?
    Are you able to flash the same way the original boot.img or twrp.img?

    Btw, you should have TWRP, why don't you Install the patched img from TWRP (select img files - by default it shows only zip files) and select Boot as the target partition

    I assume Magisk did not report an error when you were patching, and that you have not only Bootloader unlocked (you have to, since you switched to Xiaomi.eu) but also that upon installing Xiaomi.eu you re-enabled OEM Unlocking in Developer menu (otherwise it blocks flashing)

    And test with fastboot devices before you attempt to flash from fastboot
    I patched the boot.img again and it worked. Thanks for your help :)
     
    • Like
    Reactions: zgfg

    J.Michael

    Senior Member
    Jan 20, 2018
    700
    488
    Samsung Galaxy Tab A series
    Isn't it a question of whether ramdisk is supported in boot? Pretty sure patching AP.tar still patches boot image on Ramdisk=yes devices.

    On Sammy with Ramdisk=no, is Magisk Installed properly to recovery without Recovery mode selected? (I don't think Magisk in boot works for Sammy as it does generally for Type III Xiaomi, and John says "If your device does NOT have boot ramdisk, make sure “Recovery Mode” is checked in options" in Sammy section.) PW
    We keep going in circles on this. As far as I know, only Samsung delivers firmware in tar files. I don't know if any Samsung for which firmware is delivered in tar files has Ramdisk=yes.

    I thought that when I was struggling to install Magisk, I determined that the Recovery checkbox was meaningless, that Magisk would do what it thought best after seeing the AP.tar it was being asked to patch.

    I started to check that again, but my Magisk Manager will not give me am option to patch a file: It wants to update, it won't show any "Install" option until I update, I am not willing to update. From things I've read (probably things you wrote), I might get around that by changing to Custom Update Channel without providing a URL, but, again, I'm afraid to change anything.

    It does not seem to be the case that Magisk *must* be installed in recovery on Samsungs: The thread on installing TWRP on my device (SM-T290) talks about patching the boot image.
     
    • Like
    Reactions: pndwal

    pndwal

    Senior Member
    Jun 23, 2016
    2,395
    1,681
    Sydney
    Xiaomi Redmi Note 7
    We keep going in circles on this. As far as I know, only Samsung delivers firmware in tar files. I don't know if any Samsung for which firmware is delivered in tar files has Ramdisk=yes.
    John's?

    ... might need to part with £1600 (British) for that!

    But seriously, type III (legacy SAR, Ramdisk = no) devices have been superseded by 2SI ramdisk 'SAR' (first seen on Pixel 3 Android 10 developer preview) on devices launched with API level 29+, as well as retrofitted Pixel 3 / 3a.

    So ALL later (type IV) Samsung devices use tar package and (boot) Ramdisk = yes.

    Earlier (type II) A/B, legacy SAR devices (from Pixel 1) employed a recovery ramdisk in Boot partition (Recovery partition was removed), and Samsung used tar package for their offerings.

    So earlier A/B (type II) Samsung devices also use tar package and (boot) Ramdisk = yes.

    Non A/B legacy SAR (type III) are the only devices w/ Ramdisk = no, unless some other type has escaped John!

    https://topjohnwu.github.io/Magisk/boot.html

    😉 PW
     
    Last edited:

    J.Michael

    Senior Member
    Jan 20, 2018
    700
    488
    Samsung Galaxy Tab A series
    John's?

    ... But might need to part with £1600 (British) for that! 😉 PW
    A small price to pay when you remember that, after opening it 3000 times, you will have two tablets for the price of one. (I can't wait to hear whether you can drag something from one half to the other. Or does Samsung Entanglememt guarantee that anything done to one half was already done to the other?)
     

    pndwal

    Senior Member
    Jun 23, 2016
    2,395
    1,681
    Sydney
    Xiaomi Redmi Note 7
    A small price to pay when you remember that, after opening it 3000 times, you will have two tablets for the price of one.

    I can't wait to hear whether you can drag something from one half to the other. Or does Samsung Entanglememt guarantee that anything done to one half was already done to the other?
    No, only that ones better half will be less inclined to interface with a third party, as in the case of Alice and Bob below.

    Of course, as presented by the converse theory, where third party entanglement has a mechanical bond stronger than the bipartite pure state, Alice will divulge nothing to Bob, and vice versa.
    The monogamy of entanglement is one of the basic quantum mechanical features, which says that when two partners Alice and Bob are more entangled, then either of them has to be less entangled with the third party. Here we qualitatively present the converse monogamy of entanglement: given a tripartite pure system and when Alice and Bob are weakly entangled, then either of them is generally strongly entangled with the third party. Our result leads to the classification of tripartite pure states based on bipartite reduced density operators, which is a novel and effective way to this long-standing problem compared to the means by stochastic local operations and classical communications. We also systematically indicate the structure of the classified states and generate them.
    https://arxiv.org/abs/1102.0439

    The question of whether anything done to one half was already done to the other, however, or if stuff can equitably be dragged from one party to the other for that matter, is moot, as the testing environment has become wholly unsatisfactory. At this point, the whole premise folds.

    Disclaimer:
    The objective is still, as always, reduced density of operators.

    Apologies if anyone feels that this General Discussion is in any way irreverent, or even irrelevant to the Support those impelled to don a Magisk Mask to hide from Alice... or from Bob... or from the Bank, or Google.

    09-36-08-magisk-logo.png

    Would look great at a party though. PW
     
    Last edited:
    • Like
    Reactions: ipdev

    XenonF-Dev

    Member
    Apr 28, 2021
    13
    14
    Meant device Settings, About device! 😛

    Meant unroot, take OTA, make TWRP backup to obtain boot.img update (if you can't extract, or its only a binary incremental OTA patch), patch and flash that to re-root. (Simply renaming boot.emmc.win to .img file seems to work fine, although renaming other .win files apparently doesn't always.) 🤠 PW
    Thanks for everything, I finally managed to get it to boot again, although in an unexpected way :p.

    Going to list it to make it as clear as possible:
    • Made a full compressed TWRP backup
    • "Installed" on TWRP Magisk22.1.apk as uninstall.zip, still got bootloop
    • Tried again uninstall.zip, this time wiping dalvik cache, still got bootloop
    • Renamed Magisk-v20.3.zip to "Uninstall.zip" and installed it with TWRP, it installed Magisk20.3 instead
    • The Phone now boots with no strange signs (besides the new SD I used for backups)
    I'm glad it now works, and as it is my only daily phone that's a lot, but I'm not sure how to proceed to keep myself safe in the future (Maybe install the old magisk manager and uninstall magisk from there, which could give me a clean update38 boot.img to patch?)

    Again, thanks a lot for the time and effort put into looking on my issue, it's really appreciated :D.
     

    Top Liked Posts

    • There are no posts matching your filters.
    • 12
      The man needs a break.

      He certainly deserves one in my book. Not a lynch mob.
      John Wu, 2h

      I understand that being the developer of a popular open source project, people are *longing* for an explanation.

      However, the speculation and conspiracy theories are getting out of hand, there are even attempts to sabotage my employment in the name of "saving the community"...

      This is putting extreme strain on me mentally, so let me get the facts straight: nobody really knows exactly how things will go in the future.

      I tweeted an assumption caused by miscommunication; I was informed it to be non factual; I deleted the tweet. That's all, really.

      So please, PLEASE, put down your tinfoil hats and pitchforks, and allow me to handle the situation privately. I will update you once there is a conclusion.

      Nobody is hired to kill off a project.
      I did not join Google for money.
      And of course, I have not betrayed the community.
      www.twitter.com/topjohnwu/status/1394835335096406023

      PW
      8
      From what John has said on Reddit and behind the scenes, recanting on some made statements, he can not touch magisk at all not speak on it anymore.
      Most here are aware of that quote, and as has been pointed out, it was private, he didn't 'say it on Reddit', it was only part of a much longer communication and the 'leak' was not appreciated, but my guess is that many colaborators will be in the loop.
      Since he does own the repositories for magisk so we could see them just disappear. He can't push an update which only he can do, so it's either fork it and go that route, which he knows all the ins and outs of magisk and now works for Google(2+2 says he will spilling the beans on the background to block it), I believe they have him on a gag because conflict of interest with magisk sidestepping their security system.
      I don't think G needs him to spill the beans on 'blocking' Magisk; they're quite aware of how it works. It's source is open, after all...

      But if you meant blocking attestation spoofing / bypassing (MagiskHide, some modules, and other), they already know how to make this foolproof. It does require compliant hardware to implement however, and it seems that when some target percentage of devices have launched with tee, a switch will be flipped, and spoofing attestation, and hence MagiskHide at least outside of userspace (ie bootloader Unlocked / verified boot, will become impossible for practical purposes for most users.

      MagiskHide will still be able to hide root from apps within userspace, but these can still check secure boot status through tee attestation, and will likely report 'root/jailbreak' but actually mean 'insecure boot environment'.

      Expect the pool of those still able to hide bootloader status to be reduced, for practical purposes, to those running custom OSs with inbuilt spoofing or Magisk on devices with launch version < or = to Android 7 (last version without requisite keymaster 3) overnight. (Nb. Hardware-backed Keystore began to be hardened from Android 6)
      https://source.android.com/security/keystore

      Hardware TEE of course, stands for Trusted Execution Environment, and it is not just implemented by Google.

      It actually facilities security in RISC, IBM, AMD, Intel, Apple, as well as Qualcomm, MediaTek, Samsung and Huawei SOCs running various systems. Here's an article focussing on ARM implementation:
      https://embeddedbits.org/introduction-to-trusted-execution-environment-tee-arm-trustzone/

      Interestingly, it states:
      TEE is not the solution to all of our security problems. It is just another layer to make it harder to exploit a vulnerability in the operating system. But nothing is 100% secure.
      You can't work for somewhere and have an ap they completely bypasses their OS without a amjor conflict of interest.
      Well, it doesn't bypass it; it gives superuser access as well as ways to overlay mods on an OS, and both things are certainly allowed by design if bootloader is unlocked.

      There are ways to prevent such unlocking, but Google doesn't do that. That's not to say they don't know how however. That would be laughable; It is their system (both open source Android framework and proprietary apps). They simply leave that to OEMs to implement, and, of course, a number take such measures.
      https://support.google.com/accounts/answer/9211246?hl=en
      Google doesn't even want you using a "modified system" to access your Google account. Google has major issue with root.
      They NEVER said that.

      They have protected their proprietary apps by forbidding bundling GApps with custom ROMs, originally ordering Steve Kondik to 'cease and desist' bundling with CyanogenMod, but offered an olive branch in quick succession when he assumed project was dead, allowing individual users to sideload the same, and sites like OpenGApps to host them.

      They have also expressly stated they DON'T oppose either root or custom ROMs, even recently. Eg from Tech Lead for Android hardware-backed security subsystems:
      Shawn Willden, May 19

      The Platform Security team has never been opposed to modding/rooting (and most of us are firm believers in users' right to own their devices), but remains firmly focused on maximizing security for the 99.99% of users who don't. Root weakens the security model.
      www.twitter.com/shawnwillden/status/1394665579076743175

      In line with the above, they state clearly that if you choose to mod your device, "you lose some of the security protection provided by Google", and they do have recommendations, including "Use a different device for important accounts & sensitive data"
      https://support.google.com/accounts...s-with-modified-rooted-android-versions?hl=en

      Also, rather than prevent their own proprietary apps from running in custom modded systems, they allow these to appear on PlayStore and be used freely. Very few are restricted at all, unless for good (security, corporate partners requirements etc) reason. GPay comes to mind here.

      They could, of course, prevent this (especially when HKA is fully functional), simply by requiring PlayProtect Certified Device, but so far they have PURPOSELY allowed custom modders even with uncertified (Chinese etc) devices to add their devices to their online White List that allows them to run the very GApps (without spoofing) that they were prevented from using w/ stock ROMs.

      This sets an example to others (wish likes of Maccas would wake up), but SafetyNet API and PlayProtect certification are available for apps / code deemed a security risk... Of course, SafetyNet Implementation can be abused, but Google's stance is that the code's author has the right to be informed about the execution environments status and make such decisions.

      Interestingly, it seems not only that Google is unopposed to custom ROMs, but they are not averse to the idea of certifying these / issuing appropriate signing keys so bootloader can be locked to allow full SafetyNet pass (with no spoofing), and GApps can be included legitimately. Of course, this solution evidently precludes root.

      The spiritual successor of CyanogenMod, LineageOS, is in a good position to get such an agreement as they already take pains not to 'subvert Google's security model', never bundling GApps, pre-root, signature spoofing (MicroG would come unstuck here 😉) or any other spoofing mods or techniques. Note this conversation between Shawn and Luca Stefani ('Director for LineageAndroid & Developer'):
      www.twitter.com/shawnwillden/status/1238161446200127488

      That ones been a while (time of initial Google Hardware Key Attestation testing), but I hope we see more on the front. 😛

      In short, Google is against subverting their security model, which includes SafetyNet implementation which ALLOWS code to run in insecure environments (even with superuser privileges) WITHOUT subverting it, by making TEE attestation results available to interested parties. Hardware TEE just ensures that the attestation is accurate... And Google didn't invent it either!

      Here's a bit I posted re. mainstream influence on Google's decision to implement Hardware backed attestation for for verified boot and Trusted Execution Environment:
      https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-83280363

      I don't want to take sides in this; only to give perspective. There's certainly room for many viewpoints. Take what John said on the subject just 4 months ago:
      https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84398495

      ... I wonder what he's thinking now! 😜 PW
      8
      That is the most wrong statement. If Google didn't has no issues with having root, there would not magsikhide. Just that statement alone conflicts with itself. MagiskHide hides root... Google has a problem with hiding root and not root, then why hide it? Why is there basic attention and cts profile check? Now a hardware check? Root, on Android is what they don't want, or else there would be no need for a modified kernel, we would all have root like on Linux desktop... Any terminal on desktop has root instantly, Android doesn't.. They did pretty damn good job of taking something away they wanted to have all along right? Wow.
      This whole discussion took a bit of a turn, and I'm not gonna get further into that. But, you might want to reread what I said again: "Google has no interest in preventing root". That statement doesn't say anything on how Google think about root in security terms (and I'm talking about the Google security team here, which John now is a part of).

      We're talking about different things, I believe...

      You're talking about the security aspect, which Google cracks down on (since generally, rooting a device compromises the systems security), and I'm talking about just being able to root your device regardless of if SafetyNet triggers or not.

      If they wanted to, Google could make it so much harder (impossible?) to root your Android device... From statements I've seen from Google security team members, that's not on their agenda. But of course, beefing up the security on Android in general might have the unfortunate side effect of accomplishing the same thing.
      8
      there is no access via terminal

      i installed my fave module, debloat, but of course cant access it...they were serious about the lite part :)

      As for the install of lite...i installed the apk and patched a boot img, had no errors

      v4a/vanced youtube doesnt work either, now i really want to die :)

      going to bed finally, in disgust
      Installation of modules works in Magisk Lite but with some additional tricks:

      1) When you install a module from Magisk Lite app, it creates its folder in:
      /data/adb/modules_update

      When you reboot, Lite will not read that folder and the module(s) will not really be installed/updated (instead, they would be next time when you boot to Stable/Beta/Canary/Alpha, because they do read from /data/adb/modules_update)

      Hence:
      - Install one or more modules you need
      - Use MiXplorer (or another root explorer), or terminal and mv command, or rename it by TWRP:
      /data/adb/modules_update
      to:
      /data/adb/lite_modules_update
      -Reboot, Magisk Lite will properly finish installation of your modules and you will find them in:
      /data/adb/lite_modules

      2) MHPC: I successfully installed but in terminal it doesn't recognize the props command.
      Something is wrong with the path

      You can still use MHPC by invoking instead:
      /system/xbin/props

      3) Similarly for BusyBox NDK. It was installed to /system/xbin

      Indeed, you can list all its commands by:
      ls /system/xbin

      4) I have successfully installed Vanced YouTube root (latest v16.16.38) as a module:

      No ads, background playing, all ok

      5) Smali patcher - Safe Screenhot Mode (allowing to screenshot from apps otherwise not allowing the screenshots)

      E.g., I can make screenshots from Chrome Incognito window

      6) If your debloater uses terminal and installs to /system/xbin, you should be able to exploit as explained above for MHPC and BB

      However, I use my own Systemless Debloater that does not use command line interface (terminal):

      and I have successfully debloated all the same 32 system apps as I do with Magisk Stable/Canary/Alpha

      7) I have manually copied hosts folder from:
      /data/adb/modules/
      to:
      /data/adb/lite_modules/

      and got the adblocking work.
      However, Adaway does not know for that folder and if you update/change anything in AdAway, it will write to its regular modules/hosts folder (but you can always copy again the same folder or just its etc/hosts file)

      9) I didn't try with Viper4Android (I'm already back to Magisk Beta with 'regular' modules) but I believe the installation should work the same way I always install it to Stable/Canary:

      And Lite should similarly work for other modules


      I have some issues with MixPlorer though in Magisk Lite (although I completely uninstalled and reinstalled MiXplorer):

      9) MiXploree was granted root and it works but AFTERWARDS Magisk Lite app shows that Magisk is not installed and I simply have to reboot to get Lite properly working again

      10) MiXplorer can only see the stock content in /system/xbin, i e. without props and BusyBox commands (btw, ls from terminal works fine)

      Same for all other folders being overlaid by Magisk systemless mounting - MiXplorer always shows their stock content while terminal su commands work with the Magisk overlaid content


      But altogether, it would be possible to live with Magisk Lite - even the modules work


      Edit:
      I have Magisk apps Canary, Alpha and Lite downloaded and renamed like:
      Magisk-Lite-7717f0a6(23001).apk

      I have also my boot.ing patched by Magisk Canary, Alpha and Lite and renamed like:
      boot-Magisk_Alpha_23001-xiaomi.eu_multi_HMK20MI9T_21.5.20_v12-11.img

      When I want to switch, I simply install the right Magisk apk, flash the corresponding img from TWRP (or Fastboot) and reboot

      When going from Stable/Canary to Aplha/Lite (or vice versa), that previous Magisk app must be uninstalled because of different signatures

      When installing the Alpha or Lite apk I was asked by Play Protect to send the report - I ignored and upon rebooting with Magisk and MagiskHide properly back on, Play Protect was always ok
      8
      Just want to point out that sharing screenshots of a private conversation isn't cool. The damage is already done and it's out there, but let John himself be the one to break the news.
    • 1050
      This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
      All information, including troubleshoot guides and notes, are in the Announcement Thread
      156
      Hello, I haven't given much support on XDA lately. It can be resulted from
      • University started and I have limited free time. In fact, I mostly develop during midnight
      • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
      • The new version is about to come, I don't want to spend effort on supporting old releases
      The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

      New Forum!
      As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
      **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
      It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

      The Pixel Phone
      Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

      Current Progress
      In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
      To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
      After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

      Safety Net Disaster
      Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
      However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
      I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

      Conclusion
      Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

      Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
      121
      Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

      First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

      -------------------------

      What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

      Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

      He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

      It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
      @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

      tl;dr Towards @topjohnwu, I have:
      - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
      - expressed surprise he is using SuperSU binaries in a competing superuser without permission
      - expressed surprise he is posting a modified LiveBoot without permission
      - informed him of issues with the modified SuperSU he has posted
      - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

      To be crystal clear:
      - I have not asked for an apology
      - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
      - I have not made an issue of any of this anywhere, until this post
      - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
      - I have not reported this thread to XDA moderators for copyright violations or otherwise

      While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

      To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

      I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

      Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
      76
      Thread temporarily closed so everyone sees this.

      The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

      The Flash
      Forum Moderator

      EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
      75
      Hello everyone!

      I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

      Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

      So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

      Google, how will a few systemless mods do any harm :p:p