Magisk General Support / Discussion

Search This thread

HemanthJabalpuri

Senior Member
Which logs are helpful when devices bootloops on splash screen?

I read https://www.didgeridoohan.com/magisk/MagiskHelp but is last_kmsg need be taken after booting to Android after flashing stock boot.img?

I have took and posted logs by booting to TWRP. Is that a correct way?


Thanks
 
  • Like
Reactions: J.Michael

ipdev

Recognized Contributor
  • Feb 14, 2016
    1,361
    1
    1,531
    Google Nexus 10
    Nexus 7 (2013)
    Which logs are helpful when devices bootloops on splash screen?

    I read https://www.didgeridoohan.com/magisk/MagiskHelp but is last_kmsg need be taken after booting to Android after flashing stock boot.img?

    I have took and posted logs by booting to TWRP. Is that a correct way?


    Thanks
    The kmsg (Kernel Message) file is constantly written to while booted into an Android environment.
    System or Recovery.

    A new kmsg file is created every time you boot the device into an Android environment.
    The previous kmsg file is moved to last_kmsg

    Both files are replaced each time you (re)boot into an Android environment.

    Example.

    You boot into system and get stuck at the splash screen.
    Your device is currently writing to /proc/kmsg

    You force a reboot into recovery.
    The previous /proc/kmsg was moved to /proc/last_kmsg
    Your device is currently writing to /proc/kmsg

    /proc/kmsg is now the current recovery boot
    Your previous boot into system is now /proc/last_kmsg

    If you now reboot from recovery into recovery again.
    The previous /proc/kmsg is moved to /proc/last_kmsg
    Your device is currently writing to /proc/kmsg file.​

    /proc/kmsg is now the current recovery boot
    Your previous boot into recovery is now /proc/last_kmsg


    Note:
    • Newer devices use /sys/fs/pstore instead of /proc/last_kmsg
    • You normally need heightened privileges (root) to grab kmsg or pstore.
      A custom recovery normally allows you root access.

    Hope it helps more than confuse. 🙃

    Cheers. :cowboy:
     

    DiamondJohn

    Recognized Contributor
  • Aug 31, 2013
    5,213
    4,798
    Sydney
    The kmsg (Kernel Message) file is constantly written to while booted into an Android environment.
    System or Recovery.

    A new kmsg file is created every time you boot the device into an Android environment.
    The previous kmsg file is moved to last_kmsg
    ...snip...
    And there is also the magisk boot log method, which I think from memory is basically just a logcat during boot, and is more if you can boot normal before it fails. More info at @Didgeridoohan web site:
     

    hamid3pnn

    Senior Member
    Aug 21, 2011
    178
    27
    hi after hide magisk to another apk name in setting, Avast mobile security says it contains malware and wanted to uninstall it, should i ignore that? thanks
     

    pndwal

    Senior Member
    Jun 23, 2016
    2,393
    1,674
    Sydney
    Xiaomi Redmi Note 7
    hi after hide magisk to another apk name in setting, Avast mobile security says it contains malware and wanted to uninstall it, should i ignore that? thanks
    Many 'Magisk' packages floating around actually DO contain malware. Counterfeit (doctored) builds have even been proffered on PlayStore!

    What's more, root permission makes malware particularly potent / dangerous, so BE CAREFUL!

    John Wu's GitHub is now the ONLY official source.
    https://github.com/topjohnwu/Magisk

    Please consider the source of yours.

    Having said that, it is still likely that there is no malware infection to worry about at all. John acknowledges that detection of 'suspicious activity' in relation to a hidden Magisk App / Manager is in fact legitimate due to generated key used to sign the App:
    John Wu, Feb 22, 2020

    I don't understand why people still believe whatever antivirus apps say about Magisk Manager 🙄

    Look, Magisk Manager is an OPEN SOURCE app. Just avoid downloading it from ANYWHERE other than my GitHub release page.

    Deal?

    Oh, and for those wondering why Google Play Protect red flags the repackaged Magisk Manager: it is because the app is GENERATING a unique key on-the-fly and use it to sign the repackaged APK, so OF COURSE it is suspicious activity in Google Play Protect's eyes, and rightfully so.
    www.twitter.com/topjohnwu/status/1231114984484065281

    Perhaps coincidentally, John has recently changed the App hiding method. Just out of curiosity, what is you Magisk version? PW
     
    Last edited:

    diorlee90

    Member
    Sep 9, 2018
    11
    2
    Hey guys, my phone xiaomi Mi 11 pro has rooted succes with magisk 22.1 ver. But it's only "youtube vanced" working, Mixplorer newest ver not work athough it's has permission. It's cant modify system/root.
    Anyone know how to solve that problem?

    sorry for my bad English.
     

    DiamondJohn

    Recognized Contributor
  • Aug 31, 2013
    5,213
    4,798
    Sydney
    Hey guys, my phone xiaomi Mi 11 pro has rooted succes with magisk 22.1 ver. But it's only "youtube vanced" working, Mixplorer newest ver not work athough it's has permission. It's cant modify system/root.
    Anyone know how to solve that problem?

    sorry for my bad English.
    If you have a newer device (Which it sounds like you do), then your system is mounted as Read-Only, and basically can not be changed to RW. Thats how newer android on newer devices, runs
     

    XenonF-Dev

    Member
    Apr 28, 2021
    13
    14
    Aside from trying Canary Magisk (not sure if you did), might be worth waiting for next Stable build. Seem to be quite a few fixes already committed to be merged... PW
    What puzzles me is that even after un-rooting I had the bootloop, and only applying Magisk 20.3 fixed it.
    Also saw a popup when checking Magisk App that Magisk 22.1 app doesn't give support to Magisk <20.4 (I had 20.3), which could have been the problem from the start.

    When I manage to have some time to fiddle more with Magisk, I will try updating to Magisk20.4 via TWRP and try again, this time with the next Stable Magisk version of course (which I hope doesn't drop support for 20.4 🤞).

    About Canary, I didn't even consider it, since I couldn't afford the risk of doing anything that could potentially do even more damage as I was still trying to understand what was happening first and taking only affordable risks if possible. While I consider I can defend myself on bash, I lack the Andoid's ecosystem knowledge that could let me know what went wrong and that kind of stuff, so thanks ipdev for summarizing it, it will be really helpful in case I run again into trouble :).

    Have a nice day!
     
    • Like
    Reactions: ipdev and pndwal

    dknight178

    Senior Member
    Jan 21, 2012
    82
    6
    London
    Hi everyone, I'm using OP7 pro (10.0.10). Magisk was working fine before today; however, I tried updating my magisk manager to 22.1 and now I can't open magisk manager - first time I open the app, the magisk logo appears then disappears and nothing happens; second time I open it says "magisk keeps stopping".



    I googled around and tried to: a) restart my phone, b) clear cache and/or storage, c) try to use magisk manager without wifi/data, but none of them worked.



    Google pay still works and rooted apps like titanium backup still work (although "magisk manager keeps stopping" pops up, I can use the rooted apps).



    Is there any way I can fix this without losing my data and my root? Thanks
     

    zgfg

    Senior Member
  • Oct 10, 2016
    5,290
    2,594
    Hi everyone, I'm using OP7 pro (10.0.10). Magisk was working fine before today; however, I tried updating my magisk manager to 22.1 and now I can't open magisk manager - first time I open the app, the magisk logo appears then disappears and nothing happens; second time I open it says "magisk keeps stopping".



    I googled around and tried to: a) restart my phone, b) clear cache and/or storage, c) try to use magisk manager without wifi/data, but none of them worked.



    Google pay still works and rooted apps like titanium backup still work (although "magisk manager keeps stopping" pops up, I can use the rooted apps).



    Is there any way I can fix this without losing my data and my root? Thanks
    Make sure you find in Settings, Apps the old Magisk Manager (or however you renamed if hiding) and ununstall.
    If needed uninstall and reinstall also the new Magisk app.
    You will not loose Magisk root, modules, hide etc
     

    535iu

    Senior Member
    Feb 22, 2016
    129
    5
    Hi, some of us are having problems patching Ramdisk so we can update Magisk. Magisk is patching the Ramdisk file wrong and when this file is installed (from TWRP) the root is lost. The direct install method doesn't work either, root is also lost when installing.

    I have tried with several versions of the Magisk application, also with the old Magisk Manager applications. Nothing works. I also wiped Dalvik and cache.

    I have Magisk 20.4 (20400).

    Can anyone help me?
     

    zgfg

    Senior Member
  • Oct 10, 2016
    5,290
    2,594
    Hi, some of us are having problems patching Ramdisk so we can update Magisk. Magisk is patching the Ramdisk file wrong and when this file is installed (from TWRP) the root is lost. The direct install method doesn't work either, root is also lost when installing.

    I have tried with several versions of the Magisk application, also with the old Magisk Manager applications. Nothing works. I also wiped Dalvik and cache.

    I have Magisk 20.4 (20400).

    Can anyone help me?
    You omitted the most important details like model, firmware

    Assuming ramdisk.img, you should have Huawei with exactly EMUI 8.x?

    Do you still have your ramdisk patched with the old Magisk - to revert if neccessary.
    Try (re) patching with the new Magisk that ramdisk img previously (successfully) patched by the old Magisk, instead of patching the stock ramdisk

    Try also with Magisk Canary (it's newer than Stable)

    Use the appropriate (Stable or Canary) Magisk app
     
    • Like
    Reactions: pndwal

    hamid3pnn

    Senior Member
    Aug 21, 2011
    178
    27
    Many 'Magisk' packages floating around actually DO contain malware. Counterfeit (doctored) builds have even been proffered on PlayStore!

    What's more, root permission makes malware particularly potent / dangerous, so BE CAREFUL!

    John Wu's GitHub is now the ONLY official source.
    https://github.com/topjohnwu/Magisk

    Please consider the source of yours.

    Having said that, it is still likely that there is no malware infection to worry about at all. John acknowledges that detection of 'suspicious activity' in relation to a hidden Magisk App / Manager is in fact legitimate due to generated key used to sign the App:

    www.twitter.com/topjohnwu/status/1231114984484065281

    Perhaps coincidentally, John has recently changed the App hiding method. Just out of curiosity, what is you Magisk version? PW
    thanks, i'm using v22.1 then installed canary build on it from this page to pass safetynet , https://github.com/topjohnwu/Magisk ,

    after install there was no problem, just when i changed magisk name to (for example) "magic", avast says it's malware
     
    • Like
    Reactions: pndwal

    zgfg

    Senior Member
  • Oct 10, 2016
    5,290
    2,594
    thanks, i'm using v22.1 then installed canary build on it from this page to pass safetynet , https://github.com/topjohnwu/Magisk ,

    after install there was no problem, just when i changed magisk name to (for example) "magic", avast says it's malware
    Then it probably recognizes the original package name
    com.topjohnwu.magisk, knowing that Magisk apk is not mallware - but it's suspicious about that 'new' root manager with the 'unknown' package name (it doesn't matter that much that you rename the app, but that package name gets obfuscated)
     
    • Like
    Reactions: hamid3pnn

    SaikiK

    Member
    May 29, 2019
    8
    3
    After updating to a.61 from a.59, there was a bootloop ( a.59 was rooted with magisk patched image), but after download a.61 update from realme website and then flashing original boot image, it worked, but my device is no longer rooted and safety net cts profile fails.
    Tried rooting a.61 but there is a boot loop (even though performed same earlier method).
    Device details attached.
    Screenshot_2021-05-07-02-34-00-79.jpg
     

    Top Liked Posts

    • There are no posts matching your filters.
    • 14
      Before anyone freaks out, Google has given John the ok to keep working on Magisk.

      Edit: hmm... John has deleted the tweet stating that he's got the green light from Google in regards to Magisk. Maybe bad news, maybe no news. We'll just have to wait and see...

      Ref:
      https://www.xda-developers.com/magisk-developer-topjohnwu-leaves-apple-joins-google/

      12
      The man needs a break.

      He certainly deserves one in my book. Not a lynch mob.
      John Wu, 2h

      I understand that being the developer of a popular open source project, people are *longing* for an explanation.

      However, the speculation and conspiracy theories are getting out of hand, there are even attempts to sabotage my employment in the name of "saving the community"...

      This is putting extreme strain on me mentally, so let me get the facts straight: nobody really knows exactly how things will go in the future.

      I tweeted an assumption caused by miscommunication; I was informed it to be non factual; I deleted the tweet. That's all, really.

      So please, PLEASE, put down your tinfoil hats and pitchforks, and allow me to handle the situation privately. I will update you once there is a conclusion.

      Nobody is hired to kill off a project.
      I did not join Google for money.
      And of course, I have not betrayed the community.
      www.twitter.com/topjohnwu/status/1394835335096406023

      PW
      8
      there is no access via terminal

      i installed my fave module, debloat, but of course cant access it...they were serious about the lite part :)

      As for the install of lite...i installed the apk and patched a boot img, had no errors

      v4a/vanced youtube doesnt work either, now i really want to die :)

      going to bed finally, in disgust
      Installation of modules works in Magisk Lite but with some additional tricks:

      1) When you install a module from Magisk Lite app, it creates its folder in:
      /data/adb/modules_update

      When you reboot, Lite will not read that folder and the module(s) will not really be installed/updated (instead, they would be next time when you boot to Stable/Beta/Canary/Alpha, because they do read from /data/adb/modules_update)

      Hence:
      - Install one or more modules you need
      - Use MiXplorer (or another root explorer), or terminal and mv command, or rename it by TWRP:
      /data/adb/modules_update
      to:
      /data/adb/lite_modules_update
      -Reboot, Magisk Lite will properly finish installation of your modules and you will find them in:
      /data/adb/lite_modules

      2) MHPC: I successfully installed but in terminal it doesn't recognize the props command.
      Something is wrong with the path

      You can still use MHPC by invoking instead:
      /system/xbin/props

      3) Similarly for BusyBox NDK. It was installed to /system/xbin

      Indeed, you can list all its commands by:
      ls /system/xbin

      4) I have successfully installed Vanced YouTube root (latest v16.16.38) as a module:

      No ads, background playing, all ok

      5) Smali patcher - Safe Screenhot Mode (allowing to screenshot from apps otherwise not allowing the screenshots)

      E.g., I can make screenshots from Chrome Incognito window

      6) If your debloater uses terminal and installs to /system/xbin, you should be able to exploit as explained above for MHPC and BB

      However, I use my own Systemless Debloater that does not use command line interface (terminal):

      and I have successfully debloated all the same 32 system apps as I do with Magisk Stable/Canary/Alpha

      7) I have manually copied hosts folder from:
      /data/adb/modules/
      to:
      /data/adb/lite_modules/

      and got the adblocking work.
      However, Adaway does not know for that folder and if you update/change anything in AdAway, it will write to its regular modules/hosts folder (but you can always copy again the same folder or just its etc/hosts file)

      9) I didn't try with Viper4Android (I'm already back to Magisk Beta with 'regular' modules) but I believe the installation should work the same way I always install it to Stable/Canary:

      And Lite should similarly work for other modules


      I have some issues with MixPlorer though in Magisk Lite (although I completely uninstalled and reinstalled MiXplorer):

      9) MiXploree was granted root and it works but AFTERWARDS Magisk Lite app shows that Magisk is not installed and I simply have to reboot to get Lite properly working again

      10) MiXplorer can only see the stock content in /system/xbin, i e. without props and BusyBox commands (btw, ls from terminal works fine)

      Same for all other folders being overlaid by Magisk systemless mounting - MiXplorer always shows their stock content while terminal su commands work with the Magisk overlaid content


      But altogether, it would be possible to live with Magisk Lite - even the modules work


      Edit:
      I have Magisk apps Canary, Alpha and Lite downloaded and renamed like:
      Magisk-Lite-7717f0a6(23001).apk

      I have also my boot.ing patched by Magisk Canary, Alpha and Lite and renamed like:
      boot-Magisk_Alpha_23001-xiaomi.eu_multi_HMK20MI9T_21.5.20_v12-11.img

      When I want to switch, I simply install the right Magisk apk, flash the corresponding img from TWRP (or Fastboot) and reboot

      When going from Stable/Canary to Aplha/Lite (or vice versa), that previous Magisk app must be uninstalled because of different signatures

      When installing the Alpha or Lite apk I was asked by Play Protect to send the report - I ignored and upon rebooting with Magisk and MagiskHide properly back on, Play Protect was always ok
      8
      From what John has said on Reddit and behind the scenes, recanting on some made statements, he can not touch magisk at all not speak on it anymore.
      Most here are aware of that quote, and as has been pointed out, it was private, he didn't 'say it on Reddit', it was only part of a much longer communication and the 'leak' was not appreciated, but my guess is that many colaborators will be in the loop.
      Since he does own the repositories for magisk so we could see them just disappear. He can't push an update which only he can do, so it's either fork it and go that route, which he knows all the ins and outs of magisk and now works for Google(2+2 says he will spilling the beans on the background to block it), I believe they have him on a gag because conflict of interest with magisk sidestepping their security system.
      I don't think G needs him to spill the beans on 'blocking' Magisk; they're quite aware of how it works. It's source is open, after all...

      But if you meant blocking attestation spoofing / bypassing (MagiskHide, some modules, and other), they already know how to make this foolproof. It does require compliant hardware to implement however, and it seems that when some target percentage of devices have launched with tee, a switch will be flipped, and spoofing attestation, and hence MagiskHide at least outside of userspace (ie bootloader Unlocked / verified boot, will become impossible for practical purposes for most users.

      MagiskHide will still be able to hide root from apps within userspace, but these can still check secure boot status through tee attestation, and will likely report 'root/jailbreak' but actually mean 'insecure boot environment'.

      Expect the pool of those still able to hide bootloader status to be reduced, for practical purposes, to those running custom OSs with inbuilt spoofing or Magisk on devices with launch version < or = to Android 7 (last version without requisite keymaster 3) overnight. (Nb. Hardware-backed Keystore began to be hardened from Android 6)
      https://source.android.com/security/keystore

      Hardware TEE of course, stands for Trusted Execution Environment, and it is not just implemented by Google.

      It actually facilities security in RISC, IBM, AMD, Intel, Apple, as well as Qualcomm, MediaTek, Samsung and Huawei SOCs running various systems. Here's an article focussing on ARM implementation:
      https://embeddedbits.org/introduction-to-trusted-execution-environment-tee-arm-trustzone/

      Interestingly, it states:
      TEE is not the solution to all of our security problems. It is just another layer to make it harder to exploit a vulnerability in the operating system. But nothing is 100% secure.
      You can't work for somewhere and have an ap they completely bypasses their OS without a amjor conflict of interest.
      Well, it doesn't bypass it; it gives superuser access as well as ways to overlay mods on an OS, and both things are certainly allowed by design if bootloader is unlocked.

      There are ways to prevent such unlocking, but Google doesn't do that. That's not to say they don't know how however. That would be laughable; It is their system (both open source Android framework and proprietary apps). They simply leave that to OEMs to implement, and, of course, a number take such measures.
      https://support.google.com/accounts/answer/9211246?hl=en
      Google doesn't even want you using a "modified system" to access your Google account. Google has major issue with root.
      They NEVER said that.

      They have protected their proprietary apps by forbidding bundling GApps with custom ROMs, originally ordering Steve Kondik to 'cease and desist' bundling with CyanogenMod, but offered an olive branch in quick succession when he assumed project was dead, allowing individual users to sideload the same, and sites like OpenGApps to host them.

      They have also expressly stated they DON'T oppose either root or custom ROMs, even recently. Eg from Tech Lead for Android hardware-backed security subsystems:
      Shawn Willden, May 19

      The Platform Security team has never been opposed to modding/rooting (and most of us are firm believers in users' right to own their devices), but remains firmly focused on maximizing security for the 99.99% of users who don't. Root weakens the security model.
      www.twitter.com/shawnwillden/status/1394665579076743175

      In line with the above, they state clearly that if you choose to mod your device, "you lose some of the security protection provided by Google", and they do have recommendations, including "Use a different device for important accounts & sensitive data"
      https://support.google.com/accounts...s-with-modified-rooted-android-versions?hl=en

      Also, rather than prevent their own proprietary apps from running in custom modded systems, they allow these to appear on PlayStore and be used freely. Very few are restricted at all, unless for good (security, corporate partners requirements etc) reason. GPay comes to mind here.

      They could, of course, prevent this (especially when HKA is fully functional), simply by requiring PlayProtect Certified Device, but so far they have PURPOSELY allowed custom modders even with uncertified (Chinese etc) devices to add their devices to their online White List that allows them to run the very GApps (without spoofing) that they were prevented from using w/ stock ROMs.

      This sets an example to others (wish likes of Maccas would wake up), but SafetyNet API and PlayProtect certification are available for apps / code deemed a security risk... Of course, SafetyNet Implementation can be abused, but Google's stance is that the code's author has the right to be informed about the execution environments status and make such decisions.

      Interestingly, it seems not only that Google is unopposed to custom ROMs, but they are not averse to the idea of certifying these / issuing appropriate signing keys so bootloader can be locked to allow full SafetyNet pass (with no spoofing), and GApps can be included legitimately. Of course, this solution evidently precludes root.

      The spiritual successor of CyanogenMod, LineageOS, is in a good position to get such an agreement as they already take pains not to 'subvert Google's security model', never bundling GApps, pre-root, signature spoofing (MicroG would come unstuck here 😉) or any other spoofing mods or techniques. Note this conversation between Shawn and Luca Stefani ('Director for LineageAndroid & Developer'):
      www.twitter.com/shawnwillden/status/1238161446200127488

      That ones been a while (time of initial Google Hardware Key Attestation testing), but I hope we see more on the front. 😛

      In short, Google is against subverting their security model, which includes SafetyNet implementation which ALLOWS code to run in insecure environments (even with superuser privileges) WITHOUT subverting it, by making TEE attestation results available to interested parties. Hardware TEE just ensures that the attestation is accurate... And Google didn't invent it either!

      Here's a bit I posted re. mainstream influence on Google's decision to implement Hardware backed attestation for for verified boot and Trusted Execution Environment:
      https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-83280363

      I don't want to take sides in this; only to give perspective. There's certainly room for many viewpoints. Take what John said on the subject just 4 months ago:
      https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84398495

      ... I wonder what he's thinking now! 😜 PW
      8
      Just want to point out that sharing screenshots of a private conversation isn't cool. The damage is already done and it's out there, but let John himself be the one to break the news.
    • 1050
      This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
      All information, including troubleshoot guides and notes, are in the Announcement Thread
      156
      Hello, I haven't given much support on XDA lately. It can be resulted from
      • University started and I have limited free time. In fact, I mostly develop during midnight
      • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
      • The new version is about to come, I don't want to spend effort on supporting old releases
      The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

      New Forum!
      As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
      **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
      It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

      The Pixel Phone
      Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

      Current Progress
      In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
      To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
      After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

      Safety Net Disaster
      Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
      However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
      I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

      Conclusion
      Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

      Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
      121
      Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

      First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

      -------------------------

      What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

      Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

      He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

      It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
      @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

      tl;dr Towards @topjohnwu, I have:
      - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
      - expressed surprise he is using SuperSU binaries in a competing superuser without permission
      - expressed surprise he is posting a modified LiveBoot without permission
      - informed him of issues with the modified SuperSU he has posted
      - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

      To be crystal clear:
      - I have not asked for an apology
      - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
      - I have not made an issue of any of this anywhere, until this post
      - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
      - I have not reported this thread to XDA moderators for copyright violations or otherwise

      While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

      To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

      I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

      Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
      76
      Thread temporarily closed so everyone sees this.

      The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

      The Flash
      Forum Moderator

      EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
      75
      Hello everyone!

      I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

      Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

      So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

      Google, how will a few systemless mods do any harm :p:p
    Our Apps
    Get our official app!
    The best way to access XDA on your phone
    Nav Gestures
    Add swipe gestures to any Android
    One Handed Mode
    Eases uses one hand with your phone