Magisk General Support / Discussion

Search This thread

HippoMan

Senior Member
May 5, 2009
1,715
551
Hippoland
In case this can't be removed, I would comment about the news from the Magisk Dev on Joining the Android Security Team, as google could say he is using it's priviledged position and internal knowledge to overcome SafetyNet, which could end in MagiskHide demise, although I hope I'm wrong. Google already did nasty stuff, like what they did with the Stadia team.

I share your concern and your hope. I think that now is a good time to fork the github Magisk repo, just in case.
 

73sydney

Senior Member
Jul 21, 2018
1,543
1,252
Sydney
Google Pixel 2 XL

Congrats to John, some people just stand out from the crowd by their demonstration of knowledge, and he richly deserves the recognition

Im not going to make any comment about Magisk itself. We will just have to wait to see how things pan out.

Regardless, thanks John

p.s. At least he ain't working for Big Skivvy anymore :)
 
  • Like
Reactions: Wolfcity and zgfg

olexiiy

Member
Jun 1, 2016
23
5
As you're using CRdroid custom ROM, you may need MagiskHide Props Config to spoof certified fingerprint if ROM doesn't already do this. You need to configure using a terminal emulator, or it does nothing!

You should ONLY use fingerprint function.

With MHPC using a terminal interface you can see what fingerprint ROM already applied. Try changing it any other, but best to use Xiaomi.

You'll need Universal SafetyNet Fix also, regardless of MHPC setting. PW
Yes, I use crDroid 7.6
Yesterday, I found out
photo_2021-05-18_09-09-56.jpg
This patch brokes ctsProfile and certificate (the last six months everything worked with the patch)
Now without patch works. I can't try previous version of rom.
crDroid's maintainer and LuckyPatcher ignore this issue.
I don't know, what is the reason(LP, ROM, Magisk, Google)
 
Last edited:
  • Like
Reactions: pndwal

pndwal

Senior Member
Jun 23, 2016
2,407
1,700
Sydney
Xiaomi Redmi Note 7
My 2 cents:

John's celebrating!

New job with the one phone OS builder that has always allowed modders to customise / root / contribute because of Android Open Source Project, Apache licencing, etc!

The shock and horror was palpable when John landed internship, then permanent position with this OS's main contender. Personally, I wondered 'Why didn't Google snap him up?' Now that it's happened, why be surprised? Or shocked? Or horrified?

As has already been mentioned, SafetyNet pass & continued use of proprietary apps from corporate players & devs who don't want these to run in a custom modded environment (usually, not always, for pretty obvious reasons), is really out of John's hands in any case.

I'm very surprised G has turned a blind eye for so long, and I've commented here on the damage done / effect on market share, of allowing major a competitor to prove to have, or even to be perceived as having a more secure, even impenetrable, platform. Clearly, that's why Samsung came up with Knox, and others have tried to implement similar security measures to align themselves with corporate players and their needs, cognisant of the tide of customers turning to A to fill this need.

In any case, it seems a switch will be flipped at some point when bad vendor Keystore implementations (OnePlus etc) etc are resolved, and Hardware Keystore Attestation rollout finalised. And G will do it, simply because they have a vested interest in stemming the tide.

John said right at the outset of HKA testing (March 2020) not only that it would be impossible (practically) to circumvent, but that he too had been surprised that G had taken so long to implement it.
www.twitter.com/topjohnwu/status/1237656703929180160

Well, they still haven't, but it's not anything John can control in any case... He already said "Let's face it. Fun is over guys"... 14 months later we're still having fun! ... But when the lights do go out, it won't be John flipping the switch.

... or maybe now they'll let him! 😁

Interestingly, John's now on Shawn Willden's team.
www.twitter.com/shawnwillden/status/1394457196021252098

I said previously that I believe Shawn when he says "The Android security team doesn't want to prevent the use of custom ROMs; we're actually quite supportive of that, and do a lot of work to ensure that remains possible".
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-82211559

I can't see G implementing any root prevention either, even if that were possible with AOSP. After all, custom development has been good for Google, root users included.

However, when considering the bottom line, their loyalties are necessarily torn, and they clearly need to strike a balance. Seems to me we've been spared till now while Google has postponed the inevitable HKA, but don't think we're going to be able to continue to have our cake and eat it too, John G, John A, or John Wu!

Anyway, WELL DONE JOHN! A well deserved break! 🎉 🎉 PW
 
Last edited:

romilspm

Member
Jul 3, 2016
5
1
I had the latest magisk. I tried to hide the app (renamed it to something else) and when I tried to restore the app, it can't. And the root is gone-- Said that "Magisk is installed to the external storage. Please move the app to the internal storage. I tried to flash magisk again and there is no change. My root is gone and I can't bring it back. I'd appreciate it if anyone can help me. Thank you.
 

J.Michael

Senior Member
Jan 20, 2018
703
497
Samsung Galaxy Tab A series
I had the latest magisk. I tried to hide the app (renamed it to something else) and when I tried to restore the app, it can't. And the root is gone-- Said that "Magisk is installed to the external storage. Please move the app to the internal storage. I tried to flash magisk again and there is no change. My root is gone and I can't bring it back. I'd appreciate it if anyone can help me. Thank you.
You have not said what your phone is, what versions of Magisk you have used, or how you installed Magisk.

The message about external storage sounds like Android talking about the Magisk Manager app. At that point I would have suggested uninstalling every copy of the Manager app you can find in your app drawer. Look closely, probably no more than one is called Magisk, but you must find and remove all of them.

What, exactly, did you do when you "tried to flash magisk again"?

What makes you say your root is gone? (Where do you look? What do you try to do? How does it fail?)
 

Stillhard

Member
Sep 25, 2016
46
24
Last edited:

pndwal

Senior Member
Jun 23, 2016
2,407
1,700
Sydney
Xiaomi Redmi Note 7
Still, sad to see the retraction.

Watching this space.

This from his new team leader;
Bjoern Kerler, 4h

Did Google just announce integration of magisk aka official root support into Android ? 🥳🍿😁

Shawn Willden, 3h

No, sorry. The Platform Security team has never been opposed to modding/rooting (and most of us are firm believers in users' right to own their devices), but remains firmly focused on maximizing security for the 99.99% of users who don't. Root weakens the security model.
www.twitter.com/shawnwillden/status/1394457196021252098

So, root, but no security circumvention I'm guessing... Mask (overlay), but no masking (spoofing)... (or no mask at all?)

Serious implications for MagiskHide.

Have cake, but can't eat it too... at least no cherry on top... 🙁 PW
 
Last edited:

pndwal

Senior Member
Jun 23, 2016
2,407
1,700
Sydney
Xiaomi Redmi Note 7
I had the latest magisk. I tried to hide the app (renamed it to something else) and when I tried to restore the app, it can't. And the root is gone-- Said that "Magisk is installed to the external storage. Please move the app to the internal storage. I tried to flash magisk again and there is no change. My root is gone and I can't bring it back. I'd appreciate it if anyone can help me. Thank you.
Haven't seen that message, but makes sense. No root apps I've had work on external storage, so if you're using adopted storage SD, or have other separate memory partition (I understand some devices do), Magisk App installed there won't have access to or see root.

Go to Settings, Apps (manage apps) and move Magisk App to internal memory. PW
 
Last edited:

HippoMan

Senior Member
May 5, 2009
1,715
551
Hippoland
What many of us are thinking and feeling about John's having gotten together with the alluring Ms. Google, and thanks to Steely Dan ...

Are you with me Doctor Wu?
Are you really just a shadow
Of the man that I once knew?
She is lovely, yes she's sly,
And you're an ordinary guy.
Has she finally got to you?
Can you hear me Doctor Wu?
Are you with me Doctor Wu?
Can you hear me Doctor Wu?
 
Last edited:
  • Haha
Reactions: pndwal

pndwal

Senior Member
Jun 23, 2016
2,407
1,700
Sydney
Xiaomi Redmi Note 7
One more screenshot circulating around (seems also a published but later removed)

Or, if not made by Photoshop
Well, first here was removed for a reason...

Just reading between the lines, but I'd say private communication is for colaborators at this stage. Makes sense they'd be in the loop.

I'm sure someone, John or someone in loop, will spill beans in due course.

Till then, anybody's guess... Perhaps an ownership change? Couple of Devs come to mind. 😛 PW
 
Last edited:
  • Like
Reactions: 73sydney

Top Liked Posts

  • There are no posts matching your filters.
  • 8
    there is no access via terminal

    i installed my fave module, debloat, but of course cant access it...they were serious about the lite part :)

    As for the install of lite...i installed the apk and patched a boot img, had no errors

    v4a/vanced youtube doesnt work either, now i really want to die :)

    going to bed finally, in disgust
    Installation of modules works in Magisk Lite but with some additional tricks:

    1) When you install a module from Magisk Lite app, it creates its folder in:
    /data/adb/modules_update

    When you reboot, Lite will not read that folder and the module(s) will not really be installed/updated (instead, they would be next time when you boot to Stable/Beta/Canary/Alpha, because they do read from /data/adb/modules_update)

    Hence:
    - Install one or more modules you need
    - Use MiXplorer (or another root explorer), or terminal and mv command, or rename it by TWRP:
    /data/adb/modules_update
    to:
    /data/adb/lite_modules_update
    -Reboot, Magisk Lite will properly finish installation of your modules and you will find them in:
    /data/adb/lite_modules

    2) MHPC: I successfully installed but in terminal it doesn't recognize the props command.
    Something is wrong with the path

    You can still use MHPC by invoking instead:
    /system/xbin/props

    3) Similarly for BusyBox NDK. It was installed to /system/xbin

    Indeed, you can list all its commands by:
    ls /system/xbin

    4) I have successfully installed Vanced YouTube root (latest v16.16.38) as a module:

    No ads, background playing, all ok

    5) Smali patcher - Safe Screenhot Mode (allowing to screenshot from apps otherwise not allowing the screenshots)

    E.g., I can make screenshots from Chrome Incognito window

    6) If your debloater uses terminal and installs to /system/xbin, you should be able to exploit as explained above for MHPC and BB

    However, I use my own Systemless Debloater that does not use command line interface (terminal):

    and I have successfully debloated all the same 32 system apps as I do with Magisk Stable/Canary/Alpha

    7) I have manually copied hosts folder from:
    /data/adb/modules/
    to:
    /data/adb/lite_modules/

    and got the adblocking work.
    However, Adaway does not know for that folder and if you update/change anything in AdAway, it will write to its regular modules/hosts folder (but you can always copy again the same folder or just its etc/hosts file)

    9) I didn't try with Viper4Android (I'm already back to Magisk Beta with 'regular' modules) but I believe the installation should work the same way I always install it to Stable/Canary:

    And Lite should similarly work for other modules


    I have some issues with MixPlorer though in Magisk Lite (although I completely uninstalled and reinstalled MiXplorer):

    9) MiXploree was granted root and it works but AFTERWARDS Magisk Lite app shows that Magisk is not installed and I simply have to reboot to get Lite properly working again

    10) MiXplorer can only see the stock content in /system/xbin, i e. without props and BusyBox commands (btw, ls from terminal works fine)

    Same for all other folders being overlaid by Magisk systemless mounting - MiXplorer always shows their stock content while terminal su commands work with the Magisk overlaid content


    But altogether, it would be possible to live with Magisk Lite - even the modules work


    Edit:
    I have Magisk apps Canary, Alpha and Lite downloaded and renamed like:
    Magisk-Lite-7717f0a6(23001).apk

    I have also my boot.ing patched by Magisk Canary, Alpha and Lite and renamed like:
    boot-Magisk_Alpha_23001-xiaomi.eu_multi_HMK20MI9T_21.5.20_v12-11.img

    When I want to switch, I simply install the right Magisk apk, flash the corresponding img from TWRP (or Fastboot) and reboot

    When going from Stable/Canary to Aplha/Lite (or vice versa), that previous Magisk app must be uninstalled because of different signatures

    When installing the Alpha or Lite apk I was asked by Play Protect to send the report - I ignored and upon rebooting with Magisk and MagiskHide properly back on, Play Protect was always ok
    8
    From what John has said on Reddit and behind the scenes, recanting on some made statements, he can not touch magisk at all not speak on it anymore.
    Most here are aware of that quote, and as has been pointed out, it was private, he didn't 'say it on Reddit', it was only part of a much longer communication and the 'leak' was not appreciated, but my guess is that many colaborators will be in the loop.
    Since he does own the repositories for magisk so we could see them just disappear. He can't push an update which only he can do, so it's either fork it and go that route, which he knows all the ins and outs of magisk and now works for Google(2+2 says he will spilling the beans on the background to block it), I believe they have him on a gag because conflict of interest with magisk sidestepping their security system.
    I don't think G needs him to spill the beans on 'blocking' Magisk; they're quite aware of how it works. It's source is open, after all...

    But if you meant blocking attestation spoofing / bypassing (MagiskHide, some modules, and other), they already know how to make this foolproof. It does require compliant hardware to implement however, and it seems that when some target percentage of devices have launched with tee, a switch will be flipped, and spoofing attestation, and hence MagiskHide at least outside of userspace (ie bootloader Unlocked / verified boot, will become impossible for practical purposes for most users.

    MagiskHide will still be able to hide root from apps within userspace, but these can still check secure boot status through tee attestation, and will likely report 'root/jailbreak' but actually mean 'insecure boot environment'.

    Expect the pool of those still able to hide bootloader status to be reduced, for practical purposes, to those running custom OSs with inbuilt spoofing or Magisk on devices with launch version < or = to Android 7 (last version without requisite keymaster 3) overnight. (Nb. Hardware-backed Keystore began to be hardened from Android 6)
    https://source.android.com/security/keystore

    Hardware TEE of course, stands for Trusted Execution Environment, and it is not just implemented by Google.

    It actually facilities security in RISC, IBM, AMD, Intel, Apple, as well as Qualcomm, MediaTek, Samsung and Huawei SOCs running various systems. Here's an article focussing on ARM implementation:
    https://embeddedbits.org/introduction-to-trusted-execution-environment-tee-arm-trustzone/

    Interestingly, it states:
    TEE is not the solution to all of our security problems. It is just another layer to make it harder to exploit a vulnerability in the operating system. But nothing is 100% secure.
    You can't work for somewhere and have an ap they completely bypasses their OS without a amjor conflict of interest.
    Well, it doesn't bypass it; it gives superuser access as well as ways to overlay mods on an OS, and both things are certainly allowed by design if bootloader is unlocked.

    There are ways to prevent such unlocking, but Google doesn't do that. That's not to say they don't know how however. That would be laughable; It is their system (both open source Android framework and proprietary apps). They simply leave that to OEMs to implement, and, of course, a number take such measures.
    https://support.google.com/accounts/answer/9211246?hl=en
    Google doesn't even want you using a "modified system" to access your Google account. Google has major issue with root.
    They NEVER said that.

    They have protected their proprietary apps by forbidding bundling GApps with custom ROMs, originally ordering Steve Kondik to 'cease and desist' bundling with CyanogenMod, but offered an olive branch in quick succession when he assumed project was dead, allowing individual users to sideload the same, and sites like OpenGApps to host them.

    They have also expressly stated they DON'T oppose either root or custom ROMs, even recently. Eg from Tech Lead for Android hardware-backed security subsystems:
    Shawn Willden, May 19

    The Platform Security team has never been opposed to modding/rooting (and most of us are firm believers in users' right to own their devices), but remains firmly focused on maximizing security for the 99.99% of users who don't. Root weakens the security model.
    www.twitter.com/shawnwillden/status/1394665579076743175

    In line with the above, they state clearly that if you choose to mod your device, "you lose some of the security protection provided by Google", and they do have recommendations, including "Use a different device for important accounts & sensitive data"
    https://support.google.com/accounts...s-with-modified-rooted-android-versions?hl=en

    Also, rather than prevent their own proprietary apps from running in custom modded systems, they allow these to appear on PlayStore and be used freely. Very few are restricted at all, unless for good (security, corporate partners requirements etc) reason. GPay comes to mind here.

    They could, of course, prevent this (especially when HKA is fully functional), simply by requiring PlayProtect Certified Device, but so far they have PURPOSELY allowed custom modders even with uncertified (Chinese etc) devices to add their devices to their online White List that allows them to run the very GApps (without spoofing) that they were prevented from using w/ stock ROMs.

    This sets an example to others (wish likes of Maccas would wake up), but SafetyNet API and PlayProtect certification are available for apps / code deemed a security risk... Of course, SafetyNet Implementation can be abused, but Google's stance is that the code's author has the right to be informed about the execution environments status and make such decisions.

    Interestingly, it seems not only that Google is unopposed to custom ROMs, but they are not averse to the idea of certifying these / issuing appropriate signing keys so bootloader can be locked to allow full SafetyNet pass (with no spoofing), and GApps can be included legitimately. Of course, this solution evidently precludes root.

    The spiritual successor of CyanogenMod, LineageOS, is in a good position to get such an agreement as they already take pains not to 'subvert Google's security model', never bundling GApps, pre-root, signature spoofing (MicroG would come unstuck here 😉) or any other spoofing mods or techniques. Note this conversation between Shawn and Luca Stefani ('Director for LineageAndroid & Developer'):
    www.twitter.com/shawnwillden/status/1238161446200127488

    That ones been a while (time of initial Google Hardware Key Attestation testing), but I hope we see more on the front. 😛

    In short, Google is against subverting their security model, which includes SafetyNet implementation which ALLOWS code to run in insecure environments (even with superuser privileges) WITHOUT subverting it, by making TEE attestation results available to interested parties. Hardware TEE just ensures that the attestation is accurate... And Google didn't invent it either!

    Here's a bit I posted re. mainstream influence on Google's decision to implement Hardware backed attestation for for verified boot and Trusted Execution Environment:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-83280363

    I don't want to take sides in this; only to give perspective. There's certainly room for many viewpoints. Take what John said on the subject just 4 months ago:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84398495

    ... I wonder what he's thinking now! 😜 PW
    8
    That is the most wrong statement. If Google didn't has no issues with having root, there would not magsikhide. Just that statement alone conflicts with itself. MagiskHide hides root... Google has a problem with hiding root and not root, then why hide it? Why is there basic attention and cts profile check? Now a hardware check? Root, on Android is what they don't want, or else there would be no need for a modified kernel, we would all have root like on Linux desktop... Any terminal on desktop has root instantly, Android doesn't.. They did pretty damn good job of taking something away they wanted to have all along right? Wow.
    This whole discussion took a bit of a turn, and I'm not gonna get further into that. But, you might want to reread what I said again: "Google has no interest in preventing root". That statement doesn't say anything on how Google think about root in security terms (and I'm talking about the Google security team here, which John now is a part of).

    We're talking about different things, I believe...

    You're talking about the security aspect, which Google cracks down on (since generally, rooting a device compromises the systems security), and I'm talking about just being able to root your device regardless of if SafetyNet triggers or not.

    If they wanted to, Google could make it so much harder (impossible?) to root your Android device... From statements I've seen from Google security team members, that's not on their agenda. But of course, beefing up the security on Android in general might have the unfortunate side effect of accomplishing the same thing.
    7
    Is this a bug or a feature?
    Feature, and has been like that since very early in Magisk's history. Magic mounting files and folders to the root of /system, that doesn't previously exist there, can cause all kinds of weird issues.
    7
    FWIW, as there is no news of updated Magisk from John Wu, I'm now running Alpha Magisk and Magisk App from dev @vvb2060 (Nangong Xueshan).

    Seems his App maintains connection to standard Stable / Beta / Canary channels from topjohnwu, but adds his Alpha (Bleeding edge) channel:
    https://github.com/vvb2060/magisk_files/tree/alpha

    Click View code, Download / install app-release.apk 👍

    Screenshot_2021-05-29-17-24-43-651_com.topjohnwu.magisk.jpg


    No problems running this Alpha so far. 👍

    - Nb. Unhide Magisk App if changing to this. Conflict with hidden Apps are still occurring.

    Alpha adds new / experimental commits. Some of these already have pull requests in John's Magisk GitHub.

    Nb. John Wu recently changed his description of debug Canary builds from 'Bleeding Edge' to 'Cutting Edge'...

    WARNING

    If you move to Nangong Xueshan's Alpha, my advice is to consider yourself on the Bleeding Edge again... and to understand what this means!

    Changelog for Alpha, next post. PW
  • 1050
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p