• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
I had the latest magisk. I tried to hide the app (renamed it to something else) and when I tried to restore the app, it can't. And the root is gone-- Said that "Magisk is installed to the external storage. Please move the app to the internal storage. I tried to flash magisk again and there is no change. My root is gone and I can't bring it back. I'd appreciate it if anyone can help me. Thank you.
Haven't seen that message, but makes sense. No root apps I've had work on external storage, so if you're using adopted storage SD, or have other separate memory partition (I understand some devices do), Magisk App installed there won't have access to or see root.

Go to Settings, Apps (manage apps) and move Magisk App to internal memory. PW
 
Last edited:

pndwal

Senior Member
It's sad that magsik won't get any updates by its lead developer. :(
Early days, but I hope at least reins can be passed on to someone with no conflicting interests ...

Still, may be fight left in John yet; he does have a (HUGE) vested interest after all! 😬 PW
Tom-Jerry-tom-and-jerry-bed.gif
 
Last edited:
  • Like
Reactions: AndDiSa

HippoMan

Senior Member
May 5, 2009
1,737
587
Hippoland
What many of us are thinking and feeling about John's having gotten together with the alluring Ms. Google, and thanks to Steely Dan ...

Are you with me Doctor Wu?
Are you really just a shadow
Of the man that I once knew?
She is lovely, yes she's sly,
And you're an ordinary guy.
Has she finally got to you?
Can you hear me Doctor Wu?
Are you with me Doctor Wu?
Can you hear me Doctor Wu?
 
Last edited:
  • Haha
Reactions: pndwal

pndwal

Senior Member
One more screenshot circulating around (seems also a published but later removed)

Or, if not made by Photoshop
Well, first here was removed for a reason...

Just reading between the lines, but I'd say private communication is for colaborators at this stage. Makes sense they'd be in the loop.

I'm sure someone, John or someone in loop, will spill beans in due course.

Till then, anybody's guess... Perhaps an ownership change? Couple of Devs come to mind. 😛 PW
 
Last edited:
  • Like
Reactions: 73sydney

HippoMan

Senior Member
May 5, 2009
1,737
587
Hippoland
I share your concern and your hope. I think that now is a good time to fork the github Magisk repo, just in case.
I have now performed the fork, as well as some offline backups. However, I don't have nearly enough spare time to work on Magisk, nor do I have nearly the amount of qualifications that John has.

Let's more of us get forking.
 

pndwal

Senior Member
The man needs a break.

He certainly deserves one in my book. Not a lynch mob.
John Wu, 2h

I understand that being the developer of a popular open source project, people are *longing* for an explanation.

However, the speculation and conspiracy theories are getting out of hand, there are even attempts to sabotage my employment in the name of "saving the community"...

This is putting extreme strain on me mentally, so let me get the facts straight: nobody really knows exactly how things will go in the future.

I tweeted an assumption caused by miscommunication; I was informed it to be non factual; I deleted the tweet. That's all, really.

So please, PLEASE, put down your tinfoil hats and pitchforks, and allow me to handle the situation privately. I will update you once there is a conclusion.

Nobody is hired to kill off a project.
I did not join Google for money.
And of course, I have not betrayed the community.
www.twitter.com/topjohnwu/status/1394835335096406023

PW
 
Last edited:

razes

Member
Sep 13, 2016
29
0
I'm trying to install Magisk 22.1 on my Samsung Galaxy S5 Marshmallow. I had before Magisk 20.4 and Magisk Manager (App) 8.0.4. I have updated TWRP recovery up to TWRP 3.5.1_9-0-klte
I've installed MAgisk 22.1 via TWRP as apk not as a zip file.
Everything was smoothly. I was able to reboot to the system. However, once I've open the MAgisk App, the App suggested to finish installation and to install some additional files. I did not follow that suggestion. So, after that the MAgisk version was 22.1, and MAgisk App version 8.0.4. I have updated the App version up to the last version 23.0. However, after the update the MAgisk seems to me stopped to recognize the version 22.1 (see screenshot).
So, what can I do now? Uninstall the MAgisk app from the phone Settings and reflash the 22.1 in recovery again and to follow the App suggestion to install additional files after reboot? Or should I completely uninstall MAgisk in TWRP and start from the scratch then? In such situation will I able to keep the root or I should root the phone again?
 

Attachments

  • Screenshot_Magisk.png
    Screenshot_Magisk.png
    126.2 KB · Views: 43

zgfg

Senior Member
Oct 10, 2016
6,088
3,591
I'm trying to install Magisk 22.1 on my Samsung Galaxy S5 Marshmallow. I had before Magisk 20.4 and Magisk Manager (App) 8.0.4. I have updated TWRP recovery up to TWRP 3.5.1_9-0-klte
I've installed MAgisk 22.1 via TWRP as apk not as a zip file.
Everything was smoothly. I was able to reboot to the system. However, once I've open the MAgisk App, the App suggested to finish installation and to install some additional files. I did not follow that suggestion. So, after that the MAgisk version was 22.1, and MAgisk App version 8.0.4. I have updated the App version up to the last version 23.0. However, after the update the MAgisk seems to me stopped to recognize the version 22.1 (see screenshot).
So, what can I do now? Uninstall the MAgisk app from the phone Settings and reflash the 22.1 in recovery again and to follow the App suggestion to install additional files after reboot? Or should I completely uninstall MAgisk in TWRP and start from the scratch then? In such situation will I able to keep the root or I should root the phone again?
Uninstall all versions of Magisk apk or manager, specially if you have hiden/renamed one

Then install the latest Manager apk v23. And generally, whenever asked, finish the requested installation
 

ChewyLouis

New member
May 16, 2021
3
1
Hi guys,
i have a problem when trying to install the magisk_patched-xxx.img
The latest LineageOS (16.05.) and Magisk App (23) is installed. I'm on Oneplus 7 Pro.

When i'm in Lineage Recovery > Advanced FastbootD
and enter this command via cmd:

fastboot flash boot /path/to/magisk_patched.img

I always get this Error

sending 'boot' (98304 KB)...
OKAY [ 2.200s]
writing 'boot'...
FAILED (remote: No such file or directory)
finished. total time: 2.250s

Does anyone know how to fix this?
Thanks in advance, you guys are great! :)
 

pndwal

Senior Member
Hi guys,
i have a problem when trying to install the magisk_patched-xxx.img
The latest LineageOS (16.05.) and Magisk App (23) is installed. I'm on Oneplus 7 Pro.

When i'm in Lineage Recovery > Advanced FastbootD
and enter this command via cmd:

fastboot flash boot /path/to/magisk_patched.img

I always get this Error

sending 'boot' (98304 KB)...
OKAY [ 2.200s]
writing 'boot'...
FAILED (remote: No such file or directory)
finished. total time: 2.250s

Does anyone know how to fix this?
Thanks in advance, you guys are great! :)
I don't know about advanced fastboot flash mode in LOS Recovery, but John no longer recomends using custom Recovery due to inherent problems custom recovery can introduce. So there's no guarantees here:
installing Magisk through custom recoveries on modern devices is no longer recommended. If you face any issues, please use the Patch Image method as it is guaranteed to work 100% of the time.
https://topjohnwu.github.io/Magisk/install.html#custom-recovery

Looks like your device is failing to find boot partition. Perhaps Recovery mode is not calling / switching to Fastboot mode properly, or other problem.

For official method, you need adb drivers on PC, img file in PC adb directory, phone in fastboot mode ('boot to bootloader') connected with usb, execute 'fastboot flash boot magisk_patched_boot.img'

Use of Custom Recovery is NOT part of Patch Image method referred to here:
https://topjohnwu.github.io/Magisk/install.html#patching-images

🤠 PW
 
Last edited:

HippoMan

Senior Member
May 5, 2009
1,737
587
Hippoland
This is insanity

So many panic merchants

*sigh*
John himself accidentally caused the panic to increase. He said, "I tweeted an assumption caused by miscommunication; I was informed it to be non factual; I deleted the tweet. That's all, really."

I'm glad it was a miscommunication, and I'm glad the tweet was deleted. Let's just see what happens over time.
 

ChewyLouis

New member
May 16, 2021
3
1
I don't know about advanced fastboot flash mode in LOS Recovery, but John no longer recomends using custom Recovery due to inherent problems custom recovery can introduce. So there's no guarantees here:

https://topjohnwu.github.io/Magisk/install.html#custom-recovery

Looks like your device is failing to find boot partition. Perhaps Recovery mode is not calling / switching to Fastboot mode properly, or other problem.

For official method, you need adb drivers on PC, img file in PC adb directory, phone in fastboot mode ('boot to bootloader') connected with usb, execute 'fastboot flash boot magisk_patched_boot.img'

Use of Custom Recovery is NOT part of Patch Image method referred to here:
https://topjohnwu.github.io/Magisk/install.html#patching-images

🤠PW

Thx for your fast reply,

when i follow the official method at first in cmd it looks like everything is working.
cmd.jpeg


But after reboot nothing changed.
img.jpeg
 
  • Like
Reactions: J.Michael

Top Liked Posts

  • 3
    Latest Alpha Magisk (Unofficial)
    Translated:

    # alpha update log

    ## Magisk (0f71edee-alpha)
    -[App] Support SharedUserId
    -[App] Delete the backup file after restoring the boot image
    -[App] Built-in current version update log
    -[App] Use local version when unable to download stub
    -[App] Switch to Java 8 Modern Time API
    -[General] No longer automatically unlock the device block
    -[General] Use MagiskHide to hide when Zygisk is closed
    -[App] Delete markdown rendering
    -[General] Do not execute scripts that have ignored loading modules
    -[App] Fix Magisk cannot be updated from notification
    -[App] Fix that the second time tapping the hidden app button may be unresponsive
    -[App] Fix the effective time of signing certificate
    -[App] Enable network request caching
    -[App] Rewrite install application function
    -[App] Enhance the function of repairing environment
    -[App] Fix that some processes in the exclusion list may not be displayed
    -[App] Support setting the KEEPVBMETAFLAG flag to skip processing vbmeta in the boot image
    -[Zygisk] Fix Xhook

    👍 PW
    2
    So I assume I've got the right lsposed version as the mocking works where it didn't before (I just got a could not find location error 12 in pogo). Whenever I remove Pokemon from the deny list, it pops up again complaining about the OS not being compatible/supported.

    What folders or files should I look out for? As far as I know I've gotten rid of any Magisk related stuff...
    Make sure you are using Magisk and not some custom version.
    Enable zygisk, enforce deny list, and add what is necessary in denylist (I only have my work stuff denied, not PoGo)
    Then use Lsposed zygisk version (you need to download this from telegram, if you didn't, you probably have the wrong version).
    Then use mock mock, and check pogo.

    PoGo will look for any files that suggest magisk (make sure this is hidden as well!), or any custom recovery folders.
    If you had used backup restore when you started using your P6P, you it may have transfered some old files from your old phone. The other thing is whether you hid your mocking app. If you are using it directly as downloaded, PoGo may be looking for the package name.

    I'm not sure whether you actually need to pass SafetyNet for PoGo now. Previously on A11, you didn't. I only have 3 modules in magisk - systemless, USFN and Zygisk Lsposed. If you add anything else, you may be inadvertantly tripping PoGo detection.

    That's it. I have this setup running on A12 P6P and P4XL and P2XL (A11). Not sure if anyone else has similar experience, or if it's not working for others?
    2
    Nb. New Alpha Magisk has Xhook fix merged (Not yet in TJW Magisk downstream:
    https://github.com/topjohnwu/Magisk/pull/5010 ) so supports new Zygisk hide solution which is "Shadow Mistress Yuko: Hide for zygisk".

    New Shadow Mistress Yuko is also available. Shamiko-v0.1.2-47-release zip

    😝 PW
    1
    Trying with 0f71edee-alpha (23015) but Shamiko reports that Magisk is somewhat broken and Momo still finds Zygisk

    All other things work for me (SafetyNet hence DenyList and Zygisk, Superuser grants, modules - and of course, I do testing without Riru)

    PS: Tested also with all other modules disabled, still Shamiko reports the same error and fails to hide Zygisk

    EDIT:
    With the updated:
    Shamiko-v0.1.2-47-release.zip
    It worked!!!
    Updated to Shamiko 47 and it works:
    - Enforce and Configure DenyList
    - Install Shamiko
    - Disable DenyList - Shamiko takes over, DenyList will work although disabled in Magisk app

    Then Momo does no more find Zygisk while SafetyNet still passes (I have two other apps that I had to add to DenyList and they also don't complain about root)
  • 37
    I've been following the thread for a long time now, and I think some users are still confused regarding the differences between the different variants of Magisk that are available for use. I'm going to try and summarize them here, which should be helpful for everyone:

    Magisk Variant​
    Stable​
    Canary​
    Alpha​
    Custom​
    Release
    Official​
    Official​
    Unofficial​
    Unofficial​
    Maintainer
    topjohnwu​
    topjohnwu​
    vvb2060​
    TheHitMan7​
    Project Link
    Zygisk
    No​
    Yes​
    Yes​
    Yes​
    DenyList
    No​
    Yes​
    Yes​
    No​
    MagiskHide
    Yes​
    No​
    Yes*​
    Yes​
    Modules Repo
    Yes​
    No​
    No​
    Yes​
    Download Link

    *If you turn off Zygisk in Alpha, then DenyList will act like MagiskHide. So essentially, you can have Zygisk On + DenyList or Zygisk Off + DenyList running as MagiskHide.

    In case I've gotten something wrong, or can add more information, please let me know. :) Cheers!
    13
    Great guide, thanks... I think I followed a similar guide from you a while back, but forgot full path requirement... Pinged you as I thought you'd come through! 👍

    I didn't say MagiskBoot was part of Magisk binary however... I clearly said 'magiskboot * binary * isn't working for me'. 😜 ...

    Thanks for the method. PW
    This one might be a bit more confusing. ;)

    Not sure I can operate Magiskboot before I flash it to the device. Once I flash Magisk, I have access to fastboot through recovery, and that's it.
    While catching up last night, I missed that you are not rooted. :oops:

    ---

    Without root, you need a directory with heightened permissions that you can access.

    You should be able to use the /data/local/tmp/ directory.

    Unzip the Magisk apk file and push the appropriate architecture to the device.
    Then set the permissions to be executable.

    Linux/Mac command line example.
    Make the appropriate changes if you use Windows.​
    • Unpack the lib directory from the Magisk apk file.
      unzip app-debug.apk lib*
    • Push the matching Magisk architecture to the device.
      adb push lib/YourDeviceArchitecture/* /data/local/tmp/
    • Push the boot image you want to modify to the device.
      adb push boot.img /data/local/tmp/
    • Set permissions.
      adb shell chmod 0755 /data/local/tmp/*.so
    • Enter adb shell and change directories.
      adb shell
      cd /data/local/tmp/
    • Run the commands using the ./ prefix.
      ./libmagiskboot.so

    Make the changes you want, exit the shell and pull the new-boot image to the computer.
    Reboot into bootloader and boot the new-boot image.

    Note:
    /data/local/tmp/ should be an empty directory.
    You should clear the directory after you are done using it. ;)


    Quick example just unpacking and repacking a boot image without root.
    Magiskboot Example - Pastebin - Link

    Hope it helps more than confuse. 🙃

    Cheers. :cowboy:
    12
    Hi all. :D

    I do not use twitter so, I am out of the loop at times. :confused:
    Links to a few tweets were noted in an issue on USNF github earlier today.

    Seemed to be appropriate to mention here.

    From John Wu.
    PSA: MagiskHide of Magisk v23.0 no longer passes SafetyNet, even with BASIC evalType. Tested on my Pixel 4 XL running stock Android 12 with vanilla Magisk v23.0.

    MagiskHide is *officially* dead. If you need any kind of root hiding, it's the perfect time to find alternatives.
    There are already plenty of "root hiding" modules out there that I'm aware of, some even utilizing the latest features of Magisk canary.

    I'm obligated to distance myself from any tamper detection circumvention, so I will not assist/promote any modules. Do your own research 🙃

    From osm0sis
    *Cough* @kdrag0n's Universal SafetyNet Fix (USNF) *Cough* 😘
    To be specific, Magisk Canary, Zygisk and DenyList enabled, and USNF v2.2.0+ is the way forward. 🤘

    Cheers all. :cowboy:
    10

    Latest Magisk Canary:​

    Magisk (7e9d4512) (23014)​

    • Fix crashes when multiple Zygisk module is installed
    • Fix crashes in magiskboot under certain circumstances
    • Always unload Zygisk itself after post specialize
    • Add module suspension state in Magisk app (riru/zygisk modules)

    Diffs to v23.0​

    • [General] MagiskHide is removed from Magisk
    • [General] Support 64-bit only systems
    • [General] Support Android 12
    • [Zygisk] Introduce new feature: Zygisk
    • [Zygisk] Introduce DenyList feature to revert Magisk features in user selected processes
    • [MagiskBoot] Support patching 32-bit kernel zImages
    • [MagiskBoot] Support boot image header v4
    • [MagiskBoot] Support patching out skip_initramfs from dtb bootargs
    • [MagiskInit] Support /proc/bootconfig for loading boot configurations
    • [MagiskInit] Better support for some Meizu devices
    • [MagiskInit] Better support for some Oppo/Realme devices
    • [MagiskInit] Support init.real on some Sony devices
    • [MagiskPolicy] Load *_compat_cil_file from system_ext
    • [MagiskSU] Use isolated devpts if the kernel supports it
    • [MagiskSU] Fix root shell if isolated mount namespace is set
    • [resetprop] Deleted properties are now wiped from memory instead of just unlinking
    • [App] Build a single APK for all ABIs
    • [App] Switch to use standard bottom navigation bar
    • [App] Downloading modules within the Magisk app is removed
    https://github.com/topjohnwu/magisk-files/blob/55bdc45955e7ba1fe4d296b6fc06f926ebc9ddd1/notes.md
    👍 PW
    10
    Gents, as grateful I am for all above substantial contributions I hope you allow me to express my "wonder"... As you all know off-topic posts (unless violating forum rules) are only removed on request of the threadowner, I'm just surprised that extremely experienced and knowledgable XDA users allow this thread to deviate from its subject.
    Just as an idea for similar "occasions" in future, hadn't it been better to simply point somebody to the well known subject matter related ad blocker threads? Okay, unexperienced members should certainly question themselves why they post off-topic in a thread. After the initial serious problems with the in-XDA-search, I meanwhile must say it's working excellent for me.

    And by the way: I've removed the link to paid applications as not being accepted on XDA. Please don't mind.

    Regards
    Oswald Boelcke
    Senior Moderator
  • 1070
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p