• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
Oh, init.rc modification is also detected. The others are not detected.

And yes, I keep clearing MagiskDetector data.
And you have empty files for ALL four options in MomoHider config folder?
- create an empty file named for each option used (I have all enabled), and place these in existing
/data/adb/modules/riru_momohider/config folder (no extension, mine have rw-rw-rw- permission)
[Options: isolated, setns, app_zygote_magic, initrc]
PW
 
  • Like
Reactions: J.Michael

DiamondJohn

Recognized Contributor
Aug 31, 2013
5,542
5,286
Sydney
This thread was General, and it included Stable, Beta and Canary versions - all three were maintained by TJW.
Now, when he started to work for Google, it is unclear when and from whom can we expect the new release(s)

If, then maybe from wb2060, and based on his Alpha version (upstream commits to Canary) - in the past he also provided certain important fixes and some of them were also available for pre-testing from his Github (I think, it was also his Alpha), before they would be incorporated to TJW"s Canary

Maybe this thread becomes obsolete in the future, frozen for TJW Magisk up to v23, who knows...

Magisk Detector discussion is about the general issues, certain banking apps that detect the Magisk. Magisk Lite is maybe in that direction (if wb2060 ever decides to release some kind of 'official' release)

Unfortunately, TJW long ago distracted himself from XDA and wb2060 was never a member here
Just because development stops on any artifact, does noit mean the thread should be closed. Just think of an app that development may end on, but its use continues.

Where I was going, is that this new development ios sooooo different to the existing Magisk (inc alpha, canary and stable Magisk), I know I personally find it more time consuming to ignore the posts which have nothing to do with the existing Magisk. I see it kind of like starting a new thread for a different android version (eg A10 to A11) even though its the same dev. I think people who are looking at the exiusting Magisk could come here and those looking for the future (ie beyond the existing canary Magisk) culd be better served on a different thread. It gets condusing for simple folk like me to have to read few paragraphs to ensure there ois nothing pertinent or appli9cable to the existing Magisk. One of the real problems is who will start the threaad considering the actual dev is not present on XDA.
 

pndwal

Senior Member
Yes. I stated that above.
Ok, sorry... so seems mileage varies per device...

I had read it was particularly difficult to hide isolated processes on Xiaomi, so I was chuffed to have all MagiskDetector items undetected...

Just thinking on 'system file(s) are modified by Magisk module', I'm now thinking that means a module may be responsible...

I'm not certain how a module may do this, bit I am aware that if modules are installed via custom recovery (some can work this way) they can / often do actually alter the system partition...

So I'm thinking it may be worth 1) Disabling modules to test, and 2) if you think system mods may have been done, consider how to reverse these (by proper custom recovery uninstall, or by flashing system image?).

Of course, I'm just thinking out loud in case it helps... I may be on the wrong tangent here completely...

Any other ideas on what accounts for 'system file(s) are modified by Magisk module' detected? anyone? PW
 

zgfg

Senior Member
Oct 10, 2016
5,721
3,174
Where I was going, is that this new development ios sooooo different to the existing Magisk (inc alpha, canary and stable Magisk), I know I personally find it more time consuming to ignore the posts which have nothing to do with the existing Magisk. I see it kind of like starting a new thread for a different android version (eg A10 to A11) even though its the same dev. I think people who are looking at the exiusting Magisk could come here and those looking for the future (ie beyond the existing canary Magisk) culd be better served on a different thread. It gets condusing for simple folk like me to have to read few paragraphs to ensure there ois nothing pertinent or appli9cable to the existing Magisk.
It was (and still is), Stable, Beta (not Alpha) and Canary as Magisk versions from TJW as it easily shows in Update Channel (screenshot)

And unfortunately, discussion about Magisk Detector and how to pass was started by guys having problems with certain e.g. banking apps that detect Magisk and refuse to use them (although basic checks like SafetyNet pass and MagiskHide is properly enabled), hence it applies to Magisk in the sense: how to use Magisk but also to properly hide it from apps, and what is missing in Magisk in that regard (e.g., su can be found in the path, modifications of init.rc are detectable)

Hence it's IMO disputable if that discussion belongs or not to this thread - if not, then certainly all similar discussions in the past about USNF, MHPC and similar were also not applicable to this thread, and similarly everything about OTA, TWRPs, etc, as well
 

Attachments

  • IMG_20210603_154839.jpg
    IMG_20210603_154839.jpg
    42.2 KB · Views: 21
Last edited:
  • Like
Reactions: J.Michael

Stillhard

Senior Member
Sep 25, 2016
56
29
And many thanks for suggesting this module!

I think MagiskHide is sorted, at least for my Xiaomi device (Stock RN8T, Alpha Magisk) 😛 :

View attachment 5328287

A bit regarding configuration seems to be lost in translation on its GitHub, so did a little googling.

My setup:
- Install riru_momohider module
- Disable 'Riru - Enhanced mode for Magisk Hide', riru-unhide module (if have it)
- create an empty file named for each option used (I have all enabled), and place these in existing
/data/adb/modules/riru_momohider/config folder (no extension, mine have rw-rw-rw- permission)
[Options: isolated, setns, app_zygote_magic, initrc]
- MagiskDetector in MagiskHide list
- Clear MagiskDetector data
- Reboot

Nb. Only MagiskDetector items 1 & 5 (as per SS above) were being detected before this.

@HippoMan, I'm interested if this solution will solve item 2 detection for you, but guessing you may need to resolve this separately.

Also interested to hear if, with each MagiskDetector item undetected, anyone with Bank App detecting root has success with these... or it there are unlisted methods extant.

Hope it helps! 🎉 PW
Glad to see you've sorted it out.
Recently i was involved with the development (a lot communications with canyie - the developer (reporting issues and send logs privately)). He's a real nice person as a developer.
I hope all his work can help us to overcome the missing pieces in Magisk.
 
  • Like
Reactions: pndwal

73sydney

Senior Member
Jul 21, 2018
1,848
1,602
Sydney
Google Pixel 2 XL
Its weird, i could get all items setup as you did and report in the Magisk Detector the same as you, but Westpac didnt work.

When i killed that and tried edXposed and XprivacyLUA, Westpac worked, but Samsung pay detected root

note: Its easy to tell when WestPac banking detects root, you lose fingerprint login as an option, AND most importantly the Digital Card option (so you can still use your debit/credit card while waiting for a new card to be sent out, which is kind important right now as of course im waiting on a new card after the last one connected to my account wreaked havoc on my Google Pay account because of Westpacs bugs)

Which circle of hell is this?

2 weeks ago, not a single issue...

Life was good.....

Update: i think i *may* have it fixed with both Samsung Pay and Google Pay/Westpac Bank App working. Ill test it for a few days....because last time i thought i had it with riru-unshared, it lasted 2 days :)

Im going to do a clean flash and recreate it and then leave it for 3 days...tonight i screwed it up trying everything so that its not a reliable test bed right now

It really seems like pot luck these days ...im not sure that execution time in startup isnt half the issue
 
Last edited:

pndwal

Senior Member
Just because development stops on any artifact, does noit mean the thread should be closed. Just think of an app that development may end on, but its use continues.

Where I was going, is that this new development ios sooooo different to the existing Magisk (inc alpha, canary and stable Magisk), I know I personally find it more time consuming to ignore the posts which have nothing to do with the existing Magisk. I see it kind of like starting a new thread for a different android version (eg A10 to A11) even though its the same dev. I think people who are looking at the exiusting Magisk could come here and those looking for the future (ie beyond the existing canary Magisk) culd be better served on a different thread. It gets condusing for simple folk like me to have to read few paragraphs to ensure there ois nothing pertinent or appli9cable to the existing Magisk. One of the real problems is who will start the threaad considering the actual dev is not present on XDA.
Have to say that even with Alpha builds, not much has really changed.

Lately, more development has been done by others rather than John (which is why he commented on how open source is great, allowing him to be lazy). And @vvb2060 has been at top of list for a long time... So many commits authored by him, many tested first in his Alpha, but many (most?) being merged into John's builds.

Of the current 5 pull requests for example, 2 are his.

So his changes have been at the forefront; So many major innovations in John's builds have been his babies. Here is a sampling, just from this year:

MTK compatibility, single package delivery, 64bit support, sepolicy fixes, several isolated process fixes, fixes for UID, MicroG, process names, file based encryption, mount rules for Sammy, auto-close issues bot, reboot menu, multi-user and shared user id compatibility fixes, hidden apps, Chinese translation, offline restore app, unsupported environment checking, fix for apex path (a big one), permission fixes, module Installation fixes, Kotlin code cleanup, MagiskHide stopping fix, Rename App include uninstaller..........

Really, users here have been testing / discussing @vvb2060's innovations for a good while.

Existing Magisk is already very much @vvb2060's... And, of course, @diareuse's... And @osm0sis', ... And @topjohnwu's, and that of some 208 more contributors.

I'm sorry, but I hope from this you might agree that this isn't really 'new development', and is NOT 'sooooo different to the existing Magisk'... It's actually continuation of the same without a break!

Some of the same Devs already help @vvb2060. I hope the others (I'm sure they will) will continue to colaborate with him as they already were with John signing off commits.

But we've certainly lost a great team leader, and original innovator and visionary... for now. PW
 
Last edited:

J.Michael

Recognized Contributor
Jan 20, 2018
838
700
Samsung Galaxy Tab A series
I Have a original firmware downloaded by a user that created the pached_magisk_boot.zip file too.
This 2 files (original firmware and pached_boot) can be update in automatic way via OTA when USB card is detected.
I tried yesterday to solve using SafetyNet Fix 1.1.0 but head unit remained totally blocked during restart with logo of android.
No OTA update was again possible!
The only solution I find was to insert directly on a microSD slot present on main board disassembling the hardware a microSD with "Android 8.1 Update with Root" in .img format using PhoenixCard tool.
The update was automatic when system was power up, then I removed microSD and Android restarted with Magisk to update.
SafetyNet check fails again but I have not indication of another "su" command present when I open Magisk.

The release uploaded was very old (terrible interface available) So I tried to update via OTA but now I don't know why but it stops with this indication: "no find app file, update falure!" (chinese has good translation :D ).

So now no problem for a second "su" but SafetyNet fails and no rom update possible :(



I am confused: Are you trying to accept an Over-The-Air update? Or are you installing a file which is on an SD-card?

Are you now running a newer version of the patched operating system that you originally described?

Is your original problem resolved? *Was* your original problem "Magisk complains that it detects another copy of 'su'"?
 

HippoMan

Senior Member
May 5, 2009
1,728
573
Hippoland
Ok, sorry... so seems mileage varies per device...

I had read it was particularly difficult to hide isolated processes on Xiaomi, so I was chuffed to have all MagiskDetector items undetected...

Just thinking on 'system file(s) are modified by Magisk module', I'm now thinking that means a module may be responsible...

I'm not certain how a module may do this, bit I am aware that if modules are installed via custom recovery (some can work this way) they can / often do actually alter the system partition...

So I'm thinking it may be worth 1) Disabling modules to test, and 2) if you think system mods may have been done, consider how to reverse these (by proper custom recovery uninstall, or by flashing system image?).

Of course, I'm just thinking out loud in case it helps... I may be on the wrong tangent here completely...

Any other ideas on what accounts for 'system file(s) are modified by Magisk module' detected? anyone? PW
Thank you. I'll try disabling modules to see how that works ... when I have some time.

For the moment, I'm kind of busy with two jobs and some issues with my cat needing surgery, so I probably won't get to that for a while. In the mean time, my web-based Android access to my banking app is serving me just fine.
 
  • Like
Reactions: pndwal

73sydney

Senior Member
Jul 21, 2018
1,848
1,602
Sydney
Google Pixel 2 XL
fwiw really strange things happening here

I flashed a clean ROM, and then flashed and
setup:

Magisk (alpha)
Riru
Riru-MomoHider

and set the config options of Momo as before

All tests in Magisk Detector came back perfect

then i added my usual modules...fonts, v4a etc

and tested again

suddenly the lower 3 tests in Magisk Detector returned negative results.

whats really weird was that toggling the modules off one by one (until they were all toggled off) did not return the results to their former states.... i saw between 1 and 4 su processes in Magisk Detector...weird

currently removing modules and testing as i go...

all this just to use my own money......whoever is in charge of the root hatred at banks needs to be shot....its my device, i bought it and i have no interest in using your money, just mine, let me use my damn device and money as i see fit...

Last update before i crash for some sleep: i removed all modules back to the Riru and Riru-Momohider, and its still banging on about running su processes and selinux
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
5,721
3,174
fwiw really strange things happening here

I flashed a clean ROM, and then flashed and
setup:

Magisk (alpha)
Riru
Riru-MomoHider

and set the config options fofo Momo as before

All tests in Magisk Detector came back perfect

then i added my usual modules...fonts, v4a etc

and tested again

suddenly the lower 3 tests in Magisk Detector returned negative results.

whats really weird was that toggling the modules off one by one (until they were all toggled off) did not return the results to their former states.... i saw between 1 and 4 su processes in Magisk Detector...weird

currently removing modules and testing as i go...

all this just to use my own money......whoever is in charge of the root hatred at banks needs to be shot....its my device, i bought it and i have no interest in using your money, just mine, let me use my damn device and money as i see fit...

Last update before i crash for some sleep: i removed all modules back to the Riru and Riru-Momohider, and its still banging on about running su processes and selinux
Don't forget to wipe Data for Magisk Detector (and your banking app) between tests
 

73sydney

Senior Member
Jul 21, 2018
1,848
1,602
Sydney
Google Pixel 2 XL
Don't forget to wipe Data for Magisk Detector (and your banking app) between tests

I did wipe data for Magisk Detector before every one of the what seemed like 50 reboots :)

I did not test any further than Magisk Detector at this point to see if anything weird was going on...and it was, variable numbers of su processes reported..often jumping between 1 and 4, when closing and reopening it between reboots..

fwiw: magisk lite tests ok, except for init.rc modified message
 
Last edited:
  • Like
Reactions: J.Michael

zgfg

Senior Member
Oct 10, 2016
5,721
3,174
fwiw: magisk lite tests ok, except for init.rc modified message
I had the same result with Lite

Did you try to install some nodules to Lite?
E.g., can you get MHPC running - it installs for me but terminal complains that props command is unknown.
To the other side, pure REPLACE based module(s) work fine.

Also, does it crash to you when you first time upon the installation of Lite to /data/adb by MiXploree - sounds strange but it happe!ed to me twice
 

73sydney

Senior Member
Jul 21, 2018
1,848
1,602
Sydney
Google Pixel 2 XL
I had the same result with Lite

Did you try to install some nodules to Lite?
E.g., can you get MHPC running - it installs for me but terminal complains that props command is unknown.
To the other side, pure REPLACE based module(s) work fine.

Also, does it crash to you when you first time upon the installation of Lite to /data/adb by MiXploree - sounds strange but it happe!ed to me twice

there is no access via terminal

i installed my fave module, debloat, but of course cant access it...they were serious about the lite part :)

As for the install of lite...i installed the apk and patched a boot img, had no errors

v4a/vanced youtube doesnt work either, now i really want to die :)

going to bed finally, in disgust
 
Last edited:

DiamondJohn

Recognized Contributor
Aug 31, 2013
5,542
5,286
Sydney
@zgfg & @pndwal I TOTALLY understand I am only one very small fish in this ocean, and for the most part I swim alone in ever decreasing circles in my little personal puddle. I am not that active in this thread and have an even lower level on contribution. It was simply a suggestion and completely understand that everyone's opinion on any topic of Magisk discussion in this thread, is more pertinent than mine. It was really just a suggestion from someone who's opinion is not very important. Dont fret about it or waste your time explaining/replying too much, I would of accepted a simple"NO", but also understand it might of looked too dismissive.(y)
 

pndwal

Senior Member
@zgfg & @pndwal I TOTALLY understand I am only one very small fish in this ocean, and for the most part I swim alone in ever decreasing circles in my little personal puddle. I am not that active in this thread and have an even lower level on contribution. It was simply a suggestion and completely understand that everyone's opinion on any topic of Magisk discussion in this thread, is more pertinent than mine. It was really just a suggestion from someone who's opinion is not very important. Dont fret about it or waste your time explaining/replying too much, I would of accepted a simple"NO", but also understand it might of looked too dismissive.(y)
No worries!

Just hope some info on recent Magisk development, and behind scenes gratuitous efforts of unseen developers aids ALL in understanding this group/community effort...

Of course it's only my opinion (but I think fairly evident) that Magisk has become more than just John's baby.

You may well be right that it merrits a new thread too... But, as you note, Dev with current builds available is without citizenship here...

John's an OP AWOL anyway, but hasn't formally put the baby up for adoption either!

Magisk, it does appear, is in a state of flux... But without @vvb2060, it might have been a state of limbo.

I see @vvb2060 as now in a caretaker role. He didn't ask for it either... We just found him holding the baby... And nurturing it.

So what to do?... It's perplexing, but very early days yet... And anything could happen!

I think time will tell, but unless the baby gets a new home, I'm happy to watch it grow here.

John will always be the father of Magisk... Hope he hasn't abandoned him... and that he can at least get visitation rights / contribute in future. 😐

You are very modest, but I know you've made countless valuable contributions / comments here. There's more than one Diamond John!

Please don't feel your opinions are less valuable / pertinent here either - you raised valid points, and in a forum expressly designated for such general discussion / bouncing ideas by John himself. I certainly didn't intend to dismiss them... You've swum in these waters much longer than me, after all!

Please remember this: If enough fish swim in circles, you get a whirlpool... Difficulty when you've swum to the middle is swimming out again....

The effort is the price you pay, but IMHO, it beats swimming alone. 😜 PW
 
Last edited:
  • Like
Reactions: jinsing

pndwal

Senior Member
there is no access via terminal

i installed my fave module, debloat, but of course cant access it...they were serious about the lite part :)

As for the install of lite...i installed the apk and patched a boot img, had no errors

v4a/vanced youtube doesnt work either, now i really want to die :)

going to bed finally, in disgust
Wow... 7.30 am! What a night, eh!

Chin up! When you wake up for lunch, things will be brighter. 😛 ... And make coffee... for two! 🙂 🐻 PW
 
Last edited:
  • Like
Reactions: 73sydney

S8rooted&tooted

Senior Member
Sep 18, 2017
354
174
Google Pixel 3 XL
From what John has said on Reddit and behind the scenes, recanting on some made statements, he can not touch magisk at all not speak on it anymore. Since he does own the repositories for magisk so we could see them just disappear. He can't push an update which only he can do, so it's either fork it and go that route, which he knows all the ins and outs of magisk and now works for Google(2+2 says he will spilling the beans on the background to block it), I believe they have him on a gag because conflict of interest with magisk sidestepping their security system. You can't work for somewhere and have an ap they completely bypasses their OS without a amjor conflict of interest. Magisk, from John's standpoint and having to delete his tweet about keeping magisk going, I don't think an answer will ever be given from John unless he leaves Google. They did the smartest move I have ever seen them do.
 

Top Liked Posts

  • 10
    MOD ACTION:

    Enough is enough. Despite my deleting some off topic posts yesterday, the spam continues. Thread cleaned. Please check your PM inbox and avoid off topic posts.
    3
    This is based on John's repo.
    I am not sure if vvb2060's alpha build require Zygisk active for enabling DenyList.
    AFAICS it does, at least for now.

    I believe ptrace was used previously for this; new Magisk needs Zygisk; I don't think we'll have an option in future since all ptrace code is gone... unless it comes back. vvb2060 OP note re. this here:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85643797

    ... 'n please don't team up on me; my Android reflexes are abominably slow and I might just go sulk in the carpark... Marvin.
    3
    Need quick help with the installation instructions https://topjohnwu.github.io/Magisk/install.html

    Under "Patching Images" it says I need the boot.img (cause my OP 5T has RAM disk), but where can I download it?

    Thanks in advance

    Edit: I'm running lineage OS with microG
    From the LOS install zip file.
    Unzip that file, you should find a boot.img in there. That's what Magisk needs.
    If you have a boot.img.br file, just uncompress it first with brotli.
    2
    For those running vvb2060's alpha builds.

    You should be able to install any of the alpha builds over each other.
    The versionName is changing GitShortHead-alpha.
    The versionCode is remaining 23001.

    The versionCode is what triggers the upgrade/downgrade install.
    PackageManager only see that you are re-installing version 23001. ;)

    With that being said, you might run into a problem with magisk.db that was generated by an older/newer build.
    There was a very recent commit about this. (Currently the last commit on John's repo.)​
    Magisk - GitHub - commit - f7c0e40
    Also the last commit in vvb2060's repo currently.


    You might have an issues repacking a Magisk boot image.
    For testing purposes you should always use your ROM's stock boot image.
    Yes testing the updating logic is important but, you need a base line to compare.​
    A clean install may fail when an update succeeds and vice versa.

    Cheers all. :cowboy:
    Good to know, thx

    Hopefully, if I make a copy of /data/adb/magisk.db before trying the next Alpha, I will be able to restore the database if I would have to go back to b6298f86-alpha
    1
    Hi,

    Does snapchat work with the Magisk and corresponding modules for hiding? I've been out of rooting scene for long, so I don't know. The last time snapchat was able to detect it.

    Thanks.
  • 44
    OK. AIO solution. Modded "Universal SafetyNet Fix" module. Just added "model" props.
    17
    So, new layer of HARDWARE detection is here.
    SafetyNet failed on devices, where must bee HARDWARE detection. GMS no longer check system response of evaluation type, and force check HW. USNF doesn't work in this cause.
    Hm, funny things happening. I was thinking this is upgrade of HW attestation, but it is DOWNGRADE actually. 😄

    Remember my old first simple digging into HW?
    It`s..... working again.

    Looks like a temporary solution or just "combo" of old and new methods from Google.
    This explains the fact that dirty hack with Xposed-s working now.

    So, this current environment may be temporary or preparation for something BIGGER.

    In conclusion: in this time to passing SafetyNet you need just my old "hardware_off" module from link above or "MagiskHidePropsConf" with any "BASIC" print with model simulation and kdrag0n-s "Universal SafetyNet Fix".

    No ***-posed-s need!
    16
    Few Headsups:

    1) There are reports that Danny's (@kdrag0n) new early release Universal SafetyNet Fix 2.0.0 (combines AOSP Keystore and shim Keystore solutions) is restoring ctsProfile for some. It just may work for all, but not enough reports as yet. Also, it requires a payment at this stage:
    https://forum.xda-developers.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/post-85581909

    https://github.com/kdrag0n/safetynet-fix/pull/13#issuecomment-904209677

    2) There are reports that simply using MagiskHide Props Config module to 'delete' ro.product.model prop fixes ctsProfile on custom ROMs where other methods have failed. Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912885628

    3) New MagiskHide Props Config module 6.0.0 just released with all the sensitive prop values that MagiskHide changed up to and including Magisk v23 set by default, "Force BASIC key attestation" re-enabled (for Googles latest changes), and various other fixes.
    https://forum.xda-developers.com/t/...p-edits-and-more-v6-0-0.3789228/post-85581939

    I have to agree that this module's name does suddenly seem very apt, and as always, it proves elegant in its versatility. 😛👍

    4) Another elegant solution that some may have relegated to a bygone era seems to be coming back in fashion to!

    Those with Google Pay problems persisting after fixing ctsProfile are reporting in GPay threads, here and elsewhere, that GPay-SQLite-Fix + SQLite binary modules from stylemessiah (a connoisseur at least in digital fashion ... or perhaps just lucky, our @73sydney, - original solution from @BostonDan ) is fixing these for them once again. 😜 Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912798412

    WOT 😉 to read if interested:
    https://forum.xda-developers.com/t/...s-of-gms-17-1-22-on-pie.3929950/post-79643248

    🤠 PW
    15
    ro.product.model was enough for my OP8T, but I didn't like how Google Play Services started referring to my device as "OnePlus BASIC" with the "hardware off" module, so I knocked together this module really quickly to just append _SN to the real model name. WFM. 🤘
    14
    Removed the @Displax safety net mod fix and applied the latest USNF 2.1.0 from @kdrag0n.

    Attestation is passed and device is compliant in company portal too with my original device name 1+8 Pro and not Pixel.

    This is done over the latest Alpha Magisk.

    Update: My In-display fingerprint hardware is not working anymore, I think the fix is already committed. Hopefully it will be resolved in the next version.
    Yep, I have sent a Pull Request with the fix like an hour after v2.1.0 was released. 🤠

    See my post here in the official USNF thread for getting it working in the meantime until it's merged and a new release is made: https://forum.xda-developers.com/t/...tynet-fix-1-1-0.4217823/page-59#post-85631613

    Also may be worth everyone reading my comments at the end of that post about people doubting the sponsored testing closed-then-open development.

    And then here on this GitHub issue about how it's not meant to replace MagiskHide so you can't just turn Hide off: https://github.com/kdrag0n/safetynet-fix/issues/91#issuecomment-919264624
  • 1062
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p