• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!
  • Fill out your device list and let everyone know which phones you have!    Edit Your Device Inventory

Magisk General Support / Discussion

Search This thread

soaib333

Member
Nov 12, 2018
14
0
Delhi
The lastest magisk zip or boot.img patch ia not working on samsung TAB A SM-T285 (Lollipop)
I flash the correct zip file so many time and it flash the success on TWRP but after reboot the manager showes Installed : N/A. Then I read the magisk blog instructions and patch the boot img file but the result is same. The only thing is working the older version of magisk but I want to up to date so please fix this bug or announce a new method for samsung lollipop version.
 

pndwal

Senior Member
The lastest magisk zip or boot.img patch ia not working on samsung TAB A SM-T285 (Lollipop)
I flash the correct zip file so many time and it flash the success on TWRP but after reboot the manager showes Installed : N/A. Then I read the magisk blog instructions and patch the boot img file but the result is same. The only thing is working the older version of magisk but I want to up to date so please fix this bug or announce a new method for samsung lollipop version.
Likely this known issue affecting older Android:
https://github.com/topjohnwu/Magisk/issues/4174

See also XDA link there, and this:
https://github.com/topjohnwu/Magisk/issues/4107 PW
 
Last edited:

martyfender

Senior Member
Mar 9, 2017
3,158
1,675
Indianapolis, IN
The lastest magisk zip or boot.img patch ia not working on samsung TAB A SM-T285 (Lollipop)
I flash the correct zip file so many time and it flash the success on TWRP but after reboot the manager showes Installed : N/A. Then I read the magisk blog instructions and patch the boot img file but the result is same. The only thing is working the older version of magisk but I want to up to date so please fix this bug or announce a new method for samsung lollipop version.
John took a job with Google, so the way I understand it, he is no longer allowed to develop Magisk.
 

rodken

Senior Member
Jan 11, 2010
489
102
Google Pixel XL
OnePlus 8
I havent tested it on the new Magisk lite. I thought the module location had changed so would of assumed it would not work; but talk that the others may or were expected to work makes me think it might. However, the app TeMeFI has a built in Magisk debloater module builder. It can be found at Magisk>Modules>TeMeFI Hide System Apps>Add or Remove - Hide System Apps using a TeMeFI Module>Add One>* One thing that is clear, I really need to shorten some of those menu items...

If it is simply a case of a moved module location, if you let me know what that is and how to detect when to use/switch to it (eg if statement based on Magisk version), it would probably be pretty simple to modify the path it is built into. And I am working on new release right now.


My app above, uses a GUI, so it is pretty easy apart from having to use the GUI again if you clean flash your ROMS. But you can save off the scripts to automate it if you do it repeatedly and dont like to click.

Regarding Viper, if its the SEPolicy changes that are questionable, then switching to permissive should make that irrelevant (ie test the theory); for testing only of course. There are many methods used to install viper. I have had the best luck on A11 using the attached Magisk zip; note, I did not build it, and it defaults to boot permissive, which can be easily changed with a delay in the service script. It also has a few other very minor things not quite neat, but it has worked for me and others.


TeMeFI does. It looks under (all under system) app, priv-app, product, product/priv-app, vendor, vendor/priv-app
Is there an advantage in utilizing Magisk Lite versus other versions of Magisk?
 

pndwal

Senior Member
Is there an advantage in utilizing Magisk Lite versus other versions of Magisk?
Not for most: It breaks normal use of modules for example. Seems its sole purpose / only advantage is for those desperate to pass SafetyNet for bank apps detecting "root" through isolated processes, or interested in testing MagiskHide with this ability.
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85103873

Alpha Magisk from same dev is best bet for those simply wanting newer updates / fixes at present:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85103975 PW
 
Last edited:

DiamondJohn

Recognized Contributor
Aug 31, 2013
5,360
5,048
Sydney
Is there an advantage in utilizing Magisk Lite versus other versions of Magisk?
I have never installed it nor used it or even followed what the heck it is. However, it looks like the direction Magisk will be heading in, in the future. The advantage in my eyes is best to find any roadblocks and soln now, before they become a sticking point.
 

DiamondJohn

Recognized Contributor
Aug 31, 2013
5,360
5,048
Sydney
The lastest magisk zip or boot.img patch ia not working on samsung TAB A SM-T285 (Lollipop)
I flash the correct zip file so many time and it flash the success on TWRP but after reboot the manager showes Installed : N/A. Then I read the magisk blog instructions and patch the boot img file but the result is same. The only thing is working the older version of magisk but I want to up to date so please fix this bug or announce a new method for samsung lollipop version.
I dont know your device, however, I have owned older devices, and on those devices, I cannot run the latest software. Maybe your device running lollipop is just not ready for running the latest of software in other regards. Lollipop is getting old.
 
  • Like
Reactions: J.Michael

73sydney

Senior Member
Jul 21, 2018
1,657
1,349
Sydney
Google Pixel 2 XL
The lastest magisk zip or boot.img patch ia not working on samsung TAB A SM-T285 (Lollipop)
I flash the correct zip file so many time and it flash the success on TWRP but after reboot the manager showes Installed : N/A. Then I read the magisk blog instructions and patch the boot img file but the result is same. The only thing is working the older version of magisk but I want to up to date so please fix this bug or announce a new method for samsung lollipop version.

I have an old Samsung Galaxy Tab 3 10.1 (GT-P5210) and it wont support Magisk above v20. Just the way it is.

Im afraid you just have to realise your request will go into the "wont be fixed" list sorry
 

rodken

Senior Member
Jan 11, 2010
489
102
Google Pixel XL
OnePlus 8
@pndwal What would be the difference in these three versions?
stub.png
 

pndwal

Senior Member
@pndwal What would be the difference in these three versions?View attachment 5338879
Just download/use the app-release.apk as per my linked notes.

Not sure why app-32bit.release.apk and app-64bit.release.apk have been left there, but they're clearly not up to date in any case.

stub-release.apk is called (as per json file link) for 'Hide the Magisk app' function if online when selecting this, but this Alpha will use a local stub apk otherwise. (See changelog "- use the local version when you can not download stub, can be completely offline now Magisk") You don't download that manually. 👍 PW
 

rodken

Senior Member
Jan 11, 2010
489
102
Google Pixel XL
OnePlus 8
Just download/use the app-release.apk as per my linked notes.

Not sure why app-32bit.release.apk and app-64bit.release.apk have been left there, but they're clearly not up to date in any case.

stub-release.apk is called (as per json file link) for 'Hide the Magisk app' function if online when selecting this, but this Alpha will use a local stub apk otherwise. (See changelog "- use the local version when you can not download stub, can be completely offline now Magisk") You don't download that manually. 👍 PW
Since using this Alpha version, have you seen any updates come through the pipes automatically via the Alpha channel or this one of those situations where I have to 'hunt down' and manually install any future updates of the Alpha build?
 

zgfg

Senior Member
Oct 10, 2016
5,436
2,764
Since using this Alpha version, have you seen any updates come through the pipes automatically via the Alpha channel or this one of those situations where I have to 'hunt down' and manually install any future updates of the Alpha build?
Having Alpha for cca 10-14 days, there were no updates so far

As you were responded, install app-release.apk (17 days old as of today) - my download is 9.87 MB and with MD5 checksum: b989587f1ac9a1ff2ca03c87f017a3c7
 
Last edited:

rodken

Senior Member
Jan 11, 2010
489
102
Google Pixel XL
OnePlus 8
Having Alpha for cca 10-14 days, there were no updates so far

As you were responded, install app-release.apk (17 days old as of today) - my download is 9.87 MB and with MD5 checksum: b989587f1ac9a1ff2ca03c87f017a3c7
Correct me if I am wrong - I would have to repatch my boot.img with the alpha release in order to get this work in my favor because simply installing the alpha apk over the existing Magisk Manager is not an option.
 
  • Like
Reactions: J.Michael

zgfg

Senior Member
Oct 10, 2016
5,436
2,764
Correct me if I am wrong - I would have to repatch my boot.img with the alpha release in order to get this work in my favor because simply installing the alpha apk over the existing Magisk Manager is not an option.
Yes, first install Magisk Alpha apk and allow to finish the installation once you run the app (it will fetch the stub.apk)

Then, make sure that Alpha Update channel is selected in Settings

Use Install Magisk option to patch your (boot) image, flash and reboot - to obtain as on my screenshot

Important - to install Magisk Alpha app, you will probably have to uninstall Magisk Stable/Canary application (because of the missmatch in the apk package names and/or version number)
 

Attachments

  • IMG_20210615_165610.jpg
    IMG_20210615_165610.jpg
    206.6 KB · Views: 39
  • Like
Reactions: rodken

73sydney

Senior Member
Jul 21, 2018
1,657
1,349
Sydney
Google Pixel 2 XL
@pndwal and anyone using/testing riru-momohider

I got rapidly tired of adding the config files manually each flash, so i modded the riru-momohider module and added:

Code:
# Add config switches
ui_print "- Setting config"
options='isolated setns app_zygote_magic initrc'
for i in $options
do
    touch $DATA_DIR/"$i" && ui_print "- Setting config: $i" || ui_print "- Setting config: Failed to create config file"
done

just above the last two lines in customize.sh:

Code:
ui_print "- Setting permissions"
set_perm_recursive $MODPATH 0 0 0755 0644

Or if you like, i have attached my modded riru-momohider zip to this post
 

Attachments

  • Riru-MomoHider-Mod.zip
    323.4 KB · Views: 60

Primokorn

Senior Member
Nov 17, 2012
11,444
7,695
Hello,
My device is a Xiaomi Redmi Note 7 running crDroid 3.11 (Android 10) and Magisk 23.0 (23000).
SafetyNet is OK and I enabled Magisk Hide.
My banking app (Google Play link - com.prod.bca) still knows that I'm rooted, why?

I compared my configuration with my other devices (Oneplus 3T - crDroid Android 11) and I have no issue.
I have attached logs.
Thank you in advance for your support.
 

Attachments

  • magisk_log_2021-06-15T19-12-24Z.log
    16.7 KB · Views: 8

sporc10

Senior Member
Dec 21, 2014
50
13
I somehow locked myself out..
I had magisk installed and all working, then I hide magisk and freezed the repackaged app. Now I have the problem that I cant unfreeze it again, because the app I used to freeze doesn't work anymore (I suppose the root is missing).
What can I do, to get access to magisk again?
I tried to install the latest magisk apk, it says under magisk "Installed: N/A".
Any suggestions or ideas? Thank you
 

zgfg

Senior Member
Oct 10, 2016
5,436
2,764
I somehow locked myself out..
I had magisk installed and all working, then I hide magisk and freezed the repackaged app. Now I have the problem that I cant unfreeze it again, because the app I used to freeze doesn't work anymore (I suppose the root is missing).
What can I do, to get access to magisk again?
I tried to install the latest magisk apk, it says under magisk "Installed: N/A".
Any suggestions or ideas? Thank you
Sorry but it was really a bad and wrong idea to freeze the Magisk app (pretty sure, it was not suggested in this thread) - specially upon it was repackaged.
Without, you cannot grant root access, etc

And of course, your newly installed Magisk app cannot connect to Magisk because the old (repackaged and frozen one - doesn't matter) is still connected to Magisk DB - three were so many posts here about the same problem when the newly installed Magisk app shows N/A for Magisk because of the forgotten, old, repackaged Magisk mngr/app still installed

First, uninstall that newly installed Magisk app (simply from Settings, Apps)

Then, you must find your old, repackaged (and frozen) Magisk Manager/App and uninstall it, too

Unfortunately, when you did repackaging, the package name was randomized and you don't remember that randomized package name (another reason it should have not been frozen then)

Hopefully, you remember which app name you gave it instead of the Magisk mngr/app - try to find it under that name in Settings, Apps and try to uninstall it there (even since it was frozen)

Or, install an app Package Manager from Google Play, search in that app for the app name of your renamed/repackaged Magisk Manager/App.
You can probably uninstall it from that Package Manager but even if not, you can read there its randomized package name

The other way to find its randomized package name will be to use ADB comnand from PC:
adb shell pm list packages -d

That command lists package names for all your "pm disable-user ..." apps (that is, those apps you 'froze')

Look at the output list and if you see some totally strange/randomized package name, that one should correspond to your (frozen and) repackaged Magisk mngr/app

Once you detect its (randomized) package name, you will be able to 'un-freeze' by ADB:
adb shell pm enable <package-name>

and then you should be able to regularly uninstall it from Settings, Apps (or just open it, go to Settings, and take the Restore option to get it back to the 'normal', not renamed/randomized Magisk mngr/app)

Only then, if neccessry, install the new/updated Magisk app

PS: For all who cannot live without repackaging Magisk app.
Upon repackaging, open the app and take a screenshot - on top, under the App info, after Latest and Installed lines, you will see the line Package showing its randomized package name.
Save the screenshot for your reference - in case you ever 'freeze' it, you will know its randoized package name to un-freeze
 
Last edited:

pndwal

Senior Member
Hello,
My device is a Xiaomi Redmi Note 7 running crDroid 3.11 (Android 10) and Magisk 23.0 (23000).
SafetyNet is OK and I enabled Magisk Hide.
My banking app (Google Play link - com.prod.bca) still knows that I'm rooted, why?

I compared my configuration with my other devices (Oneplus 3T - crDroid Android 11) and I have no issue.
I have attached logs.
Thank you in advance for your support.
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85148739 👍 PW
 

Burt Squirtz

Senior Member
Feb 11, 2018
473
156
Not for most: It breaks normal use of modules for example. Seems its sole purpose / only advantage is for those desperate to pass SafetyNet for bank apps detecting "root" through isolated processes, or interested in testing MagiskHide with this ability.
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85103873

Alpha Magisk from same dev is best bet for those simply wanting newer updates / fixes at present:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85103975 PW
Will this show updates within the app itself? Or do we have to manually download and install new Alpha branch?

Over-joyed that someone is continuing on with the work. I thought we were done with magisk honestly. Has been Anxiety-inducing
 
Last edited:

Top Liked Posts

  • 6
    Yup!

    This is a per-device setting (doesn't show for many). Generally, these are correctly set; only change if you have issues.

    In this instance, I think you'll only need it if you wish to decrypt device (for custom ROM etc?), and some devices may bootloop if not checked. That said, if it's off by default, I'd leave it that way...

    Not a Sammy guy, but the install instructions seem to be in error; AFAIK, MD5 (message-digest algorithm) is only used to verify file integrity. Is there also an AP_xxxx.tar file? I'm guessing John ment to specify that... PW
    Sometimes the .tar.md5 file is the .tar file, with the md5 of the tar file appended. That's what I got when I unpacked the zip file I downloaded, that's what I fed to the antediluvian Magisk I used. @zgfg's suggestion of checking the file size is a good start.

    The talk about being unable to select a file (@xAxB said the files were all grayed out) makes me think it's some permission issue. I don't think the content of the file matters until after you've selected an inappropriate file.
    4
    Hello, I hope that this is the right thread for general support.
    Yup!
    I am trying to use Magisk (tried both v23.0 and Canary) to root my Samsung Tab S4 (Android 10, security patch March 2021) following the Samsung (System-as-root) guide posted here: https://topjohnwu.github.io/Magisk/install.html

    1. When I click "Install" there is the option to tick / untick "Preserve force encryption" - What should I do with this?
    This is a per-device setting (doesn't show for many. I think only on older devices). Generally, these are correctly set; only change if you have issues.

    In this instance, I think you'll only need it if you wish to decrypt device (for custom ROM, TWRP etc?), and some devices may bootloop if not checked. That said, if it's off by default, I'd leave it that way...
    2. Regardless of whether I tick it or not, selecting "Next" would let me "Select and Patch a file". However, and this is my main problem, I am unable to select the AP_[device_model_sw_ver].tar.md5 file. I can find it, but not select it. It doesn't matter if I put it on the internal storage, or microSD card, everything is just greyed out.

    Is there a solution to this problem? Thanks.
    Not a Sammy guy, [edit: this is wrong] but the install instructions seem to be in error; AFAIK, MD5 (message-digest algorithm) is only used to verify file integrity. Is there also an AP_xxxx.tar file? I'm guessing John ment to specify that... PW
    4
    In general yes.

    This seems to be another device specific issue.
    In the case of OnePlus 6T, you do not have to restore stock images first. ;)
    I added a post-script note to my prior post.
    Edit:
    PS.
    If I remember correctly, OnePlus OTA updater would detect root/modified system.
    So it would download/install the full version instead of an incremental/partial update.​

    Cheers. :cowboy:
    Depends on the device. On 8T and newer, which use the new "Google OTA" (Google Play services meditates the OTA) process, it'll do incremental regardless of root status. Also, to make it even more complicated, that's only on International/North American variant OOS and only on stable ROM channel.

    Edit: Now that there's a working kebab TWRP my next trick will be to see if the post-reboot OTA checks might pass with it reinstalled in between, since then we could reroot while avoid the bootloader/PC steps; there's a chance it might since it's a recovery_a/_b device. I'll check into that with the next security update my 8T gets. 🙂🤞
    3
    Hello, I hope that this is the right thread for general support.

    I am trying to use Magisk (tried both v23.0 and Canary) to root my Samsung Tab S4 (Android 10, security patch March 2021) following the Samsung (System-as-root) guide posted here: https://topjohnwu.github.io/Magisk/install.html

    1. When I click "Install" there is the option to tick / untick "Preserve force encryption" - What should I do with this?

    2. Regardless of whether I tick it or not, selecting "Next" would let me "Select and Patch a file". However, and this is my main problem, I am unable to select the AP_[device_model_sw_ver].tar.md5 file. I can find it, but not select it. It doesn't matter if I put it on the internal storage, or microSD card, everything is just greyed out.

    Is there a solution to this problem? Thanks.
    Which Magisk Manager/App version do you use - in v23 there should be no more Preserve force encryption option (removed long ago)?
    Download the latest Magisk App from Magisk Github

    How big is your md5 file? If 32 bytes or so, it would be just a textual file containing MD5 checksum of the ROM file
    3
    Which Magisk Manager/App version do you use - in v23 there should be no more Preserve force encryption option (removed long ago)?
    Download the latest Magisk App from Magisk Github

    How big is your md5 file? If 32 bytes or so, it would be just a textual file containing MD5 checksum of the ROM file

    I tried both Canary (23001), and 23.0 (23000) (21) (downloaded from Github and it does show. Perhaps it is as @pndwal mentioned, a per-device setting (the Tab S4 is 3 years old)?

    On the plus side, I sorted out the greyed out thing. Basically you can't just tap on Galaxy Tab S4 / SD card and select the file from there (everything is greyed out), but select an external app (e.g. My File) from within Magisk, and select from there. Hope that makes sense for anyone who run into this issue (on Googling, I am not the only one who ran into this issue).

    I would also like to confirm that the tar.md5 file is 4.05GB and this seems to be the way the AP are named, at least on the Tab S4.
  • 8
    reddit link shared by John Wu:
    reddit post

    Especially interesting a comment by the leader of the Android Security team:
    (I lead the Android Hardware-backed security team, so while this response isn't official, it's informed. Do keep in mind that I am a programmer, not a lawyer, and I have not consulted with legal, so don't rely on this as any sort of legal advice. Nor did I run this by PR, so if I put my foot in my mouth, it's totally on me. This is not an official Google communication, and I may get my hand slapped for it. Probably not, but it's happened to me in the past :) ).

    I know of no legal issues here. AFAIK, you're free to do what you like with your device. Doing these sorts of things may invalidate your warranty, depending on the details, but I'm guessing you already know that and have decided you're fine with it.

    What I do know is that if you've found a vulnerability, Google would not only like to hear about it, Google may pay you for it. If you're compromising the TEE or kernel on a Pixel device, the reward could be up to $250,000. If you're compromising the Titan M, up to $1,000,000. Even if your current exploit isn't on a Pixel device, if you can make it work on a Pixel you would qualify. Alternatively, your device manufacturer may have their own bug bounty program and you should look.

    Obviously, if you report the vuln, what we're going to do is to fix it, so you'll lose your SafetyNet bypass. The same will happen if you publish it for others to use. Vulnerabilities that allow SafetyNet bypass typically compromise far more than just SafetyNet, which is why Google is willing to pay so much money to identify and fix them. Also, we really believe that app developers should be able to find out if they're running on a "stock" device, with all of the security and functionality guarantees that implies, so fixing SafetyNet bypasses is important in and of itself.

    It's not that we don't like custom ROMs or rooting, in fact we find a lot of the innovation that takes place in the community very interesting and eagerly adopt good ideas we find there, but our primary focus is on protecting the 99.9% of Android users who run stock Android, and the developers who serve them. It's an unfortunate but unavoidable reality that this sometimes disadvantages ROM users. I, personally, have been holding regular meetings with various leaders in the modding community for seven years now, to get their feedback and to give them a heads up on security features we implement that might pose problems for them. My goals are to both serve the main Android userbase of some 3B people and to avoid harming the modding community. Sadly, sometimes those goals conflict, and the modders obviously lose in those cases.

    I also want to address the comments about John Wu joining Google. He is perfectly capable of communicating his own intentions and goals so I won't try to do that. I'll just say that I have no interest in shutting down Magisk. To the degree that it enables people to bypass Android security guarantees, that just shows that we have work to do, indeed it helps us to identify where we need to do that work. It's not like Magisk can somehow create vulnerabilities (it's not magic). If vulns exist, they're certain to be found and exploited by people with nefarious goals, so it's better for everyone if there's a healthy "white hat" community focused on finding problems and reporting or publishing them. I see the Magisk community as part of that white hat community, and John as a valuable contributor to Android security even before he started working for Google.
    8

    Latest @vvb2060 Magisk Alpha build (July 18, 2021) changelog:​

    Chinese Translated:

    alpha update log​

    Magisk (1eb83ad8-alpha-19)​

    • Based on 1eb83ad8, please refer to the upstream update log for related modifications
    • Properly process any data from magiskd
    • Support SharedUserId
    • Delete the backup file after restoring the boot image
    • Built-in current version update log
    • Use the local version when the stub cannot be downloaded, now Magisk can be used completely offline
    • Support bootimg v4 format
    • Support bootconfig
    • Detect /data/adb/magisk/ not updated and prompt to repair
    • Remove the disabled and pending deletion marks when upgrading the module, and it is not allowed to mark as pending deletion before restarting
    • Fix that it cannot be flashed in some TWRP
    • Modify the search order of the module sepolicy location and fix the problem that some devices do not load the module sepolicy
    • Listen to the PACKAGE_FULLY_REMOVED broadcast to remove completely uninstalled apps from magiskhide
    • Display a modal waiting pop-up window when hiding/restore the Magisk application
    Edit: The following are new commits:
    • App adapted to Android 12
    • Android 12+ super user hides the screen overlay when the window pops up
    https://github.com/vvb2060/Magisk/b...73bce50fe5e/app/src/main/res/raw/changelog.md

    My earlier notes:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85098469

    Current notes:

    magisk_files repo is now updated! Check 'earlier notes' for installation method / details.

    Alpha build users won't yet see Update button notice in Magisk App for this build as VersionCode has (again) NOT changed from 23001.

    I'm not sure if this behaviour will be addressed, but users will observe the 'Latest' version (1eb83ad8-alpha-19) now differs from 'Installed' (1eb83ad8-alpha).

    Package is now also uploaded to Telegram group.
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85229385

    Interestingly, in Magisk Documentation, @vvb2060 has updated "Internal Details" and "Deployment" since John did.
    https://github.com/vvb2060/Magisk/tree/alpha/docs

    😛 PW
    7
    Tried using https://raw.githubusercontent.com/topjohnwu/magisk_files/canary/app-debug.apk after it was already rooted with Magisk, but adb said [INSTALL_FAILED_VERSION_DOWNGRADE]
    Just use Magisk/Canary button on Magisk GitHub home page to get app. Opens
    This is latest 23001

    Nb. Your link (where did you get that??) is to latest Canary in old archived magisk_files repo (note '_', not '-') so it's fetching 22003, ie. you would be trying to downgrade from 23000, and to downgrade you need to uninstall 23000 first, as with any app downgrade. 😜

    Nb. Regular app installation from device should work fine, then Direct install to update (or downgrade) Magisk should be available / work.
    Well golly, the whole reason I was trying to use canary was to file a bug report, but if nobody is maintaining it, then there's no point. Thanks for letting me know!
    Wouldn't say no point however.

    Magisk contributors (there are 201) like @osmosis (especially) and @vvb2060 are still distilling / fixing issues, and responding to many issues, as are other informed / experienced users. Many workarounds / non-integrated solutions have been supplied.

    Further, as has been noted, many fixes from topjohnwu Magisk Issues have been incorporated in vvb2060's Alpha builds (seems these go back at least to Dec 2018. Archived builds from Dec 2020 are available on his GitHub & Telegram) before merging in John Wu's.

    I doubt this will change, and vvb2060 has produced several builds since John's last ones already! This is the beauty of such an open source project. Links, latest etc:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85226785

    It would be a misunderstanding to say only John is supplying fixes for Magisk Issues, just as he is not (any longer at least) its sole developer!
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85127113

    Nb. John already pretty much turned over current App design / fixes to @diareuse so he could concentrate on Magisk Mask itself:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-83637567

    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-83771409

    Clearly the issue of official builds continuing (in present form or other) is up-in-the-air atm, but a healthy / active / interested community still exists. 🙂 PW
    7
    Just a random question. If one was to install Magisk & app, assign root permissions to appropriate apps, and then uninstall the Magisk app (where superuser permissions can be turned on and off once a request has been made), would the SU permissions stop working on the assigned apps?

    No. You can uninstall Magisk app, but root grants (and Magisk Hide, modules) will continue working.
    Of course, you will not be able to grant root to additional apps (there will be no pop-ups).
    And you can again install Magisk app, no problem

    Magisk db (root grants, Magisk Hide) and modules are not affected by uninstalling Magisk app (or by deleting its cache or data). Magisk app just provides the user interface to manage root grants, Magisk Hide, modules

    Side note:
    To clear/reset Magisk, you need to delete /data/adb/magisk.db
    Magisk will regenerate magisk.db on (re)boot.
    Helpful if your Magisk install becomes corrupt, sometimes just regenerating magisk.db will fix the issue(s).​

    Cheers. :cowboy:
    6
    Side note:
    To clear/reset Magisk, you need to delete /data/adb/magisk.db
    Magisk will regenerate magisk.db on (re)boot.

    Helpful if your Magisk install becomes corrupt, sometimes just regenerating magisk.db will fix the issue(s).

    Cheers. :cowboy:

    That tricks saved my bacon many times over a few years

    I also back it up and restore it on new ROM flashes, install magisk, put it back, reboot and then rename magisk app, before restoring my apps...then by default none of them can detect root on install. Its the partly (along with restoring the original Android ID i used on original ROM setup) how i keep everything (Galaxy Watch connection, Samsung Pay, banking apps etc) working across ROM flashes with my Migrate backups...

    Oddly ive never corrupted one doing that :)
  • 1055
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p