• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
Is there an advantage in utilizing Magisk Lite versus other versions of Magisk?
Not for most: It breaks normal use of modules for example. Seems its sole purpose / only advantage is for those desperate to pass SafetyNet for bank apps detecting "root" through isolated processes, or interested in testing MagiskHide with this ability.
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85103873

Alpha Magisk from same dev is best bet for those simply wanting newer updates / fixes at present:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85103975 PW
 
Last edited:

DiamondJohn

Recognized Contributor
Aug 31, 2013
5,558
5,309
Sydney
Is there an advantage in utilizing Magisk Lite versus other versions of Magisk?
I have never installed it nor used it or even followed what the heck it is. However, it looks like the direction Magisk will be heading in, in the future. The advantage in my eyes is best to find any roadblocks and soln now, before they become a sticking point.
 

DiamondJohn

Recognized Contributor
Aug 31, 2013
5,558
5,309
Sydney
The lastest magisk zip or boot.img patch ia not working on samsung TAB A SM-T285 (Lollipop)
I flash the correct zip file so many time and it flash the success on TWRP but after reboot the manager showes Installed : N/A. Then I read the magisk blog instructions and patch the boot img file but the result is same. The only thing is working the older version of magisk but I want to up to date so please fix this bug or announce a new method for samsung lollipop version.
I dont know your device, however, I have owned older devices, and on those devices, I cannot run the latest software. Maybe your device running lollipop is just not ready for running the latest of software in other regards. Lollipop is getting old.
 
  • Like
Reactions: J.Michael

73sydney

Senior Member
Jul 21, 2018
1,864
1,610
Sydney
Google Pixel 2 XL
The lastest magisk zip or boot.img patch ia not working on samsung TAB A SM-T285 (Lollipop)
I flash the correct zip file so many time and it flash the success on TWRP but after reboot the manager showes Installed : N/A. Then I read the magisk blog instructions and patch the boot img file but the result is same. The only thing is working the older version of magisk but I want to up to date so please fix this bug or announce a new method for samsung lollipop version.

I have an old Samsung Galaxy Tab 3 10.1 (GT-P5210) and it wont support Magisk above v20. Just the way it is.

Im afraid you just have to realise your request will go into the "wont be fixed" list sorry
 

rodken

Senior Member
Jan 11, 2010
559
131
Google Pixel XL
OnePlus 8
@pndwal What would be the difference in these three versions?
stub.png
 

pndwal

Senior Member
@pndwal What would be the difference in these three versions?View attachment 5338879
Just download/use the app-release.apk as per my linked notes.

Not sure why app-32bit.release.apk and app-64bit.release.apk have been left there, but they're clearly not up to date in any case.

stub-release.apk is called (as per json file link) for 'Hide the Magisk app' function if online when selecting this, but this Alpha will use a local stub apk otherwise. (See changelog "- use the local version when you can not download stub, can be completely offline now Magisk") You don't download that manually. 👍 PW
 

rodken

Senior Member
Jan 11, 2010
559
131
Google Pixel XL
OnePlus 8
Just download/use the app-release.apk as per my linked notes.

Not sure why app-32bit.release.apk and app-64bit.release.apk have been left there, but they're clearly not up to date in any case.

stub-release.apk is called (as per json file link) for 'Hide the Magisk app' function if online when selecting this, but this Alpha will use a local stub apk otherwise. (See changelog "- use the local version when you can not download stub, can be completely offline now Magisk") You don't download that manually. 👍 PW
Since using this Alpha version, have you seen any updates come through the pipes automatically via the Alpha channel or this one of those situations where I have to 'hunt down' and manually install any future updates of the Alpha build?
 

zgfg

Senior Member
Oct 10, 2016
5,730
3,181
Since using this Alpha version, have you seen any updates come through the pipes automatically via the Alpha channel or this one of those situations where I have to 'hunt down' and manually install any future updates of the Alpha build?
Having Alpha for cca 10-14 days, there were no updates so far

As you were responded, install app-release.apk (17 days old as of today) - my download is 9.87 MB and with MD5 checksum: b989587f1ac9a1ff2ca03c87f017a3c7
 
Last edited:

rodken

Senior Member
Jan 11, 2010
559
131
Google Pixel XL
OnePlus 8
Having Alpha for cca 10-14 days, there were no updates so far

As you were responded, install app-release.apk (17 days old as of today) - my download is 9.87 MB and with MD5 checksum: b989587f1ac9a1ff2ca03c87f017a3c7
Correct me if I am wrong - I would have to repatch my boot.img with the alpha release in order to get this work in my favor because simply installing the alpha apk over the existing Magisk Manager is not an option.
 
  • Like
Reactions: J.Michael

zgfg

Senior Member
Oct 10, 2016
5,730
3,181
Correct me if I am wrong - I would have to repatch my boot.img with the alpha release in order to get this work in my favor because simply installing the alpha apk over the existing Magisk Manager is not an option.
Yes, first install Magisk Alpha apk and allow to finish the installation once you run the app (it will fetch the stub.apk)

Then, make sure that Alpha Update channel is selected in Settings

Use Install Magisk option to patch your (boot) image, flash and reboot - to obtain as on my screenshot

Important - to install Magisk Alpha app, you will probably have to uninstall Magisk Stable/Canary application (because of the missmatch in the apk package names and/or version number)
 

Attachments

  • IMG_20210615_165610.jpg
    IMG_20210615_165610.jpg
    206.6 KB · Views: 43
  • Like
Reactions: rodken

73sydney

Senior Member
Jul 21, 2018
1,864
1,610
Sydney
Google Pixel 2 XL
@pndwal and anyone using/testing riru-momohider

I got rapidly tired of adding the config files manually each flash, so i modded the riru-momohider module and added:

Code:
# Add config switches
ui_print "- Setting config"
options='isolated setns app_zygote_magic initrc'
for i in $options
do
    touch $DATA_DIR/"$i" && ui_print "- Setting config: $i" || ui_print "- Setting config: Failed to create config file"
done

just above the last two lines in customize.sh:

Code:
ui_print "- Setting permissions"
set_perm_recursive $MODPATH 0 0 0755 0644

Or if you like, i have attached my modded riru-momohider zip to this post
 

Attachments

  • Riru-MomoHider-Mod.zip
    323.4 KB · Views: 139

Primokorn

Senior Member
Nov 17, 2012
11,458
7,705
Hello,
My device is a Xiaomi Redmi Note 7 running crDroid 3.11 (Android 10) and Magisk 23.0 (23000).
SafetyNet is OK and I enabled Magisk Hide.
My banking app (Google Play link - com.prod.bca) still knows that I'm rooted, why?

I compared my configuration with my other devices (Oneplus 3T - crDroid Android 11) and I have no issue.
I have attached logs.
Thank you in advance for your support.
 

Attachments

  • magisk_log_2021-06-15T19-12-24Z.log
    16.7 KB · Views: 10

sporc10

Senior Member
Dec 21, 2014
50
13
I somehow locked myself out..
I had magisk installed and all working, then I hide magisk and freezed the repackaged app. Now I have the problem that I cant unfreeze it again, because the app I used to freeze doesn't work anymore (I suppose the root is missing).
What can I do, to get access to magisk again?
I tried to install the latest magisk apk, it says under magisk "Installed: N/A".
Any suggestions or ideas? Thank you
 

zgfg

Senior Member
Oct 10, 2016
5,730
3,181
I somehow locked myself out..
I had magisk installed and all working, then I hide magisk and freezed the repackaged app. Now I have the problem that I cant unfreeze it again, because the app I used to freeze doesn't work anymore (I suppose the root is missing).
What can I do, to get access to magisk again?
I tried to install the latest magisk apk, it says under magisk "Installed: N/A".
Any suggestions or ideas? Thank you
Sorry but it was really a bad and wrong idea to freeze the Magisk app (pretty sure, it was not suggested in this thread) - specially upon it was repackaged.
Without, you cannot grant root access, etc

And of course, your newly installed Magisk app cannot connect to Magisk because the old (repackaged and frozen one - doesn't matter) is still connected to Magisk DB - three were so many posts here about the same problem when the newly installed Magisk app shows N/A for Magisk because of the forgotten, old, repackaged Magisk mngr/app still installed

First, uninstall that newly installed Magisk app (simply from Settings, Apps)

Then, you must find your old, repackaged (and frozen) Magisk Manager/App and uninstall it, too

Unfortunately, when you did repackaging, the package name was randomized and you don't remember that randomized package name (another reason it should have not been frozen then)

Hopefully, you remember which app name you gave it instead of the Magisk mngr/app - try to find it under that name in Settings, Apps and try to uninstall it there (even since it was frozen)

Or, install an app Package Manager from Google Play, search in that app for the app name of your renamed/repackaged Magisk Manager/App.
You can probably uninstall it from that Package Manager but even if not, you can read there its randomized package name

The other way to find its randomized package name will be to use ADB comnand from PC:
adb shell pm list packages -d

That command lists package names for all your "pm disable-user ..." apps (that is, those apps you 'froze')

Look at the output list and if you see some totally strange/randomized package name, that one should correspond to your (frozen and) repackaged Magisk mngr/app

Once you detect its (randomized) package name, you will be able to 'un-freeze' by ADB:
adb shell pm enable <package-name>

and then you should be able to regularly uninstall it from Settings, Apps (or just open it, go to Settings, and take the Restore option to get it back to the 'normal', not renamed/randomized Magisk mngr/app)

Only then, if neccessry, install the new/updated Magisk app

PS: For all who cannot live without repackaging Magisk app.
Upon repackaging, open the app and take a screenshot - on top, under the App info, after Latest and Installed lines, you will see the line Package showing its randomized package name.
Save the screenshot for your reference - in case you ever 'freeze' it, you will know its randoized package name to un-freeze
 
Last edited:

pndwal

Senior Member
Hello,
My device is a Xiaomi Redmi Note 7 running crDroid 3.11 (Android 10) and Magisk 23.0 (23000).
SafetyNet is OK and I enabled Magisk Hide.
My banking app (Google Play link - com.prod.bca) still knows that I'm rooted, why?

I compared my configuration with my other devices (Oneplus 3T - crDroid Android 11) and I have no issue.
I have attached logs.
Thank you in advance for your support.
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85148739 👍 PW
 

Burt Squirtz

Senior Member
Feb 11, 2018
489
171
Not for most: It breaks normal use of modules for example. Seems its sole purpose / only advantage is for those desperate to pass SafetyNet for bank apps detecting "root" through isolated processes, or interested in testing MagiskHide with this ability.
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85103873

Alpha Magisk from same dev is best bet for those simply wanting newer updates / fixes at present:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85103975 PW
Will this show updates within the app itself? Or do we have to manually download and install new Alpha branch?

Over-joyed that someone is continuing on with the work. I thought we were done with magisk honestly. Has been Anxiety-inducing
 
Last edited:

pndwal

Senior Member
Will this show updates within the app itself? Or do we have to manually download and install new Alpha branch?

Over-joyed that someone is continuing on with the work. I thought we were done with magisk honestly. Has been Anxiety-inducing
Yes, it should with Alpha Channel set. This commit:
https://github.com/vvb2060/Magisk/commit/f2c6ee7bc2f5be6456a91e85424069e6da16a667

Not really new; @vvb2060's been a main colaborator and contributor of new functionality on (John Wu's) Magisk for some time now. 🙂

His 'Alpha' experimental builds have been available since Dec 2020, and he also has many test / experimental 'Lite' and 'MTK' builds going back to May 2020.
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85127113 PW
 
Last edited:

sporc10

Senior Member
Dec 21, 2014
50
13
Sorry but it was really a bad and wrong idea to freeze the Magisk app (pretty sure, it was not suggested in this thread) - specially upon it was repackaged.
Without, you cannot grant root access, etc

And of course, your newly installed Magisk app cannot connect to Magisk because the old (repackaged and frozen one - doesn't matter) is still connected to Magisk DB - three were so many posts here about the same problem when the newly installed Magisk app shows N/A for Magisk because of the forgotten, old, repackaged Magisk mngr/app still installed

First, uninstall that newly installed Magisk app (simply from Settings, Apps)

Then, you must find your old, repackaged (and frozen) Magisk Manager/App and uninstall it, too

Unfortunately, when you did repackaging, the package name was randomized and you don't remember that randomized package name (another reason it should have not been frozen then)

Hopefully, you remember which app name you gave it instead of the Magisk mngr/app - try to find it under that name in Settings, Apps and try to uninstall it there (even since it was frozen)

Or, install an app Package Manager from Google Play, search in that app for the app name of your renamed/repackaged Magisk Manager/App.
You can probably uninstall it from that Package Manager but even if not, you can read there its randomized package name

The other way to find its randomized package name will be to use ADB comnand from PC:
adb shell pm list packages -d

That command lists package names for all your "pm disable-user ..." apps (that is, those apps you 'froze')

Look at the output list and if you see some totally strange/randomized package name, that one should correspond to your (frozen and) repackaged Magisk mngr/app

Once you detect its (randomized) package name, you will be able to 'un-freeze' by ADB:
adb shell pm enable <package-name>

and then you should be able to regularly uninstall it from Settings, Apps (or just open it, go to Settings, and take the Restore option to get it back to the 'normal', not renamed/randomized Magisk mngr/app)

Only then, if neccessry, install the new/updated Magisk app

PS: For all who cannot live without repackaging Magisk app.
Upon repackaging, open the app and take a screenshot - on top, under the App info, after Latest and Installed lines, you will see the line Package showing its randomized package name.
Save the screenshot for your reference - in case you ever 'freeze' it, you will know its randoized package name to un-freeze
Yeah sure in retrospect it was stupid..
Thank you for your very detailed answer.

I uninstalled the new installed Magisk manager from setttings -> ok
In settings under all apps I can see the 'old' App which is just called 'Manager' and is stated as disabled -> ok

One point is still not clear for me:
What do do now? If I uninstall the 'Manager' App will I automatically get the old Magisk manager back? OR should I better use the adb command to reenable the renamed app?
 

zgfg

Senior Member
Oct 10, 2016
5,730
3,181
Yeah sure in retrospect it was stupid..
Thank you for your very detailed answer.

I uninstalled the new installed Magisk manager from setttings -> ok
In settings under all apps I can see the 'old' App which is just called 'Manager' and is stated as disabled -> ok

One point is still not clear for me:
What do do now? If I uninstall the 'Manager' App will I automatically get the old Magisk manager back? OR should I better use the adb command to reenable the renamed app?
You can do either one

If you uninstall, then just install again the newest Magisk app - you will not loose anything (modules, etc), just make sure that you enable MagiskHide again.
You can also repackage then the newly installed Magisk app

Otherwise, use the adb command to re-enable your old repackaged Magisk App or Mngr (depending how old it was)

In the first case you assure that you would have the latest Magisk app.
In the second case you may need to update (upon being re-enabled)!your Magisk app/mngr if you want (and that could possibly fail if you try to update from the repackaged app/mngr)

I would go for the first option, and then also update the Magisk itself (unless you have some old device where Magisk update/installation might fail)

Edit - maybe you have an option in Settings/Apps to enable the disabled/frozen old Magisk mngr/app, in that case you don't need to use adb command for the option (2)
 
Last edited:

sporc10

Senior Member
Dec 21, 2014
50
13
You can do either one

If you uninstall, then just install again the newest Magisk app - you will not loose anything (modules, etc), just make sure that you enable MagiskHide again.
You can also repackage then the newly installed Magisk app

Otherwise, use the adb command to re-enable your old repackaged Magisk App or Mngr (depending how old it was)

In the first case you assure that you would have the latest Magisk app.
In the second case you may need to update (upon being re-enabled)!your Magisk app/mngr if you want (and that could possibly fail if you try to update from the repackaged app/mngr)

I would go for the first option, and then also update the Magisk itself (unless you have some old device where Magisk update/installation might fail)

Edit - maybe you have an option in Settings/Apps to enable the disabled/frozen old Magisk mngr/app, in that case you don't need to use adb command for the option (2)
I went for the first option. I uninstalled the renamed package and installed the newest App.
It detects magisk again, thank you!
So it says the Magisk version is 21.1, if I want to update with the direct installation method it says "unable to detect target image". Any hints on this one?
 
  • Like
Reactions: J.Michael and zgfg

Top Liked Posts

  • 3
    I'm not noticing any problems either. Was just making a PSA for anybody who does use Riru that it's not going to work anymore, and it's not a bug -- it was intentionally disabled. People are freaking out in the alpha Telegram over the "bug," and I wanted to head that off over here
    Yup, looks like w/ a0fe78a7-alpha (maverick 😜) users needing any Riru solutions are out of luck.

    I'm guessing many of these modules will move to Zygisk base in due course.

    Those using needing USNF 2.x for September Google server end change can move back to 1.2.0 and older fixes changing model props. MagiskHide Props Config module Force Basic attestation option with similar late 'device selected from list' matching OEM configured is probably the best of these option. PW

    Screenshot_2021-09-25-09-21-04-544_com.topjohnwu.magisk.png
    Screenshot_2021-09-25-09-25-37-464_com.topjohnwu.magisk.jpg
    2
    Tried newest alpha, zygisk = No, ramdisk = yes, denylist(s) active and running (weird)
    Reverted to 0ab31ab0-alpha, zygisk = Yes...
    For now i'm happy with 9bf835e8-alpha
    Interestingly, I had such issues with 0ab31ab0-alpha with Riru enabled, but issue is gone for me in 61783ffc-alpha...

    You could try disabling Riru & USNF 2.x, rebooting, checking Zygisk status / settings, then enabling again; I needed this initially - actually uninstalled USNF, disabled Riru and rebooted before installing again... No issue since on RN8T.

    Of course this may be a per device issue.

    John and vvb2060 are still busy with implementation of Zygisk; this may help in next builds:
    https://github.com/topjohnwu/Magisk/pull/4720
    ... merged with Commits on Sep 24, 2021:
    https://github.com/vvb2060/Magisk/commits/app_zygote
    ... there'll be more too. PW
    2
    Interestingly, I had such issues with 0ab31ab0-alpha with Riru enabled, but issue is gone for me in 61783ffc-alpha...

    You could try disabling Riru & USNF 2.x, rebooting, checking Zygisk status / settings, then enabling again; I needed this initially - actually uninstalled USNF, disabled Riru and rebooted before installing again... No issue since on RN8T.

    Of course this may be a per device issue.

    John and vvb2060 are still busy with implementation of Zygisk; this may help in next builds:
    https://github.com/topjohnwu/Magisk/pull/4720
    ... merged with Commits on Sep 24, 2021:
    https://github.com/vvb2060/Magisk/commits/app_zygote
    ... there'll be more too. PW
    I have tried w/o any modules
    Toggled the zygisk button to enable, reboot, zygisk = No, but the button in settings stayed as toggled on, checked the logs, no trace of zygisk

    Tried toggled on and added denylist, reboot, zygisk = No, checked the logs, still no trace of zygisk, but the denylist ran and active.

    Reverting to 0ab31ab0-alpha, boom!!! zygisk = Yes, checked the logs, zygisk xhook was there.

    Tried all alpha before 0ab31ab0-alpha too (with zygisk in it), all the same result with zygisk xhook ran.

    ...running weirdly? or it is weird that they are running?
    It was weird they were running but with no zygisk
    2
    For me everything ok (I don't use and need riru): root, SN, V4A, WebView, you name it
    I'm not noticing any problems either. Was just making a PSA for anybody who does use Riru that it's not going to work anymore, and it's not a bug -- it was intentionally disabled. People are freaking out in the alpha Telegram over the "bug," and I wanted to head that off over here
    1
    So guys after tests I have to find out how I add squashfs support on twrp, cause I can't do much, what I saw is that when I rebooted to system magisk was not working like the first place, tried to boot to twrp and guess what, it booted to stock recovery, how? I didn't flash the stock recovery, I searched and I find out that when it booting to system everything I has flash goes back to stock, for this magisk don't work when I trying to boot with combo key, everything goes back to stock without flashing, so the patched recovery from magisk goes back to stock while booting, I will make more research!
    Behaviour is pretty standard w/ stock ROMs (eg MIUI):
    Note many devices will replace your custom recovery automatically during first boot. To prevent this, use Google to find the proper key combo to enter recovery. After typing fastboot reboot, hold the key combo and boot to TWRP. Once TWRP is booted, TWRP will patch the stock ROM to prevent the stock ROM from replacing TWRP. If you don't follow this step, you will have to repeat the install.
    https://twrp.me/xiaomi/xiaomimi9tpro.html

    Nb. as mentioned, installing Magisk zip installer from TWRP will only succeed if bootloader contains 'boot' ramdisk support to allow basic ramdisk added by Magisk to be utilised... Of course you may be considering other custom recovery tricks. 😛 PW
  • 44
    OK. AIO solution. Modded "Universal SafetyNet Fix" module. Just added "model" props.
    17
    So, new layer of HARDWARE detection is here.
    SafetyNet failed on devices, where must bee HARDWARE detection. GMS no longer check system response of evaluation type, and force check HW. USNF doesn't work in this cause.
    Hm, funny things happening. I was thinking this is upgrade of HW attestation, but it is DOWNGRADE actually. 😄

    Remember my old first simple digging into HW?
    It`s..... working again.

    Looks like a temporary solution or just "combo" of old and new methods from Google.
    This explains the fact that dirty hack with Xposed-s working now.

    So, this current environment may be temporary or preparation for something BIGGER.

    In conclusion: in this time to passing SafetyNet you need just my old "hardware_off" module from link above or "MagiskHidePropsConf" with any "BASIC" print with model simulation and kdrag0n-s "Universal SafetyNet Fix".

    No ***-posed-s need!
    16
    Few Headsups:

    1) There are reports that Danny's (@kdrag0n) new early release Universal SafetyNet Fix 2.0.0 (combines AOSP Keystore and shim Keystore solutions) is restoring ctsProfile for some. It just may work for all, but not enough reports as yet. Also, it requires a payment at this stage:
    https://forum.xda-developers.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/post-85581909

    https://github.com/kdrag0n/safetynet-fix/pull/13#issuecomment-904209677

    2) There are reports that simply using MagiskHide Props Config module to 'delete' ro.product.model prop fixes ctsProfile on custom ROMs where other methods have failed. Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912885628

    3) New MagiskHide Props Config module 6.0.0 just released with all the sensitive prop values that MagiskHide changed up to and including Magisk v23 set by default, "Force BASIC key attestation" re-enabled (for Googles latest changes), and various other fixes.
    https://forum.xda-developers.com/t/...p-edits-and-more-v6-0-0.3789228/post-85581939

    I have to agree that this module's name does suddenly seem very apt, and as always, it proves elegant in its versatility. 😛👍

    4) Another elegant solution that some may have relegated to a bygone era seems to be coming back in fashion to!

    Those with Google Pay problems persisting after fixing ctsProfile are reporting in GPay threads, here and elsewhere, that GPay-SQLite-Fix + SQLite binary modules from stylemessiah (a connoisseur at least in digital fashion ... or perhaps just lucky, our @73sydney, - original solution from @BostonDan ) is fixing these for them once again. 😜 Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912798412

    WOT 😉 to read if interested:
    https://forum.xda-developers.com/t/...s-of-gms-17-1-22-on-pie.3929950/post-79643248

    🤠 PW
    15
    ro.product.model was enough for my OP8T, but I didn't like how Google Play Services started referring to my device as "OnePlus BASIC" with the "hardware off" module, so I knocked together this module really quickly to just append _SN to the real model name. WFM. 🤘
    14
    Removed the @Displax safety net mod fix and applied the latest USNF 2.1.0 from @kdrag0n.

    Attestation is passed and device is compliant in company portal too with my original device name 1+8 Pro and not Pixel.

    This is done over the latest Alpha Magisk.

    Update: My In-display fingerprint hardware is not working anymore, I think the fix is already committed. Hopefully it will be resolved in the next version.
    Yep, I have sent a Pull Request with the fix like an hour after v2.1.0 was released. 🤠

    See my post here in the official USNF thread for getting it working in the meantime until it's merged and a new release is made: https://forum.xda-developers.com/t/...tynet-fix-1-1-0.4217823/page-59#post-85631613

    Also may be worth everyone reading my comments at the end of that post about people doubting the sponsored testing closed-then-open development.

    And then here on this GitHub issue about how it's not meant to replace MagiskHide so you can't just turn Hide off: https://github.com/kdrag0n/safetynet-fix/issues/91#issuecomment-919264624
  • 1064
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p