• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

zgfg

Senior Member
Oct 10, 2016
5,721
3,174
I went for the first option. I uninstalled the renamed package and installed the newest App.
It detects magisk again, thank you!
So it says the Magisk version is 21.1, if I want to update with the direct installation method it says "unable to detect target image". Any hints on this one?
Can you post the screenshot showing your Magisk main window to see the versions

Are you on Stable?
And sorry, you probably posted but what is your phone and ROM?

You could try patching your image but maybe it would also fail (might be that v23 does not install to your phone)
 

sporc10

Senior Member
Dec 21, 2014
50
13
Can you post the screenshot showing your Magisk main window to see the versions

Are you on Stable?
And sorry, you probably posted but what is your phone and ROM?

You could try patching your image but maybe it would also fail (might be that v23 does not install to your phone)
Magisk:
Installed: 21.1 (21100), A/B: Yes, Ramdisk: No, SAR: Yes
App:
Newest: 23.0(23000)
Installed: 23.0 (23000)

I am using an PH-1 with an Android 11 Rom (Build: RQ1A.201205.010)

The main 'problem' I had is solved. I have Magisk back and so far everything is working.
If I get some sparetime I will have a look on patching the boot.img. Until then I will go with the actual setup. So once again thank you for the great support!
 
  • Like
Reactions: zgfg and J.Michael

pndwal

Senior Member
Magisk:
Installed: 21.1 (21100), A/B: Yes, Ramdisk: No, SAR: Yes
App:
Newest: 23.0(23000)
Installed: 23.0 (23000)

I am using an PH-1 with an Android 11 Rom (Build: RQ1A.201205.010)

The main 'problem' I had is solved. I have Magisk back and so far everything is working.
If I get some sparetime I will have a look on patching the boot.img. Until then I will go with the actual setup. So once again thank you for the great support!
Nice / interesting device.

Is 11 ROM modified pixel ROM?

Did you install from custom recovery originally?

"unable to detect target image" (both from custom recovery or App direct Install) is often due to fstab not containing the info where the boot block device is, or missing symlinks with proper names, making it impossible to detect where your boot image partition is. (Could be messed up vendor partition, or other.)

I'm not sure this is your problem as you did get it installed (unless pre-rooted?), but patching image manually should overcome it if it is. PW
 
Last edited:

pndwal

Senior Member
Magisk:
Installed: 21.1 (21100), A/B: Yes, Ramdisk: No, SAR: Yes
App:
Newest: 23.0(23000)
Installed: 23.0 (23000)

I am using an PH-1 with an Android 11 Rom (Build: RQ1A.201205.010)

The main 'problem' I had is solved. I have Magisk back and so far everything is working.
If I get some sparetime I will have a look on patching the boot.img. Until then I will go with the actual setup. So once again thank you for the great support!
A bit further; - I did a little digging into this because I was surprised to see a report of an A/B device w/ Ramdisk = No.

I hadn't seen (factory boot) ramdisk status change before, and I'm pretty sure it isn't meant to.

Clearly, your PH-1 is SAR by Google's definition (legacy SAR by John Wu's.) See this:
https://topjohnwu.github.io/Magisk/boot.html
and is a Type II device with a recovery ramdisk in boot partition.

Devices with any type of ramdisk in boot partition should show Ramdisk = Yes, ie. all types I, II & IV.

Type III are the ONLY type that have no ramdisk in stock (factory) boot partition! ... And these often (but not always) lack bootloader support even for manually added ramdisk in boot partition. See table here:
https://topjohnwu.github.io/Magisk/boot.html#piecing-things-together

So it seems to me there's something peculiar (messed up?) with your device, perhaps related to TWRP which resides in boot partition on Type II devices if you have this and Magisk has patched the already TWRP patched boot image. Or perhaps related to a pre-built modded boot image, Android 11 ROM (seems to be a custom port?), device tree used, etc, etc.

Anyway, I'm betting that those on stock images (including the recovery part of boot.img) w/ Magisk patched boot.img only, have Ramdisk = Yes in Magisk App...

Root guide here:
https://forum.xda-developers.com/t/guide-rooting-your-essential-ph-1.3701976/

Incidentally, I noticed here that @ipdev has PH-1 also. Perhaps he can help with configuration, Ramdisk status, etc. 😜 PW
 
Last edited:

ipdev

Recognized Contributor
Feb 14, 2016
1,503
1
1,885
Google Nexus 10
Nexus 7 (2013)
Magisk:
Installed: 21.1 (21100), A/B: Yes, Ramdisk: No, SAR: Yes
App:
Newest: 23.0(23000)
Installed: 23.0 (23000)

I am using an PH-1 with an Android 11 Rom (Build: RQ1A.201205.010)

The main 'problem' I had is solved. I have Magisk back and so far everything is working.
If I get some sparetime I will have a look on patching the boot.img. Until then I will go with the actual setup. So once again thank you for the great support!
What ROM are you using?
Are you porting/bringing up a rom?

Let me know and I will give it a try. :)

A bit further; - I did a little digging into this because I was surprised to see a report of an A/B device w/ Ramdisk = No.

I hadn't seen (factory boot) ramdisk status change before, and I'm pretty sure it isn't meant to.

Clearly, your PH-1 is SAR by Google's definition (legacy SAR by John Wu's.) See this:
https://topjohnwu.github.io/Magisk/boot.html
and is a Type II device with a recovery ramdisk in boot partition.

Devices with any type of ramdisk in boot partition should show Ramdisk = Yes, ie. all types I, II & IV.

Type III are the ONLY type that have no ramdisk in stock (factory) boot partition! ... And these often (but not always) lack bootloader support even for manually added ramdisk in boot partition. See table here:
https://topjohnwu.github.io/Magisk/boot.html#piecing-things-together

So it seems to me there's something peculiar (messed up?) with your device, perhaps related to TWRP which resides in boot partition on Type II devices if you have this and Magisk has patched the already TWRP patched boot image. Or perhaps related to a pre-built modded boot image, Android 11 ROM (seems to be a custom port?), device tree used, etc, etc.

Anyway, I'm betting that those on stock images (including the recovery part of boot.img) w/ Magisk patched boot.img only, have Ramdisk = Yes in Magisk App...

Root guide here:
https://forum.xda-developers.com/t/guide-rooting-your-essential-ph-1.3701976/

Incidentally, I noticed here that @ipdev has PH-1 also. Perhaps he can help with configuration, Ramdisk status, etc. 😜 PW

Essential PH-1 (mata) is basically a sister to Pixel 2/XL.
Save for PH1's bootloader not having a boot option.
- You could flash taimen's system image on mata and everything normally worked.


I haven't fired mine up in a while, normally just use it for testing. ;)

---

Installed the current lineage 18.1 nightly...
Using lineage's recovery.

- Patched the boot image with Magisk canary.
- Flashed the patched image and booted.
- Direct install worked fine.

Cheers. :cowboy:

PS.
When PH-1 was supported, before Essential closed their doors, all the official builds had a ramdisk in boot.
It is what I used to pull the monthly fingerprint and security patch date from.

PPS.
The l18.1 boot image boots AOSP Android 10 GSI on mata. ;)
“We don't make mistakes, just happy little accidents.” - Bob Ross.
 

Attachments

  • Screenshot_20210618-185728_Settings.png
    Screenshot_20210618-185728_Settings.png
    167.2 KB · Views: 53
  • Screenshot_20210618-185746_Settings.png
    Screenshot_20210618-185746_Settings.png
    96.3 KB · Views: 54
  • Screenshot_20210618-185814_Settings.png
    Screenshot_20210618-185814_Settings.png
    102.2 KB · Views: 53
  • Like
Reactions: sporc10 and pndwal

pndwal

Senior Member
What ROM are you using?
Are you porting/bringing up a rom?

Let me know and I will give it a try. :)

Essential PH-1 (mata) is basically a sister to Pixel 2/XL.
Save for PH1's bootloader not having a boot option.
This made me think, but guess meant Fastboot option!?
- You could flash taimen's system image on mata and everything normally worked.

I haven't fired mine up in a while, normally just use it for testing. ;)
---
Installed the current lineage 18.1 nightly...
Using lineage's recovery.

- Patched the boot image with Magisk canary.
- Flashed the patched image and booted.
- Direct install worked fine.

Cheers. :cowboy:

PS.
When PH-1 was supported, before Essential closed their doors, all the official builds had a ramdisk in boot.
It is what I used to pull the monthly fingerprint and security patch date from.

PPS.
The l18.1 boot image boots AOSP Android 10 GSI on mata. ;)
Many thanks for info, especially confirmation A11 (LOS 18.1) works as expected on PH-1. 👌
“We don't make mistakes, just happy little accidents.” - Bob Ross.
🤩 PW
 
Last edited:
  • Like
Reactions: ipdev

ipdev

Recognized Contributor
Feb 14, 2016
1,503
1
1,885
Google Nexus 10
Nexus 7 (2013)
This made me think, but guess meant Fastboot option!?

Many thanks for info, especially confirmation A11 (LOS 18.1) works as expected on PH-1. 👌

🤩 PW
There are a few oddities/drawbacks with Essential PH-1 (mata).

Not being able to fastboot boot is one of them.
Broken touch in recovery is another.

You can not temporarily boot a boot or recovery image.
Only option is to flash it using fastboot.

Taught us mata users how to work around some things. ;)

Cheers. :cowboy:
 
  • Like
Reactions: pndwal

pndwal

Senior Member
There are a few oddities/drawbacks with Essential PH-1 (mata).

Not being able to fastboot boot is one of them.
Ah yes:
Unlike the Pixel devices, Essential has disabled fastboot boot so there is no way to temporarily boot TWRP to perform an installation.
https://twrp.me/essential/essentialph1.html

Broken touch in recovery is another.
FWIW, seems that issue only occurs if using Official pre-built TWRP (link above) w/ post Sept 2018 ROMs as it hasn't been updated since Sept 10 2018.

Simply replacing Official "initial copy of TWRP" with this TWRP patched boot image should fix touch:
https://drive.google.com/file/d/1YxJJj96Web0ikHXdHf_zboZT_KSYl7Nj/view
according to:
https://forum.xda-developers.com/t/guide-rooting-your-essential-ph-1.3701976/

Next, updating your system by patching boot images for later builds with the TWRP Installer "will allow touch to work flawlessly".

Still, compatibility should be considered using such an old TWRP build.

Additional Information:

I saw this in 2nd post from link above:
No Touch in TWRP

Some day you may end up with a firmware that doesn’t play well with twrp. Either no touch screen, or no data decryption.

One quick way to flash a zip in this situation is to put the device in sideload mode via an adb command:
adb shell twrp sideload

then flash your zip using adb sideload:
adb sideload myawesomezip.zip

No Touch when moving from 8/2018 -> 9/2018 Pie builds

Read this post.

TL;DR: Basically essential updated two firmware files byp and rpm. These two images were left out of the September fastboot.zip and the older versions from August 2018 and prior are incompatible September going forward.

Simply fastboot flash both of these images to the byp and rpm partitions respectively.
https://mata.readthedocs.io/en/latest/

Nb. seems correct partitions are hyp & rpm.

So sideload can be used to patch active slot boot.img with TWRP Installer zip despite broken touch in initial TWRP (in inactive slot)... Or a TWRP patched boot image from a post Sept. ROM build should fix touch (for initial boot only) as it will be compatible with later hyp and rpm files... Or a mouse and OTG adapter can work... Or you could even obtain old hyp and rpm images from pre Sept. 2018 ROM and replace newer ones in inactive slot with these to get Official initial pre-built TWRP working.... 😜
https://forum.xda-developers.com/t/official-twrp-3-2-3-0-for-essential-ph-1.3840931/post-77597383

Taught us mata users how to work around some things. ;)
Yup, "Necessity is the mother of invention".

I agree with that much from Plato... Alfred Whitehead and Agatha Christie can have their opinions. 😬 PW
 
Last edited:
  • Like
Reactions: ipdev

Joingoin

New member
Jun 19, 2021
4
2
Redmi K20 / Xiaomi Mi 9T
Hey im having trouble installing Magisk and im now searching Help here!

I already installed Magisk once and already faced troubles back then. To sum them up:
I own a Xaomi Mi 9T and have to flash to Recovery, back then i got it to work with an image i patched with Canary-Branch of Magisk.
After an Update of my Phone i have to reinstall.

Reinstall with Canary or Normal Branch Magisk Patched Recovery-Image didnt work, it always boots back to Fastboot.
What i´ve tried so far:
Patch Image with different Magisk Versions.
Use different Images.
Remove any remaining Magisk Modules using TWRP.

Attached is the only usefull Log i could find, i hope its usefull to you.
Last_Log

Thanks for all your answers in advance!
 

zgfg

Senior Member
Oct 10, 2016
5,721
3,174
Hey im having trouble installing Magisk and im now searching Help here!

I already installed Magisk once and already faced troubles back then. To sum them up:
I own a Xaomi Mi 9T and have to flash to Recovery, back then i got it to work with an image i patched with Canary-Branch of Magisk.
After an Update of my Phone i have to reinstall.

Reinstall with Canary or Normal Branch Magisk Patched Recovery-Image didnt work, it always boots back to Fastboot.
What i´ve tried so far:
Patch Image with different Magisk Versions.
Use different Images.
Remove any remaining Magisk Modules using TWRP.

Attached is the only usefull Log i could find, i hope its usefull to you.
Last_Log

Thanks for all your answers in advance!
For Xiaomi Mi 9T:
- extract boot img from your recovery/zip firmware (or from tgz/fastboot firmware) or use boot.emmc.win from your TWRP backup)
- then patch that boot.img (Recovery option must be disabled by default)
- then flash the patched img to Boot partition

Yes, that is the procedure - although Magisk app says Ramdisk No, nevertheless patch the boot.img (not recovery.img) and everything will be ok

On Recovery, keep the stock recovery or use the latest official twrp-3.5.2_9-0-davinci.img
 

Joingoin

New member
Jun 19, 2021
4
2
Redmi K20 / Xiaomi Mi 9T
For Xiaomi Mi 9T:
- extract boot img from your recovery/zip firmware (or from tgz/fastboot firmware) or use boot.emmc.win from your TWRP backup)
- then patch that boot.img (Recovery option must be disabled by default)
- then flash the patched img to Boot partition

Yes, that is the procedure - although Magisk app says Ramdisk No, nevertheless patch the boot.img (not recovery.img) and everything will be ok

On Recovery, keep the stock recovery or use the latest official twrp-3.5.2_9-0-davinci.img
Thanks alot for your reply.

The installation worked now, sadly Wifi doesnt seem to be working now.
I flashed the boot image a second time already since google said so ;D.

Any other ideas?
 

zgfg

Senior Member
Oct 10, 2016
5,721
3,174
Thanks alot for your reply.

The installation worked now, sadly Wifi doesnt seem to be working now.
I flashed the boot image a second time already since google said so ;D.

Any other ideas?
Disable all Magisk modules you may have, reboot and try again

When I used to be on stock (EEA, MIUI 10-12, Android 9-10) I never had a problem with WiFi

For the last 6-7 months I'm on Xiaomi.eu weekly MIUI 12.6, Android 11 builds, also no problem with WiFi (or anything)
 
  • Like
Reactions: J.Michael

Joingoin

New member
Jun 19, 2021
4
2
Redmi K20 / Xiaomi Mi 9T
Disable all Magisk modules you may have, reboot and try again

When I used to be on stock (EEA, MIUI 10-12, Android 9-10) I never had a problem with WiFi

For the last 6-7 months I'm on Xiaomi.eu weekly MIUI 12.6, Android 11 builds, also no problem with WiFi (or anything)
Nah still no luck., ive turned of Magisk Hide and my Saftey-Net fix both.
To specifiy: I cant turn on the Wifi, it instantly turns itself off again!
 
  • Like
Reactions: J.Michael

zgfg

Senior Member
Oct 10, 2016
5,721
3,174
Nah still no luck., ive turned of Magisk Hide and my Saftey-Net fix both.
To specifiy: I cant turn on the Wifi, it instantly turns itself off again!
Are you sure that problems started when you installed Magisk

Disable Mobile Data and test if WiFi stays connected then

Generally, check if similar problem was reported on the Mi 9T forum or ask there (particularly for your firmware, you didn't say are you on Global, EEA, China, Russia or India and what is your particular MIUI and Android version, like V12.0.5.0.QFJEUXM, V12.1.2.0.RFJMIXM, etc):
 
Last edited:
  • Like
Reactions: J.Michael

Joingoin

New member
Jun 19, 2021
4
2
Redmi K20 / Xiaomi Mi 9T
Are you sure that problems started when you installed Magisk

Disable Mobile Data and test if WiFi stays connected then

Generally, check if similar problem was reported on the Mi 9T forum or ask there (particularly for your firmware, you didn't say are you on Global, EEA, China, Russia or India and what is your particular MIUI and Android version, like V12.0.5.0.QFJEUXM, V12.1.2.0.RFJMIXM, etc):
Yeah, im 100% sure it started when i installed magisk.
The problem is not that i cant connect to a network, i cant even turn on Wifi to even at least scan for networks.
Mobile Data seems to connect but doesnt provide internet!

Im on Global MIUI 12.0.5.0


EDIT: I Downloaded the offical ROM from Xaomis Site and Patched and Flashed it and its still not working :/
 
Last edited:
  • Like
Reactions: J.Michael

pndwal

Senior Member
Yeah, im 100% sure it started when i installed magisk.
The problem is not that i cant connect to a network, i cant even turn on Wifi to even at least scan for networks.
Mobile Data seems to connect but doesnt provide internet!

Im on Global MIUI 12.0.5.0


EDIT: I Downloaded the offical ROM from Xaomis Site and Patched and Flashed it and its still not working :/
Just checking, Recovery mode is unchecked when patching? PW
 
  • Like
Reactions: J.Michael

J.Michael

Recognized Contributor
Jan 20, 2018
838
702
Samsung Galaxy Tab A series
Yeah, im 100% sure it started when i installed magisk.
The problem is not that i cant connect to a network, i cant even turn on Wifi to even at least scan for networks.
Mobile Data seems to connect but doesnt provide internet!

Im on Global MIUI 12.0.5.0


EDIT: I Downloaded the offical ROM from Xaomis Site and Patched and Flashed it and its still not working :/
When you flash official ROM, before trying to install Magisk, does wifi work?
 

pndwal

Senior Member
Yeah, im 100% sure it started when i installed magisk.
The problem is not that i cant connect to a network, i cant even turn on Wifi to even at least scan for networks.
Mobile Data seems to connect but doesnt provide internet!

Im on Global MIUI 12.0.5.0


EDIT: I Downloaded the offical ROM from Xaomis Site and Patched and Flashed it and its still not working :/
Bit further:
WiFi issues w/ Magisk are usually a result of flashing mismatched patched boot image. (Search closed GitHub issues.)

I noticed latest MIUI for Mi 9T Global Stable appears to be V12.0.8.0.QFJMIXM, as of 2021-04-13.
https://xiaomifirmwareupdater.com/miui/davinci/

Mi 9T EEA is V12.0.5.0.QFJEUXM, and V12.0.5.0 is latest for other variants also.

Mi 9T Global Stable V12.0.5.0.QFJMIXM came out in 2020-10-10.
https://xiaomifirmwareupdater.com/archive/miui/davinci/

Please make sure both current ROM (Global MIUI 12.0.5.0 ?) and boot.img you patched / flashed is actually Mi 9T Global variant as well as same version (build); These must normally be an exact match, especially because boot image contains the kernel which must be compatible with system...

Otherwise, consider updating to Mi 9T Global Stable V12.0.8.0.QFJMIXM, (Nb. Mi 9T Global Stable Beta (Recovery type) V12.1.2.0.RFJMIXM Android 11.0 ROM is another available option) and be sure to extract / patch / flash boot image from this also. PW
 
Last edited:

pndwal

Senior Member
Some early news

Latest @vvb2060 Magisk Alpha build (June 23, 2021) change log:​

Chinese Translated:

alpha update log​

Magisk (1eb83ad8-alpha)​

  • Based on 1eb83ad8, please refer to the upstream update log for related modifications
  • Properly process any data from magiskd
  • Support SharedUserId
  • Delete the backup file after restoring the boot image
  • Built-in current version update log
  • Use the local version when the stub cannot be downloaded, now Magisk can be used completely offline
  • Support bootimg v4 format
  • Support bootconfig
  • Detect /data/adb/magisk/ not updated and prompt to repair
Edit:
Following are new commits:
  • Remove the disabled and pending deletion marks when upgrading the module, and it is not allowed to mark as pending deletion before restarting
  • Fix that it cannot be flashed in some TWRP
  • Modify the search order of the module sepolicy location and fix the problem that some devices do not load the module sepolicy
  • Listen to the PACKAGE_FULLY_REMOVED broadcast to remove completely uninstalled apps from magiskhide
  • Display the modal waiting pop-up window when hiding/restore the Magisk application
https://github.com/vvb2060/Magisk/b...af4f3d37e69/app/src/main/res/raw/changelog.md

My earlier notes:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85098469

Current notes:

[It seems this build is only partially rolled out 3hrs ago, and magisk_files repo is not yet updated with package files.] Repo us now updated! Check 'earlier notes' for installation method / details.

I am not expecting Alpha build users will see Update button notice in Magisk App for this build (as with last build) as Version has (again) NOT been changed from "1eb83ad8-alpha". Again, I'm not sure if this is intended.

[I'll be sure to update here when package files have been uploaded.] Now updated as mentioned above.

Edit: Package already available on Telegram:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85229385
See post after next for details.

Interestingly, in Magisk Documentation, @vvb2060 has updated "Internal Details" (Delete wrong info) and "Deployment"
(Add exploit conditions).
https://github.com/vvb2060/Magisk/tree/alpha/docs

😛 PW
 
Last edited:

pndwal

Senior Member
Some early news

Nb. It seems Lite builds will likely be of interest only to those wanting basic superuser privileges, and a way to hide root from bank apps that detect isolated processes, at least at this stage:

Latest @vvb2060 Magisk Lite build (June 23, 2021) change log:​

Chinese Translated:

Magisk Lite​

In Magisk in the whitelist mode, all applications are hidden by default, and only the applications ticked in Hide can obtain super user permissions. adb shell automatically has super user privileges. Module function is not available.

'magiskhide add UID package name' to add super-user application
'magiskhide rm UID package name' to remove super-user application
'magiskhide ls' lists the super-user applications

Magisk (1eb83ad8-lite)​

  • Based on 1eb83ad8, please refer to the upstream update log for related modifications
  • Properly process any data from magiskd
  • Support SharedUserId
  • Delete the backup file after restoring the boot image
  • Built-in current version update log
  • Use the local version when the stub cannot be downloaded, now Magisk can be used completely offline
  • Support bootimg v4 format
  • Support bootconfig
  • Detect /data/adb/magisk/ not updated and prompt to repair
Edit:
Following are new commits:
  • Remove the disabled and pending deletion marks when upgrading the module, and it is not allowed to mark as pending deletion before restarting
  • Fix that it cannot be flashed in some TWRP
  • Modify the search order of the module sepolicy location and fix the problem that some devices do not load the module sepolicy
  • Display the modal waiting pop-up window when hiding/restore the Magisk application
https://github.com/vvb2060/Magisk/b...a1bc0ad2802/app/src/main/res/raw/changelog.md

My earlier notes:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85082149

Current notes:

This seems to be only partially rolled out 1hr ago, and magisk_files repo is not yet updated with package files.

I'll be sure to update here when package files have been uploaded.

😛 PW
 
Last edited:

Top Liked Posts

  • 10
    MOD ACTION:

    Enough is enough. Despite my deleting some off topic posts yesterday, the spam continues. Thread cleaned. Please check your PM inbox and avoid off topic posts.
    3
    Need quick help with the installation instructions https://topjohnwu.github.io/Magisk/install.html

    Under "Patching Images" it says I need the boot.img (cause my OP 5T has RAM disk), but where can I download it?

    Thanks in advance

    Edit: I'm running lineage OS with microG
    From the LOS install zip file.
    Unzip that file, you should find a boot.img in there. That's what Magisk needs.
    If you have a boot.img.br file, just uncompress it first with brotli.
    2
    For those running vvb2060's alpha builds.

    You should be able to install any of the alpha builds over each other.
    The versionName is changing GitShortHead-alpha.
    The versionCode is remaining 23001.

    The versionCode is what triggers the upgrade/downgrade install.
    PackageManager only see that you are re-installing version 23001. ;)

    With that being said, you might run into a problem with magisk.db that was generated by an older/newer build.
    There was a very recent commit about this. (Currently the last commit on John's repo.)​
    Magisk - GitHub - commit - f7c0e40
    Also the last commit in vvb2060's repo currently.


    You might have an issues repacking a Magisk boot image.
    For testing purposes you should always use your ROM's stock boot image.
    Yes testing the updating logic is important but, you need a base line to compare.​
    A clean install may fail when an update succeeds and vice versa.

    Cheers all. :cowboy:
    Good to know, thx

    Hopefully, if I make a copy of /data/adb/magisk.db before trying the next Alpha, I will be able to restore the database if I would have to go back to b6298f86-alpha
    1
    Hi,

    Does snapchat work with the Magisk and corresponding modules for hiding? I've been out of rooting scene for long, so I don't know. The last time snapchat was able to detect it.

    Thanks.
    1
    Thanks. I thought it was somewhere on the magisk github
    Boot image is part of your firmware. Imagine how many phones and models and their firmwares are around (usually, each OTA installs its own, new boot img)

    What would Magisk have with them, who would collect and manage a thousand of those boot images on the Magisk Github pages?!

    Btw, when you take a simple search you will find here on XDA a subforum for almost every phone, e g. for your One Plus 5T.
    There you find a section named Guides and another Questions and Answers.
    That is the place where users for the particular phone share the knowledge where to find and download their firmwares, how to unpack them (for some phones they are not ZIP files), etc, etc
    It is worth (not to say a must) to look there first for the device specific questions like yours - you cannot expect that other users here with maybe Samsung, XPeria phones or who knows, could give you correct (and trustful!) answers for your One Plus

    Btw, that's the pretty old device and TWRP must be available, hence Magisk can still be flashed through TWRP (with no need for finding a boot img, patching and flashing, although that is not really a rocket science)
  • 44
    OK. AIO solution. Modded "Universal SafetyNet Fix" module. Just added "model" props.
    17
    So, new layer of HARDWARE detection is here.
    SafetyNet failed on devices, where must bee HARDWARE detection. GMS no longer check system response of evaluation type, and force check HW. USNF doesn't work in this cause.
    Hm, funny things happening. I was thinking this is upgrade of HW attestation, but it is DOWNGRADE actually. 😄

    Remember my old first simple digging into HW?
    It`s..... working again.

    Looks like a temporary solution or just "combo" of old and new methods from Google.
    This explains the fact that dirty hack with Xposed-s working now.

    So, this current environment may be temporary or preparation for something BIGGER.

    In conclusion: in this time to passing SafetyNet you need just my old "hardware_off" module from link above or "MagiskHidePropsConf" with any "BASIC" print with model simulation and kdrag0n-s "Universal SafetyNet Fix".

    No ***-posed-s need!
    16
    Few Headsups:

    1) There are reports that Danny's (@kdrag0n) new early release Universal SafetyNet Fix 2.0.0 (combines AOSP Keystore and shim Keystore solutions) is restoring ctsProfile for some. It just may work for all, but not enough reports as yet. Also, it requires a payment at this stage:
    https://forum.xda-developers.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/post-85581909

    https://github.com/kdrag0n/safetynet-fix/pull/13#issuecomment-904209677

    2) There are reports that simply using MagiskHide Props Config module to 'delete' ro.product.model prop fixes ctsProfile on custom ROMs where other methods have failed. Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912885628

    3) New MagiskHide Props Config module 6.0.0 just released with all the sensitive prop values that MagiskHide changed up to and including Magisk v23 set by default, "Force BASIC key attestation" re-enabled (for Googles latest changes), and various other fixes.
    https://forum.xda-developers.com/t/...p-edits-and-more-v6-0-0.3789228/post-85581939

    I have to agree that this module's name does suddenly seem very apt, and as always, it proves elegant in its versatility. 😛👍

    4) Another elegant solution that some may have relegated to a bygone era seems to be coming back in fashion to!

    Those with Google Pay problems persisting after fixing ctsProfile are reporting in GPay threads, here and elsewhere, that GPay-SQLite-Fix + SQLite binary modules from stylemessiah (a connoisseur at least in digital fashion ... or perhaps just lucky, our @73sydney, - original solution from @BostonDan ) is fixing these for them once again. 😜 Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912798412

    WOT 😉 to read if interested:
    https://forum.xda-developers.com/t/...s-of-gms-17-1-22-on-pie.3929950/post-79643248

    🤠 PW
    15
    ro.product.model was enough for my OP8T, but I didn't like how Google Play Services started referring to my device as "OnePlus BASIC" with the "hardware off" module, so I knocked together this module really quickly to just append _SN to the real model name. WFM. 🤘
    14
    Removed the @Displax safety net mod fix and applied the latest USNF 2.1.0 from @kdrag0n.

    Attestation is passed and device is compliant in company portal too with my original device name 1+8 Pro and not Pixel.

    This is done over the latest Alpha Magisk.

    Update: My In-display fingerprint hardware is not working anymore, I think the fix is already committed. Hopefully it will be resolved in the next version.
    Yep, I have sent a Pull Request with the fix like an hour after v2.1.0 was released. 🤠

    See my post here in the official USNF thread for getting it working in the meantime until it's merged and a new release is made: https://forum.xda-developers.com/t/...tynet-fix-1-1-0.4217823/page-59#post-85631613

    Also may be worth everyone reading my comments at the end of that post about people doubting the sponsored testing closed-then-open development.

    And then here on this GitHub issue about how it's not meant to replace MagiskHide so you can't just turn Hide off: https://github.com/kdrag0n/safetynet-fix/issues/91#issuecomment-919264624
  • 1062
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p