• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

ipdev

Recognized Contributor
Feb 14, 2016
1,500
1
1,871
Google Nexus 10
Nexus 7 (2013)
In general yes.

This seems to be another device specific issue.
In the case of OnePlus 6T, you do not have to restore stock images first. ;)
I added a post-script note to my prior post.
Edit:
PS.
If I remember correctly, OnePlus OTA updater would detect root/modified system.
So it would download/install the full version instead of an incremental/partial update.​

Cheers. :cowboy:
 

osm0sis

Senior Recognized Developer / Contributor
Mar 14, 2012
14,737
33,265
Halifax
GT-i9250
Nexus 7 (2013)
In general yes.

This seems to be another device specific issue.
In the case of OnePlus 6T, you do not have to restore stock images first. ;)
I added a post-script note to my prior post.
Edit:
PS.
If I remember correctly, OnePlus OTA updater would detect root/modified system.
So it would download/install the full version instead of an incremental/partial update.​

Cheers. :cowboy:
Depends on the device. On 8T and newer, which use the new "Google OTA" (Google Play services meditates the OTA) process, it'll do incremental regardless of root status. Also, to make it even more complicated, that's only on International/North American variant OOS and only on stable ROM channel.

Edit: Now that there's a working kebab TWRP my next trick will be to see if the post-reboot OTA checks might pass with it reinstalled in between, since then we could reroot while avoid the bootloader/PC steps; there's a chance it might since it's a recovery_a/_b device. I'll check into that with the next security update my 8T gets. 🙂🤞
 
Last edited:

jons99

Senior Member
Nov 5, 2019
201
237
In general yes.

This seems to be another device specific issue.
In the case of OnePlus 6T, you do not have to restore stock images first. ;)
I added a post-script note to my prior post.
Edit:

PS.

If I remember correctly, OnePlus OTA updater would detect root/modified system.

So it would download/install the full version instead of an incremental/partial update.


Cheers. :cowboy:
yeah since op otas contain all the original images you don't need to restore the original images (I happen to own the op6 as a secondary device to my pixel 5) but in google devices you need to restore the original images before you can install magisk to the inactive slot
on older op devices at least
cheers
 
  • Like
Reactions: pndwal and ipdev

pndwal

Senior Member
As I sayd, I uninstalled only the Magisk app/icon.
I am at oxygen is and after every reboot I must uninstall the app/icon.
Sure. But I asked 1) 'how did you set up (install) the App?', and 2) if it's 'pre-installed with ROM' (Seems you have OnePlus device with OOS? Is that unofficial, or stock ROM? If unofficial, please cite link to ROM) or 3) if App is 'merged as a system app' (ie 'systemised') and 4) if you 'just deleted the home screen icon!...

You didn't answer any of these questions.😕

Please state specific device, ROM, Magisk version and installation method. 👍 PW
 
  • Like
Reactions: J.Michael

spevil07

Senior Member
Mar 16, 2012
1,092
571
Sure. But I asked 1) 'how did you set up (install) the App?', and 2) if it's 'pre-installed with ROM' (Seems you have OnePlus device with OOS? Is that unofficial, or stock ROM? If unofficial, please cite link to ROM) or 3) if App is 'merged as a system app' (ie 'systemised') and 4) if you 'just deleted the home screen icon!...

You didn't answer any of these questions.😕

Please state specific device, ROM, Magisk version and installation method. 👍 PW
1. Installed Magisk over twrp
2. It's not pre-installed / oneplus stock oos A10
3. App isn't system app
4. Uninstalled Magisk app/icon as every app like WhatsApp

Oneplus 7 pro, stock oos, Magisk-23.0(23000), installed over twrp

I hope all questions are now answered
 
  • Like
Reactions: ipdev and pndwal

jons99

Senior Member
Nov 5, 2019
201
237
1. Installed Magisk over twrp
2. It's not pre-installed / oneplus stock oos A10
3. App isn't system app
4. Uninstalled Magisk app/icon as every app like WhatsApp

Oneplus 7 pro, stock oos, Magisk-23.0(23000), installed over twrp

I hope all questions are now answered
dude how do you even pass safetynet without magisk hide? I mean look at pndwal for example he doesn't uninstall magisk yet magisk is undetectable maybe instead of asking pndwal how to uninstall magisk ask him how to hide it properly
 

ipdev

Recognized Contributor
Feb 14, 2016
1,500
1
1,871
Google Nexus 10
Nexus 7 (2013)
Good morning, tell me do someone know if there is a possibility that the Magisk app is not constantly reinstalled after a reboot?

I usually uninstalled the app for online banking, but it's back after every reboot.

I don't want uninstall Magisk/root completely, only the Magisk app.

I tried to rename and hide magisk for my banking apps but it's not working.

Uninstalling Magisk app works fine but after every reboot it's back again.

I was a little confused but, I had an idea that I just checked.
The Magisk stub app seems to be reinstalled while Magisk is active.

I did not go all in and delete my magisk.db but, I assume the stub app would not be reinstalled.
or boot a non-magisk boot image.

This was a quick check.
Anyone can test it. Just uninstall the Magisk app and reboot.

It is the same result once Magisk is configured. Did not matter what device or Magisk installation.

Nexus 7 (2013)
ARM | Lineage 18.1 | Magisk (canary) installed by flashing in TWRP.​

Pixel 3aXL
ARM64 | abcROM (Android 11) | Magisk (canary) installed by patching boot image.​

I never had a reason to uninstall the Magisk app so, I never noticed it before.
I am guessing that if someone has time to look, they will find something in the Magisk release notes about it.

Cheers. :cowboy:
 
  • Like
Reactions: 73sydney and pndwal

ipdev

Recognized Contributor
Feb 14, 2016
1,500
1
1,871
Google Nexus 10
Nexus 7 (2013)
dude how do you even pass safetynet without magisk hide? I mean look at pndwal for example he doesn't uninstall magisk yet magisk is undetectable maybe instead of asking pndwal how to uninstall magisk ask him how to hide it properly
Once you configure Magisk, the app is not necessary.
Magisk settings are stored in magisk.db

You only need the app to configure Magisk.

MagiskHide will still be active unless you turned it off before uninstalling the app.
Root access will still be granted to the processes that you granted it to.
Modules will still load on boot.

I have never used them but, you can configure some Magisk options from command line.

Cheers. :cowboy:
 

pndwal

Senior Member
1. Installed Magisk over twrp
2. It's not pre-installed / oneplus stock oos A10
3. App isn't system app
4. Uninstalled Magisk app/icon as every app like WhatsApp

Oneplus 7 pro, stock oos, Magisk-23.0(23000), installed over twrp
I was a little confused but, I had an idea that I just checked.
The Magisk stub app seems to be reinstalled while Magisk is active.

I did not go all in and delete my magisk.db but, I assume the stub app would not be reinstalled.
or boot a non-magisk boot image.

This was a quick check.
Anyone can test it. Just uninstall the Magisk app and reboot.

It is the same result once Magisk is configured. Did not matter what device or Magisk installation.

Nexus 7 (2013)
ARM | Lineage 18.1 | Magisk (canary) installed by flashing in TWRP.​

Pixel 3aXL
ARM64 | abcROM (Android 11) | Magisk (canary) installed by patching boot image.​

I never had a reason to uninstall the Magisk app so, I never noticed it before.
I am guessing that if someone has time to look, they will find something in the Magisk release notes about it.

Cheers. :cowboy:
I had a feeling it'd have something to do with stub, but I think you've put your finger right on it. 👍

Just tested, first with Alpha setup w/ App hidden. -

Uninstalled app, rebooted, checked and App / Magisk stub was gone from app draw, but Magisk stub was indeed still present in device settings / Manage apps.

Another reboot and stub shows in app drawer / launcher. Clicking brings dialogue asking to download/setup full app.

Next, tried after unhiding App, then uninstall and reboot -

Surprised to see stub still returns!

Had a thought it may be unique Alpha behaviour as this will use local stub when hiding App, so next reverted to regular Canary (both App and Magisk mask) and tried again w/ App hidden, then uninstall and reboot -

Stub still returns.

Next, tried after unhiding App, then uninstall and reboot -

Stub still returns.

(So seems official builds save stub locally also, but use server based stub when hiding!)

My feeling is that there should / may be a way to prevent stub being loaded on reboot, especially if Hide the Magisk app is not selected; probably an easy code edit for someone to identify / post. 😉

ATM I haven't investigated or discovered a a way to disable stub loading at boot time. PW
 
  • Like
Reactions: ipdev and J.Michael

xAxB

Member
Mar 9, 2017
23
7
Great.

Did it flash / boot w/ Magisk root ok?... Also, I'm interested to know if 'Preserve force encryption' is checked or unchecked by default for your device. 👍 PW

To answer your question, 'Preserve force encryption' was checked by default for my device. I bought this device second hand, and it has been upgraded to Android 10 on arrival. I am not sure if the upgrade in itself converted the system to FBE though.

Unfortunately, I am not able to confirm Magisk root works for the Tab S4, with the latest update as I am having trouble with Odin. I tried Odin 3.13.1 and 3.14.1, with three cables and 4 USB ports (though only one is USB 2.0) but while Odin detects my device fine, it simply won't flash the device (doing nothing at either initialisation or setup connection) , not even the most recent stock rom, so I am probably out of luck until I can find another computer to try on.

(Though I am leaning towards the issue being something about my setup not working well with Odin, part of me also wonder if there isn't something wrong with this second hand tablet that makes it not play nice with Odin.. not sure if that kind of issues happen)
 
  • Like
Reactions: pndwal

pndwal

Senior Member
I usually uninstalled the app for online banking, but it's back after every reboot.

I don't want uninstall Magisk/root completely, only the Magisk app.

I tried to rename and hide magisk for my banking apps but it's not working.

Uninstalling Magisk app works fine but after every reboot it's back again.
Bit further on this; can I assume you tried using the standard 'Hide the Magisk app' function in Magisk App settings? - I'm not sure why this wouldn't work... PW
 

pndwal

Senior Member
To answer your question, 'Preserve force encryption' was checked by default for my device. I bought this device second hand, and it has been upgraded to Android 10 on arrival. I am not sure if the upgrade in itself converted the system to FBE though.
Ta. Is it also SAR = Yes?
Unfortunately, I am not able to confirm Magisk root works for the Tab S4, with the latest update as I am having trouble with Odin. I tried Odin 3.13.1 and 3.14.1, with three cables and 4 USB ports (though only one is USB 2.0) but while Odin detects my device fine, it simply won't flash the device (doing nothing at either initialisation or setup connection) , not even the most recent stock rom, so I am probably out of luck until I can find another computer to try on.
Sounds like driver / permission issues on PC?

Not sure of Odin requirements... Take it you confirmed bootloader is unlocked... Have you tried with USB Debugging enabled and checked OEM unlocking is Allowed in Developer options?

A suggestion with ZERO Sammy experience. 😬 :

I saw several guides to root your device w/ Magisk and earlier OS builds, but all involved downloading a prepatched boot image (must be matched to specific ROM version), but imsmc, simply flashing patched boot image did work for your (originally non-SAR) device.

There are also TWRP implementations available.

Official TWRP specifies using Odin to install, but I see you can also get to ADB / Fastboot for this device. Here's a guide using Fastboot to unlock bootloader:
https://www.mobilewithdrivers.com/unlock-bootloader/samsung-galaxy-tab-s4-64gb-4gb-ram

So if you can obtain a .img format TWRP, you can likely flash or simply boot to it (I'd boot it rather than flash) using PC ADB Fastboot connection, then take a TWRP backup of boot.img, locate and rename backup .win file to .img, boot system and patch that from Magisk App, boot TWRP again to flash Magisk-patched image...

Again, I have no Sammy experience, but this (or a variation) may work for you. 😜

(Though I am leaning towards the issue being something about my setup not working well with Odin, part of me also wonder if there isn't something wrong with this second hand tablet that makes it not play nice with Odin.. not sure if that kind of issues happen)
Could be, especially if you obtained it with bootloader unlocked... PW
 

pndwal

Senior Member
26 is out
https://t.me/magiskalpha/324
The beta version does not send channels. Try to support oplus.fstab. No need to update the ones that are already available (translated changelog)
Thanks! I've now updated, all working fine on RN8T.

Latest @vvb2060 Magisk Alpha build (July 26, 2021) change:​

Chinese Translated:

Magisk (1eb83ad8-alpha-26)​

• Support oplus.fstab for Oppo series devices

Nb. This build is available only on Telegram at present. I'll post full Changelog here when available on GitHub.

Last GitHub build, notes, links:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85372173

🤠 PW
 
Last edited:

pndwal

Senior Member
OP Wellbeing Report 😀 :

John's growing up / happy with work... 🙂
John Wu, 3h

Oftenly I want to impulse tweet my "hot takes". Recent years I almost always end up not pressing the button. Having quite a few followers and is formerly/currently employed by Apple/Google, the trouble it could create is never worth it. I guess this is how growing up works, huh?

BTW, this has nothing to do with me being censored by my employers. I'm just reacting to the fact that I had just deleted yet another tweet from my draft after evaluating that it serves absolutely no purpose other than stirring unnecessary drama 🤣

Jane Manchun Wong, 3h

Would you have picked Apple / Google if you were given offers from companies not as closely related to mobile OS security research?

John Wu, 3h

My main priority is to have a stable footing to start my career, the job itself doesn't really matter that much when I'm looking for jobs. There are many other reasons why I chose Apple/Google haha. But I have to say, I'm currently very happy with my position at Google
www.twitter.com/topjohnwu/status/1419562776767340547

... Sometimes I forget he's so young. 😛 PW
 

Devilsho

Senior Member
May 15, 2018
218
91
Islamabad.
ASUS ROG Phone 3
every time i run any command this error came i googled tried everything solution but i dont know why this error.
i reinstall Magisk rooted again but stil this error

/system/bin/sh: pkg: inaccessible or not found

this error is not just for pkg update its for every thing.

Thanks in advance
 

Attachments

  • Screenshot_20210726-164526828.jpg
    Screenshot_20210726-164526828.jpg
    243 KB · Views: 44
  • Screenshot_20210726-171948080.jpg
    Screenshot_20210726-171948080.jpg
    352.6 KB · Views: 42
  • Screenshot_20210726-171850899.jpg
    Screenshot_20210726-171850899.jpg
    359.5 KB · Views: 43

dcarvil

Senior Member
Apr 20, 2016
464
246
every time i run any command this error came i googled tried everything solution but i dont know why this error.
i reinstall Magisk rooted again but stil this error

/system/bin/sh: pkg: inaccessible or not found

this error is not just for pkg update its for every thing.

Thanks in advance

You have to run pkg from the normal (non-root) prompt. It is not the way you expect it to work, but that is how it works on my device.
 

Top Liked Posts

  • 9
    @hfam I would suggest going with the latest stable release for now, since the Alpha releases are highly experimental and @topjohnwu will create an official release whenever he deems those changes to be a bit more mature.

    The official installation instructions is always a good place to start:
    https://topjohnwu.github.io/Magisk/install.html

    But I see that there are a few threads on this in the 5a threads as well:
    https://forum.xda-developers.com/t/magisk-root-procedure-for-5a-5g.4327361/

    It should be pretty straightforward, since it's a Pixel device. Just patch the boot image and flash it to your device.

    To pass SafetyNet you'll need to use the new Universal SafetyNet Fix as well (as long as you stay stock you shouldn't need anything else):
    https://github.com/kdrag0n/safetynet-fix

    Android 12 is gonna need some updates on the Magisk side, but that'll be taken care of in good time...

    Everything that's being discussed in this thread over the past weeks/months will probably be made much more clear once John releases his next build.
    6
    Got confirmation in the telegram channel.

    "It is not recommended to use 706a4922-alpha and later versions. Zygisk is in a very early stage of development and has serious problems.
    Even if you use it, please turn off the zygisk function.

    The current recommended version is the version in the update channel."

    The versions merged with the repo are the recommended versions of Magisk Alpha.

    The Zygisk versions are bleeding edge builds and not stable at all. Please refrain from installing them.

    Just check the latest version mentioned in your magisk app and that is the version you want to be in.
    6
    Welcome back!
    Man, I've been gone for quite a while, last Magisk I installed was v20 on my Pixel 2!! Coming back is like being dropped in the middle of a foreign land, and I could sure use a bit of encouragement and a small assist!

    I purchased 2 of the unlocked Pixel 5a 5G devices and they'll be here in a few days. M8 died and P2 battery is just useless at this point! :)

    That said, I've spent an hour or so reading the thread backwards from today and I see Magisk Alpha, zygote, MagiskHide is replaced with Deny List, etc...I am having trouble wrapping my head around some of this.
    Good start. If I were you:

    - I'd read John's Release Notes from your 20.x (?) version for best / official summary of changes. Major changes in 21.0 & 22.0:
    https://topjohnwu.github.io/Magisk/releases/
    I don't want to blow it with the install, so can someone point me in the right direction to get started? Magisk or Magisk Alpha?
    - I'd avoid Alpha, especially now that John has returned from limbo (with blessing of big G).

    Alpha's are Bleeding Edge test builds, bleeding more than usual presently and especially ATM are only for mavericks keeping pace with all TJW commits / willing to test w/ untold bugs and regressions, and not disposed to chewing off a foot when things go pear-shaped.
    No TWRP, I just keep it super stock, no OTAs, just updates using full images (remove -w) and flash-all. Anything to look out for in the Pixel 5a that is a major change affecting root, etc?

    I'm happy to read until I bleed to get it right, so even a few links on which Magisk to install, where to get it (if it's not on TJW's Magisk github), how to make sure I can hide apps (Deny List replaced MagiskHide?) and pass SafetyNet?
    - Install latest Stable or Canary from main GitHub page (these are synced / essentially identical currently). If taking direct install / update on old device, be sure to restore (unhide) Manager / App first, and disable modules especially after OTA's.

    No Zygisk, Denylist etc. in current TJW builds; (It'll be a big leap when it arrives), so no worries with that stuff till next Beta, and John usually updates documentation at the same time...

    - Familiarise yourself with changes to Installation Instruction:
    https://topjohnwu.github.io/Magisk/install.html
    and FAQs re. fixing issues (new Safe Mode fix for modules causing bootloop etc).
    https://topjohnwu.github.io/Magisk/faq.html

    For Stock certified ROM, enabling MagiskHide and installing latest Universal SafetyNet Fix module 2.1.1 + Riru should be enough to pass SafetyNet at present. USNF:
    https://forum.xda-developers.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/post-84286769

    Many changes in @Didgeridoohan's wiki regarding other issues too. First port of call if having problems:
    https://www.didgeridoohan.com/magisk/HomePage
    Thanks, and glad to see a lot of the folks who've been here forever still here helpin' out! Any assistance would be appreciated as always.
    All best. 🙂 PW

    Edit: I see there's some repetition here, but shouldn't hurt. 😛
    5
    I've been browsing the Magisk Alpha GitHub and it seems the older releases aren't available.

    Are they removed or I'm mistaken?

    Compass.
    They're in magisk_files repo:
    https://github.com/vvb2060/magisk_files/commits/alpha

    Click a commit (by date), then browse files, then view code. PW
    5
    @pndwal, @Didgeridoohan, (I see you too @zgfg!!), thank you both SO MUCH for the thoughtful and helpful and comprehensive replies!! So grateful, it's so good to be back and as always, the XDA Magisk family are truly the kindest most willingly helpful folks ever!

    Im all over this info, thanks again so much for the timely replies, I'm off to read, get up to date educated and get prepped for the phone arrivals!! I'll be back once I've blasted em with Magisk, thanks again!
  • 44
    OK. AIO solution. Modded "Universal SafetyNet Fix" module. Just added "model" props.
    17
    So, new layer of HARDWARE detection is here.
    SafetyNet failed on devices, where must bee HARDWARE detection. GMS no longer check system response of evaluation type, and force check HW. USNF doesn't work in this cause.
    Hm, funny things happening. I was thinking this is upgrade of HW attestation, but it is DOWNGRADE actually. 😄

    Remember my old first simple digging into HW?
    It`s..... working again.

    Looks like a temporary solution or just "combo" of old and new methods from Google.
    This explains the fact that dirty hack with Xposed-s working now.

    So, this current environment may be temporary or preparation for something BIGGER.

    In conclusion: in this time to passing SafetyNet you need just my old "hardware_off" module from link above or "MagiskHidePropsConf" with any "BASIC" print with model simulation and kdrag0n-s "Universal SafetyNet Fix".

    No ***-posed-s need!
    16
    Few Headsups:

    1) There are reports that Danny's (@kdrag0n) new early release Universal SafetyNet Fix 2.0.0 (combines AOSP Keystore and shim Keystore solutions) is restoring ctsProfile for some. It just may work for all, but not enough reports as yet. Also, it requires a payment at this stage:
    https://forum.xda-developers.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/post-85581909

    https://github.com/kdrag0n/safetynet-fix/pull/13#issuecomment-904209677

    2) There are reports that simply using MagiskHide Props Config module to 'delete' ro.product.model prop fixes ctsProfile on custom ROMs where other methods have failed. Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912885628

    3) New MagiskHide Props Config module 6.0.0 just released with all the sensitive prop values that MagiskHide changed up to and including Magisk v23 set by default, "Force BASIC key attestation" re-enabled (for Googles latest changes), and various other fixes.
    https://forum.xda-developers.com/t/...p-edits-and-more-v6-0-0.3789228/post-85581939

    I have to agree that this module's name does suddenly seem very apt, and as always, it proves elegant in its versatility. 😛👍

    4) Another elegant solution that some may have relegated to a bygone era seems to be coming back in fashion to!

    Those with Google Pay problems persisting after fixing ctsProfile are reporting in GPay threads, here and elsewhere, that GPay-SQLite-Fix + SQLite binary modules from stylemessiah (a connoisseur at least in digital fashion ... or perhaps just lucky, our @73sydney, - original solution from @BostonDan ) is fixing these for them once again. 😜 Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912798412

    WOT 😉 to read if interested:
    https://forum.xda-developers.com/t/...s-of-gms-17-1-22-on-pie.3929950/post-79643248

    🤠 PW
    15
    ro.product.model was enough for my OP8T, but I didn't like how Google Play Services started referring to my device as "OnePlus BASIC" with the "hardware off" module, so I knocked together this module really quickly to just append _SN to the real model name. WFM. 🤘
    14
    Removed the @Displax safety net mod fix and applied the latest USNF 2.1.0 from @kdrag0n.

    Attestation is passed and device is compliant in company portal too with my original device name 1+8 Pro and not Pixel.

    This is done over the latest Alpha Magisk.

    Update: My In-display fingerprint hardware is not working anymore, I think the fix is already committed. Hopefully it will be resolved in the next version.
    Yep, I have sent a Pull Request with the fix like an hour after v2.1.0 was released. 🤠

    See my post here in the official USNF thread for getting it working in the meantime until it's merged and a new release is made: https://forum.xda-developers.com/t/...tynet-fix-1-1-0.4217823/page-59#post-85631613

    Also may be worth everyone reading my comments at the end of that post about people doubting the sponsored testing closed-then-open development.

    And then here on this GitHub issue about how it's not meant to replace MagiskHide so you can't just turn Hide off: https://github.com/kdrag0n/safetynet-fix/issues/91#issuecomment-919264624
  • 1062
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p