• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

xAxB

Member
Mar 9, 2017
27
7
Ta. Is it also SAR = Yes?

Sounds like driver / permission issues on PC?

Not sure of Odin requirements... Take it you confirmed bootloader is unlocked... Have you tried with USB Debugging enabled and checked OEM unlocking is Allowed in Developer options?
A/B = No
Ramdisk = Yes
SAR = Yes

USB debugging is enabled and OEM unlocking is allowed in the developer options. I have a question though, if I am only trying to flash the current stock rom, a locked bootloader shouldn't be a problem right?

Truth to be said, I -do- wonder if my bootloader is fully unlocked. The Magisk installation guide mentions something about needing the IEM unlocked and greyed before it's truly unlocked (something to do with Samsung's 'Vaultkeeper'), but I following the steps to reproduce that from multiple guides, 'the volume up long press' option to enable 'Device unlock mode' in the warning screen (2:41 in this video, or in this guide) simply doesn't show for my device. As far as I know, the Vaultkeeper 'later' and I do wonder if it hasn't been introduced only from the Tab S5SE in the video and onward. but unfortunately I haven't been able to get any confirmation in the Tab S4 forum.

I saw several guides to root your device w/ Magisk and earlier OS builds, but all involved downloading a prepatched boot image (must be matched to specific ROM version), but imsmc, simply flashing patched boot image did work for your (originally non-SAR) device.

There are also TWRP implementations available.

Official TWRP specifies using Odin to install, but I see you can also get to ADB / Fastboot for this device. Here's a guide using Fastboot to unlock bootloader:
https://www.mobilewithdrivers.com/unlock-bootloader/samsung-galaxy-tab-s4-64gb-4gb-ram

So if you can obtain a .img format TWRP, you can likely flash or simply boot to it (I'd boot it rather than flash) using PC ADB Fastboot connection, then take a TWRP backup of boot.img, locate and rename backup .win file to .img, boot system and patch that from Magisk App, boot TWRP again to flash Magisk-patched image...

Again, I have no Sammy experience, but this (or a variation) may work for you. 😜


Could be, especially if you obtained it with bootloader unlocked... PW
Thanks for that guide, I didn't come across it. I did wonder if there isn't a work around from having to use Odin, but all my searches pointed toward having to use it on Sammys. But first thing first, I just want to be able to restore to a stock ROM first. If I am not mistaken, this shouldn't need an unlocked bootloader, and if something goes wrong in the process, I should at least be able to restore the system.

On a sidenote, the device came with the bootloader locked and Knox hasn't been tripped. I just kind of wondering if the previous owner -really- wanted a rooted device but after spending hours doing all the things I am doing now, gave up and flogged the device and perhaps the issue is something to do with the USB-C port on the tablet (in reality, I think it is unlikely - both the assumption that the previous owner might've wanted to root the device and there is something wrong with the port even though it charges and transfer files perfectly fine). I am pretty sure that I am on the latest Sammy driver, but I guess I will double check.

There is also one more port on my PC that I could try, but it is USB-C, so I am going to have to do it with a USB-C to USB-C cable, and the port will clearly -not- be a USB 2.0 port as many recommends.
 
  • Like
Reactions: J.Michael

BillGoss

Senior Member
Sep 2, 2010
4,728
4,145
Sydney
OnePlus 3T
OnePlus 8T
every time i run any command this error came i googled tried everything solution but i dont know why this error.
i reinstall Magisk rooted again but stil this error

/system/bin/sh: pkg: inaccessible or not found

this error is not just for pkg update its for every thing.

Thanks in advance
That's because Termux won't let you run the pkg command as root because it screws up the the installation. You must only run pkg as user.
Nothing to do with Magisk.
 

pndwal

Senior Member
A/B = No
Ramdisk = Yes
SAR = Yes
FWIW, seems Tab S4 (Launch version Android 8.1, API 27) was using legacy ramdisk boot method when launched since legacy SAR required API Level 28 (Android 9). This is boot method A, Type 1 device here:
https://topjohnwu.github.io/Magisk/boot.html

Also, updates have converted device to 2SI ramdisk SAR, Method C, Type IV device (Running version 29).

Nb, this boot method is not officially considered SAR by Google, (considers only Initial rootdir; how the kernel boots the device). It is SAR by Magisk’s (John's) definition (considers Final rootdir; what the device ends up using when fully booted)
USB debugging is enabled and OEM unlocking is allowed in the developer options. I have a question though, if I am only trying to flash the current stock rom, a locked bootloader shouldn't be a problem right?
Correct, as bootloader will accept signing keys for stock ROM. See Android Verified Boot:
https://source.android.com/security/verifiedboot
Truth to be said, I -do- wonder if my bootloader is fully unlocked. The Magisk installation guide mentions something about needing the IEM unlocked and greyed before it's truly unlocked (something to do with Samsung's 'Vaultkeeper'), but I following the steps to reproduce that from multiple guides, 'the volume up long press' option to enable 'Device unlock mode' in the warning screen (2:41 in this video, or in this guide) simply doesn't show for my device. As far as I know, the Vaultkeeper 'later' and I do wonder if it hasn't been introduced only from the Tab S5SE in the video and onward. but unfortunately I haven't been able to get any confirmation in the Tab S4 forum.
Looks like bootloader is likely locked. Is there no indication in download / Fastboot mode (padlock symbol, etc?)
Thanks for that guide, I didn't come across it. I did wonder if there isn't a work around from having to use Odin, but all my searches pointed toward having to use it on Sammys. But first thing first, I just want to be able to restore to a stock ROM first. If I am not mistaken, this shouldn't need an unlocked bootloader, and if something goes wrong in the process, I should at least be able to restore the system.

On a sidenote, the device came with the bootloader locked and Knox hasn't been tripped. I just kind of wondering if the previous owner -really- wanted a rooted device but after spending hours doing all the things I am doing now, gave up and flogged the device and perhaps the issue is something to do with the USB-C port on the tablet (in reality, I think it is unlikely - both the assumption that the previous owner might've wanted to root the device and there is something wrong with the port even though it charges and transfer files perfectly fine). I am pretty sure that I am on the latest Sammy driver, but I guess I will double check.

There is also one more port on my PC that I could try, but it is USB-C, so I am going to have to do it with a USB-C to USB-C cable, and the port will clearly -not- be a USB 2.0 port as many recommends.
Quite possible previous owner tried I guess.

Seems you'll need to sort out driver / Odin issues, try fastboot method(s), check bootloader status etc to get proper unlock and ability to flash Magisk.

Sammy users may be of more help. 😛 PW
 

xAxB

Member
Mar 9, 2017
27
7
Looks like bootloader is likely locked. Is there no indication in download / Fastboot mode (padlock symbol, etc?)
In the download mode, it also says that the OEM lock is "Off" leading me to think that it's probably unlocked fine. Wish a Tab S4 user could confirm it but it's kinda quiet over there lol.

(While I am at it though, there is a DID number that I often see people remove from photos - I imagine there must be some important security reason for that, but what is it? Simply Googling "DID Number Android" didn't yield anything that seem to explain it..
 

dcarvil

Senior Member
Apr 20, 2016
471
247
(While I am at it though, there is a DID number that I often see people remove from photos - I imagine there must be some important security reason for that, but what is it? Simply Googling "DID Number Android" didn't yield anything that seem to explain it..

Try googling 'Android "Device ID"' instead. Here is one link - https://www.gtricks.com/android/2-ways-to-find-android-device-id-and-change-it/

It is basically a device identifier, but it is tied to the Android installation, not the device hardware. It will change when you flash a different ROM.
 

jons99

Senior Member
Nov 5, 2019
206
241
27 is out and working well
photo_2021-07-27_13-26-44.jpg

 

pndwal

Senior Member

Latest @vvb2060 Magisk Alpha build (July 27, 2021) changelog:​

Chinese Translated:

alpha update log​

Magisk (1eb83ad8-alpha-27)​

  • Based on 1eb83ad8, please refer to the upstream update log for related modifications
  • Properly process any data from magiskd
  • Support SharedUserId
  • Delete the backup file after restoring the boot image
  • Built-in current version update log
  • Use the local version when the stub cannot be downloaded, now Magisk can be used completely offline
  • Support bootimg v4 format
  • Support bootconfig
  • Detect /data/adb/magisk/ not updated and prompt to repair
  • Remove the disabled and pending deletion marks when upgrading the module, and it is not allowed to mark as pending deletion before restarting
  • Repair can not be brushed in some TWRP
  • Listen to the PACKAGE_FULLY_REMOVED broadcast to remove completely uninstalled apps from magiskhide
  • Display the modal waiting pop-up window when hiding/restore the Magisk application
  • App adapted to Android 12
  • Android 12+ super user hides the screen overlay when the window pops up
  • For devices supported by the kernel, MagiskSU uses proprietary devpts to bypass some application detection
  • Rewrite MagiskSU's logic to open pty and delete extra sepolicy rules
  • Fix incorrect signal sending in MagiskHide
  • Add untrusted_app_30
Edit: New changes since last build on GitHub 1eb83ad8-alpha-25
  • Support oplus.fstab for oppo series devices
  • Prompt that some devices do not load the module sepolicy problem
  • Add mount information to the log file
https://github.com/vvb2060/Magisk/b...8916dd34ea8/app/src/main/res/raw/changelog.md

My earlier notes:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85098469

Current notes:

Check 'earlier notes' for installation method / details.

Alpha build users won't yet see Update button notice in Magisk App for this build as VersionCode has (again) NOT changed from 23001.

I'm not sure if this behaviour will be addressed, but users will observe the 'Latest' and 'Installed' version suffix now differs.

Latest in GitHub magisk_files repo is 1eb83ad8-alpha-27

Latest available from Telegram group is
1eb83ad8-alpha-27

https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85229385

Nb. In Magisk Documentation, @vvb2060 has updated "Internal Details" and "Deployment" since John did.
https://github.com/vvb2060/Magisk/tree/alpha/docs

🤠 PW
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
5,730
3,181
Updated to 27 - all ok

However, I paid attention and observed (like previously with 20 Jul or 25):
- I download the Alpha 27 apk, install, open, check SN, modules, Magisk hide
- all ok and it does not pop-up, not asking for additional setup and reboot
- I select and patch the img file (actually I patched two img files but it probably doesn't matter)
- few seconds later it pops up and asks for additional setup and reboot (screenshot)
- I accept, it reboots, I reopen Magisk app but it pops up again, asking the same again

This time I ignore and reboot manually to TWRP, flash the patched img and reboot - now it no more asks for any additional setup / reboot

If I chose Direct install, then that pop up asking for reboot would perfectly make sense, but not after just patching the boot.img
 

Attachments

  • Screenshot_2021-07-27-13-16-57-774_com.topjohnwu.magisk.jpg
    Screenshot_2021-07-27-13-16-57-774_com.topjohnwu.magisk.jpg
    327.9 KB · Views: 17
Last edited:

jons99

Senior Member
Nov 5, 2019
206
241
Updated to 27 - all ok

However, I paid attention and observed (like previously with 20 Jul or 25):
- I download the Alpha 27 apk, install, open, check SN, modules, Magisk hide
- all ok and it does not pop-up, not asking for additional setup and reboot
- I select and patch the img file (actually I patched two img files but it probably doesn't matter)
- few seconds later it pops up and asks for additional setup and reboot (screenshot)
- I accept, it reboots, I reopen Magisk app but it pops up again, asking the same again

This time I ignore and reboot manually to TWRP, flash the patched img and reboot - now it no more asks for any additional setup / reboot

If I chose Direct install, then that pop up asking for reboot would perfectly make sense, but not after just patching the boot.img
I think it's because the additional setup was made on the old patched boot img and after the direct install you have a new patched boot img not sure just a theory
 

rodken

Senior Member
Jan 11, 2010
559
131
Google Pixel XL
OnePlus 8
@73sydney Question: Taking the steps of installing the Alpha apk after unisntalling the Stable version, then patching the boot image and flashing the patched boot image warranted a factory reset. Was wondering when I give it another go - after uninstaling the John Wu's stable Magisk, I suppose that I could I just use TWRP to install the Alpha instead of using a patched boot image?
 
  • Like
Reactions: duttyend

jons99

Senior Member
Nov 5, 2019
206
241
@73sydney Question: Taking the steps of installing the Alpha apk after unisntalling the Stable version, then patching the boot image and flashing the patched boot image warranted a factory reset. Was wondering when I give it another go - after uninstaling the John Wu's stable Magisk, I suppose that I could I just use TWRP to install the Alpha instead of using a patched boot image?
you don't need to factory reset you can flash the alpha patched boot img ontop your existing boot img
or flash in twrp works as well
 
  • Like
Reactions: rodken

pndwal

Senior Member
Updated to 27 - all ok

However, I paid attention and observed (like previously with 20 Jul or 25):
- I download the Alpha 27 apk, install, open, check SN, modules, Magisk hide
- all ok and it does not pop-up, not asking for additional setup and reboot
- I select and patch the img file (actually I patched two img files but it probably doesn't matter)
- few seconds later it pops up and asks for additional setup and reboot (screenshot)
- I accept, it reboots, I reopen Magisk app but it pops up again, asking the same again

This time I ignore and reboot manually to TWRP, flash the patched img and reboot - now it no more asks for any additional setup / reboot

If I chose Direct install, then that pop up asking for reboot would perfectly make sense, but not after just patching the boot.img
Interesting...

Just took direct update, all fine, then patched 2 images for kicks to try to replicate you issue, but no such problem / pop-up on RN8T. 🙃

🤔 PW
 

zgfg

Senior Member
Oct 10, 2016
5,730
3,181
Interesting...

Just took direct update, all fine, then patched 2 images for kicks to try to replicate you issue, but no such problem / pop-up on RN8T. 🙃

🤔 PW
You were already on 27 after Direct Install.
I did Select and Parch only (like I also did first time with 20, Jul version when I observed and reported about that pop-up the first time)
I think it's because the additional setup was made on the old patched boot img and after the direct install you have a new patched boot img not sure just a theory
But I did not do Direct install at all. I only patched the stock boot.img (hence asking for reboot to system makes no sense)
 
Last edited:

xAxB

Member
Mar 9, 2017
27
7
Try googling 'Android "Device ID"' instead. Here is one link - https://www.gtricks.com/android/2-ways-to-find-android-device-id-and-change-it/

It is basically a device identifier, but it is tied to the Android installation, not the device hardware. It will change when you flash a different ROM.
Ahh thanks! Kinda funny I couldn't figure that out when I am 80% of why I am even trying to root in the first place is to change my Device ID Changer :)
 

73sydney

Senior Member
Jul 21, 2018
1,865
1,610
Sydney
Google Pixel 2 XL
@73sydney Question: Taking the steps of installing the Alpha apk after unisntalling the Stable version, then patching the boot image and flashing the patched boot image warranted a factory reset. Was wondering when I give it another go - after uninstaling the John Wu's stable Magisk, I suppose that I could I just use TWRP to install the Alpha instead of using a patched boot image?

Sorry for late reply, i spent the night trying my best to brick my Pixel 2XL by resizing the partitions and flashing an A12 Beta ...it did not go well :)
 
  • Haha
Reactions: duttyend and ipdev

zgfg

Senior Member
Oct 10, 2016
5,730
3,181
I guess the key is to ensure that I patch the original boot image and not some generic version that I found laying around in my cloud backup.
If you have TWRP, you can patch (without renaming or so) the TWRP backup boot.emmc.win

You can also save your patched img for e.g. Alpha 25 and later repatch by Alpha 27, etc
 
Last edited:
  • Like
Reactions: J.Michael

Didgeridoohan

Senior Moderator / Dev Committee / Dev Relations
Staff member
May 31, 2012
12,017
13,699
Gothenburg
Google Nexus 4
Nexus 6
@pndwal and @ipdev

I saw you guys did some testing on the mysterious reinstallation of an uninstalled Magisk app on a reboot. I present you with the changelog for Magisk v16.6:
[Daemon] Check whether a valid Magisk Manager is installed on boot, if not, install stub APK embedded in magiskinit
:p
 

Top Liked Posts

  • 3
    I'm not noticing any problems either. Was just making a PSA for anybody who does use Riru that it's not going to work anymore, and it's not a bug -- it was intentionally disabled. People are freaking out in the alpha Telegram over the "bug," and I wanted to head that off over here
    Yup, looks like w/ a0fe78a7-alpha (maverick 😜) users needing any Riru solutions are out of luck.

    I'm guessing many of these modules will move to Zygisk base in due course.

    Those using needing USNF 2.x for September Google server end change can move back to 1.2.0 and older fixes changing model props. MagiskHide Props Config module Force Basic attestation option with similar late 'device selected from list' matching OEM configured is probably the best of these option. PW

    Screenshot_2021-09-25-09-21-04-544_com.topjohnwu.magisk.png
    Screenshot_2021-09-25-09-25-37-464_com.topjohnwu.magisk.jpg
    2
    For me everything ok (I don't use and need riru): root, SN, V4A, WebView, you name it
    I'm not noticing any problems either. Was just making a PSA for anybody who does use Riru that it's not going to work anymore, and it's not a bug -- it was intentionally disabled. People are freaking out in the alpha Telegram over the "bug," and I wanted to head that off over here
    2
    Interestingly, I had such issues with 0ab31ab0-alpha with Riru enabled, but issue is gone for me in 61783ffc-alpha...

    You could try disabling Riru & USNF 2.x, rebooting, checking Zygisk status / settings, then enabling again; I needed this initially - actually uninstalled USNF, disabled Riru and rebooted before installing again... No issue since on RN8T.

    Of course this may be a per device issue.

    John and vvb2060 are still busy with implementation of Zygisk; this may help in next builds:
    https://github.com/topjohnwu/Magisk/pull/4720
    ... merged with Commits on Sep 24, 2021:
    https://github.com/vvb2060/Magisk/commits/app_zygote
    ... there'll be more too. PW
    I have tried w/o any modules
    Toggled the zygisk button to enable, reboot, zygisk = No, but the button in settings stayed as toggled on, checked the logs, no trace of zygisk

    Tried toggled on and added denylist, reboot, zygisk = No, checked the logs, still no trace of zygisk, but the denylist ran and active.

    Reverting to 0ab31ab0-alpha, boom!!! zygisk = Yes, checked the logs, zygisk xhook was there.

    Tried all alpha before 0ab31ab0-alpha too (with zygisk in it), all the same result with zygisk xhook ran.

    ...running weirdly? or it is weird that they are running?
    It was weird they were running but with no zygisk
    1
    tried the new alpha and it broke riru which broke lsposed and safetynet not recommended at least if you want to use riru I went back to previous one for now
    That's because they toggled a switch to stop Riru from working with Zygisk in the latest build. Apparently it causes issues
    1
    For me everything ok (I don't use and need riru): root, SN, V4A, WebView, you name it
  • 44
    OK. AIO solution. Modded "Universal SafetyNet Fix" module. Just added "model" props.
    17
    So, new layer of HARDWARE detection is here.
    SafetyNet failed on devices, where must bee HARDWARE detection. GMS no longer check system response of evaluation type, and force check HW. USNF doesn't work in this cause.
    Hm, funny things happening. I was thinking this is upgrade of HW attestation, but it is DOWNGRADE actually. 😄

    Remember my old first simple digging into HW?
    It`s..... working again.

    Looks like a temporary solution or just "combo" of old and new methods from Google.
    This explains the fact that dirty hack with Xposed-s working now.

    So, this current environment may be temporary or preparation for something BIGGER.

    In conclusion: in this time to passing SafetyNet you need just my old "hardware_off" module from link above or "MagiskHidePropsConf" with any "BASIC" print with model simulation and kdrag0n-s "Universal SafetyNet Fix".

    No ***-posed-s need!
    16
    Few Headsups:

    1) There are reports that Danny's (@kdrag0n) new early release Universal SafetyNet Fix 2.0.0 (combines AOSP Keystore and shim Keystore solutions) is restoring ctsProfile for some. It just may work for all, but not enough reports as yet. Also, it requires a payment at this stage:
    https://forum.xda-developers.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/post-85581909

    https://github.com/kdrag0n/safetynet-fix/pull/13#issuecomment-904209677

    2) There are reports that simply using MagiskHide Props Config module to 'delete' ro.product.model prop fixes ctsProfile on custom ROMs where other methods have failed. Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912885628

    3) New MagiskHide Props Config module 6.0.0 just released with all the sensitive prop values that MagiskHide changed up to and including Magisk v23 set by default, "Force BASIC key attestation" re-enabled (for Googles latest changes), and various other fixes.
    https://forum.xda-developers.com/t/...p-edits-and-more-v6-0-0.3789228/post-85581939

    I have to agree that this module's name does suddenly seem very apt, and as always, it proves elegant in its versatility. 😛👍

    4) Another elegant solution that some may have relegated to a bygone era seems to be coming back in fashion to!

    Those with Google Pay problems persisting after fixing ctsProfile are reporting in GPay threads, here and elsewhere, that GPay-SQLite-Fix + SQLite binary modules from stylemessiah (a connoisseur at least in digital fashion ... or perhaps just lucky, our @73sydney, - original solution from @BostonDan ) is fixing these for them once again. 😜 Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912798412

    WOT 😉 to read if interested:
    https://forum.xda-developers.com/t/...s-of-gms-17-1-22-on-pie.3929950/post-79643248

    🤠 PW
    15
    ro.product.model was enough for my OP8T, but I didn't like how Google Play Services started referring to my device as "OnePlus BASIC" with the "hardware off" module, so I knocked together this module really quickly to just append _SN to the real model name. WFM. 🤘
    14
    Removed the @Displax safety net mod fix and applied the latest USNF 2.1.0 from @kdrag0n.

    Attestation is passed and device is compliant in company portal too with my original device name 1+8 Pro and not Pixel.

    This is done over the latest Alpha Magisk.

    Update: My In-display fingerprint hardware is not working anymore, I think the fix is already committed. Hopefully it will be resolved in the next version.
    Yep, I have sent a Pull Request with the fix like an hour after v2.1.0 was released. 🤠

    See my post here in the official USNF thread for getting it working in the meantime until it's merged and a new release is made: https://forum.xda-developers.com/t/...tynet-fix-1-1-0.4217823/page-59#post-85631613

    Also may be worth everyone reading my comments at the end of that post about people doubting the sponsored testing closed-then-open development.

    And then here on this GitHub issue about how it's not meant to replace MagiskHide so you can't just turn Hide off: https://github.com/kdrag0n/safetynet-fix/issues/91#issuecomment-919264624
  • 1064
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p