• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

73sydney

Senior Member
Jul 21, 2018
1,907
1,670
Sydney
Google Pixel 2 XL
mmm. But it works out-of-the-box for me after setting Legacy mode, disabling then re-enabling module (2 reboots) as described... 🤔

Seems everyone needs Legacy mode though, but also seems to me no SELinux policy change is needed to reset the driver for this mode...

Has anyone else here tried resetting / fixing just by turning module off, then on again? ... Perhaps I'm missing something. PW

Theres not even legacy mode as an option for the version im using ...theres a compatibiliy mode switch, but thats it

Reason i and a lot of others use the Ichigo Viper zip is because its been the only one to work on A11 for us

Im not up to speed on all things Viper, as ive said before (and perhaps you dont understand my function here, lol) i just tend to repackage other peoples shizz to make it easier to use. Im all ears if theres better ways to do stuff
 

Attachments

  • v4a1.jpg
    v4a1.jpg
    13.1 KB · Views: 24
  • v4a2.jpg
    v4a2.jpg
    10.6 KB · Views: 23
  • v4a3.jpg
    v4a3.jpg
    15.9 KB · Views: 24
  • Like
Reactions: pndwal

73sydney

Senior Member
Jul 21, 2018
1,907
1,670
Sydney
Google Pixel 2 XL
This way with SEPolicy rules in the script has advantage for me when updating my Xiaomi.eu weekly ROMs:

- Without, I had to go through the procedure with disabling, re-enabling V4A, maybe also AML (it was described in my post I mentioned), then reconfiguring again V4A app (its settings)

- However, upon I added SEPolicy rules section to the script, I can simply install the zip with new ROM, flash its boot.img (prepared in advance) patched by Magisk (flashing one after another in TWRP) , then I reboot and everything (incl. Viper4Android) works out of the box

Hehe, theres a better explanation of the sepolicy stuff :)
 

zgfg

Senior Member
Oct 10, 2016
5,863
3,330
Hehe, theres a better explanation of the sepolicy stuff :)
Since I have also A11, you can try that nethod with V4A 2.7.1.2 instead of your older 2.7.1.6

SEPolicy rules I mention do not include SELinux Permissive, just:

allow audioserver audioserver_tmpfs file { read write execute }
allow audioserver system_file file { execmod }
allow mediaserver mediaserver_tmpfs file { read write execute }
allow mediaserver system_file file { execmod }
allow audioserver unlabeled file { read write execute open getattr }
allow hal_audio_default hal_audio_default process { execmem }
allow hal_audio_default hal_audio_default_tmpfs file { execute }
allow hal_audio_default audio_data_file dir { search }
allow app app_data_file file { execute_no_trans }
allow mtk_hal_audio mtk_hal_audio_tmpfs file { execute }

The point (follow-up to my previous post) is that sepolicy.rule file seems to be executed only when module was installed (and therefore overrulled to default when I later update the ROM)

Whereas the same SEPolicy rules commands put to post-fs-data.sh script are executed on each reboot (if Magisk is installed and V4A module enabled) - hence the V4A works again out-of-the-box even upon updating the ROM
 
  • Like
Reactions: pndwal

J.Michael

Recognized Contributor
Jan 20, 2018
874
739
Samsung Galaxy Tab A series
Seems there is some 'sowing' problem with 29 - anyone could maybe decipher what would that mean in the Magisk concept?

Anyway, be warned

Google Translation from the Alpha Telegram channel:

🎀:
Sudden sowization

bl Bloodfang:
Indeed, the sow turned ()

🎀:
If there is no problem, push to the update channel

Magisk alpha discussion group:
The above is the problem
sow -- female pig that has reproduced?
sow -- plant seeds?
 
  • Like
Reactions: 73sydney

pndwal

Senior Member
Theres not even legacy mode as an option for the version im using ...theres a compatibiliy mode switch, but thats it

Reason i and a lot of others use the Ichigo Viper zip is because its been the only one to work on A11 for us

Im not up to speed on all things Viper, as ive said before (and perhaps you dont understand my function here, lol) i just tend to repackage other peoples shizz to make it easier to use. Im all ears if theres better ways to do stuff
Yup, I'm getting that adding script can save reboots (X2) needed to reset driver on initial installation. 😜 ...

However I had wondered if SELinux changes were actually a necessity on some devices. It seems simple reboots / reset will still do the trick for the less time-conscious users, at least on latest 2.7.2.1 (Magisk repo).

Reason i and a lot of others use the Ichigo Viper zip is because its been the only one to work on A11 for us
I think @zgfg has 2.7.2.1 working on Android MIUI.

Also, I just installed it on my Mi Pad 4, LOS 18.1 (ie. Android 11, Alpha Magisk), and was surprised to find it needed only mandatory reboot after module Installation to work! 😛

I did this: installed Viper4Android FX from Magisk repo but instead of reboot immediately, opened Viper4Android FX App (it's already installed), let it install missing Neon driver then reboot, open Viper4Android FX, check driver status; it's Abnormal, select Legacy mode in settings, check driver status again and it's Normal / working! (No reset needed.)

Not sure if it's Android 11, AOSP standard ROM or other that allows swapping to Legacy mode to work immediately, but my RN8T on stock MIUI, Android 10 & Alpha Magisk needs driver reset incl. reboots to work. PW
 
Last edited:
  • Like
Reactions: 73sydney

73sydney

Senior Member
Jul 21, 2018
1,907
1,670
Sydney
Google Pixel 2 XL
Since I have also A11, you can try that nethod with V4A 2.7.1.2 instead of your older 2.7.1.6

SEPolicy rules I mention do not include SELinux Permissive, just:

allow audioserver audioserver_tmpfs file { read write execute }
allow audioserver system_file file { execmod }
allow mediaserver mediaserver_tmpfs file { read write execute }
allow mediaserver system_file file { execmod }
allow audioserver unlabeled file { read write execute open getattr }
allow hal_audio_default hal_audio_default process { execmem }
allow hal_audio_default hal_audio_default_tmpfs file { execute }
allow hal_audio_default audio_data_file dir { search }
allow app app_data_file file { execute_no_trans }
allow mtk_hal_audio mtk_hal_audio_tmpfs file { execute }

The point (follow-up to my previous post) is that sepolicy.rule file seems to be executed only when module was installed (and therefore overrulled to default when I later update the ROM)

Whereas the same SEPolicy rules commands put to post-fs-data.sh script are executed on each reboot (if Magisk is installed and V4A module enabled) - hence the V4A works again out-of-the-box even upon updating the ROM


Well now im confused, because the module im working on had as one of its "clean up" goals to remove the duplication of sepolicy.rule AND post-fs-data.sh

Adding to the mix is Johns last changelog for Magisk 23 including:

[General] Several sepolicy.rule copy/installation fixes

I would assume by that it was fucntioning properly to apply any sepolicy.rule files in a modules folder...but maybe not?

So i guess Ichigo was hedging his bets with having both (sepolicy.rule & post-fs-data.sh), but maybe that was trying to account for different magisk versions. Think its safe to say choosing one way would be best going forwards as most should be on 23 at least by now, one would hope. So we think post-fs-data is preferable, from the sound of it...

fwiw, riru-momohider does the same thing - doubles down with sepolicy.rule & post-fs-data....

Maybe i need to reevaluate messing with viper :)
 

73sydney

Senior Member
Jul 21, 2018
1,907
1,670
Sydney
Google Pixel 2 XL
Yup, I'm getting that adding script can save reboots (X2) needed to reset driver on initial installation. 😜 ...

However I had wondered if SELinux changes were actually a necessity on some devices. It seems simple reboots / reset will still do the trick for the less time-conscious users, at least on latest 2.7.2.1 (Magisk repo).


I think @zgfg has 2.7.2.1 working on Android MIUI.

Also, I just installed it on my Mi Pad 4, LOS 18.1 (ie. Android 11, Alpha Magisk), and was surprised to find it needed only mandatory reboot after module Installation to work! 😛

I did this: installed Viper4Android FX from Magisk repo but instead of reboot immediately, opened Viper4Android FX App (it's already installed), let it install missing Neon driver then reboot, open Viper4Android FX, check driver status; it's Abnormal, select Legacy mode in settings, check driver status again and it's Normal / working! (No reset needed.)

Not sure if it's Android 11, AOSP standard ROM or other that allows swapping to Legacy mode to work immediately, but my RN8T on stock MIUI, Android 10 & Alpha Magisk needs driver reset incl. reboots to work. PW

Imma try your method, but last time i tried with the repo version, it did not end well :)

edit:

wont even download the apk lol

Log: line 214: curl not found :)

time for Zacks Cross Compiled Binaries it seems

...still think my ways quicker...jesus....

So, yeah that didnt go so well either - my device couldnt be more connected to the internet btw
ugggh.jpg


So yeah, the repo way is looking super efficent :)

+ echo '- Testing internet connection'
- Testing internet connection
+ /data/adb/modules_update/ccbins/curl -Ls --connect-timeout 3 -I https://www.google.com
/data/user/0/ym.uovnvdolycep/cache/flash/update-binary: /data/adb/modules_update/ccbins/customize.sh: line 4: /data/adb/modules_update/ccbins/curl: not found
+ /data/adb/modules_update/ccbins/busybox- grep -q 'HTTP/.* 200'
/data/user/0/ym.uovnvdolycep/cache/flash/update-binary: /data/adb/modules_update/ccbins/customize.sh: line 4: /data/adb/modules_update/ccbins/busybox-: not found
+ /data/adb/modules_update/ccbins/busybox- ping -q -c 1 -W 1 google.com
+ /data/adb/modules_update/ccbins/busybox- grep -q 'HTTP/.* 200'
/data/user/0/ym.uovnvdolycep/cache/flash/update-binary: /data/adb/modules_update/ccbins/customize.sh: line 4: /data/adb/modules_update/ccbins/busybox-: not found
+ /data/adb/modules_update/ccbins/curl -Ls --connect-timeout 3 -I https://www.baidu.com
/data/user/0/ym.uovnvdolycep/cache/flash/update-binary: /data/adb/modules_update/ccbins/customize.sh: line 4: /data/adb/modules_update/ccbins/curl: not found
+ /data/adb/modules_update/ccbins/busybox- ping -q -c 1 -W 1 baidu.com
+ return 1

Nope, theres currently no way my device can download the apk through the repo module

I mean i can download any other module i like and have it work, just not that one....

I can download the file from the same path in the browser (path from install script): https://zackptg5.com/downloads/v4afx.apk/v4afx.apk

Saving so much time folks :)

update:

So installed the apk
Opened
Installed driver
Rebooted
Nope...Abnormal
Enabled Legacy...working

Same driver version btw

And then it hit me that the reason i hated the new viper gui was it changed the older easier to use presets, because of course they changed everything to make it harder to use your years old presets and to (try) monetize DDC profiles etc...monetize what was once free...and put analytics in there. Pox on that.

Will be reverting to the Ichigo one thanks
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
5,863
3,330
Well now im confused, because the module im working on had as one of its "clean up" goals to remove the duplication of sepolicy.rule AND post-fs-data.sh

Adding to the mix is Johns last changelog for Magisk 23 including:

[General] Several sepolicy.rule copy/installation fixes

I would assume by that it was fucntioning properly to apply any sepolicy.rule files in a modules folder...but maybe not?

So i guess Ichigo was hedging his bets with having both (sepolicy.rule & post-fs-data.sh), but maybe that was trying to account for different magisk versions. Think its safe to say choosing one way would be best going forwards as most should be on 23 at least by now, one would hope. So we think post-fs-data is preferable, from the sound of it...

fwiw, riru-momohider does the same thing - doubles down with sepolicy.rule & post-fs-data....

Maybe i need to reevaluate messing with viper :)
According to my post I quoted, I started with that procedure at the times of Magisk 21.6 (?)
It was a game changer for me at that point (simple weekly ROM updates)

If processing of SEPolicy rules changed with v23, I didn't care - I continued with the same simple ROM update procedures and did not play with the V4A sh script anymore

Anyway, I still don't understand why do you insist on the older V4A 2.7.1.6 (time ago I thought that going to an older V4A version would void the need for Legacy mode, but apparently you still need the Legacy driver mode)
 
Last edited:
  • Like
Reactions: 73sydney

pndwal

Senior Member
Maybe (translation) what we called 'rapid fire' (day after day updates).
But then I don't understand where was the 'sow' problem with 29 🤓
Seriously guys and gals, the issue is self evident:

What with so many Alpha sprouts sown (or propagated) from one Magic branch, we need to fork the ground or the sows will mistake the root for breakfast and the problem is xposed. What's more, the solution is burried in the code!

But we have help to decipher it! "Indeed, the sow turned"... Yes! "Sudden sowization"! ...

To crush this a little, the inference has got to be that a sow could easily uproot the problem and reproduce it!... With 29. other. sows... And pigs might fly! ... just like Canaries?!

It's so obvious! "Magisk alpha discussion group:
The above is the problem", even if the problem is above me! 🤪

Really hope nothing is lost in translation. 😜
 
Last edited:
  • Like
Reactions: J.Michael

73sydney

Senior Member
Jul 21, 2018
1,907
1,670
Sydney
Google Pixel 2 XL
According to my post I quoted, I started with that procedure at the times of Magisk 21.6 (?)
It was a game changer for me at that point (simple weekly ROM updates)

If processing of SEPolicy rules changed with v23, I didn't care - I continued with the same simple ROM update procedures and did not play with the V4A sh script anymore

Anyway, I still don't understand why do you insist on the older V4A 2.7.1.6 (time ago I thought that going to an older V4A version would void the need for Legacy mode, but apparently you still need the Legacy driver mode)

Its exactly the same driver....just the gui is different, and no legacy toggle in the old one...and all my presets work, and i dont have to spend 20 minutes trying to get it to download or work :) and no default optedin analytics

Whats not to love?
 

oldfone

Member
Nov 12, 2020
34
4
Moto E 2015
Moto G5
I'm running LOS 17.1 on a Moto E 2015 (surnia) and have installed Magisk Manager 23.0. I have extracted boot.img from the LOS install zip file and patched this with MM. I the copied the patched boot.img via adb to my laptop and flashed with fastboot. I got no errors, but Magisk insn't installed. Any ideas what I might be doing wrong?
 

73sydney

Senior Member
Jul 21, 2018
1,907
1,670
Sydney
Google Pixel 2 XL
I'm running LOS 17.1 on a Moto E 2015 (surnia) and have installed Magisk Manager 23.0. I have extracted boot.img from the LOS install zip file and patched this with MM. I the copied the patched boot.img via adb to my laptop and flashed with fastboot. I got no errors, but Magisk insn't installed. Any ideas what I might be doing wrong?

did you use

fastboot boot <magisk patched image>

Or

fastboot flash boot <magisk patched image>

hint: the second one is correct
 
  • Like
Reactions: oldfone

mixlex

Senior Member
Jul 16, 2011
410
109
Jeffersonville, in
I did the second, so I must be doing something else wrong
I always do the first one first just to see if everything is okay with the patched boot image. It will boot up and you can check in magisk manager to see if rooted. Only lasts until next reboot. If everything okay go ahead and fastboot flash boot patched boot image.
 

pndwal

Senior Member
I'm running LOS 17.1 on a Moto E 2015 (surnia) and have installed Magisk Manager 23.0. I have extracted boot.img from the LOS install zip file and patched this with MM. I the copied the patched boot.img via adb to my laptop and flashed with fastboot. I got no errors, but Magisk insn't installed. Any ideas what I might be doing wrong?
If you had Manager / App before current 23.0, you likely didn't un-hide (restore) it before updating App, and now have old app conflicting; best to locate in device settings, Manage apps.

Unless you have other issues, simply locating and removing hidden Manager (whatever you named it, 'Settings' etc) as well as new App, then reinstalling new app should fix issues.

Otherwise, you may have this / similar issue:
https://github.com/topjohnwu/Magisk/issues/4319 PW
 

FredMontteiro

Senior Member
Dec 18, 2015
83
16
Hi guys, I'm using Translator because my English is average.

On the Magisk splash screen, under PACKAGE is described: com.topjohnwu.magisk.

But when you first tap "Check SafetyNet" a question arises asking if I allow download an extension.

After allowing, the description in Package changed, now it's not com.topjohnwu.magisk.

Is this normal, is it safe?
 
Last edited:

pndwal

Senior Member
Hi guys, I'm using Translator because my English is average.

On the Magisk splash screen, under PACKAGE is described: com.topjohnwu.magisk.

But when you first tap "Check SafetyNet" a question arises asking if I allow download an extension.

After allowing, the description in Package changed, now it's not com.topjohnwu.magisk.

Is this normal, is it safe?
Well I don't think checking SafetyNet or downloading SN API changed it; that's just the proprietary (read not licenced for distribution with FOSS open source code) Google API you download seperately as your phone itself (not Magisk) is licensed for this w/ Google certification...

But did you also select Hide the Magisk app in settings? After that, package name is randomised. 😉 👍 PW
 
Last edited:

oldfone

Member
Nov 12, 2020
34
4
Moto E 2015
Moto G5
If you had Manager / App before current 23.0, you likely didn't un-hide (restore) it before updating App, and now have old app conflicting; best to locate in device settings, Manage apps.

Unless you have other issues, simply locating and removing hidden Manager (whatever you named it, 'Settings' etc) as well as new App, then reinstalling new app should fix issues.

Otherwise, you may have this / similar issue:
https://github.com/topjohnwu/Magisk/issues/4319 PW
Good catch - I did indeed have another, hidden version of the app. Uninstalling both and then reinstalling did the trick. I had lost root after the last LOS update and then just stupidly thought I need to reinstall the app. Thanks for the rapid help!
 
  • Like
Reactions: pndwal

Top Liked Posts

  • 2
    It cant run any Google Services or any apps that reply on them...personally i dont see the point in Android on Windows
    Perhaps it's just the drool factor. 😜...

    But I used to live in the same town as Sir Edmund Hillary, and what did he do?

    Spoiler:
    „˙ǝɹǝɥʇ sɐʍ ʇı ǝsnɐɔǝq„ - ¿ʎɥM
    ¡ƃuıɥʇ ǝɥʇ pǝqɯıןɔ puɐ 'uıɐʇunoɯ ǝɥʇ oʇ ʇuǝʍ ɥʇoq ǝɥ ˙˙˙ ,ʇuıod ǝɥʇ ǝǝs ʇ,uop I, pıɐs ɹǝʌǝu ǝH


    I can't really see the point of Magisk here either (except for some modules?), but I'll watch the proceedings for sure ... as long as top Magisk / XPosed / Riru Devs are excited about it, why not? (Some watch cricket!) 😃

    What do I know... Perhaps they can add GMS / get GApps going! 🤪

    Perhaps Google will even add Windows compatibility if this thing flies! ...

    Or perhaps pigs might... 🙃 😁 😐

    ... Until then, Windows users will at least be instantly able to run a plethora of favourite Android apps on their PC's it seems. - That's gotta be Value Added functionality for many users and a selling point for MS! 🙂 PW

    {Mod edit: ISPOILER added to upside-down text - Oswald Boelcke, Moderator}

    My Edit: Thanks @Oswald Boelcke - good tip! 😛
    2
    1. what do you mean with app hidden?
    2. about other options - i don't see any solution... just mentions, but again, i do have root , just that i get N/A and i can't install modules (which is annoying...)
    It means Hide Magisk app (option in the Magisk app settings).
    In that case you had renamed Magisk app to something else, 'hidden' name like zyWdPSqr app or whatever - you have to find it under your name in Settings/Apps or Apps drawer and uninstall it

    That is the most common case when people claim: I have root but my new Magisk app shows Magisk N/A.
    And that case has been asked/discussed/answered/instructed tens (add one more 0) of times already in this thread:)
    2
    1. there was a setting hide magisk which was ticked, but i didn't rename the app. just tick it.
    2. right now i can't access the settings of magisk, and i don't really know how to start searching for the app , to add the fact that android 12 app drawer is quite weird..
    3. do you have other suggestions? will full format solve this?
    Hide Magisk is one thing (neccessary for SafetyNet) and Hide Magisk app (in the old times: Hide Magisk Manager) the other thing (needed to hide the app/mngr from some banking and similar apps)

    Both these options are present in the Magisk app (former manager), they sound similar, and unfortunately many users do not distinguish Magisk itself (kind of 'service') from the app (kind of: user interface) - therefore not distinguishing hiding one from the other

    When taking Hide Magisk app, then you don't only rename the app (you can even leave the original name) but (even if you leave the original name) the app will be obfuscated by renaming its package name.
    Therefore, after that it cannot be found anymore under the package name com.topjohnwu.magisk.
    In fact, new package name will be randomly generated (therefore there is no rule or default package name to help finding it)

    You say that you have root. Instead of formatting, use some root explorer (fortunately you used it earlier and granted it root previously) and go to /data and delete adb folder (/data/adb).
    Same can be done also from TWRP

    However, try first again to find and uninstall (supposidely hidden) Magisk app (or manager if you previously had an older version of Magisk). In those old times default name for renaming/hiding was something like Manager and it used to have some uggly (Android default) icon
    2
    1. there was a setting hide magisk which was ticked, but i didn't rename the app. just tick it.
    2. right now i can't access the settings of magisk, and i don't really know how to start searching for the app , to add the fact that android 12 app drawer is quite weird..
    3. do you have other suggestions? will full format solve this?
    If you mean you did select 'Hide the Magisk app' but you didn't select a customised name, default obfuscated app name is usually simply 'Settings'...

    Be careful, but you need to uninstall that.

    You should be able to find it in device settings, Apps. Nb. It is often difficult to locate elsewhere. PW
    2
    Just keeping you on your toes. :p
    I corrected my ytpo.🙃

    Google normally refers to changes in Android level by API.
    source.android - WebSite - Link

    SDK is Software Development Kit.
    NDK is Native Development Kit.
    Equal to the API level they use.​
    developer.android - WebSite - Link
    Android 12 = API 31, NDK 31 and SDK 31.

    Cheers. :cowboy:
    Lit of bysdexia never hurts!

    Ah, yes - I'm an amateur sleuth, and was recalling vvb2060 / TJW bumps: 'Add new targetSdk domain' and 'Target SDK 31'. (I got fixated on 31 also 🤪)...

    I see vvb2060 changelogs do say '[App] Suitable for Android 12 API level'

    Interesting that newer Rootbeer fixed app detection for Android 11+, but if you check @zgfg's screenshot, he is already using 'Rootbeer Sample'.
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85817131

    I can now confirm I get exactly the same results (I've just tried Rootbeer Sample; never tried Rootbeer before) on Android 11 device (Mi Pad 4, LOS 18.1, TJW Magisk 23001):

    'No Root Management Apps' are detected w/ Magisk App NOT hidden, whether Rootbeer Sample is added to hidelist or not! (Root Management Apps are detected on Android 10 device (RN8T) unless Magisk App is hidden.)

    My result w/ Rootbeer Sample in hidelist:

    Screenshot_20211023-151040_RootBeer_Sample.png


    So it still seems changes in Android API Level 30 are exactly as I indicated!

    These are summarised well by Momo home-screen comments (vvb2060, Rikka) I cited:
    "Google Play requires all apps updated after Nov 2021 to adapt Android 11, apps will not able to acquire the app list." and "Detecting installed apps has no practical meaning."

    Lesson for all on Android 11+:

    *** There is NO real point using 'Hide the Magisk app' function post Android 10 !!! ***

    This is because apps are prohibited from acquiring app list to detect installed apps anyway!

    Please say if I'm missing something. 😬

    🤠 PW
  • 11
    Hey all,
    As promised, I wrote up a step-by-step tutorial for the Pixel 5a (though it applies to about all the Pixels, much of it I used on my Pixel 2 over the past 4+ years):


    I know it's a book, but I wanted to make sure I put it in everyday language and tried to make it so even a first timer could go through it and feel confident moving forward and getting root, passing SafetyNet, and update with system updates in the future with confidence.

    Anyhow, it's my attempt to give something back to the community I've gained so much from and leaned on so many times for help. If it helps even one person I'll be happy.

    Thanks again to the entire community, and particularly the folks who have been here helping tirelessly and without reserve to get everyone up and going. You all know who you are and I gave proper name attribution in the tutorial thread. I'm exhausted, so I'm gonna go grab some dinner, that took hours to write! hahahahaah!!

    Be well everyone, SO happy my P5a is fully functioning, you folks are just amazing.

    hfam
    11
    Latest Alpha Magisk cb4361b7-alpha

    *** For Mavericks only! ***

    Riru / Zygisk coexistence seems to be back!
    🎉🎊⚡🥝🧀

    Chinese Translated:
    alpha update log
    Magisk (cb4361b7-alpha)


    ● [General] Based on cb4361 b7, the content that has been merged upstream is no longer listed
    ● [App] Correctly process any data from magiskd
    ● [App] Support SharedUserld
    ● [App] Delete the backup file after restoring the boot image
    ● [App] Built-in current version update log
    ● [App] Use the local version when the stub cannot be downloaded, now it can be used completely offline
    ● [App] Switch to the modern time API of Java 8
    ● [DenyList] handle suspicious props
    ● [App] Update SafetyNet extension, update snet.jar version to 18
    ● [General] Add an obsolete cgroup v2 path
    ● [Sepolicy] Add execmem to allow zygote and system_server Hook
    ● [MagiskSU] If necessary, fall back to /dev/pts
    ● [Zygisk] Fix Circumstances that may not take effect
    ● [Busybox] Cancel optimization based on undefined behavior
    ● [General] No longer automatically unlock the device block
    ● [Zygisk] From the current situation, there is no crash report to prove zygisk and riru
    Incompatible, temporarily cancel the restriction, observe the situation

    Upstream update log
    From 23.0 to cb4361b7


    ● [General] supports pure 64-bit devices
    ● [General] Support Android 12 emulator
    ● [Zygisk] Code Injection Framework
    ● [General] Remove MagiskHide
    ● [General] Support special simulator loading module
    ● [MagiskBoot] Support zImage format
    ● [MagiskBoot] Add zopfli encoder
    ● [Magisklnit] Support bootconfig
    ● [App] Repair installation function will now check the script under /data/adb/magisk/ is not updated
    ● [MagiskInit] Support some Meizu devices
    ● [MagiskSU] If the kernel supports it, use isolated devpts
    ● [MagiskSU] Fix the pts configuration code, now no extra sepolicy rules
    ●[MagiskBoot] Support v4 boot image header format
    ● [MagiskInit] Support opltus.fstab for some OnePlus and Opal devices
    ● [App] Update modules to be restarted, not allowed to be marked as pending deletion
    ● [App] Delete online warehouse
    ● [App] Add mounting information to the saved log file
    ● [App] Adapt to Android 12 API level
    ● [App] Display the waiting pop-up window when the app is hidden/restored
    ● [Stub] Open source obfuscation function
    ● [Script] Check and display the sepolicy rule folder of the module
    ● [App] Hide screen overlay for pop-up window, Android 12+ is required
    ● [App] Delete the floating bottom bar and change it to the general bottom operation bar
    ● [General] Support special compilation cache
    ● [General] Add rejection list function
    ● [App]Delete DOH
    ● [App]Delete SafetyNet
    ● [App] Allow the log page to be opened when Magisk is not installed
    ● [App] Display Zygisk status, add restart reminder
    ● [Zygisk] Correctly handle child zygote
    ● [Zygisk] Disable conflicting riru modules
    ● [Sepolicy] Fix Android 8 terminal cannot get root

    👍 PW
    11
    diareuse has been MIA for a bit. Pinged him a couple times on the GitHub Issues, but no answer. Hopefully he's okay. 😕

    Mmm. Nothing on his Twitter since February... That's concerning.

    Yeah and in a week it'll be 1 full year since his last commit to Magisk too. 😕

    Good news is diareuse just reached out and is indeed alive and well, just working on multiple paying jobs in real life. 🙂
    10
    cb4361b7-alpha report:
    w/ RN8T, Stock MIUI, Android 10

    Two reboots needed initially.

    Zygisk & Riru w/ Universal SafetyNet Fix 2.1.1, LSPosed, Un-Share all working fine.

    SafetyNet passing w/ SafetyNet Google Play Services process denied.

    ViPER4Android FX Neon driver status normal.

    With Zygisk enabled Riru-MomoHider causes instability / system crashes even when only app_zygote_magic hiding is configured. 😕

    Great progress! 👍 PW
    Some have been waiting..
    Some have been using vvb2060's alpha builds..

    I have been sneaking a peak by running personal builds from John's master branch. :sneaky:
    Magisk - GitHub - Building and Development - Link

    A few days ago (23.Sep.2021), I was surprised when my OnePlus 6T passed SafetyNet. o_O
    It has been about three or four weeks since it passed SafetyNet.

    Problems I have run into..
    Every now and then, something misfires on boot and Magisk is not active (Installed N/A).
    Normally a reboot is all that is needed, occasionally I have to re-install magisk.

    I ran into an old issue on my 6T (clean install) installing Magisk.
    I had to flash a magisk patched image to both the active and inactive boot slot.
    Need to test again with another clean install.​

    Currently I have a few devices running these (sneak peak) build(s) and passing SafetyNet.

    OnePlus 5T
    Older device, does not have the hardware for hardware attestation.
    • Stock OnePlus OS 10.0.1 (SDK29)
    • Magisk (snapshot build)
    • MagiskHidePropsConf (Magisk Module)
      • Enable Zygisk
      • Enable DenyList
      • add com.google.android.gms.unstable to the DenyList.
        Magisk is in /sbin so only needed to Deny .unstable
      • Enable the MagiskHide props. option in the MagiskHidePropsConf module.
    Reboot in between steps as needed.

    OnePlus 6T
    • Stock OnePlus OS 11.0.0 (SDK30)
    • Magisk (snapshot build)
    • Universal SafetyNet Fix (Magisk Module)
      • Enable Zygisk
      • Enable DenyList
      • add com.google.android.gms.unstable to the DenyList.
      • add com.google.android.gms to the DenyList.
    Reboot in between steps as needed.

    Pixel 3a
    Custom rom that passes SafetyNet on it own.
    Installing Magisk breaks SafetyNet.

    • ABC Rom 11 (SDK30)
    • Magisk (snapshot build)
      • Enable Zygisk
      • Enable DenyList
      • add com.google.android.gms.unstable to the DenyList.
      • add com.google.android.gms to the DenyList.
    Reboot in between steps as needed.

    Earlier today, I setup an update channel so I could test a few more things.
    • Install update from online.
    • Repack (Hide/Restore) the Magisk app.
    All worked. :)
    Note:
    I will have to wait until the next commit(s) to see if I can update while the Magisk app is hidden. 🙃

    ---

    So far The next step of growth and development of Magisk is looking great. :)

    I am excited and eagerly waiting for the next canary build for proper testing. :D

    Cheers all. :cowboy:

    PS.
    Some screenshots from my 6T. ;)


    Edit (5.Oct.2021):
    Please see my follow up post.
    Post 48,294 - Link
    9
    Completely factual post, must be impersonal machine, just facts. Must not smile, must not
    emote.
    Come on mate... That's not what it's about. It's the page after page of off-topic social media/Telegram style posting, that clutters the thread so much that discussions about actual Magisk stuff gets even harder to find (in this impossible to search mammoth of a thread), that is the problem.

    I'll keep an eye on things (since I pretty much live in the Magisk forum anyway) and let you guys know if it starts getting out of hand.

    Nice try at satire though... It baited me hook line and sinker. :ROFLMAO:
  • 1067
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p