• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

Mistercraft38

Member
Nov 20, 2016
11
6
Grenoble
Xiaomi Poco F3
Hey, I Wanted to know if there is a way to get the Magisk tools (I'm mainly searching for magiskboot) on desktop. And also if there is precompiled binaries available somewhere

EDIT: I found out. If anyone else end in the same situation as me, just follow the steps for building Magisk on github. Once NDK configured, just type `./build.py binary magiskboot` and you'll find x86 and x86_64 executable in native/out folder
 
Last edited:
  • Like
Reactions: J.Michael

FredMontteiro

Senior Member
Dec 18, 2015
83
16
Well I don't think checking SafetyNet or downloading SN API changed it; that's just the proprietary (read not licenced for distribution with FOSS open source code) Google API you download seperately as your phone itself (not Magisk) is licensed for this w/ Google certification...

But did you also select Hide the Magisk app in settings? After that, package name is randomised. 😉 👍 PW

Oh yes! I hid the magisk. The app has been renamed. That's it. Thank you very much! In this case I believe I have no security problem.
 
  • Like
Reactions: pndwal

AidanWoolley

New member
Jan 23, 2017
2
0
I'm attempting to install magisk on a oneplus 5T with lineageOS 18.1 and openGApps pico. I think I've followed the instructions correctly: I installed lineageOS and openGApps and everything was working, and then I extracted the boot.img from the lineageOS zip, patched it and flashed it. This broke the installed GApps (none of the could find google play services) and I had to reinstall lineageOS and the GApps. Is this is a known issue? Did I follow the instructions wrong? Help much appreciated.
 

zgfg

Senior Member
Oct 10, 2016
5,894
3,367
I'm attempting to install magisk on a oneplus 5T with lineageOS 18.1 and openGApps pico. I think I've followed the instructions correctly: I installed lineageOS and openGApps and everything was working, and then I extracted the boot.img from the lineageOS zip, patched it and flashed it. This broke the installed GApps (none of the could find google play services) and I had to reinstall lineageOS and the GApps. Is this is a known issue? Did I follow the instructions wrong? Help much appreciated.
If the GApps install to Boot, then they were no more in your boot.img you extracted from the OS zip

If you had TWRP, you could have backed-up your Boot partition (with the GApps already installed) and then patch that boot.emmc.win (TWRP back-up) instead of the extracted boot.img (with no GApps)
 

pndwal

Senior Member
If the GApps install to Boot, then they were no more in your boot.img you extracted from the OS zip

If you had TWRP, you could have backed-up your Boot partition (with the GApps already installed) and then patch that boot.emmc.win (TWRP back-up) instead of the extracted boot.img (with no GApps)
🤔 I'm confused here; does GApps ever install to boot partition? ... Or do you mean Play Services (only) can install there? ...

My understanding is that GApps is (always?) in /system w/ parts in /data !? 🙃 PW
 
  • Like
Reactions: J.Michael and ipdev

pndwal

Senior Member
I'm attempting to install magisk on a oneplus 5T with lineageOS 18.1 and openGApps pico. I think I've followed the instructions correctly: I installed lineageOS and openGApps and everything was working, and then I extracted the boot.img from the lineageOS zip, patched it and flashed it. This broke the installed GApps (none of the could find google play services) and I had to reinstall lineageOS and the GApps. Is this is a known issue? Did I follow the instructions wrong? Help much appreciated.
I'd say it's unusual.

Assuming you are 100% sure you patched / flashed boot image from exact LOS build you are currently using (which failure often affects/breaks network/data access, incl. Play services access) ie. you didn't muddle image files on PC etc, I have the following questions:

Did you notice issue with initial Magisk installation w/ MagiskHide disabled? (could give clues 😉)

Also, just in case, you didn't manually add any Google App processes to MagiskHide list (especially in Google Play services) did you?

Did you have data/internet access?

Did you try clearing data for Google Play services?

But seems all went well after you reinstalled. Do you now have Magisk / root?

If so, what did you do differently? (Changed flash order? Clean install? No reboots between flashes? Other?) PW
 
Last edited:
  • Like
Reactions: J.Michael and ipdev

ipdev

Recognized Contributor
Feb 14, 2016
1,554
1
2,003
Google Nexus 10
Nexus 7 (2013)
I'm attempting to install magisk on a oneplus 5T with lineageOS 18.1 and openGApps pico. I think I've followed the instructions correctly: I installed lineageOS and openGApps and everything was working, and then I extracted the boot.img from the lineageOS zip, patched it and flashed it. This broke the installed GApps (none of the could find google play services) and I had to reinstall lineageOS and the GApps. Is this is a known issue? Did I follow the instructions wrong? Help much appreciated.
Could have just been a bad install/update.
The core of GApps needs to be compatible versions.
If one is out of sync with the other(s) you will have issues.


What version (and dates) of GApps and Lineage are you using?
My dumpling is running l18 (personal build), OpenGApps (personal build, need to check the date) and Magisk (canary).​

Backup what you want to save and store it off device.
Copy it to your computer, cloud storage, USB, ...


Try again with a complete clean flash.

Instead of flashing the magisk patched image, test by just booting it.
fastboot boot magisk_patched-VersionNumber_SomeThing.img

If Magisk is active, you can use the Direct Install option in Magisk.
or reboot back into bootloader and flash the patched boot image.

Cheers. :cowboy:
 

ipdev

Recognized Contributor
Feb 14, 2016
1,554
1
2,003
Google Nexus 10
Nexus 7 (2013)
🤔 I'm confused here; does GApps ever install to boot partition? ... Or do you mean Play Services (only) can install there? ...

My understanding is that GApps is (always?) in /system w/ parts in /data !? 🙃 PW
No GApps package that I know of modifies the boot image.
At least not currently (SDK30). ;)

A GApps install places the necessary files into the read-only partitions.
system, system/app, system/etc, priv-app, .....

User configuration and GApps updates are in /data

Not a great example but, I made a Magisk Module a while back (for testing).
I was testing something for MagiskHidePropsConfig at the time.
Could not remount the AOSP GSI as Read-Write in TWRP so..
Magisk overlay to the rescue. ;)
Hope it helps explain what a GApps install normally does.
mModule_sGapps - GitHub - Link

Cheers. :cowboy:
 
  • Like
Reactions: duttyend and pndwal

pndwal

Senior Member
No GApps package that I know of modifies the boot image.
At least not currently (SDK30). ;)

A GApps install places the necessary files into the read-only partitions.
system, system/app, system/etc, priv-app, .....

User configuration and GApps updates are in /data

Not a great example but, I made a Magisk Module a while back (for testing).
I was testing something for MagiskHidePropsConfig at the time.
Could not remount the AOSP GSI as Read-Write in TWRP so..
Magisk overlay to the rescue. ;)
Hope it helps explain what a GApps install normally does.
mModule_sGapps - GitHub - Link

Cheers. :cowboy:
Yes, thanks, for making it clear.

Further, I am aware that a number of systemless GApps packages exist. I didn't mention these as they were not applicable to the member's issue.

Users should be aware that there may be unexpected issues using such a systemless GApps package however.

For example Magisk Hide means Magisk unmounts modules to hide them, so, if I understand it correctly, when, say, Google Play services is called (opened), the GApps module itself will simultaneously be unmounted and the 'app' crashes. PW
 
Last edited:
  • Like
Reactions: ipdev

zgfg

Senior Member
Oct 10, 2016
5,894
3,367
🤔 I'm confused here; does GApps ever install to boot partition? ... Or do you mean Play Services (only) can install there? ...

My understanding is that GApps is (always?) in /system w/ parts in /data !? 🙃 PW
I don't know how it goes when manually installing GApps. But according to his description, he lost his previously installed GApps when he returned to the original boot.img (patched by Magisk). And then he was again able to install GApps

He could test something else. Install GApps and then flash his extracted boot img (not patched by Magisk), to make sure it was really not about Magisk but about replacing boot.img upon the installation of GApps
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
I don't know how it goes when manually installing GApps. But according to his description, he lost his previously installed GApps
Well, broke access to Google Play services anyway
This broke the installed GApps (none of the could find google play services)

when he returned to the original boot.img (patched by Magisk).
Well, apparently after he first patched / flashed
then I extracted the boot.img from the lineageOS zip, patched it and flashed it. This broke the installed GApps

And then he was again able to install GApps
Well, after he reinstalled OS
and I had to reinstall lineageOS and the GApps.

He could test something else. Install GApps and then flash his extracted boot img (not patched by Magisk), to make sure it was really not about Magisk but about replacing boot.img upon the installation of GApps
Sure.

The statements I found confusing (actually, I just think they're incorrect) however, were:
If the GApps install to Boot, then they were no more in your boot.img you extracted from the OS zip
🤔 GApps don't install to boot... ever... So they wouldn't be in boot whether installed, extracted, stock, patched, backed up or other! 😬

And this:
If you had TWRP, you could have backed-up your Boot partition (with the GApps already installed) and then patch that boot.emmc.win (TWRP back-up) instead of the extracted boot.img (with no GApps)
🤔 Except that there would be no difference! ... Boot doesn't change at all after flashing GApps. Neither have it.

TWRP backup boot.emmc.win file is an alternative to downloading / extracting boot image from a ROM for those with compatible TWRP, but resulting image should be identical!

Nb. A Magisk zip will alter the partition and subsequent backup, but GApps zip won't! They're two very different beasts. 😉

GApps work fine with stock kernel, ramdisk etc so don't require any changes, and a GApps package is just a means of distributing often stock-standard Google Apps for legal and practical reasons.

Magisk on the other hand requires code injected into a ramdisk to boot with SU privileges, so necessarily alters a boot image, whether boot or recovery.

Sorry! 🙃 PW
 
Last edited:
  • Like
Reactions: J.Michael

zgfg

Senior Member
Oct 10, 2016
5,894
3,367
Well, broke access to Google Play services anyway



Well, apparently after he first patched / flashed



Well, after he reinstalled OS



Sure.

The statements I found confusing (actually, I just think they're incorrect) however, were:

🤔 GApps don't install to boot... ever... So they wouldn't be in boot whether installed, extracted, stock, patched, backed up or other! 😬

And this:

🤔 Except that there would be no difference! ... Boot doesn't change at all after flashing GApps. Neither have it.

TWRP backup boot.emmc.win file is an alternative to downloading / extracting boot image from a ROM for those with compatible TWRP, but resulting image should be identical!

Nb. A Magisk zip will alter the partition and subsequent backup, but GApps zip won't! They're two very different beasts. 😉

GApps work fine with stock kernel, ramdisk etc so don't require any changes, and a GApps package is just a means of distributing often stock-standard Google Apps for legal and practical reasons.

Magisk on the other hand requires code injected into a ramdisk to boot with SU privileges, so necessarily alters a boot image, whether boot or recovery.

Sorry! 🙃 PW
Still, if installed Gapps didn't need/affect Boot, there is no explanation why after replacing the boot img with original one + Magisk, he lost GApps and needed to install GApps again
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
Still, if installed Gapps didn't need/affect Boot,
Installing GApps doesn't need/affect boot.
there is no explanation why after replacing the boot img with original one + Magisk, he lost GApps
As noted above, those are your words. 😬

He (or she?) never said any GApps were lost, only "This broke the installed GApps (none of the[m] could find google play services)"

And I hinted at a few possibilities re. why access to Google Play services might not work here:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85406199

You well know Magisk can affect Play Services, especially if MagiskHide is on / extra processes hidden.

May be other errors made too. Muddled / mismatched boot image is a regular culprit in wifi / network data Issues for instance.

Could be a number of possibilities/ explanations at this stage - just not GApps install itself affecting boot partition. 😉
and needed to install GApps again
Maybe he needed to, maybe he didn't... Impossible to tell yet. PW
 
Last edited:
  • Like
Reactions: J.Michael

bonedriven

Senior Member
Oct 2, 2011
184
21
Hello, the context is this:

  1. A Pixel 2 phone that had LOS 17 running with magisk rooted.
  2. Successfully upgraded to latest LOS 18.1 and everything runs well except that I lost root, with only the Magisk app still installed on the phone (as expected).
  3. Followed the "patch image method" from Magisk guide:
    1. ) Extract boot.img from google factory downloads, as magisk app showed I have ramdisk.
    2. ) Patch the file to get a magisk-patch-*.img
    3. ) Do the "fastboot flash magisk-patch-*.img
  4. reboot and get boot loop
For now I followed the manual upgrade guide again from LOS upgrade instruction and the phone can work again, but it's like before as there's no root.
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
  1. A Pixel 2 phone that had LOS 17 running with magisk rooted.
  2. Successfully upgraded to latest LOS 18.1 and everything runs well except that I lost root, with only the Magisk app still installed on the phone (as expected).
  3. Followed the "patch image method" from Magisk guide:
    1. ) Extract boot.img from google factory downloads, as magisk app showed I have ramdisk.
You need to patch boot image matching your current ROM!... I don't think Google supplies images for custom LineageOS! 😉

Extract boot.img from current LOS package, or take TWRP backup incl. boot partition, locate and patch that (either as .win or renamed to .img file).
👍 PW.
 
Last edited:

bonedriven

Senior Member
Oct 2, 2011
184
21
You need to patch boot image matching your current ROM!... I don't think Google supplies images for custom LineageOS! 😉

Extract boot.img from current LOS package, or take TWRP backup incl. boot partition, locate and patch that (either as .win or renamed to .img file).
👍 PW.
OK. Now I am going to study the new knowledge of android phone about "how to extract .img from a payload". Using android phone is great, it teaches you android knowledge that becomes useless every few months.
 
  • Like
Reactions: ipdev

Top Liked Posts

  • 3
    The safetynet passed even without denylisted the google play services (gms).
    3
    updated mhpc to 6.1.1 and reset everything. no go.
    If you reset everything you might have just made the MagiskHide props option inactive. Take a look under "Edit MagiskHide props" in the module main menu and see if all options are active (if not, activate).
    2
    Try USNF 1.2 or 1.1.1, as they were the last versions that don't require Riru.
    Thank you, that worked. I'm passing SafetyNet now
    2
    You cant install Riru when Zygisk is enabled, because both edit the same things. Instead of using Universal SafetyNet fix with Riru Download Version 1.2 of USNF (which doesnt need Riru).
    In the latest alpha 43d11d87, you don't need zygisk to be enabled just enable magisk hide then install any riru based module as you like.
    Zygisk still experimental and it can't be used together with riru at all.
    2
    If wishes were horses... PW
    ...we'd all wear rubber boots.
    (Should that have been "Wellies"?)
  • 11
    diareuse has been MIA for a bit. Pinged him a couple times on the GitHub Issues, but no answer. Hopefully he's okay. 😕

    Mmm. Nothing on his Twitter since February... That's concerning.

    Yeah and in a week it'll be 1 full year since his last commit to Magisk too. 😕

    Good news is diareuse just reached out and is indeed alive and well, just working on multiple paying jobs in real life. 🙂
    9
    Latest Alpha Magisk Chinese Translated:
    (For mavericks only! 😬)

    alpha update journal Magisk (cb4361b7-alpha-2)

    • [General] Based on cb4361b7, the content that has been merged into the upstream will not be listed anymore
    • [App] Correctly process any data from magiskd
    • [App] Support SharedUserld
    • [App] Delete the backup file after adding a thick boot mirror
    • [App] Built-in current version update log
    • [App] Use the local version when you cannot download the stub, now it can be used completely offline
    • [App] Switch to Java 8 modern time API
    • [DenyList] Dealing with suspicious props
    • [App] Expand and update SafetyNet, update the snet.jar version to 18
    • [General] Add an outdated cgroup v2 path
    • [Sepolicy] Add execmem to allow hook in zygote and system_server
    • [MagiskSU] If necessary, fall back to /dev/pts
    • [Zygisk] Repair may not take effect
    • [Busybox] Cancel optimization based on undefined behavior
    • [General] No longer automatically unlock the device block
    • [Zygisk] There is no report to prove that zygisk is incompatible with riru, remove the restriction
    • [Resetprop] Completely erase the old content when modifying/deleting
    • [General] Fix the race condition of thread pool
    • [Magisklnit] Do not intervene when booting to DSU

    How to install ?

    To install and use Magisk through the Magisk application, the general relationship should be completed directly in the application. For special circumstances such as the first installation, the image should be patched and then flashed in with the fastboot/odin tool. Customizing Recovery is not a supported method.

    You update the journal
    From 23.0 to cb4361b7

    • [General] Support pure 64-bit devices
    • [Generall supports Android 12 emulator
    • [Zygisk] Code injection framework
    • [General] Remove MagiskHide
    • [General] Support Simulator to add modules
    • [MagiskBoot] Support zimage format
    • [MagiskBoot] Add zopfhi encoder
    • [MagiskInit] Support bootconfig
    • [App] The repair installation function will now check if the script under /data/adb/magisk/ has not been updated
    • [Magisklnit] Support some Meizu devices
    • [MagiskSU] If the kernel supports it, use isolated devpts
    • [MagiskSU] Fix the pts configuration code, now no additional sepolicy rules are needed
    • [MagiskBoot] Support v4 boot image header format
    • [Magisklnit] Support oplus.fstab for some OnePlus and Opal devices
    • [App] Restart and update modules, not allowed to be marked as pending deletion
    • [App] Delete online warehouses
    • [App] Add mounting information to the saved log file
    • [App] Suitable for Android 12 API level
    • [App] Display the waiting pop-up window that is running when hide/restore the original app
    • [Stub] Open source obfuscation function
    • [Script] Check and display the sepolicy rule folder of the module.
    • [App] When the window pops up, hide the screen helmet and add layer. Android 12+ is required.
    • [App] Delete the floating bottom bar and change it to the general bottom operation bar.
    • [General] Support compilation cache
    • [General] Add rejection list function
    • [App] Delete DoH
    • [App] Delete SafetyNet
    • [App] Allow the log page to be opened when Magisk is not installed
    • [App] Display the status of Zygisk, add a reminder that restart is effective
    • [Zygisk] Correctly handle the child zygote
    • [Zygisk] Disabled riru module
    • [Sepolicy] Fix Android 8 terminal cannot get root

    👍 Marvin.
    9
    Hi all. :)

    Just a quick note for those using newer (test/unofficial) builds that have the online Module Repo removed.

    Magisk-Modules-Repo - GitHub - Link
    Magisk-Modules-Repo - Repositories - GitHub - Link

    If you keep an eye on the repo, you will see when the developer(s) push an update.
    Most of the modules have links to support threads and/or another spot that you can download the updated module.
    Didgeridoohan uses the GitHub releases option for MHPC. 🙃

    If no other option is available, you can clone or download the specific module repo and then zip it into a new Magisk module zip file. ;)

    ---

    I Hope the option of a custom module repo is not too far down the list. ;)
    Bye, Magisk-Module-Repo
    I wanted to do this for a long time, as I do not have the mental capacity and interest to moderate and curate what modules are allowed on the official repo. If I accept low quality modules, people complain; if I remove some modules, people also complain. So I made the decision to remove Magisk-Module-Repo from the Magisk app. The administration and maintenance of the GitHub organization will be transferred to trusted community members (candidates not final yet). Developers can still easily install modules using the magisk —-install-module ZIP command in its own apps; users can install modules by selecting zip files in the Magisk app.

    I do want to eventually enable users to set its own online Magisk module sources which the Magisk app can handle module downloading / installing / upgrading, but this isn’t high up on the list of things I want to do in the near future.
    State of Magisk: 2021 - WebSite - medium.com - Link


    I have been a little curious since I mentioned it in a prior post that Magisk was once on PlayStore.
    If I remember correctly, this was the main reason Magisk was booted from PlayStore. :unsure:

    Now that the module repo is removed, does Magisk now fit Google's criteria for PlayStore?

    Cheers all. :cowboy:
    8
    Guess John has given this by now:
    John Wu, Sep 22

    Fellow Googlers: I'll be giving an internal tech talk about Android modding on Sep. 30 @ 9 AM PT. Ping me at Google chat if you/your team are interested and not already invited!
    He did say to 'non Googlers':
    John Wu, Sep 30

    Now think again about all those people saying Magisk is all about hiding root 🤦‍♂️

    Sneak peek of the slides for tomorrow's tech talk. Rooting Android is sooooo easy 🤷‍♂️
    newmagisk.jpeg


    ... Just thought y'all might find John's visual aid for understanding new Magisk helpful!

    Of course, this is on his Twitter... Sorry I can't give a link...

    FWIW, a Mod has told me:
    Any link to social media is governed by the policy HERE. As per the policy, only developers are allowed to post social media links in the OPs of their development threads. Even they are not allowed to post such links on their subsequent posts in the thread...

    Github posts and links are perfectly ok since the policy mentioned above applies to social media and similar places only.

    As for quoting content from social media, it is allowed provided it is relevant to the topic of the thread and no link is given.

    Moderators usually act on reports and also on what they come across in their daily journey through the forums. It is impossible to monitor every single post on a forum of 11 million+ registered users. But when something is brought to their notice, they act.
    😬 PW
    8
    All that Knox stuff is why i departed Samsung phones after my Note 4 and went Pixel, and will never go back

    If you spend that much money on a device, you should be allowed to do what you want with it, without all that nonsense...
  • 1068
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p