• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

73sydney

Senior Member
Jul 21, 2018
1,893
1,653
Sydney
Google Pixel 2 XL
OK. Now I am going to study the new knowledge of android phone about "how to extract .img from a payload". Using android phone is great, it teaches you android knowledge that becomes useless every few months.

Actually that knowledge gets used often as has been around for more than 6 months, and will be around 6 months from now :)

And to help you, in my sig (and here) is an easy (if youre running windows x64) tool to extract the boot image from payload.bin (inside the ROM zip).

1) download payload_dumper-win64.zip and extract
2) extract payload.bin from ROM and put in payload_dumper-win64\payload_input folder
3) run payload_dumper.exe
4) monitor payload_output folder - once theres more than boot.img in there, you can kill the process if yuo liek to avoid extracting all the images
5) copy boot.img file to device
6) patch with magisk
7) move magisk_patched.img back to PC
8) flash with fastboot flash boot <magisk_patched.img>
9) reboot with fastboot reboot

Holler if you are not using windows, theres a tool for every OS...

Some ROM devs will include a boot.img file separately (like ABC ROM), some wont. But now you have the knowledge, and a tool for those
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
5,837
3,308
OK. Now I am going to study the new knowledge of android phone about "how to extract .img from a payload". Using android phone is great, it teaches you android knowledge that becomes useless every few months.
It depends on vendors. Usually OTA or ROMs can be downloaded as zip files, just open and find the boot.img inside. Nothing new and no rocket science here. If you use a good file explorer like MiXPlorer, you can manipulate zip archives directly on the phone

Regarding your 'every few months' - I personally use the method of extracting and patching the img since 2018 (on various phones) and it didn't become "useless knowkedge".
Although all but one of my phones I played with Magisk on them did have proper TWRP, I liked that method more than flashing the Magisk zip through TWRP, but don't plan now to repeat the reason since that has also been discussed many times in this thread

Btw, the method has been also described all the time in the Magisk documentation - not just for the last six months or so.
Find an old Magisk Manager v16 or something, install and you will see that Select and Patch the image file has been present already in the prehistoric times
 
Last edited:
  • Like
Reactions: ipdev and J.Michael

justDave

Senior Member
Nov 17, 2006
172
52
If you downloaded Lineage from the official site, the boot image for each build is available for download. Just use that - no need to extract.
I suspect that your problem is an incompatible module. Try booting up in safe mode, which will disable all your modules. Get root working and then try reenabling your modules one by one (or binary search).
 
  • Like
Reactions: J.Michael

nostraslo

Member
Sep 19, 2010
16
2
I just upgraded my Samsung Galaxy Note 10 from Android 10 to Android 11. After that, I have a problem with Magisk. The Magisk is not installed anymore.

At Android 10 I had to boot with keys combination (power + volume up). This combination does not work anymore.

What did I miss ? Help, please.

Screenshot_20210731-215333.jpg
 

pndwal

Senior Member
I just upgraded my Samsung Galaxy Note 10 from Android 10 to Android 11. After that, I have a problem with Magisk. The Magisk is not installed anymore.

At Android 10 I had to boot with keys combination (power + volume up). This combination does not work anymore.

What did I miss ? Help, please.

View attachment 5375053
Assuming you have installed Android to recovery again you will actually still have root, but will need to boot via recovery as before.

You need recovery key combo and updated method.

Key combo is likely Power + Bixby + Volume Up or similar, but update to One UI 3.0 additionally requires user to plug in a USB-C data cable connected to PC, or USB-C earphones. 😉

Be sure to release keys immediately on vibration / splash screen as before.

Many articles on this change, eg
https://www.androidsage.com/2020/12...ode-on-samsungs-one-ui-3-0-android-11-update/

🤠 PW
 
Last edited:

J.Michael

Recognized Contributor
Jan 20, 2018
872
739
Samsung Galaxy Tab A series
I just upgraded my Samsung Galaxy Note 10 from Android 10 to Android 11. After that, I have a problem with Magisk. The Magisk is not installed anymore.

At Android 10 I had to boot with keys combination (power + volume up). This combination does not work anymore.

What did I miss ? Help, please.

View attachment 5375053
You do not mention installing Magisk after "upgrading" to Android 11. Samsung probably replaced your boot and recovery partitions, so after the change to Android 11, there is no Magisk. Even if Samsung did not destroy your /data, so you still have a Magisk Manager app.

You may need to unlock your bootloader again. You may have been "upgraded" to a bootloader that does not allow unsigned images (Samsung's lawyers have a creative interpretation of the phrase "unlocked bootloader".) If you install Magisk again, it may try to use the modules you had installed, and they may not work with Android 11.
 
  • Like
Reactions: pndwal and dcarvil

ipdev

Recognized Contributor
Feb 14, 2016
1,536
1
1,972
Google Nexus 10
Nexus 7 (2013)
Yes, thanks, for making it clear.

Further, I am aware that a number of systemless GApps packages exist. I didn't mention these as they were not applicable to the member's issue.

Users should be aware that there may be unexpected issues using such a systemless GApps package however.

For example Magisk Hide means Magisk unmounts modules to hide them, so, if I understand it correctly, when, say, Google Play services is called (opened), the GApps module itself will simultaneously be unmounted and the 'app' crashes. PW
Sorry all for some OT. ;)

I was referring more to what is overlaid into system.
mModule_sGapps [system] - GitHub - Link
This is what a normal basic/core flashable GApps package installs into system.

Since I was only using it to test GSI(s), I only trimmed it down as much as I had time for.
Could be trimmed down a bit more. ;)

---

I never ran into an issue when I was testing with mModule_sGapps active.
I had a few things on deck to fix.
I ran out of time to test GSI(s) and never looked into updating or fixing the small and big versions of mModule_sGapp. 🙃

Found my post in MHPC thread. Post # 3,594

The Caution note I added was to warn users about a mismatch and/or when the core is missing.
This would be the same as updating a custom ROM (system) and GApps not being re-installed to system properly.
The permissions are lost and/or the app (update) becomes a user-app instead of a system-app (different permissions).

Some times you can get away with it (debloating) but, you have to be careful for the same reason.
Bootloop and/or an infinite boot.

Cheers. :cowboy:
 
  • Like
Reactions: pndwal

UltimateRayon

Member
Jan 9, 2021
9
0
Hi, can anyone help me?

I've magisk 23 stable version installed but my WhatsApp can't permit google drive for backing up data. The screen keeps loading where I have to allow for the permission
 

pndwal

Senior Member
Sorry all for some OT. ;)

I was referring more to what is overlaid into system.
mModule_sGapps [system] - GitHub - Link
This is what a normal basic/core flashable GApps package installs into system.
Yes, and I understood that (it demonstrates GApps setup well) / agree entirely / thank you for the extra clarity / insight! 😉

And while you weren't recommending using these systemless GApps, my comment was just a general caution to any considering doing so; just in case!
I never ran into an issue when I was testing with mModule_sGapps active.
Out of interest, did Google Apps and any other apps calling SafetyNet API (w MagiskHide on) work fine with your systemless GApps?... Any special considerations to make it work with MagiskHide?
I had a few things on deck to fix.
I ran out of time to test GSI(s) and never looked into updating or fixing the small and big versions of mModule_sGapp. 🙃

Found my post in MHPC thread. Post # 3,594

The Caution note I added was to warn users about a mismatch and/or when the core is missing.
This would be the same as updating a custom ROM (system) and GApps not being re-installed to system properly.​
The permissions are lost and/or the app (update) becomes a user-app instead of a system-app (different permissions).

Some times you can get away with it (debloating) but, you have to be careful for the same reason.
Bootloop and/or an infinite boot.
Yup, point taken too; core is in /system and may be corrupted / removed by a ROM update, debloating etc. Updated apps moved to /data and other data in /cache or /data may remain and cause issues if not manually / properly removed seperately.

Nb. I understand that this was meant to illustrate GApps installation in case of confusion.

It also demonstrates that original users problem caused by flashing Magisk-patched zip is NOT caused by such a corruption of core files or mismatch!
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85405923

I am assuming Magisk flash or settings (hide, etc) are the source of Play services access issue in this case, or somehow Play services data / cache got corruped (simply clearing these may have fixed installation).

👍 PW
 
  • Like
Reactions: duttyend and ipdev

nostraslo

Member
Sep 19, 2010
16
2
You do not mention installing Magisk after "upgrading" to Android 11. Samsung probably replaced your boot and recovery partitions, so after the change to Android 11, there is no Magisk. Even if Samsung did not destroy your /data, so you still have a Magisk Manager app.

You may need to unlock your bootloader again. You may have been "upgraded" to a bootloader that does not allow unsigned images (Samsung's lawyers have a creative interpretation of the phrase "unlocked bootloader".) If you install Magisk again, it may try to use the modules you had installed, and they may not work with Android 11.

Hmm, bootloader is still unlocked. I tried to installed Magisk again at Android 11, but nothing happened.

How should I install Magisk again ? Can you describe or post a video, please.
 

Attachments

  • Screenshot_20210801-074823_Settings.jpg
    Screenshot_20210801-074823_Settings.jpg
    197.1 KB · Views: 24

J.Michael

Recognized Contributor
Jan 20, 2018
872
739
Samsung Galaxy Tab A series
Hmm, bootloader is still unlocked. I tried to installed Magisk again at Android 11, but nothing happened.

How should I install Magisk again ? Can you describe or post a video, please.
I do not have Android 11. I have Android 9 on an SM-T290 (tablet). When I installed Magisk, I used @topjohnwu's instructions, with a hiccup to further modify the patched file -- a workaround developed by @gcrutchr for my device. (So, I used Odin to flash the modifications.)

I don't think you should allow automatic updating.

You need to search this thread and your device thread to find out if Magisk can work with Android 11 on your device.

If Magisk is installed in recovery, you might have installed Magisk correctly. Try booting towards recovery a lot of times. It's a really finicky step.
 
  • Like
Reactions: pndwal

pndwal

Senior Member
Hmm, bootloader is still unlocked. I tried to installed Magisk again at Android 11, but nothing happened.

How should I install Magisk again ? Can you describe or post a video, please.
I'm guessing you must have flashed Magisk to recovery to root previously in accord with official Installation Instruction for Samsung devices.

You should therefore understand that you can't update using OTA any longer, so you should have downloaded complete new ROM and followed the same instructions again with the following exceptions: Use images from the new ROM, and use HOME_CSC instead is CSC to avoid factory reset. (ie patch AP .tar then flash magisk_patched.tar as AP together with BL, CP, and HOME_CSC. (Make sure “Recovery Mode” is checked in options.)

If that is in fact what you did / tried, you should already have root, but, of course on you device standard bootup doesn't use ramdisk and boots system without Magisk root. Booting with the amended use-recovery-to-boot-system-with-Magisk key combo and method for One UI 3.0 I mentioned above
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85410347
will boot rooted system again.

If you didn't follow official Magisk Samsung SAR device "Upgrading the OS" section and flashed stock AP .tar file (un-patched), it seems you will need to do 'initial' Magisk install again, which requires a full data wipe.

You have Magisk app installed. Click the GitHub 'OctoCat' cat symbol for Magisk Home page, then 'Installation Instruction'. Scroll down to 'Samsung (System-as-root)'.

If you updated ROM without factory reset over previous Magisk installation (not uninstalled), modules will load again on booting with Magisk, and if any are incompatible with Android 11 you will likely get bootloop initially as a member told you above.

In this case, search for Safe Mode key combo (nb. for One UI 3.0 it will likely be the same as before with additional requirement to connect PC or earphone to USB), boot to Safe Mode which will disable Magisk module, then boot immediately to system again using amended use-recovery-to-boot-system-with-Magisk key combo and method for One UI 3.0. After this you should have system with Magisk root; compatible modules can be enabled and others uninstalled.

🤠 PW
 
Last edited:

bonedriven

Senior Member
Oct 2, 2011
184
21
If you downloaded Lineage from the official site, the boot image for each build is available for download. Just use that - no need to extract.
I suspect that your problem is an incompatible module. Try booting up in safe mode, which will disable all your modules. Get root working and then try reenabling your modules one by one (or binary search).
No, LOS does not provide boot.img.

Thanks above for all the help as I managed to finally install Magisk.
 
  • Like
Reactions: J.Michael

3mel

Senior Member
Aug 23, 2012
1,314
368
London
hello folks, I've got a question related pre V22 versions of magisk I need help with.

I have a cheap android TV box called a Yagala T95
https://www.amazon.co.uk/Quad-core-...eywords=yagala+T95+h616&qid=1627822904&sr=8-2

the box comes pre rooted via a root switch in it's settings but without a superSU app. a few of us from the allwinner forum have rooted with older versions of magisk because it's better than having any app that asks for root just getting it on a Chinese box thrown together in the sloppiest way like this thing is.
side note: don't buy a cheap TV box unless it has an AMLogic or RockChip SoC!

anyway, because it came rooted you can install magisk manager and have it flash magisk and then turn off the built-in root.

the problem is this box has zero custom recovery options.
if you factory reset and reinstall magisk manager like I have, you have root for your apps but magisk will ask for the additional setup every time and modules won't work. it asks that you reflash magisk (20.4 in this case).
so my question, updating the magisk app to v22 isn't going to work for me is it ? that's going to want to patch firmware and have me flash it isn't it ?
is there a way to either remove magisk without a recovery to flash the uninstall zip or is it possible to use something like flashify to flash magisk 20.4.zip ? seeing as the box is actually rooted ?

I have no backups and currently no way to reflash it's firmware if it goes wrong hence my caution and need of advice. TIA
 

pndwal

Senior Member
Not so on my OnePlus 8T.
I thought he was talking about a Pixel 2. Interesting about the OnePlus 8T though. Why does each vendor have to do things differently :-(
I wish the outsides of the phones showed more imagination and the insides less ;-)
John's explanation:
When Google released the first generation Pixel, it also introduced A/B (Seamless) System Updates. Due to storage size concerns, there are several differences compared to A-only, the most relevant one being the removal of recovery partition and the recovery ramdisk being merged into boot.
This marked the introduction of "Method B - Legacy SAR" boot method (ie. SAR in the official sense), and included Pixel 1 and 2. Pixel 3 and 3a.

Numerous A/B as well as A-only (these launched without ramdisk in boot partition necessitating a new Magisk in Recovery option, although some devices do have bootloader support for such ramdisk to be added later to support Magisk in Boot, eg Xiaomi) "Method B" Legacy SAR devices followed.

Later, Google introduced what John calls "Method C - 2SI ramdisk SAR" (not officially considered SAR, but a form of SAR for Magisk's purposes, therefore in Magisk SAR = Yes) A/B seamless update devices including updated Pixel 3 and 3a (retrofitted to API Level 29, apparently the only devices to convert from B boot method to C) and A/B devices launched with API Level 29+.

Also, A-only devices launched with API Level 29+ are type C, as are the A-only Method A - Legacy ramdisk LV (Launch Version) <28 devices that are converted to boot method C with upgrades to API Level 29+ Android.

Google calls this "USES_RECOVERY_AS_BOOT" officially. The new method was necessary due to new Dynamic Partition scheme.

Further, while boot method C devices generally use a hybrid ramdisk in boot partition to boot into Android or recovery,
Some modern devices using A/B with 2SI also comes with recovery_a/_b partitions. This is officially supported with Google’s standard. These devices will then only use the boot ramdisk to boot into Android as recovery is stored on a separate partition.
Also,
A-only Type IV ramdisk can only boot into Android.
I guess late models also come with recovery partitions and match the Type I / boot method A devices converted to boot method C, and that these likely have both boot and recovery ramdisks.

https://topjohnwu.github.io/Magisk/boot.html#some-history

My conclusion:

Generally it is true that A/B devices use recovery in boot partition. This is almost certainly always true of official SAR A/B devices including the Pixel 2 in question.

With newer 2SI A/B devices (I think only High End / flagship models) there are exceptions to this as Google has made provision for dual recovery partitions. Seems OnePlus 8T is one such device.

🤠 PW
 
Last edited:

Top Liked Posts

  • 6
    Clarification comments from LSPosed team (still about the future Magisk)

    Attaching as a screenshot since links to TG are not allowed (frankly speaking, this 'purity' in XDA policies becomes pretty annoying to me)
    3
    @yujincheng08

    Great to see you active here, and especially your early issues for Zygisk and pull request fixes for webview, logging, modules and DSU in TJW GitHub! ...

    We're all watching / anticipating new LSPosed / Magisk compatibility also...

    Thanks, and love your work! 👍 🙂 PW
    2
    @V0latyle Can you help me out I installed a magisk module that caused a bootloop and I tried the adb wait-for-device shell magisk --remove-modules and it doesn't work for me I'm on the P5 a12 beta 5 I have since flashed the stock boot.img. What can I do to remove this module?
    Search this thread, lots of suggestions.

    Simplest probably shut down, boot to Safe Mode, shut down, boot -- all modules should be disabled but Magisk should be running, so you can permanently disable or remove problem module.

    Worst case: Wipe data / factory reset, start over.
    1
    You are right 8T is Willow. Fortunately for LAOS ginkgo and willow have the same release. I have been using LAOS for many years even when it was called Cyanogenmod and I have always liked it but lately I have a few more problems.It's a fairly light ROM and I like it for that. Back on Magisk I read the linked post and it seems the same problem. However, plugins worked for me before. This summer I used Viper Audio and Cloudflare DNS with 18.1 with no problems with the same Magisk package. The problem arises when doing phone OTA updates. Not only does Magisk no longer work but often the phone does not boot the new release. So if the problem is not on Magisk it could be TWRP or more easily some changes to LAOS that partially invalidate the functioning of Magisk. But at this point I ask in the LAOS discussion.
    1
    Search this thread, lots of suggestions.

    Simplest probably shut down, boot to Safe Mode, shut down, boot -- all modules should be disabled but Magisk should be running, so you can permanently disable or remove problem module.

    Worst case: Wipe data / factory reset, start over.
    Thanks for your help it worked.
  • 14
    MOD ACTION:

    Enough is enough. Despite my deleting some off topic posts yesterday, the spam continues. Thread cleaned. Please check your PM inbox and avoid off topic posts.
    11
    Hey all,
    As promised, I wrote up a step-by-step tutorial for the Pixel 5a (though it applies to about all the Pixels, much of it I used on my Pixel 2 over the past 4+ years):


    I know it's a book, but I wanted to make sure I put it in everyday language and tried to make it so even a first timer could go through it and feel confident moving forward and getting root, passing SafetyNet, and update with system updates in the future with confidence.

    Anyhow, it's my attempt to give something back to the community I've gained so much from and leaned on so many times for help. If it helps even one person I'll be happy.

    Thanks again to the entire community, and particularly the folks who have been here helping tirelessly and without reserve to get everyone up and going. You all know who you are and I gave proper name attribution in the tutorial thread. I'm exhausted, so I'm gonna go grab some dinner, that took hours to write! hahahahaah!!

    Be well everyone, SO happy my P5a is fully functioning, you folks are just amazing.

    hfam
    11
    @hfam I would suggest going with the latest stable release for now, since the Alpha releases are highly experimental and @topjohnwu will create an official release whenever he deems those changes to be a bit more mature.

    The official installation instructions is always a good place to start:
    https://topjohnwu.github.io/Magisk/install.html

    But I see that there are a few threads on this in the 5a threads as well:
    https://forum.xda-developers.com/t/magisk-root-procedure-for-5a-5g.4327361/

    It should be pretty straightforward, since it's a Pixel device. Just patch the boot image and flash it to your device.

    To pass SafetyNet you'll need to use the new Universal SafetyNet Fix as well (as long as you stay stock you shouldn't need anything else):
    https://github.com/kdrag0n/safetynet-fix

    Android 12 is gonna need some updates on the Magisk side, but that'll be taken care of in good time...

    Everything that's being discussed in this thread over the past weeks/months will probably be made much more clear once John releases his next build.
    11
    diareuse has been MIA for a bit. Pinged him a couple times on the GitHub Issues, but no answer. Hopefully he's okay. 😕

    Mmm. Nothing on his Twitter since February... That's concerning.

    Yeah and in a week it'll be 1 full year since his last commit to Magisk too. 😕

    Good news is diareuse just reached out and is indeed alive and well, just working on multiple paying jobs in real life. 🙂
    11
    Latest Alpha Magisk cb4361b7-alpha

    *** For Mavericks only! ***

    Riru / Zygisk coexistence seems to be back!
    🎉🎊⚡🥝🧀

    Chinese Translated:
    alpha update log
    Magisk (cb4361b7-alpha)


    ● [General] Based on cb4361 b7, the content that has been merged upstream is no longer listed
    ● [App] Correctly process any data from magiskd
    ● [App] Support SharedUserld
    ● [App] Delete the backup file after restoring the boot image
    ● [App] Built-in current version update log
    ● [App] Use the local version when the stub cannot be downloaded, now it can be used completely offline
    ● [App] Switch to the modern time API of Java 8
    ● [DenyList] handle suspicious props
    ● [App] Update SafetyNet extension, update snet.jar version to 18
    ● [General] Add an obsolete cgroup v2 path
    ● [Sepolicy] Add execmem to allow zygote and system_server Hook
    ● [MagiskSU] If necessary, fall back to /dev/pts
    ● [Zygisk] Fix Circumstances that may not take effect
    ● [Busybox] Cancel optimization based on undefined behavior
    ● [General] No longer automatically unlock the device block
    ● [Zygisk] From the current situation, there is no crash report to prove zygisk and riru
    Incompatible, temporarily cancel the restriction, observe the situation

    Upstream update log
    From 23.0 to cb4361b7


    ● [General] supports pure 64-bit devices
    ● [General] Support Android 12 emulator
    ● [Zygisk] Code Injection Framework
    ● [General] Remove MagiskHide
    ● [General] Support special simulator loading module
    ● [MagiskBoot] Support zImage format
    ● [MagiskBoot] Add zopfli encoder
    ● [Magisklnit] Support bootconfig
    ● [App] Repair installation function will now check the script under /data/adb/magisk/ is not updated
    ● [MagiskInit] Support some Meizu devices
    ● [MagiskSU] If the kernel supports it, use isolated devpts
    ● [MagiskSU] Fix the pts configuration code, now no extra sepolicy rules
    ●[MagiskBoot] Support v4 boot image header format
    ● [MagiskInit] Support opltus.fstab for some OnePlus and Opal devices
    ● [App] Update modules to be restarted, not allowed to be marked as pending deletion
    ● [App] Delete online warehouse
    ● [App] Add mounting information to the saved log file
    ● [App] Adapt to Android 12 API level
    ● [App] Display the waiting pop-up window when the app is hidden/restored
    ● [Stub] Open source obfuscation function
    ● [Script] Check and display the sepolicy rule folder of the module
    ● [App] Hide screen overlay for pop-up window, Android 12+ is required
    ● [App] Delete the floating bottom bar and change it to the general bottom operation bar
    ● [General] Support special compilation cache
    ● [General] Add rejection list function
    ● [App]Delete DOH
    ● [App]Delete SafetyNet
    ● [App] Allow the log page to be opened when Magisk is not installed
    ● [App] Display Zygisk status, add restart reminder
    ● [Zygisk] Correctly handle child zygote
    ● [Zygisk] Disable conflicting riru modules
    ● [Sepolicy] Fix Android 8 terminal cannot get root

    👍 PW
  • 1067
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p