• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
I don't know how it goes when manually installing GApps. But according to his description, he lost his previously installed GApps
Well, broke access to Google Play services anyway
This broke the installed GApps (none of the could find google play services)

when he returned to the original boot.img (patched by Magisk).
Well, apparently after he first patched / flashed
then I extracted the boot.img from the lineageOS zip, patched it and flashed it. This broke the installed GApps

And then he was again able to install GApps
Well, after he reinstalled OS
and I had to reinstall lineageOS and the GApps.

He could test something else. Install GApps and then flash his extracted boot img (not patched by Magisk), to make sure it was really not about Magisk but about replacing boot.img upon the installation of GApps
Sure.

The statements I found confusing (actually, I just think they're incorrect) however, were:
If the GApps install to Boot, then they were no more in your boot.img you extracted from the OS zip
🤔 GApps don't install to boot... ever... So they wouldn't be in boot whether installed, extracted, stock, patched, backed up or other! 😬

And this:
If you had TWRP, you could have backed-up your Boot partition (with the GApps already installed) and then patch that boot.emmc.win (TWRP back-up) instead of the extracted boot.img (with no GApps)
🤔 Except that there would be no difference! ... Boot doesn't change at all after flashing GApps. Neither have it.

TWRP backup boot.emmc.win file is an alternative to downloading / extracting boot image from a ROM for those with compatible TWRP, but resulting image should be identical!

Nb. A Magisk zip will alter the partition and subsequent backup, but GApps zip won't! They're two very different beasts. 😉

GApps work fine with stock kernel, ramdisk etc so don't require any changes, and a GApps package is just a means of distributing often stock-standard Google Apps for legal and practical reasons.

Magisk on the other hand requires code injected into a ramdisk to boot with SU privileges, so necessarily alters a boot image, whether boot or recovery.

Sorry! 🙃 PW
 
Last edited:
  • Like
Reactions: J.Michael

zgfg

Senior Member
Oct 10, 2016
5,725
3,177
Well, broke access to Google Play services anyway



Well, apparently after he first patched / flashed



Well, after he reinstalled OS



Sure.

The statements I found confusing (actually, I just think they're incorrect) however, were:

🤔 GApps don't install to boot... ever... So they wouldn't be in boot whether installed, extracted, stock, patched, backed up or other! 😬

And this:

🤔 Except that there would be no difference! ... Boot doesn't change at all after flashing GApps. Neither have it.

TWRP backup boot.emmc.win file is an alternative to downloading / extracting boot image from a ROM for those with compatible TWRP, but resulting image should be identical!

Nb. A Magisk zip will alter the partition and subsequent backup, but GApps zip won't! They're two very different beasts. 😉

GApps work fine with stock kernel, ramdisk etc so don't require any changes, and a GApps package is just a means of distributing often stock-standard Google Apps for legal and practical reasons.

Magisk on the other hand requires code injected into a ramdisk to boot with SU privileges, so necessarily alters a boot image, whether boot or recovery.

Sorry! 🙃 PW
Still, if installed Gapps didn't need/affect Boot, there is no explanation why after replacing the boot img with original one + Magisk, he lost GApps and needed to install GApps again
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
Still, if installed Gapps didn't need/affect Boot,
Installing GApps doesn't need/affect boot.
there is no explanation why after replacing the boot img with original one + Magisk, he lost GApps
As noted above, those are your words. 😬

He (or she?) never said any GApps were lost, only "This broke the installed GApps (none of the[m] could find google play services)"

And I hinted at a few possibilities re. why access to Google Play services might not work here:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85406199

You well know Magisk can affect Play Services, especially if MagiskHide is on / extra processes hidden.

May be other errors made too. Muddled / mismatched boot image is a regular culprit in wifi / network data Issues for instance.

Could be a number of possibilities/ explanations at this stage - just not GApps install itself affecting boot partition. 😉
and needed to install GApps again
Maybe he needed to, maybe he didn't... Impossible to tell yet. PW
 
Last edited:
  • Like
Reactions: J.Michael

bonedriven

Senior Member
Oct 2, 2011
184
21
Hello, the context is this:

  1. A Pixel 2 phone that had LOS 17 running with magisk rooted.
  2. Successfully upgraded to latest LOS 18.1 and everything runs well except that I lost root, with only the Magisk app still installed on the phone (as expected).
  3. Followed the "patch image method" from Magisk guide:
    1. ) Extract boot.img from google factory downloads, as magisk app showed I have ramdisk.
    2. ) Patch the file to get a magisk-patch-*.img
    3. ) Do the "fastboot flash magisk-patch-*.img
  4. reboot and get boot loop
For now I followed the manual upgrade guide again from LOS upgrade instruction and the phone can work again, but it's like before as there's no root.
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
  1. A Pixel 2 phone that had LOS 17 running with magisk rooted.
  2. Successfully upgraded to latest LOS 18.1 and everything runs well except that I lost root, with only the Magisk app still installed on the phone (as expected).
  3. Followed the "patch image method" from Magisk guide:
    1. ) Extract boot.img from google factory downloads, as magisk app showed I have ramdisk.
You need to patch boot image matching your current ROM!... I don't think Google supplies images for custom LineageOS! 😉

Extract boot.img from current LOS package, or take TWRP backup incl. boot partition, locate and patch that (either as .win or renamed to .img file).
👍 PW.
 
Last edited:

bonedriven

Senior Member
Oct 2, 2011
184
21
You need to patch boot image matching your current ROM!... I don't think Google supplies images for custom LineageOS! 😉

Extract boot.img from current LOS package, or take TWRP backup incl. boot partition, locate and patch that (either as .win or renamed to .img file).
👍 PW.
OK. Now I am going to study the new knowledge of android phone about "how to extract .img from a payload". Using android phone is great, it teaches you android knowledge that becomes useless every few months.
 
  • Like
Reactions: ipdev

73sydney

Senior Member
Jul 21, 2018
1,863
1,610
Sydney
Google Pixel 2 XL
OK. Now I am going to study the new knowledge of android phone about "how to extract .img from a payload". Using android phone is great, it teaches you android knowledge that becomes useless every few months.

Actually that knowledge gets used often as has been around for more than 6 months, and will be around 6 months from now :)

And to help you, in my sig (and here) is an easy (if youre running windows x64) tool to extract the boot image from payload.bin (inside the ROM zip).

1) download payload_dumper-win64.zip and extract
2) extract payload.bin from ROM and put in payload_dumper-win64\payload_input folder
3) run payload_dumper.exe
4) monitor payload_output folder - once theres more than boot.img in there, you can kill the process if yuo liek to avoid extracting all the images
5) copy boot.img file to device
6) patch with magisk
7) move magisk_patched.img back to PC
8) flash with fastboot flash boot <magisk_patched.img>
9) reboot with fastboot reboot

Holler if you are not using windows, theres a tool for every OS...

Some ROM devs will include a boot.img file separately (like ABC ROM), some wont. But now you have the knowledge, and a tool for those
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
5,725
3,177
OK. Now I am going to study the new knowledge of android phone about "how to extract .img from a payload". Using android phone is great, it teaches you android knowledge that becomes useless every few months.
It depends on vendors. Usually OTA or ROMs can be downloaded as zip files, just open and find the boot.img inside. Nothing new and no rocket science here. If you use a good file explorer like MiXPlorer, you can manipulate zip archives directly on the phone

Regarding your 'every few months' - I personally use the method of extracting and patching the img since 2018 (on various phones) and it didn't become "useless knowkedge".
Although all but one of my phones I played with Magisk on them did have proper TWRP, I liked that method more than flashing the Magisk zip through TWRP, but don't plan now to repeat the reason since that has also been discussed many times in this thread

Btw, the method has been also described all the time in the Magisk documentation - not just for the last six months or so.
Find an old Magisk Manager v16 or something, install and you will see that Select and Patch the image file has been present already in the prehistoric times
 
Last edited:
  • Like
Reactions: ipdev and J.Michael

justDave

Senior Member
Nov 17, 2006
172
52
If you downloaded Lineage from the official site, the boot image for each build is available for download. Just use that - no need to extract.
I suspect that your problem is an incompatible module. Try booting up in safe mode, which will disable all your modules. Get root working and then try reenabling your modules one by one (or binary search).
 
  • Like
Reactions: J.Michael

nostraslo

Member
Sep 19, 2010
16
2
I just upgraded my Samsung Galaxy Note 10 from Android 10 to Android 11. After that, I have a problem with Magisk. The Magisk is not installed anymore.

At Android 10 I had to boot with keys combination (power + volume up). This combination does not work anymore.

What did I miss ? Help, please.

Screenshot_20210731-215333.jpg
 

pndwal

Senior Member
I just upgraded my Samsung Galaxy Note 10 from Android 10 to Android 11. After that, I have a problem with Magisk. The Magisk is not installed anymore.

At Android 10 I had to boot with keys combination (power + volume up). This combination does not work anymore.

What did I miss ? Help, please.

View attachment 5375053
Assuming you have installed Android to recovery again you will actually still have root, but will need to boot via recovery as before.

You need recovery key combo and updated method.

Key combo is likely Power + Bixby + Volume Up or similar, but update to One UI 3.0 additionally requires user to plug in a USB-C data cable connected to PC, or USB-C earphones. 😉

Be sure to release keys immediately on vibration / splash screen as before.

Many articles on this change, eg
https://www.androidsage.com/2020/12...ode-on-samsungs-one-ui-3-0-android-11-update/

🤠 PW
 
Last edited:

J.Michael

Recognized Contributor
Jan 20, 2018
845
708
Samsung Galaxy Tab A series
I just upgraded my Samsung Galaxy Note 10 from Android 10 to Android 11. After that, I have a problem with Magisk. The Magisk is not installed anymore.

At Android 10 I had to boot with keys combination (power + volume up). This combination does not work anymore.

What did I miss ? Help, please.

View attachment 5375053
You do not mention installing Magisk after "upgrading" to Android 11. Samsung probably replaced your boot and recovery partitions, so after the change to Android 11, there is no Magisk. Even if Samsung did not destroy your /data, so you still have a Magisk Manager app.

You may need to unlock your bootloader again. You may have been "upgraded" to a bootloader that does not allow unsigned images (Samsung's lawyers have a creative interpretation of the phrase "unlocked bootloader".) If you install Magisk again, it may try to use the modules you had installed, and they may not work with Android 11.
 
  • Like
Reactions: pndwal and dcarvil

ipdev

Recognized Contributor
Feb 14, 2016
1,504
1
1,891
Google Nexus 10
Nexus 7 (2013)
Yes, thanks, for making it clear.

Further, I am aware that a number of systemless GApps packages exist. I didn't mention these as they were not applicable to the member's issue.

Users should be aware that there may be unexpected issues using such a systemless GApps package however.

For example Magisk Hide means Magisk unmounts modules to hide them, so, if I understand it correctly, when, say, Google Play services is called (opened), the GApps module itself will simultaneously be unmounted and the 'app' crashes. PW
Sorry all for some OT. ;)

I was referring more to what is overlaid into system.
mModule_sGapps [system] - GitHub - Link
This is what a normal basic/core flashable GApps package installs into system.

Since I was only using it to test GSI(s), I only trimmed it down as much as I had time for.
Could be trimmed down a bit more. ;)

---

I never ran into an issue when I was testing with mModule_sGapps active.
I had a few things on deck to fix.
I ran out of time to test GSI(s) and never looked into updating or fixing the small and big versions of mModule_sGapp. 🙃

Found my post in MHPC thread. Post # 3,594

The Caution note I added was to warn users about a mismatch and/or when the core is missing.
This would be the same as updating a custom ROM (system) and GApps not being re-installed to system properly.
The permissions are lost and/or the app (update) becomes a user-app instead of a system-app (different permissions).

Some times you can get away with it (debloating) but, you have to be careful for the same reason.
Bootloop and/or an infinite boot.

Cheers. :cowboy:
 
  • Like
Reactions: pndwal

UltimateRayon

Member
Jan 9, 2021
9
0
Hi, can anyone help me?

I've magisk 23 stable version installed but my WhatsApp can't permit google drive for backing up data. The screen keeps loading where I have to allow for the permission
 

pndwal

Senior Member
Sorry all for some OT. ;)

I was referring more to what is overlaid into system.
mModule_sGapps [system] - GitHub - Link
This is what a normal basic/core flashable GApps package installs into system.
Yes, and I understood that (it demonstrates GApps setup well) / agree entirely / thank you for the extra clarity / insight! 😉

And while you weren't recommending using these systemless GApps, my comment was just a general caution to any considering doing so; just in case!
I never ran into an issue when I was testing with mModule_sGapps active.
Out of interest, did Google Apps and any other apps calling SafetyNet API (w MagiskHide on) work fine with your systemless GApps?... Any special considerations to make it work with MagiskHide?
I had a few things on deck to fix.
I ran out of time to test GSI(s) and never looked into updating or fixing the small and big versions of mModule_sGapp. 🙃

Found my post in MHPC thread. Post # 3,594

The Caution note I added was to warn users about a mismatch and/or when the core is missing.
This would be the same as updating a custom ROM (system) and GApps not being re-installed to system properly.​
The permissions are lost and/or the app (update) becomes a user-app instead of a system-app (different permissions).

Some times you can get away with it (debloating) but, you have to be careful for the same reason.
Bootloop and/or an infinite boot.
Yup, point taken too; core is in /system and may be corrupted / removed by a ROM update, debloating etc. Updated apps moved to /data and other data in /cache or /data may remain and cause issues if not manually / properly removed seperately.

Nb. I understand that this was meant to illustrate GApps installation in case of confusion.

It also demonstrates that original users problem caused by flashing Magisk-patched zip is NOT caused by such a corruption of core files or mismatch!
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85405923

I am assuming Magisk flash or settings (hide, etc) are the source of Play services access issue in this case, or somehow Play services data / cache got corruped (simply clearing these may have fixed installation).

👍 PW
 
  • Like
Reactions: duttyend and ipdev

nostraslo

Member
Sep 19, 2010
16
2
You do not mention installing Magisk after "upgrading" to Android 11. Samsung probably replaced your boot and recovery partitions, so after the change to Android 11, there is no Magisk. Even if Samsung did not destroy your /data, so you still have a Magisk Manager app.

You may need to unlock your bootloader again. You may have been "upgraded" to a bootloader that does not allow unsigned images (Samsung's lawyers have a creative interpretation of the phrase "unlocked bootloader".) If you install Magisk again, it may try to use the modules you had installed, and they may not work with Android 11.

Hmm, bootloader is still unlocked. I tried to installed Magisk again at Android 11, but nothing happened.

How should I install Magisk again ? Can you describe or post a video, please.
 

Attachments

  • Screenshot_20210801-074823_Settings.jpg
    Screenshot_20210801-074823_Settings.jpg
    197.1 KB · Views: 24

J.Michael

Recognized Contributor
Jan 20, 2018
845
708
Samsung Galaxy Tab A series
Hmm, bootloader is still unlocked. I tried to installed Magisk again at Android 11, but nothing happened.

How should I install Magisk again ? Can you describe or post a video, please.
I do not have Android 11. I have Android 9 on an SM-T290 (tablet). When I installed Magisk, I used @topjohnwu's instructions, with a hiccup to further modify the patched file -- a workaround developed by @gcrutchr for my device. (So, I used Odin to flash the modifications.)

I don't think you should allow automatic updating.

You need to search this thread and your device thread to find out if Magisk can work with Android 11 on your device.

If Magisk is installed in recovery, you might have installed Magisk correctly. Try booting towards recovery a lot of times. It's a really finicky step.
 
  • Like
Reactions: pndwal

pndwal

Senior Member
Hmm, bootloader is still unlocked. I tried to installed Magisk again at Android 11, but nothing happened.

How should I install Magisk again ? Can you describe or post a video, please.
I'm guessing you must have flashed Magisk to recovery to root previously in accord with official Installation Instruction for Samsung devices.

You should therefore understand that you can't update using OTA any longer, so you should have downloaded complete new ROM and followed the same instructions again with the following exceptions: Use images from the new ROM, and use HOME_CSC instead is CSC to avoid factory reset. (ie patch AP .tar then flash magisk_patched.tar as AP together with BL, CP, and HOME_CSC. (Make sure “Recovery Mode” is checked in options.)

If that is in fact what you did / tried, you should already have root, but, of course on you device standard bootup doesn't use ramdisk and boots system without Magisk root. Booting with the amended use-recovery-to-boot-system-with-Magisk key combo and method for One UI 3.0 I mentioned above
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85410347
will boot rooted system again.

If you didn't follow official Magisk Samsung SAR device "Upgrading the OS" section and flashed stock AP .tar file (un-patched), it seems you will need to do 'initial' Magisk install again, which requires a full data wipe.

You have Magisk app installed. Click the GitHub 'OctoCat' cat symbol for Magisk Home page, then 'Installation Instruction'. Scroll down to 'Samsung (System-as-root)'.

If you updated ROM without factory reset over previous Magisk installation (not uninstalled), modules will load again on booting with Magisk, and if any are incompatible with Android 11 you will likely get bootloop initially as a member told you above.

In this case, search for Safe Mode key combo (nb. for One UI 3.0 it will likely be the same as before with additional requirement to connect PC or earphone to USB), boot to Safe Mode which will disable Magisk module, then boot immediately to system again using amended use-recovery-to-boot-system-with-Magisk key combo and method for One UI 3.0. After this you should have system with Magisk root; compatible modules can be enabled and others uninstalled.

🤠 PW
 
Last edited:

bonedriven

Senior Member
Oct 2, 2011
184
21
If you downloaded Lineage from the official site, the boot image for each build is available for download. Just use that - no need to extract.
I suspect that your problem is an incompatible module. Try booting up in safe mode, which will disable all your modules. Get root working and then try reenabling your modules one by one (or binary search).
No, LOS does not provide boot.img.

Thanks above for all the help as I managed to finally install Magisk.
 
  • Like
Reactions: J.Michael

Top Liked Posts

  • 8
    Completely factual post, must be impersonal machine, just facts. Must not smile, must not
    emote.
    Come on mate... That's not what it's about. It's the page after page of off-topic social media/Telegram style posting, that clutters the thread so much that discussions about actual Magisk stuff gets even harder to find (in this impossible to search mammoth of a thread), that is the problem.

    I'll keep an eye on things (since I pretty much live in the Magisk forum anyway) and let you guys know if it starts getting out of hand.

    Nice try at satire though... It baited me hook line and sinker. :ROFLMAO:
    6
    Hi everyone, and thanks the developers for this great app. I need help because I can't hide the magisk app, the option isn't available/clickable in the Magisk settings as I show in the screenshot. I'm running an Android 11-based AOSP custom rom (Derpfest).
    Thanks to anyone that can help ;)
    View attachment 5417127
    Requires the Update Channel to be accessible.
    (You have to be online to hide the Magisk app. 😞)

    The update channel has to be set to the Magisk app version you want to install.
    Using vvb2060's alpha builds, it will be pointing the the version released to github.
    vvb2060 [magisk_files] - GitHub - alpha - Link

    From the screenshot, it appears you set the Update Channel to Custom Channel.
    The Custom Channel is not set so no online version can be found.

    Cheers. :cowboy:
    5
    Alpha Magisk update (61783ffc-alpha)

    [General] Based on 61783ffc, the content that has been merged into the upstream is no longer listed

    [App] Correctly process any data from magiskd

    [App] Support SharedUserld

    [App] Delete the backup file after restoring the boot mirror image

    [App] Built-in current version update log

    [App] Use the local version when you cannot download the stub, now it can be used completely offline

    [Busybox] Fix the default shell path

    [App] Switch to Java 8 modern time API

    [DenyList] Deal with suspicious props

    [App] Expand and update SafetyNet, update the version of snet.jar to 18

    [Sepolicy] Sepolicy with built-in LSPosed

    [General] Add an obsolete cgroup v2 path

    [Zygisk] Fix app_zygote and webview_zygote binary


    - You update the journal From 23.0 to 61783ffc

    [General] Supports pure 64-bit devices

    [General] Support Android 12 emulator

    [Zygisk] Code injection framework

    [General] Remove MagiskHide

    [General] Support Simulator to add modules

    [MagiskBoot] Support zimage format

    [MagiskBoot] Add zopfi encoder

    [Magisklnit] Support bootconfig

    [App] The repair installation function will now check if the script under /data/adb/magisk/ has not been updated

    [Magisklnit] Support some Meizu devices

    [MagiskSU] If the kernel supports it, use isolated devpts

    [MagiskSU] Fix the pts configuration code, now no additional sepolicy rules are needed

    [MagiskBoot] Support v4 boot image header format

    [Magisklnit] Support oplus.fstab for some OnePlus and Opal devices

    [App] Restart and update modules, not allowed to be marked as pending deletion

    [App] Delete online warehouses

    [App] Add mounting information to the saved log file

    [App] Suitable for Android 12 API level

    [App] Display the waiting pop-up window that is running when hide/restore the original app

    [Stub] Open source obfuscation function

    [Script] Check and display the sepolicy rule folder of the module.

    [App] When the window pops up, hide the screen and add layers. Android 12+ is required

    [App] Delete the floating bottom bar and change it to the general bottom operation bar

    [General] Support compilation and cache

    [General] Add rejection list function

    [App] Delete DoH

    [App] Delete SafetyNet

    [App] Allow the log page to be opened when Magisk is not installed

    [App] Display Zygisk status, add restart to take effect to remind Zygisk to Fix the problem

    PW
    2
    it always boot to recovery,tried 100 times sure!fiffrent timing-with cable and without,im tired but i dont want to give up,somebody who can examine the stock recovery will find a way sure!

    I took a quick peek at the images you provided earlier. Magisk patches them just fine, without any errors and the boot image is indeed missing ramdisk so the recovery image is what you need to use (unless it's a Xiaomi situation kind of thing where the bootloader does accept the added initramfs, but that's probably unlikely). I can't tell you anything more about the images than that though... Not my area of expertise.

    Since you haven't been able to get the boot key combo working yet, that is what I would focus my efforts on for now. But, maybe that just means that you haven't been able to install the patched image properly, or that it isn't compatible somehow. It could of course be something completely different, but since it seems like you're the pioneer (pun intended) for this device it's hard for us to know what that could be.
    2
    How is this version working for you?
    (Alpha is for mavericks only! 😬 )

    As already mentioned, it's fine at present w/ caveats mentioned re. ease of Zygisk detection which vvb2060 has stated is impossible to hide, at least at present.

    I changed back to USNF 2.1.1 & Riru (last build didn't like Riru for me), enabled LSPosed too, updated Magisk / rebooted and all seemed good; SafetyNet pass, stable etc.

    On next reboot SafetyNet failed inexplicably however. --> disabled Riru and USNF, rebooted, Reinstalled USNF 2.1.1 for good measure, enabled Riru, rebooted...

    --> SafetyNet passing, system stable, SafetyNet survives reboots even with LSPosed, webview fine, no further issues.

    @vvb2060 seems to be restoring just enough of the revoked MagiskHide commits to allow SafetyNet pass ATM, and there do seem to be more mod traces being detected. I can't even seem to hide 'MagiskHide' (aka MagiskDeny) any longer. See screenshots.

    I'm guessing others may need to supply modules (made more powerful by Zygisk at least) or other solutions for hiding these, and I don't assume even SafetyNet will pass without at least an updated USNF in future TJW builds. Hiding Zygisk itself may be a tall order...
    Screenshot_2021-09-24-13-38-23-932_com.topjohnwu.magisk.jpg
    Screenshot_2021-09-24-13-39-59-013_io.github.vvb2060.mahoshojo.png
    Screenshot_2021-09-24-13-34-43-389_io.github.vvb2060.magiskdetector.jpg
    Screenshot_2021-09-24-13-34-17-482_io.github.vvb2060.zygiskdetector.jpg
    😜 PW
  • 44
    OK. AIO solution. Modded "Universal SafetyNet Fix" module. Just added "model" props.
    17
    So, new layer of HARDWARE detection is here.
    SafetyNet failed on devices, where must bee HARDWARE detection. GMS no longer check system response of evaluation type, and force check HW. USNF doesn't work in this cause.
    Hm, funny things happening. I was thinking this is upgrade of HW attestation, but it is DOWNGRADE actually. 😄

    Remember my old first simple digging into HW?
    It`s..... working again.

    Looks like a temporary solution or just "combo" of old and new methods from Google.
    This explains the fact that dirty hack with Xposed-s working now.

    So, this current environment may be temporary or preparation for something BIGGER.

    In conclusion: in this time to passing SafetyNet you need just my old "hardware_off" module from link above or "MagiskHidePropsConf" with any "BASIC" print with model simulation and kdrag0n-s "Universal SafetyNet Fix".

    No ***-posed-s need!
    16
    Few Headsups:

    1) There are reports that Danny's (@kdrag0n) new early release Universal SafetyNet Fix 2.0.0 (combines AOSP Keystore and shim Keystore solutions) is restoring ctsProfile for some. It just may work for all, but not enough reports as yet. Also, it requires a payment at this stage:
    https://forum.xda-developers.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/post-85581909

    https://github.com/kdrag0n/safetynet-fix/pull/13#issuecomment-904209677

    2) There are reports that simply using MagiskHide Props Config module to 'delete' ro.product.model prop fixes ctsProfile on custom ROMs where other methods have failed. Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912885628

    3) New MagiskHide Props Config module 6.0.0 just released with all the sensitive prop values that MagiskHide changed up to and including Magisk v23 set by default, "Force BASIC key attestation" re-enabled (for Googles latest changes), and various other fixes.
    https://forum.xda-developers.com/t/...p-edits-and-more-v6-0-0.3789228/post-85581939

    I have to agree that this module's name does suddenly seem very apt, and as always, it proves elegant in its versatility. 😛👍

    4) Another elegant solution that some may have relegated to a bygone era seems to be coming back in fashion to!

    Those with Google Pay problems persisting after fixing ctsProfile are reporting in GPay threads, here and elsewhere, that GPay-SQLite-Fix + SQLite binary modules from stylemessiah (a connoisseur at least in digital fashion ... or perhaps just lucky, our @73sydney, - original solution from @BostonDan ) is fixing these for them once again. 😜 Eg:
    https://github.com/kdrag0n/safetynet-fix/issues/78#issuecomment-912798412

    WOT 😉 to read if interested:
    https://forum.xda-developers.com/t/...s-of-gms-17-1-22-on-pie.3929950/post-79643248

    🤠 PW
    15
    ro.product.model was enough for my OP8T, but I didn't like how Google Play Services started referring to my device as "OnePlus BASIC" with the "hardware off" module, so I knocked together this module really quickly to just append _SN to the real model name. WFM. 🤘
    14
    Removed the @Displax safety net mod fix and applied the latest USNF 2.1.0 from @kdrag0n.

    Attestation is passed and device is compliant in company portal too with my original device name 1+8 Pro and not Pixel.

    This is done over the latest Alpha Magisk.

    Update: My In-display fingerprint hardware is not working anymore, I think the fix is already committed. Hopefully it will be resolved in the next version.
    Yep, I have sent a Pull Request with the fix like an hour after v2.1.0 was released. 🤠

    See my post here in the official USNF thread for getting it working in the meantime until it's merged and a new release is made: https://forum.xda-developers.com/t/...tynet-fix-1-1-0.4217823/page-59#post-85631613

    Also may be worth everyone reading my comments at the end of that post about people doubting the sponsored testing closed-then-open development.

    And then here on this GitHub issue about how it's not meant to replace MagiskHide so you can't just turn Hide off: https://github.com/kdrag0n/safetynet-fix/issues/91#issuecomment-919264624
  • 1062
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p