• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

zgfg

Senior Member
Oct 10, 2016
5,886
3,353
@rodken - You messed something while posting, that were not my words (but yours) - see the screenshot of your post

About the mentioned screenshot with Zygisk - I don't see anything like that on the Alpha Telegram channel (maybe I'm missing something or you refer to another Telegram channel)
 

Attachments

  • IMG_20210916_223854.jpg
    IMG_20210916_223854.jpg
    243.8 KB · Views: 69

zgfg

Senior Member
Oct 10, 2016
5,886
3,353
Anyone else?

Latest magisk alpha doesnt prompt me for su for Viper4Android....even running it ends in no prompt and black screen, severa lag, and needing to reboot

Have tried removing, deleting data folder and reinstalling...
I'm still on yesterday's Alpha b6298f86 and V4A works flawlessly (I didn't reinstall but kept all modules that I had before updating the Alpha)
 

rodken

Senior Member
Jan 11, 2010
602
168
Google Pixel XL
OnePlus 8
@rodken - You messed something while posting, that were not my words (but yours) - see the screenshot of your post

About the mentioned screenshot with Zygisk - I don't see anything like that on the Alpha Telegram channel (maybe I'm missing something or you refer to another Telegram channel)
I'm having one of those days where I'm trying to jog while I run.
 

73sydney

Senior Member
Jul 21, 2018
1,912
1,673
Sydney
Google Pixel 2 XL
I'm still on yesterday's Alpha b6298f86 and V4A works flawlessly (I didn't reinstall but kept all modules that I had before updating the Alpha)
i decided to full uninstall and clean install...maybe that was the issue, or maybe it got so fudged up by the latest, that when i rolled back to that same build youre referring to it just couldnt cope....im heading back to Magisk-1eb83ad8-alpha-31 for now....i just need stuff to work...

Damn thing has hosed my system totally, not even uninstalling and flashing via TWRP can get me back to it seems, the app says magisk isnt installed....sometimes i hate Magisk....

stupidmagisk.jpg


This is after i:

1) Removed the previous one and flashed the 32 alpha via TWRP...
2) Tried the replace original boot.img and boot patch method

Completely screwed....

Later today ill be doing a backup and clean flashing again...

Actually scratch that, without root, i cant do a backup...

Did i mention i want to kill Magisk about now...

Update:

On a hunch i decided to go back and wipe /data/adb via TWRP...yup, it was still populated

Installed the patched boot image of alpha 31 while i was in there....win...magisk is back

So, yeah, beware the "backwards" (and forwards) compatibility folks with these alphas....

update #2:

All that also borked my google pay and contactless setup, so had to clear Google Play Store/Services and Google Pay and re-add. Luckily it didnt bork my wearables and Samsung Pay.

Id rather be shot than go through all that again anytime soon
 
Last edited:

73sydney

Senior Member
Jul 21, 2018
1,912
1,673
Sydney
Google Pixel 2 XL
Is it possible to rename MagiskAlpha.apk to *.zip and flash it from TWRP like it was on "regular" Magisk?

Yes, its still the way i do it...

Just be aware you will then need to install the apk after rebooting to system to have the full app

I always have a copy of each

Note:

If you have any bank or root-sensitive apps, after rebooting into system you should remove or rename the TWRP folder
 
Last edited:
  • Like
Reactions: J.Michael

pndwal

Senior Member
"CRACK"

We have a problem Nigel!

Same same:

- Everything 'keeps stopping'
- Standard clock widget broken
- Magisk needs further setup / fails
- No root apps open incl. Viper
- Other apps fail too
- Screenshot broken
etc.

But wadaya spect? First iteration of Zygisk on bleeding edge Alpha w/ untold TJW added-then-reverted commits...

I'm reverting too for now...

Still, it was worth a crack Nigel! ... just part of life!

Nigel?...

...You don't like talking to me do you?

I'm not getting you down at all am I?... I wouldn't like to think that I was getting you down...

... Life... Don't talk to me about life....

It's the people you meet in this job that really get you down... The best conversation I had was over forty million years ago ... And that was with a coffee machine... Sigh.

☹️ Marvin.

Edit: Revert to previous Alpha went fine for me.. Had to clear Play Store / Play Services for Device certification... Viper driver still enabled / normal...

Coulda been a Zygisk conflict w/ Riru?...

I'm lonely... where's that coffee machine...
 
Last edited:

73sydney

Senior Member
Jul 21, 2018
1,912
1,673
Sydney
Google Pixel 2 XL
"CRACK"

We have a problem Nigel!

Same same:

- Everything 'keeps stopping'
- Standard clock widget broken
- Magisk needs further setup / fails
- No root apps open incl. Viper
- Other apps fail too
- Screenshot broken
etc.

But wadaya spect? First iteration of Zygisk on bleeding edge Alpha w/ untold TJW added-then-reverted commits...

I'm reverting too for now...

Still, it was worth a crack Nigel! ... just part of life!

Nigel?...

...You don't like talking to me do you?

I'm not getting you down at all am I?... I wouldn't like to think that I was getting you down...

... Life... Don't talk to me about life....

It's the people you meet in this job that really get you down... The best conversation I had was over forty million years ago ... And that was with a coffee machine... Sigh.

☹️ Marvin.

Edit: Revert to previous Alpha went fine for me.. Had to clear Play Store / Play Services for Device certification... Viper driver still enabled / normal...

Coulda been a Zygisk conflict w/ Riru?...

I'm lonely... where's that coffee machine...

You'll keep Marvin, you'll keep :)

I want points for stopping short of blaming it all on you, you terrible release tease :p

I dunno what the issue was because there was nothing in the magisk log to show any drama, i even read it, and i never read logs :) Note: I stopped short of looking at catlog and finding anything useful, but i want points for just considering it :)

Yours,

Nigel
 
  • Like
Reactions: pndwal

ipdev

Recognized Contributor
Feb 14, 2016
1,551
1
1,999
Google Nexus 10
Nexus 7 (2013)
Btw, I've slso played with. There is one MIUI app that was not possible to enable for MagiskHide in Magisk v23 official - it was not showing in GUI.
It was only possible through the Terminal, by using magiskhide command line

Ofc, magiskhide applet is no more available (and there is no command-line applet for DenyList), but by enabling OS apps in Filter I was able to see and check-in that Security center app for DenyList

And I tested with MagiskDetector, having the same results as with previous Alpha versions (no better or worse)
And yeah, it says that "Maisk Hide works properly" 🤩
Not an applet but, you can still do it by command line. :sneaky:
Code:
magisk --denylist add com.google.android.gms com.google.android.gms
magisk --denylist add com.google.android.gms com.google.android.gms.unstable

Magisk - Multi-purpose Utility
Code:
Usage: magisk [applet [arguments]...]
   or: magisk [options]...

Options:
   -c                        print current binary version
   -v                        print running daemon version
   -V                        print running daemon version code
   --list                    list all available applets
   --remove-modules          remove all modules and reboot
   --install-module ZIP      install a module zip file

Advanced Options (Internal APIs):
   --daemon                  manually start magisk daemon
   --stop                    remove all magisk changes and stop daemon
   --[init trigger]          start service for init trigger
                             Supported init triggers:
                             post-fs-data, service, boot-complete
   --unlock-blocks           set BLKROSET flag to OFF for all block devices
   --restorecon              restore selinux context on Magisk files
   --clone-attr SRC DEST     clone permission, owner, and selinux context
   --clone SRC DEST          clone SRC to DEST
   --sqlite SQL              exec SQL commands to Magisk database
   --path                    print Magisk tmpfs mount path
   --denylist ARGS           denylist config CLI

Available applets:
    su, resetprop

DenyList Config CLI
Code:
Usage: magisk --denylist [action [arguments...] ]
Actions:
   status          Return the enforcement status
   enable          Enable denylist enforcement
   disable         Disable denylist enforcement
   add PKG [PROC]  Add a new target to the denylist
   rm PKG [PROC]   Remove target(s) from the denylist
   ls              Print the current denylist
   exec CMDs...    Execute commands in isolated mount
                   namespace and do all unmounts

Cheers. :cowboy:
 

pndwal

Senior Member
I also tried the latest alpha everything was fine. The attestation failed after install, so I installed the latest USNF 2.1.1 and then the SN was passed but all sorts of application were failing. Something to do with the SN fix then?
Thanks for confirming.

Thats what I'm suspecting. Possibly a conflict between Riru Zygote injection and Zygisk's, but I didn't have time for testing.

I'll give it another crack with USNF 1.x series (no Riru) when I get time, (or someone may like to try) since my RN8T is not affected by September Google server end changes anyway.

If this hunch is correct, @vvb2060 may need to fix Riru compatibility, and @kdrag0n will likely move USNF to Zygisk soon anyway. And fwiw, latest USNF seems to be producing stability issues for some w/o Alpha Magisk. PW
 
Last edited:

hkdoublecat

Member
Jul 13, 2011
46
8

Commits on Sep 13, 2021

MagiskHide / hidelist gone; denylist replaces,
Denylist configured in settings,
Remote Domain Name System resolution via HTTPS protocol gone,
SafetyNet check gone,
Module repo database gone.
https://github.com/topjohnwu/Magisk/commits/master:

PW
Coukd you hints me where can I find the denylist?
Was not able to search in modules. Really need this to deal with safetynet cts things....

Safetynet fix v2.1.1 didnt work on my oneplus 3t... gonna need to give a go on denylist.
Thanks
 

zgfg

Senior Member
Oct 10, 2016
5,886
3,353
Coukd you hints me where can I find the denylist?
Was not able to search in modules. Really need this to deal with safetynet cts things....

Safetynet fix v2.1.1 didnt work on my oneplus 3t... gonna need to give a go on denylist.
Thanks
Yesterday I posted screenshots

Anyway, Alpha app, Settings, right below Systemless hosts option, you have Enforce DenyList (check-in) and then click on Configure
 

pndwal

Senior Member
Coukd you hints me where can I find the denylist?
Was not able to search in modules. Really need this to deal with safetynet cts things....

Safetynet fix v2.1.1 didnt work on my oneplus 3t... gonna need to give a go on denylist.
Thanks
As mentioned in your quoted post, it's in Magisk App settings assuming you have one of last two Alpha builds.

Nb. You'll need both USNF and the correct processes(s) in Google Play Services (search back) hidden / denied to pass ctsProfile.

If you tell us your ROM and results for evalType and basicIntegrity we may be able to help you further. PW
 

hkdoublecat

Member
Jul 13, 2011
46
8
Yesterday I posted screenshots

Anyway, Alpha app, Settings, right below Systemless hosts option, you have Enforce DenyList (check-in) and then click on Configure

Thanks but it doesn't work.

Previously my failure was that I installed the Magisk boot iamge but not the App part, now I get both install and now be able to find the denylist. And I look for your post and finish the denylist setting (screenshot 2). Then reboot the devices, still not able to pass the test.

Not sure which part goes wrong. My device is oneplus 3T (A3003) on RR rom V7.0.2.
 

Attachments

  • 2021-09-17 20.17.28.jpg
    2021-09-17 20.17.28.jpg
    1.4 MB · Views: 50
  • 2021-09-17 20.19.50.jpg
    2021-09-17 20.19.50.jpg
    1.6 MB · Views: 51

Top Liked Posts

  • 5
    Ok, Alpha Dev explains this (Chinese translated):

    Seems latest Zygisk tweeks for new Zygisk LSPosed module now cause unresolved conflicts with Riru (likely due to using the same resources simultaneously I guess).

    John committed code to ensure these couldn't coexist some time ago, and vvb2060 reversed this in a few Alpha builds.

    Anyway, looks like Riru's fate is sealed going forward.

    I'm guessing most Riru modules will move to Zygisk in short order now. Users who want to use Riru modules for any reason will need to forgo Zygisk it seems...

    FWIW, I have SafetyNet passing with old USNF 1.2.0 and the Google Play Services SafetyNet process added to the DenyList in new Canary on Redmi Note 8T.

    I'll.post Notes for passing SafetyNet for others next. 👍 PW
    Yes, no other way, but LSPosed Zygisk version runs fine

    It means that you must sacrifice Riru-Momohider (since Riru is sacrificed) and therefore you can no more hide su from the path (maybe there will be a new Momohider for Zygisk, if possible)

    However, Zygisk itself is easily detectable, hence the hunting season for banking and similar apps is now open (SafetyNet can still pass but the apps long ago started to evaluate other methods to detect root, and the Zygisk detection code is open source)

    But generally, with the new Magisk, Google got what they approved
    3
    On the other hand, correct me if wrong, I don't recall a must reason for Magisk switch to Zygisk or at least a decisive explanation about the reasonable advantage of Zygisk model (to validate the issues as introduced)

    Ofc, TJW does no more care about detections, hence from his shoes there are no troubles with
    Yup, no 'must reason', but he has certainly explained / given heads-ups regarding his intention to do this as far back as old 20.4 Magisk...

    At that time he planned both to integrate overlayfs (already delivered and a real boon especially in the age of shared blocks filesystems as I think you appreciate), and to create the 'native zygote injection/hooking framework' now spawned as Zygisk.

    As for 'a decisive explanation about the reasonable advantage of Zygisk model', he said back in December, after some nine months as an apple engineer "I lost all interest in improving the current way of hiding" but native zygote injection/hooking framework would bring "proper ways to 'hide' root and Magisk Manager."

    Addressing the major issue introduced also, he said "standardizing code injection to something hidable is my goal."

    I'm not sure that there are many issues other than Riru replacement / initial hiding issues. (Reminds me a bit of XDA vBulletin to XenForo migration 😁 ), and I am optimistic that 'standardizing code injection to something hidable' may still be achieved. (I posted a little about Riru hide methods earlier today)...

    Here is John's 2020 Heads-Up in context:
    John Wu, Dec 13, 2020

    Let me get this out of the way: since I have a full time job now, I don't have much time for Magisk; I need prioritization. HW based evaluation is impractical to "hack" (except tricks to make it fallback to basic), and I lost all interest in improving the current way of hiding.

    So what is on the roadmap for Magisk? Integrating overlayfs and creating a native zygote injection/hooking framework. Both of these are ambitious projects, which means they will only happen after a stable v21, and stabilizing Magisk is what I'm currently focusing on.

    What does code injection brings? Proper ways to "hide" root and Magisk Manager. Also, standardizing code injection to something hidable is my goal. This is inspired by Riru (you can already get it from modules repo, 100% open source), but I'd love to try out some new approaches.

    Aha! ... "I'd love to try out some new approaches." Well I'm all for that!

    To add an observation, it seems that as a (still very young) developer John always liked new challenges. Only five years ago (2016) he'd just learned C++ and knew little in programming but taught himself scripting (from "snippets of shell scripts throughout XDA"). He said SuperSU and Xposed installation scripts were the most prominent he referrenced.

    The same year he was first to release Systemless Xposed, then immediately started working on a general solution and in August 2016 released Magisk to the public. 😛...

    Personally, I think John loves the challenge / cares about custom Modding more than most of us... All power to him. 😁 PW
    3
    So there's no point updating magisk today if it's just gonna break things and it's already working as is right ?
    There is no point in updating if everything works for you. Updating at this time is very likely to break things.
    2
    ...LSPosed Zygisk version runs fine.... SafetyNet can still pass ....
    installed Zygisk-LSPosed fine. but, don't have (can't get) LSPosed app in drawer. how to get the app running? do i have to extract apk from zip and run it?

    edit 1: did this and got things working. but, now i have SafetyNet failing. can you suggest a solution, maybe more on configuring denylist or something? already tried several things mentioned here. my earlier post here.

    edit 2: reinstalling MHPC module and rebooting did the trick. passing basic integrity and and cts profile match now. evaluation type - basic.
  • 11
    Hey all,
    As promised, I wrote up a step-by-step tutorial for the Pixel 5a (though it applies to about all the Pixels, much of it I used on my Pixel 2 over the past 4+ years):


    I know it's a book, but I wanted to make sure I put it in everyday language and tried to make it so even a first timer could go through it and feel confident moving forward and getting root, passing SafetyNet, and update with system updates in the future with confidence.

    Anyhow, it's my attempt to give something back to the community I've gained so much from and leaned on so many times for help. If it helps even one person I'll be happy.

    Thanks again to the entire community, and particularly the folks who have been here helping tirelessly and without reserve to get everyone up and going. You all know who you are and I gave proper name attribution in the tutorial thread. I'm exhausted, so I'm gonna go grab some dinner, that took hours to write! hahahahaah!!

    Be well everyone, SO happy my P5a is fully functioning, you folks are just amazing.

    hfam
    11
    Latest Alpha Magisk cb4361b7-alpha

    *** For Mavericks only! ***

    Riru / Zygisk coexistence seems to be back!
    🎉🎊⚡🥝🧀

    Chinese Translated:
    alpha update log
    Magisk (cb4361b7-alpha)


    ● [General] Based on cb4361 b7, the content that has been merged upstream is no longer listed
    ● [App] Correctly process any data from magiskd
    ● [App] Support SharedUserld
    ● [App] Delete the backup file after restoring the boot image
    ● [App] Built-in current version update log
    ● [App] Use the local version when the stub cannot be downloaded, now it can be used completely offline
    ● [App] Switch to the modern time API of Java 8
    ● [DenyList] handle suspicious props
    ● [App] Update SafetyNet extension, update snet.jar version to 18
    ● [General] Add an obsolete cgroup v2 path
    ● [Sepolicy] Add execmem to allow zygote and system_server Hook
    ● [MagiskSU] If necessary, fall back to /dev/pts
    ● [Zygisk] Fix Circumstances that may not take effect
    ● [Busybox] Cancel optimization based on undefined behavior
    ● [General] No longer automatically unlock the device block
    ● [Zygisk] From the current situation, there is no crash report to prove zygisk and riru
    Incompatible, temporarily cancel the restriction, observe the situation

    Upstream update log
    From 23.0 to cb4361b7


    ● [General] supports pure 64-bit devices
    ● [General] Support Android 12 emulator
    ● [Zygisk] Code Injection Framework
    ● [General] Remove MagiskHide
    ● [General] Support special simulator loading module
    ● [MagiskBoot] Support zImage format
    ● [MagiskBoot] Add zopfli encoder
    ● [Magisklnit] Support bootconfig
    ● [App] Repair installation function will now check the script under /data/adb/magisk/ is not updated
    ● [MagiskInit] Support some Meizu devices
    ● [MagiskSU] If the kernel supports it, use isolated devpts
    ● [MagiskSU] Fix the pts configuration code, now no extra sepolicy rules
    ●[MagiskBoot] Support v4 boot image header format
    ● [MagiskInit] Support opltus.fstab for some OnePlus and Opal devices
    ● [App] Update modules to be restarted, not allowed to be marked as pending deletion
    ● [App] Delete online warehouse
    ● [App] Add mounting information to the saved log file
    ● [App] Adapt to Android 12 API level
    ● [App] Display the waiting pop-up window when the app is hidden/restored
    ● [Stub] Open source obfuscation function
    ● [Script] Check and display the sepolicy rule folder of the module
    ● [App] Hide screen overlay for pop-up window, Android 12+ is required
    ● [App] Delete the floating bottom bar and change it to the general bottom operation bar
    ● [General] Support special compilation cache
    ● [General] Add rejection list function
    ● [App]Delete DOH
    ● [App]Delete SafetyNet
    ● [App] Allow the log page to be opened when Magisk is not installed
    ● [App] Display Zygisk status, add restart reminder
    ● [Zygisk] Correctly handle child zygote
    ● [Zygisk] Disable conflicting riru modules
    ● [Sepolicy] Fix Android 8 terminal cannot get root

    👍 PW
    11
    diareuse has been MIA for a bit. Pinged him a couple times on the GitHub Issues, but no answer. Hopefully he's okay. 😕

    Mmm. Nothing on his Twitter since February... That's concerning.

    Yeah and in a week it'll be 1 full year since his last commit to Magisk too. 😕

    Good news is diareuse just reached out and is indeed alive and well, just working on multiple paying jobs in real life. 🙂
    10
    cb4361b7-alpha report:
    w/ RN8T, Stock MIUI, Android 10

    Two reboots needed initially.

    Zygisk & Riru w/ Universal SafetyNet Fix 2.1.1, LSPosed, Un-Share all working fine.

    SafetyNet passing w/ SafetyNet Google Play Services process denied.

    ViPER4Android FX Neon driver status normal.

    With Zygisk enabled Riru-MomoHider causes instability / system crashes even when only app_zygote_magic hiding is configured. 😕

    Great progress! 👍 PW
    Some have been waiting..
    Some have been using vvb2060's alpha builds..

    I have been sneaking a peak by running personal builds from John's master branch. :sneaky:
    Magisk - GitHub - Building and Development - Link

    A few days ago (23.Sep.2021), I was surprised when my OnePlus 6T passed SafetyNet. o_O
    It has been about three or four weeks since it passed SafetyNet.

    Problems I have run into..
    Every now and then, something misfires on boot and Magisk is not active (Installed N/A).
    Normally a reboot is all that is needed, occasionally I have to re-install magisk.

    I ran into an old issue on my 6T (clean install) installing Magisk.
    I had to flash a magisk patched image to both the active and inactive boot slot.
    Need to test again with another clean install.​

    Currently I have a few devices running these (sneak peak) build(s) and passing SafetyNet.

    OnePlus 5T
    Older device, does not have the hardware for hardware attestation.
    • Stock OnePlus OS 10.0.1 (SDK29)
    • Magisk (snapshot build)
    • MagiskHidePropsConf (Magisk Module)
      • Enable Zygisk
      • Enable DenyList
      • add com.google.android.gms.unstable to the DenyList.
        Magisk is in /sbin so only needed to Deny .unstable
      • Enable the MagiskHide props. option in the MagiskHidePropsConf module.
    Reboot in between steps as needed.

    OnePlus 6T
    • Stock OnePlus OS 11.0.0 (SDK30)
    • Magisk (snapshot build)
    • Universal SafetyNet Fix (Magisk Module)
      • Enable Zygisk
      • Enable DenyList
      • add com.google.android.gms.unstable to the DenyList.
      • add com.google.android.gms to the DenyList.
    Reboot in between steps as needed.

    Pixel 3a
    Custom rom that passes SafetyNet on it own.
    Installing Magisk breaks SafetyNet.

    • ABC Rom 11 (SDK30)
    • Magisk (snapshot build)
      • Enable Zygisk
      • Enable DenyList
      • add com.google.android.gms.unstable to the DenyList.
      • add com.google.android.gms to the DenyList.
    Reboot in between steps as needed.

    Earlier today, I setup an update channel so I could test a few more things.
    • Install update from online.
    • Repack (Hide/Restore) the Magisk app.
    All worked. :)
    Note:
    I will have to wait until the next commit(s) to see if I can update while the Magisk app is hidden. 🙃

    ---

    So far The next step of growth and development of Magisk is looking great. :)

    I am excited and eagerly waiting for the next canary build for proper testing. :D

    Cheers all. :cowboy:

    PS.
    Some screenshots from my 6T. ;)


    Edit (5.Oct.2021):
    Please see my follow up post.
    Post 48,294 - Link
    9
    Latest Alpha Magisk Chinese Translated:
    (For mavericks only! 😬)

    alpha update journal Magisk (cb4361b7-alpha-2)

    • [General] Based on cb4361b7, the content that has been merged into the upstream will not be listed anymore
    • [App] Correctly process any data from magiskd
    • [App] Support SharedUserld
    • [App] Delete the backup file after adding a thick boot mirror
    • [App] Built-in current version update log
    • [App] Use the local version when you cannot download the stub, now it can be used completely offline
    • [App] Switch to Java 8 modern time API
    • [DenyList] Dealing with suspicious props
    • [App] Expand and update SafetyNet, update the snet.jar version to 18
    • [General] Add an outdated cgroup v2 path
    • [Sepolicy] Add execmem to allow hook in zygote and system_server
    • [MagiskSU] If necessary, fall back to /dev/pts
    • [Zygisk] Repair may not take effect
    • [Busybox] Cancel optimization based on undefined behavior
    • [General] No longer automatically unlock the device block
    • [Zygisk] There is no report to prove that zygisk is incompatible with riru, remove the restriction
    • [Resetprop] Completely erase the old content when modifying/deleting
    • [General] Fix the race condition of thread pool
    • [Magisklnit] Do not intervene when booting to DSU

    How to install ?

    To install and use Magisk through the Magisk application, the general relationship should be completed directly in the application. For special circumstances such as the first installation, the image should be patched and then flashed in with the fastboot/odin tool. Customizing Recovery is not a supported method.

    You update the journal
    From 23.0 to cb4361b7

    • [General] Support pure 64-bit devices
    • [Generall supports Android 12 emulator
    • [Zygisk] Code injection framework
    • [General] Remove MagiskHide
    • [General] Support Simulator to add modules
    • [MagiskBoot] Support zimage format
    • [MagiskBoot] Add zopfhi encoder
    • [MagiskInit] Support bootconfig
    • [App] The repair installation function will now check if the script under /data/adb/magisk/ has not been updated
    • [Magisklnit] Support some Meizu devices
    • [MagiskSU] If the kernel supports it, use isolated devpts
    • [MagiskSU] Fix the pts configuration code, now no additional sepolicy rules are needed
    • [MagiskBoot] Support v4 boot image header format
    • [Magisklnit] Support oplus.fstab for some OnePlus and Opal devices
    • [App] Restart and update modules, not allowed to be marked as pending deletion
    • [App] Delete online warehouses
    • [App] Add mounting information to the saved log file
    • [App] Suitable for Android 12 API level
    • [App] Display the waiting pop-up window that is running when hide/restore the original app
    • [Stub] Open source obfuscation function
    • [Script] Check and display the sepolicy rule folder of the module.
    • [App] When the window pops up, hide the screen helmet and add layer. Android 12+ is required.
    • [App] Delete the floating bottom bar and change it to the general bottom operation bar.
    • [General] Support compilation cache
    • [General] Add rejection list function
    • [App] Delete DoH
    • [App] Delete SafetyNet
    • [App] Allow the log page to be opened when Magisk is not installed
    • [App] Display the status of Zygisk, add a reminder that restart is effective
    • [Zygisk] Correctly handle the child zygote
    • [Zygisk] Disabled riru module
    • [Sepolicy] Fix Android 8 terminal cannot get root

    👍 Marvin.
  • 1067
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p