• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

zgfg

Senior Member
Oct 10, 2016
5,903
3,376
What is MHPC in two words? I am new here.

Did I understand right that to use stable Magisk, I should again reinstall stable apk and then probably patch boot.img again with fastboot?

And if I just change the update channel in current "alpha" app from the "alpha" to "stable", then it won't work and I won't see any modules anyway in the repository?
MHPC = Magisk Hide Props Config (you compained that you cannot find it or so)

Yes, to go back to Stable you must install the Stable apk (maybe you would need to uninstall Magisk Alpha app because you will be downgading the app, where both Stable and Alpha use the same package names and usually the Apk installer does not allow downgrading the apps versions)

There might be another problem - since that version you have your Magisk Alpha app, there wass no more MagiskHide but the new DenyList. However, you had (discrapances on your side) an older version of Magisk Alpha 'service' that still had MagiskHide.
I don't know when you switch back to the old Stable, would the MagiskHide settings be messed up due to the new DenyList

Maybe you should try to fully Unistall Magisk first (an option from Magisk app). Then to install the old Stable app, etc

(For everybody: Please don't play with the Alpha beast unless you are deeply up to all the new stuff and changes it brings, and you well understand how to handle the Alpha)
 
Last edited:

ipdev

Recognized Contributor
Feb 14, 2016
1,554
1
2,003
Google Nexus 10
Nexus 7 (2013)
Since Nigel and Marvin are not keeping up. :p

John has been busy..
vvb2060 is a few hours behind John. ;)
Lot of zygisk and deny stuff still being implemented.


For those using vvb2060's Alpha builds..
Expect vvb2060 to pull the changes and update alpha again soon. ;)

Just remember, vvb2060 is incorporating SafetyNet and old MagiskHide stuff back into the alpha builds.
I wish vvb2060 would turn it into a module instead of incorporating it back in. :rolleyes:
Then again, seems John has not yet finished updating the Magisk base yet. :unsure:

When John is finally done with this update.
The Release Notes will be it's own article. 🙃

Cheers all. :cowboy:
 

midgo12

Senior Member
May 30, 2017
159
49
OnePlus 7 Pro
Hi Guys.

I am on Magisk Canary and was passing safety net up until today.
Can anyone suggest where to look or what to check to see why it has failed.
On Latest OOS 11.0.3.1GM21BA EU build.
OnePlus 7pro GM 1910.
Thanks for any help given...
 

midgo12

Senior Member
May 30, 2017
159
49
OnePlus 7 Pro
[MODULE] MagiskHide Props Config - SafetyNet, prop edits, and more - xdaThread - Link

Great module if you want (need) to modify your device.
Didgeridoohan does an excellent job at maintaining and updating it. ;)

Cheers. :cowboy:
Tried this.
As well as a few other things like safety net fix latest as well as change my device with MHPC but still no success with my issue post #48011 above yours...
 
Last edited:

pndwal

Senior Member
Hi Guys.

I am on Magisk Canary and was passing safety net up until today.
Can anyone suggest where to look or what to check to see why it has failed.
On Latest OOS 11.0.3.1GM21BA EU build.
OnePlus 7pro GM 1910.
Thanks for any help given...
Please say if you changed anything, what are results for basicIntegrity, ctsProfile, evalType, which modules you use (especially USNF version), what is configured in MHPC, confirm that ROM is stock (looks like it is), installed app and Magisk both show f822c85b.

Meantime, try toggling MagiskHide off and on again in settings, disable all modules not necessary for SafetyNet, reboot and run Check SafetyNet again. 👍 PW
 

pndwal

Senior Member
Since Nigel and Marvin are not keeping up. :p
Yep, haven't had much time since 7 AM AUS time this morning... I think the mouse is asleep... The android just keeps going and going (on energiser batteries), but must prioritise! (I haven't moved to latest Alpha yet.)
John has been busy..
vvb2060 is a few hours behind John. ;)
Lot of zygisk and deny stuff still being implemented.


For those using vvb2060's Alpha builds..
Expect vvb2060 to pull the changes and update alpha again soon. ;)

Just remember, vvb2060 is incorporating SafetyNet and old MagiskHide stuff back into the alpha builds.
I wish vvb2060 would turn it into a module instead of incorporating it back in. :rolleyes:
Would be good; had the same thought. 😜

I think his strategy is just to keep Alpha and hide/deny working with all John's commits merged for testing purposes on a regular basis.
Then again, seems John has not yet finished updating the Magisk base yet. :unsure:

When John is finally done with this update.
The Release Notes will be it's own article. 🙃
Agree! - John's strategy seems to be to implement all changes as a set for next build and test them together... It'll be interesting when it comes. 😁 ...

He's likely watching Alpha incremental testing / getting feedback [email protected] and others in the meantime, which will help him however... He's bound making private builds and testing himself (or perhaps using Alpha) also.

By virtue of the major and MASSIVE changes occurring to produce next Beta / Canary builds, @vvb2060's bleeding edge Alpha will necessarily bleed more profusely than normal for a while I'm guessing...

As mentioned, if users are not in it for testing or for a thrill ride they will probably be best to go back to cutting edge Canary, or Stable.

😜 PW
 
Last edited:

hkdoublecat

Member
Jul 13, 2011
46
8
Definitely not normal. :D

Since Google uses SafetyNet as part of the certification, it should fail certification.

Something appears to be blocking Google from seeing that you are failing SafetyNet.
Either purposely or by accident. ;)

Cheers. :cowboy:
I did some research and find examples of when CTS Profile Match will report as false (failed):
  • Uncertified device (the manufacturer hasn’t applied for Google certification)
  • Unlocked bootloader
  • Signs of system integrity compromise (rooting, etc)
  • Signs of other attacks (Xposed, EdXposed, etc)
So for my case the failure is likely caused by and only caused by unlocked bootloader.

And I thought it is normal because my main device oneplus 7 pro got the same failed safety net and device certified.

I had been able to use google pay before; ~early september google pay start popup i shouldn't use it for security reason yet i could still pay by google pay; late september, could be triggered by clearing cache, the google pay drop my cards and i can no longer add new. Then I install Magisk (app only) and see I cannot pass safety net.

It is an unrooted oneplus 7 pro running on custom rom Havoc 4.6
 

pndwal

Senior Member
I did some research and find examples of when CTS Profile Match will report as false (failed):
  • Uncertified device (the manufacturer hasn’t applied for Google certification)
  • Unlocked bootloader
  • Signs of system integrity compromise (rooting, etc)
  • Signs of other attacks (Xposed, EdXposed, etc)
So for my case the failure is likely caused by and only caused by unlocked bootloader.

And I thought it is normal because my main device oneplus 7 pro got the same failed safety net and device certified.

I had been able to use google pay before; ~early september google pay start popup i shouldn't use it for security reason yet i could still pay by google pay; late september, could be triggered by clearing cache, the google pay drop my cards and i can no longer add new. Then I install Magisk (app only) and see I cannot pass safety net.

It is an unrooted oneplus 7 pro running on custom rom Havoc 4.6
Interesting... If you clear data for Google Play Services and Google Play Store (w/ failed ctsProfile), does Play Protect still dive Device is certified?

Nb. Custom ROMs like Havoc often include inbuilt spoofing / hiding, but S/N fail should still produce Device NOT certified result.

Also, apparently OnePlus's (in particular) messed up hardware TEE implementation on many devices initially caused Google to turn off enforced hardware TEE attestation for SafetyNet in March 2020... I wonder if certified Device w/ failed ctsProfile may be a symptom of OnePlus's poor coding? PW
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
Bank app detecting your settings?

Here's John's take / solution:
John Wu, 16h

"We detected that you are using a smartphone. This poses a security risk as smartphone are prone to phishing attacks and full of privacy issues. Please discard this device immediately and reach out to the nearest branch for any banking assistance."
www.twitter.com/topjohnwu/status/1439204362182488065 🤪

Actually, it's about app detecting Developer Options enabled...

@phhusson weighed in with:
Husson Pierre-Hugues, 20h

I have a hard time seeing how this is worse than banning root/custom ROM.

Developer options are useful only to developers, and power users to report bugs to developers. Custom ROM allows chosing who does your data belong to, it doesn't take a developer to make that choice.
www.twitter.com/phhusson/status/1439144663609450497

TJW.jpgvs.Husson.jpg

Interesting! 😛 PW
 
Last edited:
  • Like
Reactions: ipdev

pndwal

Senior Member

Latest @vvb2060 Magisk Alpha (Chinese translated):​

Magisk (46e8f077-alpha)​

  • [General] Based on 46e8f077, the content that has been merged upstream is no longer listed
  • [App] Correctly process any data from magiskd
  • [App] Support SharedUserId
  • [App] Delete the backup file after restoring the boot image
  • [App] Built-in current version update log
  • [App] Use the local version when the stub cannot be downloaded, now it can be used completely offline
  • [Busybox] Fix the default shell path
  • [App] Switch to the modern time API of Java 8
  • [DenyList] Dealing with suspicious props
  • [App] Update the SafetyNet extension, update the version of snet.jar to 18
  • [Sepolicy] Sepolicy with built-in LSPosed
https://github.com/vvb2060/Magisk/b...7c9697f54c9/app/src/main/res/raw/changelog.md

😜 PW

Edit: Already withdrawn... See above.
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
5,903
3,376
WebView is not working with he latest alpha magisk.
Unfortunately, you are right

I use XDA app. I receive notifications about the new posts. I go in XDA app to the Alert page, alerts are there. I click on an alert and it doesn't open - page stays empty forever.
I thought first it was an issue on XDA forum side, but it's not:

- In that 'empty' page in XDA app, if I use three-dots on top-right and then Open in Browser, then it immediately opens the particular post in Chrome

- If I go to Magisk app, switch off Zygisk and reboot, after that (with Zygisk off) then there is no problem with XDA app.
I switch Zygisk on, reboot, and again the same problem with XDA app

Btw, with Zygisk on, I can still open Web pages in WebView when I click to the given link (even if it is a link to the particular XDA thread or post)

Preparing now to revert back to Alpha b9268f86, last before Zygisk = last where things (XDA app and its alerts) properly worked - and for the time being to stop playing with further Alpha versions
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
5,903
3,376

Latest @vvb2060 Magisk Alpha (Chinese translated):​

Magisk (46e8f077-alpha)​

  • [General] Based on 46e8f077, the content that has been merged upstream is no longer listed
  • [App] Correctly process any data from magiskd
  • [App] Support SharedUserId
  • [App] Delete the backup file after restoring the boot image
  • [App] Built-in current version update log
  • [App] Use the local version when the stub cannot be downloaded, now it can be used completely offline
  • [Busybox] Fix the default shell path
  • [App] Switch to the modern time API of Java 8
  • [DenyList] Dealing with suspicious props
  • [App] Update the SafetyNet extension, update the version of snet.jar to 18
  • [Sepolicy] Sepolicy with built-in LSPosed
https://github.com/vvb2060/Magisk/b...7c9697f54c9/app/src/main/res/raw/changelog.md

😜 PW

Edit: Already withdrawn... See above.
As you wrote earlier, that release is (no more) available in Telegram

63cfe7b4-alpha is the last on Telegram and the Alpha app itself still declares b6298f86-alpha as the latest released
 

Attachments

  • Screenshot_2021-09-19-08-54-16-358_org.telegram.messenger.jpg
    Screenshot_2021-09-19-08-54-16-358_org.telegram.messenger.jpg
    534.8 KB · Views: 57
  • Screenshot_2021-09-19-08-58-27-455_com.topjohnwu.magisk.jpg
    Screenshot_2021-09-19-08-58-27-455_com.topjohnwu.magisk.jpg
    392.5 KB · Views: 56

Top Liked Posts

  • 5
    new alpha is out and working fine
    photo_2021-10-27_12-41-54.jpg

    Changelog:

    - Fixed magiskd may crash
    - Support Zygote restart
    - Fixed CWD process across namespace in isolated namespace mode
    - Improve deny list loading
    - Use Traditional Search list in deny list
    5
    Latest Canary Magisk

    Magisk (ea75a09f) (23011)

    • Make Zygisk survive zygote restarts
    • Fix crashes when Magisk environment was not properly setup. This will fix the crashes experienced after installing Magisk with patching boot images.

    Diffs to v23.0

    • [General] MagiskHide is removed from Magisk
    • [General] Support 64-bit only systems
    • [General] Support Android 12
    • [Zygisk] Introduce new feature: Zygisk
    • [Zygisk] Introduce DenyList feature to revert Magisk features in user selected processes
    • [MagiskBoot] Support patching 32-bit kernel zImages
    • [MagiskBoot] Support boot image header v4
    • [MagiskInit] Support /proc/bootconfig for loading boot configurations
    • [MagiskInit] Better support for some Meizu devices
    • [MagiskInit] Better support for some Oppo/Realme devices
    • [MagiskSU] Use isolated devpts if the kernel supports it
    • [resetprop] Deleted properties are now wiped from memory instead of just unlinking
    • [App] Build a single APK for all ABIs

    [App] Switch to use standard bottom navigation bar

    [App] Downloading modules within the Magisk app is removed

    👍 PW
    4
    hello i think i read everything but it doesn't work
    safetynet is failed.
    the riru modules must all be installed? where are they found? i have a oneplus 7t
    Oxygen os 1103.1View attachment 5442503
    Generally, Riru cannot help you for SafetyNet. If you properly enabled Zygisk rebooted, Configured DenyList (GMS and GMS unstable), rebooted, you should pass SN.
    If not, then you would need USNF and/or MHPC

    As mentioned several times here, Riru is broken with Zygisk. And in your Canary, you need Zygisk for DenyList (hence for SN).
    Therefore, if you really want Riru, you would need to switch to Alpha or Custom (many posts here how/where/what, etc) and use them as: Zygisk No, MagiskHide Yes (not the new DenyList)

    And to avoid troubles when switching the Magisk flavour, better completely uninstall Magisk before you go
    3
    got it. many thanks. had to run setenforce 1 to get the 3rd screenshot.
    Nb. There may be issues with isolated as per GitHub page for module. - it is deprecated and replaced by setns (need isolated + setns). Without Zygisk you should be able enable all options. In Alpha with Zygisk + Riru co-existing, only isolated & initrc work. PW
    2
    With the latest update, I have a failure to connect mobile wifi, any solution ?.

    my device redmi note 7. android 10, ROM stock.

    I am attaching catlog, I hope you can see the error. thank you all for your time and effort, greetings.
    Meaning Magisk Update, or Rom?

    These symptoms are often an indication of mismatched boot image...

    Did you take an OTA update and restore previously patched boot image, or perhaps updated Magisk but patched a boot image extracted from a ROM prior to an OTA update or other ROM entirely?... PW
  • 9
    Latest Alpha Magisk Chinese Translated:
    (For mavericks only! 😬)

    alpha update journal Magisk (cb4361b7-alpha-2)

    • [General] Based on cb4361b7, the content that has been merged into the upstream will not be listed anymore
    • [App] Correctly process any data from magiskd
    • [App] Support SharedUserld
    • [App] Delete the backup file after adding a thick boot mirror
    • [App] Built-in current version update log
    • [App] Use the local version when you cannot download the stub, now it can be used completely offline
    • [App] Switch to Java 8 modern time API
    • [DenyList] Dealing with suspicious props
    • [App] Expand and update SafetyNet, update the snet.jar version to 18
    • [General] Add an outdated cgroup v2 path
    • [Sepolicy] Add execmem to allow hook in zygote and system_server
    • [MagiskSU] If necessary, fall back to /dev/pts
    • [Zygisk] Repair may not take effect
    • [Busybox] Cancel optimization based on undefined behavior
    • [General] No longer automatically unlock the device block
    • [Zygisk] There is no report to prove that zygisk is incompatible with riru, remove the restriction
    • [Resetprop] Completely erase the old content when modifying/deleting
    • [General] Fix the race condition of thread pool
    • [Magisklnit] Do not intervene when booting to DSU

    How to install ?

    To install and use Magisk through the Magisk application, the general relationship should be completed directly in the application. For special circumstances such as the first installation, the image should be patched and then flashed in with the fastboot/odin tool. Customizing Recovery is not a supported method.

    You update the journal
    From 23.0 to cb4361b7

    • [General] Support pure 64-bit devices
    • [Generall supports Android 12 emulator
    • [Zygisk] Code injection framework
    • [General] Remove MagiskHide
    • [General] Support Simulator to add modules
    • [MagiskBoot] Support zimage format
    • [MagiskBoot] Add zopfhi encoder
    • [MagiskInit] Support bootconfig
    • [App] The repair installation function will now check if the script under /data/adb/magisk/ has not been updated
    • [Magisklnit] Support some Meizu devices
    • [MagiskSU] If the kernel supports it, use isolated devpts
    • [MagiskSU] Fix the pts configuration code, now no additional sepolicy rules are needed
    • [MagiskBoot] Support v4 boot image header format
    • [Magisklnit] Support oplus.fstab for some OnePlus and Opal devices
    • [App] Restart and update modules, not allowed to be marked as pending deletion
    • [App] Delete online warehouses
    • [App] Add mounting information to the saved log file
    • [App] Suitable for Android 12 API level
    • [App] Display the waiting pop-up window that is running when hide/restore the original app
    • [Stub] Open source obfuscation function
    • [Script] Check and display the sepolicy rule folder of the module.
    • [App] When the window pops up, hide the screen helmet and add layer. Android 12+ is required.
    • [App] Delete the floating bottom bar and change it to the general bottom operation bar.
    • [General] Support compilation cache
    • [General] Add rejection list function
    • [App] Delete DoH
    • [App] Delete SafetyNet
    • [App] Allow the log page to be opened when Magisk is not installed
    • [App] Display the status of Zygisk, add a reminder that restart is effective
    • [Zygisk] Correctly handle the child zygote
    • [Zygisk] Disabled riru module
    • [Sepolicy] Fix Android 8 terminal cannot get root

    👍 Marvin.
    9
    Hi all. :)

    Just a quick note for those using newer (test/unofficial) builds that have the online Module Repo removed.

    Magisk-Modules-Repo - GitHub - Link
    Magisk-Modules-Repo - Repositories - GitHub - Link

    If you keep an eye on the repo, you will see when the developer(s) push an update.
    Most of the modules have links to support threads and/or another spot that you can download the updated module.
    Didgeridoohan uses the GitHub releases option for MHPC. 🙃

    If no other option is available, you can clone or download the specific module repo and then zip it into a new Magisk module zip file. ;)

    ---

    I Hope the option of a custom module repo is not too far down the list. ;)
    Bye, Magisk-Module-Repo
    I wanted to do this for a long time, as I do not have the mental capacity and interest to moderate and curate what modules are allowed on the official repo. If I accept low quality modules, people complain; if I remove some modules, people also complain. So I made the decision to remove Magisk-Module-Repo from the Magisk app. The administration and maintenance of the GitHub organization will be transferred to trusted community members (candidates not final yet). Developers can still easily install modules using the magisk —-install-module ZIP command in its own apps; users can install modules by selecting zip files in the Magisk app.

    I do want to eventually enable users to set its own online Magisk module sources which the Magisk app can handle module downloading / installing / upgrading, but this isn’t high up on the list of things I want to do in the near future.
    State of Magisk: 2021 - WebSite - medium.com - Link


    I have been a little curious since I mentioned it in a prior post that Magisk was once on PlayStore.
    If I remember correctly, this was the main reason Magisk was booted from PlayStore. :unsure:

    Now that the module repo is removed, does Magisk now fit Google's criteria for PlayStore?

    Cheers all. :cowboy:
    8
    Guess John has given this by now:
    John Wu, Sep 22

    Fellow Googlers: I'll be giving an internal tech talk about Android modding on Sep. 30 @ 9 AM PT. Ping me at Google chat if you/your team are interested and not already invited!
    He did say to 'non Googlers':
    John Wu, Sep 30

    Now think again about all those people saying Magisk is all about hiding root 🤦‍♂️

    Sneak peek of the slides for tomorrow's tech talk. Rooting Android is sooooo easy 🤷‍♂️
    newmagisk.jpeg


    ... Just thought y'all might find John's visual aid for understanding new Magisk helpful!

    Of course, this is on his Twitter... Sorry I can't give a link...

    FWIW, a Mod has told me:
    Any link to social media is governed by the policy HERE. As per the policy, only developers are allowed to post social media links in the OPs of their development threads. Even they are not allowed to post such links on their subsequent posts in the thread...

    Github posts and links are perfectly ok since the policy mentioned above applies to social media and similar places only.

    As for quoting content from social media, it is allowed provided it is relevant to the topic of the thread and no link is given.

    Moderators usually act on reports and also on what they come across in their daily journey through the forums. It is impossible to monitor every single post on a forum of 11 million+ registered users. But when something is brought to their notice, they act.
    😬 PW
    8
    On a side note, TiBu is extremely outdated and most of the time backups will not restore properly. If you do want to make a backup so that you can clean flash android 11 then I suggest using Migrate app instead.
    Strong recommendation for Swift Backup. It's in the Google Play store. There's added functionality with root. It saved me once and restored every app better than TiBu ever did for me, even when it was working.
    8
    All that Knox stuff is why i departed Samsung phones after my Note 4 and went Pixel, and will never go back

    If you spend that much money on a device, you should be allowed to do what you want with it, without all that nonsense...
  • 1068
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p