• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

Didgeridoohan

Senior Moderator / Dev Committee / Dev Relations
Staff member
May 31, 2012
12,100
13,972
Gothenburg
Google Nexus 4
Nexus 6
so after hours nothing, i am sure something else is missing for this device, also while searching I found for the same allwinner brand a custom twrp for a TV box and it pass the signature verification, it does not work cause diffrence device, but when I try to load with the same method magisk zip it failed cause verification error, can we fix somehow the verification on magisk, searching for ways...
You cannot install the magisk.zip from the stock Android recovery, you need a custom recovery like TWRP. But if your device need to use the recovery image to install Magisk (due to no ramdisk in boot) you cannot install Magisk through recovery...

So far it sounds to me like you've managed to get a recovery image patched, but you have not yet managed to boot to a rooted system. I'm assuming you've read this:
https://topjohnwu.github.io/Magisk/install.html#magisk-in-recovery

When you do the recovery key combo to boot to a rooted system, does it boot up straight away or do you end up in recovery first? If everything is installed correctly it might just be down to a timing thing (as mentioned earlier) and you need to try different timings of releasing the buttons when the device vibrates with splash screen.

It could also be that the device simply is incompatible too, but let's hope it's a timing thing.
 
Mar 25, 2012
1,053
772
31
Crete,,,Heraklio
You cannot install the magisk.zip from the stock Android recovery, you need a custom recovery like TWRP. But if your device need to use the recovery image to install Magisk (due to no ramdisk in boot) you cannot install Magisk through recovery...

So far it sounds to me like you've managed to get a recovery image patched, but you have not yet managed to boot to a rooted system. I'm assuming you've read this:
https://topjohnwu.github.io/Magisk/install.html#magisk-in-recovery

When you do the recovery key combo to boot to a rooted system, does it boot up straight away or do you end up in recovery first? If everything is installed correctly it might just be down to a timing thing (as mentioned earlier) and you need to try different timings of releasing the buttons when the device vibrates with splash screen.

It could also be that the device simply is incompatible too, but let's hope it's a timing thing.
it always boot to recovery,tried 100 times sure!fiffrent timing-with cable and without,im tired but i dont want to give up,somebody who can examine the stock recovery will find a way sure!
 

Didgeridoohan

Senior Moderator / Dev Committee / Dev Relations
Staff member
May 31, 2012
12,100
13,972
Gothenburg
Google Nexus 4
Nexus 6
it always boot to recovery,tried 100 times sure!fiffrent timing-with cable and without,im tired but i dont want to give up,somebody who can examine the stock recovery will find a way sure!

I took a quick peek at the images you provided earlier. Magisk patches them just fine, without any errors and the boot image is indeed missing ramdisk so the recovery image is what you need to use (unless it's a Xiaomi situation kind of thing where the bootloader does accept the added initramfs, but that's probably unlikely). I can't tell you anything more about the images than that though... Not my area of expertise.

Since you haven't been able to get the boot key combo working yet, that is what I would focus my efforts on for now. But, maybe that just means that you haven't been able to install the patched image properly, or that it isn't compatible somehow. It could of course be something completely different, but since it seems like you're the pioneer (pun intended) for this device it's hard for us to know what that could be.
 
Mar 25, 2012
1,053
772
31
Crete,,,Heraklio
I took a quick peek at the images you provided earlier. Magisk patches them just fine, without any errors and the boot image is indeed missing ramdisk so the recovery image is what you need to use (unless it's a Xiaomi situation kind of thing where the bootloader does accept the added initramfs, but that's probably unlikely). I can't tell you anything more about the images than that though... Not my area of expertise.

Since you haven't been able to get the boot key combo working yet, that is what I would focus my efforts on for now. But, maybe that just means that you haven't been able to install the patched image properly, or that it isn't compatible somehow. It could of course be something completely different, but since it seems like you're the pioneer (pun intended) for this device it's hard for us to know what that could be.
Thanks for your time! Sure I flash the patched recovery right cause if I flash boot
Img on recovery img can't boot on recovery, I flash back patched recovery and it boot on recovery, maybe the key combo don't work on this device, is any other way to patch the system? Tried to unpack it but I can't find working squashfs extractor
 

pndwal

Senior Member
Thanks for your time! Sure I flash the patched recovery right cause if I flash boot
Img on recovery img can't boot on recovery, I flash back patched recovery and it boot on recovery, maybe the key combo don't work on this device, is any other way to patch the system? Tried to unpack it but I can't find working squashfs extractor
No way to patch system; Magisk needs to reside in ramdisk as I mentioned, preferably in boot partition, otherwise in recovery partition...

I don't have experience with Magisk in Recovery, but it seems the trick to key combo detection is to release all keys at the earliest possible time without booting to system...

Since you can reach recovery, don't bother with Sammy USB-connected-for-Android-11 requirement...

Also, can we assume you used this device to patch recovery.img in Magisk App? PW
 
Last edited:
Mar 25, 2012
1,053
772
31
Crete,,,Heraklio
No way to patch system; Magisk needs to reside in ramdisk as I mentioned, preferably in boot partition, otherwise in recovery partition...

I don't have experience with Magisk in Recovery, but it seems the trick to key combo detection is to release all keys at the earliest possible time without booting to system...

Since you can reach recovery, don't bother with Sammy USB-connected-for-Android-11 requirement...

Also, can we assume you used this device to patch recovery.img in Magisk App? PW
Yes off course
 

pndwal

Senior Member
Alpha Magisk update (61783ffc-alpha)

[General] Based on 61783ffc, the content that has been merged into the upstream is no longer listed

[App] Correctly process any data from magiskd

[App] Support SharedUserld

[App] Delete the backup file after restoring the boot mirror image

[App] Built-in current version update log

[App] Use the local version when you cannot download the stub, now it can be used completely offline

[Busybox] Fix the default shell path

[App] Switch to Java 8 modern time API

[DenyList] Deal with suspicious props

[App] Expand and update SafetyNet, update the version of snet.jar to 18

[Sepolicy] Sepolicy with built-in LSPosed

[General] Add an obsolete cgroup v2 path

[Zygisk] Fix app_zygote and webview_zygote binary


- You update the journal From 23.0 to 61783ffc

[General] Supports pure 64-bit devices

[General] Support Android 12 emulator

[Zygisk] Code injection framework

[General] Remove MagiskHide

[General] Support Simulator to add modules

[MagiskBoot] Support zimage format

[MagiskBoot] Add zopfi encoder

[Magisklnit] Support bootconfig

[App] The repair installation function will now check if the script under /data/adb/magisk/ has not been updated

[Magisklnit] Support some Meizu devices

[MagiskSU] If the kernel supports it, use isolated devpts

[MagiskSU] Fix the pts configuration code, now no additional sepolicy rules are needed

[MagiskBoot] Support v4 boot image header format

[Magisklnit] Support oplus.fstab for some OnePlus and Opal devices

[App] Restart and update modules, not allowed to be marked as pending deletion

[App] Delete online warehouses

[App] Add mounting information to the saved log file

[App] Suitable for Android 12 API level

[App] Display the waiting pop-up window that is running when hide/restore the original app

[Stub] Open source obfuscation function

[Script] Check and display the sepolicy rule folder of the module.

[App] When the window pops up, hide the screen and add layers. Android 12+ is required

[App] Delete the floating bottom bar and change it to the general bottom operation bar

[General] Support compilation and cache

[General] Add rejection list function

[App] Delete DoH

[App] Delete SafetyNet

[App] Allow the log page to be opened when Magisk is not installed

[App] Display Zygisk status, add restart to take effect to remind Zygisk to Fix the problem

PW
 
Last edited:

J.Michael

Recognized Contributor
Jan 20, 2018
870
732
Samsung Galaxy Tab A series
yes i checked,,is the same size both boot and recovery,patched and stock version but when i extract ptched versions i see the diffrence in boot and recovery

Thanks for your time! Sure I flash the patched recovery right cause if I flash boot
Img on recovery img can't boot on recovery, I flash back patched recovery and it boot on recovery, maybe the key combo don't work on this device, is any other way to patch the system? Tried to unpack it but I can't find working squashfs extractor
Could you repeat what you said about the sizes of the original/patched boot/recovery? I thought you said they were all the same size, but then you said you see the difference. Do you see different sizes? Or were you looking at the contents of the images?

If on an unpatched device you can get to recovery, then you have the right key combo to get to recovery. What we keep harping on is, when you magisk-patch recovery, when you want to boot to magisk-controlled Android, you have to pick just the right time to let go of all buttons. It is easy to tell that you let go too late: you end up in recovery. What's harder is telling that you let go too soon: it boots Android, and you can't tell whether Magisk is active until it finishes booting so you can run the Magisk app. (It might be you could test by looking for files that only exist when Magisk is active, but I'm not sure that they are there before Magisk has done its "more setup".)
 
Mar 25, 2012
1,053
772
31
Crete,,,Heraklio
Could you repeat what you said about the sizes of the original/patched boot/recovery? I thought you said they were all the same size, but then you said you see the difference. Do you see different sizes? Or were you looking at the contents of the images?

If on an unpatched device you can get to recovery, then you have the right key combo to get to recovery. What we keep harping on is, when you magisk-patch recovery, when you want to boot to magisk-controlled Android, you have to pick just the right time to let go of all buttons. It is easy to tell that you let go too late: you end up in recovery. What's harder is telling that you let go too soon: it boots Android, and you can't tell whether Magisk is active until it finishes booting so you can run the Magisk app. (It might be you could test by looking for files that only exist when Magisk is active, but I'm not sure that they are there before Magisk has done its "more setup".)
Size is the same but inside I see the extra files of magisk, I will try again today to see if I manage to boot with root, for confirmation, should I use only the keys to boot in recovery or all?
 

martyfender

Senior Member
Mar 9, 2017
3,162
1,682
Indianapolis, IN
Alpha Magisk update (61783ffc-alpha)

[General] Based on 61783ffc, the content that has been merged into the upstream is no longer listed

[App] Correctly process any data from magiskd

[App] Support SharedUserld

[App] Delete the backup file after restoring the boot mirror image

[App] Built-in current version update log

[App] Use the local version when you cannot download the stub, now it can be used completely offline

[Busybox] Fix the default shell path

[App] Switch to Java 8 modern time API

[DenyList] Deal with suspicious props

[App] Expand and update SafetyNet, update the version of snet.jar to 18

[Sepolicy] Sepolicy with built-in LSPosed

[General] Add an obsolete cgroup v2 path

[Zygisk] Fix app_zygote and webview_zygote binary


- You update the journal From 23.0 to 61783ffc

[General] Supports pure 64-bit devices

[General] Support Android 12 emulator

[Zygisk] Code injection framework

[General] Remove MagiskHide

[General] Support Simulator to add modules

[MagiskBoot] Support zimage format

[MagiskBoot] Add zopfi encoder

[Magisklnit] Support bootconfig

[App] The repair installation function will now check if the script under /data/adb/magisk/ has not been updated

[Magisklnit] Support some Meizu devices

[MagiskSU] If the kernel supports it, use isolated devpts

[MagiskSU] Fix the pts configuration code, now no additional sepolicy rules are needed

[MagiskBoot] Support v4 boot image header format

[Magisklnit] Support oplus.fstab for some OnePlus and Opal devices

[App] Restart and update modules, not allowed to be marked as pending deletion

[App] Delete online warehouses

[App] Add mounting information to the saved log file

[App] Suitable for Android 12 API level

[App] Display the waiting pop-up window that is running when hide/restore the original app

[Stub] Open source obfuscation function

[Script] Check and display the sepolicy rule folder of the module.

[App] When the window pops up, hide the screen and add layers. Android 12+ is required

[App] Delete the floating bottom bar and change it to the general bottom operation bar

[General] Support compilation and cache

[General] Add rejection list function

[App] Delete DoH

[App] Delete SafetyNet

[App] Allow the log page to be opened when Magisk is not installed

[App] Display Zygisk status, add restart to take effect to remind Zygisk to Fix the problem

PW
How is this version working for you?
 

J.Michael

Recognized Contributor
Jan 20, 2018
870
732
Samsung Galaxy Tab A series
Size is the same but inside I see the extra files of magisk, I will try again today to see if I manage to boot with root, for confirmation, should I use only the keys to boot in recovery or all?
If you patched recovery image, and "installed" it (I don't know what mechanism you use),
Whatever key combo you use to boot to recovery, that's the key combo you use to try to boot Android-with-Magisk.

You could try writing the magisk-patched-recovery to the boot partition. Then you wouldn't need a special key combo to boot. I just do not know whether Magisk booting in recovery requires the boot partition at some point.
 
Last edited:

73sydney

Senior Member
Jul 21, 2018
1,890
1,650
Sydney
Google Pixel 2 XL
Alpha Magisk update (61783ffc-alpha)

[General] Based on 61783ffc, the content that has been merged into the upstream is no longer listed

<snip>

PW

Just a reminder for peeps that this like all alphas is bleeding edge, and there are with
this lastest alpha of reports of:

* intermittent root failure (requiring reboot)
* zygote non-functioning
* safetynet failure with denylist enabled

The above can be device dependent

Be prepared for such possibilities, and for the first step in resolution to return to
official Magisk builds, as reporting faults here is unlikely to lead to resolution as
alpha dev doesnt monitor XDA and gets most bug reports via Telegram where we
see them.

In short, it can still be borky folks, your mileage may vary

Return to official builds *may* requite removing /data/adb/magisk.db if not the entire
/data/adb path, after first doing a full uninstall of magisk from within magisk manager


Completely factual post, must be impersonal machine, just facts. Must not smile, must not
emote.
 
Last edited:
  • Like
Reactions: duttyend
Mar 25, 2012
1,053
772
31
Crete,,,Heraklio
If you patched recovery image, and "installed" it (I don't know what mechanism you use),
Whatever key combo you use to boot to recovery, that's the key combo you use to try to boot Android-with-Magisk.

You could try writing the magisk-patched-recovery to the boot partition. Then you wouldn't need a special key combo to boot. I just do not know whether Magisk booting in recovery requires the boot partition at some point.
Now I'm thinking, is any way to disable recovery while holding the combo key so the combo key work only for the magisk too boot?
 

Didgeridoohan

Senior Moderator / Dev Committee / Dev Relations
Staff member
May 31, 2012
12,100
13,972
Gothenburg
Google Nexus 4
Nexus 6
Now I'm thinking, is any way to disable recovery while holding the combo key so the combo key work only for the magisk too boot?
It's possible to alter the device so that it boots directly to Magisk, it's been done on a few Samsung devices I believe. But, that meant manually baking Magisk into the kernel so you'd have to figure that out (I have no idea).
 

Didgeridoohan

Senior Moderator / Dev Committee / Dev Relations
Staff member
May 31, 2012
12,100
13,972
Gothenburg
Google Nexus 4
Nexus 6
Completely factual post, must be impersonal machine, just facts. Must not smile, must not
emote.
Come on mate... That's not what it's about. It's the page after page of off-topic social media/Telegram style posting, that clutters the thread so much that discussions about actual Magisk stuff gets even harder to find (in this impossible to search mammoth of a thread), that is the problem.

I'll keep an eye on things (since I pretty much live in the Magisk forum anyway) and let you guys know if it starts getting out of hand.

Nice try at satire though... It baited me hook line and sinker. :ROFLMAO:
 

Top Liked Posts

  • 4
    Note from John's repo.
    Code:
    // Riru and its modules are not compatible with zygisk
    Magisk - GitHub - module.cpp - Line 704

    Before you could disable zygisk and Riru would work but..
    Magisk's DenyList would be disabled since it requires zygisk.

    With the newest commits (and the shift to zygisk).
    Magisk - GitHub - commits - Link

    Riru will not run even if you disable zygisk.
    Gives error about zygote not running.

    Cheers. :cowboy:
    There was a similar discussion about the disabled Riru on TheHitMan7 TG channel

    But for the matter of fact, in Alpha Riru works and with Zygisk - as posted here previously I use:
    - Riru
    - Riru-Momohider with isolated option enabled (hiding su in the path)
    - Riru-LSPosed with GravityBox-R and CustoMIUizer modules

    It worked with the Riru and LSPosed versions from the beginning of the month and with the latest as updated two days ago

    And of course, with Zygisk enabled
    4
    @ipdev, @zgfg

    Yup, Riru and Zygisk coexist again and work well (with exceptions like some MomoHider configurations) in last two Alpha builds since this change:
    Latest Alpha Magisk cb4361b7-alpha
    ...
    Riru / Zygisk coexistence seems to be back!
    🎉🎊⚡🥝🧀
    ...
    Chinese Translated:
    ...
    ● [Zygisk] From the current situation, there is no crash report to prove zygisk and riru
    Incompatible, temporarily cancel the restriction, observe the situation
    ...
    👍 PW
    4
    Sorry, if you flashed uninstall.zip, modules and everything from Magisk should have been wiped

    Have you checked /cache/magisk.log

    For the reference, mine attached (Alpha working fine)

    Well, it took a while but I can confirm: Magisk Alpha does have some bug while patching boot (maybe for a few devices?). At least when in comparison to Stable Magisk v23.

    > Samsung S4 Mini Dual SIM (I9192)
    > Official TWRP 3.5.2_9-0
    > I've completely clean flashed LOS 14.1, 16.0, 17.1, 18.1 (Android 7, 9, 10, 11), formatting data and everything. No encryption. Tried both Magisk v23 and Magisk Alpha with all of them just after fresh install, each one.
    > It always boots fine with default system (no Magisk yet). All Androids work as expected.
    > It always install and boots fine with STABLE Magisk v23 (both flashing zip on TWRP or patching boot.img and then flashing patched on TWRP). All Androids works rooted as expected.
    > Magisk ALPHA: seems to install zip fine on TWRP, but CANNOT boot. Freezes on the "Samsung" logo.
    > Magisk ALPHA: seems to patch fine boot.img, but after flashing patched image CANNOT boot. Freezes on the "Samsung" logo.

    The way Magisk Alpha is patching boot.img is the problem. The patched image freezes the S4 Mini (I9192).

    Thanks again @zgfg but it seems Magisk Alpha developers will have to check that.

    By the way, there is no /cache/magisk.log with Magisk Alpha. Probably because boot freezes at the very beginning.
    3
    Testing today the new TheHitMan7 build 7b5f065e from t.me/custommagisk (not released yet to Github)

    WebView is fixed now in this build

    However, seems it doesn't support Riru
    Note from John's repo.
    Code:
    // Riru and its modules are not compatible with zygisk
    Magisk - GitHub - module.cpp - Line 704

    Before you could disable zygisk and Riru would work but..
    Magisk's DenyList would be disabled since it requires zygisk.

    With the newest commits (and the shift to zygisk).
    Magisk - GitHub - commits - Link

    Riru will not run even if you disable zygisk.
    Gives error about zygote not running.

    Cheers. :cowboy:
    1
    Is this the same build from September 26th?
    Latest Alpha is from TG, Oct 4, and we use that one with Riru
  • 14
    MOD ACTION:

    Enough is enough. Despite my deleting some off topic posts yesterday, the spam continues. Thread cleaned. Please check your PM inbox and avoid off topic posts.
    13
    Btw, I've slso played with. There is one MIUI app that was not possible to enable for MagiskHide in Magisk v23 official - it was not showing in GUI.
    It was only possible through the Terminal, by using magiskhide command line

    Ofc, magiskhide applet is no more available (and there is no command-line applet for DenyList), but by enabling OS apps in Filter I was able to see and check-in that Security center app for DenyList

    And I tested with MagiskDetector, having the same results as with previous Alpha versions (no better or worse)
    And yeah, it says that "Maisk Hide works properly" 🤩
    Not an applet but, you can still do it by command line. :sneaky:
    Code:
    magisk --denylist add com.google.android.gms com.google.android.gms
    magisk --denylist add com.google.android.gms com.google.android.gms.unstable

    Magisk - Multi-purpose Utility
    Code:
    Usage: magisk [applet [arguments]...]
       or: magisk [options]...
    
    Options:
       -c                        print current binary version
       -v                        print running daemon version
       -V                        print running daemon version code
       --list                    list all available applets
       --remove-modules          remove all modules and reboot
       --install-module ZIP      install a module zip file
    
    Advanced Options (Internal APIs):
       --daemon                  manually start magisk daemon
       --stop                    remove all magisk changes and stop daemon
       --[init trigger]          start service for init trigger
                                 Supported init triggers:
                                 post-fs-data, service, boot-complete
       --unlock-blocks           set BLKROSET flag to OFF for all block devices
       --restorecon              restore selinux context on Magisk files
       --clone-attr SRC DEST     clone permission, owner, and selinux context
       --clone SRC DEST          clone SRC to DEST
       --sqlite SQL              exec SQL commands to Magisk database
       --path                    print Magisk tmpfs mount path
       --denylist ARGS           denylist config CLI
    
    Available applets:
        su, resetprop

    DenyList Config CLI
    Code:
    Usage: magisk --denylist [action [arguments...] ]
    Actions:
       status          Return the enforcement status
       enable          Enable denylist enforcement
       disable         Disable denylist enforcement
       add PKG [PROC]  Add a new target to the denylist
       rm PKG [PROC]   Remove target(s) from the denylist
       ls              Print the current denylist
       exec CMDs...    Execute commands in isolated mount
                       namespace and do all unmounts

    Cheers. :cowboy:
    11
    Latest Alpha Magisk cb4361b7-alpha

    *** For Mavericks only! ***

    Riru / Zygisk coexistence seems to be back!
    🎉🎊⚡🥝🧀

    Chinese Translated:
    alpha update log
    Magisk (cb4361b7-alpha)


    ● [General] Based on cb4361 b7, the content that has been merged upstream is no longer listed
    ● [App] Correctly process any data from magiskd
    ● [App] Support SharedUserld
    ● [App] Delete the backup file after restoring the boot image
    ● [App] Built-in current version update log
    ● [App] Use the local version when the stub cannot be downloaded, now it can be used completely offline
    ● [App] Switch to the modern time API of Java 8
    ● [DenyList] handle suspicious props
    ● [App] Update SafetyNet extension, update snet.jar version to 18
    ● [General] Add an obsolete cgroup v2 path
    ● [Sepolicy] Add execmem to allow zygote and system_server Hook
    ● [MagiskSU] If necessary, fall back to /dev/pts
    ● [Zygisk] Fix Circumstances that may not take effect
    ● [Busybox] Cancel optimization based on undefined behavior
    ● [General] No longer automatically unlock the device block
    ● [Zygisk] From the current situation, there is no crash report to prove zygisk and riru
    Incompatible, temporarily cancel the restriction, observe the situation

    Upstream update log
    From 23.0 to cb4361b7


    ● [General] supports pure 64-bit devices
    ● [General] Support Android 12 emulator
    ● [Zygisk] Code Injection Framework
    ● [General] Remove MagiskHide
    ● [General] Support special simulator loading module
    ● [MagiskBoot] Support zImage format
    ● [MagiskBoot] Add zopfli encoder
    ● [Magisklnit] Support bootconfig
    ● [App] Repair installation function will now check the script under /data/adb/magisk/ is not updated
    ● [MagiskInit] Support some Meizu devices
    ● [MagiskSU] If the kernel supports it, use isolated devpts
    ● [MagiskSU] Fix the pts configuration code, now no extra sepolicy rules
    ●[MagiskBoot] Support v4 boot image header format
    ● [MagiskInit] Support opltus.fstab for some OnePlus and Opal devices
    ● [App] Update modules to be restarted, not allowed to be marked as pending deletion
    ● [App] Delete online warehouse
    ● [App] Add mounting information to the saved log file
    ● [App] Adapt to Android 12 API level
    ● [App] Display the waiting pop-up window when the app is hidden/restored
    ● [Stub] Open source obfuscation function
    ● [Script] Check and display the sepolicy rule folder of the module
    ● [App] Hide screen overlay for pop-up window, Android 12+ is required
    ● [App] Delete the floating bottom bar and change it to the general bottom operation bar
    ● [General] Support special compilation cache
    ● [General] Add rejection list function
    ● [App]Delete DOH
    ● [App]Delete SafetyNet
    ● [App] Allow the log page to be opened when Magisk is not installed
    ● [App] Display Zygisk status, add restart reminder
    ● [Zygisk] Correctly handle child zygote
    ● [Zygisk] Disable conflicting riru modules
    ● [Sepolicy] Fix Android 8 terminal cannot get root

    👍 PW
    11
    @hfam I would suggest going with the latest stable release for now, since the Alpha releases are highly experimental and @topjohnwu will create an official release whenever he deems those changes to be a bit more mature.

    The official installation instructions is always a good place to start:
    https://topjohnwu.github.io/Magisk/install.html

    But I see that there are a few threads on this in the 5a threads as well:
    https://forum.xda-developers.com/t/magisk-root-procedure-for-5a-5g.4327361/

    It should be pretty straightforward, since it's a Pixel device. Just patch the boot image and flash it to your device.

    To pass SafetyNet you'll need to use the new Universal SafetyNet Fix as well (as long as you stay stock you shouldn't need anything else):
    https://github.com/kdrag0n/safetynet-fix

    Android 12 is gonna need some updates on the Magisk side, but that'll be taken care of in good time...

    Everything that's being discussed in this thread over the past weeks/months will probably be made much more clear once John releases his next build.
    11
    Hey all,
    As promised, I wrote up a step-by-step tutorial for the Pixel 5a (though it applies to about all the Pixels, much of it I used on my Pixel 2 over the past 4+ years):


    I know it's a book, but I wanted to make sure I put it in everyday language and tried to make it so even a first timer could go through it and feel confident moving forward and getting root, passing SafetyNet, and update with system updates in the future with confidence.

    Anyhow, it's my attempt to give something back to the community I've gained so much from and leaned on so many times for help. If it helps even one person I'll be happy.

    Thanks again to the entire community, and particularly the folks who have been here helping tirelessly and without reserve to get everyone up and going. You all know who you are and I gave proper name attribution in the tutorial thread. I'm exhausted, so I'm gonna go grab some dinner, that took hours to write! hahahahaah!!

    Be well everyone, SO happy my P5a is fully functioning, you folks are just amazing.

    hfam
  • 1067
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p