• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

zgfg

Senior Member
Oct 10, 2016
5,855
3,325
So far so good

However, I cannot be happy that Zygisk cannot be hidden (it acts like a time bomb)
 

Attachments

  • 1.jpg
    1.jpg
    159.6 KB · Views: 72
  • 5.jpg
    5.jpg
    237.4 KB · Views: 71
  • 2.jpg
    2.jpg
    187.1 KB · Views: 66
  • 6.jpg
    6.jpg
    63.5 KB · Views: 64
  • 3.jpg
    3.jpg
    227 KB · Views: 61
  • 4.jpg
    4.jpg
    209.3 KB · Views: 70

mikwii2000

Member
Nov 1, 2015
16
5
Venice
Hi everyone, and thanks the developers for this great app. I need help because I can't hide the magisk app, the option isn't available/clickable in the Magisk settings as I show in the screenshot. I'm running an Android 11-based AOSP custom rom (Derpfest).
Thanks to anyone that can help ;)
Screenshot_20210923-220134479 (1).jpg
 

73sydney

Senior Member
Jul 21, 2018
1,904
1,667
Sydney
Google Pixel 2 XL
Come on mate... That's not what it's about. It's the page after page of off-topic social media/Telegram style posting, that clutters the thread so much that discussions about actual Magisk stuff gets even harder to find (in this impossible to search mammoth of a thread), that is the problem.

I'll keep an eye on things (since I pretty much live in the Magisk forum anyway) and let you guys know if it starts getting out of hand.

Nice try at satire though... It baited me hook line and sinker. :ROFLMAO:

Answered in private, cheers
 

J.Michael

Recognized Contributor
Jan 20, 2018
874
739
Samsung Galaxy Tab A series
Now I'm thinking, is any way to disable recovery while holding the combo key so the combo key work only for the magisk too boot?
If you mean, make the bootloader have no interest in booting recovery, that wouldn't help you. Magisk hijacked recovery, Magisk *needs* the bootloader to load "recovery", which is now really Magisk. Once Magisk gets control, Magisk chooses whether to keep control or to turn control over to the original "recovery".

If you mean, make Magisk *always* keep control when booted as part of recovery, in theory it would be trivial: just change the "if" test. I keep hearing that Magisk is open source, so all you need to do is checkout a copy and make the change.

In practice, I don't like my odds. I don't know your background, so I can't guess your chances. Rotsa ruck!
 

ipdev

Recognized Contributor
Feb 14, 2016
1,542
1
1,985
Google Nexus 10
Nexus 7 (2013)
Hi everyone, and thanks the developers for this great app. I need help because I can't hide the magisk app, the option isn't available/clickable in the Magisk settings as I show in the screenshot. I'm running an Android 11-based AOSP custom rom (Derpfest).
Thanks to anyone that can help ;)
View attachment 5417127
Requires the Update Channel to be accessible.
(You have to be online to hide the Magisk app. 😞)

The update channel has to be set to the Magisk app version you want to install.
Using vvb2060's alpha builds, it will be pointing the the version released to github.
vvb2060 [magisk_files] - GitHub - alpha - Link

From the screenshot, it appears you set the Update Channel to Custom Channel.
The Custom Channel is not set so no online version can be found.

Cheers. :cowboy:
 

pndwal

Senior Member
How is this version working for you?
(Alpha is for mavericks only! 😬 )

As already mentioned, it's fine at present w/ caveats mentioned re. ease of Zygisk detection which vvb2060 has stated is impossible to hide, at least at present.

I changed back to USNF 2.1.1 & Riru (last build didn't like Riru for me), enabled LSPosed too, updated Magisk / rebooted and all seemed good; SafetyNet pass, stable etc.

On next reboot SafetyNet failed inexplicably however. --> disabled Riru and USNF, rebooted, Reinstalled USNF 2.1.1 for good measure, enabled Riru, rebooted...

--> SafetyNet passing, system stable, SafetyNet survives reboots even with LSPosed, webview fine, no further issues.

@vvb2060 seems to be restoring just enough of the revoked MagiskHide commits to allow SafetyNet pass ATM, and there do seem to be more mod traces being detected. I can't even seem to hide 'MagiskHide' (aka MagiskDeny) any longer. See screenshots.

I'm guessing others may need to supply modules (made more powerful by Zygisk at least) or other solutions for hiding these, and I don't assume even SafetyNet will pass without at least an updated USNF in future TJW builds. Hiding Zygisk itself may be a tall order...
Screenshot_2021-09-24-13-38-23-932_com.topjohnwu.magisk.jpg
Screenshot_2021-09-24-13-39-59-013_io.github.vvb2060.mahoshojo.png
Screenshot_2021-09-24-13-34-43-389_io.github.vvb2060.magiskdetector.jpg
Screenshot_2021-09-24-13-34-17-482_io.github.vvb2060.zygiskdetector.jpg
😜 PW
 
  • Like
Reactions: jons99 and BillGoss

mikwii2000

Member
Nov 1, 2015
16
5
Venice
Requires the Update Channel to be accessible.
(You have to be online to hide the Magisk app. 😞)

The update channel has to be set to the Magisk app version you want to install.
Using vvb2060's alpha builds, it will be pointing the the version released to github.​
vvb2060 [magisk_files] - GitHub - alpha - Link

From the screenshot, it appears you set the Update Channel to Custom Channel.
The Custom Channel is not set so no online version can be found.

Cheers. :cowboy:
Thank you for your time man, that solved my problem!
 
Mar 25, 2012
1,053
772
31
Crete,,,Heraklio
If you mean, make the bootloader have no interest in booting recovery, that wouldn't help you. Magisk hijacked recovery, Magisk *needs* the bootloader to load "recovery", which is now really Magisk. Once Magisk gets control, Magisk chooses whether to keep control or to turn control over to the original "recovery".

If you mean, make Magisk *always* keep control when booted as part of recovery, in theory it would be trivial: just change the "if" test. I keep hearing that Magisk is open source, so all you need to do is checkout a copy and make the change.

In practice, I don't like my odds. I don't know your background, so I can't guess your chances. Rotsa ruck!

News! Just created twrp, all night was working and now is ready, let's see now what I can do with magisk!
 

Attachments

  • DSC_0045.JPG
    DSC_0045.JPG
    3.3 MB · Views: 49

Stillhard

Senior Member
Sep 25, 2016
60
34
Tried newest alpha, zygisk = No, ramdisk = yes, denylist(s) active and running (weird)
Reverted to 0ab31ab0-alpha, zygisk = Yes...
For now i'm happy with 9bf835e8-alpha
 
Mar 25, 2012
1,053
772
31
Crete,,,Heraklio
So guys after tests I have to find out how I add squashfs support on twrp, cause I can't do much, what I saw is that when I rebooted to system magisk was not working like the first place, tried to boot to twrp and guess what, it booted to stock recovery, how? I didn't flash the stock recovery, I searched and I find out that when it booting to system everything I has flash goes back to stock, for this magisk don't work when I trying to boot with combo key, everything goes back to stock without flashing, so the patched recovery from magisk goes back to stock while booting, I will make more research!
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
So guys after tests I have to find out how I add squashfs support on twrp, cause I can't do much, what I saw is that when I rebooted to system magisk was not working like the first place, tried to boot to twrp and guess what, it booted to stock recovery, how? I didn't flash the stock recovery, I searched and I find out that when it booting to system everything I has flash goes back to stock, for this magisk don't work when I trying to boot with combo key, everything goes back to stock without flashing, so the patched recovery from magisk goes back to stock while booting, I will make more research!
Behaviour is pretty standard w/ stock ROMs (eg MIUI):
Note many devices will replace your custom recovery automatically during first boot. To prevent this, use Google to find the proper key combo to enter recovery. After typing fastboot reboot, hold the key combo and boot to TWRP. Once TWRP is booted, TWRP will patch the stock ROM to prevent the stock ROM from replacing TWRP. If you don't follow this step, you will have to repeat the install.
https://twrp.me/xiaomi/xiaomimi9tpro.html

Nb. as mentioned, installing Magisk zip installer from TWRP will only succeed if bootloader contains 'boot' ramdisk support to allow basic ramdisk added by Magisk to be utilised... Of course you may be considering other custom recovery tricks. 😛 PW
 

pndwal

Senior Member
Tried newest alpha, zygisk = No, ramdisk = yes, denylist(s) active and running (weird)
Reverted to 0ab31ab0-alpha, zygisk = Yes...
For now i'm happy with 9bf835e8-alpha
Interestingly, I had such issues with 0ab31ab0-alpha with Riru enabled, but issue is gone for me in 61783ffc-alpha...

You could try disabling Riru & USNF 2.x, rebooting, checking Zygisk status / settings, then enabling again; I needed this initially - actually uninstalled USNF, disabled Riru and rebooted before installing again... No issue since on RN8T.

Of course this may be a per device issue.

John and vvb2060 are still busy with implementation of Zygisk; this may help in next builds:
https://github.com/topjohnwu/Magisk/pull/4720
... merged with Commits on Sep 24, 2021:
https://github.com/vvb2060/Magisk/commits/app_zygote
... there'll be more too. PW
 
  • Like
Reactions: ipdev and rodken

J.Michael

Recognized Contributor
Jan 20, 2018
874
739
Samsung Galaxy Tab A series
Behaviour is pretty standard w/ stock ROMs (eg MIUI):

https://twrp.me/xiaomi/xiaomimi9tpro.html
Note many devices will replace your custom recovery automatically during first boot. To prevent this, use Google to find the proper key combo to enter recovery. After typing fastboot reboot, hold the key combo and boot to TWRP. Once TWRP is booted, TWRP will patch the stock ROM to prevent the stock ROM from replacing TWRP. If you don't follow this step, you will have to repeat the install.
He showed us a screenshot of TWRP running.
Does he have to tell TWRP to protect itself?
 

J.Michael

Recognized Contributor
Jan 20, 2018
874
739
Samsung Galaxy Tab A series
So guys after tests I have to find out how I add squashfs support on twrp, cause I can't do much, what I saw is that when I rebooted to system magisk was not working like the first place, tried to boot to twrp and guess what, it booted to stock recovery, how? I didn't flash the stock recovery, I searched and I find out that when it booting to system everything I has flash goes back to stock, for this magisk don't work when I trying to boot with combo key, everything goes back to stock without flashing, so the patched recovery from magisk goes back to stock while booting, I will make more research!
Please put more space between thoughts. Maybe an occasional period or carriage return.

What happens if you
Code:
fastboot boot magisk-patched-recovery.img
?
 
  • Like
Reactions: digger16309

Top Liked Posts

  • 2
    I stand to be corrected here, but I think MHPC now changes 'sensitive' props that MagiskHide used to handle to 'safe' (undetected) values by default (even if MHPC is not configured).

    This may do no harm of course, but it should be understood that MHPC is no longer 'dormant' when reset or left unconfigured.

    Also, as USNF now apparently does this also, this function may be duplicated / redundant, although I imagine this wouldn't cause any real conflict, only increase load time marginally. PW
    The sensitive props changing is active by default, yes, but only ever does anything if a prop is set to a sensitive value.
    1
    Didn't know and didn't expect (changes if not activated in the module).
    However, my /data/adb/modules/MagiskHidePropsConf/system.prop is empty (besides the header), hence the module makes no props changes through that file for me

    Yet, my sensitive props are already ok by Xiaomi.eu ROM and I pass SafetyNet with or without MHPC.
    Anyway, since I usually experiment (also systemlessly) with props changes by directly manipulating my /data/adb/modules/.../system.prop file, I have now disabled the dormant or not MHPC :)
    So seems no effect where prop already changed, which explains your result.

    Ref for active setting of 'trigering' values to 'safe' is here:
    https://github.com/Magisk-Modules-R...README.md#setreset-magiskhide-sensitive-props PW
    1
    wasnt dated by much

    i tend not to invite the possibility of more of the same, when i can go right back to stable ...im getting too old for much testing these days Marvin
    Yup, only one more TJW commit:
    https://github.com/topjohnwu/Magisk/commit/fe41df87bb34926cf2d6b448dd5a2878d90d4dc1
    fixing this race condition:
    https://github.com/topjohnwu/Magisk/pull/4759
    Check the best minds on that: reopened, and just closed again...

    Clearly some vvb2060 commit(s) too (esp. removing Check SafetyNet).

    The fact that vvb2060 pushed fix so quickly should say something. Others reported abfb3bb3-alpha issues gone too.

    8276a077-alpha is all good for me ATM... We'll see...

    However, I always try to remember 'you can lead a mouse to water, but you cannot make it think'... 😜 ... Perhaps life on the bleeding edge does require too much of that... so just don't talk to me about life... Marvin.
    1
    This'll be fun:

    @MishaalRahman (late of XDA) posted (on twitter) he just got WSA (Windows Subsystem for Android) up and running with Windows 11 (yes, you can sideload APKs!).

    Of course, John is now pulling out all stops to 'root' it with Magisk! - Magisk for Windows; what a treat!

    There's no ramdisk, but he's located 4 stage init (last 2 are Android 2SI)

    He says "I found the init, the kernel binary, and initrd.img. Let's get things cooking baby!"... Go John! 😃 PW
  • 11
    Latest Alpha Magisk cb4361b7-alpha

    *** For Mavericks only! ***

    Riru / Zygisk coexistence seems to be back!
    🎉🎊⚡🥝🧀

    Chinese Translated:
    alpha update log
    Magisk (cb4361b7-alpha)


    ● [General] Based on cb4361 b7, the content that has been merged upstream is no longer listed
    ● [App] Correctly process any data from magiskd
    ● [App] Support SharedUserld
    ● [App] Delete the backup file after restoring the boot image
    ● [App] Built-in current version update log
    ● [App] Use the local version when the stub cannot be downloaded, now it can be used completely offline
    ● [App] Switch to the modern time API of Java 8
    ● [DenyList] handle suspicious props
    ● [App] Update SafetyNet extension, update snet.jar version to 18
    ● [General] Add an obsolete cgroup v2 path
    ● [Sepolicy] Add execmem to allow zygote and system_server Hook
    ● [MagiskSU] If necessary, fall back to /dev/pts
    ● [Zygisk] Fix Circumstances that may not take effect
    ● [Busybox] Cancel optimization based on undefined behavior
    ● [General] No longer automatically unlock the device block
    ● [Zygisk] From the current situation, there is no crash report to prove zygisk and riru
    Incompatible, temporarily cancel the restriction, observe the situation

    Upstream update log
    From 23.0 to cb4361b7


    ● [General] supports pure 64-bit devices
    ● [General] Support Android 12 emulator
    ● [Zygisk] Code Injection Framework
    ● [General] Remove MagiskHide
    ● [General] Support special simulator loading module
    ● [MagiskBoot] Support zImage format
    ● [MagiskBoot] Add zopfli encoder
    ● [Magisklnit] Support bootconfig
    ● [App] Repair installation function will now check the script under /data/adb/magisk/ is not updated
    ● [MagiskInit] Support some Meizu devices
    ● [MagiskSU] If the kernel supports it, use isolated devpts
    ● [MagiskSU] Fix the pts configuration code, now no extra sepolicy rules
    ●[MagiskBoot] Support v4 boot image header format
    ● [MagiskInit] Support opltus.fstab for some OnePlus and Opal devices
    ● [App] Update modules to be restarted, not allowed to be marked as pending deletion
    ● [App] Delete online warehouse
    ● [App] Add mounting information to the saved log file
    ● [App] Adapt to Android 12 API level
    ● [App] Display the waiting pop-up window when the app is hidden/restored
    ● [Stub] Open source obfuscation function
    ● [Script] Check and display the sepolicy rule folder of the module
    ● [App] Hide screen overlay for pop-up window, Android 12+ is required
    ● [App] Delete the floating bottom bar and change it to the general bottom operation bar
    ● [General] Support special compilation cache
    ● [General] Add rejection list function
    ● [App]Delete DOH
    ● [App]Delete SafetyNet
    ● [App] Allow the log page to be opened when Magisk is not installed
    ● [App] Display Zygisk status, add restart reminder
    ● [Zygisk] Correctly handle child zygote
    ● [Zygisk] Disable conflicting riru modules
    ● [Sepolicy] Fix Android 8 terminal cannot get root

    👍 PW
    11
    diareuse has been MIA for a bit. Pinged him a couple times on the GitHub Issues, but no answer. Hopefully he's okay. 😕

    Mmm. Nothing on his Twitter since February... That's concerning.

    Yeah and in a week it'll be 1 full year since his last commit to Magisk too. 😕

    Good news is diareuse just reached out and is indeed alive and well, just working on multiple paying jobs in real life. 🙂
    11
    Hey all,
    As promised, I wrote up a step-by-step tutorial for the Pixel 5a (though it applies to about all the Pixels, much of it I used on my Pixel 2 over the past 4+ years):


    I know it's a book, but I wanted to make sure I put it in everyday language and tried to make it so even a first timer could go through it and feel confident moving forward and getting root, passing SafetyNet, and update with system updates in the future with confidence.

    Anyhow, it's my attempt to give something back to the community I've gained so much from and leaned on so many times for help. If it helps even one person I'll be happy.

    Thanks again to the entire community, and particularly the folks who have been here helping tirelessly and without reserve to get everyone up and going. You all know who you are and I gave proper name attribution in the tutorial thread. I'm exhausted, so I'm gonna go grab some dinner, that took hours to write! hahahahaah!!

    Be well everyone, SO happy my P5a is fully functioning, you folks are just amazing.

    hfam
    10
    cb4361b7-alpha report:
    w/ RN8T, Stock MIUI, Android 10

    Two reboots needed initially.

    Zygisk & Riru w/ Universal SafetyNet Fix 2.1.1, LSPosed, Un-Share all working fine.

    SafetyNet passing w/ SafetyNet Google Play Services process denied.

    ViPER4Android FX Neon driver status normal.

    With Zygisk enabled Riru-MomoHider causes instability / system crashes even when only app_zygote_magic hiding is configured. 😕

    Great progress! 👍 PW
    Some have been waiting..
    Some have been using vvb2060's alpha builds..

    I have been sneaking a peak by running personal builds from John's master branch. :sneaky:
    Magisk - GitHub - Building and Development - Link

    A few days ago (23.Sep.2021), I was surprised when my OnePlus 6T passed SafetyNet. o_O
    It has been about three or four weeks since it passed SafetyNet.

    Problems I have run into..
    Every now and then, something misfires on boot and Magisk is not active (Installed N/A).
    Normally a reboot is all that is needed, occasionally I have to re-install magisk.

    I ran into an old issue on my 6T (clean install) installing Magisk.
    I had to flash a magisk patched image to both the active and inactive boot slot.
    Need to test again with another clean install.​

    Currently I have a few devices running these (sneak peak) build(s) and passing SafetyNet.

    OnePlus 5T
    Older device, does not have the hardware for hardware attestation.
    • Stock OnePlus OS 10.0.1 (SDK29)
    • Magisk (snapshot build)
    • MagiskHidePropsConf (Magisk Module)
      • Enable Zygisk
      • Enable DenyList
      • add com.google.android.gms.unstable to the DenyList.
        Magisk is in /sbin so only needed to Deny .unstable
      • Enable the MagiskHide props. option in the MagiskHidePropsConf module.
    Reboot in between steps as needed.

    OnePlus 6T
    • Stock OnePlus OS 11.0.0 (SDK30)
    • Magisk (snapshot build)
    • Universal SafetyNet Fix (Magisk Module)
      • Enable Zygisk
      • Enable DenyList
      • add com.google.android.gms.unstable to the DenyList.
      • add com.google.android.gms to the DenyList.
    Reboot in between steps as needed.

    Pixel 3a
    Custom rom that passes SafetyNet on it own.
    Installing Magisk breaks SafetyNet.

    • ABC Rom 11 (SDK30)
    • Magisk (snapshot build)
      • Enable Zygisk
      • Enable DenyList
      • add com.google.android.gms.unstable to the DenyList.
      • add com.google.android.gms to the DenyList.
    Reboot in between steps as needed.

    Earlier today, I setup an update channel so I could test a few more things.
    • Install update from online.
    • Repack (Hide/Restore) the Magisk app.
    All worked. :)
    Note:
    I will have to wait until the next commit(s) to see if I can update while the Magisk app is hidden. 🙃

    ---

    So far The next step of growth and development of Magisk is looking great. :)

    I am excited and eagerly waiting for the next canary build for proper testing. :D

    Cheers all. :cowboy:

    PS.
    Some screenshots from my 6T. ;)


    Edit (5.Oct.2021):
    Please see my follow up post.
    Post 48,294 - Link
    9
    Completely factual post, must be impersonal machine, just facts. Must not smile, must not
    emote.
    Come on mate... That's not what it's about. It's the page after page of off-topic social media/Telegram style posting, that clutters the thread so much that discussions about actual Magisk stuff gets even harder to find (in this impossible to search mammoth of a thread), that is the problem.

    I'll keep an eye on things (since I pretty much live in the Magisk forum anyway) and let you guys know if it starts getting out of hand.

    Nice try at satire though... It baited me hook line and sinker. :ROFLMAO:
  • 1067
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p