• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

nickster_uk

Senior Member
Apr 6, 2016
87
9
www.nick-thompson.co.uk
The point is that two (or more) Apps / Managers conflict.

Please locate and remove any renamed Magisk App from device settings, Apps, App info (or equivalent). If you forgot names you may have chosen, go through the whole list... likely it's default choice, 'Settings'!

Nb. Magisk general settings (hidelist, Superuser etc) & modules survive as they are stored in /data/adb instead of in app data.

If that doesn't fix conflict (App says 'Installed N/A' etc), you may need to uninstall / reinstall unhidden Magisk App also.

While updating (App) with App hidden, especially between consecutive builds, is supposed to work (coming from old builds to post 22.0 is an exception), in practice the new App has failed to replace the old one some 50% of the time when not first un-hidden. It is therefore a good practice to 'Restore the Magisk app' before updating. 👍 PW
Thanks pndwal 👍

I didn't realise it would be as simple as removing the renamed Magisk. I did that and installed the version of MM that I originally flashed with. It detected Magisk, root was still working but I still wasn't able to access Magisk settings and no su prompts were being generated for any new root apps. I then tried a newer version which I had stored on my device and everything is now working perfectly.

Not gonna update Magisk as I'm still going to flash with 11 over the next few days but pleased it's now working as it should.

Appreciate the help.
 
  • Like
Reactions: duttyend and pndwal

nickster_uk

Senior Member
Apr 6, 2016
87
9
www.nick-thompson.co.uk
On a side note, TiBu is extremely outdated and most of the time backups will not restore properly. If you do want to make a backup so that you can clean flash android 11 then I suggest using Migrate app instead.

Thanks Philnicolls89 👍

I didn't realise TiBu was that outdated, but you're right.

It used to be my #1 root app!

Appreciate the tip on Migrate. It looks very good tbh and I've just taken a full backup with it which I will flash with 11.
 
  • Like
Reactions: duttyend and pndwal

ipdev

Recognized Contributor
Feb 14, 2016
1,554
1
2,003
Google Nexus 10
Nexus 7 (2013)
Hi all. :)

Just a quick note for those using newer (test/unofficial) builds that have the online Module Repo removed.

Magisk-Modules-Repo - GitHub - Link
Magisk-Modules-Repo - Repositories - GitHub - Link

If you keep an eye on the repo, you will see when the developer(s) push an update.
Most of the modules have links to support threads and/or another spot that you can download the updated module.
Didgeridoohan uses the GitHub releases option for MHPC. 🙃

If no other option is available, you can clone or download the specific module repo and then zip it into a new Magisk module zip file. ;)

---

I Hope the option of a custom module repo is not too far down the list. ;)
Bye, Magisk-Module-Repo
I wanted to do this for a long time, as I do not have the mental capacity and interest to moderate and curate what modules are allowed on the official repo. If I accept low quality modules, people complain; if I remove some modules, people also complain. So I made the decision to remove Magisk-Module-Repo from the Magisk app. The administration and maintenance of the GitHub organization will be transferred to trusted community members (candidates not final yet). Developers can still easily install modules using the magisk —-install-module ZIP command in its own apps; users can install modules by selecting zip files in the Magisk app.

I do want to eventually enable users to set its own online Magisk module sources which the Magisk app can handle module downloading / installing / upgrading, but this isn’t high up on the list of things I want to do in the near future.
State of Magisk: 2021 - WebSite - medium.com - Link


I have been a little curious since I mentioned it in a prior post that Magisk was once on PlayStore.
If I remember correctly, this was the main reason Magisk was booted from PlayStore. :unsure:

Now that the module repo is removed, does Magisk now fit Google's criteria for PlayStore?

Cheers all. :cowboy:
 

J.Michael

Recognized Contributor
Jan 20, 2018
879
742
Samsung Galaxy Tab A series
True... Also proof of concept for custom repos supporting dev information and update flagging in upcoming TJW builds w/ official repo gone. 😛


Interestingly I did something very similar but it didn't work...

I backed up Alpha /data/adb directory, did complete uninstall, set up and played with TheHitMan Custom Magisk, restore whole (Alpha) /data/adb directory before installing Alpha App and Alpha patched image, BUT got bootloop on reboot! ☹️

Had to boot TWRP and remove whole /data/adb directory before Magisk would stick / boot. - Can you put a finger on the reason backup / restore db only might work better? Any idea what may be causing conflict? Ta. PW
Did you try reinstalling Alpha *before* restoring /data/adb from earlier use of Alpha?
 

Philnicolls89

Senior Member
Jun 28, 2019
657
289
32
A.C.T
Samsung Galaxy S10+
Has anyone from Australia managed to get the 'foxtel go' app to work? It has been well and truly kicking my butt with detecting root!
I can open and login but as soon as I try to stream or watch anything it detects that I'm rooted.
I've tried basically every method or piece of advice on this thread and it's the only app on my phone that I can't get to work, not even my bank apps or gpay have given me this much trouble.
I never used to use it that much anyway so it's not to important, but I've gotten to the point where it's now about principle lol!
 

pndwal

Senior Member
Has anyone from Australia managed to get the 'foxtel go' app to work? It has been well and truly kicking my butt with detecting root!
I can open and login but as soon as I try to stream or watch anything it detects that I'm rooted.
I've tried basically every method or piece of advice on this thread and it's the only app on my phone that I can't get to work, not even my bank apps or gpay have given me this much trouble.
I never used to use it that much anyway so it's not to important, but I've gotten to the point where it's now about principle lol!
I'm assuming you
- have 'Device is certified' PlayProtect status in PlayStore settings.
- hid Magisk App in App settings.
- hid (tv) app from root in MagiskHide list.
- wiped (tv) app's data, set up & tried again AFTER all above.
- read MagiskHide wiki info:
https://www.didgeridoohan.com/magisk/MagiskHide

I don't use Foxtel etc, but I am aware that TV apps like European SkyGo have detected isolated process(es) for some time, and other TV apps are following suit.

If Foxtel is doing this it is likely detecting the Digital Rights Management related VGDRM Helper service isolated process specifically.

Solutions:

1) There are a number of current efforts to hide isolated processes. I recommend trying this by canyie:
- Riru - MomoHider module (aka IsolatedMagiskHider)

You can also try:
- riru-unshare module (Enhanced mode for Magisk Hide by vvb2060)

To check detection, vvb2060 provides:
- Momo Detection app; can check verbose log too
- Magisk Detector app

Links for these solutions and more comprehensive information here:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85300227
(Check last link, 'my setup', if trying MomoHider.)

2) You could try a more specific isolated process solution that simply blocks problem services, working for a number of TV apps if it uses VGDRM Helper service (or similar) Isolated process:

- Download AppManager
https://github.com/MuntashirAkon/AppManager
- Open and check Services tab for your app, and block the VGDRM Helper service (click on the crossed circle icon) and click 'apply rules' in top (3 dot) menu.
- Thanks to @Longhorn87 for this solution! 👍
https://forum.xda-developers.com/t/skygo-app-detected-root.4128933/post-84688731

Nb. There may be other useful tips in that thread for detection issues w/ TV / streaming apps etc.

3) You may also have a Widevine certification issue.

Use DRM Info app from PlayStore to check if Widevine CDM security is 'L1' (HDCP level 2.3?) on your device. If so, all should be good here.
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85232477

Many tv / streaming apps work with limited functionality / lower video resolution if limited to 'L3' but some may require L1 to work at all.

If not on L1 you may need to search for a solution to restore this specific to your device. It seems some devices can be restored by flashing Vendor or other, but w/ other devices it may prove impossible to regain L1 once widevine is tripped even w/ bootloader lock, and some may not retain L1 at all (unsure about this) once unlocked.

Hope something here works for you. 🤠 PW
 
Last edited:

pndwal

Senior Member
Did you try reinstalling Alpha *before* restoring /data/adb from earlier use of Alpha?
No.

My thinking was that that restoring Alpha /data/adb first should remove any conflicting Magisk setup data prior to Alpha setup allowing it to succeed...

I guess after bootloop / cleanup / fresh Alpha flash I could have tried pasting Alpha /data/adb back again, but I didn't... 😆 PW
 
  • Like
Reactions: J.Michael

darkjake

Member
Jan 24, 2014
33
6
Hey guys,

Just having a big bloody problem installing magisk on LOS 18.1 on my Oneplus 8 pro.
Whenever I do the device will get hot, reception will be gone, system ui will keep crashing, device will operate on fullbright then eventually after about 2-5 mins qualcomm crashdumps to mdm_force_reset.
And even with all that happening Magisk still doesn't appear to have been installed according to MagiskManager :D



I have tried:

Factory reset
Magisk canary
patching boot image
reflashing rom
flashing via the (wip) twrp
flashing via sideload

All resulting in the same situation.
I have attached a full logcat dump below, device will continue to work properly with stock boot image and with stock or non stock kernal. This works on OOS just not LOS. During installation no errors occure for magisk so this has me stumped.
 

darkjake

Member
Jan 24, 2014
33
6
Hey guys,

Just having a big bloody problem installing magisk on LOS 18.1 on my Oneplus 8 pro.
Whenever I do the device will get hot, reception will be gone, system ui will keep crashing, device will operate on fullbright then eventually after about 2-5 mins qualcomm crashdumps to mdm_force_reset.
And even with all that happening Magisk still doesn't appear to have been installed according to MagiskManager :D



I have tried:

Factory reset
Magisk canary
patching boot image
reflashing rom
flashing via the (wip) twrp
flashing via sideload

All resulting in the same situation.
I have attached a full logcat dump below, device will continue to work properly with stock boot image and with stock or non stock kernal. This works on OOS just not LOS. During installation no errors occure for magisk so this has me stumped.

logcat : https://drive.google.com/file/d/163yX9hv7KgQU56N9DgeOC0Sdu6qK9SqX/view?usp=sharing
 

ipdev

Recognized Contributor
Feb 14, 2016
1,554
1
2,003
Google Nexus 10
Nexus 7 (2013)
Hey guys,

Just having a big bloody problem installing magisk on LOS 18.1 on my Oneplus 8 pro.
Whenever I do the device will get hot, reception will be gone, system ui will keep crashing, device will operate on fullbright then eventually after about 2-5 mins qualcomm crashdumps to mdm_force_reset.
And even with all that happening Magisk still doesn't appear to have been installed according to MagiskManager :D



I have tried:

Factory reset
Magisk canary
patching boot image
reflashing rom
flashing via the (wip) twrp
flashing via sideload

All resulting in the same situation.
I have attached a full logcat dump below, device will continue to work properly with stock boot image and with stock or non stock kernal. This works on OOS just not LOS. During installation no errors occure for magisk so this has me stumped.
I am surprised you can even open the Magisk app. 🙃
That is one ugly logcat. :sick:
I almost want to see the matching kernel log. :giggle:


I see it is microG lineage build, not sure if that is what is causing the problem.
You might want to offer that logcat to the rom developer. ;)
They might be able to figure out if it is related to the microG implementation.
Why did Magisk destroy their build. :oops:


Would you be willing to do a clean flash using the regular lineage build and test Magisk again?

[ROM][OFFICIAL][instantnoodlep][11] LineageOS 18.1 - xdaThread - Link
LineageOS Downloads - WebSite - OnePlus 8 Pro - Link

If Magisk works with the regular lineage build, you could try a clean flash and include microG.

[APP] microG GmsCore - lightweight free software clone of Google Play Services - xdaThread - Link
microg - GmsCore - GitHub - Link
microg - GmsCore - Releases - GitHub - Link

Then try Magisk again.

Note:
I am not that familiar with microG and not sure what the advatage of baking it into the rom gives.
I know some devices need patches to support microG.

I am not sure if microG works with the official lineageOS for OnePlus 8 Pro.


Cheers. :cowboy:
 
Last edited:

pndwal

Senior Member
Hey guys,

Just having a big bloody problem installing magisk on LOS 18.1 on my Oneplus 8 pro.
Whenever I do the device will get hot, reception will be gone, system ui will keep crashing, device will operate on fullbright then eventually after about 2-5 mins qualcomm crashdumps to mdm_force_reset.
And even with all that happening Magisk still doesn't appear to have been installed according to MagiskManager :D

I have tried:

Factory reset
Magisk canary
patching boot image
reflashing rom
flashing via the (wip) twrp
flashing via sideload

All resulting in the same situation.
I have attached a full logcat dump below, device will continue to work properly with stock boot image and with stock or non stock kernal. This works on OOS just not LOS. During installation no errors occure for magisk so this has me stumped.
Nb. There are a number of open issues for LOS 18.1.

Here's one w/ a number of OnePlus users commenting:
https://github.com/topjohnwu/Magisk/issues/4213
- Many are getting bootloops here, but one user w/ Fairphone 3 reports similar stability / forced reboot problems:
https://github.com/topjohnwu/Magisk/issues/4213#issuecomment-846555592
- OnePlus 5T user fixed issue after determining his was caused by PlayStore issue by using NikGapps:
https://github.com/topjohnwu/Magisk/issues/4213#issuecomment-842971119
He mentions solution from here:
https://gitlab.com/LineageOS/issues/android/-/issues/3460

Hope it helps, PW
 
  • Like
Reactions: duttyend and ipdev

ipdev

Recognized Contributor
Feb 14, 2016
1,554
1
2,003
Google Nexus 10
Nexus 7 (2013)

Philnicolls89

Senior Member
Jun 28, 2019
657
289
32
A.C.T
Samsung Galaxy S10+
I'm assuming you
- have 'Device is certified' PlayProtect status in PlayStore settings.
- hid Magisk App in App settings.
- hid (tv) app from root in MagiskHide list.
- wiped (tv) app's data, set up & tried again AFTER all above.
- read MagiskHide wiki info:
https://www.didgeridoohan.com/magisk/MagiskHide
Yes I have previously tried all of the above mentioned methods of hiding root detection.
Solutions:
1) There are a number of current efforts to hide isolated processes. I recommend trying this by canyie:
- Riru - MomoHider module (aka IsolatedMagiskHider)

You can also try:
- riru-unshare module (Enhanced mode for Magisk Hide by vvb2060)

To check detection, vvb2060 provides:
- Momo Detection app; can check verbose log too
- Magisk Detector app

Links for these solutions and more comprehensive information here:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85300227
(Check last link, 'my setup', if trying MomoHider.)
I have tried both momohider module and riru-unshare module both with no success, I've attached the results from magisk Detector and momo app (momo still detects traces of root eg, magisk, twrp, bootloader etc, so the app I'm trying to use may be doing the same thing).
2) You could try a more specific isolated process solution that simply blocks problem services, working for a number of TV apps if it uses VGDRM Helper service (or similar) Isolated process:

- Download AppManager
https://github.com/MuntashirAkon/AppManager
- Open and check Services tab for your app, and block the VGDRM Helper service (click on the crossed circle icon) and click 'apply rules' in top (3 dot) menu.
- Thanks to @Longhorn87 for this solution! 👍
https://forum.xda-developers.com/t/skygo-app-detected-root.4128933/post-84688731
The app does not use VGDRM Helper service as seen in screenshot.
3) You may also have a Widevine certification issue.

Use DRM Info app from PlayStore to check if Widevine CDM security is 'L1' (HDCP level 2.3?) on your device. If so, all should be good here.
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85232477

Many tv / streaming apps work with limited functionality / lower video resolution if limited to 'L3' but some may require L1 to work at all.

If not on L1 you may need to search for a solution to restore this specific to your device. It seems some devices can be restored by flashing Vendor or other, but w/ other devices it may prove impossible to regain L1 once widevine is tripped even w/ bootloader lock, and some may not retain L1 at all (unsure about this) once unlocked.

Hope something here works for you. 🤠 PW
It does not seem to be a widevine issue either as my security level is L1.
Unfortunately I think I'm back to square 1 with this, you have definitely given me some tips and things to think about though in my ongoing quest to get a streaming app to work that I barely use anyway😅.
Thank your the time to provide this information for me, it's been an interesting and enlightening read at least. 😁
 

Attachments

  • Screenshot_20211014-174734_Momo.jpg
    Screenshot_20211014-174734_Momo.jpg
    466.2 KB · Views: 40
  • Screenshot_20211014-174718_Magisk Detector.jpg
    Screenshot_20211014-174718_Magisk Detector.jpg
    796.8 KB · Views: 40
  • Screenshot_20211014-121342_App Manager.jpg
    Screenshot_20211014-121342_App Manager.jpg
    424.6 KB · Views: 39
  • Screenshot_20211014-094351_DRM Info.jpg
    Screenshot_20211014-094351_DRM Info.jpg
    317 KB · Views: 40
  • Like
Reactions: pndwal

73sydney

Senior Member
Jul 21, 2018
1,916
1,678
Sydney
Google Pixel 2 XL
Yes I have previously tried all of the above mentioned methods of hiding root detection.

I have tried both momohider module and riru-unshare module both with no success, I've attached the results from magisk Detector and momo app (momo still detects traces of root eg, magisk, twrp, bootloader etc, so the app I'm trying to use may be doing the same thing).

The app does not use VGDRM Helper service as seen in screenshot.

It does not seem to be a widevine issue either as my security level is L1.
Unfortunately I think I'm back to square 1 with this, you have definitely given me some tips and things to think about though in my ongoing quest to get a streaming app to work that I barely use anyway😅.
Thank your the time to provide this information for me, it's been an interesting and enlightening read at least. 😁

Did you use Momohider with any options enabled? (empty files under /data/adb/modules/riru_momohider/config)

see https://github.com/canyie/Riru-MomoHider under "Background"

Have you tried looking for and removing the TWRP folder on internal memory? (making sure to copy any backups off device if present first)

fwiw, Momo detects most of the same stuff for me, although all my root detector hungry apps still dont find root - always been this way...i dont have 100% faith in Momo as a result

your Magisk Detector results look correct, same as mine (i use Riru-Momohider)
 
Last edited:

Philnicolls89

Senior Member
Jun 28, 2019
657
289
32
A.C.T
Samsung Galaxy S10+
Did you use Momohider with any options enabled? (empty files under /data/adb/modules/riru_momohider/config)

see https://github.com/canyie/Riru-MomoHider under "Background"

Have you tried looking for and removing the TWRP folder on internal memory? (making sure to copy any backups off device if present first)

fwiw, Momo detects most of the same stuff for me, although all my root detector hungry apps still dont find root - always been this way...i dont have 100% faith in Momo as a result

your Magisk Detector results look correct, same as mine (i use Riru-Momohider)
Yes, I have all 4 options enabled in momohider (creating a blank file and placing it in /data/adb/modules/riru_momohider/config)
The only thing I can think of that I haven't tried is what you suggested, which is to rename or remove all files with magisk or TWRP in the name.
That seems like a lot of trouble for one rouge app that refuses to work!! Seeing as I didn't use it often when it was working.
I agree with not being able to entirely trust momos results either, as all of my root consious apps still work fine (of course with this one exception!)
 
  • Like
Reactions: 73sydney

zgfg

Senior Member
Oct 10, 2016
5,891
3,364
What is the current status of development of Zygisk ?
Is there an official repo hosting it ?
TJW works on Zygisk (did a lot of commits so far) on his Magisk Github project but he has not released a new Magisk (Canary or so) yet

However, there are other developers who branched his code and already deployed new Magisk builds with Zygisk - it's been discussed here a lot, particularly there are lot of users here using Magisk Alpha (from vvb2060).
I'm currently on the Magisk from TheHitMan7.
Both have Zygisk (based on commits from TJW)

And you don't nneed a module for Zygisk, it's in the new Magisk (core)
 
Last edited:

Top Liked Posts

  • 5
    New Google Pixel 3 XL user. Upgraded to A12 via OTA. Rooted via ROOT GUIDE steps pinned in 3 XL forum and without deleting data. Had A12 running fine with 23000, even banking app and Google Pay. Testing Magisk Canary build from today. Rebooted and everything seems to run as expected. Toggled on Zygisk, rebooted, and again everything seems to be running smoothly - including banking app and Google Pay.
    3
    The safetynet passed even without denylisted the google play services (gms).
    2
    To parrot someone 'Let me get this out of the way: since I have a full time job now, I don't have much time for Magisk; I need prioritization' ...

    I had meant to run / check it by now but priorities intervened / objected...

    Now that is keeping MHide alive, +Riru!

    This one might be more elegant than TheHitMans Custom M?

    Should be able to enable all MomoHider hide options again w/ that.

    Nb. setns is better / faster. Re isolated (only): "This feature is deprecated because it will unmount Magisk modified files for every isolated processes, and the unmounting time cannot be well controlled, which may cause some modules to not work." 👍 PW

    Edit:
    Many will like choice of traditional hide & Riru or Zygisk in up-to-date Magisk...

    Still haven't looked, but might do the translation thing for Alpha-with-deny/hide choice Changelog soon.

    Tempted Nigel? ... Just teasing ya. 🙄 🤪

    Nigel is tempted

    At some point (hopefully soonish) one fork will come out ahead and perhaps the other dev can join in and work together
    2
    Try USNF 1.2 or 1.1.1, as they were the last versions that don't require Riru.
    Thank you, that worked. I'm passing SafetyNet now
    2
    You cant install Riru when Zygisk is enabled, because both edit the same things. Instead of using Universal SafetyNet fix with Riru Download Version 1.2 of USNF (which doesnt need Riru).
    In the latest alpha 43d11d87, you don't need zygisk to be enabled just enable magisk hide then install any riru based module as you like.
    Zygisk still experimental and it can't be used together with riru at all.
  • 11
    diareuse has been MIA for a bit. Pinged him a couple times on the GitHub Issues, but no answer. Hopefully he's okay. 😕

    Mmm. Nothing on his Twitter since February... That's concerning.

    Yeah and in a week it'll be 1 full year since his last commit to Magisk too. 😕

    Good news is diareuse just reached out and is indeed alive and well, just working on multiple paying jobs in real life. 🙂
    9
    Latest Alpha Magisk Chinese Translated:
    (For mavericks only! 😬)

    alpha update journal Magisk (cb4361b7-alpha-2)

    • [General] Based on cb4361b7, the content that has been merged into the upstream will not be listed anymore
    • [App] Correctly process any data from magiskd
    • [App] Support SharedUserld
    • [App] Delete the backup file after adding a thick boot mirror
    • [App] Built-in current version update log
    • [App] Use the local version when you cannot download the stub, now it can be used completely offline
    • [App] Switch to Java 8 modern time API
    • [DenyList] Dealing with suspicious props
    • [App] Expand and update SafetyNet, update the snet.jar version to 18
    • [General] Add an outdated cgroup v2 path
    • [Sepolicy] Add execmem to allow hook in zygote and system_server
    • [MagiskSU] If necessary, fall back to /dev/pts
    • [Zygisk] Repair may not take effect
    • [Busybox] Cancel optimization based on undefined behavior
    • [General] No longer automatically unlock the device block
    • [Zygisk] There is no report to prove that zygisk is incompatible with riru, remove the restriction
    • [Resetprop] Completely erase the old content when modifying/deleting
    • [General] Fix the race condition of thread pool
    • [Magisklnit] Do not intervene when booting to DSU

    How to install ?

    To install and use Magisk through the Magisk application, the general relationship should be completed directly in the application. For special circumstances such as the first installation, the image should be patched and then flashed in with the fastboot/odin tool. Customizing Recovery is not a supported method.

    You update the journal
    From 23.0 to cb4361b7

    • [General] Support pure 64-bit devices
    • [Generall supports Android 12 emulator
    • [Zygisk] Code injection framework
    • [General] Remove MagiskHide
    • [General] Support Simulator to add modules
    • [MagiskBoot] Support zimage format
    • [MagiskBoot] Add zopfhi encoder
    • [MagiskInit] Support bootconfig
    • [App] The repair installation function will now check if the script under /data/adb/magisk/ has not been updated
    • [Magisklnit] Support some Meizu devices
    • [MagiskSU] If the kernel supports it, use isolated devpts
    • [MagiskSU] Fix the pts configuration code, now no additional sepolicy rules are needed
    • [MagiskBoot] Support v4 boot image header format
    • [Magisklnit] Support oplus.fstab for some OnePlus and Opal devices
    • [App] Restart and update modules, not allowed to be marked as pending deletion
    • [App] Delete online warehouses
    • [App] Add mounting information to the saved log file
    • [App] Suitable for Android 12 API level
    • [App] Display the waiting pop-up window that is running when hide/restore the original app
    • [Stub] Open source obfuscation function
    • [Script] Check and display the sepolicy rule folder of the module.
    • [App] When the window pops up, hide the screen helmet and add layer. Android 12+ is required.
    • [App] Delete the floating bottom bar and change it to the general bottom operation bar.
    • [General] Support compilation cache
    • [General] Add rejection list function
    • [App] Delete DoH
    • [App] Delete SafetyNet
    • [App] Allow the log page to be opened when Magisk is not installed
    • [App] Display the status of Zygisk, add a reminder that restart is effective
    • [Zygisk] Correctly handle the child zygote
    • [Zygisk] Disabled riru module
    • [Sepolicy] Fix Android 8 terminal cannot get root

    👍 Marvin.
    9
    Hi all. :)

    Just a quick note for those using newer (test/unofficial) builds that have the online Module Repo removed.

    Magisk-Modules-Repo - GitHub - Link
    Magisk-Modules-Repo - Repositories - GitHub - Link

    If you keep an eye on the repo, you will see when the developer(s) push an update.
    Most of the modules have links to support threads and/or another spot that you can download the updated module.
    Didgeridoohan uses the GitHub releases option for MHPC. 🙃

    If no other option is available, you can clone or download the specific module repo and then zip it into a new Magisk module zip file. ;)

    ---

    I Hope the option of a custom module repo is not too far down the list. ;)
    Bye, Magisk-Module-Repo
    I wanted to do this for a long time, as I do not have the mental capacity and interest to moderate and curate what modules are allowed on the official repo. If I accept low quality modules, people complain; if I remove some modules, people also complain. So I made the decision to remove Magisk-Module-Repo from the Magisk app. The administration and maintenance of the GitHub organization will be transferred to trusted community members (candidates not final yet). Developers can still easily install modules using the magisk —-install-module ZIP command in its own apps; users can install modules by selecting zip files in the Magisk app.

    I do want to eventually enable users to set its own online Magisk module sources which the Magisk app can handle module downloading / installing / upgrading, but this isn’t high up on the list of things I want to do in the near future.
    State of Magisk: 2021 - WebSite - medium.com - Link


    I have been a little curious since I mentioned it in a prior post that Magisk was once on PlayStore.
    If I remember correctly, this was the main reason Magisk was booted from PlayStore. :unsure:

    Now that the module repo is removed, does Magisk now fit Google's criteria for PlayStore?

    Cheers all. :cowboy:
    8
    Guess John has given this by now:
    John Wu, Sep 22

    Fellow Googlers: I'll be giving an internal tech talk about Android modding on Sep. 30 @ 9 AM PT. Ping me at Google chat if you/your team are interested and not already invited!
    He did say to 'non Googlers':
    John Wu, Sep 30

    Now think again about all those people saying Magisk is all about hiding root 🤦‍♂️

    Sneak peek of the slides for tomorrow's tech talk. Rooting Android is sooooo easy 🤷‍♂️
    newmagisk.jpeg


    ... Just thought y'all might find John's visual aid for understanding new Magisk helpful!

    Of course, this is on his Twitter... Sorry I can't give a link...

    FWIW, a Mod has told me:
    Any link to social media is governed by the policy HERE. As per the policy, only developers are allowed to post social media links in the OPs of their development threads. Even they are not allowed to post such links on their subsequent posts in the thread...

    Github posts and links are perfectly ok since the policy mentioned above applies to social media and similar places only.

    As for quoting content from social media, it is allowed provided it is relevant to the topic of the thread and no link is given.

    Moderators usually act on reports and also on what they come across in their daily journey through the forums. It is impossible to monitor every single post on a forum of 11 million+ registered users. But when something is brought to their notice, they act.
    😬 PW
    8
    All that Knox stuff is why i departed Samsung phones after my Note 4 and went Pixel, and will never go back

    If you spend that much money on a device, you should be allowed to do what you want with it, without all that nonsense...
  • 1068
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p