Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
I'm not familiar with Pixel and A12, but did you see:
No, I hadn't.

I'm not across all the issues w/ Android 12 either. I was really just moving the OT (non-issue related queries re. Magisk's future) in that issue thread to this General Discussion forum...

But I see you've brought this information to the attention of early A12/Magisk guinea pigs in same issue. 😁 Looks like it may be quite relavent too.

Hope this helps them / devs addressing that issue. PW
 

V0latyle

Forum Moderator
Staff member
Folks:

Please realize that the "failure to load/verify boot images" message is not due to a Magisk issue.

Android 12 introduces Verified Boot on some devices, such as the Pixel 5, which will block a modified boot image from loading.

Two new Verified Bootfeatures implemented in Android 12 will interfere with attempts to root.

Dm-verity (device-mapper-verity) is a method by which an image on block devices (the underlying storage layer of the file system) can be checked to determine if it matches an expected configuration, using a cryptographic hash tree. If the hash doesn't match, dm-verity prevents the stored code from loading.

Vbmeta verification is the other half of this - it provides a cryptographically signed reference hash which is used to verify the integrity of /boot, /system, and /vendor partitions. The vbmeta image is only used to verify /boot, while vbmeta-system is used to verify /system.

This was implemented to prevent persistent rootkits by means of a hardware level security check, to prevent "potentially harmful applications" such as Magisk from evading detection, as such applications residing within the kernel will have higher privileges than the detection applications.

What this means is that with these two enabled, a modified boot image will cause a verification error when flashed to the device, preventing boot. Interestingly, this check is not performed against "live" boot images loaded via ADB, so with dm-verity and vbmeta verification enabled, a modified image can be booted as long as the image in /boot is intact.

So, if you get stuck at bootloader with the failure message, this is because boot verification is not disabled.

You can find instructions on how to disable it in my thread here (this guide is for the Pixel 5; the instructions may be similar for other devices but it is YOUR responsibility to determine the correct procedure)

As far as failing safetynet, I used the Universal Safetynet Fix on 12 Beta 5 with no issues. I haven't updated to 12 Final yet so YMMV.
 

pndwal

Senior Member
If I understand you correctly, you got it passing without the use of MHPC...

But you can also keep it enabled - if reset and not used, it's dormant and not affecting...
I stand to be corrected here, but I think MHPC now changes 'sensitive' props that MagiskHide used to handle to 'safe' (undetected) values by default (even if MHPC is not configured).

This may do no harm of course, but it should be understood that MHPC is no longer 'dormant' when reset or left unconfigured.

Also, as USNF now apparently does this also, this function may be duplicated / redundant, although I imagine this wouldn't cause any real conflict, only increase load time marginally. PW
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
Good old Magisk alpha 31....bulletproof

I made a GPay purchase for days and even a few hours earlier...then bang, gone...root detected....

Remove and reinstall alpha 31...all is sane again....

Guess im just going to stay here for a while again until the dust settles, cant keep up with (currently) 3 forks of Magisk :)

...Nigel...
...But that version (abfb3bb3-alpha) was already dated... did you ever try later 8276a077-alpha? I haven't had issues yet... PW
 

zgfg

Senior Member
Oct 10, 2016
10,735
9,323
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11
I stand to be corrected here, but I think MHPC now changes 'sensitive' props that MagiskHide used to handle to 'safe' (undetected) values by default (even if MHPC is not configured).

This may do no harm of course, but it should be understood that MHPC is no longer 'dormant' when reset or left unconfigured.

Also, as USNF now apparently does this also, this function may be duplicated / redundant, although I imagine this wouldn't cause any real conflict, only increase load time marginally. PW
Didn't know and didn't expect (changes in effect if not activated through the module).
However, my /data/adb/modules/MagiskHidePropsConf/system.prop is empty (besides the header), hence the module makes no props changes through that file for me

Yet, my sensitive props are already ok by Xiaomi.eu ROM and I pass SafetyNet with or without MHPC

Anyway, since I usually experiment (also systemlessly) with changing props directly by manipulating my /data/adb/modules/.../system.prop file, I have now disabled that dormant or not MHPC :)
 
Last edited:

Didgeridoohan

Retired Senior Moderator
May 31, 2012
12,300
1
14,850
Gone
Google Nexus 4
Nexus 6
I stand to be corrected here, but I think MHPC now changes 'sensitive' props that MagiskHide used to handle to 'safe' (undetected) values by default (even if MHPC is not configured).

This may do no harm of course, but it should be understood that MHPC is no longer 'dormant' when reset or left unconfigured.

Also, as USNF now apparently does this also, this function may be duplicated / redundant, although I imagine this wouldn't cause any real conflict, only increase load time marginally. PW
The sensitive props changing is active by default, yes, but only ever does anything if a prop is set to a sensitive value.
 

pndwal

Senior Member
Didn't know and didn't expect (changes if not activated in the module).
However, my /data/adb/modules/MagiskHidePropsConf/system.prop is empty (besides the header), hence the module makes no props changes through that file for me

Yet, my sensitive props are already ok by Xiaomi.eu ROM and I pass SafetyNet with or without MHPC.
Anyway, since I usually experiment (also systemlessly) with props changes by directly manipulating my /data/adb/modules/.../system.prop file, I have now disabled the dormant or not MHPC :)
So seems no effect where prop already changed, which explains your result.

Ref for active setting of 'trigering' values to 'safe' is here:
https://github.com/Magisk-Modules-R...README.md#setreset-magiskhide-sensitive-props PW
 
  • Like
Reactions: zgfg

pndwal

Senior Member
wasnt dated by much

i tend not to invite the possibility of more of the same, when i can go right back to stable ...im getting too old for much testing these days Marvin
Yup, only one more TJW commit:
https://github.com/topjohnwu/Magisk/commit/fe41df87bb34926cf2d6b448dd5a2878d90d4dc1
fixing this race condition:
https://github.com/topjohnwu/Magisk/pull/4759
Check the best minds on that: reopened, and just closed again...

Clearly some vvb2060 commit(s) too (esp. removing Check SafetyNet).

The fact that vvb2060 pushed fix so quickly should say something. Others reported abfb3bb3-alpha issues gone too.

8276a077-alpha is all good for me ATM... We'll see...

However, I always try to remember 'you can lead a mouse to water, but you cannot make it think'... 😜 ... Perhaps life on the bleeding edge does require too much of that... so just don't talk to me about life... Marvin.
 
  • Like
Reactions: 73sydney

pndwal

Senior Member
This'll be fun:

@MishaalRahman (late of XDA) posted (on twitter) he just got WSA (Windows Subsystem for Android) up and running with Windows 11 (yes, you can sideload APKs!).

Of course, John is now pulling out all stops to 'root' it with Magisk! - Magisk for Windows; what a treat!

There's no ramdisk, but he's located 4 stage init (last 2 are Android 2SI)

He says "I found the init, the kernel binary, and initrd.img. Let's get things cooking baby!"... Go John! 😃 PW
 
Last edited:
  • Like
Reactions: 73sydney

arik100

Senior Member
Apr 6, 2012
238
16
unfortunately search doesn't work properly for me.

i get error installed N/A
poco X3 pro
installed magisk,
patched boot via magisk
flashed patched boot via fastboot and then via magisk.

i have root but i get this "status"
any ideas?
i run arrow os android 12 (arrowos recovery)
 

pndwal

Senior Member
unfortunately search doesn't work properly for me.

i get error installed N/A
poco X3 pro
installed magisk,
patched boot via magisk
flashed patched boot via fastboot and then via magisk.

i have root but i get this "status"
any ideas?
i run arrow os android 12 (arrowos recovery)
Did you have Magisk installed / working on that device previously w/ App hidden? If so, see:
https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85761971

If you didn't update with Magisk App hidden, there are current issues with this symptom, eg:
1) https://github.com/topjohnwu/Magisk/issues/4319
- SU present but not working. Could try this workaround:
https://github.com/topjohnwu/Magisk/issues/4319#issuecomment-851840533

2) https://github.com/topjohnwu/Magisk/issues/4174
- SU working, but this affects devices with Android 6.x, 7.x.

3) FWIW, here's an old one that affected ArrowOS:
https://github.com/topjohnwu/Magisk/issues/4005

I suspect you have hidden app conflict, but there have been very few trials / issues reported w/ Android 12 as yet. 😬 PW
 
Last edited:

pndwal

Senior Member
This'll be fun:

@MishaalRahman (late of XDA) posted (on twitter) he just got WSA (Windows Subsystem for Android) up and running with Windows 11 (yes, you can sideload APKs!).

Of course, John is now pulling out all stops to 'root' it with Magisk! - Magisk for Windows; what a treat!

There's no ramdisk, but he's located 4 stage init (last 2 are Android 2SI)

He says "I found the init, the kernel binary, and initrd.img. Let's get things cooking baby!"... Go John! 😃 PW
LSPosed guys have Windows 'Root' w/ Magisk! ... and Windows Xposed! 😃
Well... Magisk, Riru and LSPosed are now working on WSA!

Brief steps (note this is just a tmp solution)
1. Enable dev mode in win, extract WSA package, disable its signature verification and remove private permissions, and sideload it.
2. Download kernel sources of WSA, write a kernel module to provide su, compile it and relpace the kernel.
3. With su, compile magisk and run its emulator.sh script, then grant su to adb.
4. Compile Riru commenting out codes that restart zygote and install it.
5. Download and install LSPosed.
6. adb reboot userspace.
7. Enjoy :)
LSPosed Telegram group.

😛 PW
 
Last edited:
  • Like
Reactions: onoakino and rodken

pndwal

Senior Member
LSPosed guys have Windows 'Root' w/ Magisk! ... and Windows Xposed! 😃

LSPosed Telegram group.

😛 PW
Drooling? 😄
John Wu, 50m

Yup, we managed to get kernel assisted SU up and running in WSA, which bootstraps Magisk using my emulator scripts, and the rest is business as usual.

(Also by "we", I mean Magisk + Riru + LSPosed folks as we are in close collaboration)

Proper Magisk installation would require some additional research and investigation. But it's always fun to get the screenshots out and have people drool over it, doesn't it 😜

To drool or not to drool... That is the question. 🤪 PW
 
Last edited:

73sydney

Account currently disabled

pndwal

Senior Member
It cant run any Google Services or any apps that reply on them...personally i dont see the point in Android on Windows
Perhaps it's just the drool factor. 😜...

But I used to live in the same town as Sir Edmund Hillary, and what did he do?

Spoiler:
„˙ǝɹǝɥʇ sɐʍ ʇı ǝsnɐɔǝq„ - ¿ʎɥM
¡ƃuıɥʇ ǝɥʇ pǝqɯıןɔ puɐ 'uıɐʇunoɯ ǝɥʇ oʇ ʇuǝʍ ɥʇoq ǝɥ ˙˙˙ ,ʇuıod ǝɥʇ ǝǝs ʇ,uop I, pıɐs ɹǝʌǝu ǝH


I can't really see the point of Magisk here either (except for some modules?), but I'll watch the proceedings for sure ... as long as top Magisk / XPosed / Riru Devs are excited about it, why not? (Some watch cricket!) 😃

What do I know... Perhaps they can add GMS / get GApps going! 🤪

Perhaps Google will even add Windows compatibility if this thing flies! ...

Or perhaps pigs might... 🙃 😁 😐

... Until then, Windows users will at least be instantly able to run a plethora of favourite Android apps on their PC's it seems. - That's gotta be Value Added functionality for many users and a selling point for MS! 🙂 PW

{Mod edit: ISPOILER added to upside-down text - Oswald Boelcke, Moderator}

My Edit: Thanks @Oswald Boelcke - good tip! 😛
 
Last edited:
  • Like
Reactions: rodken and 73sydney

DiamondJohn

Recognized Contributor
Aug 31, 2013
7,374
7,391
Sydney
For devs, virtual android on windows is instrumental, and with easy root is brilliant. There are countless very strong reason for it. Even for non devs, having an environment to test that is not your daily is priceless in itself. Do you honestly think Mircro$oft went down this difficult route solely for bragging rights?
 

arik100

Senior Member
Apr 6, 2012
238
16
Did you have Magisk installed / working on that device previously w/ App hidden? If so, see:
https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85761971

If you didn't update with Magisk App hidden, there are current issues with this symptom, eg:
1) https://github.com/topjohnwu/Magisk/issues/4319
- SU present but not working. Could try this workaround:
https://github.com/topjohnwu/Magisk/issues/4319#issuecomment-851840533

2) https://github.com/topjohnwu/Magisk/issues/4174
- SU working, but this affects devices with Android 6.x, 7.x.

3) FWIW, here's an old one that affected ArrowOS:
https://github.com/topjohnwu/Magisk/issues/4005

I suspect you have hidden app conflict, but there have been very few trials / issues reported w/ Android 12 as yet. 😬 PW
1. what do you mean with app hidden?
2. about other options - i don't see any solution... just mentions, but again, i do have root , just that i get N/A and i can't install modules (which is annoying...)
 

Top Liked Posts

  • There are no posts matching your filters.
  • 5
    I can't access superuser and modules they are both lockedView attachment 6081641
    Your phone isn't rooted! The top section of your screenshot shows Magisk "Installed N/A".
    Installing the Magisk app isn't enough to root your phone.
    5
    I'm now having a problem hiding the TJW Magisk 27002 app ...

    I finally was able to resurrect my old Pixel 5. It's running stock A11 and was running TJW Magisk 26004 with no problem.

    The Magisk manager was showing that the upgrade to 27002 was ready for installation, and so I did the following:

    (1) Unhide Magisk
    (2) Update Magisk (27002 was listed)
    (3) After Magisk manager restarted, I did Direct Update to 27002, including reboot
    (4) Magisk 27002 indeed came up properly after reboot.
    (5) Tried to perform Hide The Magisk App.

    I entered the arbitrary name for hiding, and I clicked "OK". But the hiding never took place.

    I rebooted again, to see if perhaps that's necessary, and I repeated the hiding attempt by adding the same arbitrary name, and I again clicked "OK". But the hiding still didn't take place.

    I searched my device, and there is no app nor shortcut with that arbitrary name. I also tried other, different arbitrary names, but after clicking "OK", the hiding still didn't take place for any name I chose.

    What am I missing?
    Known issue. A fix has been merged. You can use the Debug app, revert back to 27001 or wait until 27003 is released.

    EDIT: Ninja'd 🙃
    4
    Latest canary Update 27002 will not let me hide the Magisk app, get a failed toast, tried opening an issue but need to use the debug version,
    Installed the debug version and it works and hides the magisk app?
    4
    Not sure if the fix has been pushed yet but looking at GitHub it's been sorted
    Not pushed yet... Looks like recent Android Gradle plugin upgrade just didn't build properly... Guess a new build may come once Upgrade AGP is reverted but may not happen till AGP upgrade is redone. 🤪 PW
    4
    I have always have problems with magisk and bug reports think I have even failed with the debug version lol, although its closed I have added that the bug is not present with the debug version
    Just open another with "version code: 27002" somewhere in first post, explain you tested both but issue is with Canary only, not Debug... Supply logs from broken build and wait for further instructions from Devs... Template requires the version code (or bot closes) + logs (or Devs will often close with comment like "no log no fix")...👍 PW

    Edit: Someone opened proper issue following template just now:
    https://github.com/topjohnwu/Magisk/issues/7921

    Looks to me like this commit has issues:

    Always update stub APK when upgrade

    committed5 days ago
  • 1103
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p