• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

zaczatowany

Senior Member
Jun 25, 2010
91
15
Hi guys, i need some help. I update magisk to v23 and everything was ok, but Magisk no more support MagiskHide. So i want to downgrade Magisk and reinstall from previous version by TWRP. Now i have no Magisk, any version i can't install. What i have to do? Trying reinstall BeyondROM v3.7 and now reinstall Magisk, but still no effect. My phone is Samsung S20 Ultra 5G - G988B
 

Qnorsten

Senior Member
Mar 14, 2012
192
86
Hi guys, i need some help. I update magisk to v23 and everything was ok, but Magisk no more support MagiskHide. So i want to downgrade Magisk and reinstall from previous version by TWRP. Now i have no Magisk, any version i can't install. What i have to do? Trying reinstall BeyondROM v3.7 and now reinstall Magisk, but still no effect. My phone is Samsung S20 Ultra 5G - G988B
You have to uninstall from the magisk app, reboot, install old magisk 23 then fastboot flash the patched boot img from that version of magisk.
 

kari kimber

Senior Member
Feb 6, 2005
57
3
Hi guys, i need some help. I update magisk to v23 and everything was ok, but Magisk no more support MagiskHide. So i want to downgrade Magisk and reinstall from previous version by TWRP. Now i have no Magisk, any version i can't install. What i have to do? Trying reinstall BeyondROM v3.7 and now reinstall Magisk, but still no effect. My phone is Samsung S20 Ultra 5G - G988B
cuz magisks developer hired google android security dev and developer fear job loosing (he is right).

magisk new version not support magiskhide and downloading modules the magisk app.

solution;
update magisk (canary channel, warning, not released)
hide magisk
turn on zygisk feature and enforce it deny list (warning, not released)
open configure deny list then apply deny list on google play services (gfs) and playstore (maybe clear the app cache & data)
install riru module
restart phone
install universal safety net fix module
restart the phone again
 

JustLauro

Member
Oct 20, 2021
8
3
cuz magisks developer hired google android security dev and developer fear job loosing (he is right).

magisk new version not support magiskhide and downloading modules the magisk app.

solution;
update magisk (canary channel, warning, not released)
hide magisk
turn on zygisk feature and enforce it deny list (warning, not released)
open configure deny list then apply deny list on google play services (gfs) and playstore (maybe clear the app cache & data)
install riru module
restart phone
install universal safety net fix module
restart the phone again
You cant install Riru when Zygisk is enabled, because both edit the same things. Instead of using Universal SafetyNet fix with Riru Download Version 1.2 of USNF (which doesnt need Riru).
 

Eng.Raman

Senior Member
Apr 13, 2014
409
464
Khanaqin
You cant install Riru when Zygisk is enabled, because both edit the same things. Instead of using Universal SafetyNet fix with Riru Download Version 1.2 of USNF (which doesnt need Riru).
In the latest alpha 43d11d87, you don't need zygisk to be enabled just enable magisk hide then install any riru based module as you like.
Zygisk still experimental and it can't be used together with riru at all.
 

Eng.Raman

Senior Member
Apr 13, 2014
409
464
Khanaqin
The safetynet passed even without denylisted the google play services (gms).
 

Attachments

  • Screenshot_2021-10-26-17-35-48-86_6bda79fd6bc9243b9f5c518a93e63f50.jpg
    Screenshot_2021-10-26-17-35-48-86_6bda79fd6bc9243b9f5c518a93e63f50.jpg
    323.5 KB · Views: 173
  • Screenshot_2021-10-26-17-28-43-06_8ccb6d88996d71a9fa1d96ed310fe2ae.jpg
    Screenshot_2021-10-26-17-28-43-06_8ccb6d88996d71a9fa1d96ed310fe2ae.jpg
    286.5 KB · Views: 169
  • Screenshot_2021-10-26-17-34-28-37_6088c9d1cb2ce8e37f56babcefb6e862.jpg
    Screenshot_2021-10-26-17-34-28-37_6088c9d1cb2ce8e37f56babcefb6e862.jpg
    330.5 KB · Views: 168
  • Screenshot_2021-10-26-17-34-42-19_6088c9d1cb2ce8e37f56babcefb6e862.jpg
    Screenshot_2021-10-26-17-34-42-19_6088c9d1cb2ce8e37f56babcefb6e862.jpg
    382.7 KB · Views: 156
  • Screenshot_2021-10-26-17-34-56-28_6088c9d1cb2ce8e37f56babcefb6e862.jpg
    Screenshot_2021-10-26-17-34-56-28_6088c9d1cb2ce8e37f56babcefb6e862.jpg
    337.5 KB · Views: 148
  • Screenshot_2021-10-26-17-35-34-04_0ecf870e1d5390b9ac21ebc76f00749d.jpg
    Screenshot_2021-10-26-17-35-34-04_0ecf870e1d5390b9ac21ebc76f00749d.jpg
    299.7 KB · Views: 144
  • Screenshot_2021-10-26-17-36-27-70_b7e9024f54bdc0532418cb6e23c85a7c.jpg
    Screenshot_2021-10-26-17-36-27-70_b7e9024f54bdc0532418cb6e23c85a7c.jpg
    194.5 KB · Views: 139
  • Screenshot_2021-10-26-17-36-35-01_b7e9024f54bdc0532418cb6e23c85a7c.jpg
    Screenshot_2021-10-26-17-36-35-01_b7e9024f54bdc0532418cb6e23c85a7c.jpg
    396.7 KB · Views: 133
  • Screenshot_2021-10-26-17-37-46-40_6088c9d1cb2ce8e37f56babcefb6e862.jpg
    Screenshot_2021-10-26-17-37-46-40_6088c9d1cb2ce8e37f56babcefb6e862.jpg
    325.6 KB · Views: 142
  • Screenshot_2021-10-26-17-43-55-47_313461a7842323087c692f6a9ff7f794.jpg
    Screenshot_2021-10-26-17-43-55-47_313461a7842323087c692f6a9ff7f794.jpg
    380.6 KB · Views: 134
  • Screenshot_2021-10-26-17-45-16-80_3175d5f313738748668e677d8dd7a5e5.jpg
    Screenshot_2021-10-26-17-45-16-80_3175d5f313738748668e677d8dd7a5e5.jpg
    292.7 KB · Views: 172

Didgeridoohan

Senior Moderator / Dev Committee / Dev Relations
Staff member
May 31, 2012
12,245
1
14,401
Gothenburg
Google Nexus 4
Nexus 6
updated mhpc to 6.1.1 and reset everything. no go.
If you reset everything you might have just made the MagiskHide props option inactive. Take a look under "Edit MagiskHide props" in the module main menu and see if all options are active (if not, activate).
 

zgfg

Senior Member
Oct 10, 2016
6,070
3,574
To parrot someone 'Let me get this out of the way: since I have a full time job now, I don't have much time for Magisk; I need prioritization' ...

I had meant to run / check it by now but priorities intervened / objected...

Now that is keeping MHide alive, +Riru!

This one might be more elegant than TheHitMans Custom M?

Should be able to enable all MomoHider hide options again w/ that.

Nb. setns is better / faster. Re isolated (only): "This feature is deprecated because it will unmount Magisk modified files for every isolated processes, and the unmounting time cannot be well controlled, which may cause some modules to not work." 👍 PW

Edit:
Many will like choice of traditional hide & Riru or Zygisk in up-to-date Magisk...

Still haven't looked, but might do the translation thing for Alpha-with-deny/hide choice Changelog soon.

Tempted Nigel? ... Just teasing ya. 🙄 🤪
Now I tested also MagiskCustom from TheHitMan7, latest as of today afternoon e4eeb23e (23010)

Also with Zygisk No and MagiskHide Yes

Successfully tested:
- SafetyNet
- Riru
- Riru-LSPosed (GravityBox-R, CustoMIUIzer, Hide My Applist)
- Riru-Momohider (isolated)

Although he provides his own LSPosed-Riru (aka LSPosedCustom), I used LSPosed-riru-v1.6.2-6180-release.apk
from LSPosedArchives and it worked

---

In my opinion (since I opt for Zygisk No and MagiskHide instead of DenyList)

Pro for Alpha:
- Release apk (MagiskCustom provides only Debug apk)

Pros for MagiskCustom
- Only MagiskHide, you have MagiskHide menu to configure apps | proccesses and you use magiskhide CLI command.
(In Alpha you have to choose between MagiskHide and DenyList, and even if you chose MagiskHide [with Zygisk disabled] you still need to use Configure DenyList to configure apps | processes for MagiskHide and magisk --denylist CLI command - because vvb2060 now uses a single table in his database both for MagiskHide or DenyList, it just depends if you choose MagiskHide or Zygisk+DenyList)
- Modules repo (old repo is still alive for updates of modules previously accepted to the repo, but Repo is removed from Canary and Alpha apks)

All together I prefer MagiskCustom for now but I have to use it for a day to test stability (Alpha worked fine with mainly the same setup for the whole day)

And of course, who knows in future about the maintenance

For now both are aligned with the latest Magisk Canary 23010 but providing the ability to avoid Zygisk (with DenyList) and to use MagiskHide instead - hence to have Riru working and no issues with detection of Zygisk
 

Attachments

  • 3.jpg
    3.jpg
    155.4 KB · Views: 96
  • 5.jpg
    5.jpg
    289.1 KB · Views: 90
  • 1.jpg
    1.jpg
    193.2 KB · Views: 92
  • 2.jpg
    2.jpg
    86.1 KB · Views: 85
  • 4.jpg
    4.jpg
    309.8 KB · Views: 88
  • 6.jpg
    6.jpg
    146.1 KB · Views: 86
  • 7.jpg
    7.jpg
    142.8 KB · Views: 87
Last edited:

lokopol

Senior Member
Jul 16, 2013
463
1,264
With the latest update, I have a failure to connect mobile wifi, any solution ?.

my device redmi note 7. android 10, ROM stock.

I am attaching catlog, I hope you can see the error. thank you all for your time and effort, greetings.
 

Attachments

  • 2021-10-26-22-47-34.txt
    5 KB · Views: 8

zaczatowany

Senior Member
Jun 25, 2010
91
15
cuz magisks developer hired google android security dev and developer fear job loosing (he is right).

magisk new version not support magiskhide and downloading modules the magisk app.

solution;
update magisk (canary channel, warning, not released)
hide magisk
turn on zygisk feature and enforce it deny list (warning, not released)
open configure deny list then apply deny list on google play services (gfs) and playstore (maybe clear the app cache & data)
install riru module
restart phone
install universal safety net fix module
restart the phone again
You don't understand... I install Magisk from zip file by TWRP but Magisk Manager show me so i have no magisk installed. I tried install different versions of Magisk but Magisk Manager doesn't see any of it.
 

Fif_

Senior Member
Jun 5, 2013
1,147
1,209
Google Nexus 10
Google Nexus 4
You don't understand... I install Magisk from zip file by TWRP but Magisk Manager show me so i have no magisk installed. I tried install different versions of Magisk but Magisk Manager doesn't see any of it.
Have you tried installing by patching the boot image instead? Installing via recovery is not supported anymore with recent Magisk (including 23.0).
 

Top Liked Posts

  • 26
    I've been following the thread for a long time now, and I think some users are still confused regarding the differences between the different variants of Magisk that are available for use. I'm going to try and summarize them here, which should be helpful for everyone:

    Magisk Variant​
    Stable​
    Canary​
    Alpha​
    Custom​
    Release​
    Official​
    Official​
    Unofficial​
    Unofficial​
    Maintainer​
    topjohnwu​
    topjohnwu​
    vvb2060​
    TheHitMan7​
    Zygisk​
    No​
    Yes​
    Yes​
    Yes​
    DenyList​
    No​
    Yes​
    Yes​
    No​
    MagiskHide​
    Yes​
    No​
    Yes*​
    Yes​
    Modules Repo​
    Yes​
    No​
    No​
    Yes​

    *If you turn off Zygisk in Alpha, then DenyList will act like MagiskHide. So essentially, you can have Zygisk On + DenyList or Zygisk Off + DenyList running as MagiskHide.

    In case I've gotten something wrong, or can add more information, please let me know. :) Cheers!
    6
    I've been following the thread for a long time now, and I think some users are still confused regarding the differences between the different variants of Magisk that are available for use. I'm going to try and summarize them here, which should be helpful for everyone:

    Magisk Variant​
    Stable​
    Canary​
    Alpha​
    Custom​
    Release​
    Official​
    Official​
    Unofficial​
    Unofficial​
    Maintainer​
    topjohnwu​
    topjohnwu​
    vvb2060​
    TheHitMan7​
    Zygisk​
    No​
    Yes​
    Yes​
    Yes​
    DenyList​
    No​
    Yes​
    Yes​
    No​
    MagiskHide​
    Yes​
    No​
    Yes*​
    Yes​
    Modules Repo​
    Yes​
    No​
    No​
    Yes​

    *If you turn off Zygisk in Alpha, then DenyList will act like MagiskHide. So essentially, you can have Zygisk On + DenyList or Zygisk Off + DenyList running as MagiskHide.

    In case I've gotten something wrong, or can add more information, please let me know. :) Cheers!
    Kudos to you for doing this. This thread has become very fragmented with all the different versions of Magisk being discussed in this one thread. I can't imagine being a new user (or even an experienced one) and coming in here and trying to figure out what is what, what does what, etc., especially given the OP can't be revised unless John does it. Even trying to figure out what version someone is talking about in a given post can be difficult at times I would imagine. I'm sure this table will be very helpful to many. 👍
    5
    I've been following the thread for a long time now, and I think some users are still confused regarding the differences between the different variants of Magisk that are available for use. I'm going to try and summarize them here, which should be helpful for everyone:

    Magisk Variant​
    Stable​
    Canary​
    Alpha​
    Custom​
    Release​
    Official​
    Official​
    Unofficial​
    Unofficial​
    Maintainer​
    topjohnwu​
    topjohnwu​
    vvb2060​
    TheHitMan7​
    Zygisk​
    No​
    Yes​
    Yes​
    Yes​
    DenyList​
    No​
    Yes​
    Yes​
    Yes^​
    MagiskHide​
    Yes​
    No​
    Yes*​
    Yes​
    Modules Repo​
    Yes​
    No​
    No​
    Yes​

    * If you turn off Zygisk in Alpha, then DenyList will act like MagiskHide. So essentially, you can have Zygisk On + DenyList or Zygisk Off + DenyList running as MagiskHide.
    ^ DenyList depends on Zygisk being enabled. So if you turn off Zygisk in Custom, DenyList will also stop working.

    In case I've gotten something wrong, or can add more information, please let me know. :) Cheers!
    AFAIK, there is no DenyList in Custom. Only MagiskHide without or with Zygisk
    4
    AFAIK, there is no DenyList in Custom. Only MagiskHide without or with Zygisk
    Thanks! Post updated. (y)
    4
    is it about the same magisk?
    What does that mean?

    What is or not the same Magisk - sorry be precise, cannot guess what you think or not?!

    Canary channel is (and always was) official prereleases from TJW, creator and maintainer of Magisk (Stable).
    Big changes are already rolling in Canary, hence it is not (functionally) the same as the old Stable.
    There are already tons of posts here in the thread about what is new in the Canary and how to use - there are also posts with ChangeLogs - please read, be familiar, this is not TG channel and please don't expect that somebody will waste the time to repeat all the same things to every newcomer

    There are also two spun-offs, Magisk Alpha and Magisk Custom - they are based on the new Canary but with some differences (making them more or less similsr to the old Magisk Stable).
    Again, please go back, find and read the posts about, tons of ink was already spent on, several users posted questions, answers, opinions, links to their Github pages and TG channels for download, discussion about, etc
  • 26
    I've been following the thread for a long time now, and I think some users are still confused regarding the differences between the different variants of Magisk that are available for use. I'm going to try and summarize them here, which should be helpful for everyone:

    Magisk Variant​
    Stable​
    Canary​
    Alpha​
    Custom​
    Release​
    Official​
    Official​
    Unofficial​
    Unofficial​
    Maintainer​
    topjohnwu​
    topjohnwu​
    vvb2060​
    TheHitMan7​
    Zygisk​
    No​
    Yes​
    Yes​
    Yes​
    DenyList​
    No​
    Yes​
    Yes​
    No​
    MagiskHide​
    Yes​
    No​
    Yes*​
    Yes​
    Modules Repo​
    Yes​
    No​
    No​
    Yes​

    *If you turn off Zygisk in Alpha, then DenyList will act like MagiskHide. So essentially, you can have Zygisk On + DenyList or Zygisk Off + DenyList running as MagiskHide.

    In case I've gotten something wrong, or can add more information, please let me know. :) Cheers!
    14
    For those who use Alpha or new Canary and miss the old Modules Repo:

    Download and install their root app that will act like the old Modules tab with the integrated connection to the Repo

    Actually, two Repositories - the old 'official' one plus the alternative new Repo (the old/original TJW's Repo is closed for submission of any new modules - only the modules that were admitted previously could still be updated to the old 'official' Repo)
    13
    Great guide, thanks... I think I followed a similar guide from you a while back, but forgot full path requirement... Pinged you as I thought you'd come through! 👍

    I didn't say MagiskBoot was part of Magisk binary however... I clearly said 'magiskboot * binary * isn't working for me'. 😜 ...

    Thanks for the method. PW
    This one might be a bit more confusing. ;)

    Not sure I can operate Magiskboot before I flash it to the device. Once I flash Magisk, I have access to fastboot through recovery, and that's it.
    While catching up last night, I missed that you are not rooted. :oops:

    ---

    Without root, you need a directory with heightened permissions that you can access.

    You should be able to use the /data/local/tmp/ directory.

    Unzip the Magisk apk file and push the appropriate architecture to the device.
    Then set the permissions to be executable.

    Linux/Mac command line example.
    Make the appropriate changes if you use Windows.​
    • Unpack the lib directory from the Magisk apk file.
      unzip app-debug.apk lib*
    • Push the matching Magisk architecture to the device.
      adb push lib/YourDeviceArchitecture/* /data/local/tmp/
    • Push the boot image you want to modify to the device.
      adb push boot.img /data/local/tmp/
    • Set permissions.
      adb shell chmod 0755 /data/local/tmp/*.so
    • Enter adb shell and change directories.
      adb shell
      cd /data/local/tmp/
    • Run the commands using the ./ prefix.
      ./libmagiskboot.so

    Make the changes you want, exit the shell and pull the new-boot image to the computer.
    Reboot into bootloader and boot the new-boot image.

    Note:
    /data/local/tmp/ should be an empty directory.
    You should clear the directory after you are done using it. ;)


    Quick example just unpacking and repacking a boot image without root.
    Magiskboot Example - Pastebin - Link

    Hope it helps more than confuse. 🙃

    Cheers. :cowboy:
    12
    Hi all. :D

    I do not use twitter so, I am out of the loop at times. :confused:
    Links to a few tweets were noted in an issue on USNF github earlier today.

    Seemed to be appropriate to mention here.

    From John Wu.
    PSA: MagiskHide of Magisk v23.0 no longer passes SafetyNet, even with BASIC evalType. Tested on my Pixel 4 XL running stock Android 12 with vanilla Magisk v23.0.

    MagiskHide is *officially* dead. If you need any kind of root hiding, it's the perfect time to find alternatives.
    There are already plenty of "root hiding" modules out there that I'm aware of, some even utilizing the latest features of Magisk canary.

    I'm obligated to distance myself from any tamper detection circumvention, so I will not assist/promote any modules. Do your own research 🙃

    From osm0sis
    *Cough* @kdrag0n's Universal SafetyNet Fix (USNF) *Cough* 😘
    To be specific, Magisk Canary, Zygisk and DenyList enabled, and USNF v2.2.0+ is the way forward. 🤘

    Cheers all. :cowboy:
    10
    Gents, as grateful I am for all above substantial contributions I hope you allow me to express my "wonder"... As you all know off-topic posts (unless violating forum rules) are only removed on request of the threadowner, I'm just surprised that extremely experienced and knowledgable XDA users allow this thread to deviate from its subject.
    Just as an idea for similar "occasions" in future, hadn't it been better to simply point somebody to the well known subject matter related ad blocker threads? Okay, unexperienced members should certainly question themselves why they post off-topic in a thread. After the initial serious problems with the in-XDA-search, I meanwhile must say it's working excellent for me.

    And by the way: I've removed the link to paid applications as not being accepted on XDA. Please don't mind.

    Regards
    Oswald Boelcke
    Senior Moderator
  • 1069
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p