• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

73sydney

Senior Member
Jul 21, 2018
1,997
1,799
Sydney
Google Pixel 2 XL
Samsung Galaxy S20
I looked for custom rom for this device but couldn't find any. Is there any other ad blockers that might work for me?

I long ago got rid of systemless hosts/adaway as they choke on large lists, and mine is large (as in 40Mb) :)

i prefer to use dnscypt-proxy - apart from encrypting dns queries, it has block and allow lists, though this may be
more less point and shoot than other methods as you have add and maintain the allow/block lists and add and remove entries manually

I have been working on my own version which has been pushed into a corner for over a month now, but closer to being released - it need more testing in the way i personally automate list sources and parsing them, but will have a far easier on device script that does a lot of fiddling for you (add sources lists, update sources, add/remove sites with alias in terminal, sort lists etc) and makes it easier to maintain

Currently until i get my digit out and finish it, the best option is the following version of dnscrypt-proxy, as it doesnt require the use of afwall & script to redirect DNS, as it uses the older method of straight up iptables way of doing that. This guy does set his dnscrypt-proxy.toml file (the config) file for a lot more routing than i do (relays etc), im not that tinfoil hat (after all its only to obfuscate DNS queries). But you can find the documentation on the main site and change that if necessary

dnscrypt-proxy magisk module: https://codeberg.org/quindecim/dnscrypt-proxy-android

He often releases new dnscypt-proxy.toml config files (to add or remove relays or servers if they got dormant) on his Telegram group

He tends to list a whole list of servers in his config (and soem are directly related to later relay settings - which i never use), personally i think its better to find localised ones closer to you for latency, and add as many of those as you can find, and then add a few standards, like cloudflare and google as a backup..

Server list (scroll to bottom and set Rows Per Page to All, then CTRL + F and enter (generally) country name/city name/two letter country code and find all matches and add to server_names in dnscrypt-proxy.toml): https://dnscrypt.info/public-servers/

All official docs and telegram group linked on his page, he does well to document things...

He uses official binaries, but customises the config file, differences between official config are noted on site as well.

Another alternative is Invizible (not free) - it allows gui configuration of dnscrypt-proxy, and also has Tor etc, which i never used when testing it:

{Mod edit: link removed}
 
Last edited by a moderator:

73sydney

Senior Member
Jul 21, 2018
1,997
1,799
Sydney
Google Pixel 2 XL
Samsung Galaxy S20
AdAway (A free and Open Source ad blocker for Android.) - https://f-droid.org/packages/org.adaway
See my earlier comment about AdAway choking on blocklists, that thing was outdated but for the very simplest lists years ago...

I have no idea why that broken thing even still exists, its the very definition of this gif...

deadhorseclaymation-gif.5447931
 
Last edited by a moderator:

zgfg

Senior Member
Oct 10, 2016
6,360
3,773
I looked for custom rom for this device but couldn't find any. Is there any other ad blockers that might work for me?
AdAway itself but in non-root mode, DNS66 and Blokada all use virtual VPN for DNS, hence not the hosts file and not Systemless hosts.
For the first two there are threads on XDA (don't know if for the third as well), please look for further info there

Since A9 and onward, you can use Private DNS (settings on the phone), google for the appropriate DNS to block ads (and generally how to use) - in that case you don't need an ad blocker app
 

F308

Senior Member
Feb 25, 2013
431
65
EU
A root solution is to put everything unwanted into /system/etc/hosts like I did having currently 1.9 million lines and 60 Mb size file.
Once forever I got rid of all crappy commercials and other bandwidth and processor power consuming stuff.
 

Soumy1234

Senior Member
Aug 19, 2017
626
177
A root solution is to put everything unwanted into /system/etc/hosts like I did having currently 1.9 million lines and 60 Mb size file.
Once forever I got rid of all crappy commercials and other bandwidth and processor power consuming stuff.
Damn that's quite a large hosts file. What block lists are you using if I may ask?
 

Oswald Boelcke

Senior Moderator / Moderator Committee
Staff member
Gents, as grateful I am for all above substantial contributions I hope you allow me to express my "wonder"... As you all know off-topic posts (unless violating forum rules) are only removed on request of the threadowner, I'm just surprised that extremely experienced and knowledgable XDA users allow this thread to deviate from its subject.
Just as an idea for similar "occasions" in future, hadn't it been better to simply point somebody to the well known subject matter related ad blocker threads? Okay, unexperienced members should certainly question themselves why they post off-topic in a thread. After the initial serious problems with the in-XDA-search, I meanwhile must say it's working excellent for me.

And by the way: I've removed the link to paid applications as not being accepted on XDA. Please don't mind.

Regards
Oswald Boelcke
Senior Moderator
 
Aug 22, 2016
18
5
Gents, as grateful I am for all above substantial contributions I hope you allow me to express my "wonder"... As you all know off-topic posts (unless violating forum rules) are only removed on request of the threadowner, I'm just surprised that extremely experienced and knowledgable XDA users allow this thread to deviate from its subject.
Just as an idea for similar "occasions" in future, hadn't it been better to simply point somebody to the well known subject matter related ad blocker threads? Okay, unexperienced members should certainly question themselves why they post off-topic in a thread. After the initial serious problems with the in-XDA-search, I meanwhile must say it's working excellent for me.

And by the way: I've removed the link to paid applications as not being accepted on XDA. Please don't mind.

Regards
Oswald Boelcke
Senior Moderator
Please, I would like to be directed to the well known subject matter related ad blocker threads. I searched for quite a while and was only able to find posts that were a year or more old.
 

vandyman

Senior Member
Jul 30, 2012
678
316
S.Jersey
Google Pixel 5
Google Pixel 6
Please, I would like to be directed to the well known subject matter related ad blocker threads. I searched for quite a while and was only able to find posts that were a year or more old.
The moderator said in the post above yours, No more off topic post about add blocking....
And I guess your search engine is not working either. Searching for AdAway, Adguard, etc.. works perfect on my end.
 
  • Like
Reactions: curiousrom

Ralegend

Senior Member
Feb 2, 2014
86
5
Hi.
My device is Samsung M52 5G. I tried the 23015 canary and followed the guide:
I am trying to root the phone for hours and no luck!
What am I doing wrong? Odin flash done than stuck with the "This phone is not running Samsung's official software...."
Please help me and save my next hours. Thank you.
 

Ralegend

Senior Member
Feb 2, 2014
86
5
Hi.
My device is Samsung M52 5G. I tried the 23015 canary and followed the guide:
I am trying to root the phone for hours and no luck!
What am I doing wrong? Odin flash done than stuck with the "This phone is not running Samsung's official software...."
Please help me and save my next hours. Thank you.

Still trying with no luck.
Another try. After successful Odin flash, I manually try to open recovery but it erases itself. :(
 

pndwal

Senior Member
Still trying with no luck.
Another try. After successful Odin flash, I manually try to open recovery but it erases itself. :(
Can I assume you are on Android 11 ATM? And did root with full data wipe & all image files as prescribed for Sammy devices?

Nb. There are several active Magisk GitHub issue for Sammy that may reflect yours... PW
 
  • Like
Reactions: J.Michael

Top Liked Posts

  • 3
    It hid the Magisk app. Could this be caused by the dentist
    Maybe oculist, not dentist 🥸
    2
    Maybe oculist, not dentist 🥸
    Ophthalmologist or Optometrist :ROFLMAO: :ROFLMAO: :ROFLMAO:
    Darn auto correct, it was supposed to be denylist not dentist.
    1
    on official Canary and latest Alpha, when Momo is in denylist, it crashes on startup.

    I remember it does not happen to me only
    Same in my RN8T. PW
    1
    Moved to latest Canary, haven't had a minute today; may not test latest Alpha, sorry... May have misunderstood some of your points earlier... Haven't even played much with new Canary...

    Can say w/ 72 Shamiko Mono crashes if in denylist for me too ... I see update button but greyed out / does nothing... May manually update Shamiko later... LSPosed seems to be working fine w/ 72 anyway... PW
    with latest Alpha/Shamiko (yesterday's releases), update button is not there
    1
    with latest Alpha/Shamiko (yesterday's releases), update button is not there
    That was exactly one of my points about Alpha 23017

    LSPosed has also json and it should have Update button grayed out (there is in Alpha 23016) - is it also missing for you in Alpha 23017?
  • 11
    Can you confirm that all apps checked in the deny list are hidden to the system, pleeeaaase ???
    Few things to note: You really need to read release notes before using any Magisk build, official or otherwise. 🙃

    The build @Johnson_Ran posted is his own build of latest unofficial Alpha Magisk + LoveSys fix for OnePlus 7 / 7 Pro (and possibly other devices) w/ ramdisk detection issue; I posted re. a test build based on canary, now he posted his personal Alpha Magisk with fix for OnePlus... Nb. The fix has NOT been merged in Magisk master, Canary or even latest vvb2060 Alpha yet.

    Well this concept of deny list is confusing so I tried to treat it as a MagiskHide list and all apps I checked are not working as they did with v23... ^^
    Do you mean Are root-related execution environment changes hidden from the app? If so, that depends...

    MagiskHide is dead and gone in TJW builds going forward; denylist is quite different - it 'reverts Magisk features in use for selected processes', ie w/ denylist "Magisk denies further modifications and reverts all changes it had done. Magisk will not spoof/alter/manipulate any non-Magisk related signals or traces to circumvent any device state detection." So denylist is actually made more powerful for hiding TEE mods because of Zygisk, but won't perform the spoofing / alterations / manipulations of non-Magisk related signals or traces formerly done by MagiskHide.

    Even more powerful hiding methods are now available however, thanks to John's strengthened Magisk framework; he just won't do it himself:
    www.twitter.com/topjohnwu/status/1445598597521633285

    Universal SafetyNet Fix and Shamiko are examples where Zygisk is used for advanced hiding by 3rd party modules. Nb. Denylist is not even needed if Devs choose to "do everything themselves"!
    www.twitter.com/topjohnwu/status/1445598601372069890

    As I indicated, the biggest favour users can do themselves is read release notes before using any Magisk build, official or otherwise. For TJW Canary start with this one:
    https://github.com/topjohnwu/magisk-files/blob/9537c5d8cedfc09ca723ae0392b1219e75d9b636/notes.md
    ... read the blog John links there (for good reason) also... and scroll down and read the 2020 one also for more understanding of the general Magisk roadmap / direction...

    ONLY after understanding these major changes, if you want to try HIGHLY EXPERIMENTAL bleeding edge vvb2060 Alpha builds, read IT'S Changelog (translate Chinese)... Latest here:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86215689

    Coming back to your statement
    I tried to treat it as a MagiskHide list and all apps I checked are not working as they did with v23... ^^
    Note a major difference between TJW denylist and Alpha denylist:
    • [General] Use MagiskHide to hide when Zygisk is closed
    So denylist in Alpha works like MagiskHide / hidelist only after Zygisk is closed; Nb. you NEED TO REBOOT to disable Zygisk.

    After this Riru modules will also work (it's a choice; Riru or Zygisk, not both), and if you needed 2.x series Universal SafetyNet Fix for your device, you'll need to swap to a USNF-Riru build if you had USNF-Zygisk. Note: There is no option to do this in TJW Canary as current USNF-Riru builds require MagiskHide to function.*

    Nb.1. In TJW builds denylist WON'T be used as hidelist or with MagiskHide. Alpha restores MagiskHide... This is peculiar to custom Magisk forks...

    Nb. 2. There are differences with MagiskHide in Alpha. Importantly, toggling MagiskHide off then on again does NOT add Google Play Services safetynet process to denylist (whether in denylist or hybrid alpha hidelist mode). You need to do this manually to pass SafetyNet as follows:

    Add Google Play Services process(es) to denylist unless a solution for hiding root associated modifications from GPS SafetyNet process(es) is incorporated in an active module. For devices where Magisk resides in /sbin (many pre. Android 11), only deny SafetyNet process, com.google.android.gms.unstable. For Android 11+ etc (non /sbin), deny Main process, com.google.android.gms also.

    Happy reading / playing, and hope this helps! 😀 PW

    Edit:

    *FWIW, this makes Alpha attractive for anyone wanting to use Riru and pass SafetyNet on late devices (w/ TEE Attestation in hardware affected by September Google server end changes) with post 23001 Magisk builds... This may only be useful in the interim until general Zygisk module conversion / take-up and Riru is dropped...

    However if (and only if) Riru does get continued support / remains popular / doesn't die post Magisk 24000 (ie. Zygisk in Stable Magisk), and @kdrag0n reconsiders this:
    https://github.com/kdrag0n/safetynet-fix/issues/120#issuecomment-971831719
    we may see working USNF-Riru for official TJW post Zygisk Magisk...

    I suspect though that predictions of Riru's imminent demise will be realised, so don't hold your breath.

    Thanks for all the fun RikkaW and team; You did it (allowed modules to run code in apps w/ zygote injection / Xhook) first! 👏 PW
    9
    ...snip...
    Just meant nandroid restore should be usable to roll back since you seemed concerned you'd 'lose ability to use nandroid backup' & would need to restore beloved A10 setup / mods piece by piece!...
    ...snip...
    A LOT of config is stored in the settings. For example:
    PHP:
    settings put global "window_animation_scale" "0.5";
    Because I use to build ROMs from source and therefore clean flash my devices a lot, I built a method to extract and reinstate all my config, to be used selectively and in combination with normal back-up apps, to reinstate my device as close to its previous state without manually hunting and seeking all the settings, after a clean flash.

    I automated this task as a method within the app TeMeFI and can be found under Current State>Settings>Generate Set All
    8
    Guys (especially @zgfg and @pndwal), big thumb up 👍🏻 for your patience in explaining everything gazillion times over and over 😂
    7
    Victory! What did I Will Merv!😉
    6
    I'm going to update my Samsung S21 from Android 11 One UI 3.1 to Android 12 One UI 4, can someone confirm that the standard firmware update procedure (patched system image + home_csc) will work?

    Thank you!
    Broken in current released builds. Fix merged in Magisk master repo downstream for S21
    https://github.com/topjohnwu/Magisk/issues/5162#issuecomment-1004475802
    + many other Sammy models two weeks ago.

    PR: https://github.com/topjohnwu/Magisk/pull/5139
    Committed:
    https://github.com/topjohnwu/Magisk/commit/19182ffddf6f7c87bacab4b9f91cfaec3ee79537

    John commented on Sammy's 'solution' for broken fstab in device tree (MA content):
    www.twitter.com/topjohnwu/status/1475985579036667904

    You'll need to wait for next TJW build (Canary or Beta), but you can try latest test build from artifacts here:
    https://github.com/topjohnwu/Magisk/actions/runs/1632403163
    Also, fix is merged in latest vvb2060 Alpha builds.
    https://github.com/vvb2060/Magisk/commit/19182ffddf6f7c87bacab4b9f91cfaec3ee79537

    I'm going to update my Samsung S21 from Android 11 One UI 3.1 to Android 12 One UI 4, can someone confirm that the standard firmware update procedure (patched system image + home_csc) will work?
    Nb. Standard procedure is to flash patched firmware file as AP + HOME_CSC + BL + CP as per instruction:
    • Never just flash only AP, or else Odin may shrink your /data filesystem size. Flash AP + BL + CP + HOME_CSC when upgrading.
    👀 PW
  • 1072
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p