• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
Trying with 0f71edee-alpha (23015) but Shamiko reports that Magisk is somewhat broken and Momo still finds Zygisk

All other things work for me (SafetyNet hence DenyList and Zygisk, Superuser grants, modules - and of course, I do testing without Riru)
Working for me.

IMG_20211206_095646.jpg


I suspect you have broken db or other in /data/adb due to unofficial Custom Magisk use if didn't take full Magisk Uninstall. I was able to take 'dirty' Alpha install (w/ Direct Install) over Canary however.

Also, to clarify, you will need to disable Enforce Denylist after you configure it as per original instructions. (Google translation could be clearer / doesn't help):
LSPosed:

Shamiko Preview

Simple hide based on zygisk.

Configure inheritance denylist. After installing Shamiko, configure denylist and close denylist, Shamiko will automatically take over and hide.

Theory supports Android 8.1+, but only tested on 11

Clearly we will need to wait for Zygisk compatible solutions / details for other traces / environmental abnormalities detected. I have no idea how @nu11ptr got completely happy Momo.
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86032113

Both Rootbeer Fresh and Rootbeer Sample are happy with my setup, and I can still hide 'root' from PushTAN app.

PW

Edit: See you got it sorted...

Nb. Solution is not open sourced yet, and @nu11ptr indicated that this will likely not change.
 
Last edited:

Lord Sithek

Senior Member
Dec 19, 2018
944
453
Xiaomi Redmi Note 4
Huawei Watch 2
Working for me.

View attachment 5475567

I suspect you have broken db or other in /data/adb due to unofficial Custom Magisk use if didn't take full Magisk Uninstall. I was able to take 'dirty' Alpha install (w/ Direct Install) over Canary however.

Also, to clarify, you will need to disable Enforce Denylist after you configure it as per original instructions. (Google translation could be clearer / doesn't help):


Clearly we will need to wait for Zygisk compatible solutions / details for other traces / environmental abnormalities detected. I have no idea how @nu11ptr got completely happy Momo.
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86032113

Both Rootbeer Fresh and Rootbeer Sample are happy with my setup, and I can still hide 'root' from PushTAN app.

PW

Edit: See you got it sorted...

Nb. Solution is not open sourced yet, and @nu11ptr indicated that this will likely not change.
How the heck you got SPushTan happy? Its more for testing purposes for me, I dont really need this app, but no idea how to bypass it :p Shamiko latest enabled and working, denylist disabled after configuration, rebooted, RootBeer Fresh doesnt find anything, but SPushTan complaining constantly! Also I hided Magisk app and LSPosed manager. Have no idea what else could I do

EDIT: Possible that lack of encryption results with this?
 

Attachments

  • Screenshot_20211206-084533_Momo.png
    Screenshot_20211206-084533_Momo.png
    117.8 KB · Views: 78
Last edited:

pndwal

Senior Member
How the heck you got SPushTan happy? Its more for testing purposes for me, I dont really need this app, but no idea how to bypass it :p Shamiko latest enabled and working, denylist disabled after configuration, rebooted, RootBeer Fresh doesnt find anything, but SPushTan complaining constantly! Also I hided Magisk app and LSPosed manager. Have no idea what else could I do
Yeah, Push-TAN is simply detecting Magisk App but using special tricks, which is why freezing this works, but 'Hide the Magisk App' alone is not enough as with that
only the package name changes. The classes.dex with the code does not change and can be used to identify the app.
https://github.com/topjohnwu/Magisk/issues/1084#issuecomment-893367674
Their protection engine (Promon) indeed seems to employ a very simple pattern matching on the installed apps. Rebuilding the stub app combined with Magisk Hide hides it successfully.
https://github.com/topjohnwu/Magisk/issues/1084#issuecomment-892775076

So if stub app is rebuild it can be hidden. Simply put, "a simple app packer [does] mitigate the detection very easily"
https://github.com/topjohnwu/Magisk/issues/1084#issuecomment-892224424

However I found this method solved it more simply about one month ago:
https://github.com/topjohnwu/Magisk/issues/1084#issuecomment-964222271

I don't need it (in Australia) either; just tried out of curiosity and as I knew it was a long standing issue.
EDIT: Possible that lack of encryption results with this?
Doubt it. My results w/ encryption above are similar... PW
 
  • Like
Reactions: Lord Sithek

Lord Sithek

Senior Member
Dec 19, 2018
944
453
Xiaomi Redmi Note 4
Huawei Watch 2
Yeah, Push-TAN is simply detecting Magisk App but using special tricks, which is why freezing this works, but 'Hide the Magisk App' alone is not enough as with that

https://github.com/topjohnwu/Magisk/issues/1084#issuecomment-893367674

https://github.com/topjohnwu/Magisk/issues/1084#issuecomment-892775076

So if stub app is rebuild it can be hidden. Simply put, "a simple app packer [does] mitigate the detection very easily"
https://github.com/topjohnwu/Magisk/issues/1084#issuecomment-892224424

However I found this method solved it more simply about one month ago:
https://github.com/topjohnwu/Magisk/issues/1084#issuecomment-964222271

I don't need it (in Australia) either; just tried out of curiosity and as I knew it was a long standing issue.

Doubt it. My results w/ encryption above are similar... PW
Oh yeah, I've seen this solution of yours before, just totally forgot about it 🤦🏻 Using HMA is enough indeed, thanx 😄
 
  • Like
Reactions: pndwal

Schroeder09

Senior Member
Nov 6, 2017
660
67
I'm on Android 10 march 5, 2020 update on a p2xl. I can't open the manager. I think I was on like v20.4. A couple weeks ago I clicked the update button in the manager. I think it was to a v22 or something. The direct install option never popped up. The installation didn't complete, but I think something is messed up because I can't open the manager. The message I get is:
Upgrade to full magisk manager to finish the setup. Download the install?

I click "ok" and it just says the same message. What's the proper way to install the most recent and compatible version of the manager on my current install? I don't want to have to go to Android 11 and deal with the 3 weeks of getting my phone set back up to how it was. I don't have time for rooting anymore.
 

zgfg

Senior Member
Oct 10, 2016
6,337
3,764
Working for me.

View attachment 5475567

Edit: See you got it sorted...
Not that I 'sorted out' but they fixed Shamiko - with (42) three other users reported the same problem on TG channel, but when you woke up :), the bug was already fixed in the new Shamiko build (47)

Anyway, more about my tests with Magisk Alpha 23015, Zygisk+DenyList, Shaniko and Momo v4.0.1:

With USB debugging disabled, Magisk app repackaged and all modules disabled except Shamiko, I still have:
- Partitions mounted abnormally
- Restriction on non-SDK interfaces is not working
- Bootloader unlocked

Unfortunately, I cannot get any better than that?!

I.e., compared to you, I have additional detection:
- Restriction on non-SDK interfaces is not working

but on the other side, I don't have yours:
- Found Magisk
- ART parameters are abnormal

---

I can Restore Magisk app, enable BusyBox, Systemless hosts, AML, Viper4Android (using v2.7.2.1 - it doesn't switch to Permisive mode) and Smali Patcher (I only patch Secure Screenshots), they don't make any worse, I still have the same three Momo detections as above

---

When I enable Zygisk-LSPosed module, Momo ads:
- ART parameters are abnormal

but by disabling the (single) line in the LSPosed system.prop file (workaround suggested by @Eng.Raman), I can avoid that abnormal Art params detection

And with that workaround all my LSP modules (GravityBox, CustoMIUIzer, Hide My Apps) and their corresponding mods still work correctly

---

When USB debugging in Developer options is enabled, Momo will add:
- Debugging mode is enabled

---

Finally, I can also enable Systemless debloating (by use of .replace files) and debloat various apps (tested by debloating 25 of them) from /system, /system_ext and /product - with no implications to Momo detections

However - that's strange, if I debloat any app from /vendor (I tested separately with 3 of them), then Momo immediately detects (and only in that case for me):
- Found Magisk
 

Attachments

  • Screenshot_2021-12-06-13-23-03-429_io.github.vvb2060.mahoshojo.jpg
    Screenshot_2021-12-06-13-23-03-429_io.github.vvb2060.mahoshojo.jpg
    341.1 KB · Views: 77
Last edited:

J.Michael

Recognized Contributor
Jan 20, 2018
963
884
Samsung Galaxy Tab A series
I'm on Android 10 march 5, 2020 update on a p2xl. I can't open the manager. I think I was on like v20.4. A couple weeks ago I clicked the update button in the manager. I think it was to a v22 or something. The direct install option never popped up. The installation didn't complete, but I think something is messed up because I can't open the manager. The message I get is:
Upgrade to full magisk manager to finish the setup. Download the install?

I click "ok" and it just says the same message. What's the proper way to install the most recent and compatible version of the manager on my current install? I don't want to have to go to Android 11 and deal with the 3 weeks of getting my phone set back up to how it was. I don't have time for rooting anymore.
Do you still have a rooted phone?

If so, maybe you can use the Magisk command-line program to determine what version of Magisk is installed, then pick a corresponding version of the Magisk Manager app.
 
  • Like
Reactions: ipdev

Schroeder09

Senior Member
Nov 6, 2017
660
67
Do you still have a rooted phone?

If so, maybe you can use the Magisk command-line program to determine what version of Magisk is installed, then pick a corresponding version of the Magisk Manager app.
Root checker says I'm not rooted, but titanium backups says I am. Every root app is functioning the same. Substratum, adaway, matlog, and tasker are all still doing their thing. I just can't see anything or change any settings on them through the magisk manager.


Is it an option to flash the old manager in twrp? I know have two magisk apps on my phone since the half way install of v22 got on here. I have the magisk app and then another one that says magic mask. When I tap on that one I get the install message I described before.
 

GivIn2It

Member
Jul 12, 2021
28
10
Samsung Galaxy A52 5G
First of all, I did multiple searches. The search this thread function does not work correctly for me. My problem is: magisk canary 23015 has no modules. Suggestions online said clear repo cache, That option does not show. touching the layers button does nothing, all I have is install from storage. Can someone tell me how to populate this modules list, or how to download and install the modules to storage? Its a Pixel6Pro. Root is working great so I don't intend to re install.
 

zgfg

Senior Member
Oct 10, 2016
6,337
3,764
First of all, I did multiple searches. The search this thread function does not work correctly for me. My problem is: magisk canary 23015 has no modules. Suggestions online said clear repo cache, That option does not show. touching the layers button does nothing, all I have is install from storage. Can someone tell me how to populate this modules list, or how to download and install the modules to storage? Its a Pixel6Pro. Root is working great so I don't intend to re install.
There are problems with search in XDA - nevertheless, when you updated Magisk, you could have read the ChangeLog to realize that support for Repo is gone from Canary and there is no such thing as wiping cache or so to 'help'

Install Fox Magisk Modules Manager root app (sorry, I'm not going to search where from to install, but that was also posted here maybe twice - google for Fox Mmm on the Net)
 

GivIn2It

Member
Jul 12, 2021
28
10
Samsung Galaxy A52 5G
There are problems with search in XDA - nevertheless, when you updated Magisk, you could have read the ChangeLog to realize that support for Repo is gone from Canary and there is no such thing as wiping cache or so to 'help'

Install Fox Magisk Modules Manager root app (sorry, I'm not going to search where from to install, but that was also posted here maybe twice - google for Fox Mmm on the Net)
I appreciate your reply. I cant find an apk for this, or any links, other than some stuff I don't trust on youtube. I did not find any links on how how install this. Github frustrates me, I don't understand it. Can someone point me to how to install this?
 

Lord Sithek

Senior Member
Dec 19, 2018
944
453
Xiaomi Redmi Note 4
Huawei Watch 2
I appreciate your reply. I cant find an apk for this, or any links, other than some stuff I don't trust on youtube. I did not find any links on how how install this. Github frustrates me, I don't understand it. Can someone point me to how to install this?
 

martyfender

Senior Member
Mar 9, 2017
3,185
1,704
Indianapolis, IN
Type
I appreciate your reply. I cant find an apk for this, or any links, other than some stuff I don't trust on youtube. I did not find any links on how how install this. Github frustrates me, I don't understand it. Can someone point me to how to install this?

I appreciate your reply. I cant find an apk for this, or any links, other than some stuff I don't trust on youtube. I did not find any links on how how install this. Github frustrates me, I don't understand it. Can someone point me to how to install this?
Type this search term: github fox magisk modules manager in either google search or as I use, duckduckgo in firefox.
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
Root checker says I'm not rooted, but titanium backups says I am. Every root app is functioning the same. Substratum, adaway, matlog, and tasker are all still doing their thing. I just can't see anything or change any settings on them through the magisk manager.


Is it an option to flash the old manager in twrp? I know have two magisk apps on my phone since the half way install of v22 got on here. I have the magisk app and then another one that says magic mask. When I tap on that one I get the install message I described before.
I assume you updated with Magisk app hidden, and you renamed to 'magic mask' when hiding? This is supposed to work, appart from going from pre ver 22 to 22 or later as per 22.0 Changelog which says "

RESTORE THE EXISTING MAGISK MANAGER BACK TO NORMAL BEFORE UPGRADING IF HIDDEN!"​

In practice the same / similar issues updating w/ hidden app often occur. (I'd say 50% success rate only)... Result is hidden app has partial control / other cannot see root etc.

Solution is simple. Locate and uninstall hidden app (may need to uninstall unhidden app also) from device settings, apps, app info list, then reinstall apk. Nb. Your settings / modules won't be affected as they are stored in /data/adb, not app storage. PW
 
  • Like
Reactions: ipdev and rodken

Eng.Raman

Senior Member
Apr 13, 2014
439
496
Khanaqin
I.e., compared to you, I have additional detection:
- Restriction on non-SDK interfaces is not working
This flag in Momo App is related to using a DeOdexed Rom ( your and all the xiaomi.eu roms are deodexed ).
Most of the stock roms are odexed BUT if someone decide to deodex even one file in his device rom for example: using the SmaliPatcher Module ( Which it will deodexing and patching the services.jar file in the "/system/framework/services.jar" ) then he will get that flag.
 

Attachments

  • Screenshot_2021-12-06-22-25.jpg
    Screenshot_2021-12-06-22-25.jpg
    874.9 KB · Views: 78
Last edited:

vandyman

Senior Member
Jul 30, 2012
674
313
S.Jersey
Google Pixel 5
Google Pixel 6
There are problems with search in XDA - nevertheless, when you updated Magisk, you could have read the ChangeLog to realize that support for Repo is gone from Canary and there is no such thing as wiping cache or so to 'help'

Install Fox Magisk Modules Manager root app (sorry, I'm not going to search where from to install, but that was also posted here maybe twice - google for Fox Mmm on the Net)
I really do not get it.!
Why should anyone search and check the logs.
Pictures tell a thousand words. 🤣
 
  • Sad
Reactions: heinhuiz

pndwal

Senior Member
Not that I 'sorted out' but they fixed Shamiko - with (42) three other users reported the same problem on TG channel, but when you woke up :), the bug was already fixed in the new Shamiko build (47)
Well to be fair, the bug was already fixed (not while sleeping 🙄)... You were in fact replying to my post re. new version:
Nb. New Alpha Magisk has Xhook fix merged...

New Shadow Mistress Yuko is also available. Shamiko-v0.1.2-47-release zip

😝 PW
I had naturally assumed that you were actually using v0.1.2-47, not old initial build therefore. 😉

Thanks for other useful analysis though. 😀 PW
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
6,337
3,764
I really do not get it.!
Why should anyone search and check the logs.
Pictures tell a thousand words. 🤣
I'd stop being polite here, but honestly:

Why should anybody ask questions here and expect the others to waste time answering him, if he was too lazy to follow the conversation on time to be informed from the ongoing posts (talking already two or thee months about.the changes rolling out), and in the first place, too lazy to read the ChangeLog while updating his Magisk installation
 
Last edited:

Top Liked Posts

  • 2
    I do not know what makes a Canary build go to a stable build. EX; Canary 23016 to stable v24.
    It would make versions less confusing for new and intermediate users.

    Maybe version 23017 that was released will go to stable V24.

    Stable, beta, Canary, and 20+ alpha builds. Take your pick and hope for the best.

    For me, I always used the Canary builds with the Pixel line up.
    This:
    John Wu, Nov 24, 2021

    The newly reborn Magisk (post MagiskHide removal, post Zygisk) is looking more and more ready! Will start focusing on stabilizing and testing in the coming weeks. But to be completely honest, I'm actually pretty terrified to release it, even just to the public beta channel.

    I can already see the obscene amount of hate and bashing flooding into Twitter and GitHub like a tsunami. I might actually have to leave the internet for a few days and shutdown my GitHub issues right after the release, just to prevent myself from getting depression...
    www.twitter.com/topjohnwu/status/1463404273186721794

    But seriously, he still needs to address the general lack of support for real world devices. It's pitiful, and John is attuned to the desperate pleas...
    PLEASE SIR I NEED ROOT ON MY OVEN FRIDGE COMBO WHY YOU NOT SUPPORT...
    www.twitter.com/tjh/status/1463405139763466247

    Note to Bob the chicken from North Island NZ:

    John will respond to reasonable requests only. For example, he's running test actions on a wide range of sofas as we speak in preparation for 24.0 Beta... However any suggestion of expanding compatibility to embrace animal companions will be taken with a grain of salt... 😁 😜 PW
    2
    This:


    www.twitter.com/topjohnwu/status/1463404273186721794

    But seriously, he still needs to address the general lack of support for real world devices. It's pitiful, and John is attuned to the desperate pleas...

    www.twitter.com/tjh/status/1463405139763466247

    He's running test actions on a wide range of sofas as we speak, and may also expand compatibility to embrace animal companions sometime before 24.0 Beta... ... 😁 😜 PW
    Thanks.... Zygisk looks like the best way going forward. It is cleaner with less module clutter.
    1
    ... Or use the test build from LoveSy...
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86287919
    or John's brand new one with ALL master repo commits till now:
    https://github.com/topjohnwu/Magisk/actions/runs/1722755293
    until we get imminent TJW release w/ fixes and more.

    Nb. This LSPosed build is the first with new JSON supporting "Support modules update" commit.
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86281165

    If you keep JSON intact you see update in magisk with 'Support modules update' and fix for JSON:

    ... Also, formatting errors are probably excusable, even inevitable on first try... 😜 PW
    For the matter of fact, updateJson field is supported also in Alpha 23016 (latest, Jan 17)

    Dirty test:

    Since Alpha is not updated to 23017, I must use Shamiko v0.2.0 (59).
    Hence I copy/paste updateJson from Shamiko v0.3.0(72) to /data/adb/modules/zygisk_shamiko/module.prop

    Then Magisk Alpha apk correctly shows that Update for Shamiko is available.
    I can take Install - it downloads and starts installing but correctly fails noting that new Shamiko requires Magisk 23017+ (mine is Alpha 23016). So far so good

    BUT if I take DOWNLOAD instead, it downloads Shamiko v0.3.0(72) zip but then Magisk (Alpha) app always CRASHES

    I've tested several times, Install and Download download the same zip to /Download folder, Install correctly continues with installation but Download crashes

    I experimented similarly with my own module (I added updateJson to my module.prop and json file to my Github page), Install installs/updates my module but Download downloads and then crashes

    Could somebody with Canary 23017 test that Download option - I don't know is this crash something specific to Alpha 23016 or general issue
  • 11
    Can you confirm that all apps checked in the deny list are hidden to the system, pleeeaaase ???
    Few things to note: You really need to read release notes before using any Magisk build, official or otherwise. 🙃

    The build @Johnson_Ran posted is his own build of latest unofficial Alpha Magisk + LoveSys fix for OnePlus 7 / 7 Pro (and possibly other devices) w/ ramdisk detection issue; I posted re. a test build based on canary, now he posted his personal Alpha Magisk with fix for OnePlus... Nb. The fix has NOT been merged in Magisk master, Canary or even latest vvb2060 Alpha yet.

    Well this concept of deny list is confusing so I tried to treat it as a MagiskHide list and all apps I checked are not working as they did with v23... ^^
    Do you mean Are root-related execution environment changes hidden from the app? If so, that depends...

    MagiskHide is dead and gone in TJW builds going forward; denylist is quite different - it 'reverts Magisk features in use for selected processes', ie w/ denylist "Magisk denies further modifications and reverts all changes it had done. Magisk will not spoof/alter/manipulate any non-Magisk related signals or traces to circumvent any device state detection." So denylist is actually made more powerful for hiding TEE mods because of Zygisk, but won't perform the spoofing / alterations / manipulations of non-Magisk related signals or traces formerly done by MagiskHide.

    Even more powerful hiding methods are now available however, thanks to John's strengthened Magisk framework; he just won't do it himself:
    www.twitter.com/topjohnwu/status/1445598597521633285

    Universal SafetyNet Fix and Shamiko are examples where Zygisk is used for advanced hiding by 3rd party modules. Nb. Denylist is not even needed if Devs choose to "do everything themselves"!
    www.twitter.com/topjohnwu/status/1445598601372069890

    As I indicated, the biggest favour users can do themselves is read release notes before using any Magisk build, official or otherwise. For TJW Canary start with this one:
    https://github.com/topjohnwu/magisk-files/blob/9537c5d8cedfc09ca723ae0392b1219e75d9b636/notes.md
    ... read the blog John links there (for good reason) also... and scroll down and read the 2020 one also for more understanding of the general Magisk roadmap / direction...

    ONLY after understanding these major changes, if you want to try HIGHLY EXPERIMENTAL bleeding edge vvb2060 Alpha builds, read IT'S Changelog (translate Chinese)... Latest here:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86215689

    Coming back to your statement
    I tried to treat it as a MagiskHide list and all apps I checked are not working as they did with v23... ^^
    Note a major difference between TJW denylist and Alpha denylist:
    • [General] Use MagiskHide to hide when Zygisk is closed
    So denylist in Alpha works like MagiskHide / hidelist only after Zygisk is closed; Nb. you NEED TO REBOOT to disable Zygisk.

    After this Riru modules will also work (it's a choice; Riru or Zygisk, not both), and if you needed 2.x series Universal SafetyNet Fix for your device, you'll need to swap to a USNF-Riru build if you had USNF-Zygisk. Note: There is no option to do this in TJW Canary as current USNF-Riru builds require MagiskHide to function.*

    Nb.1. In TJW builds denylist WON'T be used as hidelist or with MagiskHide. Alpha restores MagiskHide... This is peculiar to custom Magisk forks...

    Nb. 2. There are differences with MagiskHide in Alpha. Importantly, toggling MagiskHide off then on again does NOT add Google Play Services safetynet process to denylist (whether in denylist or hybrid alpha hidelist mode). You need to do this manually to pass SafetyNet as follows:

    Add Google Play Services process(es) to denylist unless a solution for hiding root associated modifications from GPS SafetyNet process(es) is incorporated in an active module. For devices where Magisk resides in /sbin (many pre. Android 11), only deny SafetyNet process, com.google.android.gms.unstable. For Android 11+ etc (non /sbin), deny Main process, com.google.android.gms also.

    Happy reading / playing, and hope this helps! 😀 PW

    Edit:

    *FWIW, this makes Alpha attractive for anyone wanting to use Riru and pass SafetyNet on late devices (w/ TEE Attestation in hardware affected by September Google server end changes) with post 23001 Magisk builds... This may only be useful in the interim until general Zygisk module conversion / take-up and Riru is dropped...

    However if (and only if) Riru does get continued support / remains popular / doesn't die post Magisk 24000 (ie. Zygisk in Stable Magisk), and @kdrag0n reconsiders this:
    https://github.com/kdrag0n/safetynet-fix/issues/120#issuecomment-971831719
    we may see working USNF-Riru for official TJW post Zygisk Magisk...

    I suspect though that predictions of Riru's imminent demise will be realised, so don't hold your breath.

    Thanks for all the fun RikkaW and team; You did it (allowed modules to run code in apps w/ zygote injection / Xhook) first! 👏 PW
    9
    ...snip...
    Just meant nandroid restore should be usable to roll back since you seemed concerned you'd 'lose ability to use nandroid backup' & would need to restore beloved A10 setup / mods piece by piece!...
    ...snip...
    A LOT of config is stored in the settings. For example:
    PHP:
    settings put global "window_animation_scale" "0.5";
    Because I use to build ROMs from source and therefore clean flash my devices a lot, I built a method to extract and reinstate all my config, to be used selectively and in combination with normal back-up apps, to reinstate my device as close to its previous state without manually hunting and seeking all the settings, after a clean flash.

    I automated this task as a method within the app TeMeFI and can be found under Current State>Settings>Generate Set All
    8
    Guys (especially @zgfg and @pndwal), big thumb up 👍🏻 for your patience in explaining everything gazillion times over and over 😂
    7
    Victory! What did I Will Merv!😉
  • 1072
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p