• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

zgfg

Senior Member
Oct 10, 2016
6,404
3,823
Well to be fair, the bug was already fixed (not while sleeping 🙄)... You were in fact replying to my post re. new version:

I had naturally assumed that you were actually using v0.1.2-47, not old initial build therefore. 😉

Thanks for other useful analysis though. 😀 PW
If I can still count on my short-term memory how I downloaded and tested just 24h ago:

I downloaded Shamiko from the main Alpha channel, assuming it was the right/latest version to test with

When complaining to the TG channel I saw couple of similar reports with the same error.
ThenI got response to use the latest version and I realized that download for (42) was replaced by (47) - otherwise I don't understand where else would I stumped first to download (42) if not from that same TG channel, where I was posting/responding to (and under the same Shamiko 'topic')
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
6,404
3,823
This flag in Momo App is related to using a DeOdexed Rom ( your and all the xiaomi.eu roms is deodexed ).
Most of the stock roms are odexed BUT if someone decide to deodex even one file in his device rom for example: using the SmaliPatcher Module ( Which it will deodexing and patching the services.jar file in the "/system/framework/services.jar" ) then he will get that flag.
Thank you for that explanation, I knew that Xiaomi.eu ROMs are deodexed but didn't know that for Momo it means that 'Restriction on non-SDK interfaces is not working"🤩
 
  • Like
Reactions: Eng.Raman

vandyman

Senior Member
Jul 30, 2012
699
326
S.Jersey
Google Pixel 5
Google Pixel 6
I will really be not polite here, but honestly:

Why should anybody ask questions here and expect the others to waste time answering him, if he was too lazy to follow the conversation on time to be informed from the ongoing posts (talking already two or thee months about.the changes rolling out), and in the first place, too lazy to read the ChangeLog while updating his Magisk installation
Thank you for being a great contributer to xda.
I have been checking in on this thread since day one.

My problem with this thread is that no one at least tries reading the basics before any modding.
The same questions are ask every day and answered with no improvement to this thread to keep the clutter down.

Remember the Bozos with the Pokémon go BS....
 
  • Like
Reactions: zgfg
This flag in Momo App is related to using a DeOdexed Rom ( your and all the xiaomi.eu roms is deodexed ).
Most of the stock roms are odexed BUT if someone decide to deodex even one file in his device rom for example: using the SmaliPatcher Module ( Which it will deodexing and patching the services.jar file in the "/system/framework/services.jar" ) then he will get that flag.
I suppose that the same reasoning applies to stock OnePlus ROMs [OOS].
 
  • Like
Reactions: Eng.Raman

pndwal

Senior Member
If I can still count on my short-term memory how I downloaded and tested just 24h ago:

I downloaded Shamiko from the main Alpha channel, assuming it was the right/latest version to test with

When complaining to the TG channel I saw couple of similar reports with the same error.
ThenI got response to use the latest version and I realized that download for (42) was replaced by (47) - otherwise I don't understand where else would I stumped first to download (42) if not from that same TG channel, where I was posting/responding to (and under the same Shamiko 'topic')
Ok, I saw your exchange later. It was in less known Alpha channel (~ 700 members) where init release was posted. Assume you found that after my first posts... Only updated 47 version was posted in main Alpha feed (6.2k subscribers) before you tried with Alpha as I said. These posts and comments are also mirrored in the 700 member feed however... PW
 

saeed81

Member
Sep 7, 2013
11
1
Help me pls , using android 12 , with magisk canary 23015 but when enable Zygisk, Riru and lsposed doesn't work
 

zgfg

Senior Member
Oct 10, 2016
6,404
3,823
This flag in Momo App is related to using a DeOdexed Rom ( your and all the xiaomi.eu roms is deodexed ).
Most of the stock roms are odexed BUT if someone decide to deodex even one file in his device rom for example: using the SmaliPatcher Module ( Which it will deodexing and patching the services.jar file in the "/system/framework/services.jar" ) then he will get that flag.
Thanks. Do you maybe know also about the flag/detection:
- Partition mounted abnormally
 

JacobBoi_

Member
Dec 6, 2021
7
0
1. Toggle on the enforce denyList
2. Click on Configure denyList
3. Choose "Google Play Service" and checklist on "com.android.gms" and "com.android.gms.unstable"

Should do the trick for safetynet. Hope it helps out with the Hysteria of magiskhide is no more.
Realme 7 pro, No custom rom

I have a problem:
I enabled the stuff in the Google Play Services (and do everything else).
But when i reboot my phone The Google Play Services seems to be untouched like i neved changed anything with it in Deny List...
Screens show Before and After Reboot.

I did this multiple times.
 

Attachments

  • Screenshot_2021-12-07-00-15-39-35.jpg
    Screenshot_2021-12-07-00-15-39-35.jpg
    275.1 KB · Views: 51
  • Screenshot_2021-12-07-00-15-43-68.jpg
    Screenshot_2021-12-07-00-15-43-68.jpg
    265.8 KB · Views: 52

zgfg

Senior Member
Oct 10, 2016
6,404
3,823
Realme 7 pro, No custom rom

I have a problem:
I enabled the stuff in the Google Play Services (and do everything else).
But when i reboot my phone The Google Play Services seems to be untouched like i neved changed anything with it in Deny List...
Screens show Before and After Reboot.

I did this multiple times.
You can't see anything in Google Play Services:)
But try with SafetyNet Checker like YASNAC

If it doesn't pass, try with installing Universal SafetyNet Fix 2.2.0 (XDA USNF thread)
 
  • Like
Reactions: Tecalote

JacobBoi_

Member
Dec 6, 2021
7
0
You can't see anything in Google Play Services:)
But try with SafetyNet Checker like YASNAC

If it doesn't pass, try with installing Universal SafetyNet Fix 2.2.0 (XDA USNF thread)
I already did it :/
 

Attachments

  • Screenshot_2021-12-07-00-58-51-22.jpg
    Screenshot_2021-12-07-00-58-51-22.jpg
    364.1 KB · Views: 45
  • Screenshot_2021-12-07-00-59-15-82.jpg
    Screenshot_2021-12-07-00-59-15-82.jpg
    220.3 KB · Views: 46

ipdev

Recognized Contributor
Feb 14, 2016
1,667
1
2,403
Google Nexus 10
Nexus 7 (2013)
@JacobBoi_
If you are using USNF v2.2.0, you can not add gms to DenyList.
The USNF module will remove it from the DenyList on boot if you do.

As soon as you add gms to the DenyList, you will break USNF.

Make sure gms is not in the DenyList and reboot one more time.

Then check SafetyNet.

--

If your device does not support hardware attestation then you do not need use the USNF module.

Instead you add gms to the DenyList and adjust the sensitive prop values.
Easiest is to use the MHPC module to set the sensitive props.

[MODULE] MagiskHide Props Config - SafetyNet, prop edits, and more - v6.1.2 - xdaThread - Link

Cheers. :cowboy:
 
  • Like
Reactions: Lughnasadh

ipdev

Recognized Contributor
Feb 14, 2016
1,667
1
2,403
Google Nexus 10
Nexus 7 (2013)
Root checker says I'm not rooted, but titanium backups says I am. Every root app is functioning the same. Substratum, adaway, matlog, and tasker are all still doing their thing. I just can't see anything or change any settings on them through the magisk manager.


Is it an option to flash the old manager in twrp? I know have two magisk apps on my phone since the half way install of v22 got on here. I have the magisk app and then another one that says magic mask. When I tap on that one I get the install message I described before.

I assume you updated with Magisk app hidden, and you renamed to 'magic mask' when hiding? This is supposed to work, appart from going from pre ver 22 to 22 or later as per 22.0 Changelog which says "

RESTORE THE EXISTING MAGISK MANAGER BACK TO NORMAL BEFORE UPGRADING IF HIDDEN!"​

In practice the same / similar issues updating w/ hidden app often occur. (I'd say 50% success rate only)... Result is hidden app has partial control / other cannot see root etc.

Solution is simple. Locate and uninstall hidden app (may need to uninstall unhidden app also) from device settings, apps, app info list, then reinstall apk. Nb. Your settings / modules won't be affected as they are stored in /data/adb, not app storage. PW
Just one thing to add. ;)

If you do not know what version of Magisk is installed.
You can uninstall all the Magisk apps and reboot.

Since Magisk is still active on the device, it will install the Magisk stub app on boot.
Open the stub app and it will prompt to install the full version.
This will guarantee you get the correct Magisk app version.
The stub will point to the version of Magisk that the boot image is patched with.

Cheers. :cowboy:
 
Last edited:

J.Michael

Recognized Contributor
Jan 20, 2018
972
896
Samsung Galaxy Tab A series
Root checker says I'm not rooted, but titanium backups says I am. Every root app is functioning the same. Substratum, adaway, matlog, and tasker are all still doing their thing. I just can't see anything or change any settings on them through the magisk manager.


Is it an option to flash the old manager in twrp? I know have two magisk apps on my phone since the half way install of v22 got on here. I have the magisk app and then another one that says magic mask. When I tap on that one I get the install message I described before.
If you can, run the following in a terminal:
Code:
magisk -c
 

VirginPC

Senior Member
Oct 14, 2012
57
6
Singapore
Hi everyone...... I tried uninstall Magisk Canary v23.0 (the last version of MagiskHide), and install the latest 23015 version from Official & Unofficial....... But I try everything, it still not able to install the Magisk, & only show App installed, but Magisk not show........ Can guide me????
 

Attachments

  • XDA.jpg
    XDA.jpg
    197.9 KB · Views: 47

Vijay_lalwani

Member
May 22, 2017
15
2
Hey, just a small question. I installed the lastest Canary build and everything works just fine but I can't see the list of installable modules that was previously available using the stable version.

Thanks in advance.

Screenshot_20211207-122905.png
 

zgfg

Senior Member
Oct 10, 2016
6,404
3,823
Hey, just a small question. I installed the lastest Canary build and everything works just fine but I can't see the list of installable modules that was previously available using the stable version.

Thanks in advance.

View attachment 5476797
First, it is/must be in the ChangeLog that Canary (and future Stable) does no more connect to the Repo - it is gone

Second, it was at least asked and answered once in the last 2-3 days (I remember, I did snswer).
Please scroll back, find and read

Sorry but I really don't understand why users tend to install new Canary, without doing their homework first to get informed what will be the changes and how to deal with them.
It's really frustrating to read the same basic questions over and over
 

pndwal

Senior Member
Hi everyone...... I tried uninstall Magisk Canary v23.0 (the last version of MagiskHide),
Well that's last Stable build w/ MagiskHide; last (synchronised) Canary was 23001.
and install the latest 23015 version from Official & Unofficial....... But I try everything, it still not able to install the Magisk, & only show App installed, but Magisk not show........ Can guide me????
So we need more details re what you did; many possibilities. Did you uninstall previous app? Did you take Uninstall Magisk from within app? Both? If used Uninstall Magisk function, Restore Images or Complete Uninstall? Reinstall by installing APK / Direct Install (if didn't use Uninstall Magisk) or patch/flash boot image or flash zip from recovery? Any root apps still working or root Detector app indicate device is actually rooted If didn't take Uninstall Magisk? Did you simply install new App with old App hidden (not Restored) and still installed? (Likely dual conflicting app syndrome afflicting more Magisk users that covid does)...

Please give us a clue... PW
 

V0latyle

Forum Moderator
Staff member
Sorry but I really don't understand why users tend to install new Canary, without doing their homework first to get informed what will be the changes and how to deal with them.
It's really frustrating to read the same basic questions over and over
Welcome to XDA :D

The best we can do is be patient and professional; we were all noobs once.
 
Last edited:

vandyman

Senior Member
Jul 30, 2012
699
326
S.Jersey
Google Pixel 5
Google Pixel 6
No being a newbie is not the main problem.
This is the Magisk general questions thread.
Meaning, posting topics above the Canary builds confuses people on what the basics are.
Stable and Canary builds is all that should be talked about here.

I am surprised that the moderator has not closed this thread for a week. As they have done in the past multiple times.

99% of the people that read these post are not developers or programmers. They are just everyday people.

And to the newbie, if a search, common sense, and reading first before posting. Then they deserve to be ridiculed.
 

Top Liked Posts

  • 3
    Now that there is a new Magisk V24 stable thread.
    Will it be it be ruined like this thread?

    I really hope not. Who can post the most in the new thread does not count like it does here in this thread.
    Sorry for the off topic rant and being an a*s.
    Nb. It's a 24.0+ thread, but we haven't yet got stable! 😉

    Preventing a new thread from expanding fast has been my concern too, and @ipdev and I have discussed this over the last few weeks (he may have done so with others also).

    I can't / couldn't see an easy solution to this for a discussion / help thread... We did discuss a wiki style site / thread to supplement @Didgeridoohan's excellent database of solutions to cover use of new hiding modules and other more loosely magisk related topics / issues... This is what we've got - Ipdev stepped up to maintain it and I salute him for his efforts!

    Nb. It will likely help a lot if users read the first 5 posts before asking questions though... The intention is to keep these updated to cover the most commonly needed information...

    I don't think that this thread ruined however. It may be burgeoning, but it is / has always been a very valuable resource as a General Discussion thread, especially for those knowing what to search for / how to search... And as long as some who keep up with recent development are happy to help others, it seems to work well for all AFAICS... 😜 PW
    3
    With @topjohnwu as OP, this thread relies on moderators to do housekeeping as John is no longer active here... PW
    Exactly. People of this thread should report posts, if they deem it necessary and we'll take care of it, as usual.

    General info:
    No need to make a post about someone else's post being offtopic etc..
    2
    No, you're right. What might help is when some of the most helpful contributers like @pndwal and @zgfg and others could have rights to simply delete posts.

    I mean, what does a post like:

    add in the middle of a discussion about hiding Magisk? 🙄
    Or would it be better to just report such posts, or (dis)like them with a sad 🙁 or angry 😡 face?
    That will be one advantage of the new @ipdev 24.0+ thread; as an active OP he can delete posts / do housekeeping.

    With @topjohnwu as OP, this thread relies on moderators to do housekeeping as John is no longer active here... PW
  • 15
    Show will begin, I tried to put some short help for probably the posts/questions soon to expect

    ===

    Please carefully read Changelog

    Study the Magisk documentation available from the official Magisk Github page - particularly about installing Magisk (if you are not familiar with patching the image in Magisk app and flashing the patched img from Fastboot- i.e, not the old school about Magisk zip through TWRP)

    Everything bellow has already been discussed in this thread since Canary 2301x started to roll out - hence more details can be found in the older posts in this thread

    a) No more MagiskHide. New technology instead (for the same - to help hiding root): Zygisk+DenyList

    b) No more built in SafetyNet checker. Install from PlayStore e g: YASNAC

    c) Modules window does no more connect to the (now frozen) old Modules repository.
    You must download module zip files manually and "Install from local storage".
    Or search for and install Fox Magisk Module Manager (Fox Mmm) app - it will connect to the new, alternative repository

    ---

    1) Make sure that both Magisk app and Magisk are installed and updated to the new version. Inspect version numbers on the main Magisk window/page

    2) Make sure to uninstall all Riru modules (not compatible with Zygisk)

    3) Settings, Enable Zygisk and reboot.
    Then check on the main window does it show Zygisk Yes

    4) Settings, enable Enforce DenyList.
    Configure DenyList, enable filters to Show OS and System apps
    Find Google Play Services and check-in only the two processes ending with gms and gms.unstable.
    You will have to check in all your banking apps and so as you used with MagiskHide.
    Always reboot upon reconfiguring DenyList

    5) If SafetyNet does not pass, install USNF 2.2.1 and test again.
    Always reboot upon installing a module, also if/when you enable Systemless Hosts

    ---

    Intentionally, I didn't want to complicate with Shamiko for the new Magisk 24 users 👍

    PS: See the new thread:
    11
    Can you confirm that all apps checked in the deny list are hidden to the system, pleeeaaase ???
    Few things to note: You really need to read release notes before using any Magisk build, official or otherwise. 🙃

    The build @Johnson_Ran posted is his own build of latest unofficial Alpha Magisk + LoveSys fix for OnePlus 7 / 7 Pro (and possibly other devices) w/ ramdisk detection issue; I posted re. a test build based on canary, now he posted his personal Alpha Magisk with fix for OnePlus... Nb. The fix has NOT been merged in Magisk master, Canary or even latest vvb2060 Alpha yet.

    Well this concept of deny list is confusing so I tried to treat it as a MagiskHide list and all apps I checked are not working as they did with v23... ^^
    Do you mean Are root-related execution environment changes hidden from the app? If so, that depends...

    MagiskHide is dead and gone in TJW builds going forward; denylist is quite different - it 'reverts Magisk features in use for selected processes', ie w/ denylist "Magisk denies further modifications and reverts all changes it had done. Magisk will not spoof/alter/manipulate any non-Magisk related signals or traces to circumvent any device state detection." So denylist is actually made more powerful for hiding TEE mods because of Zygisk, but won't perform the spoofing / alterations / manipulations of non-Magisk related signals or traces formerly done by MagiskHide.

    Even more powerful hiding methods are now available however, thanks to John's strengthened Magisk framework; he just won't do it himself:
    www.twitter.com/topjohnwu/status/1445598597521633285

    Universal SafetyNet Fix and Shamiko are examples where Zygisk is used for advanced hiding by 3rd party modules. Nb. Denylist is not even needed if Devs choose to "do everything themselves"!
    www.twitter.com/topjohnwu/status/1445598601372069890

    As I indicated, the biggest favour users can do themselves is read release notes before using any Magisk build, official or otherwise. For TJW Canary start with this one:
    https://github.com/topjohnwu/magisk-files/blob/9537c5d8cedfc09ca723ae0392b1219e75d9b636/notes.md
    ... read the blog John links there (for good reason) also... and scroll down and read the 2020 one also for more understanding of the general Magisk roadmap / direction...

    ONLY after understanding these major changes, if you want to try HIGHLY EXPERIMENTAL bleeding edge vvb2060 Alpha builds, read IT'S Changelog (translate Chinese)... Latest here:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86215689

    Coming back to your statement
    I tried to treat it as a MagiskHide list and all apps I checked are not working as they did with v23... ^^
    Note a major difference between TJW denylist and Alpha denylist:
    • [General] Use MagiskHide to hide when Zygisk is closed
    So denylist in Alpha works like MagiskHide / hidelist only after Zygisk is closed; Nb. you NEED TO REBOOT to disable Zygisk.

    After this Riru modules will also work (it's a choice; Riru or Zygisk, not both), and if you needed 2.x series Universal SafetyNet Fix for your device, you'll need to swap to a USNF-Riru build if you had USNF-Zygisk. Note: There is no option to do this in TJW Canary as current USNF-Riru builds require MagiskHide to function.*

    Nb.1. In TJW builds denylist WON'T be used as hidelist or with MagiskHide. Alpha restores MagiskHide... This is peculiar to custom Magisk forks...

    Nb. 2. There are differences with MagiskHide in Alpha. Importantly, toggling MagiskHide off then on again does NOT add Google Play Services safetynet process to denylist (whether in denylist or hybrid alpha hidelist mode). You need to do this manually to pass SafetyNet as follows:

    Add Google Play Services process(es) to denylist unless a solution for hiding root associated modifications from GPS SafetyNet process(es) is incorporated in an active module. For devices where Magisk resides in /sbin (many pre. Android 11), only deny SafetyNet process, com.google.android.gms.unstable. For Android 11+ etc (non /sbin), deny Main process, com.google.android.gms also.

    Happy reading / playing, and hope this helps! 😀 PW

    Edit:

    *FWIW, this makes Alpha attractive for anyone wanting to use Riru and pass SafetyNet on late devices (w/ TEE Attestation in hardware affected by September Google server end changes) with post 23001 Magisk builds... This may only be useful in the interim until general Zygisk module conversion / take-up and Riru is dropped...

    However if (and only if) Riru does get continued support / remains popular / doesn't die post Magisk 24000 (ie. Zygisk in Stable Magisk), and @kdrag0n reconsiders this:
    https://github.com/kdrag0n/safetynet-fix/issues/120#issuecomment-971831719
    we may see working USNF-Riru for official TJW post Zygisk Magisk...

    I suspect though that predictions of Riru's imminent demise will be realised, so don't hold your breath.

    Thanks for all the fun RikkaW and team; You did it (allowed modules to run code in apps w/ zygote injection / Xhook) first! 👏 PW
    10
    Guess I can advertise @ipdev's new WIP

    [Discussion] Magisk - The Age of Zygisk​

    thread now that public 24.0 release is out:

    First 5 posts have a good summation of new Magisk changes / direction / tips. 👍 PW
    9
    ...snip...
    Just meant nandroid restore should be usable to roll back since you seemed concerned you'd 'lose ability to use nandroid backup' & would need to restore beloved A10 setup / mods piece by piece!...
    ...snip...
    A LOT of config is stored in the settings. For example:
    PHP:
    settings put global "window_animation_scale" "0.5";
    Because I use to build ROMs from source and therefore clean flash my devices a lot, I built a method to extract and reinstate all my config, to be used selectively and in combination with normal back-up apps, to reinstate my device as close to its previous state without manually hunting and seeking all the settings, after a clean flash.

    I automated this task as a method within the app TeMeFI and can be found under Current State>Settings>Generate Set All
    8
    Guys (especially @zgfg and @pndwal), big thumb up 👍🏻 for your patience in explaining everything gazillion times over and over 😂
  • 1072
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p