• Introducing XDA Computing: Discussion zones for Hardware, Software, and more!    Check it out!

Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
"hiding module" (to me) was Unshare or Momohider needed in 23.001 but not more needed with alpha-3, of course w/ classic MagiskHide.

Same app (Sky Go Italy: it.sky.anywhere) works well w/ Shamiko /Zygisk even if Momo detect abnormal environment but only on LOS 17.1+. On Hades it fails hiding.

just for sharing I added the info that, on LOS 18.1, even Momo is happy with same alpha-3 configuration (of course root hiding is perfect!)
Ok, seems this may be an issue with ROM / kernel allowing leaks... (Hades is synonymous with DEATH, after all. 😉)...

Out of interest, I'm guessing you only get L3 security level for DRM Widevine in both of these Sammy devices?

So you are correct re. isolated process detection in SkyGo app. Specifically it detects the Digital Rights Management related VGDRM Helper service.

Nb. This service can.simply be blocked (working for a number of TV apps incl SkyGo):
- Download AppManager
https://github.com/MuntashirAkon/AppManager
- Open and check Services tab for your app, and block the VGDRM Helper service (click on the crossed circle icon) and click 'apply rules' in top (3 dot) menu.
- Thanks to @Longhorn87 for this solution! 👍
https://forum.xda-developers.com/t/skygo-app-detected-root.4128933/post-84688731

Again, some later commit has likely stopped the leaks detected while using MagiskHide / Hades... Of course we won't see the effect in Canary even if commit is in common as there's no Magiskhide...

No idea why Shamiko solution fails per ROM either, except that it's effectiveness / mileage does seem to vary greatly accross devices / OSs... Some configurations untested / unaccounted for?

I'd be interested to see your Momo results for Hades ROM with Alpha / MagiskHide / SkyGo working, and w/ Alpha / Zygisk / Shamiko / SkyGo detecting... 😛 PW
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
Last edited:
  • Like
Reactions: J.Michael

pndwal

Senior Member
Hello folks,
I'm using the latest canary build of Magisk (23016) and am facing a CTS profile mismatch leading to me failing safetynet checks. I have zygisk on, I am using universal safetynet fix 2.2.1, magiskhide props config 6.1.2 configured to pixel 6 pro props with force basic key attestation enabled, and shamiko instead of the denylist. I also have xprivacylua installed on lsposed and even with disabling google play services tracking I still fail. Any idea what I could be doing wrong and how to fix it? Thanks

Edit: A temporary fix I found was resetting my props to default and spoofing them for certain apps like google photos using lsposed.
See, I am using pixel 6 pro props but not on a pixel 6 pro. That may be part of the issue, but my device doesn't even have props in magiskhide props config, and others on my device bypass with pixel 6 pro props.
I'm using a xiaomi redmi note 10 pro (sweet) on arrowos 12. A temporary fix I found was resetting my props to default and spoofing them for certain apps like google photos using lsposed.
How are you settling props in MHPC?

USNF includes everything you need unless ArrowOS doesn't spoof certified itself... If it does, you can disable MHPC altogether; you don't need Force basic key attestation either, and this uses basic model prop mismatch trick which can cause issues... Sounds like it's a prop change that's triggering Compatibility Test Suite (CTS) profile match failure anyway.

Only if ArrowOS doesn't spoof certified itself use MHPC to set a certified fingerprint; that's probably what those you report are 'using pixel 6 pro props to pass CTS profile match' are doing in reality; ONLY a passing certified fingerprint needs configuring for CTS pass in addition to USNF changes. 🙂 PW
 

traversone

Senior Member
Feb 18, 2019
132
45
Latest Shamiko:
Shamiko-v0.1.3-51-release.zip

Translation: zh-CN-en

Alpha will remove magiskhide once all popular Riru modules have released zygisk version and magisk stable version has officially released zygisk.‌‌

https://t.me/magiskalpha/406

👀 PW
no changes from my side, the hiding feature is still not perfect.

furthermore, they have removed some "module notification" (i.e. number of impacted processess or denylist enabled, etc..etc..)
 

traversone

Senior Member
Feb 18, 2019
132
45
Ok, seems this may be an issue with ROM / kernel allowing leaks... (Hades is synonymous with DEATH, after all. 😉)...

Out of interest, I'm guessing you only get L3 security level for DRM Widevine in both of these Sammy devices?

So you are correct re. isolated process detection in SkyGo app. Specifically it detects the Digital Rights Management related VGDRM Helper service.

Nb. This service can.simply be blocked (working for a number of TV apps incl SkyGo):
- Download AppManager
https://github.com/MuntashirAkon/AppManager
- Open and check Services tab for your app, and block the VGDRM Helper service (click on the crossed circle icon) and click 'apply rules' in top (3 dot) menu.
- Thanks to @Longhorn87 for this solution! 👍
https://forum.xda-developers.com/t/skygo-app-detected-root.4128933/post-84688731

Again, some later commit has likely stopped the leaks detected while using MagiskHide / Hades... Of course we won't see the effect in Canary even if commit is in common as there's no Magiskhide...

No idea why Shamiko solution fails per ROM either, except that it's effectiveness / mileage does seem to vary greatly accross devices / OSs... Some configurations untested / unaccounted for?

I'd be interested to see your Momo results for Hades ROM with Alpha / MagiskHide / SkyGo working, and w/ Alpha / Zygisk / Shamiko / SkyGo detecting... 😛 PW
here you are.
Hades_ROM-Momo&MagiskHide.jpg

Hades_ROM-Momo&Zygisk.jpg


Anyway, I knew and successfully tested the Longhorn's advice but I would have preferred a cleaner environment (and 1 app less in the system) !
 
  • Like
Reactions: pndwal

zgfg

Senior Member
Oct 10, 2016
6,317
3,746
furthermore, they have removed some "module notification"
Yeah, unfortunately that useful info is removed now

Yuko Yoshida only thinks she has won now (これで勝ったと思うなよ)

 

Attachments

  • Shamiko.jpg
    Shamiko.jpg
    88.5 KB · Views: 44
  • Haha
Reactions: pndwal

traversone

Senior Member
Feb 18, 2019
132
45
Shamiko successfully hides root from Sky Go on LOS 17.1, even with MOMO status below. As said before, unfortunately it does not work on Hades ROM


LOS_17.1-Momo&Zygisk.jpg
 
  • Like
Reactions: pndwal

Eng.Raman

Senior Member
Apr 13, 2014
438
490
Khanaqin

Attachments

  • IMG_20220114_1.jpg
    IMG_20220114_1.jpg
    390.4 KB · Views: 84
  • IMG_20220114_2.jpg
    IMG_20220114_2.jpg
    400.6 KB · Views: 85
Last edited:

zgfg

Senior Member
Oct 10, 2016
6,317
3,746
i presume you meant the reverse. at least this is how i see it. btw, you also seem to have got the hack working. (y)
I did it pretty easy, unzipped Shamiko 1.2 and 1.3 and compared the post-fs-data.sh scripts. Difference is in two lines

So I basically copied over that script from 1.2 into the /data/adb/modules Shamiko folder and rebooted.
Seems the Engineer did some more adaptations (like translation of Shamiko sayings/phrases), but mine was a 1-2 minute work
 
  • Like
Reactions: Eng.Raman and m0han

Top Liked Posts

  • 2
    for sake of clarity: alpha last but three version, namely 0c1f6881 (Dec 2021, 20th) never looses root, all is working as expected in same system (except Zygisk...)

    something has been added that breaks something else
    Good to know. In fact, I still keep that Alpha apk and my corresponding patched boot.img (just in case)

    I have updated through all the later Alpha versions, updated LSPosed, HMA, installed and updated Shamiko

    Sometime among those updates I started to observe instabilities. I never observed loosing the root but occasionally it loop-boots two or three times (soft- rebooting) before booting successfully. One day it rebooted five times to TWRP (I didn't do anything there except wiping Cache and Dalwik trying to 'help') until it finally rebooted successfully to the system

    Since it does not happen on every reboot and since (as mentioned above) I updated various components, I was unable to point to anything specific (Alpha, Shamiko...) but my hunch was that it's maybe related to Magisk (thinking that I saw it first time upon updating Alpha from that version, before all the later updates)

    But without a hard proof I didn't want to charge anything or anybody
    1
    ## Magisk (558710bb-alpha-3)
    - [App] Support SharedUserId
    - [App] Delete backup file after restoring boot image
    - [App] Built-in current version update log
    - [App] Use local version when unable to download stub
    - [App] Modern time API using Java 8
    - [General] no longer automatically unlock device blocks
    - [General] Use MagiskHide to hide when Zygisk is closed
    - [App] Remove markdown rendering
    - [General] Do not execute scripts that ignore loaded modules
    - [App] Fix the second click of hide app button may not respond
    - [App] Enhanced repair environment function
    - [App] Support setting PATCHVBMETAFLAG flag to handle vbmeta in boot image
    - [App] Compatible with Android 12L
    - [MagiskInit] Refactor the processing method of two-step startup
    - [General] Skip mirror overlayfs partition
    - [MagiskInit] support handling force_debuggable flag
    - [App] Fix SnackBar popup position
    - [App] Removed install to unused slot limit
    - [MagiskBoot] Speed up zopfli compression
    - [App] Fixed not opening in some cases
    - [App] Patch image no longer affects the current environment when rooted
    - [App] Avoid constantly checking the environment
    - [App] The output is displayed with the default font size when flashing
    - [General] Forced not to install to recovery when ramdisk exists
    - [General] Update to NDK 23

    # Upstream changelog
    ## Magisk (92546e8a) (23016)
    - Fixed a possible AVB header misalignment
    - Add new env variable `PATCHVBMETAFLAG` to configure whether vbmeta flags should be patched
    - Only hijack `unshare` calls with `CLONE_NEWNS` bit set
    - Improved support for devices with `oplus.fstab` (OnePlus/Oppo/Realme)
    - Support loading fstab from `/system/etc` (Pixel 6 Dec. Patch)
    - Various Magisk app fixes

    ## Diffs to v23.0
    - [General] MagiskHide is removed from Magisk
    - [General] Support 64-bit only systems
    - [General] Support Android 12
    - [General] Update BusyBox to 1.34.1
    - [Zygisk] Introduce new feature: Zygisk
    - [Zygisk] Introduce DenyList feature to revert Magisk features in user selected processes
    - [MagiskBoot] Support patching 32-bit kernel zImages
    - [MagiskBoot] Support boot image header v4
    - [MagiskBoot] Support patching out `skip_initramfs` from dtb bootargs
    - [MagiskBoot] Add new env variable `PATCHVBMETAFLAG` to configure whether vbmeta flags should be patched
    - [MagiskInit] Support loading fstab from `/system/etc` (required for Pixel 6)
    - [MagiskInit] Support `/proc/bootconfig` for loading boot configurations
    - [MagiskInit] Better support for some Meizu devices
    - [MagiskInit] Better support for some OnePlus/Oppo/Realme devices
    - [MagiskInit] Support `init.real` on some Sony devices
    - [MagiskPolicy] Load `*_compat_cil_file` from system_ext
    - [MagiskSU] Use isolated devpts if the kernel supports it
    - [MagiskSU] Fix root shell if isolated mount namespace is set
    - [resetprop] Deleted properties are now wiped from memory instead of just unlinking
    - [App] Build a single APK for all ABIs
    - [App] Switch to use standard bottom navigation bar
    - [App] Downloading modules within the Magisk app is removed
    ## Magisk (76ddfeb9-alpha)
    - [App] Support SharedUserId
    - [App] Delete backup file after restoring boot image
    - [App] Built-in current version update log
    - [App] Use local version when unable to download stub
    - [App] Modern time API using Java 8
    - [General] no longer automatically unlock device blocks
    - [General] Use MagiskHide to hide when Zygisk is closed
    - [App] Remove markdown rendering
    - [General] Do not execute scripts that ignore loaded modules
    - [App] Fix the second click of hide app button may not respond
    - [App] Enhanced repair environment function
    - [App] Support setting PATCHVBMETAFLAG flag to handle vbmeta in boot image
    - [App] Compatible with Android 12L
    - [MagiskInit] Refactor the processing method of two-step startup
    - [General] Skip mirror overlayfs partition
    - [App] Fix SnackBar popup position
    - [App] Removed install to unused slot limit
    - [MagiskBoot] Speed up zopfli compression
    - [App] Patch image no longer affects the current environment when rooted
    - [App] Avoid constantly checking the environment
    - [General] Update to NDK 23
    - [App] Minimum support Magisk 21.0
    - [App] Support module to check for updates

    # Upstream changelog
    ## Magisk (92546e8a) (23016)
    - Fixed a possible AVB header misalignment
    - Add new env variable `PATCHVBMETAFLAG` to configure whether vbmeta flags should be patched
    - Only hijack `unshare` calls with `CLONE_NEWNS` bit set
    - Improved support for devices with `oplus.fstab` (OnePlus/Oppo/Realme)
    - Support loading fstab from `/system/etc` (Pixel 6 Dec. Patch)
    - Various Magisk app fixes

    ## Diffs to v23.0
    - [General] MagiskHide is removed from Magisk
    - [General] Support 64-bit only systems
    - [General] Support Android 12
    - [General] Update BusyBox to 1.34.1
    - [Zygisk] Introduce new feature: Zygisk
    - [Zygisk] Introduce DenyList feature to revert Magisk features in user selected processes
    - [MagiskBoot] Support patching 32-bit kernel zImages
    - [MagiskBoot] Support boot image header v4
    - [MagiskBoot] Support patching out `skip_initramfs` from dtb bootargs
    - [MagiskBoot] Add new env variable `PATCHVBMETAFLAG` to configure whether vbmeta flags should be patched
    - [MagiskInit] Support loading fstab from `/system/etc` (required for Pixel 6)
    - [MagiskInit] Support `/proc/bootconfig` for loading boot configurations
    - [MagiskInit] Better support for some Meizu devices
    - [MagiskInit] Better support for some OnePlus/Oppo/Realme devices
    - [MagiskInit] Support `init.real` on some Sony devices
    - [MagiskPolicy] Load `*_compat_cil_file` from system_ext
    - [MagiskSU] Use isolated devpts if the kernel supports it
    - [MagiskSU] Fix root shell if isolated mount namespace is set
    - [resetprop] Deleted properties are now wiped from memory instead of just unlinking
    - [App] Build a single APK for all ABIs
    - [App] Switch to use standard bottom navigation bar
    - [App] Downloading modules within the Magisk app is removed
    Sorry, it's not your fault but frankly, those changelogs (for Alpha) are really of very limited use (problem is in the original ZH changelogs)

    Compare the changlogs for previous 558710bb-alpha-3 and this new 76ddfeb9 - both posts quouted above

    It's hard to see what exactly is new/changed in this latest release - 99% of items are repeated over and over for each new Alpha release

    Several sections but no clear section /list what exactly is new/different in this 76ddfeb9 against the previous 558710bb-alpha-3

    Or, am I missing something?
    1
    Sorry, it's not your fault but frankly, those changelogs (for Alpha) are really of very limited use (problem is in the original ZH changelogs)

    Compare the changlogs for previous 558710bb-alpha-3 and this new 76ddfeb9 - both posts quouted above

    It's hard to see what exactly is new/changed in this latest release - 99% of items are repeated over and over for each new Alpha release
    Items are repeated until they are built in Canary or reverted (see below)... It's a cumulative changelog of current items exclusive to debug Alpha (for easy comparison to Canary). Many are for experimental Alpha features so will remain here / never make it to Canary...

    New changes are the last, logically...
    Several sections but no clear section /list what exactly is new/different in this 76ddfeb9 against the previous 558710bb-alpha-3
    Alpha releases are usually synced with Canary and Release notes are designed to show 'Diffs to last Canary', not between infrequent additional Alpha builds...
    Or, am I missing something?
    Only that when multiple Alpha builds do occur between Canary builds the last changes usually represent total 'Diffs to last Alpha' as downstream changes are consistently listed in order. These include both vvb2060 additional commits and TJW commits not included in last Canary.

    In this case it's been a good while since last Canary and vvb2060 has now made several Alpha builds in the interim, so the downstream list is longer than usual. The last 2 are the changes since the previous Alpha:

    ## Magisk (76ddfeb9-alpha)
    - [App] Minimum support Magisk 21.0
    - [App] Support module to check for updates

    Nb. New changelog no longer mentions: '[App] Fixed not opening in some cases' even though the fix remains... Clearly that's because this was a minor patch in 558710bb-alpha-3 to fix 558710bb-alpha-2, and like many TJW commits it shouldn't be in changelogs going forward; only important changes are noted; many others (of minor importance) can be found by perusing commits.

    Nb.2. 'Upstream Changelog' including 'Diffs to Stable/Beta' is simply last TJW Canary changelog reproduced.

    😶 PW
    1
    why is there no allowlist, i want to block all apps from knowing the device is rooted once.
    Traditionally, hiding more than a few apps / processes made the system unstable due to restrictions on the hide daemon's passive reaction speed (to app processes). Also Webview and more are broken by indiscriminate hiding of Chrome etc:
    - www.twitter.com/topjohnwu/status/1039528958289760256
    - https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84868359

    Nb. The hiding elements retained by denyist may well have changed, ie hijacking app_process (Zygote) rather than simply monitoring these passively may now be used / possible with Zygisk and be faster / not face this restriction any longer. However I haven't checked code for this nor am I aware of comments by John about changes to the mechanism used here. Someone may care to comment further...

    It's worth noting that vvb2060 did produce Magisk Lite builds using whitelist mode for some time. Lite however works entirety differently and sacrifices some functionality; it's experimental MagiskHide functions to hide isolated processes. - Magisk Lite has only SU function and does not provide full/normal support for modules. In Magisk in whitelist mode all applications are hidden by default, and only checked applications can obtain super user permissions.

    Testing this solution seems to have stalled / Lite is deprecated... I think I posted re. latest here:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85226953
    - https://github.com/vvb2060/magisk_files/commits/master
    - https://t.me/MagiskLite

    🤠 PW
    1
    edit: wonder why 'latest' is 558710bb-alpha-2 (23016) (23).
    Update channel points to JSON file in GitHub repo. Last pushed was 558710bb-alpha-2 (synced with Canary v23016, Stub v23) of 10 days ago, here:
    https://github.com/vvb2060/magisk_files/tree/3d74b529d447dadb99ee18c57cdc602bbc470d4b

    Neither 76ddfeb9-alpha nor 558710bb-alpha-3 have yet been pushed to GitHub yet. They were only released to Telegram group, but source is in accompanying zip. PW
  • 11
    Can you confirm that all apps checked in the deny list are hidden to the system, pleeeaaase ???
    Few things to note: You really need to read release notes before using any Magisk build, official or otherwise. 🙃

    The build @Johnson_Ran posted is his own build of latest unofficial Alpha Magisk + LoveSys fix for OnePlus 7 / 7 Pro (and possibly other devices) w/ ramdisk detection issue; I posted re. a test build based on canary, now he posted his personal Alpha Magisk with fix for OnePlus... Nb. The fix has NOT been merged in Magisk master, Canary or even latest vvb2060 Alpha yet.

    Well this concept of deny list is confusing so I tried to treat it as a MagiskHide list and all apps I checked are not working as they did with v23... ^^
    Do you mean Are root-related execution environment changes hidden from the app? If so, that depends...

    MagiskHide is dead and gone in TJW builds going forward; denylist is quite different - it 'reverts Magisk features in use for selected processes', ie w/ denylist "Magisk denies further modifications and reverts all changes it had done. Magisk will not spoof/alter/manipulate any non-Magisk related signals or traces to circumvent any device state detection." So denylist is actually made more powerful for hiding TEE mods because of Zygisk, but won't perform the spoofing / alterations / manipulations of non-Magisk related signals or traces formerly done by MagiskHide.

    Even more powerful hiding methods are now available however, thanks to John's strengthened Magisk framework; he just won't do it himself:
    www.twitter.com/topjohnwu/status/1445598597521633285

    Universal SafetyNet Fix and Shamiko are examples where Zygisk is used for advanced hiding by 3rd party modules. Nb. Denylist is not even needed if Devs choose to "do everything themselves"!
    www.twitter.com/topjohnwu/status/1445598601372069890

    As I indicated, the biggest favour users can do themselves is read release notes before using any Magisk build, official or otherwise. For TJW Canary start with this one:
    https://github.com/topjohnwu/magisk-files/blob/9537c5d8cedfc09ca723ae0392b1219e75d9b636/notes.md
    ... read the blog John links there (for good reason) also... and scroll down and read the 2020 one also for more understanding of the general Magisk roadmap / direction...

    ONLY after understanding these major changes, if you want to try HIGHLY EXPERIMENTAL bleeding edge vvb2060 Alpha builds, read IT'S Changelog (translate Chinese)... Latest here:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86215689

    Coming back to your statement
    I tried to treat it as a MagiskHide list and all apps I checked are not working as they did with v23... ^^
    Note a major difference between TJW denylist and Alpha denylist:
    • [General] Use MagiskHide to hide when Zygisk is closed
    So denylist in Alpha works like MagiskHide / hidelist only after Zygisk is closed; Nb. you NEED TO REBOOT to disable Zygisk.

    After this Riru modules will also work (it's a choice; Riru or Zygisk, not both), and if you needed 2.x series Universal SafetyNet Fix for your device, you'll need to swap to a USNF-Riru build if you had USNF-Zygisk. Note: There is no option to do this in TJW Canary as current USNF-Riru builds require MagiskHide to function.*

    Nb.1. In TJW builds denylist WON'T be used as hidelist or with MagiskHide. Alpha restores MagiskHide... This is peculiar to custom Magisk forks...

    Nb. 2. There are differences with MagiskHide in Alpha. Importantly, toggling MagiskHide off then on again does NOT add Google Play Services safetynet process to denylist (whether in denylist or hybrid alpha hidelist mode). You need to do this manually to pass SafetyNet as follows:

    Add Google Play Services process(es) to denylist unless a solution for hiding root associated modifications from GPS SafetyNet process(es) is incorporated in an active module. For devices where Magisk resides in /sbin (many pre. Android 11), only deny SafetyNet process, com.google.android.gms.unstable. For Android 11+ etc (non /sbin), deny Main process, com.google.android.gms also.

    Happy reading / playing, and hope this helps! 😀 PW

    Edit:

    *FWIW, this makes Alpha attractive for anyone wanting to use Riru and pass SafetyNet on late devices (w/ TEE Attestation in hardware affected by September Google server end changes) with post 23001 Magisk builds... This may only be useful in the interim until general Zygisk module conversion / take-up and Riru is dropped...

    However if (and only if) Riru does get continued support / remains popular / doesn't die post Magisk 24000 (ie. Zygisk in Stable Magisk), and @kdrag0n reconsiders this:
    https://github.com/kdrag0n/safetynet-fix/issues/120#issuecomment-971831719
    we may see working USNF-Riru for official TJW post Zygisk Magisk...

    I suspect though that predictions of Riru's imminent demise will be realised, so don't hold your breath.

    Thanks for all the fun RikkaW and team; You did it (allowed modules to run code in apps w/ zygote injection / Xhook) first! 👏 PW
    9
    ...snip...
    Just meant nandroid restore should be usable to roll back since you seemed concerned you'd 'lose ability to use nandroid backup' & would need to restore beloved A10 setup / mods piece by piece!...
    ...snip...
    A LOT of config is stored in the settings. For example:
    PHP:
    settings put global "window_animation_scale" "0.5";
    Because I use to build ROMs from source and therefore clean flash my devices a lot, I built a method to extract and reinstate all my config, to be used selectively and in combination with normal back-up apps, to reinstate my device as close to its previous state without manually hunting and seeking all the settings, after a clean flash.

    I automated this task as a method within the app TeMeFI and can be found under Current State>Settings>Generate Set All
    7
    Victory! What did I Will Merv!😉
    6
    I'm going to update my Samsung S21 from Android 11 One UI 3.1 to Android 12 One UI 4, can someone confirm that the standard firmware update procedure (patched system image + home_csc) will work?

    Thank you!
    Broken in current released builds. Fix merged in Magisk master repo downstream for S21
    https://github.com/topjohnwu/Magisk/issues/5162#issuecomment-1004475802
    + many other Sammy models two weeks ago.

    PR: https://github.com/topjohnwu/Magisk/pull/5139
    Committed:
    https://github.com/topjohnwu/Magisk/commit/19182ffddf6f7c87bacab4b9f91cfaec3ee79537

    John commented on Sammy's 'solution' for broken fstab in device tree (MA content):
    www.twitter.com/topjohnwu/status/1475985579036667904

    You'll need to wait for next TJW build (Canary or Beta), but you can try latest test build from artifacts here:
    https://github.com/topjohnwu/Magisk/actions/runs/1632403163
    Also, fix is merged in latest vvb2060 Alpha builds.
    https://github.com/vvb2060/Magisk/commit/19182ffddf6f7c87bacab4b9f91cfaec3ee79537

    I'm going to update my Samsung S21 from Android 11 One UI 3.1 to Android 12 One UI 4, can someone confirm that the standard firmware update procedure (patched system image + home_csc) will work?
    Nb. Standard procedure is to flash patched firmware file as AP + HOME_CSC + BL + CP as per instruction:
    • Never just flash only AP, or else Odin may shrink your /data filesystem size. Flash AP + BL + CP + HOME_CSC when upgrading.
    👀 PW
  • 1071
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p