Magisk General Support / Discussion

Search This thread

zgfg

Senior Member
Oct 10, 2016
7,166
4,618
For those who still want MagiskHide with the new Magisk (seems that Alpha will soon remove MagiskHide to provide only DenyList as in Canary) - App Manager Debug root app, v2.7.0 b1667)

Note: I didn't test since I'm using DenyList (with Shamiko)
 

Attachments

  • 1.jpg
    1.jpg
    383.7 KB · Views: 77
  • 2.jpg
    2.jpg
    347.9 KB · Views: 77
  • 3.jpg
    3.jpg
    425.4 KB · Views: 76
Last edited:

traversone

Senior Member
Feb 18, 2019
161
53
Good to know. In fact, I still keep that Alpha apk and my corresponding patched boot.img (just in case)

I have updated through all the later Alpha versions, updated LSPosed, HMA, installed and updated Shamiko

Sometime among those updates I started to observe instabilities. I never observed loosing the root but occasionally it loop-boots two or three times (soft- rebooting) before booting successfully. One day it rebooted five times to TWRP (I didn't do anything there except wiping Cache and Dalwik trying to 'help') until it finally rebooted successfully to the system

Since it does not happen on every reboot and since (as mentioned above) I updated various components, I was unable to point to anything specific (Alpha, Shamiko...) but my hunch was that it's maybe related to Magisk (thinking that I saw it first time upon updating Alpha from that version, before all the later updates)

But without a hard proof I didn't want to charge anything or anybody
unfortunately, after re-enabling mobile data/wifi this morning, again root is lost.

going to try latest alpha with zygisk and "app manager" acting as magisk hide
 

traversone

Senior Member
Feb 18, 2019
161
53
For those who still want MagiskHide with the new Magisk (seems that Alpha will soon remove MagiskHide to provide only DenyList as in Canary) - App Manager Debug root app, v2.7.0 b1667)

Note: I didn't test since I'm using DenyList (with Shamiko)
"could not enable Magisk Hide" comes up when trying to use this feature

of course, I am on Zygisk coherently with the general assumption said before
 

zgfg

Senior Member
Oct 10, 2016
7,166
4,618
"could not enable Magisk Hide" comes up when trying to use this feature

of course, I am on Zygisk coherently with the general assumption said before
I don't know, not using. You can ask in TG channel

However, I would at least try with Zygisk disabled (if that's like the old school MagiskHide)
 
Last edited:

butilka

New member
Jan 18, 2022
2
1
If your phone is an old model, launched before A11, then there should be the proper TWRP for the phone and it should work
It worked, before I've had LineageOS installed; Now fasload doesn't do anything to that device.

But what do you mean that it fails from Fastboot.
Does it fail to flash and with what error, or it flashes but then fails to boot?
It displayed < waiting for any device > as if no device is connected.
ADB is able to catch this device, and any other.

Anyhow, I've managed to root the device with the LineageOS recovery screen and a renamed Magisk package:

1) Download Magisk-v23.0.apk to your desktop computer (where ADB is installed)
2) Rename Magisk-v23.0.apk to Magisk-v23.0.zip
3) Enter to recovery mode, on your phone
4) Apply update > Apply from ADB
5) Execute adb sideload Magisk-v23.0.zip
6) Restart
 
Last edited:
  • Like
Reactions: J.Michael

zgfg

Senior Member
Oct 10, 2016
7,166
4,618
Module Update Notifications

...So we're getting getting active module.zipUrl with new updateJson! 😛 🎉
https://github.com/topjohnwu/Magisk/issues/4908#issuecomment-1015911378

Thanks vvb2060. 👍 PW
If I recall correctly, time ago (when Repo was still alive, snd earlier) there was support field in the module.prop, providing a way for developer to put a link to his Github page, XDA thread or anything where users could further find info about downloading the new version, etc

Unfortunately, it was removed (I never understood why was removing good for or neccessary)

Currently, developer can put URL to the description field but it's not clickable (it cannot be even copied from the Modules page in the Magisk app)

IMO, two clickbable fields like support and download would sufficce
 

Attachments

  • IMG_20220119_115946.jpg
    IMG_20220119_115946.jpg
    183.8 KB · Views: 49
Last edited:
  • Like
Reactions: rodken

pndwal

Senior Member
For those who still want MagiskHide with the new Magisk (seems that Alpha will soon remove MagiskHide to provide only DenyList as in Canary) - App Manager Debug root app, v2.7.0 b1667)

Note: I didn't test since I'm using DenyList (with Shamiko)
I've had AM for some time, but public (6.2.1 now), not debug version...

Some nice root features incl. 'Block activities, broadcast receivers, services, or providers', but didn't hide root...
https://github.com/MuntashirAkon/AppManager/tree/master

Just updated to debug 2.7.0 to test AM debug's Magisk hidelist feature, and it seems this app simply intercepts hidelist / DOESN'T do hiding itself... but may be useful to identify isolated processes for apps in Magisk hidelist.

Anyway, this was a mistake, at least w/ my Alpha setup w/ Zygisk; After installing AM debug I checked Magisk app and couldn't access Configure denylist (greyed out)... Discovered I can access it by enforcing denylist then closing app and opening again. List opens / isn't greyed after this. I can then close and open again, but if I disable Enforce denylist it is still accessable one time only. After exiting Configure dentist it is greyed out again and nothing enables it again except.closing / re-opening app w/ denylist enforced...

Since this I have uninstalled AM debug, deleted / reinstalled Magisk app several times, deleted all in /data/adb except modules and rebooted to reconfigure Magisk, uninstalled (removed) and reinstated Shamiko etc to no avail... The behaviour remains the same, although hiding / Magisk etc seems otherwise to work normally... Guessing I will need factory reset to fix strange new denylist behaviour...

Anyway, AFAICS, this is NOT a MagiskHide alternative. What's more, it's uninstall scripts may be buggy / fail to revert all changes... Fair warning... PW
 
  • Like
Reactions: rodken

traversone

Senior Member
Feb 18, 2019
161
53
I've had AM for some time, but public (6.2.1 now), not debug version...

Some nice root features incl. 'Block activities, broadcast receivers, services, or providers', but didn't hide root...
https://github.com/MuntashirAkon/AppManager/tree/master

Just updated to debug 2.7.0 to test AM debug's Magisk hidelist feature, and it seems this app simply intercepts hidelist / DOESN'T do hiding itself... but may be useful to identify isolated processes for apps in Magisk hidelist.

Anyway, this was a mistake, at least w/ my Alpha setup w/ Zygisk; After installing AM debug I checked Magisk app and couldn't access Configure denylist (greyed out)... Discovered I can access it by enforcing denylist then closing app and opening again. List opens / isn't greyed after this. I can then close and open again, but if I disable Enforce denylist it is still accessable one time only. After exiting Configure dentist it is greyed out again and nothing enables it again except.closing / re-opening app w/ denylist enforced...

Since this I have uninstalled AM debug, deleted / reinstalled Magisk app several times, deleted all in /data/adb except modules and rebooted to reconfigure Magisk, uninstalled (removed) and reinstated Shamiko etc to no avail... The behaviour remains the same, although hiding / Magisk etc seems otherwise to work normally... Guessing I will need factory reset to fix strange new denylist behaviour...

Anyway, AFAICS, this is NOT a MagiskHide alternative. What's more, it's uninstall scripts may be buggy / fail to revert all changes... Fair warning... PW
totally aligned to you!

Actually we would need a fully working Zygisk/Shamiko (still unusable in Android 9 and with some issues in Android 10 on some ROMs)
 
  • Like
Reactions: pndwal

pndwal

Senior Member
If I recall correctly, time ago (when Repo was still alive, snd earlier) there was support field in the module.prop, providing a way for developer to put a link to his Github page, XDA thread or anything where users could further find info about downloading the new version, etc

Unfortunately, it was removed (I never understood why was removing good for or neccessary)

Currently, developer can put URL to the description field but it's not clickable (it cannot be even copied from the Modules page in the Magisk app)

IMO, two clickbable fields like support and download would sufficce
Yup, I recall at least the readme.md info was accessible in Magisk app. Since it looks like "description" string will be in use again I already asked if this will make readme.md or other info available in app again - this comment in the original issue (marked enhancement / now closed):
https://github.com/topjohnwu/Magisk/issues/4908#issuecomment-1015911378

... looks like we may have to wait / test to see if we actually get docs back with update notification... PW
 

zgfg

Senior Member
Oct 10, 2016
7,166
4,618
Yup, I recall at least the readme.md info was accessible in Magisk app. Since it looks like "description" string will be in use again I asked if this will make readme.md or other info available in app again - this comment in the original issue (marked enhancement / now closed):

looks like we may have to wait / test to see if we actually get docs back with update notification... PW
Thanks to @73sydney (PM) for pointing that Fox Mmm (still) supports support= field in the module prop

Taking a closer look, it supports also donate= field and it recognizes where the links point to (XDA, Github, Telegram, PayPal...), by providing then different icons
 

Attachments

  • 2.jpg
    2.jpg
    182.2 KB · Views: 47
  • 1.jpg
    1.jpg
    168.1 KB · Views: 48
  • 3.jpg
    3.jpg
    100.4 KB · Views: 44
  • 4.jpg
    4.jpg
    143.6 KB · Views: 47
  • 0.jpg
    0.jpg
    398.5 KB · Views: 43
Last edited:
  • Like
Reactions: ipdev

cognitivedissonance

Senior Member
Jan 11, 2012
646
201
Does anyone know how to get the latest BusyBox NDK module now that the Magisk Repo is down? I apparently don't have a saved version of the zip anywhere, and the github does not appear to have Releases.

EDIT: Apparently AdAway was blocking access to the Magisk repo. I am using the En Blu Go hosts list, so I would imagine that any of the En hosts lists would end up blocking it too.

I'm attempting to find what to whitelist in order to allow it to be accessed properly, but the AdAway DNS logger doesn't seem to be of much help. If anyone knows what I should whitelist, please let me know. Oh, and everyone make sure you have a backup of the BusyBox module, because if the Magisk Repo does get shut down and you don't have it, you're SOL from what I can tell.

EDIT 2: For anyone who finds this, I did figure out what I needed to whitelist to allow downloads from the Magisk Repo to complete successfully. It was "cdn.jsdelivr.com" (less the quotes.) It wasn't showing up in the DNS logger of AdAway the first bunch of times I tried it out, and so I was just whitelisting "*.github.com" but that didn't do it (and also isn't necessary since github.com urls are not actually blocked. I'm a bit hesitant to allow jsdelivr to stay on the whitelist b/c I'm not really sure what it is, so I'll look into it. Really though, I may just disable AdAway anytime I use Magisk if I'm trying to grab something from the [now abandoned] Repo.
 
Last edited:
  • Like
Reactions: ipdev and J.Michael

zgfg

Senior Member
Oct 10, 2016
7,166
4,618
Does anyone know how to get the latest BusyBox NDK module now that the Repo is down? I apparently don't have a saved version of the zip anywhere, and the github does not appear to have Releases.
1) Google for Github BusyBox NDK, download and install. Magisk app (still) supports installation of locally downloaded zip module files

2) As already asked & answered several times here, you can install (google for) Fox Magisk Module Manager app. More info, incl. about the new Alt(ernative) repository can be found starting from their Github page.
Use of Fox Mmm will replace for you the old (frozen) Repo and the removed support for Repo in the new Magisk 2301x app (Canary or Alpha)
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
7,166
4,618
I've had AM for some time, but public (6.2.1 now), not debug version...

Some nice root features incl. 'Block activities, broadcast receivers, services, or providers', but didn't hide root...
https://github.com/MuntashirAkon/AppManager/tree/master

Just updated to debug 2.7.0 to test AM debug's Magisk hidelist feature, and it seems this app simply intercepts hidelist / DOESN'T do hiding itself... but may be useful to identify isolated processes for apps in Magisk hidelist.

Anyway, this was a mistake, at least w/ my Alpha setup w/ Zygisk; After installing AM debug I checked Magisk app and couldn't access Configure denylist (greyed out)... Discovered I can access it by enforcing denylist then closing app and opening again. List opens / isn't greyed after this. I can then close and open again, but if I disable Enforce denylist it is still accessable one time only. After exiting Configure dentist it is greyed out again and nothing enables it again except.closing / re-opening app w/ denylist enforced...

Since this I have uninstalled AM debug, deleted / reinstalled Magisk app several times, deleted all in /data/adb except modules and rebooted to reconfigure Magisk, uninstalled (removed) and reinstated Shamiko etc to no avail... The behaviour remains the same, although hiding / Magisk etc seems otherwise to work normally... Guessing I will need factory reset to fix strange new denylist behaviour...

Anyway, AFAICS, this is NOT a MagiskHide alternative. What's more, it's uninstall scripts may be buggy / fail to revert all changes... Fair warning... PW
Sorry, I didn't fully understand that story, but:

- Shamiko reads from Configure DenyList

-To use Shamiko, Enforce DenyList must be disabled

- While Enforce DenyList is disabled, Confugure DenyList is grayed out

That's the known ('normal') behavior. And that's why users ask that Configure DenyList should not be grayed out while Enforce DenyList is disabled

Because it's troublesome if you need to make a change in DenyList, when you use Shamiko:

You must first temporarily enable Enforce DenyList, for Configure DenyList to become functional.
Finally, upon reconfiguring DL, you must disable again Enforce DL, for Shamiko

---

Anyway, I also tried to use AM Debug v2.7.0 1667 but no success regarding to MgiskHide.
I tried with various combinations in Magisk Alpha app, always rebooting upon, before retrying with AM

When I tried e.g. to enable MagiskHide for gms and gms.unstable from AM (check boxes), AM always reported an error

Besides, it asked me do I want to use my Google account or some XSpace account (?), but failed for both

Maybe we still don't know how to properly use it for MagiskHide

Otherwise, AM seems to be a powerful app manager. However, I'm accustomed to use other app mngrs, most recently Packet Manager (less powerful but enough for what I needed), hence I stopped playing with AM ;-(

Btw, when I uninstalled the AM, I have no artefacts and no issues with Magisk, Magisk app, Zygisk, Shaniko, DenyList - everything works for me as before I tried AM
 
Last edited:
  • Like
Reactions: VerticalCobra

pndwal

Senior Member
Sorry, I didn't fully understand that story, but:

- Shamiko reads from Configure DenyList

-To use Shamiko, Enforce DenyList must be disabled

- While Enforce DenyList is disabled, Confugure DenyList is grayed out
Not any more... Reverse is true; see screenshots.
That's the known ('normal') behavior. And that's why users ask that Configure DenyList should not be grayed out while Enforce DenyList is disabled
But I get access (not grey) w/ Enforce disabled, as shown...
Because it's troublesome if you need to make a change in DenyList, when you use Shamiko:

You must first temporarily enable Enforce DenyList, for Configure DenyList to become functional.
Finally, upon reconfiguring DL, you must disable again Enforce DL, for Shamiko
Of course, and that's exactly how it always used to behave, but not since using AM debug!... I cannot get standard behaviour back!...

Once greyed out if I Enforce denylist it stays grey... I have to close magisk app and reopen to get Configure denylist access as I said!! ... And after that I can access it with Shamiko working and denylist NOT enforced too, but only once... Is this normal???

Here you go:
Screenshot_2022-01-20-07-14-37-806_com.topjohnwu.magisk.jpg Screenshot_2022-01-20-07-33-44-639_com.topjohnwu.magisk.jpg
... Expected behaviour reversed!

---

Anyway, I also tried to use AM Debug v2.7.0 1667 but no success regarding to MgiskHide.
I tried with various combinations in Magisk Alpha app, always rebooting upon, before retrying with AM

When I tried e.g. to enable MagiskHide for gms and gms.unstable from AM (check boxes), AM always reported an error

Besides, it asked me do I want to use my Google account or some XSpace account (?), but failed for both

Maybe we still don't know how to properly use it for MagiskHide

Otherwise, AM seems to be a powerful app manager. However, I'm accustomed to use other app mngrs, most recently Packet Manager (less powerful but enough for what I needed), hence I stopped playing with AM ;-(
It just doesn't hide; simply accesses hidelist to show which hidden apps have isolated processes for information purposes... I believe that's what's described in documentation too... PW
 
Last edited:

pndwal

Senior Member
Add new build command avd_patch
https://github.com/topjohnwu/Magisk/commit/20ef724fad5e0cbf2ee679406f2333eb17f9121b

I wondered about this / why so much effort! -
John Wu, 3h

Last night I spent an immense amount of time adding support for MagiskInit end-to-end integration testing using the Android Emulator.

As older hardware is more and more difficult to find nowadays, this is important to ensure no regressions will happen...

MagiskInit is *the* most complex, error prone, and difficult to debug part of Magisk. Any minor failures there will make a device simply "stop booting".

With these changes, we can finally test most boot configurations on a PC running emulators w/o the need of physical devices.

This is part of the effort to make Magisk development more scalable, and in preparation for the imminent public release Winking face

There are some significant MagiskInit refactoring planned down the pipeline. Without this infra in place, I don't think I will feel comfortable doing it.
... And now I understand, what you tried to say to me ...
And how you suffered for your sanity
And how you tried to set them free
They would not listen, they did not know how
Perhaps they'll listen now...
They would not listen, they're not listening still
Perhaps they never will...
PW
 

zgfg

Senior Member
Oct 10, 2016
7,166
4,618
Not any more... Reverse is true; see screenshots.

But I get access (not grey) w/ Enforce disabled, as shown...

Of course, and that's exactly how it always used to behave, but not since using AM debug!... I cannot get standard behaviour back!...

Once greyed out if I Enforce denylist it stays grey... I have to close magisk app and reopen to get Configure denylist access as I said!! ... And after that I can access it with Shamiko working and denylist NOT enforced too, but only once... Is this normal???

Here you go:
View attachment 5512933 View attachment 5512937
... Expected behaviour reversed!


It just doesn't hide; simply accesses hidelist to show which hidden apps have isolated processes for information purposes... I believe that's what's described in documentation too... PW
New AM Debug, v2.7.0 (1669) relesed but no change (despite some fixes claimed on TG)

1) I don't believe that AM is only for monitoring MagiskHide hide status.
Why does it have check-boxes?
Why it reports a fiailure to enable/disable Magisk Hide upon I check-in or check out MagiskHide.
If only to display the status, it should not have (active) check-boxes

2) I see now the problem you reported. But only upon I had Zygisk enabled when playing with MagiskHide in AM.
Indeed, upon I enable Enforce DL, then Confugure DL remains grayed-out.
It's not necessary to re-open Magisk app, it's enough to reopen Magisk Settings page - then Configure DL becomes un-grayed (as expected)

Similarly in the opposite direction, upon disabling Enforce DL, then Configure DL remains functional until you re-open Magisk app, or just re-open Magisk app settings, or open Configure DL for once - only then Configure DL will become grayed-out as expected

To make things worse, uninstalling the AM, and even uninstalling and reinstalling Magisk app does not restore the original/normal behavior of Magisk Alpha app - too much work to uninstall Magisk or to delete /data/adb folder to see would it fix

Definitely a BAD idea to play with AM and its MagiskHide 'functionality', it doesn't work and it breaks something with Enforce DL/Configure DL functionality in Magisk app
 

Attachments

  • enable.jpg
    enable.jpg
    275.4 KB · Views: 35
  • disable.jpg
    disable.jpg
    259.3 KB · Views: 34
Last edited:
  • Like
Reactions: rodken

cognitivedissonance

Senior Member
Jan 11, 2012
646
201
1) Google for Github BusyBox NDK, download and install. Magisk app (still) supports installation of locally downloaded zip module files

2) As already asked & answered several times here, you can install (google for) Fox Magisk Module Manager app. More info, incl. about the new Alt(ernative) repository can be found starting from their Github page.
Use of Fox Mmm will replace for you the old (frozen) Repo and the removed support for Repo in the new Magisk 2301x app (Canary or Alpha)
Haha, I actually did exactly what you listed in (1) and crawled all over both the Magisk Repo and the Osmosis BusyBox Source Repo for the better part of an hour trying to figure out where they may have hidden the zips and then trying to figure out if someone maybe dropped guide on how to build my own. Guess I should've remembered Occam's Razor and just kept on with the Google search, because it turns out the third link down was the right one. Whoops.

While I was able to access the Repo through Magisk still after disabling AdAway, I do appreciate the mention of Fox; I'll have to read up on it. I am guessing it's may not be the new replacement that allows for a URL pointing to a JSON in module.prop that John mentioned in his tweet, but either way it's great to have an alternative to the unmaintained repo in the meantime.

Thanks again for your help!


Guys (especially @zgfg and @pndwal), big thumb up 👍🏻 for your patience in explaining everything gazillion times over and over 😂
I'd encourage anyone who makes comments like this to take a second and consider the impact. Thanking someone who tirelessly helps others is a bigtime thumbs-up, but by pairing it up with a snarky tones aimed at those receiving the help, it introduces a negative dynamic that ends up chasing away people away; people who otherwise might have paid it forward, or left a comment that helped someone else (both things that make this place so great.) I speak from experience, because I saw this exact thing happen when I was much more active here, and it did chase people away, which was a shame, because some of them were battling issues that probably were fixable.

Trust me, I completely understand how tiring it can be seeing people ask the same questions over and over, but throwing shade isn't going to do anyone any good; all it accomplishes is inadvertently diminishing the hard work of those helping others, and in this particular case it ended up tarnishing an otherwise very nice complement. I say all this not to condemn you or anyone else, because I've said things very similar myself in the past; I mention it because I hope that by sharing a perspective that I've gained over my years here, it helps promotes positivity, results in good feelings all around, and possibly keeps a few more people here paying it forward.

Anyway, thank you again Zgfg and everyone else who helps out in this forum. You're all awesome and I hope you all have great days!
 
Last edited:

Top Liked Posts

  • There are no posts matching your filters.
  • 7
    Latest Shamiko:

    Shamiko v0.5.0

    0.5.0​

    • Better hiding Zygisk
    "... Momo enjoys helping Shamiko become stronger in all aspects despite Shamiko's goal of defeating her..."

    👍 PW
    6
    Latest Official TJW debug Canary Magisk:

    Magisk (985249c3) (24309)​

    Pixel 6 Android 13 Beta 2 support is here!

    • [App] Support requesting root from non app process
    • [App] Fix deadlocking a background thread on non-root devices
    • [MagiskInit] Support GKIs with no ramdisk (Pixel 6 Android 13)

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [MagiskInit] Support GKIs with no ramdisk (Pixel 6 Android 13)
    • [App] [MagiskSU] Properly support apps using shared UID
    • [MagiskSU] Fix a possible crash in magiskd
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/56da1fe5430b2c04701ce73d1658ba698ee92283/notes.md

    👍 PW
    6
    Looks like major libsu release is now imminent; most fixes are now merged.

    Should see major stability improvements in Magisk and root app implementation... Should see new commits for Magisk proper again soon too!

    John has made some major libsu changes (see libsu GitHub).

    Here are extra comments on vvb2060 fixes from her TG (Chinese translated....


    👀 PW
    libsu 5.0.0 is out!

    libsu/CHANGELOG.md

    5.0.0​

    Check the updated Javadoc and the example app for details on how to use the remote file system in the new nio module.

    New Features​

    • Introduce a new module: nio
      • Includes file system implementations for local and remote processes
      • New FileSystemManager class to access either local or remote file system implementations
      • New ExtendedFile class to extend functionality of the old Java File API
    • [core] New API Shell.isAppGrantedRoot() returns a nullable Boolean:
      • true if a root shell has been created
      • false if it has been determined that root access is impossible to get
      • null if the library has not, or could not determine the current root grant state. Future invocations of this method may return a non-null value if the library gained more information during shell creation.
    • [core] New API Shell.Builder.setContext(context): allow the developer to explicitly provide a Context object
    • [io] SuFile is updated to also extend ExtendedFile, which adds some new features and APIs

    Deprecation​

    • Version 5.0.0 will be the final release of the busybox module. If you cannot remove the usage of the module, you can pin the busybox module to version 5.0.0, as it is updated to be fully self contained, making it guaranteed to work with future libsu versions.
    • Usage of SuFile/SuFileOutputStream/SuFileInputStream/SuRandomAccessFile is discouraged. Although these APIs will remain for the foreseeable future, please migrate to use RootService + the nio module for all root I/O operations.
    • Shell.rootAccess() is deprecated. Please switch to use the more accurate Shell.isAppGrantedRoot() API

    John Wu, 2h

    Major libsu update 5.0.0!

    Introduces a new module "nio" to perform I/O operations through root services, moving away from the error prone, inefficient shell command backed I/O the library used to provide.

    It's already using splice under-the-hood. There is already some Linux magic!

    New readme etc. Read how you can Attach Debugger to Android Process in Root Services and more!
    https://github.com/topjohnwu/libsu

    👏👍🥳

    ... Back to regular Magisk programming... PW
    6

    Latest Official TJW debug Canary Magisk:​

    Magisk (cc79a96f) (24307)​

    • [App] Update libsu with 100% new I/O layer
    • [MagiskInit] Mock enforce file with regular file to prevent possible race condition
    • Switch normal NDK with ONDK, preparing the toolchain to introduce Rust

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [App] [MagiskSU] Properly support apps using shared UID
    • [MagiskSU] Fix a possible crash in magiskd
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/a66dfce1bf88a70e86bf86c5427b1c58e71a4fc2/notes.md

    👍 PW
    5

    Latest Official TJW debug Canary Magisk:​

    Magisk (42e5f515) (24308)​

    • Several minor bug fixes

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [App] [MagiskSU] Properly support apps using shared UID
    • [MagiskSU] Fix a possible crash in magiskd
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/ba1cf1081e1fe6fce7fda626dfdb0a0faab27d4e/notes.md

    👍 PW
  • 1077
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p